[PATCH v2 2/2] target/riscv: add trace in riscv_raise_exception()

2025-01-06 Thread Daniel Henrique Barboza
When using system mode we can get the CPU traps being taken via the 'riscv_trap' trace or the "-d int" qemu log. User mode does not a way of logging/showing exceptions to users. Add a trace in riscv_raise_exception() to allow qemu-riscv(32/64) users to check all exceptions being thrown. This is pa

Re: [PATCH v11 1/2] tpm: convert tpmdev options processing to new visitor format

2025-01-06 Thread Philippe Mathieu-Daudé
On 12/12/24 18:05, James Bottomley wrote: Instead of processing the tpmdev options using the old qemu options, convert to the new visitor format which also allows the passing of json on the command line. Signed-off-by: James Bottomley Tested-by: Stefan Berger Reviewed-by: Stefan Berger --- v

[PATCH] hw/ufs: Fix legacy single doorbell support bit

2025-01-06 Thread Jeuk Kim
QEMU UFS has supported both legacy single doorbell and MCQ, but the LSDBS value was incorrectly set. This change corrects the LSDBS value to 0. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c index 8d26d1379

Re: [PATCH] hw/ufs: Adjust value to match CPU's endian format

2025-01-06 Thread Philippe Mathieu-Daudé
On 7/1/25 08:02, Keoseong Park wrote: In ufs_write_attr_value(), the value parameter is handled in the CPU's endian format but provided in big-endian format by the caller. Thus, it is converted accordingly. Fixes: 7c85332a2b3 ("hw/ufs: minor bug fixes related to ufs-test") Signed-off-by: Keo

KVM/QEMU community call 07/01/2025

2025-01-06 Thread Alex Bennée
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 07/01/2025 14:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 0/4] cpu: Drop CPUState::nr_cores

2025-01-06 Thread Xiaoyao Li
On 12/31/2024 12:11 AM, Igor Mammedov wrote: On Thu, 5 Dec 2024 09:57:12 -0500 Xiaoyao Li wrote: The series is motivated by auditing the usage of CPUState::nr_cores and CPUState::nr_threads, which is motivated by [1]. The initial goal is to initialize nr_threads and nr_cores earlier for x86,

Re: [PATCH v3 3/3] virtio: Convert feature properties to OnOffAuto

2025-01-06 Thread Lei Yang
Hi Akihiko I hit qemu core dump when I tested this series of patches with virtio-net regression tests, and based on the test result this bug can be reproduced by just booting a guest. For the details of core dump info please review the attachment. Regards Lei On Sat, Jan 4, 2025 at 3:37 PM Akih

Re: [PATCH v2 07/10] i386/cpu: Hoist check of CPUID_EXT3_TOPOEXT against threads_per_core

2025-01-06 Thread Xiaoyao Li
On 12/27/2024 4:07 PM, Zhao Liu wrote: On Thu, Dec 19, 2024 at 06:01:22AM -0500, Xiaoyao Li wrote: Date: Thu, 19 Dec 2024 06:01:22 -0500 From: Xiaoyao Li Subject: [PATCH v2 07/10] i386/cpu: Hoist check of CPUID_EXT3_TOPOEXT against threads_per_core X-Mailer: git-send-email 2.34.1 Now it chan

Re: [PATCH v2 2/2] hw/sd/sdhci: Fix data transfer did not complete if data size is bigger than SDMA Buffer Boundary

2025-01-06 Thread Bernhard Beschow
Am 13. Dezember 2024 03:12:05 UTC schrieb Jamin Lin via : >According to the design of sdhci_sdma_transfer_multi_blocks, if the >"s->blkcnt * 512" was bigger than the SDMA Buffer boundary, it break the >while loop of data transfer and set SDHC_NISEN_DMA in the normal interrupt >status to notify t

Re: [PATCH 07/73] tcg: Add TCGType argument to tcg_op_supported

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 2 +- tcg/tcg.c | 10 ++ 2 files changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 01/10] i386/cpu: Extract a common fucntion to setup value of MSR_CORE_THREAD_COUNT

2025-01-06 Thread Philippe Mathieu-Daudé
On 7/1/25 05:34, Xiaoyao Li wrote: On 1/7/2025 12:31 PM, Xiaoyao Li wrote: On 1/3/2025 4:52 PM, Philippe Mathieu-Daudé wrote: On 28/12/24 18:37, Philippe Mathieu-Daudé wrote: On 19/12/24 12:01, Xiaoyao Li wrote: There are duplicated code to setup the value of MSR_CORE_THREAD_COUNT. Extract a

Re: [PATCH 09/73] target/arm: Use tcg_op_supported

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: Do not reference TCG_TARGET_HAS_* directly. Signed-off-by: Richard Henderson --- target/arm/tcg/translate-a64.c | 10 ++ target/arm/tcg/translate-sve.c | 2 +- target/arm/tcg/translate.c | 2 +- 3 files changed, 8 insertions(+), 6 del

Re: [PATCH 10/73] target/tricore: Use tcg_op_supported

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: Do not reference TCG_TARGET_HAS_* directly. Signed-off-by: Richard Henderson --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 14/73] target/i386: Use tcg_op_supported

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: Do not reference TCG_TARGET_HAS_* directly. Signed-off-by: Richard Henderson --- target/i386/tcg/emit.c.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] MAINTAINERS: Add me as the maintainer for ivshmem-flat

2025-01-06 Thread Philippe Mathieu-Daudé
On 7/1/25 02:56, Gustavo Romero wrote: Add me as the maintainer for the ivshmem-flat device. Signed-off-by: Gustavo Romero --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] hw/ufs: Adjust value to match CPU's endian format

2025-01-06 Thread Keoseong Park
In ufs_write_attr_value(), the value parameter is handled in the CPU's endian format but provided in big-endian format by the caller. Thus, it is converted accordingly. Signed-off-by: Keoseong Park --- hw/ufs/ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ufs/ufs.c

Re: [PATCH 03/73] tcg: Add TCGType argument to tcg_emit_op, tcg_op_insert_*

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: In some places we have a ready type to give. In others, like tcg-op.c, simply pass 0 for now. Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 8 +--- include/tcg/tcg.h| 6 +++--- tcg/optimize.c | 20 +++-

Re: [PATCH v2 05/10] i386/topology: Introduce helpers for various topology info of different level

2025-01-06 Thread Xiaoyao Li
On 12/27/2024 3:51 PM, Zhao Liu wrote: +static inline unsigned x86_module_per_pkg(X86CPUTopoInfo *topo_info) +{ +return topo_info->modules_per_die * topo_info->dies_per_pkg; +} + +static inline unsigned x86_cores_per_pkg(X86CPUTopoInfo *topo_info) +{ +return topo_info->cores_per_module *

Re: [PATCH 04/73] tcg: Add TCGType argument to tcg_gen_op*

2025-01-06 Thread Philippe Mathieu-Daudé
On 2/1/25 19:05, Richard Henderson wrote: This covers the balance of opcode generation. At this point, TCGOp.type is initialized. Signed-off-by: Richard Henderson --- tcg/tcg-internal.h | 13 ++--- tcg/tcg-op-ldst.c | 26 +- tcg/tcg-op.c | 119 --

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2025-01-06 Thread Zhangfei Gao
Hi, Joao On Fri, Jun 23, 2023 at 5:51 AM Joao Martins wrote: > > Hey, > > This series introduces support for vIOMMU with VFIO device migration, > particurlarly related to how we do the dirty page tracking. > > Today vIOMMUs serve two purposes: 1) enable interrupt remaping 2) > provide dma transla

Re: [PATCH v4 1/2] virtio-net: Convert feature properties to OnOffAuto

2025-01-06 Thread Akihiko Odaki
On 2025/01/06 16:13, Lei Yang wrote: On Sat, Jan 4, 2025 at 3:50 PM Akihiko Odaki wrote: Some features are not always available, and virtio-net used to disable them when not available even if the corresponding properties were explicitly set to "on". Convert feature properties to OnOffAuto so

Re: [PATCH] qemu-ga: Optimize freeze-hook script logic of logging error

2025-01-06 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Dec 25, 2024 at 10:37 AM Dehan Meng wrote: > Make sure the error log of fsfreeze hooks > when freeze/thaw/snapshot could be logged > to system logs if the default logfile of > qga can't be written or other situations > > Signed-off-by: Dehan Meng > --- >

Re: [PATCH v2 1/1] qga: Add log to guest-fsfreeze-thaw command

2025-01-06 Thread Konstantin Kostiuk
ping On Mon, Dec 16, 2024 at 5:47 PM Konstantin Kostiuk wrote: > Signed-off-by: Konstantin Kostiuk > --- > qga/commands-posix.c | 2 ++ > qga/commands-win32.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 636307bedf..359a56be81

Re: [PATCH 0/2] Disable unavailable features on older macOS

2025-01-06 Thread Peter Maydell
On Mon, 23 Dec 2024 at 04:10, Joelle van Dyne wrote: > Some features require APIs introduced in a recent version of macOS. Currently, > this is not checked anywhere and so either the build will fail (if building > with > an older version of Xcode) or will throw a warning and then crash if run on

[Bug 2072564] Re: qemu-aarch64-static segfaults running ldconfig.real (amd64 host)

2025-01-06 Thread Christian Ehrhardt 
Hi, this came up in our dormant bugs checker ... There was no reply from upstream yet, but I agree that a blunt revert might be wrong unless they agree. Sergio reached out, but probably needs to kindly ask again with some extra noise. -- You received this bug notification because you are a memb

Re: [PULL 25/41] rust: qom: put class_init together from multiple ClassInitImpl<>

2025-01-06 Thread Peter Maydell
On Mon, 6 Jan 2025 at 11:54, Paolo Bonzini wrote: > Il gio 2 gen 2025, 18:04 Philippe Mathieu-Daudé ha > scritto: >> Pre-existing, but since it appears on this patch, Rust device models >> should not implement this legacy interface. If a non-Rust parent >> implements it, I think we should conver

Re: [PATCH] qmp: update vhost-user protocol feature maps

2025-01-06 Thread Jonah Palmer
On 12/22/24 4:13 AM, Michael Tokarev wrote: 16.12.2024 20:30, Jonah Palmer wrote: ... Signed-off-by: Jonah Palmer Should this be a Reviewed-by instead? Thanks, /mjt Oof, yes, it should've been. My apologies, I was on vacation and only saw this just now.

<    1   2