On Wed, Nov 6, 2024 at 3:30 PM Noah Goldstein wrote:
>
> On Wed, Nov 6, 2024 at 3:10 PM Richard Henderson
> wrote:
> >
> > On 11/6/24 18:13, Noah Goldstein wrote:
> > > Question about impl regarding handling of `-execfd` with/without a
> > > program name.
> > >
> > > 1) `-execfd` + program name
Reviewed-by: Konstantin Kostiuk
On Wed, Nov 6, 2024 at 3:38 PM Daniel P. Berrangé
wrote:
> On Wed, Nov 06, 2024 at 04:41:34PM +0800, Dehan Meng wrote:
> > It's now only freed at the end of the function.
> >
> > Signed-off-by: Dehan Meng
> > ---
> > qga/commands-linux.c | 7 ++-
> > 1 file
On 10/30/24 21:04, Pierrick Bouvier wrote:
For now, it was only possible to build plugins using GCC on Windows. However,
windows-aarch64 only supports Clang.
The first patches (already posted and normally pulled) are fixes and
prerequisite to build plugins with meson. They are integrated here be
On Wed, Nov 6, 2024 at 6:47 PM Pierrick Bouvier
wrote:
> > for (int i = 0; i < MAX_SECTIONS; ++i) {
> > header->section_offsets[i] =
> > be64_to_cpu(header->section_offsets[i]);
> > +if (header->section_offsets[i] > OFF_MAX) {
>
> Maybe we could add a comment that section
The test_aarch64_sbsaref test is the test with the longest runtime
in our functional test suite. Split it into parts so that it can
be run on multiple CPUs in parallel.
For this we have to move the fetch_firmware() function out of the
class definition to be able to reuse it easily from the other t
When building on macOS 15 we get:
../../ui/cocoa.m:662:14: error: 'CVDisplayLinkCreateWithCGDisplay' is
deprecated:
first deprecated in macOS 15.0
- use NSView.displayLink(target:selector:),
NSWindow.displayLink(target:selector:),
or NSScreen.displayLink(target:selector:)
[-Wer
On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier
wrote:
> I noticed by --enable-debug in configure is a combination of enabling
> checks (enable-debug-tcg + graph + mutex), and deactivating optimizations.
>
> Would it be worth keeping the optimizations and runtime checks instead?
> This way, there wo
On Tue, 5 Nov 2024 at 16:59, Cédric Le Goater wrote:
>
> The following changes since commit 9a7b0a8618b1293d589a631183e80791ad7bf552:
>
> Merge tag 'pull-aspeed-20241104' of https://github.com/legoater/qemu into
> staging (2024-11-05 10:06:08 +)
>
> are available in the Git repository at:
>
On Tue, 5 Nov 2024 at 15:05, Richard Henderson
wrote:
>
> The following changes since commit 11b8920ed2093848f79f93d106afe8a69a61a523:
>
> Merge tag 'pull-request-2024-11-04' of https://gitlab.com/thuth/qemu into
> staging (2024-11-04 17:37:59 +)
>
> are available in the Git repository at:
On Tue, 5 Nov 2024 at 03:43, Warner Losh wrote:
>
> The following changes since commit daaf51001a13da007d7dde72e1ed3b06bc490791:
>
> Merge tag 'seabios-hppa-v17-pull-request' of
> https://github.com/hdeller/qemu-hppa into staging (2024-11-04 16:01:23 +)
>
> are available in the Git reposito
On 11/6/24 01:43, Thomas Huth wrote:
On 05/11/2024 19.27, Peter Xu wrote:
Report shows that commit 34a8892dec broke iotest 055:
https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org
FWIW, this patch also fixes a lot of other broken iotests (vmdk and vpc)
that occur when ru
On 11/6/24 09:09, Thomas Huth wrote:
When building QEMU with "--enable-debug" and running the tests
in parallel with "make -j$(nproc) check-functional", many tests are
still timing out due to our conservative timeout settings. Bump
the timeouts of the problematic tests and also increase the defau
On Wed, Nov 06, 2024 at 02:18:34PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> v7: update QAPI version 9.1 -> 9.2
Not like this. ypur patches are merged, pls post a fix patch on top.
Thanks!
> Vladimir Sementsov-Ogievskiy (3):
> qdev-monitor: add option to report GenericError from find_devic
On Thu, Nov 7, 2024 at 12:12 AM Paolo Bonzini wrote:
>
> Check for overflow to avoid that fseek() receives a sign-extended value.
>
> Cc: Dorjoy Chowdhury
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/osdep.h | 4
> hw/core/eif.c| 4
> 2 files changed, 8 insertions(+)
>
On Wed, 6 Nov 2024, Philippe Mathieu-Daudé wrote:
On 6/11/24 13:00, BALATON Zoltan wrote:
On Wed, 6 Nov 2024, Mark Cave-Ayland wrote:
Convert the next-kbd device from the legacy UI
qemu_add_kbd_event_handler()
function to use qemu_input_handler_register().
Signed-off-by: Mark Cave-Ayland
Rev
On Wed, Nov 06, 2024 at 03:12:20PM -0500, Steven Sistare wrote:
>
>
> On 11/4/2024 4:36 PM, David Hildenbrand wrote:
> > On 04.11.24 21:56, Steven Sistare wrote:
> > > On 11/4/2024 3:15 PM, David Hildenbrand wrote:
> > > > On 04.11.24 20:51, David Hildenbrand wrote:
> > > > > On 04.11.24 18:38, S
On 11/6/2024 3:41 PM, Peter Xu wrote:
On Wed, Nov 06, 2024 at 03:12:20PM -0500, Steven Sistare wrote:
On 11/4/2024 4:36 PM, David Hildenbrand wrote:
On 04.11.24 21:56, Steven Sistare wrote:
On 11/4/2024 3:15 PM, David Hildenbrand wrote:
On 04.11.24 20:51, David Hildenbrand wrote:
On 04.11.24
22.10.2024 15:46, Albert Esteve wrote:
VHOST_USER_BACKEND_SHARED_OBJECT_ADD and
VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE state
in the spec that they return 0 for successful
operations, non-zero otherwise. However,
implementation relies on the return types
of the virtio-dmabuf library, with opposit
On Tue, Nov 05, 2024 at 04:57:59PM +0100, Phil Dennis-Jordan wrote:
> When setting the APICBASE MSR to an illegal value, the APIC
> implementation will return an error. This change forwards that report
> to the guest as an exception rather than ignoring it when using the hvf
> accelerator.
>
Revi
On 11/4/2024 4:36 PM, David Hildenbrand wrote:
On 04.11.24 21:56, Steven Sistare wrote:
On 11/4/2024 3:15 PM, David Hildenbrand wrote:
On 04.11.24 20:51, David Hildenbrand wrote:
On 04.11.24 18:38, Steven Sistare wrote:
On 11/4/2024 5:39 AM, David Hildenbrand wrote:
On 01.11.24 14:47, Ste
Hi Sandipan,
On 11/6/24 1:58 AM, Sandipan Das wrote:
[snip]
>> @@ -4830,6 +4966,20 @@ static int kvm_get_msrs(X86CPU *cpu)
>> case MSR_P6_EVNTSEL0 ... MSR_P6_EVNTSEL0 + MAX_GP_COUNTERS - 1:
>> env->msr_gp_evtsel[index - MSR_P6_EVNTSEL0] = msrs[i].data;
>> break
Hi Zhao,
>
> You can define dependency like this:
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 3baa95481fbc..99c69ec9f369 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -1803,6 +1803,10 @@ static FeatureDep feature_dependencies[] = {
> .from = { FEAT_
On 5/11/24 13:30, Richard Henderson wrote:
On 11/5/24 13:04, Philippe Mathieu-Daudé wrote:
The Xilinx 'ethlite' device was added in commit b43848a100
("xilinx: Add ethlite emulation"), being only built back
then for a big-endian MicroBlaze target (see commit 72b675caac
"microblaze: Hook into the
[ Cc: qemu-block ]
Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben:
> The sum "cluster_index + count" may overflow uint32_t.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Frolov
Thanks, applied to the block branch.
While trying to check i
Am 01.11.2024 um 18:36 hat John Snow geschrieben:
> Various python tests in the "check-python-tox" test case on GitLab have
> begun failing due to newer package versions. This patch set corrects
> those issues and also improves the reliability of local developer tests
> which may be using these too
On Wed, Nov 6, 2024 at 5:25 PM Michael S. Tsirkin wrote:
>
> On Sat, Oct 26, 2024 at 03:59:59PM +0800, Cindy Lu wrote:
> > When using a VDPA device, it's important to ensure that the MAC
> > address is correctly set.
> > Add a new parameter in qemu cmdline to enable this check, default value
> > i
On 05/11/2024 19.27, Peter Xu wrote:
Report shows that commit 34a8892dec broke iotest 055:
https://lore.kernel.org/r/b8806360-a2b6-4608-83a3-db67e264c...@linaro.org
FWIW, this patch also fixes a lot of other broken iotests (vmdk and vpc)
that occur when running "make check SPEED=thorough".
On 11/5/24 18:02, Peter Maydell wrote:
The clang sanitizer complains about the code in the EOI handling
of openpic_cpu_write_internal():
UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1 ./build/clang/qemu-system-ppc -M
mac99,graphics=off -display none -kernel day15/invaders.elf
../../hw/intc/open
On Tue, 5 Nov 2024 21:12:00 +
Salil Mehta wrote:
> > From: Igor Mammedov
> > Sent: Tuesday, November 5, 2024 12:50 PM
> > To: Michael S. Tsirkin
> > Cc: qemu-devel@nongnu.org; Peter Maydell ;
> > Salil Mehta ; Ani Sinha ;
> > Eduardo Habkost ; Marcel Apfelbaum
> > ; Philippe Mathieu-
Hi Igor,
> From: qemu-arm-bounces+salil.mehta=huawei@nongnu.org arm-bounces+salil.mehta=huawei@nongnu.org> On Behalf Of Igor
> Mammedov
> Sent: Wednesday, November 6, 2024 1:57 PM
> To: Salil Mehta
>
> On Wed, 6 Nov 2024 13:03:30 +
> Salil Mehta wrote:
>
> > Checking `is
On 05/11/2024 17.42, Jared Rossi wrote:
Hi Thomas, Sebastian,
It looks like this is simply caused by the "is_cdrom" value only ever being set
to true. I think it is a one-line fix that just makes sure to initialize the
value to false each time we try a new device:
diff --git a/pc-bios/s390-ccw
On Tue, 5 Nov 2024 at 18:30, Peter Xu wrote:
> https://www.qemu.org/docs/master/devel/qapi-code-gen.html
>
> Sometimes, the behaviour of QEMU changes compatibly, but without a
> change in the QMP syntax (usually by allowing values or operations
> that previously resulted in
On Wed, Nov 06, 2024 at 12:09:27PM +, Mark Cave-Ayland wrote:
> Convert the next-kbd device from the legacy UI qemu_add_kbd_event_handler()
> function to use qemu_input_handler_register().
>
> Signed-off-by: Mark Cave-Ayland
> Reviewed-by: Thomas Huth
> ---
> hw/m68k/next-kbd.c | 163 ++
Daniel P. Berrangé writes:
> On Tue, Nov 05, 2024 at 03:08:21PM -0300, Fabiano Rosas wrote:
>> We current have a bunch of non-test functions in migration-test.c and
>> some others in migration-helpers.c. In order to split migration-test.c
>> into separate test binaries, these helpers need to go s
On Wed, Nov 06, 2024 at 11:07:18AM +0800, Zhao Liu wrote:
> In x86_cpu_filter_features(), if host doesn't support AVX10, the
> configured avx10_version should be marked as filtered regardless of
> whether prefix is NULL or not.
>
> Check prefix before warn_report() instead of checking for
> have_f
On Tue, 5 Nov 2024 at 10:44, Alex Bennée wrote:
>
> The following changes since commit daaf51001a13da007d7dde72e1ed3b06bc490791:
>
> Merge tag 'seabios-hppa-v17-pull-request' of
> https://github.com/hdeller/qemu-hppa into staging (2024-11-04 16:01:23 +)
>
> are available in the Git reposito
On Wed, 6 Nov 2024 at 14:21, Stefano Garzarella wrote:
> I think we should call that functions in the reverse order, so just add them
> in the error path, as we already do for other calls.
===
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index a70b7422b5..f168e1f02a 100644
--- a/hw/virtio/v
The sum "cluster_index + count" may overflow uint32_t.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Frolov
---
block/parallels.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 9205a08
On Tue, Nov 05, 2024 at 03:08:27PM -0300, Fabiano Rosas wrote:
> The migration-test.c file has become unwieldy large. It's quite
> confusing to navigate with all the test definitions mixed with hook
> definitions. The TLS tests make this worse with ifdef'ery.
>
> Since we're planning on having a s
Daniel P. Berrangé writes:
> This updates the libvirt-ci submodule to pull in various fixes,
> the most notable reducing native package sets in cross builds.
> Some packages were mistakenly marked as native, rather than
> foreign, in libvirt-ci. Fixing this causes our dockerfiles to
> pick up th
Add command to sync config from vhost-user backend to the device. It
may be helpful when VHOST_USER_SLAVE_CONFIG_CHANGE_MSG failed or not
triggered interrupt to the guest or just not available (not supported
by vhost-user server).
Command result is racy if allow it during migration. Let's not allo
On Wed, Nov 06, 2024 at 09:40:21AM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Nov 05, 2024 at 03:08:36PM -0300, Fabiano Rosas wrote:
> >> Allow qtests to be ran by subsystem. Some subsystems, such as
> >> migration, have a large number of tests and we could benefit fro
On Tue, Nov 05, 2024 at 03:08:36PM -0300, Fabiano Rosas wrote:
> Allow qtests to be ran by subsystem. Some subsystems, such as
> migration, have a large number of tests and we could benefit from
> being able to access them from make check without having to run the
> full set of qtests.
>
> This ad
Am 06.11.2024 um 16:45 hat Denis V. Lunev geschrieben:
> On 11/6/24 10:53, Kevin Wolf wrote:
> > [ Cc: qemu-block ]
> >
> > Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben:
> > > The sum "cluster_index + count" may overflow uint32_t.
> > >
> > > Found by Linux Verification Center (linuxtesti
On Wed, Nov 06, 2024 at 05:49:23PM +0530, Prasad Pandit wrote:
> On Tue, 5 Nov 2024 at 18:30, Peter Xu wrote:
> > https://www.qemu.org/docs/master/devel/qapi-code-gen.html
> >
> > Sometimes, the behaviour of QEMU changes compatibly, but without a
> > change in the QMP syntax (usual
On Wed, Nov 06, 2024 at 09:26:24AM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Nov 05, 2024 at 03:08:26PM -0300, Fabiano Rosas wrote:
> >> Put the common test code in a separate file. Leave only individual
> >> test functions and their static helpers in migration-test.c
This updates the libvirt-ci submodule to pull in various fixes,
the most notable reducing native package sets in cross builds.
Some packages were mistakenly marked as native, rather than
foreign, in libvirt-ci. Fixing this causes our dockerfiles to
pick up the cross arch package instead of native
v7: update QAPI version 9.1 -> 9.2
Vladimir Sementsov-Ogievskiy (3):
qdev-monitor: add option to report GenericError from find_device_state
vhost-user-blk: split vhost_user_blk_sync_config()
qapi: introduce device-sync-config
hw/block/vhost-user-blk.c | 27 ++--
hw/virtio/v
Am 30.08.2024 um 09:29 hat Markus Armbruster geschrieben:
> Stefan Hajnoczi writes:
>
> > The QMP device_add monitor command converts the QDict arguments to
> > QemuOpts and then back again to QDict. This process only supports scalar
> > types. Device properties like virtio-blk-pci's iothread-vq-
On Tue, Nov 05, 2024 at 03:08:20PM -0300, Fabiano Rosas wrote:
> Move the code that creates the guest binary out of migration-test and
> into the qtest/migration/ directory, along with the rest of the
> a-b-kernel code.
>
> That code is part of the basic infrastructure of migration tests, it
> sho
On Wed, Nov 06, 2024 at 10:05:59AM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Nov 05, 2024 at 03:08:27PM -0300, Fabiano Rosas wrote:
> >> The migration-test.c file has become unwieldy large. It's quite
> >> confusing to navigate with all the test definitions mixed with
On Wed, Nov 06, 2024 at 04:41:34PM +0800, Dehan Meng wrote:
> It's now only freed at the end of the function.
>
> Signed-off-by: Dehan Meng
> ---
> qga/commands-linux.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
On Wed, Nov 06, 2024 at 01:53:15PM +0100, Markus Armbruster wrote:
> I've been dealing with a health emergency in the family. I've had
> serious difficulties focusing, patch review in particular. I apologize
> for letting you all down.
>
> I tried to cc: the people who I believe are affected, bu
On Tue, Nov 05, 2024 at 03:08:21PM -0300, Fabiano Rosas wrote:
> We current have a bunch of non-test functions in migration-test.c and
> some others in migration-helpers.c. In order to split migration-test.c
> into separate test binaries, these helpers need to go somewhere
> else.
>
> To avoid mak
On Mon, 4 Nov 2024 at 17:35, Paolo Bonzini wrote:
>
> The following changes since commit 15195de6a93438be99fdf9a90992c4228527130d:
>
> ci: enable rust in the Fedora system build job (2024-10-30 16:30:56 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git
On Tue, 2024-11-05 at 12:55 -0800, Rick Edgecombe wrote:
> Binbin was looking at re-arranging the TDX dev branch to try to move these
> patches earlier in the series so we could get them finalized for the purpose
> of
> fully settling the uAPI for QEMU.
>
> I wonder if we should just post a very
On Tue, Nov 05, 2024 at 04:57:56PM +0100, Phil Dennis-Jordan wrote:
> Support for x2APIC mode was recently introduced in the software emulated
> APIC implementation for TCG. Enabling it when using macOS´s hvf
> accelerator is useful and significantly helps performance, as Qemu
> currently uses the
On Tue, Nov 05, 2024 at 08:24:17PM +0530, Sahil Siddiq wrote:
Hi,
Thank you for the review.
On 11/5/24 3:06 PM, Stefano Garzarella wrote:
On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
Linux commit v5.14-rc1~30^2~8 enabled the vp_vdpa driver to set the
To refer to a commit, p
On Tue, Nov 05, 2024 at 03:08:25PM -0300, Fabiano Rosas wrote:
> We currently have some environment validation to perform and flags to
> set during the initialization of the tests. To be able to add more
> migration test binaries, we'll need these tasks to be in their own
> function so they can be
Since the last keyboard device has now been converted over to use
qemu_input_handler_register(), the legacy qemu_add_kbd_event_handler() function
is now unused and can be removed.
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
---
include/ui/consol
Am 27.08.2024 um 21:27 hat Stefan Hajnoczi geschrieben:
> v3:
> - Duplicate drain_call_rcu() into hmp_device_add() because moving it into
> qdev_device_add_from_qdict turned out to be unsafe.
> v2:
> - Rename Patch 1 to indicate that we're avoiding QemuOpts rather than doing a
> full conversion
Convert the next-kbd device from the legacy UI qemu_add_kbd_event_handler()
function to use qemu_input_handler_register().
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Thomas Huth
---
hw/m68k/next-kbd.c | 163 ++---
1 file changed, 108 insertions(+), 55 d
On Tue, 5 Nov 2024 at 22:20, Salil Mehta wrote:
>
> HI Peter,
>
> > From: Peter Maydell
> > Sent: Monday, November 4, 2024 1:27 PM
> > To: Salil Mehta
> >
> > On Sun, 3 Nov 2024 at 15:25, Salil Mehta wrote:
> > >
> > > Extract common GIC and CPU interrupt wiring code to improve code
> >
From: Sunil V L
Add a new machine option called 'iommu-sys' that enables a
riscv-iommu-sys platform device for the 'virt' machine. The option is
default 'off'.
The device will use IRQs 36 to 39.
We will not support both riscv-iommu-sys and riscv-iommu-pci devices in
the same board in this first
MSIx support is added in the RISC-V IOMMU platform device by including
the required MSIx facilities to alow software to properly setup the MSIx
subsystem.
We took inspiration of what is being done in the riscv-iommu-pci device,
mainly msix_init() and msix_notify(), while keeping in mind that
riscv
Signed-off-by: Daniel Henrique Barboza
---
docs/specs/riscv-iommu.rst | 30 +++---
docs/system/riscv/virt.rst | 10 ++
2 files changed, 37 insertions(+), 3 deletions(-)
diff --git a/docs/specs/riscv-iommu.rst b/docs/specs/riscv-iommu.rst
index 463f4cffb6..b1538c9e
Daniel P. Berrangé writes:
> On Tue, Nov 05, 2024 at 03:08:26PM -0300, Fabiano Rosas wrote:
>> Put the common test code in a separate file. Leave only individual
>> test functions and their static helpers in migration-test.c.
>>
>> This moves the shared:
>>
>> test_postcopy_common
>> test_pos
Prasad Pandit writes:
> On Tue, 5 Nov 2024 at 18:30, Peter Xu wrote:
>> https://www.qemu.org/docs/master/devel/qapi-code-gen.html
>>
>> Sometimes, the behaviour of QEMU changes compatibly, but without a
>> change in the QMP syntax (usually by allowing values or operations
>>
On 05/11/2024 18:02, Peter Maydell wrote:
The clang sanitizer complains about the code in the EOI handling
of openpic_cpu_write_internal():
UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1 ./build/clang/qemu-system-ppc -M
mac99,graphics=off -display none -kernel day15/invaders.elf
../../hw/intc/
On Wed, Nov 6, 2024 at 2:10 PM Peter Maydell wrote:
>
> On Mon, 4 Nov 2024 at 17:35, Paolo Bonzini wrote:
> >
> > The following changes since commit 15195de6a93438be99fdf9a90992c4228527130d:
> >
> > ci: enable rust in the Fedora system build job (2024-10-30 16:30:56 +0100)
> >
> > are available
Daniel P. Berrangé writes:
> On Tue, Nov 05, 2024 at 03:08:27PM -0300, Fabiano Rosas wrote:
>> The migration-test.c file has become unwieldy large. It's quite
>> confusing to navigate with all the test definitions mixed with hook
>> definitions. The TLS tests make this worse with ifdef'ery.
>>
>
Commit b56617bbcb4 ("target/i386: Walk NPT in guest real mode") added
logic to run the page table walker even in real mode if we are in NPT
mode. That function then determined whether real mode or paging is
active based on whether the pg_mode variable was 0.
Unfortunately pg_mode is 0 in two situ
On 11/6/24 10:53, Kevin Wolf wrote:
[ Cc: qemu-block ]
Am 06.11.2024 um 09:04 hat Dmitry Frolov geschrieben:
The sum "cluster_index + count" may overflow uint32_t.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Frolov
Thanks, applied to the block bra
This series converts the next-kbd device to use
qemu_input_handler_register(), and then removes the now-unused legacy
qemu_add_kbd_event_handler() function.
Signed-off-by: Mark Cave-Ayland
v4:
- Rebase onto master
- Remove extra zero entries from qcode_to_nextkbd_keycode[] array
- Move positio
On 6/11/24 13:00, BALATON Zoltan wrote:
On Wed, 6 Nov 2024, Mark Cave-Ayland wrote:
Convert the next-kbd device from the legacy UI
qemu_add_kbd_event_handler()
function to use qemu_input_handler_register().
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Thomas Huth
---
hw/m68k/next-kbd.c | 163
list changed files in tests/qtest/bios-tables-test-allowed-diff.h
Suggested-by: Igor Mammedov
Message-ID: <20241106100047.18901...@imammedo.users.ipa.redhat.com>
Signed-off-by: Salil Mehta
---
tests/qtest/bios-tables-test-allowed-diff.h | 41 +
1 file changed, 41 insertions(
On Mon, 4 Nov 2024 11:00:59 -0500
"Michael S. Tsirkin" wrote:
> On Mon, Sep 16, 2024 at 06:44:49PM +0100, Jonathan Cameron wrote:
> > Add a test with 6 nodes to exercise most interesting corner cases of SRAT
> > and HMAT generation including the new Generic Initiator and Generic Port
> > Affinity
16.09.2024 20:10, Jonathan Cameron via wrote:
The ordering in ACPI specification [1] has bus number in the lowest byte.
As ACPI tables are little endian this is the reverse of the ordering
used by PCI_BUILD_BDF(). As a minimal fix split the QEMU BDF up
into bus and devfn and write them as single
Here we just prepare for the following patch, making possible to report
GenericError as recommended.
This patch doesn't aim to prevent further use of DeviceNotFound by
future interfaces:
- find_device_state() is used in blk_by_qdev_id() and qmp_get_blk()
functions, which may lead to spread of
On Tue, Nov 05, 2024 at 04:57:55PM +0100, Phil Dennis-Jordan wrote:
> This is a loose collection of patches against the x86 hvf accel. They
> can be applied/pulled independently from one another.
>
> Patch 1 is a repost of a patch I've submitted a bunch of times already.
> It wires up and enables
Both timeout and return value of imx_gpt_update_count() are unsigned.
Thus "limit" can not be negative, but obviously it was implied.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Frolov
---
hw/timer/imx_gpt.c | 2 +-
1 file changed, 1 insertion(+), 1 d
On Wed, 6 Nov 2024, Mark Cave-Ayland wrote:
Convert the next-kbd device from the legacy UI qemu_add_kbd_event_handler()
function to use qemu_input_handler_register().
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Thomas Huth
---
hw/m68k/next-kbd.c | 163 ++---
On Wed, Nov 6, 2024 at 3:33 PM Stefano Garzarella wrote:
>
> On Tue, Nov 05, 2024 at 08:24:17PM +0530, Sahil Siddiq wrote:
> >Hi,
> >
> >Thank you for the review.
> >
> >On 11/5/24 3:06 PM, Stefano Garzarella wrote:
> >>On Mon, Nov 04, 2024 at 09:51:24PM +0530, Sahil Siddiq wrote:
> >>>Linux commi
On Wed, 6 Nov 2024 at 13:14, Paolo Bonzini wrote:
>
> On Wed, Nov 6, 2024 at 2:10 PM Peter Maydell wrote:
> >
> > On Mon, 4 Nov 2024 at 17:35, Paolo Bonzini wrote:
> > >
> > > The following changes since commit
> > > 15195de6a93438be99fdf9a90992c4228527130d:
> > >
> > > ci: enable rust in the
Daniel P. Berrangé writes:
> On Tue, Nov 05, 2024 at 03:08:36PM -0300, Fabiano Rosas wrote:
>> Allow qtests to be ran by subsystem. Some subsystems, such as
>> migration, have a large number of tests and we could benefit from
>> being able to access them from make check without having to run the
On Tue, Nov 05, 2024 at 03:08:26PM -0300, Fabiano Rosas wrote:
> Put the common test code in a separate file. Leave only individual
> test functions and their static helpers in migration-test.c.
>
> This moves the shared:
>
> test_postcopy_common
> test_postcopy_recovery_common
> test_precopy_
On 11/5/24 4:50 PM, Stefan Berger wrote:
> > One of swtpm or apparmor must be wrong here and I think it should
be fixed. In particular, having the failure mode be "something
As stated, we were going to fix the AppArmor path in the swtpm Ubuntu
package.
But AIUI the solution you've
Daniel P. Berrangé writes:
> On Tue, Nov 05, 2024 at 03:08:19PM -0300, Fabiano Rosas wrote:
>> The current build structure for migration tests is confusing. There is
>> the tests/migration directory, which contains two different guest code
>> implementations, one for the qtests (a-b-{bootblock|ke
Fixes the the CPUs AML code and its corresponding golden masters ACPI
tables files for backward compatability of live migration on x86 platforms
i.e. when newer Qemu is migrated to older Qemu without `CPRS` Bit present
in the register block.
Fixes [PULL 60/65], [PULL 61/65]:
Message-ID:
Message-
Update DSDT golden master files for x86/pc and x86/q35 platforms to fix
the earlier changes made in the architecture-agnostic CPU AML. These
updates notify the guest OS of vCPU hot-plug and hot-unplug status using
the ACPI `_STA.Enabled` bit. Earlier order of checking `presence` and
`enabled` broke
On Wed, Nov 06, 2024 at 01:53:15PM +0100, Markus Armbruster wrote:
> Date: Wed, 06 Nov 2024 13:53:15 +0100
> From: Markus Armbruster
> Subject: Why the wait for reviews / advice from armbru?
>
> I've been dealing with a health emergency in the family. I've had
> serious difficulties focusing, pa
On 11/5/2024 10:23 PM, Paolo Bonzini wrote:
On 11/5/24 12:25, Xiaoyao Li wrote:
On 11/5/2024 5:55 PM, Paolo Bonzini wrote:
On 11/5/24 07:23, Xiaoyao Li wrote:
From: Sean Christopherson
Don't get/put state of TDX VMs since accessing/mutating guest state of
production TDs is not supported.
No
Interrupt Generation Support (IGS) is a capability that is tied to the
interrupt deliver mechanism, not with the core IOMMU emulation. We
should allow device implementations to set IGS as they wish.
A new helper is added to make it easier for device impls to set IGS. Use
it in our existing IOMMU d
On 11/4/2024 3:10 PM, Dongli Zhang wrote:
> QEMU uses the kvm_get_msrs() function to save Intel PMU registers from KVM
> and kvm_put_msrs() to restore them to KVM. However, there is no support for
> AMD PMU registers. Currently, has_pmu_version and num_pmu_gp_counters are
> initialized based on cpu
On Wed, 30 Oct 2024 09:42:10 +0800
maobibo wrote:
> Hi Zhao,
>
> Thanks for reviewing the patch.
>
> On 2024/10/29 下午9:19, Zhao Liu wrote:
> > Hi Bibo,
> >
> > [snip]
> >
> >> +In the CPU topology relationship, When we know the ``socket_id``
> >> ``core_id``
> >> +and ``thread_id`` of the
Split vhost_user_blk_sync_config() out from
vhost_user_blk_handle_config_change(), to be reused in the following
commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Raphael Norwitz
Reviewed-by: Stefano Garzarella
---
hw/block/vhost-user-blk.c | 26 +++---
1 file c
On Wed, Nov 06, 2024 at 03:41:24PM +0530, Prasad Pandit wrote:
On Wed, 6 Nov 2024 at 14:21, Stefano Garzarella wrote:
I think we should call that functions in the reverse order, so just add them in
the error path, as we already do for other calls.
===
diff --git a/hw/virtio/vhost.c b/hw/virti
On Wed, 30 Oct 2024 09:50:56 +0800
maobibo wrote:
> Hi Zhao,
>
> On 2024/10/29 下午9:37, Zhao Liu wrote:
> > (CC Igor since I want to refer his comment on hotplug design.)
> >
> > Hi Bibo,
> >
> > I have some comments about your hotplug design.
> >
> > [snip]
> >
> >> +static void virt_cpu_p
On Tue, Nov 05, 2024 at 03:08:23PM -0300, Fabiano Rosas wrote:
> Move ufd_version_check() to migration-util.c file. This is a helper
> function that is used during tests definition so it should be
> available outside of migration-test.c
>
> Signed-off-by: Fabiano Rosas
> ---
> tests/qtest/migrat
On Wed, 6 Nov 2024 at 16:05, Stefano Garzarella wrote:
> >+fail_iotlb:
> >+hdev->vhost_ops->vhost_set_iotlb_callback(hdev, false);
> > fail_start:
> >+hdev->vhost_ops->vhost_dev_start(hdev, false);
>
> This should go before the fail_start label, since it should not be
> called when vhost_d
1 - 100 of 264 matches
Mail list logo