On Wed, Nov 6, 2024 at 2:10 PM Peter Maydell <peter.mayd...@linaro.org> wrote:
>
> On Mon, 4 Nov 2024 at 17:35, Paolo Bonzini <pbonz...@redhat.com> wrote:
> >
> > The following changes since commit 15195de6a93438be99fdf9a90992c4228527130d:
> >
> > ci: enable rust in the Fedora system build job (2024-10-30 16:30:56 +0100)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/bonzini/qemu.git tags/for-upstream-rust
> >
> > for you to fetch changes up to d20feaa9a5af597bd20630d041e5dc7808612be1:
> >
> > ci: enable rust in the Debian and Ubuntu system build job (2024-10-31
> > 18:39:52 +0100)
> >
> > ----------------------------------------------------------------
> > * rust: cleanups
> > * rust: integration tests
> > * rust/pl011: add support for migration
> > * rust/pl011: add TYPE_PL011_LUMINARY device
> > * rust: add support for older compilers and bindgen
> > * rust: enable rust in the Debian, Fedora and Ubuntu system build job
> >
> > ----------------------------------------------------------------
>
> This probably isn't something worth not merging this for, but I
> noticed while testing (via vm-build-openbsd) that Meson complains:
>
> Compiler for language rust for the host machine not found.
> Program bindgen skipped: feature rust disabled
> ../meson.build:111: WARNING: bindgen not found, disabling Rust compilation.
> Message: To use Rust you can install a new version with "cargo install
> bindgen-cli"
>
> Rust is still disabled-by-default, so why is meson probing for bindgen?
It's not probing it ("Program bindgen skipped"), but I was a bit too
happy about printing warnings. This line:
if not bindgen.found() or bindgen.version().version_compare('<0.60.0')
should simply have had an "if not have_rust", or something like that.
If you want I can resend. I know that Linaro people are in Dublin, so
whatever is easiest for you.
Paolo
