On 2024/10/21 09:42, Alistair Francis wrote:
On Thu, Oct 17, 2024 at 5:33 AM Richard Henderson
wrote:
Introduce support for the RISC-V vector extension in the TCG backend.
v5:
https://lore.kernel.org/qemu-devel/20241007025700.47259-1-zhiwei_...@linux.alibaba.com/
Changes for v6:
- Fix p
On Tue, Oct 22, 2024 at 01:11:31AM -0300, Philippe Mathieu-Daudé wrote:
> On 17/10/24 13:32, Peter Maydell wrote:
> > Add a functional test for the collie board that uses the kernel and
> > rootfs provided by Guenter Roeck in the linux-test-downloads repo:
> > https://github.com/groeck/linux-test
On 10/22/24 1:36 PM, Thomas Huth wrote:
On 20/10/2024 03.29, jro...@linux.ibm.com wrote:
From: Jared Rossi
We are already using the libc from SLOF for the s390-netboot.img, and
this libc implementation is way more complete and accurate than the
simple implementation that we currently use fo
Per previous discussion [1,2], this patch deprecates query-migrationthreads
command.
To summarize, the major reason of the deprecation is due to no sensible way
to consume the API properly:
(1) The reported list of threads are incomplete (ignoring destination
threads and non-multifd threa
Am 21.10.2024 um 18:35 hat Paolo Bonzini geschrieben:
> Use the "struct update" syntax to initialize most of the fields to zero,
> and simplify the handmade type-checking of $name.
>
> Reviewed-by: Junjie Mao
> Signed-off-by: Paolo Bonzini
> ---
> rust/qemu-api/src/device_class.rs | 29 ++--
On 10/22/24 03:55, Alex Bennée wrote:
From: Ilya Leoshkevich
GCC produces invalid code for microblaze atomics.
The fix is unfortunately not upstream, so fetch it from an external
location and apply it locally.
Suggested-by: Peter Maydell
Signed-off-by: Ilya Leoshkevich
Message-Id: <20240919
On 10/22/24 03:55, Alex Bennée wrote:
Testing non-auto built docker containers (i.e. custom built compilers)
is a bit fiddly as you couldn't continue a build with a previously
locally built container. While you can play games with REGISTRY its
simpler to allow a NOFETCH that will go through the c
Am 22.10.2024 um 08:00 hat Junjie Mao geschrieben:
>
> Paolo Bonzini writes:
>
> > On Tue, Oct 22, 2024 at 4:12 AM Junjie Mao wrote:
> >> > +($type:ident => $body:block) => {
> >> > +const _: () = {
> >> > +#[used]
> >> > +#[cfg_attr(
> >> > +
On 10/22/24 03:56, Alex Bennée wrote:
We were missing s390x here. There isn't much point testing for the
architecture here as we will fail anyway if the appropriate package
list is missing.
Signed-off-by: Alex Bennée
---
scripts/ci/setup/ubuntu/build-environment.yml | 2 --
1 file changed, 2
Signed-off-by: Matthieu Castet
---
hw/intc/armv7m_nvic.c| 38 +-
target/arm/cpu.c | 4 ++--
target/arm/ptw.c | 23 +++
target/arm/tcg/cpu-v7m.c | 21 -
4 files changed, 74 insertions(+), 12 deletions(-
Hello,
I have a patch that should allow to support cortex-m0+.
I used it in a special arm virtual machine that is still in progress (and not
submitted).
I think this can be usefull.
Matthieu Castet (1):
target/arm: Add cortex-m0+ support
hw/intc/armv7m_nvic.c| 38
On 10/22/24 03:56, Alex Bennée wrote:
From: Ilya Leoshkevich
commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation")
fixed cross-modifying code handling, but did not add a test. The
changed code was further improved recently [1], and I was not sure
whether these modifications wer
On Fri, Oct 11, 2024 at 1:14 PM Noah Goldstein wrote:
>
> On Wed, Oct 2, 2024 at 11:42 AM Noah Goldstein
> wrote:
> >
> > On Wed, Oct 2, 2024 at 11:39 AM Ilya Leoshkevich wrote:
> > >
> > > On Wed, 2024-10-02 at 09:05 -0500, Noah Goldstein wrote:
> > > > On Wed, Oct 2, 2024 at 3:08 AM Ilya Leos
On 22/10/24 07:56, Alex Bennée wrote:
We didn't notice breakage of aarch64_be because we don't have any TCG
tests for it. However while the existing aarch64 compiler can target
big-endian builds no one packages a BE libc. Instead we bang some
rocks together to do the most basic of hello world wit
Hi Igor,
> From: Igor Mammedov
> Sent: Friday, October 18, 2024 3:18 PM
> To: Salil Mehta
>
> On Mon, 14 Oct 2024 20:22:03 +0100
> Salil Mehta wrote:
>
> > Update the `AcpiCpuStatus` for `is_enabled` and `is_present`
> > accordingly when vCPUs are hot-plugged or hot-unplugged, taking
On Wed, Oct 16, 2024 at 02:28:27PM +0800, Jiqian Chen wrote:
> --- a/hw/xen/xen_pt.h
> +++ b/hw/xen/xen_pt.h
> @@ -36,6 +36,7 @@ void xen_pt_log(const PCIDevice *d, const char *f, ...)
> G_GNUC_PRINTF(2, 3);
> # define XEN_PT_LOG_CONFIG(d, addr, val, len)
> #endif
>
> +#define DOMID_RUN_QEMU
On 10/22/24 03:56, Alex Bennée wrote:
Make it easier to find where plugin patches are being staged.
Signed-off-by: Alex Bennée
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 81396c9f15..02b8b2dfd6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
On 10/22/24 03:56, Alex Bennée wrote:
Attempting to run the binary asserts when it can't find the XML entry.
We can fix it so we don't although I suspect other stuff is broken.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580
Signed-off-by: Alex Bennée
---
configs/targets/aarch64_be-
On 10/22/24 03:56, Alex Bennée wrote:
We didn't notice breakage of aarch64_be because we don't have any TCG
tests for it. However while the existing aarch64 compiler can target
big-endian builds no one packages a BE libc. Instead we bang some
rocks together to do the most basic of hello world wit
On 10/22/24 03:56, Alex Bennée wrote:
From: Gustavo Romero
Use list and set comprehension to simplify code. Also, gently handle
invalid gdb filenames.
Signed-off-by: Gustavo Romero
Message-Id: <20241015145848.387281-1-gustavo.rom...@linaro.org>
Signed-off-by: Alex Bennée
---
scripts/probe-
On 10/22/24 03:56, Alex Bennée wrote:
Now gdbstub has gained the ability to extend its command tables we can
allow it to trigger plugin callbacks. This is probably most useful for
QEMU developers debugging plugins themselves but might be useful for
other stuff.
Trigger the callback by sending:
Am 21.10.2024 um 18:35 hat Paolo Bonzini geschrieben:
> This series integrates some of the observations from the MSRV patches at
> https://lore.kernel.org/qemu-devel/20241015131735.518771-1-pbonz...@redhat.com/.
>
> The main changes here are two: first, build an integration test that
> actually tr
Signed-off-by: Matthieu Castet
---
hw/intc/armv7m_nvic.c| 38 +-
target/arm/cpu.c | 4 ++--
target/arm/ptw.c | 23 +++
target/arm/tcg/cpu-v7m.c | 21 -
4 files changed, 74 insertions(+), 12 deletions(-
Hello,
This is a follow up to commit 8f525028bc6f52e4af3f737928d16c3f39a6ea54 to
take care of a few remaining QCryptoAFAlg -> QCryptoAFAlgo renames.
Signed-off-by: Cal Peake
diff --git a/crypto/hash-afalg.c b/crypto/hash-afalg.c
index 06e1e4699c..8c0ce5b520 100644
--- a/crypto/hash-afalg.c
+++
On 10/22/24 01:21, Julian Ganz wrote:
Hi, Pierrick,
October 21, 2024 at 11:59 PM, "Pierrick Bouvier" wrote:
On 10/21/24 14:02, Julian Ganz wrote:
The motivation for this API is a plugin that simulates a RISC-V tracing
unit (and produces a trace). For that we actually also needed to
track
On Tue, Oct 22, 2024 at 02:08:28PM -0600, Alex Williamson wrote:
> Move error handling code to the end of the function so that it can more
> easily be shared by new mmap failure conditions. No functional change
> intended.
>
> Signed-off-by: Alex Williamson
> ---
> hw/vfio/helpers.c | 34 ++
On 22/10/24 02:23, Paolo Bonzini wrote:
On Tue, Oct 22, 2024 at 6:31 AM Philippe Mathieu-Daudé
wrote:
-void qdev_property_add_static(DeviceState *dev, Property *prop)
+void qdev_property_add_static(DeviceState *dev, const Property *prop)
{
Object *obj = OBJECT(dev);
ObjectPrope
On 22/10/24 06:02, Peter Maydell wrote:
On Tue, 22 Oct 2024 at 08:09, Daniel P. Berrangé wrote:
On Tue, Oct 22, 2024 at 01:11:31AM -0300, Philippe Mathieu-Daudé wrote:
On 17/10/24 13:32, Peter Maydell wrote:
Add a functional test for the collie board that uses the kernel and
rootfs provided
On Tue, Oct 22, 2024 at 02:08:29PM -0600, Alex Williamson wrote:
> Thanks to work by Peter Xu, support is introduced in Linux v6.12 to
> allow pfnmap insertions at PMD and PUD levels of the page table. This
> means that provided a properly aligned mmap, the vfio driver is able
> to map MMIO at sig
On Tue, Oct 22, 2024 at 06:11:19PM +0200, Cédric Le Goater wrote:
> On 10/22/24 18:07, Peter Xu wrote:
> > Migration object can be freed before some other device codes run, while we
> > do have a bunch of migration helpers exported in migration/misc.h that
> > logically can be invoked at any time o
On 10/22/24 03:56, Alex Bennée wrote:
We didn't notice breakage of aarch64_be because we don't have any TCG
tests for it. However while the existing aarch64 compiler can target
big-endian builds no one packages a BE libc. Instead we bang some
rocks together to do the most basic of hello world wit
On 10/10/2024 18.20, Daniel P. Berrangé wrote:
From: Alejandro Zeise
Changes the public hash API implementation to support accumulative hashing.
Implementations for the public functions are added to call the new
driver functions that implement context creation, updating,
finalization, and dest
Hello,
Please ignore this mail,
I was doing some test and didn't realise real email was added.
I will resend the real one.
Thanks.
- Mail original -
De: "Matthieu Castet"
À: "castet matthieu"
Cc: "Peter Maydell" , "open list:ARM cores"
, "open list:All patches CC here"
Thanks to work by Peter Xu, support is introduced in Linux v6.12 to
allow pfnmap insertions at PMD and PUD levels of the page table. This
means that provided a properly aligned mmap, the vfio driver is able
to map MMIO at significantly larger intervals than PAGE_SIZE. For
example on x86_64 (the o
As described in patch /2, newer kernels may support pfnmap with PMD or
PUD sized mappings. Mappings must be aligned in order to see the full
benefit of this support. We're largely able to get PMD alignment for
free from mmap, but PUD alignment requires some effort. Further, we
don't actually hav
Move error handling code to the end of the function so that it can more
easily be shared by new mmap failure conditions. No functional change
intended.
Signed-off-by: Alex Williamson
---
hw/vfio/helpers.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
Hi, Alex,
October 22, 2024 at 10:58 AM, "Alex Bennée" wrote:
> How easy would it be to expose a Rust API? I'm curious because now we
> are looking to integrate Rust into QEMU we could consider transitioning
> to a Rust API for plugins. It has been done before:
>
> https://github.com/novafacing/q
From: William Roche
Add the page size information to the hwpoison_page_list elements.
As the kernel doesn't always report the actual poisoned page size,
we adjust this size from the backend real page size.
We take into account the recorded page size to adjust the size
and location of the memory h
From: William Roche
The SIGBUS signal siginfo reporting a HW memory error
provides a si_addr_lsb field with an indication of the
impacted memory page size.
This information should be used to track the hwpoisoned
page sizes.
Signed-off-by: William Roche
---
accel/kvm/kvm-all.c| 6 --
ac
On 22/10/24 07:56, Alex Bennée wrote:
Make it easy for people to see what is already queued.
Signed-off-by: Alex Bennée
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé
From: William Roche
This set of patches fixes several problems with hardware memory errors
impacting hugetlbfs memory backed VMs. When using hugetlbfs large
pages, any large page location being impacted by an HW memory error
results in poisoning the entire page, suddenly making a large chunk of
t
From: William Roche
On HW memory error, we need to report better what the impact of this
error is. So when an entire large page is impacted by an error (like the
hugetlbfs case), we give a warning message when this page is first hit:
Memory error: Loosing a large page (size: X) at QEMU addr Y and
From: William Roche
When the VM reboots, a memory reset is performed calling
qemu_ram_remap() on all hwpoisoned pages.
While we take into account the recorded page sizes to repair the
memory locations, a large page also needs to punch a hole in the
backend file to regenerate a usable memory, clea
Hi Igor,
> From: Igor Mammedov
> Sent: Friday, October 18, 2024 3:31 PM
> To: Salil Mehta
>
> On Mon, 14 Oct 2024 20:22:05 +0100
> Salil Mehta wrote:
>
> > The ACPI CPU hotplug states `is_{present, enabled}` must be migrated
> > alongside other vCPU hotplug states to the destination
Hi Zhao,
Sorry, for the late reply. I was away last week with only intermittent access
to the mails.
> From: Zhao Liu
> Sent: Friday, October 18, 2024 6:13 AM
> To: Salil Mehta
>
> Hi Salil,
>
> On Mon, Oct 14, 2024 at 08:22:04PM +0100, Salil Mehta wrote:
> > Date: Mon, 14 Oct 2024 20
Hi Igor,
> From: Igor Mammedov
> Sent: Friday, October 18, 2024 3:25 PM
> To: Salil Mehta
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@redhat.com;
> m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
> ; lpieral...@kernel.org;
> peter.mayd...@linaro.org; richard.hender.
Hi,
Peter reported on IRC that FMA NaN handling was likely broken on s390x.
Patch 1 of this series fixes the issue, patch 2 adds a test. For the
sake of readability, the test sacrifices the 90-character line length
rule.
Best regards,
Ilya
Ilya Leoshkevich (2):
target/s390x: Fix the floating-p
Add a test to prevent regressions.
Share some useful pieces with the vfminmax test.
Remove the duplicates from the floating point class values.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 5 +-
tests/tcg/s390x/float.h | 104 ++
tests/tcg/s390x/fma.
Order the helper arguments to match the Principles of Operation.
Implement the "Results: MULTIPLY AND ADD" table in pickNaNMulAdd().
Reported-by: Peter Maydell
Signed-off-by: Ilya Leoshkevich
---
fpu/softfloat-specialize.c.inc| 19 +++
target/s390x/tcg/fpu_helper.c | 8
> From: Igor Mammedov
> Sent: Friday, October 18, 2024 3:19 PM
> To: Zhao Liu
> Cc: Salil Mehta ; qemu-devel@nongnu.org;
> qemu-...@nongnu.org; m...@redhat.com; m...@kernel.org; jean-
> phili...@linaro.org; Jonathan Cameron
> ; lpieral...@kernel.org;
> peter.mayd...@linaro.org; richard.h
On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote:
> On 10/22/24 03:56, Alex Bennée wrote:
> > From: Ilya Leoshkevich
> >
> > commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before
> > translation")
> > fixed cross-modifying code handling, but did not add a test. The
> > changed code wa
Running qemu-i386 on a system running with SELinux in enforcing mode
(more precisely: s390x trixie container on Fedora 40) fails with:
qemu-i386: tests/tcg/i386-linux-user/sigreturn-sigmask: Unable to find a
guest_base to satisfy all guest address mapping requirements
-
On 10/22/24 17:16, Ilya Leoshkevich wrote:
On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote:
On 10/22/24 03:56, Alex Bennée wrote:
From: Ilya Leoshkevich
commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before
translation")
fixed cross-modifying code handling, but did not add a test
On Tue, Oct 22, 2024 at 04:42:14PM +0200, Cédric Le Goater wrote:
> > So let me send a small patch later to hopefully make all these exported
> > functions (including migration_file_set_error() in this case, logically
> > anything in migration/misc.h) safe to be called without migration.
>
> OK.
Current definition yields a negative 32bits value, messing up hwprobe
result when Zvfhmin extension presents. Replace it by using a 1ULL bit
shift value as done in kernel upstream.
Link:
https://github.com/torvalds/linux/commit/5ea6764d9095e234b024054f75ebbccc4f0eb146
Fixes: a3432cf227 ("linux-us
On 10/22/24 18:07, Peter Xu wrote:
Migration object can be freed before some other device codes run, while we
do have a bunch of migration helpers exported in migration/misc.h that
logically can be invoked at any time of QEMU, even during destruction of a
VM.
Make all these functions safe to be
On 10/22/24 18:07, Peter Xu wrote:
It's only used within migration/, so it shouldn't be exported.
Signed-off-by: Peter Xu
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
include/migration/misc.h | 3 ---
migration/migration.h| 4
2 files changed, 4 insertions(+), 3 deletions(
From: Vladimir Sementsov-Ogievskiy
We need something more reliable than "device" (which absent in modern
interfaces) and "node-name" (which may absent, and actually don't
specify the device, which is a source of error) to make a per-device
throttling for the event in the following commit.
Signed
From: Peter Maydell
Make the VDI SECTOR_SIZE define be a 64-bit constant; this matches
how we define BDRV_SECTOR_SIZE. The benefit is that it means that we
don't need to carefully cast to 64-bits when doing operations like
"n_sectors * SECTOR_SIZE" to avoid doing a 32x32->32 multiply, which
migh
On Tue, Oct 22, 2024 at 01:40:37PM +0200, Markus Armbruster wrote:
> If we want such warnings for QMP, they should be automated just like the
> -compat actions. Any existing warnings rendered redundant should then
> be taken out. I considered that when I did -compat, and rejected it as
> not wort
From: Peter Maydell
In commit 52b10c9c0c68e90f in 2023 the QAPI MapEntry struct was
updated to add a 'compressed' field. That commit updated a number
of iotest expected-output files, but missed 211, which is vdi
specific. The result is that
./check -vdi
and more specifically
./check -vdi 211
fa
From: Vladimir Sementsov-Ogievskiy
Make variable reusable in code for checks. Don't care to change "512 *
1024" invocations as they will be dropped in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240620144402.65896-2-vsement...@yandex-team.ru>
Reviewed-by: Kevin W
From: Leonid Kaplan
BLOCK_IO_ERROR events comes from guest, so we must throttle them.
We still want per-device throttling, so let's use device id as a key.
Signed-off-by: Leonid Kaplan
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20241002151806.592469-3-vsement...@yandex-team.ru>
R
s->offset and s->size are only set at the end of the function and still
contain the old values when formatting the error message. Print the
parameters with the new values that we actually checked instead.
Fixes: 500e2434207d ('raw-format: Split raw_read_options()')
Signed-off-by: Kevin Wolf
Messa
From: Vladimir Sementsov-Ogievskiy
Relying on disk usage is bad thing, and test just doesn't work on XFS.
Let's instead add a dirty bitmap to track writes to test image.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240620144402.65896-3-vsement...@yandex-team.ru>
Reviewed-by: Kevi
From: Peter Maydell
In compare_fingerprint() we effectively check whether the characters
in the fingerprint are valid hex digits twice: first we do so with
qemu_isxdigit(), but then the hex2decimal() function also has a code
path where it effectively detects an invalid digit and returns -1.
This
The following changes since commit 6f625ce2f21d6a1243065d236298277c56f972d5:
Merge tag 'pull-request-2024-10-21' of https://gitlab.com/thuth/qemu into
staging (2024-10-21 17:12:59 +0100)
are available in the Git repository at:
https://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to
From: Peter Maydell
In the loop in qemu_gluster_parse_json() we do:
char *str = NULL;
for(...) {
str = g_strdup_printf(...);
...
if (various errors) {
goto out;
}
...
g_free(str);
str = NULL;
}
return 0;
out:
On Mon, Oct 21, 2024 at 06:35:28PM +0200, Paolo Bonzini wrote:
> Date: Mon, 21 Oct 2024 18:35:28 +0200
> From: Paolo Bonzini
> Subject: [PATCH v2 03/13] meson: pass rustc_args when building all crates
> X-Mailer: git-send-email 2.46.2
>
> rustc_args is needed to smooth the difference in warnings
The @result parameter passed to hash/hmac APIs may either contain
a pre-allocated buffer, or a buffer can be allocated on the fly.
Clarify these two different usage models in the API docs.
Reviewed-by: Dorjoy Chowdhury
Signed-off-by: Daniel P. Berrangé
---
include/crypto/hash.h | 47 +++
From: "Dr. David Alan Gilbert"
qcrypto_der_encode_octet_str_begin and _end have been unused
since they were added in
3b34ccad66 ("crypto: Support DER encodings")
Remove them.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Daniel P. Berrangé
---
crypto
From: Markus Armbruster
Fux build broken by semantic conflict with commit
8f525028bc6 (qapi/crypto: Rename QCryptoAFAlg to QCryptoAFAlgo).
Fixes: 90c3dc60735a (crypto/hash-afalg: Implement new hash API)
Signed-off-by: Markus Armbruster
Signed-off-by: Daniel P. Berrangé
---
crypto/hash-afalg.c
If the user provides a pre-allocated buffer for the hash result,
we must use that rather than re-allocating a new buffer.
Reported-by: Dorjoy Chowdhury
Signed-off-by: Daniel P. Berrangé
---
crypto/hash-gcrypt.c | 15 ---
crypto/hash-glib.c | 11 +--
crypto/hash-gnutls.c |
On 20/10/2024 03.29, jro...@linux.ibm.com wrote:
From: Jared Rossi
We are already using the libc from SLOF for the s390-netboot.img, and
this libc implementation is way more complete and accurate than the
simple implementation that we currently use for the s390-ccw.img binary.
Since we are now
Hi Gustavo,
> From: Gustavo Romero
> Sent: Monday, October 21, 2024 3:10 AM
> To: Salil Mehta ; qemu-devel@nongnu.org;
> qemu-...@nongnu.org; m...@redhat.com
>
> Hi Salil,
>
> On 10/14/24 16:22, Salil Mehta wrote:
> > Reflect the ACPI CPU hotplug `is_{present, enabled}` states in the
>
On 2024/10/23 上午2:54, Richard Henderson wrote:
On 10/22/24 05:42, Bibo Mao wrote:
For user tcg, there is no physical cpu id provided and logic cpuid
is used. For system emulation, physical cpu id is provided, initial
value of register CSR CPUID can be set from physical cpu id.
Signed-off-by:
I would like a command line option to set register R5 for the microblaze on
boot.
--
Sincerely,
Sam Price
Migration object can be freed before some other device codes run, while we
do have a bunch of migration helpers exported in migration/misc.h that
logically can be invoked at any time of QEMU, even during destruction of a
VM.
Make all these functions safe to be called, especially, not crashing afte
This is a follow up of below patch from Avihai as a replacement:
https://lore.kernel.org/qemu-devel/20241020130108.27148-3-avih...@nvidia.com/
It allows all misc.h exported helpers to be used for the whole VM
lifecycle, so as to never crash QEMU with freed migration objects.
I did also add some
It's only used within migration/, so it shouldn't be exported.
Signed-off-by: Peter Xu
---
include/migration/misc.h | 3 ---
migration/migration.h| 4
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/migration/misc.h b/include/migration/misc.h
index 8d6812b8c7..e0e
On 10/22/24 03:26, Ilya Leoshkevich wrote:
Add a function for formatting target sigsets. It can be useful for
other syscalls in the future, so put it into the beginning of strace.c.
For simplicity, do not implement the strace's ~[] output syntax.
Add a rt_sigprocmask return handler.
Example out
Setting the SO_REUSEADDR property on a socket allows binding to a port
number that is in the TIMED_WAIT state. This is usually done on listener
sockets, to enable a server to restart itself without having to wait for
the completion of TIMED_WAIT on the port.
It is also possible, but highly unusual
The code is supposed to distinguish between SASL server data that
is NULL, vs non-NULL but zero-length. It was incorrectly checking
the 'serveroutlen' variable, rather than 'serverout' though, so
failing to distinguish the cases.
Fortunately we can fix this without breaking compatibility with
clie
From: "Dr. David Alan Gilbert"
socket_remote_address hasn't been used since it was added in
17c55decec ("sockets: add helpers for creating SocketAddress from a socket")
inet_connect hasn't been used since 2017's
8ecc2f9eab ("sheepdog: Use SocketAddress and socket_connect()")
Remove them.
S
When the SASL data is non-NULL, the SASL protocol spec requires that
it is padded with a trailing NUL byte. QEMU discards the trailing
byte, but does not currently validate that it was in fact a NUL.
Apply strict validation to better detect any broken clients.
Reviewed-by: Marc-André Lureau
Signe
On 10/21/24 19:02, Daniel P. Berrangé wrote:
The AF_ALG crypto integration for Linux is not being tested in
any CI scenario. It always requires an explicit configure time
flag to be passed to turn it on. The Fedora system test is
arbitrarily picked as the place to test it.
Signed-off-by: Daniel
On 10/22/24 06:34, Dani Szebenyi wrote:
The previous message I sent was corrupted, sending again.
The TCG IR sequence:
mov_i32 tmp97,$0xc424dead: 1 pref=0x
mov_i32 tmp98,$0x0 pref=0x
rotr_i32 tmp97,tmp97,tmp98 dead: 1 2 pr
On 10/22/24 05:29, Yao Zi wrote:
Commit 9651cead2f ("linux-user: add openat2 support in linux-user")
ships a definition of struct open_how_ver0 while assuming type __u64 is
available in code, which is not the case when building QEMU on musl.
Let's replaces __u64 with uint64_t.
Fixes: 9651cead2f
On 10/22/24 09:01, Yao Zi wrote:
Current definition yields a negative 32bits value, messing up hwprobe
result when Zvfhmin extension presents. Replace it by using a 1ULL bit
shift value as done in kernel upstream.
Link:
https://github.com/torvalds/linux/commit/5ea6764d9095e234b024054f75ebbccc4f
Although we avoid requesting an SSF when querying SASL mechanisms for a
UNIX socket client, we still mistakenly checked for availability of an
SSF once the SASL auth process is complete.
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
ui/vnc-auth-sasl.c | 2 +-
1 file chang
The AF_ALG crypto integration for Linux is not being tested in
any CI scenario. It always requires an explicit configure time
flag to be passed to turn it on. The Fedora system test is
arbitrarily picked as the place to test it.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed
Validate that the pre-allocated buffer pointer was not overwritten
by the hash/hmac APIs.
Reviewed-by: Dorjoy Chowdhury
Signed-off-by: Daniel P. Berrangé
---
tests/unit/test-crypto-hash.c | 7 ---
tests/unit/test-crypto-hmac.c | 6 --
2 files changed, 8 insertions(+), 5 deletions(-)
di
The SASL library requires the connection's local & remote IP address to
be passed in, since some mechanism may use this information. Currently
QEMU raises an error for non-inet sockets, but it is valid to pass NULL
to the SASL library. Doing so makes SASL work on UNIX sockets.
Reviewed-by: Marc-An
The 'is_unix' flag is set on the VNC server during startup, however,
a regression in:
commit 8bd22f477f68bbd7a9c88e926e7a58bf65605e39
Author: Daniel P. Berrangé
Date: Fri Feb 3 12:06:46 2017 +
ui: extract code to connect/listen from vnc_display_open
meant we stopped setting the
The SASL initialization phase may determine that there are no valid
mechanisms available to use. This may be because the host OS admin
forgot to install some packages, or it might be because the requested
SSF level is incompatible with available mechanisms, or other unknown
reasons.
If we return a
On Tue, 22 Oct 2024 14:15:44 +0100
Daniel P. Berrangé wrote:
> On Tue, Oct 22, 2024 at 02:46:15PM +0200, Igor Mammedov wrote:
> > On Fri, 18 Oct 2024 13:59:34 +0100
> > Daniel P. Berrangé wrote:
> >
> > > On Fri, Oct 18, 2024 at 02:25:26PM +0200, Igor Mammedov wrote:
> > > > On Wed, 16 Oct
On Tue, Oct 22, 2024 at 08:34:02AM +0200, Thomas Huth wrote:
> The linker on OpenBSD complains:
>
> ld: warning: dirtyrate.c:447 (../src/migration/dirtyrate.c:447)(...):
> warning: strcpy() is almost always misused, please use strlcpy()
>
> It's currently not a real problem in this case since b
On 10/22/24 13:54, Joel Stanley wrote:
On Wed, 16 Oct 2024 at 01:23, Jamin Lin wrote:
3. Test HACE model with u-boot hash command
a. load test file to address 8300 via tftp
ast# tftp 8300 jamin_lin/32MB
b. get sha256
ast# hash sha256 8300 200
sha256 for 8300 ... 84ff ==
On 10/17/24 05:54, Ilya Leoshkevich wrote:
Add a small test to prevent regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/multiarch/sigreturn-sigmask.c | 51 +
1 file changed, 51 insertions(+)
create mode 100644 tests/tcg/multiarch/sigreturn-sigmask.c
This
On 10/17/24 05:54, Ilya Leoshkevich wrote:
Hi,
This series fixes an issue where an emulated ppc64le process running on
s390x attempting to wake up a sigwait()ing thread would instead
terminate itself. Patch 1 is the fix, patch 2 is a testcase extracted
from the real-world scenario.
Best regards
1 - 100 of 335 matches
Mail list logo