On Tue, Oct 22, 2024 at 01:11:31AM -0300, Philippe Mathieu-Daudé wrote: > On 17/10/24 13:32, Peter Maydell wrote: > > Add a functional test for the collie board that uses the kernel and > > rootfs provided by Guenter Roeck in the linux-test-downloads repo: > > https://github.com/groeck/linux-test-downloads/ > > > > This just boots Linux with a userspace that immediately reboots > > the board, so we wait for the reboot log line. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > MAINTAINERS | 1 + > > tests/functional/meson.build | 1 + > > tests/functional/test_arm_collie.py | 31 +++++++++++++++++++++++++++++ > > 3 files changed, 33 insertions(+) > > create mode 100755 tests/functional/test_arm_collie.py > > > > +class CollieTest(LinuxKernelTest): > > + > > + ASSET_ZIMAGE = Asset( > > + > > 'https://github.com/groeck/linux-test-downloads/raw/225223f2ad7d637b34426810bf6c3b727b76a718/collie/zImage', > > + '10ace8abf9e0875ef8a83b8829cc3b5b50bc6d7bc3ca29f19f49f5673a43c13b') > > + > > + ASSET_ROOTFS = Asset( > > + > > 'https://github.com/groeck/linux-test-downloads/raw/225223f2ad7d637b34426810bf6c3b727b76a718/collie/rootfs-sa110.cpio', > > + '89ccaaa5c6b33331887047e1618ffe81b0f55909173944347d5d2426f3bcc1f2') > > Should we wrap these lines to comply with checkpatch.pl?
While we have some line wrapped URLs in the tests already, IMHO they are pretty awful to look at. I think we should make URLs be an exception to line wrapping rules, provided the URL is the /only/ thing on the line. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
