Re: [PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Laurent Vivier
Le 19/09/2024 à 21:46, Michael Vogt a écrit : This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`.

Re: [PULL 00/38] target-arm queue

2024-09-19 Thread Peter Maydell
ilable in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20240919 > > for you to fetch changes up to 89b30b4921e51bb47313d2d8fdc3d7bce987e4c5: > > docs/deve

[PATCH] {hw/ssi,docs/system/arm}: Allwinner A10 SPI emulation

2024-09-19 Thread Strahinja Jankovic
This patch implements Allwinner A10 SPI controller emulation. Only master-mode functionality is implemented. Since U-Boot and Linux SPI drivers for Allwinner A10 perform only byte-wide CPU access (no DMA) to the peripheral, the emulated controller does not implement DMA control and supports only b

[PATCH] hw/nvme: i/o cmd set independent namespace data structure

2024-09-19 Thread Arun Kumar
add support for i/o command set independent namespace data structure(cns=8h and cns=1fh) Signed-off-by: Klaus Jensen Signed-off-by: Arun Kumar --- hw/nvme/ctrl.c | 37 + hw/nvme/trace-events | 1 + include/block/nvme.h | 17 + 3 files c

Re: [PATCH] q35: Remove unused mch_mcfg_base

2024-09-19 Thread Dr. David Alan Gilbert
* Bernhard Beschow (shen...@gmail.com) wrote: > > > Am 18. September 2024 00:51:32 UTC schrieb d...@treblig.org: > >From: "Dr. David Alan Gilbert" > > > >mch_mcfg_base has been unused since it was added by > > 6f1426ab0f ("ich9: APIs for pc guest info") > >back in 2013. > > Indeed. > > > > >R

Re: [PATCH v2 06/17] migration: Add save_live_complete_precopy_{begin,end} handlers

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 09:47:53PM +0200, Maciej S. Szmigiero wrote: > On 9.09.2024 21:08, Peter Xu wrote: > > On Mon, Sep 09, 2024 at 08:32:45PM +0200, Maciej S. Szmigiero wrote: > > > On 9.09.2024 19:59, Peter Xu wrote: > > > > On Thu, Sep 05, 2024 at 04:45:48PM +0300, Avihai Horon wrote: > > > >

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Maciej S. Szmigiero
On 17.09.2024 19:50, Peter Xu wrote: On Tue, Sep 17, 2024 at 07:07:10PM +0200, Cédric Le Goater wrote: [ ... ] I as a patch writer always like to do that when it's essential. Normally the case is I don't have enough reviewer resources to help me get a better design, or discuss about it. Rig

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-19 Thread Yong Huang
On Fri, Sep 20, 2024 at 2:45 AM Peter Xu wrote: > On Tue, Sep 17, 2024 at 02:48:03PM +0800, Yong Huang wrote: > > On Tue, Sep 17, 2024 at 5:11 AM Fabiano Rosas wrote: > > > > > Hyman Huang writes: > > > > > > > shadow_bmap, iter_bmap and iter_dirty_pages are introduced > > > > to satisfy the ne

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-19 Thread Yong Huang
On Fri, Sep 20, 2024 at 2:45 AM Peter Xu wrote: > On Tue, Sep 17, 2024 at 02:48:03PM +0800, Yong Huang wrote: > > On Tue, Sep 17, 2024 at 5:11 AM Fabiano Rosas wrote: > > > > > Hyman Huang writes: > > > > > > > shadow_bmap, iter_bmap and iter_dirty_pages are introduced > > > > to satisfy the ne

Re: [PATCH v2 06/17] migration: Add save_live_complete_precopy_{begin,end} handlers

2024-09-19 Thread Maciej S. Szmigiero
On 9.09.2024 21:32, Peter Xu wrote: On Mon, Sep 09, 2024 at 03:08:40PM -0400, Peter Xu wrote: On Mon, Sep 09, 2024 at 08:32:45PM +0200, Maciej S. Szmigiero wrote: On 9.09.2024 19:59, Peter Xu wrote: On Thu, Sep 05, 2024 at 04:45:48PM +0300, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S.

Re: [PATCH v2 06/17] migration: Add save_live_complete_precopy_{begin,end} handlers

2024-09-19 Thread Maciej S. Szmigiero
On 9.09.2024 21:08, Peter Xu wrote: On Mon, Sep 09, 2024 at 08:32:45PM +0200, Maciej S. Szmigiero wrote: On 9.09.2024 19:59, Peter Xu wrote: On Thu, Sep 05, 2024 at 04:45:48PM +0300, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-19 Thread Maciej S. Szmigiero
On 9.09.2024 22:03, Peter Xu wrote: On Tue, Aug 27, 2024 at 07:54:27PM +0200, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" load_finish SaveVMHandler allows migration code to poll whether a device-specific asynchronous device state loading operation had finished. In order to avoid ca

[PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Michael Vogt
This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`. Unfortunately we cannot just make do_guest_opena

[PATCH v5 0/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Michael Vogt
Hi, This is v5 of the openat2 support in linux-user. Thanks for the excellent feedback from Laurent Vivier on v4. This version is very close to v4 and only tweaks/simplifies based on the code review comments from Laurent, see the below changes for details. Thanks again, Michael v4 -> v5 - drop

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 09:49:43PM +0200, Maciej S. Szmigiero wrote: > On 10.09.2024 21:48, Peter Xu wrote: > > On Wed, Aug 28, 2024 at 09:41:17PM -0300, Fabiano Rosas wrote: > > > > +size_t multifd_device_state_payload_size(void) > > > > +{ > > > > +return sizeof(MultiFDDeviceState_t); > > > >

Re: [PATCH v3 0/1] Add support for generating OpenSBI domains in the device tree

2024-09-19 Thread Gregor Haas
Hi Drew, On Tue, Sep 17, 2024 at 5:45 AM Andrew Jones wrote: > > On Mon, Sep 09, 2024 at 01:27:05PM GMT, Alistair Francis wrote: > > On Tue, Aug 6, 2024 at 7:05 AM Gregor Haas wrote: > > > > > > This patch series adds support for specifying OpenSBI domains on the QEMU > > > command line. A simpl

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 09:49:57PM +0200, Maciej S. Szmigiero wrote: > On 10.09.2024 18:06, Peter Xu wrote: > > On Tue, Aug 27, 2024 at 07:54:31PM +0200, Maciej S. Szmigiero wrote: > > > +bool multifd_queue_device_state(char *idstr, uint32_t instance_id, > > > +char

[PATCH v2 0/1] hw/nvme: add atomic write support

2024-09-19 Thread Alan Adamson
Changelog: v2: - Include changes suggested by Klaus - Check for READ/WRITE commmands when walking SQs. - Updated the "cover-letter" below with new fio example. = Since there is work in the Lin

[PATCH v2 1/1] hw/nvme: add atomic write support

2024-09-19 Thread Alan Adamson
Adds support for the controller atomic parameters: AWUN and AWUPF. Atomic Compare and Write Unit (ACWU) is not currently supported. Writes that adhere to the ACWU and AWUPF parameters are guaranteed to be atomic. New NVMe QEMU Parameters (See NVMe Specification for details): atomic.dn (def

Re: [PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-19 Thread Michael Tokarev
On 11.09.2024 07:32, Jacob Abrams wrote: SW modifying USART_CR1 TE bit should cuase HW to respond by altering USART_ISR TEACK bit, and likewise for RE and REACK bit. This resolves some but not all issues necessary for the official STM USART HAL driver to function as is. Fixes: 87b77e6e01ca ("hw

Re: [PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-19 Thread Michael Tokarev
On 20.09.2024 07:32, Michael Tokarev wrote: ... Though I'm a bit unsure about the target series. !2540 talks about 9.0.2, but 9.0 does not have 87b77e6e01ca which is being fixed by this change.  Is !2540 incorrect? Ah, n/m, !2540 does indeed mention in 9.0 the device were non-functional. So th

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-19 Thread 0x48 Swung
Hey everyone! Late to the party. Life happens sometimes ;) Just discovered this patch and this mail list, and I'd like to provide some background story here. I originally provided my initial implementation in a downstream repo last

Re: [PATCH v2 09/17] migration/multifd: Device state transfer support - receive side

2024-09-19 Thread Maciej S. Szmigiero
On 9.09.2024 21:52, Peter Xu wrote: On Mon, Sep 02, 2024 at 10:12:01PM +0200, Maciej S. Szmigiero wrote: diff --git a/migration/multifd.h b/migration/multifd.h index a3e35196d179..a8f3e4838c01 100644 --- a/migration/multifd.h +++ b/migration/multifd.h @@ -45,6 +45,12 @@ MultiFDRecvData *multifd_

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Maciej S. Szmigiero
On 10.09.2024 21:48, Peter Xu wrote: On Wed, Aug 28, 2024 at 09:41:17PM -0300, Fabiano Rosas wrote: +size_t multifd_device_state_payload_size(void) +{ +return sizeof(MultiFDDeviceState_t); +} This will not be necessary because the payload size is the same as the data type. We only need it

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Maciej S. Szmigiero
On 9.09.2024 21:40, Peter Xu wrote: On Fri, Aug 30, 2024 at 10:02:40AM -0300, Fabiano Rosas wrote: @@ -397,20 +404,16 @@ bool multifd_send(MultiFDSendData **send_data) p = &multifd_send_state->params[i]; /* - * Lockless read to p->pending_job is safe, because o

Re: [PATCH v2 12/17] migration/multifd: Device state transfer support - send side

2024-09-19 Thread Maciej S. Szmigiero
On 10.09.2024 18:06, Peter Xu wrote: On Tue, Aug 27, 2024 at 07:54:31PM +0200, Maciej S. Szmigiero wrote: +bool multifd_queue_device_state(char *idstr, uint32_t instance_id, +char *data, size_t len) +{ +/* Device state submissions can come from multiple thread

Re: [PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Laurent Vivier
Hi, your PATCH 1/1 doesn't appear to be a reply of PATCH 0/1 (mail header tag "In-Reply-To:"/"Reference") so it is not correctly collected by patchew.org. Do you have the 'thread' parameter for git-send-email? See my comments below: Le 19/09/2024 à 21:46, Michael Vogt a écrit : This commit

Re: [PATCH v2 09/17] migration/multifd: Device state transfer support - receive side

2024-09-19 Thread Maciej S. Szmigiero
On 12.09.2024 15:52, Fabiano Rosas wrote: Avihai Horon writes: On 09/09/2024 21:05, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 5.09.2024 18:47, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution open

[ANNOUNCE] QEMU 7.2.14 Stable released

2024-09-19 Thread Michael Tokarev
Hi everyone, The QEMU v7.2.14 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-7.2.14.tar.xz https://download.qemu.org/qemu-7.2.14.tar.xz.sig (signature) v7.2.14 is now tagged in t

[ANNOUNCE] QEMU 8.2.7 Stable released

2024-09-19 Thread Michael Tokarev
Hi everyone, The QEMU v8.2.7 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.7.tar.xz https://download.qemu.org/qemu-8.2.7.tar.xz.sig (signature) v8.2.7 is now tagged in the o

[ANNOUNCE] QEMU 9.0.3 Stable released

2024-09-19 Thread Michael Tokarev
Hi everyone, The QEMU v9.0.3 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-9.0.3.tar.xz https://download.qemu.org/qemu-9.0.3.tar.xz.sig (signature) v9.0.3 is now tagged in the o

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-19 Thread LIU Zhiwei
On 2024/9/20 12:01, 0x48 Swung wrote: Hey everyone! Late to the party. Life happens sometimes ;) Just discovered this patch and this mail list, and I'd like to provide some background story here. I originally provided my initial implementation in a downstream repo last year, namely https://gi

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 09:49:10PM +0200, Maciej S. Szmigiero wrote: > On 9.09.2024 22:03, Peter Xu wrote: > > On Tue, Aug 27, 2024 at 07:54:27PM +0200, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > load_finish SaveVMHandler allows migration code to poll whether > > > a

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-19 Thread Yong Huang
On Fri, Sep 20, 2024 at 2:45 AM Peter Xu wrote: > On Tue, Sep 17, 2024 at 02:48:03PM +0800, Yong Huang wrote: > > On Tue, Sep 17, 2024 at 5:11 AM Fabiano Rosas wrote: > > > > > Hyman Huang writes: > > > > > > > shadow_bmap, iter_bmap and iter_dirty_pages are introduced > > > > to satisfy the ne

Re: [PATCH for-9.2 0/7] docs/devel: Convert txt files to rST

2024-09-19 Thread Peter Maydell
Ping^2. In particular: Paolo, it would be helpful if you could confirm what license you intended for the lockcnt.c code. thanks -- PMM On Fri, 6 Sept 2024 at 16:12, Peter Maydell wrote: > > Ping for review on these docs conversions, please? > > thanks > -- PMM > > On Fri, 16 Aug 2024 at 14:22,

Looking for help and advice on using RPMSG-over-VIRTIO

2024-09-19 Thread Doug Miller
I am working on adding SR-IOV for a new adapter and need to find a way to communicate between guest and host drivers without using the adapter hardware. I have been looking at RPMSG-over-VIRTIO as a way to this, but have not been able to figure out how the host would setup the RPMSG device needed

Re: [PATCH for-9.2] docs/devel: Remove nested-papr.txt

2024-09-19 Thread Peter Maydell
On Sat, 24 Aug 2024 at 11:13, Daniel Henrique Barboza wrote: > > > > On 8/16/24 10:33 AM, Peter Maydell wrote: > > docs/devel/nested-papr.txt is entirely (apart from the initial > > paragraph) a partial copy of the kernel documentation > > https://docs.kernel.org/arch/powerpc/kvm-nested.html > > >

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-19 Thread Peter Maydell
On Tue, 10 Sept 2024 at 10:38, Peter Maydell wrote: > > On Tue, 10 Sept 2024 at 10:03, Igor Mammedov wrote: > > > > On Mon, 19 Aug 2024 15:43:03 +0100 > > Peter Maydell wrote: > > > @@ -83,34 +83,32 @@ vCPU hotplug > > > > > >(QEMU) query-cpus-fast > > >{ > > > - "execut

Re: [PATCH] io/channel-socket: Remove unused qio_channel_socket_dgram_async

2024-09-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Sep 19, 2024 at 01:00:34AM +0100, d...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > qio_channel_socket_dgram_async has been unused since it was originally > > added in 2015. > > > > Remove it. > > This was knowingly ad

Re: [PULL v2 0/6] Migration 20240917 patches

2024-09-19 Thread Peter Xu
On Thu, Sep 19, 2024 at 10:08:25AM +0100, Peter Maydell wrote: > Thanks for looking at the issues with the migration tests. > This run went through first time without my needing to retry any > jobs, so fingers crossed that we have at least improved the reliability. > (I have a feeling there's still

Re: [PATCH] io/channel-socket: Remove unused qio_channel_socket_dgram_async

2024-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2024 at 01:00:34AM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > qio_channel_socket_dgram_async has been unused since it was originally > added in 2015. > > Remove it. This was knowingly added as unused, since the QIO channel APIs were intended to be provid

Re: [PATCH] io/channel-socket: Remove unused qio_channel_socket_dgram_async

2024-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2024 at 12:36:51PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Sep 19, 2024 at 01:00:34AM +0100, d...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > qio_channel_socket_dgram_async has been unused since i

[PULL 12/38] target/arm: Convert FMOVI (scalar, immediate) to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-13-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 4 ++ target/arm/tcg/translate-a64.c | 74 -

[PULL 27/38] target/arm: Convert SQSHL, UQSHL, SQSHLU (immediate) to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-28-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 36 +- target/arm/tcg/translate-a64.c | 223 ++-

[PULL 04/38] target/arm: Use cmpsel in gen_sshl_vec

2024-09-19 Thread Peter Maydell
From: Richard Henderson Instead of cmp+and or cmp+andc, use cmpsel. This will be better for hosts that use predicate registers for cmp. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-5-richard.hender...@linaro.org Signed-off-by: Peter Maydell -

[PULL 02/38] target/arm: Replace tcg_gen_dupi_vec with constants in translate-sve.c

2024-09-19 Thread Peter Maydell
From: Richard Henderson Instead of copying a constant into a temporary with dupi, use a vector constant directly. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-3-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/tran

[PULL 03/38] target/arm: Use cmpsel in gen_ushl_vec

2024-09-19 Thread Peter Maydell
From: Richard Henderson Instead of cmp+and or cmp+andc, use cmpsel. This will be better for hosts that use predicate registers for cmp. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-4-richard.hender...@linaro.org Signed-off-by: Peter Maydell -

[PULL 06/38] target/arm: Convert EXT to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 5 ++ target/arm/tcg/translate-a64.c |

[PULL 25/38] target/arm: Convert VQSHL, VQSHLU to gvec

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-26-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 12 target/arm/tcg/translate.h | 7 ++ target/arm/tcg/neon-dp.

[PULL 16/38] target/arm: Convert handle_vec_simd_shri to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson This includes SSHR, USHR, SSRA, USRA, SRSHR, URSHR, SRSRA, URSRA, SRI. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-17-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 63 +

[PULL 01/38] target/arm: Replace tcg_gen_dupi_vec with constants in gengvec.c

2024-09-19 Thread Peter Maydell
From: Richard Henderson Instead of copying a constant into a temporary with dupi, use a vector constant directly. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-2-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/geng

Re: [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

2024-09-19 Thread Alex Bennée
Peter Maydell writes: > On Wed, 18 Sept 2024 at 22:08, Alex Bennée wrote: >> >> The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: >> >> Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into >> staging (2024-09-17 14:02:18 +0100) >> >> are available

[PULL 05/38] target/arm: Use tcg_gen_extract2_i64 for EXT

2024-09-19 Thread Peter Maydell
From: Richard Henderson The extract2 tcg op performs the same operation as the do_ext64 function. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-6-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 11/38] target/arm: Convert FMAXNMV, FMINNMV, FMAXV, FMINV to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-12-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 14 +++ target/arm/tcg/translate-a64.c | 176 ++

[PULL 08/38] target/arm: Convert UZP, TRN, ZIP to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 9 ++ target/arm/tcg/translate-a64.c | 158 ++--

[PULL 29/38] target/arm: Convert scalar [US]QSHRN, [US]QRSHRN, SQSHRUN to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-30-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 30 +++ target/arm/tcg/translate-a64.c | 160 +++---

[PULL 14/38] target/arm: Introduce gen_gvec_sshr, gen_gvec_ushr

2024-09-19 Thread Peter Maydell
From: Richard Henderson Handle the two special cases within these new functions instead of higher in the call stack. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-15-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/

[PULL 22/38] target/arm: Convert SHRN, RSHRN to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-23-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 8 +++ target/arm/tcg/translate-a64.c | 95 +---

[PULL 34/38] tests: drop OpenBSD tests for aarch64/sbsa-ref

2024-09-19 Thread Peter Maydell
From: Marcin Juszkiewicz OpenBSD 7.3 we use is EoL. Both 7.4 and 7.5 releases do not work on anything above Neoverse-N1 due to PAC emulation: https://marc.info/?l=openbsd-arm&m=171050428327850&w=2 OpenBSD 7.6 is not yet released. Signed-off-by: Marcin Juszkiewicz Message-id: 20240910-b4-move-

[PULL 28/38] target/arm: Convert vector [US]QSHRN, [US]QRSHRN, SQSHRUN to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-29-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 24 + target/arm/tcg/translate-a64.c | 176

[PULL 15/38] target/arm: Fix whitespace near gen_srshr64_i64

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-16-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/gengvec.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

2024-09-19 Thread Peter Maydell
On Thu, 19 Sept 2024 at 14:11, Alex Bennée wrote: > > Peter Maydell writes: > > While I'm looking at the code, this caught my eye: > > > > case QEMU_PLUGIN_MEM_VALUE_U64: > > { > > uint64_t *p = (uint64_t *) &ri->data[offset]; > > uint64_t val = be ? htobe64(value.data.u64

[PULL 17/38] target/arm: Convert handle_vec_simd_shli to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson This includes SHL and SLI. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-18-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 15 +++ target/arm/tcg/translate-a64

[PULL 00/38] target-arm queue

2024-09-19 Thread Peter Maydell
tags/pull-target-arm-20240919 for you to fetch changes up to 89b30b4921e51bb47313d2d8fdc3d7bce987e4c5: docs/devel: Remove nested-papr.txt (2024-09-19 13:33:15 +0100) target-arm queue: * target/arm: Correct ID_AA64ISAR1_EL1

[PULL 10/38] target/arm: Convert ADDV, *ADDLV, *MAXV, *MINV to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-11-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 12 +++ target/arm/tcg/translate-a64.c | 140 --

[PULL 37/38] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-09-19 Thread Peter Maydell
The Neoverse-V1 TRM is a bit confused about the layout of the ID_AA64ISAR1_EL1 register, and so its table 3-6 has the wrong value for this ID register. Trust instead section 3.2.74's list of which fields are set. This means that we stop incorrectly reporting FEAT_XS as present, and now report the

[PULL 32/38] tests: add FreeBSD tests for aarch64/sbsa-ref

2024-09-19 Thread Peter Maydell
From: Marcin Juszkiewicz FreeBSD has longer support cycle for stable release (14.x EoL in 2028) than OpenBSD (7.3 we use is already EoL). Also bugfixes are backported so we can stay on 14.x for longer. Signed-off-by: Marcin Juszkiewicz Message-id: 20240910-b4-move-to-freebsd-v5-2-0fb66d803...@l

[PULL 31/38] tests: use default cpu for aarch64/sbsa-ref

2024-09-19 Thread Peter Maydell
From: Marcin Juszkiewicz We want to run tests using default cpu without having to remember which Arm core is it. Change Neoverse-N1 (old default) test to use default cpu (Neoverse-N2 at the moment). Signed-off-by: Marcin Juszkiewicz Message-id: 20240910-b4-move-to-freebsd-v5-1-0fb66d803...@lin

[PULL 24/38] target/arm: Convert handle_scalar_simd_shli to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson This includes SHL and SLI. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-25-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 4 target/arm/tcg/translate-a64.c | 44 +++

[PULL 19/38] target/arm: Convert SSHLL, USHLL to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-20-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 8 target/arm/tcg/translate-a64.c | 81 ---

[PULL 30/38] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-19 Thread Peter Maydell
From: Jacob Abrams SW modifying USART_CR1 TE bit should cuase HW to respond by altering USART_ISR TEACK bit, and likewise for RE and REACK bit. This resolves some but not all issues necessary for the official STM USART HAL driver to function as is. Fixes: 87b77e6e01ca ("hw/char/stm32l4x5_usart:

[PULL 35/38] kvm: Make 'mmap_size' be 'int' in kvm_init_vcpu(), do_kvm_destroy_vcpu()

2024-09-19 Thread Peter Maydell
In kvm_init_vcpu()and do_kvm_destroy_vcpu(), the return value from kvm_ioctl(..., KVM_GET_VCPU_MMAP_SIZE, ...) is an 'int', but we put it into a 'long' logal variable mmap_size. Coverity then complains that there might be a truncation when we copy that value into the 'int ret' which we use for re

[PULL 21/38] target/arm: Split out subroutines of handle_shri_with_rndacc

2024-09-19 Thread Peter Maydell
From: Richard Henderson There isn't a lot of commonality along the different paths of handle_shri_with_rndacc. Split them out to separate functions, which will be usable during the decodetree conversion. Simplify 64-bit rounding operations to not require double-word arithmetic. Reviewed-by: Pe

[PULL 36/38] kvm: Remove unreachable code in kvm_dirty_ring_reaper_thread()

2024-09-19 Thread Peter Maydell
The code at the tail end of the loop in kvm_dirty_ring_reaper_thread() is unreachable, because there is no way for execution to leave the loop. Replace it with a g_assert_not_reached(). (The code has always been unreachable, right from the start when the function was added in commit b4420f198dd8.)

[PULL 38/38] docs/devel: Remove nested-papr.txt

2024-09-19 Thread Peter Maydell
docs/devel/nested-papr.txt is entirely (apart from the initial paragraph) a partial copy of the kernel documentation https://docs.kernel.org/arch/powerpc/kvm-nested.html There's no benefit to the QEMU docs to converting this to rST, so instead delete it. Anybody needing to know the API and protoco

[PULL 18/38] target/arm: Use {, s}extract in handle_vec_simd_wshli

2024-09-19 Thread Peter Maydell
From: Richard Henderson Combine the right shift with the extension via the tcg extract operations. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-19-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate-a64.c |

[PULL 20/38] target/arm: Push tcg_rnd into handle_shri_with_rndacc

2024-09-19 Thread Peter Maydell
From: Richard Henderson We always pass the same value for round; compute it within common code. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-21-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 07/38] target/arm: Convert TBL, TBX to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-8-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 4 +++ target/arm/tcg/translate-a64.c |

[PULL 26/38] target/arm: Widen NeonGenNarrowEnvFn return to 64 bits

2024-09-19 Thread Peter Maydell
From: Richard Henderson While these functions really do return a 32-bit value, widening the return type means that we need do less marshalling between TCG types. Remove NeonGenNarrowEnvFn typedef; add NeonGenOne64OpEnvFn. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id:

[PULL 13/38] target/arm: Convert MOVI, FMOV, ORR, BIC (vector immediate) to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-14-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 9 +++ target/arm/tcg/translate-a64.c | 117 ++

[PULL 23/38] target/arm: Convert handle_scalar_simd_shri to decodetree

2024-09-19 Thread Peter Maydell
From: Richard Henderson This includes SSHR, USHR, SSRA, USRA, SRSHR, URSHR, SRSRA, URSRA, SRI. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240912024114.1097832-24-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/a64.decode | 16

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Ganapatrao Kulkarni
On 19-09-2024 08:52 am, Gustavo Romero wrote: Hi Ganapatrao, On 9/12/24 06:16, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disabl

Re: [PATCH 2/3] migration: Remove unused zero-blocks capability

2024-09-19 Thread Markus Armbruster
Peter Xu writes: > On Wed, Sep 18, 2024 at 07:52:56AM +0200, Markus Armbruster wrote: >> d...@treblig.org writes: >> >> > From: "Dr. David Alan Gilbert" >> > >> > migrate_zero_blocks is unused since >> > eef0bae3a7 ("migration: Remove block migration") >> > >> > Remove it. >> > That whole zer

Re: [PATCH v3] i386/cpu: fixup number of addressable IDs for logical processors in the physical package

2024-09-19 Thread Igor Mammedov
On Wed, 18 Sep 2024 21:18:15 +0800 Chuang Xu wrote: > When QEMU is started with: > -cpu host,migratable=on,host-cache-info=on,l3-cache=off > -smp 180,sockets=2,dies=1,cores=45,threads=2 > > Try to execute "cpuid -1 -l 1 -r" in guest, we'll obtain a value of 90 for > CPUID.01H.EBX[23:16], while t

Re: [PATCH] target-i386: Walk NPT in guest real mode

2024-09-19 Thread Richard Henderson
On 8/27/24 15:58, Alexander Graf wrote: When translating virtual to physical address with a guest CPU that supports nested paging (NPT), we need to perform every page table walk access indirectly through the NPT, which we correctly do. However, we treat real mode (no page table walk) special: In

Re: [PATCH 1/1] target/riscv: enable floating point unit

2024-09-19 Thread Richard Henderson
On 9/16/24 20:16, Heinrich Schuchardt wrote: +env->mstatus = set_field(env->mstatus, MSTATUS_FS, env->misa_mxl); Using mxl is definitely wrong here. r~

Re: [PATCH 0/2] gitlab-ci: Make separate sections for build and test

2024-09-19 Thread Richard Henderson
On 9/18/24 14:54, Peter Maydell wrote: Peter Maydell (2): .gitlab-ci.d: Split build and test in cross build job templates .gitlab-ci.d: Make separate collapsible log sections for build and test Reviewed-by: Richard Henderson r~

Re: [PATCH v4 02/12] tcg/riscv: Add basic support for vector

2024-09-19 Thread Richard Henderson
On 9/18/24 12:43, LIU Zhiwei wrote: On 2024/9/18 18:11, Richard Henderson wrote: On 9/18/24 07:17, LIU Zhiwei wrote: On 2024/9/12 2:41, Richard Henderson wrote: On 9/11/24 06:26, LIU Zhiwei wrote: From: Swung0x48 The RISC-V vector instruction set utilizes the LMUL field to group multiple r

Re: [PATCH] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

2024-09-19 Thread Richard Henderson
On 9/17/24 21:30, Thomas Huth wrote: When compiling QEMU just with "--target-list=or1k-softmmu", there are 8 iotests failing that try to use PCI devices - but the default or1k machine does not have a PCI bus. The "virt" machine is better suited for running the iotests than the or1k default machin

Re: [PATCH 08/25] hw/i2c: add support for flexcomm i2c

2024-09-19 Thread Peter Maydell
On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote: > Generally it's frowned upon to have a ton of extra stuff that's not > used. I would think some is ok, like defining bits in registers that > aren't used yet, but I have no idea how all the enums below here > actually tie into anything. I'm gu

Re: [PATCH 1/3] linux-user: update syscall_nr.h to Linux v6.10

2024-09-19 Thread Laurent Vivier
Le 18/09/2024 à 17:41, Brian Cain a écrit : On 9/18/2024 2:42 AM, Laurent Vivier wrote: Automatically generated using scripts/gensyscalls.sh Signed-off-by: Laurent Vivier ---   linux-user/aarch64/syscall_nr.h | 19 ++-   linux-user/hexagon/syscall_nr.h | 20

[PATCH v2 1/7] migration: Remove migrate_cap_set

2024-09-19 Thread dave
From: "Dr. David Alan Gilbert" migrate_cap_set has been unused since 18d154f575 ("migration: Remove 'blk/-b' option from migrate commands") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Fabiano Rosas --- migration/options.c | 20 migration/options.h |

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

2024-09-19 Thread Brian Cain
On 9/16/2024 11:31 AM, Brian Cain wrote: On 9/16/2024 11:05 AM, Brian Cain wrote: On 9/16/2024 10:47 AM, Alex Bennée wrote: Brian Cain writes: On 9/16/2024 8:12 AM, Alex Bennée wrote: Brian Cain writes: On 9/6/2024 9:39 PM, Brian Cain wrote: With newer clang builds (19.x), there's a

[PATCH v2 7/7] util/userfaultfd: Remove unused uffd_poll_events

2024-09-19 Thread dave
From: "Dr. David Alan Gilbert" uffd_poll_events has been unused since it was added; it's also just a wrapper around a plain old poll call, so doesn't add anything. Signed-off-by: Dr. David Alan Gilbert --- include/qemu/userfaultfd.h | 1 - util/userfaultfd.c | 28 -

Re: [PATCH v3 1/1] virtio-pci: Add lookup subregion of VirtIOPCIRegion MR

2024-09-19 Thread Gao,Shiyuan
>> Now virtio_address_space_lookup only lookup common/isr/device/notify >> MR and exclude their subregions. >> >> When VHOST_USER_PROTOCOL_F_HOST_NOTIFIER enable, the notify MR has >> host-notifier subregions and we need use host-notifier MR to >> notify the hardware accelerator directly instead of

[PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-19 Thread dave
From: "Dr. David Alan Gilbert" Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers rather than calling ioctl ourselves. They return -errno on error, and print an error_report themselves. I think this actually makes postcopy_place_page actually more consistent in it's callers. Signed-

[PATCH V2] virtio/vhost-user: fix qemu abort when hotunplug vhost-user-net device

2024-09-19 Thread yaozhenguo
During the process of hot-unplug in vhost-user-net NIC, vhost_user_cleanup may add same rcu node to rcu list. Function calls are as follows: vhost_user_cleanup ->vhost_user_host_notifier_remove ->call_rcu(n, vhost_user_host_notifier_free, rcu); ->g_free_rcu(n, rcu); When this happ

[PATCH v7 2/8] target/riscv: Adjust PMP size for no-MMU RV64 QEMU running RV32

2024-09-19 Thread LIU Zhiwei
From: TANG Tiancheng Ensure pmp_size is correctly determined using mxl for RV32 in RV64 QEMU. Signed-off-by: TANG Tiancheng Reviewed-by: Liu Zhiwei Reviewed-by: Alistair Francis --- target/riscv/pmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/pmp.c b/ta

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-09-19 Thread David Hildenbrand
On 17.09.24 18:38, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's sta

Re: [PULL 00/18] tcg plugins (deprecations, mem apis, contrib plugins)

2024-09-19 Thread Peter Maydell
On Wed, 18 Sept 2024 at 22:08, Alex Bennée wrote: > > The following changes since commit 2b81c046252fbfb375ad30632362fc16e6e22bd5: > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2024-09-17 14:02:18 +0100) > > are available in the Git repository at: > >

  1   2   >