[PATCH 1/1] softmmu/physmem.c: Keep transaction attribute in address_space_map()

2024-09-12 Thread Fea.Wang
The follow-up transactions may use the data in the attribution, so keep the value of attribution from the function parameter just as flatview_translate() above. Signed-off-by: Fea.Wang --- system/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/physmem.c b/sys

[PATCH 0/1] Keep transaction attribute in address_space_map()

2024-09-12 Thread Fea.Wang
The follow-up transactions may use the data in the attribution, so keep the value of attribution from the function parameter. Fea.Wang (1): softmmu/physmem.c: Keep transaction attribute in address_space_map() system/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1

Re: [RFC PATCH] ppc/spapr: Change printf format to %HWADDR_PRId for MIN_RMA_SLOF

2024-09-12 Thread Philippe Mathieu-Daudé
Hi Aditya, On 12/9/24 08:52, Aditya Gupta wrote: Currently starting a pSeries machine, with lesser than 128MiB shows below error: qemu-system-ppc64: pSeries SLOF firmware requires >= 80ldMiB guest RMA (Real Mode Area memory) Above '80ldMib' is in hex, and it means 0x80 MiB = 128 MiB. Ch

Re: [PATCH 1/1] softmmu/physmem.c: Keep transaction attribute in address_space_map()

2024-09-12 Thread Philippe Mathieu-Daudé
On 12/9/24 09:04, Fea.Wang wrote: The follow-up transactions may use the data in the attribution, so keep the value of attribution from the function parameter just as flatview_translate() above. Doh, long standing bug... Cc: qemu-sta...@nongnu.org Fixes: f26404fbee ("Make address_space_map()

[PATCH v2 00/48] Use g_assert_not_reached instead of (g_)assert(0, false)

2024-09-12 Thread Pierrick Bouvier
This series cleans up all usages of assert/g_assert who are supposed to stop execution of QEMU. We replace those by g_assert_not_reached(). It was suggested recently when cleaning codebase to build QEMU with gcc and tsan: https://lore.kernel.org/qemu-devel/54bb02a6-1b12-460a-97f6-3f478ef76...@lina

[PATCH v2 02/48] hw/acpi: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 06/48] hw/net: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v2 12/48] tests/qtest: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier --- tests/qtest/ipmi-bt-test.c | 2 +- tests/qtest/

[PATCH v2 01/48] docs/spin: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- docs/spin/aio_notify_accept.promela | 6 +++--- docs/spin/aio_notify_bug.p

[PATCH v2 17/48] hw/net: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c| 2 +- hw/net/net_rx_pk

[PATCH v2 03/48] hw/arm: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH v2 09/48] qobject: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ---

[PATCH v2 04/48] hw/char: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/char/avr_usart.c | 2 +- 1 file ch

[PATCH v2 23/48] tests/qtest: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/qtest/numa-test.c | 10 +- 1 file changed, 5 insertions(+),

[PATCH v2 22/48] target/i386/kvm: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/i386/kvm/kvm.c | 4 ++-- 1 fil

[PATCH v2 20/48] hw/ppc: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- hw/ppc/spapr_events.c | 2 +- 1 file

[PATCH v2 18/48] hw/nvme: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/nvme/ctrl.c | 8 1 file changed, 4 insertions(+), 4 deletions(

[PATCH v2 16/48] hw/hyperv: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++---

[PATCH v2 34/48] target/riscv: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/riscv/monitor.c

[PATCH v2 15/48] block: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/qcow2.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 25/48] block: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- block/ssh.c | 1

[PATCH v2 11/48] target/ppc: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier --- target/ppc/dfp_helper.c | 8

[PATCH v2 19/48] hw/pci: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[PATCH v2 26/48] hw/acpi: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/

[PATCH v2 24/48] accel/tcg: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[PATCH v2 39/48] include/qemu: remove return after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- include/qemu/pmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/pmem.h b/include/qemu/

[PATCH v2 28/48] hw/misc: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/misc/imx6_ccm.c | 1 - hw/misc/mac

[PATCH v2 27/48] hw/gpio: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/gpio/nrf51_gpio.c | 1 - 1 file ch

[PATCH v2 32/48] hw/tpm: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/t

[PATCH v2 41/48] hw/net: remove return after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/net/e1000e_core.c | 2 -- hw/net/igb_core.c| 2 -- hw/net/vmxnet3.c | 1 - 3 files changed, 5 d

[PATCH v2 33/48] target/arm: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 10/48] system: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- system/rtc.c | 2 +- 1 file changed,

[PATCH v2 43/48] hw/ppc: remove return after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw

[PATCH v2 35/48] tests/qtest: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/qtest/migration-helpers.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Pierrick Bouvier --- include/hw/s390x/cpu-topology.h | 2 +- 1 file c

[PATCH v2 38/48] tcg/loongarch64: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) dif

[PATCH v2 21/48] migration: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/dirtyrate.c |

[PATCH v2 07/48] hw/watchdog: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard W.M. Jones Signed-off-by: Pierrick Bouvier --- hw/w

[PATCH v2 37/48] fpu: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH v2 31/48] hw/scsi: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier --- hw/scsi/virtio-scsi.c | 1 - 1 file changed, 1 de

[PATCH v2 05/48] hw/core: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/core/numa.c | 2 +- 1 file changed

[PATCH v2 40/48] hw/hyperv: remove return after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 files changed, 4 deletions(-) dif

[PATCH v2 42/48] hw/pci: remove return after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub

[PATCH v2 29/48] hw/net: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/

[PATCH v2 13/48] tests/unit: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/unit/test-xs-node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2 30/48] hw/pci-host: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- hw/pci-host/gt64120.c | 2 -- 1 file

[PATCH v2 08/48] migration: replace assert(0) with g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier --- migration/migration-hmp-cmds.c | 2 +- migration/postc

[PATCH v2 36/48] ui: remove break after g_assert_not_reached()

2024-09-12 Thread Pierrick Bouvier
This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- ui/qemu-pixman.c | 1 - 1 file change

Re: [PATCH 1/2] qga/qapi-schema: Drop obsolete note on "unsupported" errors

2024-09-12 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Sep 11, 2024 at 4:12 PM Markus Armbruster wrote: > The note talks about "unsupported" errors and QERR_UNSUPPORTED. The > former is vague, and the latter makes sense only in C, not in external > interface documentation. Fortunately, we don't have to addr

Re: [PATCH 2/2] qga: Improve error for guest-set-user-password parameter @crypted

2024-09-12 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Sep 11, 2024 at 4:12 PM Markus Armbruster wrote: > The Windows version of guest-set-user-password rejects argument > "crypted": true with the rather useless "this feature or command is > not currently supported". Improve to "'crypted' must be off on this

Re: [PATCH v2 43/48] hw/ppc: remove return after g_assert_not_reached()

2024-09-12 Thread Cédric Le Goater
On 9/12/24 09:39, Pierrick Bouvier wrote: This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/ppc.

Re: [PATCH v1 05/14] s390x/s390-virtio-ccw: move setting the maximum guest size from sclp to machine code

2024-09-12 Thread Thomas Huth
On 10/09/2024 19.58, David Hildenbrand wrote: Nowadays, it feels more natural to have that code located in s390_memory_init(), where we also have direct access to the machine object. While at it, use the actual RAM size, not the maximum RAM size which cannot currently be reached without support

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-12 Thread Avihai Horon
On 09/09/2024 18:11, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 07:45:43PM +030

Re: [PATCH v1 06/14] s390x: introduce s390_get_memory_limit()

2024-09-12 Thread Thomas Huth
On 10/09/2024 19.58, David Hildenbrand wrote: Let's add s390_get_memory_limit(), to query what has been successfully set via s390_set_memory_limit(). Allow setting the limit only once. Signed-off-by: David Hildenbrand --- target/s390x/cpu-sysemu.c | 19 +-- target/s390x/cpu.h

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 22:26, Fabiano Rosas wrote: > I don't think we're discussing total CI time at this point, so the math > doesn't really add up. We're not looking into making the CI finish > faster. We're looking into making migration-test finish faster. That > would reduce timeouts in CI, s

Re: [PATCH v2 09/17] migration/multifd: Device state transfer support - receive side

2024-09-12 Thread Avihai Horon
On 09/09/2024 21:05, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 5.09.2024 18:47, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" Add a ba

Re: [PATCH 0/2] Fixes for standard conformance

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 23:30, Sergey Makarov wrote: > > *** Patchset goal *** > > This patchset aims to improve standard conformance for SiFive PLIC > implementation. > > *** Testing cases *** > > Currently there are no automated tests for these changes, but there > are several test cases, with w

Re: Gitlab CI caching is not working

2024-09-12 Thread Daniel P . Berrangé
On Thu, Sep 12, 2024 at 07:38:37AM +0200, Thomas Huth wrote: > > Hi! > > While looking at some recent CI jobs, I noticed that the caching of the > Gitlab-CI jobs is not working at all anymore. In the build jobs, the ccache > saving is not working and causing a complete cache miss of each compile

Re: [PATCH v1 07/14] s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT

2024-09-12 Thread Thomas Huth
On 10/09/2024 19.58, David Hildenbrand wrote: A guest OS that supports memory hotplug / memory devices must during boot be aware of the maximum possible physical memory address that it might have to handle at a later stage during its runtime For example, the maximum possible memory address might

Re: [PATCH v2 15/17] vfio/migration: Multifd device state transfer support - receive side

2024-09-12 Thread Avihai Horon
On 09/09/2024 21:06, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 9.09.2024 10:55, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" The mult

Re: [PATCH v2 17/17] vfio/migration: Multifd device state transfer support - send side

2024-09-12 Thread Avihai Horon
On 09/09/2024 21:07, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 9.09.2024 13:41, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" Implemen

Re: [PATCH v2 18/48] hw/nvme: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Klaus Jensen
On Sep 12 00:38, Pierrick Bouvier wrote: > This patch is part of a series that moves towards a consistent use of > g_assert_not_reached() rather than an ad hoc mix of different > assertion mechanisms. > > Reviewed-by: Richard Henderson > Signed-off-by: Pierrick Bouvier > --- > hw/nvme/ctrl.c |

Re: [PATCH 1/1] hw/nvme: add atomic write support

2024-09-12 Thread Klaus Jensen
On Aug 20 09:11, Alan Adamson wrote: > Adds support for the controller atomic parameters: AWUN and AWUPF. Atomic > Compare and Write Unit (ACWU) is not currently supported. > > Writes that adhere to the ACWU and AWUPF parameters are guaranteed to be > atomic. > > New NVMe QEMU Parameters (See NV

Re: [PATCH v2 15/17] vfio/migration: Multifd device state transfer support - receive side

2024-09-12 Thread Cédric Le Goater
-    return vfio_migration_set_state(vbasedev, VFIO_DEVICE_STATE_RESUMING, - vbasedev->migration->device_state, errp); +    migration->load_bufs_thread_finished = false; +    migration->load_bufs_thread_want_exit = false; +    qemu_thread_create(&migration->load_bufs_thread, "vfio-load-bufs", +  

[PATCH 00/10] target/riscv: Add support for Smdbltrp and Ssdbltrp extensions

2024-09-12 Thread Clément Léger
A double trap typically arises during a sensitive phase in trap handling operations — when an exception or interrupt occurs while the trap handler (the component responsible for managing these events) is in a non-reentrant state. This non-reentrancy usually occurs in the early phase of trap handlin

[PATCH 02/10] target/riscv: Add Ssdbltrp CSRs handling

2024-09-12 Thread Clément Léger
Implement MSTATUS.SDT, {H|M}ENVCFG.DTE and modify the availability of MTVAL2 based on the presence of the Ssdbltrp ISA extension. Signed-off-by: Clément Léger --- target/riscv/cpu.h| 1 + target/riscv/cpu_bits.h | 6 ++ target/riscv/cpu_helper.c | 16 ++ target/riscv/

[PATCH 03/10] target/riscv: Implement Ssdbltrp sret, mret and mnret behavior

2024-09-12 Thread Clément Léger
When the Ssdbltrp extension is enabled, SSTATUS.SDT field is cleared when executing sret. When executing mret/mnret, SSTATUS.SDT is cleared when returning to U, VS or VU and VSSTATUS.SDT is cleared when returning to VU from HS. Signed-off-by: Clément Léger --- target/riscv/op_helper.c | 35 +

[PATCH 04/10] target/riscv: Implement Ssdbltrp exception handling

2024-09-12 Thread Clément Léger
When the Ssdbltrp ISA extension is enabled, if a trap happens in S-mode while SSTATUS.SDT isn't cleared, generate a double trap exception to M-mode. Signed-off-by: Clément Léger --- target/riscv/cpu.c| 2 +- target/riscv/cpu_bits.h | 1 + target/riscv/cpu_helper.c | 47 ++

[PATCH 01/10] target/riscv: Add `ext_ssdbltrp` in RISCVCPUConfig.

2024-09-12 Thread Clément Léger
This variable is used to determine if the Ssdbltrp extension is enabled. Signed-off-by: Clément Léger --- target/riscv/cpu_cfg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index ae2a945b5f..dd804f95d4 100644 --- a/target/riscv/cpu_cfg.h ++

[PATCH 07/10] target/riscv: Add Smdbltrp CSRs handling

2024-09-12 Thread Clément Léger
Implement MSTATUS.MDT behavior. Signed-off-by: Clément Léger --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 15 +++ 2 files changed, 16 insertions(+) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 5557a86348..62bab1bf55 100644 --- a/target/riscv/

[PATCH 06/10] target/riscv: Add `ext_smdbltrp` in RISCVCPUConfig.

2024-09-12 Thread Clément Léger
This variable is used to determine if the Smdbltrp extension is enabled. Signed-off-by: Clément Léger --- target/riscv/cpu_cfg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index dd804f95d4..4c4caa2b39 100644 --- a/target/riscv/cpu_cfg.h ++

[PATCH 09/10] target/riscv: Implement Smdbltrp behavior

2024-09-12 Thread Clément Léger
When the Smsdbltrp ISA extension is enabled, MSTATUS.MDT bit is enabled at reset and set upon trap. If a trap happens while MSTATUS.MDT is already set, it will trigger an abort or an NMI is the Smrnmi extension is available. Signed-off-by: Clément Léger --- target/riscv/cpu.c| 3 +++ ta

[PATCH 05/10] target/riscv: Add Ssdbltrp ISA extension enable switch

2024-09-12 Thread Clément Léger
Add the switch to enable the Ssdbltrp ISA extension. Signed-off-by: Clément Léger --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 206736182a..75433a4359 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -190,6 +

[PATCH 10/10] target/riscv: Add Smdbltrp ISA extension enable switch

2024-09-12 Thread Clément Léger
Add the switch to enable the Smdbltrp ISA extension. Signed-off-by: Clément Léger --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index f9b2ce4463..3a3009bd23 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -183,6 +

[PATCH 08/10] target/riscv: Implement Smdbltrp sret, mret and mnret behavior

2024-09-12 Thread Clément Léger
When the Ssdbltrp extension is enabled, SSTATUS.MDT field is cleared when executing sret if executed in M-mode. When executing mret/mnret, SSTATUS.MDT is cleared. Signed-off-by: Clément Léger --- target/riscv/op_helper.c | 12 1 file changed, 12 insertions(+) diff --git a/target/ri

Re: [PATCH] hw/nvme: MDTS Enhancement

2024-09-12 Thread Klaus Jensen
On Jul 16 13:23, Arun Kumar wrote: > Updated mdts field to only include interleaved metadata if metadata is > interleaved and MEM bit is cleared to 0 > > Signed-off-by: Arun Kumar Thanks! Reviewed-by: Klaus Jensen

Re: [PATCH v2 17/17] vfio/migration: Multifd device state transfer support - send side

2024-09-12 Thread Cédric Le Goater
On 9/12/24 10:26, Avihai Horon wrote: On 09/09/2024 21:07, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments On 9.09.2024 13:41, Avihai Horon wrote: On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments

Re: [PULL v2 00/24] Tests and misc patches

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 10:34, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: > > Merge tag 'migration-20240909-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) > > are available in the

[PATCH V2] arm/kvm: add support for MTE

2024-09-12 Thread Ganapatrao Kulkarni
Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disable migration, as we do not yet have a way to migrate the tags as well. Therefore, MTE will stay off with KVM unles

[PATCH v2 1/5] include/exec: Introduce env_cpu_const()

2024-09-12 Thread Ilya Leoshkevich
It's the same as env_cpu(), but for const objects. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- include/exec/cpu-common.h | 13 - linux-user/elfload.c | 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/exec/cpu-common.h b/incl

[PATCH v2 3/5] target/i386/gdbstub: Factor out gdb_get_reg() and gdb_write_reg()

2024-09-12 Thread Ilya Leoshkevich
i386 gdbstub handles both i386 and x86_64. Factor out two functions for reading and writing registers without knowing their bitness. While at it, simplify the TARGET_LONG_BITS == 32 case. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/i386/gdbstub.c | 51

[PATCH v2 5/5] tests/tcg: Run test-proc-mappings.py on i386

2024-09-12 Thread Ilya Leoshkevich
Now that orig_ax is exposed and GDB is happy, don't skip test-proc-mappings.py on i386. In fact, it's broken only on m68k now, so skip only this architecture. Acked-by: Alex Bennée Signed-off-by: Ilya Leoshkevich --- .../tcg/multiarch/gdbstub/test-proc-mappings.py | 17 ++--- 1 file

[PATCH v2 2/5] linux-user/i386: Emulate orig_ax

2024-09-12 Thread Ilya Leoshkevich
The kernel uses orig_rax/orig_eax to store the syscall number before a syscall. One can see this value in core dumps and ptrace. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- linux-user/elfload.c | 4 ++-- linux-user/i386/cpu_loop.c | 3 +++ linux-user/qemu.h

[PATCH v2 0/5] linux-user/i386: Emulate orig_ax

2024-09-12 Thread Ilya Leoshkevich
v1: https://lore.kernel.org/qemu-devel/20240802095942.34565-1-...@linux.ibm.com/ v1 -> v2: Move orig_ax declaration higher, simplify gdb_write_reg() for TARGET_LONG_BITS == 32 (Richard). Hi, Currently gdbstub is barely usable with i386-linux-user: GDB cannot even parse a shared library

[PATCH v2 4/5] target/i386/gdbstub: Expose orig_ax

2024-09-12 Thread Ilya Leoshkevich
Copy XML files describing orig_ax from GDB and glue them with CPUX86State.orig_ax. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- configs/targets/i386-linux-user.mak | 2 +- configs/targets/x86_64-linux-user.mak | 2 +- gdb-xml/i386-32bit-linux.xml | 11 ++

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-12 Thread Cédric Le Goater
On 9/12/24 10:09, Avihai Horon wrote: On 09/09/2024 18:11, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote: On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments O

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-09-12 Thread Eugenio Perez Martin
On Wed, Sep 11, 2024 at 9:36 PM Sahil wrote: > > Hi, > > On Monday, September 9, 2024 6:04:45 PM GMT+5:30 Eugenio Perez Martin wrote: > > On Sun, Sep 8, 2024 at 9:47 PM Sahil wrote: > > > On Friday, August 30, 2024 4:18:31 PM GMT+5:30 Eugenio Perez Martin wrote: > > > > On Fri, Aug 30, 2024 at 12

Re: [PATCH] vfio/pci: Fix null pointer deference from error API

2024-09-12 Thread Cédric Le Goater
Hello Jim, On 9/12/24 08:36, Jim Shu wrote: Hi Cédric, Thank you very much for the quick response! I have checked the error API again. It seems to be my porting issue of set_iommu_device() callback. Are you adding support for a new IOMMU ? I think "pci_device_set_iommu_device(..., *errp)"

Re: [PATCH v4] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-09-12 Thread Alberto Garcia
On Tue, Jul 30, 2024 at 04:15:52PM +0200, Alberto Garcia wrote: > This tool converts a disk image to qcow2, writing the result directly > to stdout. This can be used for example to send the generated file > over the network. ping

Re: [PATCH v1 07/14] s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT

2024-09-12 Thread Janosch Frank
On 9/12/24 10:19 AM, Thomas Huth wrote: On 10/09/2024 19.58, David Hildenbrand wrote: [...] diff --git a/hw/s390x/s390-hypercall.h b/hw/s390x/s390-hypercall.h index b7ac29f444..f0ca62bcbb 100644 --- a/hw/s390x/s390-hypercall.h +++ b/hw/s390x/s390-hypercall.h @@ -18,6 +18,7 @@ #define DIAG5

[PATCH v12 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-09-12 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

[PATCH v12 01/10] block: add persistent reservation in/out api

2024-09-12 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH v12 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-09-12 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PATCH v12 10/10] block/iscsi: add persistent reservation in/out driver

2024-09-12 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

[PATCH v12 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-09-12 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v12 09/10] hw/nvme: add reservation protocal command

2024-09-12 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

[PATCH v12 00/10] Support persistent reservation operations

2024-09-12 Thread Changqi Lu
Hi, Patch v12 has been modified, thanks to Stefan for the code review. v11->v12: - Fixed endian conversion during command parsing; - Add the maximum number of keys, currently limited to 128. v10->v11: - Before executing the pr operation, check whether it is supported. If it is not supported, r

[PATCH v12 02/10] block/raw: add persistent reservation in/out driver

2024-09-12 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v12 07/10] hw/nvme: add helper functions for converting reservation types

2024-09-12 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Klaus Jensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h |

[PATCH v12 06/10] block/nvme: add reservation command protocol constants

2024-09-12 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h

  1   2   3   >