Re: [PATCH 1/1] softmmu/physmem.c: Keep transaction attribute in address_space_map()

[Philippe Mathieu-Daudé]

On 12/9/24 09:04, Fea.Wang wrote:

The follow-up transactions may use the data in the attribution, so keep
the value of attribution from the function parameter just as
flatview_translate() above.

Doh, long standing bug...

Cc: qemu-sta...@nongnu.org
Fixes: f26404fbee ("Make address_space_map() take a MemTxAttrs argument")
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

Signed-off-by: Fea.Wang <fea.w...@sifive.com>
---
  system/physmem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/system/physmem.c b/system/physmem.c
index d71a2b1bbd..dc1db3a384 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -3274,7 +3274,7 @@ void *address_space_map(AddressSpace *as,
          bounce->len = l;

if (!is_write) {

-            flatview_read(fv, addr, MEMTXATTRS_UNSPECIFIED,
+            flatview_read(fv, addr, attrs,
                            bounce->buffer, l);
          }