Re: [PATCH v7 6/7] rust: add crate to expose bindings and interfaces

2024-08-21 Thread Manos Pitsidianakis
On Fri, 16 Aug 2024 11:34, Philippe Mathieu-Daudé wrote: On 15/8/24 17:06, Daniel P. Berrangé wrote: On Thu, Aug 15, 2024 at 04:01:17PM +0200, Philippe Mathieu-Daudé wrote: Hi Manos, On 15/8/24 13:42, Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bind

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-21 Thread Francisco Iglesias
On Fri, Aug 16, 2024 at 09:35:02AM -0700, Doug Brown wrote: > When checking the QEMU_CAN_FRMF_TYPE_FD flag, we need to ignore other > potentially set flags. Before this change, received CAN FD frames from > SocketCAN weren't being recognized as CAN FD. > > Signed-off-by: Doug Brown Reviewed-by:

Re: [PATCH 1/5] hw/net/can/xlnx-versal-canfd: Fix interrupt level

2024-08-21 Thread Francisco Iglesias
On Fri, Aug 16, 2024 at 09:35:01AM -0700, Doug Brown wrote: > The interrupt level should be 0 or 1. The existing code was using the > interrupt flags to determine the level. In the only machine currently > supported (xlnx-versal-virt), the GICv3 was masking off all bits except > bit 0 when applying

[PATCH] target/riscv/kvm: Fix the group bit setting of AIA

2024-08-21 Thread Andrew Jones
Just as the hart bit setting of the AIA should be calculated as ceil(log2(max_hart_id + 1)) the group bit setting should be calculated as ceil(log2(max_group_id + 1)). The hart bits are implemented by passing max_hart_id to find_last_bit() and adding one to the result. Do the same for the group bit

[PATCH v4 06/35] tests/avocado/boot_linux_console: Remove the s390x subtest

2024-08-21 Thread Thomas Huth
We've got a much more sophisticated, Fedora-based test for s390x ("test_s390x_fedora" in another file) already, so the test in boot_linux_console.py seems to be rather a waste of precious test cycles. Thus move the command line check and delete the s390x test in boot_linux_console.py. Signed-off-b

[PATCH v4 01/35] tests/avocado: machine aarch64: standardize location and RO access

2024-08-21 Thread Thomas Huth
From: Cleber Rosa The tests under machine_aarch64_virt.py and machine_aarch64_sbsaref.py should not be writing to the ISO files. By adding "media=cdrom" the "ro" is automatically set. While at it, let's use a single code style and hash for the ISO url. Signed-off-by: Cleber Rosa Tested-by: Ma

[PATCH v4 15/35] tests/functional: enable pre-emptive caching of assets

2024-08-21 Thread Thomas Huth
From: Daniel P. Berrangé Many tests need to access assets stored on remote sites. We don't want to download these during test execution when run by meson, since this risks hitting test timeouts when data transfers are slow. Add support for pre-emptive caching of assets by setting the env var QEM

[PATCH v4 14/35] tests/functional: add a module for handling asset download & caching

2024-08-21 Thread Thomas Huth
From: Daniel P. Berrangé The 'Asset' class is a simple module that declares a downloadable asset that can be cached locally. Downloads are stored in the user's home dir at ~/.cache/qemu/download, using a sha256 sum of the URL. Signed-off-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daud

[PATCH v4 16/35] tests/functional: Convert some tests that download files via fetch_asset()

2024-08-21 Thread Thomas Huth
Now that we've got the Asset class with pre-caching, we can convert some Avocado tests that use fetch_asset() for downloading their required files. Signed-off-by: Thomas Huth --- MAINTAINERS | 12 ++--- tests/avocado/machine_mips_loongson3v.py | 39

[PATCH v4 04/35] Bump avocado to 103.0

2024-08-21 Thread Thomas Huth
From: Cleber Rosa This bumps Avocado to latest the LTS release. An LTS release is one that can receive bugfixes and guarantees stability for a much longer period and has incremental minor releases made. Even though the 103.0 LTS release is pretty a rewrite of Avocado when compared to 88.1, the

[PATCH v4 09/35] tests/functional: Set up logging

2024-08-21 Thread Thomas Huth
Create log files for each test separately, one file that contains the basic logging and one that contains the console output. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/functional/qemu_test/testcase.py | 27 +- 1 file changed, 26 insertions(+),

[PATCH v4 03/35] tests/avocado/machine_aarch64_sbsaref.py: allow for rw usage of image

2024-08-21 Thread Thomas Huth
From: Cleber Rosa When the OpenBSD based tests are run in parallel, the previously single instance of the image would become corrupt. Let's give each test its own snapshot. Signed-off-by: Cleber Rosa Suggested-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Marcin Juszkiewicz

[PATCH v4 00/35] Convert avocado tests to normal Python unittests

2024-08-21 Thread Thomas Huth
The Avocado v88 that we use in QEMU is already on a life support system: It is not supported by upstream anymore, and with the latest versions of Python, it won't work anymore since it depends on the "imp" module that has been removed in Python 3.12. There have been several attempts to update the

[PATCH v4 18/35] tests/functional: Convert some avocado tests that needed avocado.utils.archive

2024-08-21 Thread Thomas Huth
Instead of using the "archive" module from avocado.utils, switch these tests to use the new wrapper function that is based on the "tarfile" module instead. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAIN

[PATCH v4 02/35] tests/avocado/boot_xen.py: fetch kernel during test setUp()

2024-08-21 Thread Thomas Huth
From: Cleber Rosa The kernel is a common blob used in all tests. By moving it to the setUp() method, the "fetch asset" plugin will recognize the kernel and attempt to fetch it and cache it before the tests are started. Signed-off-by: Cleber Rosa Reviewed-by: Akihiko Odaki Tested-by: Marcin Ju

[PATCH v4 32/35] docs/devel: Split testing docs from the build docs and move to separate folder

2024-08-21 Thread Thomas Huth
Building and testing are two separate topics, so let's split the testing into a separate category and move the related files into a separate folder. Signed-off-by: Thomas Huth --- docs/devel/index-build.rst | 14 -- docs/devel/index.rst

[PATCH v4 23/35] tests/functional: Convert the virtio_gpu avocado test into a standalone test

2024-08-21 Thread Thomas Huth
Nothing thrilling in here, it's just a straight forward conversion. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/functional/meson.build | 1 + .../test_virtio_gpu.py} | 64 +-- 2 files changed, 30 insertions(+),

[PATCH v4 27/35] tests/functional: Convert the m68k nextcube test with tesseract

2024-08-21 Thread Thomas Huth
The code that handles running of tesseract needs to be tweaked a little bit to be able to run without the functions from avocado.utils, and while we're at it, drop some legacy stuff that was still there due to Tesseract 3 support that we already dropped a while ago. Reviewed-by: Philippe Mathieu-D

[PATCH v4 21/35] tests/functional: Convert the microblaze avocado tests into standalone tests

2024-08-21 Thread Thomas Huth
The machine_microblaze.py file contained two tests, one for each endianness. Since we only support one QEMU target binary per file in the new functional test environment, we have to split this file up into two files now. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signe

[PATCH v4 12/35] tests/functional: Convert simple avocado tests into standalone python tests

2024-08-21 Thread Thomas Huth
These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. To ease debugging, make the files executable and add a shebang line and Python '__main__' handling, too, so that these tests can now be run by executing them directly. Reviewed-by: Dani

[PATCH v4 13/35] tests/functional: Convert avocado tests that just need a small adjustment

2024-08-21 Thread Thomas Huth
These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the corresponding avocado tags in the new python test framework. Reviewed-by: Daniel P. Berrangé Teste

[PATCH v4 17/35] tests/functional: Add a function for extracting files from an archive

2024-08-21 Thread Thomas Huth
Some Avocado-based tests use the "archive" module from avocado.utils to extract files from an archive. To be able to use these tests without Avocado, we have to provide our own function for extracting files. Fortunately, there is already the tarfile module that will provide us with this functionali

[PATCH v4 11/35] tests/functional: Prepare the meson build system for the functional tests

2024-08-21 Thread Thomas Huth
Provide a meson.build file for the upcoming python-based functional tests, and add some wrapper glue targets to the tests/Makefile.include file. We are going to use two "speed" modes for the functional tests: The "quick" tests can be run at any time (i.e. also during "make check"), while the "thoro

[PATCH v4 22/35] tests/functional: Convert the riscv_opensbi avocado test into a standalone test

2024-08-21 Thread Thomas Huth
The avocado test defined test functions for both, riscv32 and riscv64. Since we can run the whole file with multiple targets in the new framework, we can now consolidate the functions so we have to only define one function per machine now. Reviewed-by: Alistair Francis Tested-by: Philippe Mathieu

[PATCH v4 29/35] tests/functional: Convert the rx_gdbsim avocado test into a standalone test

2024-08-21 Thread Thomas Huth
Provide a "gzip_uncompress" function based on the standard "gzip" module to avoid the usage of avocado.utils here. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- tests/functional/meson.

[PATCH v4 19/35] tests/functional: Convert the s390x avocado tests into standalone tests

2024-08-21 Thread Thomas Huth
These tests use archive.lzma_uncompress() from the Avocado utils, so provide a small helper function for this, based on the standard lzma module from Python instead. And while we're at it, replace the MD5 hashes in the topology test with proper SHA256 hashes, since MD5 should not be used anymore n

[PATCH v4 24/35] tests/functional: Convert most ppc avocado tests into standalone tests

2024-08-21 Thread Thomas Huth
Nothing thrilling in here, just straight forward conversions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 9 +-- tests/functional/meson.build | 11 .../test_ppc64_powernv.py}| 56 ++

[PATCH v4 30/35] tests/functional: Convert the linux_initrd avocado test into a standalone test

2024-08-21 Thread Thomas Huth
While we're at it, update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 1 + .../test_linux_initrd.py} | 37 +++ 2 files changed, 22 insertions(+

[PATCH v4 33/35] docs/devel/testing: Split the Avocado documentation into a separate file

2024-08-21 Thread Thomas Huth
The main testing documentation file got very overloaded already. Thus let's split the Avocado information into a separate file. Signed-off-by: Thomas Huth --- docs/devel/testing/avocado.rst | 581 + docs/devel/testing/index.rst | 1 + docs/devel/testing/main.r

[PATCH v4 34/35] docs/devel/testing: Rename avocado_qemu.Test class

2024-08-21 Thread Thomas Huth
The avocado_qemu.Test class has been renamed a while back in commit 2283b627bc ("tests/avocado: Rename avocado_qemu.Test -> QemuSystemTest"), so we should reflect this now in the documentation, too. Signed-off-by: Thomas Huth --- docs/devel/testing/avocado.rst | 32 --

[PATCH v4 20/35] tests/functional: Convert the x86_cpu_model_versions test

2024-08-21 Thread Thomas Huth
Nothing thrilling in here, it's just a straight forward conversion. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + tests/functional/meson.build | 1 + .../test_x86_cpu_

[PATCH v4 08/35] tests/functional: Add base classes for the upcoming pytest-based tests

2024-08-21 Thread Thomas Huth
The files are mostly a copy of the tests/avocado/avocado_qemu/__init__.py file with some adjustments to get rid of the Avocado dependencies (i.e. we also have to drop the LinuxSSHMixIn and LinuxTest for now). The emulator binary and build directory are now passed via environment variables that wil

[PATCH v4 28/35] tests/functional: Convert the acpi-bits test into a standalone test

2024-08-21 Thread Thomas Huth
Mostly a straight-forward conversion. Looks like we can simply drop the avocado datadrainer stuff when not using the avocado framework anymore. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS |

[PATCH v4 26/35] tests/functional: Convert the ppc_hv avocado test into a standalone test

2024-08-21 Thread Thomas Huth
A straight forward conversion, we just also have to remove the decorator @skipUnless(os.getenv('SPEED')) since all non-trivial functional tests are running in SPEED=thorough mode now. Also make sure that the extracted assets are writable, so that the test does not fail if it gets re-run and there a

[PATCH v4 31/35] gitlab-ci: Add "check-functional" to the build tests

2024-08-21 Thread Thomas Huth
Now that we converted many tests from the "check-avocado" test suite to the "check-functional" test suite, we should make sure that these also get tested in the CI. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest-templat

[PATCH v4 35/35] docs/devel/testing: Add documentation for functional tests

2024-08-21 Thread Thomas Huth
Document the new functional testing framework. The text is originally based on the Avocado documentation, but heavily modified to match the new framework. Signed-off-by: Thomas Huth --- docs/devel/testing/functional.rst | 269 ++ docs/devel/testing/index.rst |

[PATCH v4 10/35] tests/Makefile.include: Increase the level of indentation in the help text

2024-08-21 Thread Thomas Huth
The next patch is going to add some entries that need more space between the command and the help text, so let's increase the indentation here first. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Thomas Huth --- tests/Makefile.in

[PATCH v4 05/35] tests/avocado/avocado_qemu: Fix the "from" statements in linuxtest.py

2024-08-21 Thread Thomas Huth
Without this change, the new Avocado v103 fails to find the tests that are based on the LinuxTest class. Suggested-by: Cleber Rosa Signed-off-by: Thomas Huth --- tests/avocado/avocado_qemu/linuxtest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/avocado/avocado

[PATCH v4 07/35] python: Install pycotap in our venv if necessary

2024-08-21 Thread Thomas Huth
The upcoming functional tests will require pycotap for providing TAP output from the python-based tests. Since we want to be able to run some of the tests offline by default, too, let's install it along with meson in our venv if necessary (it's size is only 5 kB, so adding the wheel here should not

[PATCH v4 25/35] tests/functional: Convert the ppc_amiga avocado test into a standalone test

2024-08-21 Thread Thomas Huth
Use the Python standard zipfile module instead of avocado.utils for extracting the ZIP file that we download here, and use the standard subprocess module for running the "tail" command. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAI

Re: [PATCH for-9.1] hw/loongarch: Fix length for lowram in ACPI SRAT

2024-08-21 Thread Philippe Mathieu-Daudé
On 20/8/24 20:42, Jiaxun Yang wrote: The size of lowram should be "gap" instead of the whole node. This is failing kernel's sanity check: [0.00] ACPI: SRAT: Node 0 PXM 0 [mem 0x-0x] [0.00] ACPI: SRAT: Node 0 PXM 0 [mem 0x8000-0x16fff] [0.00] ACPI:

Re: [PATCH v4 01/35] tests/avocado: machine aarch64: standardize location and RO access

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: From: Cleber Rosa The tests under machine_aarch64_virt.py and machine_aarch64_sbsaref.py should not be writing to the ISO files. By adding "media=cdrom" the "ro" is automatically set. While at it, let's use a single code style and hash for the ISO url. Si

Re: [PATCH v4 05/35] tests/avocado/avocado_qemu: Fix the "from" statements in linuxtest.py

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: Without this change, the new Avocado v103 fails to find the tests that are based on the LinuxTest class. Reorder before previous patch? Suggested-by: Cleber Rosa Signed-off-by: Thomas Huth --- tests/avocado/avocado_qemu/linuxtest.py | 4 ++-- 1 file c

Re: [PATCH v4 26/35] tests/functional: Convert the ppc_hv avocado test into a standalone test

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: A straight forward conversion, we just also have to remove the decorator @skipUnless(os.getenv('SPEED')) since all non-trivial functional tests are running in SPEED=thorough mode now. Also make sure that the extracted assets are writable, so that the test does

Re: [PATCH v4 05/35] tests/avocado/avocado_qemu: Fix the "from" statements in linuxtest.py

2024-08-21 Thread Thomas Huth
On 21/08/2024 11.31, Philippe Mathieu-Daudé wrote: On 21/8/24 10:27, Thomas Huth wrote: Without this change, the new Avocado v103 fails to find the tests that are based on the LinuxTest class. Reorder before previous patch? The funny thing is that Avocado v88 breaks the other way round if th

Re: [PATCH v4 26/35] tests/functional: Convert the ppc_hv avocado test into a standalone test

2024-08-21 Thread Thomas Huth
On 21/08/2024 11.43, Philippe Mathieu-Daudé wrote: On 21/8/24 10:27, Thomas Huth wrote: A straight forward conversion, we just also have to remove the decorator @skipUnless(os.getenv('SPEED')) since all non-trivial functional tests are running in SPEED=thorough mode now. Also make sure that the

Re: [PATCH for-9.2 v7 0/9] virtio-net: add support for SR-IOV emulation

2024-08-21 Thread Yui Washizu
On 2024/08/13 15:36, Akihiko Odaki wrote: Based-on: <20240802-reuse-v11-0-fb83bb8c1...@daynix.com> ("[PATCH for-9.2 v11 00/11] hw/pci: SR-IOV related fixes and improvements") I couldn't apply this patch series after applying "[PATCH for-9.2 v11 00/11] hw/pci: SR-IOV related fixes and improve

Re: [PATCH v4 05/35] tests/avocado/avocado_qemu: Fix the "from" statements in linuxtest.py

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 12:07, Thomas Huth wrote: On 21/08/2024 11.31, Philippe Mathieu-Daudé wrote: On 21/8/24 10:27, Thomas Huth wrote: Without this change, the new Avocado v103 fails to find the tests that are based on the LinuxTest class. Reorder before previous patch? The funny thing is that Avocad

RE: [PATCH RFC V3 17/29] arm/virt: Release objects for *disabled* possible vCPUs after init

2024-08-21 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Wednesday, August 21, 2024 7:25 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org; m...@redhat.com > > Hi Salil, > > On 8/21/24 2:40 AM, Salil Mehta wrote: > > > > I don’t understand this clearly. Are you suggesting to reuse only

Re: [PATCH v4 04/35] Bump avocado to 103.0

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: From: Cleber Rosa This bumps Avocado to latest the LTS release. An LTS release is one that can receive bugfixes and guarantees stability for a much longer period and has incremental minor releases made. Even though the 103.0 LTS release is pretty a rewrite

Re: [PATCH for-9.2 v14 08/11] pcie_sriov: Remove num_vfs from PCIESriovPF

2024-08-21 Thread Yui Washizu
On 2024/08/13 15:14, Akihiko Odaki wrote: num_vfs is not migrated so use PCI_SRIOV_CTRL_VFE and PCI_SRIOV_NUM_VF instead. Signed-off-by: Akihiko Odaki --- include/hw/pci/pcie_sriov.h | 1 - hw/pci/pcie_sriov.c | 38 +++--- hw/pci/trace-events

[PATCH] tests/functional: Convert mips fuloong2e avocado test

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Since the asset is expected locally and the test is guarded with QEMU_TEST_ALLOW_UNTRUSTED_CODE, keep it under the 'quick' category. $ RESCUE_YL_PATH=/path/to/rescue-yl QEMU_TEST

Re: [PATCH] roms: Support compile the efi bios for loongarch

2024-08-21 Thread Gerd Hoffmann
On Wed, Jul 24, 2024 at 10:22:45AM GMT, Xianglai Li wrote: > Added loongarch UEFI BIOS support to compiled scripts. > But now, the UEFI code of loongarch virtual machine has been migrated > from edK2-platform to edk2 repository. The migration work was completed > and merged into edk2 main line o

Re: [PATCH for-9.2 v6 04/12] pci-ids.rst: add Red Hat pci-id for RISC-V IOMMU device

2024-08-21 Thread Gerd Hoffmann
On Thu, Aug 01, 2024 at 12:43:25PM GMT, Daniel Henrique Barboza wrote: > The RISC-V IOMMU PCI device we're going to add next is a reference > implementation of the riscv-iommu spec [1], which predicts that the > IOMMU can be implemented as a PCIe device. > > However, RISC-V International (RVI), th

Re: [PATCH] tests/functional: Convert mips fuloong2e avocado test

2024-08-21 Thread Thomas Huth
On 21/08/2024 13.29, Philippe Mathieu-Daudé wrote: Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Since the asset is expected locally and the test is guarded with QEMU_TEST_ALLOW_UNTRUSTED_CODE, keep it under the 'quick' categ

Re: [PATCH v4 26/35] tests/functional: Convert the ppc_hv avocado test into a standalone test

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: A straight forward conversion, we just also have to remove the decorator @skipUnless(os.getenv('SPEED')) since all non-trivial functional tests are running in SPEED=thorough mode now. Also make sure that the extracted assets are writable, so that the test does

Re: [PATCH v8 3/5] migration: Add migration parameters for QATzip

2024-08-21 Thread Prasad Pandit
On Tue, 20 Aug 2024 at 22:40, Yichen Wang wrote: > Adds support for migration parameters to control QATzip compression > level and to enable/disable software fallback when QAT hardware is > unavailable. This is a preparatory commit for a subsequent commit that > will actually use QATzip compressio

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-08-21 Thread Sahil
Hi, Sorry for the late reply. On Tuesday, August 13, 2024 12:23:55 PM GMT+5:30 Eugenio Perez Martin wrote: > [...] > > I think I have understood what's going on in "vhost_vdpa_svq_map_rings", > > "vhost_vdpa_svq_map_ring" and "vhost_vdpa_dma_map". But based on > > what I have understood it looks

[PATCH 2/4] hw/ufs: ufs flag read/write test implemented

2024-08-21 Thread 정유찬
>From fa2187660e82e7772c2061b22ba9eab95e92f77c Mon Sep 17 00:00:00 2001 From: Yoochan Jeong Date: Wed, 21 Aug 2024 09:08:18 +0900 Subject: [PATCH 2/4] hw/ufs: ufs flag read/write test implemented New test function "ufstest_flag_request" added, which can check one's virtual UFS device can properly

[PATCH 0/4] hw/ufs: ufs device testing function added and modified

2024-08-21 Thread 정유찬
>From 936ef0a907bcf16809f9980c2d37e8fcb13697d2 Mon Sep 17 00:00:00 2001 From: Yoochan Jeong Date: Wed, 21 Aug 2024 10:45:28 +0900 Subject: [PATCH 0/4] hw/ufs: ufs device testing function added and modified Previously, it was only able to test virtual UFS devices if they properly read and write st

[PATCH 0/4] hw/ufs: ufs device testing function added and modified

2024-08-21 Thread 정유찬
From 936ef0a907bcf16809f9980c2d37e8fcb13697d2 Mon Sep 17 00:00:00 2001 From: Yoochan Jeong Date: Wed, 21 Aug 2024 10:45:28 +0900 Subject: [PATCH 0/4] hw/ufs: ufs device testing function added and modified Previously, it was only able to test virtual UFS devices if they properly read a

[PATCH 3/4] hw/ufs: ufs attribute read/write test implemented

2024-08-21 Thread 정유찬
>From 3341c347a70783c5e60a963501e63cb5da8f2e1f Mon Sep 17 00:00:00 2001 From: Yoochan Jeong Date: Wed, 21 Aug 2024 09:09:32 +0900 Subject: [PATCH 3/4] hw/ufs: ufs attribute read/write test implemented New test function "ufstest_attr_request" added, which can check one's virtual UFS device can pro

[PATCH 1/4] hw/ufs: minor bug fixes related to ufs-test

2024-08-21 Thread 정유찬
>From d0ae8e25aec4ae7d222a2ea667d5ddb61f14fe02 Mon Sep 17 00:00:00 2001 From: Yoochan Jeong Date: Wed, 21 Aug 2024 09:03:06 +0900 Subject: [PATCH 1/4] hw/ufs: minor bug fixes related to ufs-test Minor bugs and errors related to ufs-test are resolved. Some permissions and code implementations that

Re: [PATCH 1/2] tests/functional: Convert mips64el Malta I6400 avocado tests

2024-08-21 Thread Thomas Huth
On 21/08/2024 14.57, Philippe Mathieu-Daudé wrote: Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + tests/avocado/machine_mips_malta.

[PATCH 1/2] tests/functional: Convert mips64el Malta I6400 avocado tests

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + tests/avocado/machine_mips_malta.py | 108 --- tests/functional/

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2024-08-21 Thread Igor Mammedov
On Thu, 27 Apr 2023 17:10:06 -0400 Alexander Bulekov wrote: > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > This flag is set/checked prior to calling a device's MemoryRegion > handlers, and set when device code initiates DMA. The purpose of this > flag is to prevent

[PATCH 2/2] tests/functional: Convert mipsel Malta YAMON avocado test

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion using the Python standard zipfile module instead of avocado.utils package. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- tests/avocado/

[RFC 0/2] Handling aliased guest memory maps in vhost-vDPA SVQs

2024-08-21 Thread Jonah Palmer
The guest may overlap guest memory regions when mapping IOVA to HVA translations in the IOVA->HVA tree. This means that different HVAs, that correspond to different guest memory region mappings, may translate to the same IOVA. This can cause conflicts when a mapping is incorrectly referenced. For

Re: [PATCH] tests/functional: Convert mips fuloong2e avocado test

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 13:46, Thomas Huth wrote: On 21/08/2024 13.29, Philippe Mathieu-Daudé wrote: Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Since the asset is expected locally and the test is guarded with QEMU_TEST_ALLOW_UNTRUSTED

Issue with QEMU Live Migration

2024-08-21 Thread Arisetty, Chakri
Hello, I’m having trouble with live migration and I’m using QEMU 7.2.0 on Debian 11. Migration state switches to pre-switchover state during the RAM migration. My assumption is that disks are already migrated and there are no further dirty pages to be transferred from source host to destination

Re: [PATCH RFC V3 17/29] arm/virt: Release objects for *disabled* possible vCPUs after init

2024-08-21 Thread Gavin Shan
Hi Salil, On 8/21/24 8:23 PM, Salil Mehta wrote: On 8/21/24 2:40 AM, Salil Mehta wrote: > > I don’t understand this clearly. Are you suggesting to reuse only > single vCPU object to initialize all KVM vCPUs not yet plugged? If > yes, then I'm not sure what do we gain here by adding

[PATCH v2 0/3] tests/functional: Convert few MIPS avocado tests

2024-08-21 Thread Philippe Mathieu-Daudé
1/4 qemu:func-quick+func-mipsel / func-mipsel-empty_cpu_model OK 0.64s 1 subtests passed 2/4 qemu:func-quick+func-mipsel / func-mipsel-version OK 0.65s 1 subtests passed 3/4 qemu:func-quick+func-mipsel / func-mipsel-info_

[PATCH v2 2/3] tests/functional: Convert mips64el Malta I6400 avocado tests

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + tests/avocado/machine_mips_malta.py | 108

[PATCH v2 1/3] tests/functional: Convert mips fuloong2e avocado test

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Since the asset is expected locally and the test is guarded with QEMU_TEST_ALLOW_UNTRUSTED_CODE, keep it under the 'quick' category. $ RESCUE_YL_PATH=/path/to/rescue-yl QEMU_TEST

[PATCH v2 3/3] tests/functional: Convert mipsel Malta YAMON avocado test

2024-08-21 Thread Philippe Mathieu-Daudé
Straight forward conversion using the Python standard zipfile module instead of avocado.utils package. Update the SHA1 hashes to SHA256 hashes since SHA1 should not be used anymore nowadays. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- tests/avocado/

[RFC 2/2] vhost-vdpa: Implement GPA->IOVA & IOVA->SVQ HVA trees

2024-08-21 Thread Jonah Palmer
Implements a GPA->IOVA and IOVA->SVQ HVA tree for handling mapping, unmapping, and translations for guest and host-only memory, respectively. By splitting up a full IOVA->HVA tree (containing both guest and host-only memory mappings) into a GPA->IOVA tree (containing only guest memory mappings) an

Re: [PATCH v2] hw/acpi/ich9: Add periodic and swsmi timer

2024-08-21 Thread Dominic Prinz
Ping https://patchew.org/QEMU/1e4d59a49e7f2e02cf522e799a7bf5f3fa3fba1f.1722414006.git@dprinz.de/ https://lore.kernel.org/qemu-devel/1e4d59a49e7f2e02cf522e799a7bf5f3fa3fba1f.1722414006.git@dprinz.de/ On Wed Jul 31, 2024 at 10:28 AM CEST, Dominic Prinz wrote: > This patch implements the per

Re: [PATCH v4 4/6] machine/nitro-enclave: Add built-in Nitro Secure Module device

2024-08-21 Thread Dorjoy Chowdhury
Hey Daniel, The libvirt-ci repository has been updated with the libcbor dependency. Should I just update my submodule locally to point to the new master branch and then do a separate commit i.e., "Updated submodule..." and _then_ do this[1] as part of whatever commit introduces the libcbor dependen

[RFC 1/2] vhost-vdpa: Decouple the IOVA allocator

2024-08-21 Thread Jonah Palmer
Decouples the IOVA allocator from the IOVA->HVA tree and instead adds the allocated IOVA range to an IOVA-only tree (iova_map). This IOVA tree will hold all IOVA ranges that have been allocated (e.g. in the IOVA->HVA tree) and are removed when any IOVA ranges are deallocated. A new API function vh

[PATCH 0/2] tests/functional: Convert MIPS Malta avocado tests

2024-08-21 Thread Philippe Mathieu-Daudé
Based-on: <20240821082748.65853-1-th...@redhat.com> Philippe Mathieu-Daudé (2): tests/functional: Convert mips64el Malta I6400 avocado tests tests/functional: Convert mipsel Malta YAMON avocado test MAINTAINERS | 3 +- tests/functional/meson.build

Re: Issue with QEMU Live Migration

2024-08-21 Thread Fabiano Rosas
"Arisetty, Chakri" writes: > Hello, > > I’m having trouble with live migration and I’m using QEMU 7.2.0 on Debian 11. > > Migration state switches to pre-switchover state during the RAM migration. > > My assumption is that disks are already migrated and there are no further > dirty pages to be t

Re: [PATCH v4 1/2] cxl/core: introduce device reporting poison hanlding

2024-08-21 Thread Shiyang Ruan via
在 2024/8/9 2:28, Fan Ni 写道: On Thu, Aug 08, 2024 at 11:13:27PM +0800, Shiyang Ruan wrote: CXL device can find&report memory problems, even before MCE is detected by CPU. AFAIK, the current kernel only traces POISON error event from FW-First/OS-First path, but it doesn't handle them, neither

Re: [PATCH] ppc: fixed incorrect name filed in vmstate_tlbemb_entry

2024-08-21 Thread Physics Набиев
Sorry for not providing enough argumentation for my patch. I found a configuration where this error occurs. Please take a look at https://gitlab.com/qemu-project/qemu/-/issues/2522. вт, 20 авг. 2024 г. в 19:20, Peter Maydell : > On Tue, 20 Aug 2024 at 17:03, wrote: > > > > From: armanincredible

Re: [PATCH] hw/char: suppress sunmouse events with no changes

2024-08-21 Thread Mark Cave-Ayland
On 20/08/2024 08:34, Richard Henderson wrote: On 8/20/24 09:18, Carl Hauser wrote: @@ -959,6 +960,15 @@ static void sunmouse_event(void *opaque,   int ch;   trace_escc_sunmouse_event(dx, dy, buttons_state); + +    /* Don't send duplicate events without motion */ +    if (dx == 0 && +  

Re: [PATCH v5 1/3] tests/acpi: pc: allow DSDT acpi table changes

2024-08-21 Thread Igor Mammedov
On Wed, 14 Aug 2024 11:56:09 + Ricardo Ribalda wrote: > Signed-off-by: Ricardo Ribalda Reviewed-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h >

Re: [PATCH v4 11/35] tests/functional: Prepare the meson build system for the functional tests

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: Provide a meson.build file for the upcoming python-based functional tests, and add some wrapper glue targets to the tests/Makefile.include file. We are going to use two "speed" modes for the functional tests: The "quick" tests can be run at any time (i.e. also

Re: [PATCH 1/5] hw: Remove unused inclusion of hw/char/serial.h

2024-08-21 Thread Mark Cave-Ayland
On 14/08/2024 19:15, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/char/riscv_htif.c | 1 - hw/ppc/prep.c| 1 - hw/riscv/sifive_e.c | 1 - hw/riscv/sifive_u.c | 1 - 4 files changed, 4 deletions(-) diff --git a/hw/char/riscv_htif.c b/hw/char/riscv_htif.c index

Re: [PATCH 3/5] hw/ppc/Kconfig: Add missing SERIAL_ISA dependency to POWERNV machine

2024-08-21 Thread Mark Cave-Ayland
On 14/08/2024 19:15, Bernhard Beschow wrote: The machine calls serial_hds_isa_init() which is provided by serial-isa.c, guarded by SERIAL_ISA. Signed-off-by: Bernhard Beschow --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index c235519

Re: [PATCH v5 3/3] tests/acpi: pc: update golden masters for DSDT

2024-08-21 Thread Igor Mammedov
On Wed, 14 Aug 2024 11:56:11 + Ricardo Ribalda wrote: > Signed-off-by: Ricardo Ribalda Acked-by: Igor Mammedov > --- > tests/data/acpi/x86/pc/DSDT | Bin 6830 -> 8527 bytes > tests/data/acpi/x86/pc/DSDT.acpierst| Bin 6741 -> 8438 bytes > tests/data/acpi/x86/pc/DSD

Re: [PATCH 4/5] hw/char/serial.h: Extract serial-isa.h

2024-08-21 Thread Mark Cave-Ayland
On 14/08/2024 19:15, Bernhard Beschow wrote: The includes where updated based on compile errors. Now, the inclusion of the header roughly matches Kconfig dependencies: # grep -r -e "select SERIAL_ISA" hw/ppc/Kconfig:select SERIAL_ISA hw/isa/Kconfig:select SERIAL_ISA hw/sparc

Re: [PATCH v5 0/3] hw/i386/acpi: Pre-compute the _PRT table

2024-08-21 Thread Igor Mammedov
On Wed, 14 Aug 2024 11:56:08 + Ricardo Ribalda wrote: > Today for x86 the _PRT() table is computed in runtime. > Under some configurations, computing the _PRT table can take more than > 30 seconds and the ACPI timeout is violated. > > This patchset modifies _PRT() to return a pre-computed ta

Re: [PATCH 5/5] hw/char: Extract serial-mm

2024-08-21 Thread Mark Cave-Ayland
On 14/08/2024 19:15, Bernhard Beschow wrote: hw/char/serial currently contains the implementation of both TYPE_SERIAL and TYPE_SERIAL_MM. According to serial_class_init(), TYPE_SERIAL is an internal class while TYPE_SERIAL_MM is used by numerous machine types directly. Let's move the latter into

Re: [PATCH v4 14/35] tests/functional: add a module for handling asset download & caching

2024-08-21 Thread Philippe Mathieu-Daudé
On 21/8/24 10:27, Thomas Huth wrote: From: Daniel P. Berrangé The 'Asset' class is a simple module that declares a downloadable asset that can be cached locally. Downloads are stored in the user's home dir at ~/.cache/qemu/download, using a sha256 sum of the URL. Signed-off-by: Daniel P. Berra

Re: [PATCH] tests/avocado: Move LinuxTest related code into a separate file

2024-08-21 Thread Philippe Mathieu-Daudé
On 19/7/24 11:50, Thomas Huth wrote: Only some few tests are using the LinuxTest class. Move the related code into a separate file so that this does not pollute the main namespace. Signed-off-by: Thomas Huth --- tests/avocado/avocado_qemu/__init__.py | 239 +- tests/avoc

Re: [PATCH] tests/avocado: Move LinuxTest related code into a separate file

2024-08-21 Thread Thomas Huth
On 21/08/2024 17.11, Philippe Mathieu-Daudé wrote: On 19/7/24 11:50, Thomas Huth wrote: Only some few tests are using the LinuxTest class. Move the related code into a separate file so that this does not pollute the main namespace. Signed-off-by: Thomas Huth ---   tests/avocado/avocado_qemu/__

[PATCH] tests/avocado: Allow running user-mode tests

2024-08-21 Thread Philippe Mathieu-Daudé
Commit 816d4201ea ("tests/avocado: Move LinuxTest related code into a separate file") removed the Avocado 'process' import which is used by the QemuUserTest class, restore it. Fixes: 816d4201ea ("tests/avocado: Move LinuxTest ...") Signed-off-by: Philippe Mathieu-Daudé --- Unfortunately the singl

Re: [PATCH] ppc: fixed incorrect name filed in vmstate_tlbemb_entry

2024-08-21 Thread Peter Maydell
On Wed, 21 Aug 2024 at 15:08, Physics Набиев wrote: > > Sorry for not providing enough argumentation for my patch. I found a > configuration where this error occurs. Please take a look at > https://gitlab.com/qemu-project/qemu/-/issues/2522. Hmm. I don't understand why fixing this field name wo

Re: Issue with QEMU Live Migration

2024-08-21 Thread Arisetty, Chakri
Hi, Thank you for getting back to me. Yes, I have opened the ticket https://urldefense.com/v3/__https://gitlab.com/qemu-project/qemu/-/issues/2482__;!!GjvTz_vk!SCg-a5LiuAGlWyQ6Opd9urNAW4_Z-tUtzPZARWB1d3Ulg_ws87yL3iJcxuZPktLeHNNtPztJTJZNJdE$

Re: [PATCH V2 06/11] migration: fix mismatched GPAs during cpr

2024-08-21 Thread Peter Xu
On Fri, Aug 16, 2024 at 01:10:02PM -0400, Steven Sistare wrote: > On 8/16/2024 10:43 AM, Peter Xu wrote: > > On Thu, Aug 15, 2024 at 04:54:58PM -0400, Steven Sistare wrote: > > > On 8/13/2024 4:43 PM, Peter Xu wrote: > > > > On Wed, Aug 07, 2024 at 05:04:26PM -0400, Steven Sistare wrote: > > > > >

Re: [PATCH] hw/char: suppress sunmouse events with no changes

2024-08-21 Thread Carl Hauser via
More on whether the sunmouse_prev_state needs to be migrated. I think that if it were NOT included in the migration state the following would hold, assuming that it would be initialized to 0 in the "to" environment: 1. If prev_state is 0 in the "from" environment the prev_state in the "to" environm

  1   2   >