Re: [PATCH v2 05/24] target/riscv: tracking indirect branches (fcfi) for zicfilp

2024-08-01 Thread Deepak Gupta
On Mon, Jul 29, 2024 at 7:34 PM Richard Henderson wrote: > > On 7/30/24 03:53, Deepak Gupta wrote: > > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > > index acba90f170..c746d7df08 100644 > > --- a/target/riscv/translate.c > > +++ b/target/riscv/translate.c > > @@ -20,6 +20,7 @

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Akihiko Odaki
On 2024/07/31 17:32, Markus Armbruster wrote: Akihiko Odaki writes: rom_bar is tristate but was defined as uint32_t so convert it into OnOffAuto to clarify that. For compatibility, a uint32 value set via QOM will be converted into OnOffAuto. Signed-off-by: Akihiko Odaki I agree making prop

Re: [PATCH v2 09/24] linux-user/riscv: implement indirect branch tracking prctls

2024-08-01 Thread Deepak Gupta
On Mon, Jul 29, 2024 at 11:27 PM Richard Henderson wrote: > > On 7/30/24 03:53, Deepak Gupta wrote: > > +/* set or clear branch tracking */ > > +env->ufcfien = (flag & PR_INDIR_BR_LP_ENABLE); > > +tb_flush(env_cpu(env)); > > tb_flush is not required when you tra

Re: [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation

2024-08-01 Thread Akihiko Odaki
On 2024/07/31 17:58, Cédric Le Goater wrote: On 7/30/24 19:56, Michael S. Tsirkin wrote: On Tue, Jul 30, 2024 at 09:26:20PM +0900, Akihiko Odaki wrote: On 2024/07/30 20:37, Michael S. Tsirkin wrote: On Mon, Jul 15, 2024 at 02:19:06PM +0900, Akihiko Odaki wrote: Based-on: <20240714-rombar-v2-0

Re: QEMU unexpectedly closed the monitor

2024-08-01 Thread Itaru Kitayama
> On Jul 31, 2024, at 19:34, Daniel P. Berrangé wrote: > > On Wed, Jul 31, 2024 at 11:29:01AM +0100, Peter Maydell wrote: >> On Wed, 31 Jul 2024 at 10:52, Alex Bennée wrote: >>> You then need to manually strip out all the various chardevs for libvirt >>> control sockets and you can an equival

[PATCH] Cleanup: rename virtio_split_packed_update_used_idx

2024-08-01 Thread Wenyu Huang
virtio_split_packed_update_used_idx should be virtio_queue_split_update_used_idx like virtio_split_packed_update_used_idx. Signed-off-by: Wenyu Huang --- hw/virtio/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 397c2

[PATCH v2 0/1] Brief description of the patch series

2024-08-01 Thread Lei Huang
The purpose of this patch is customize refresh rate and resolution for the guest VM instead of being limited by the actual resolution of the host. Although it is possible to configure the VM kernel cmdline to set the EDID, such as with drm.edid_firmware=edid/1920x1080.bin, this approach is very

Re: [RFC PATCH 0/6] Enable shared device assignment

2024-08-01 Thread Yin, Fengwei
Hi David, On 7/26/2024 3:20 PM, David Hildenbrand wrote: Yes, there have been discussions about that, also in the context of supporting huge pages while allowing for the guest to still convert individual 4K chunks ... A summary is here [1]. Likely more things will be covered at Linux Plumber

[PATCH v2 1/1] virtio-gpu: customize EDID for vms

2024-08-01 Thread Lei Huang
customize refresh rate and resolution for the guest VM instead of being limited by the actual resolution of the host. add edid info and modify conf like: "-device", "virtio-vga-gl,edid=on,max_outputs=2, refresh_rate0=12,maxx0=7680,maxy0=1080,refresh_rate1=75000, maxx1=3840,maxy1=960" Change-I

Re: [PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-08-01 Thread Cédric Le Goater
Hello Aditya, On 7/31/24 22:10, Aditya Gupta wrote: Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The existing behaviour when -dtb is 'not' passed, is pre

Re: [PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-08-01 Thread Cédric Le Goater
On 8/1/24 09:44, Cédric Le Goater wrote: -    /* Pack resulting tree */ -    _FDT((fdt_pack(fdt))); +    /* read the file 'machine->dtb', and load it into 'fdt' buffer */ +    if (!g_file_get_contents(machine->dtb, (gchar **)&fdt, NULL, NULL)) { +    error_report("Could not load

Re: [PATCH v5 0/8] virtio-net: add support for SR-IOV emulation

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 04:13:14PM +0900, Akihiko Odaki wrote: > I think it is a good idea to revert these patches for now OK I reverted the 2 patchsets. there were some bugfixes there but I had to revert them too due to the dependency. If appropriate, feel free to resubmit just the fixes. -- MS

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 04:01:44PM +0900, Akihiko Odaki wrote: > rom_bar_set() and and underlying visit_type_str_preserving() are ugly, but > we can remove them once the deprecation period ends. On the other hand, if > we don't make this change, dev->opts will keep floating around, and we will > ev

[PATCH 1/2] target/i386: Split out gen_prepare_val_nz

2024-08-01 Thread Richard Henderson
Split out the TCG_COND_TSTEQ logic from gen_prepare_eflags_z, and use it for CC_OP_BMILG* as well. Prepare for requiring both zero and non-zero senses. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-)

[PATCH 0/2] target/i386: Fix carry flag for BLSI

2024-08-01 Thread Richard Henderson
Fix #2175. r~ Richard Henderson (2): target/i386: Split out gen_prepare_val_nz target/i386: Fix carry flag for BLSI target/i386/cpu.h| 5 + target/i386/tcg/cc_helper.c | 18 target/i386/tcg/translate.c | 27

[PATCH 2/2] target/i386: Fix carry flag for BLSI

2024-08-01 Thread Richard Henderson
BLSI has inverted semantics for C as compared to the other two BMI1 instructions, BLSMSK and BLSR. Introduce CC_OP_BLSI* for this purpose. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2175 Signed-off-by: Richard Henderson --- target/i386/cpu.h| 5 + targe

Re: [PULL v2 17/61] virtio-snd: check for invalid param shift operands

2024-08-01 Thread Michael S. Tsirkin
On Sat, Jul 27, 2024 at 08:55:10AM +0200, Volker Rümelin wrote: > > From: Manos Pitsidianakis > > > > When setting the parameters of a PCM stream, we compute the bit flag > > with the format and rate values as shift operand to check if they are > > set in supported_formats and supported_rates. > >

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

2024-08-01 Thread Eugenio Perez Martin
On Thu, Aug 1, 2024 at 2:41 AM Si-Wei Liu wrote: > > Hi Jonah, > > On 7/31/2024 7:09 AM, Jonah Palmer wrote: > > > >> Let me clarify, correct me if I was wrong: > >> > >> 1) IOVA allocator is still implemented via a tree, we just > >> don't need > >> to stor

Re: [PATCH] bsd-user/main: Allow setting tb-size

2024-08-01 Thread Ilya Leoshkevich
On Wed, 2024-07-31 at 15:21 -0600, Warner Losh wrote: > On Wed, Jul 31, 2024 at 8: 45 AM Ilya Leoshkevich > wrote: While qemu-system can set tb-size using > -accel tcg,tb-size=n, there is no similar knob for qemu-bsd-user. Add > one in a way similar to how one-insn-per-tb is already > > > > On

Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread Michael S. Tsirkin
On Sun, Jul 21, 2024 at 11:20:56AM +0800, BillXiang wrote: > > > From: "Michael S. Tsirkin" > > Date:  Sun, Jul 21, 2024, 03:01 > > Subject:  Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent > > VHOST_USER_SET_LOG_BASE > > To: "BillXiang" > > Cc: > > typos in subject do not inspire

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-08-01 Thread Vladimir Sementsov-Ogievskiy
On 01.07.24 23:55, Michael S. Tsirkin wrote: On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: I have no issues with these APIs, but I'm not a QMP expert so others should review those bits. For the vhost-user-blk code: Acked-by: Raphael Norwitz Could the relevant bits get ack

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-08-01 Thread Igor Mammedov
On Wed, 31 Jul 2024 09:57:19 +0100 Jonathan Cameron wrote: > On Wed, 31 Jul 2024 09:11:33 +0200 > Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Jul 2024 13:17:09 +0200 > > Igor Mammedov escreveu: > > > > > On Mon, 22 Jul 2024 08:45:56 +0200 > > > Mauro Carvalho Chehab wrote: [...] > > > Pr

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 11:35:19AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 01.07.24 23:55, Michael S. Tsirkin wrote: > > On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: > > > I have no issues with these APIs, but I'm not a QMP expert so others > > > should review those bits

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Akihiko Odaki
On 2024/08/01 16:52, Michael S. Tsirkin wrote: On Thu, Aug 01, 2024 at 04:01:44PM +0900, Akihiko Odaki wrote: rom_bar_set() and and underlying visit_type_str_preserving() are ugly, but we can remove them once the deprecation period ends. On the other hand, if we don't make this change, dev->opts

Re: [PATCH v5 0/3] vhost-user-blk: live resize additional APIs

2024-08-01 Thread Vladimir Sementsov-Ogievskiy
On 01.08.24 11:37, Michael S. Tsirkin wrote: On Thu, Aug 01, 2024 at 11:35:19AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 01.07.24 23:55, Michael S. Tsirkin wrote: On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote: I have no issues with these APIs, but I'm not a QMP expert so

[PATCH] char-socket: grow timeout from smaller value

2024-08-01 Thread Vladimir Sementsov-Ogievskiy
The smallest possible timeout for reconnect to set in QAPI is 1 second. But for system where reconnect is considered a regular situation and backend is guaranteed to start in tens of milliseconds this timeout of 1 second becomes an extra throttling. On the other hand, just allowing smaller timeout

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread David Woodhouse
On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > Perfect. So as and when the header is in its final form in Linux, > > it can be part of the automated import and we'll use that version. > > At that point we can drop the one that's sitting alongside the > > device itself in hw/acp

Re: [PATCH] hw/ppc: Implement -dtb support for PowerNV

2024-08-01 Thread Aditya Gupta
Hello Cedric, <...snip...> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 3526852685b4..03600fa62cbd 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -736,10 +736,21 @@ static void pnv_reset(MachineState *machine, ShutdownCause reason)   }   }   -    fdt = pnv_dt_create(machine);

[PATCH v2] hw/ppc: Implement -dtb support for PowerNV

2024-08-01 Thread Aditya Gupta
Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The existing behaviour when -dtb is 'not' passed, is preserved as-is. But when a '-dtb' is passed, it complete

Re: [PATCH v2 05/24] target/riscv: tracking indirect branches (fcfi) for zicfilp

2024-08-01 Thread Richard Henderson
On 8/1/24 16:59, Deepak Gupta wrote: hmm... you've suggested below to use `aarch64_tr_translate_insn` and check if it's the first instruction. and put the check there. In that case I won't need FCFI_LP_EXPECTED TB flag. Then I would rather use it as FCFI_ENABLED TB flag. You will need both bits

[PATCH-for-9.1] hw/pci-host/gt64120: Set PCI base address register write mask

2024-08-01 Thread Philippe Mathieu-Daudé
When booting Linux we see: PCI host bridge to bus :00 pci_bus :00: root bus resource [mem 0x1000-0x17ff] pci_bus :00: root bus resource [io 0x1000-0x1f] pci_bus :00: No busn resource found for root bus, will use [bus 00-ff] pci :00:00.0: [11ab:4620] type

Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object

2024-08-01 Thread Zhao Liu
On Thu, Jul 25, 2024 at 11:07:12AM +0200, Markus Armbruster wrote: > Date: Thu, 25 Jul 2024 11:07:12 +0200 > From: Markus Armbruster > Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache > object > > Zhao Liu writes: > > > Hi Markus and Daniel, > > > > I have the questions

Re: [PULL 02/22] tests/avocado: use snapshot=on in kvm_xen_guest

2024-08-01 Thread David Woodhouse
On Fri, 2024-01-12 at 11:04 +, Alex Bennée wrote: > This ensures the rootfs is never permanently changed as we don't need > persistence between tests anyway. > > Message-Id: <20240103173349.398526-3-alex.ben...@linaro.org> > Signed-off-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé >

Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread BillXiang
> From: "Michael S. Tsirkin" > Date:  Thu, Aug 1, 2024, 16:26 > Subject:  Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: > On Sun, Jul 21, 2024 at 11:20:56AM +0800, BillXiang wrote: > >  > > > From: "Michael S. Tsirkin" > > > Dat

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 09:49:06AM +0100, David Woodhouse wrote: > On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > > > Perfect. So as and when the header is in its final form in Linux, > > > it can be part of the automated import and we'll use that version. > > > At that point w

Re: [PATCH v2] hw/ppc: Implement -dtb support for PowerNV

2024-08-01 Thread Cédric Le Goater
On 8/1/24 10:51, Aditya Gupta wrote: Currently any device tree passed with -dtb option in QEMU, was ignored by the PowerNV code. Read and pass the passed -dtb to the kernel, thus enabling easier debugging with custom DTBs. The existing behaviour when -dtb is 'not' passed, is preserved as-is. B

Re: [PATCH v2] hw/acpi: Add vmclock device

2024-08-01 Thread David Woodhouse
On Thu, 2024-08-01 at 05:48 -0400, Michael S. Tsirkin wrote: > On Thu, Aug 01, 2024 at 09:49:06AM +0100, David Woodhouse wrote: > > On Wed, 2024-07-31 at 17:19 -0400, Michael S. Tsirkin wrote: > > > > > > > Perfect. So as and when the header is in its final form in Linux, > > > > it can be part of

Re: [PATCH v3 04/24] tests/Makefile.include: Increase the level of indentation in the help text

2024-08-01 Thread Alex Bennée
Daniel P. Berrangé writes: > From: Thomas Huth > > The next patch is going to add some entries that need more space between > the command and the help text, so let's increase the indentation here > first. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Thomas Huth Reviewed-by: Alex B

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Manish
On 31/07/24 9:01 pm, Xiaoyao Li wrote: !---|  CAUTION: External Email |---! On 7/31/2024 4:49 PM, John Levon wrote: On Wed, Jul 31, 2024 at 03:02:15PM +0800, Xiaoya

[PATCH-for-9.1?] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-01 Thread Philippe Mathieu-Daudé
When BAR aren't configured, we get: (qemu) info pci Bus 0, device 0, function 0: Host bridge: PCI device dead:beef ... BAR4: 32 bit memory at 0x [0x0ffe]. BAR5: I/O at 0x [0x0ffe]. Improve logging to not display bogus size

Re: [PATCH v3 02/24] tests/functional: Add base classes for the upcoming pytest-based tests

2024-08-01 Thread Daniel P . Berrangé
On Wed, Jul 31, 2024 at 03:24:35PM +0100, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > From: Thomas Huth > > > > The file is mostly a copy of the tests/avocado/avocado_qemu/__init__.py > > file with some adjustments to get rid of the Avocado dependencies (i.e. > > we also have to drop t

Re: [PATCH v3 16/24] tests/functional: Convert the riscv_opensbi avocado test into a standalone test

2024-08-01 Thread Daniel P . Berrangé
On Thu, Aug 01, 2024 at 09:00:36AM +1000, Richard Henderson wrote: > On 7/31/24 22:56, Philippe Mathieu-Daudé wrote: > > On 30/7/24 19:03, Daniel P. Berrangé wrote: > > > From: Thomas Huth > > > > > > The avocado test defined test functions for both, riscv32 and riscv64. > > > Since we can run th

Re: [PATCH v3 03/24] tests/functional: Set up logging

2024-08-01 Thread Alex Bennée
Daniel P. Berrangé writes: > From: Thomas Huth > > Create log files for each test separately, one file that contains > the basic logging and one that contains the console output. > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Thomas Huth > --- > tests/functional/qemu_test/testcase.py |

Re: [PATCH-for-9.1] hw/pci-host/gt64120: Set PCI base address register write mask

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 11:13:32AM +0200, Philippe Mathieu-Daudé wrote: > When booting Linux we see: > > PCI host bridge to bus :00 > pci_bus :00: root bus resource [mem 0x1000-0x17ff] > pci_bus :00: root bus resource [io 0x1000-0x1f] > pci_bus :00: No busn res

[PATCH] include: Fix typo in name of MAKE_IDENTFIER macro

2024-08-01 Thread Peter Maydell
In commit bb71846325e23 we added some macro magic to avoid variable-shadowing when using some of our more complicated macros. One of the internal components of this is a macro named MAKE_IDENTFIER. Fix the typo in its name: it should be MAKE_IDENTIFIER. Commit created with sed -i -e 's/MAKE_IDENT

Re: [PATCH v1] target/i386: Always set leaf 0x1f

2024-08-01 Thread Igor Mammedov
On Thu, 1 Aug 2024 15:36:10 +0530 Manish wrote: > On 31/07/24 9:01 pm, Xiaoyao Li wrote: > > !---| > >  CAUTION: External Email > > > > |---! > > > > On 7/31/2024 4:49 P

Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 05:48:36PM +0800, BillXiang wrote: > > > From: "Michael S. Tsirkin" > > Date:  Thu, Aug 1, 2024, 16:26 > > Subject:  Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent > > VHOST_USER_SET_LOG_BASE > > To: "BillXiang" > > Cc: > > On Sun, Jul 21, 2024 at 11:20:56

Re: [PATCH-for-9.1?] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 12:07:42PM +0200, Philippe Mathieu-Daudé wrote: > When BAR aren't configured, we get: > > (qemu) info pci > Bus 0, device 0, function 0: > Host bridge: PCI device dead:beef > ... > BAR4: 32 bit memory at 0x [0x0ffe]. >

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-08-01 Thread Sandesh Patel
> On 11 Jul 2024, at 12:56 PM, David Woodhouse wrote: > > On Mon, 2024-07-08 at 10:13 +0100, David Woodhouse wrote: >> On Wed, 2024-07-03 at 16:01 +, Sandesh Patel wrote: Interesting. What exactly has Windows *done* in those MSI entries? That might give a clue about how to s

[PULL 00/19] virtio,pci,pc: fixes

2024-08-01 Thread Michael S. Tsirkin
The following changes since commit e9d2db818ff934afb366aea566d0b33acf7bced1: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-08-01 07:31:49 +1000) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream f

[PULL 07/19] Revert "pcie_sriov: Ensure PF and VF are mutually exclusive"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 78f9d7fd1989311040beff54979bcb2a1ba0aff2. Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie_sriov.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 6c79658b4c..56523ab4e8 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pci

[PULL 01/19] virtio-rng: block max-bytes=0

2024-08-01 Thread Michael S. Tsirkin
with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Message-Id: <73a89a42d82ec8b47358f25119b87063e4a6ea57.1721818306.git@redhat.com> Signed-off-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-rng.c | 5 +++-- 1

[PULL 05/19] Revert "pcie_sriov: Allow user to create SR-IOV device"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 122173a5830f7757f8a94a3b1559582f312e140b. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_device.h | 6 +- include/hw/pci/pcie_sriov.h | 18 --- hw/pci/pci.c| 62 +++- hw/pci/pcie_sriov.c | 290 4 f

[PULL 02/19] Revert "docs: Document composable SR-IOV device"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit d6f40c95b35bd380340b698e4306704fe22a5d68. Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 1 - docs/system/index.rst | 1 - docs/system/sriov.rst | 36 3 files changed, 38 deletions(-) delete mode 100644 docs/system/sriov.

[PULL 03/19] Revert "virtio-net: Implement SR-IOV VF"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit c2d6db6a1f39780b24538440091893f9fbe060a7. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-net-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/virtio-net-pci.c b/hw/virtio/virtio-net-pci.c index dba4987d6e..e03543a70a 100644 --- a/hw/virtio/virtio-net

[PULL 08/19] Revert "hw/pci: Fix SR-IOV VF number calculation"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit ca6dd3aef8a103138c99788bcba8195d4905ddc5. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index cf2794879d..4c7be52951 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1437

[PULL 12/19] Revert "pcie_sriov: Reuse SR-IOV VF device instances"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 139610ae67f6ecf92127bb7bf53ac6265b459ec8. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h| 5 ++ include/hw/pci/pci_device.h | 15 -- include/hw/pci/pcie_sriov.h | 1 + hw/pci/pci.c| 2 +- hw/pci/pcie_sriov.c | 95

[PULL 14/19] Revert "pcie_sriov: Do not manually unrealize"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit c613ad25125bf3016aa8f81ce170f5ac91d2379f. Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie_sriov.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 499becd527..e9b23221d7 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pci

[PULL 11/19] Revert "pcie_sriov: Release VFs failed to realize"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 1a9bf009012e590cb166a4a9bae4bc18fb084d76. Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie_sriov.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 9bd7f8acc3..faadb0d2ea 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_s

[PULL 04/19] Revert "virtio-pci: Implement SR-IOV PF"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 3f868ffb0bae0c4feafabe34a371cded57fe3806. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-pci.h | 1 - hw/virtio/virtio-pci.c | 20 +--- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/include/hw/virtio/virtio-pci.h b/in

[PULL 17/19] Revert "hw/pci: Rename has_power to enabled"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 6a31b219a5338564f3978251c79f96f689e037da. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h| 7 +-- include/hw/pci/pci_device.h | 2 +- hw/pci/pci.c| 14 +++--- hw/pci/pci_host.c | 4 ++-- 4 files changed, 11 insertion

[PULL 19/19] intel_iommu: Fix for IQA reg read dropped DW field

2024-08-01 Thread Michael S. Tsirkin
From: yeeli If VT-D hardware supports scalable mode, Linux will set the IQA DW field (bit11). In qemu, the vtd_mem_write and vtd_update_iq_dw set DW field well. However, vtd_mem_read the DW field wrong because "& VTD_IQA_QS" dropped the value of DW. Replace "&VTD_IQA_QS" with "& (VTD_IQA_QS | VTD

[PULL 15/19] Revert "hw/ppc/spapr_pci: Do not reject VFs created after a PF"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 26f86093ec989cb73ad03e8a234f5dc321e1e267. Signed-off-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index ed4454bbf7..f63182a03c 100644 --- a/hw/ppc/spapr_pci.c +++ b

[PULL 13/19] Revert "pcie_sriov: Ensure VF function number does not overflow"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 77718701157f6ca77ea7a57b536fa0a22f676082. Signed-off-by: Michael S. Tsirkin --- docs/pcie_sriov.txt | 8 +++- include/hw/pci/pcie_sriov.h | 5 ++--- hw/net/igb.c| 13 +++-- hw/nvme/ctrl.c | 24 hw/pci

[PULL 06/19] Revert "pcie_sriov: Check PCI Express for SR-IOV PF"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 47cc753e50076c25334091783738be9f716253b1. Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie_sriov.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 15a4aac1f4..6c79658b4c 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pci

[PULL 18/19] hw/i386/amd_iommu: Don't leak memory in amdvi_update_iotlb()

2024-08-01 Thread Michael S. Tsirkin
From: Peter Maydell In amdvi_update_iotlb() we will only put a new entry in the hash table if to_cache.perm is not IOMMU_NONE. However we allocate the memory for the new AMDVIIOTLBEntry and for the hash table key regardless. This means that in the IOMMU_NONE case we will leak the memory we allo

[PULL 16/19] Revert "hw/ppc/spapr_pci: Do not create DT for disabled PCI device"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 723c5b4628d047e43825a046c6ee517b82b88117. Signed-off-by: Michael S. Tsirkin --- hw/ppc/spapr_pci.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index f63182a03c..7cf9904c35 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pc

[PULL 10/19] Revert "pcie_sriov: Remove num_vfs from PCIESriovPF"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit cbd9e5120bac3e292eee77b7a2e3692f235a1a26. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_sriov.h | 1 + hw/pci/pcie_sriov.c | 28 hw/pci/trace-events | 2 +- 3 files changed, 10 insertions(+), 21 deletions(-) diff --g

[PULL 09/19] Revert "pcie_sriov: Register VFs after migration"

2024-08-01 Thread Michael S. Tsirkin
This reverts commit 107a64b9a360cf5ca046852bc03334f7a9f22aef. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_sriov.h | 2 -- hw/pci/pci.c| 7 --- hw/pci/pcie_sriov.c | 7 --- 3 files changed, 16 deletions(-) diff --git a/include/hw/pci/pcie_sriov.h b/i

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Markus Armbruster
Akihiko Odaki writes: > On 2024/07/31 17:32, Markus Armbruster wrote: >> Akihiko Odaki writes: >> >>> rom_bar is tristate but was defined as uint32_t so convert it into >>> OnOffAuto to clarify that. For compatibility, a uint32 value set via >>> QOM will be converted into OnOffAuto. >>> >>> Sig

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Markus Armbruster
Akihiko Odaki writes: > On 2024/08/01 16:52, Michael S. Tsirkin wrote: >> On Thu, Aug 01, 2024 at 04:01:44PM +0900, Akihiko Odaki wrote: >>> rom_bar_set() and and underlying visit_type_str_preserving() are ugly, but >>> we can remove them once the deprecation period ends. On the other hand, if >>

Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object

2024-08-01 Thread Markus Armbruster
Zhao Liu writes: > On Thu, Jul 25, 2024 at 11:07:12AM +0200, Markus Armbruster wrote: >> Date: Thu, 25 Jul 2024 11:07:12 +0200 >> From: Markus Armbruster >> Subject: Re: [PATCH 8/8] qemu-options: Add the description of smp-cache >> object >> >> Zhao Liu writes: >> >> > Hi Markus and Daniel,

Re: [PATCH] include: Fix typo in name of MAKE_IDENTFIER macro

2024-08-01 Thread Markus Armbruster
Peter Maydell writes: > In commit bb71846325e23 we added some macro magic to avoid > variable-shadowing when using some of our more complicated > macros. One of the internal components of this is a macro > named MAKE_IDENTFIER. Fix the typo in its name: it should > be MAKE_IDENTIFIER. > > Commit

Re: [PATCH] include: Fix typo in name of MAKE_IDENTFIER macro

2024-08-01 Thread Philippe Mathieu-Daudé
On 1/8/24 12:25, Peter Maydell wrote: In commit bb71846325e23 we added some macro magic to avoid variable-shadowing when using some of our more complicated macros. One of the internal components of this is a macro named MAKE_IDENTFIER. Fix the typo in its name: it should be MAKE_IDENTIFIER. Comm

Re: object_new() cannot fail, and that's fundamental (was: [PATCH v2 1/2] qom/object, qdev: move globals functions to object.c)

2024-08-01 Thread Daniel P . Berrangé
On Thu, Aug 01, 2024 at 08:58:10AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > CC: Markus since he's had opinions on stuff related to -global in > > the past. > > > > On Wed, Jul 03, 2024 at 05:41:48PM -0300, Daniel Henrique Barboza wrote: > >> Next patch will add Accel gl

Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread BillXiang
> From: "Michael S. Tsirkin" > Date:  Thu, Aug 1, 2024, 18:26 > Subject:  Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent > VHOST_USER_SET_LOG_BASE > To: "BillXiang" > Cc: > On Thu, Aug 01, 2024 at 05:48:36PM +0800, BillXiang wrote: > >  > > > From: "Michael S. Tsirkin" > > > Dat

Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 12:59:57PM +0200, Markus Armbruster wrote: > Akihiko Odaki writes: > > > On 2024/07/31 17:32, Markus Armbruster wrote: > >> Akihiko Odaki writes: > >> > >>> rom_bar is tristate but was defined as uint32_t so convert it into > >>> OnOffAuto to clarify that. For compatibil

Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 08:20:35PM +0800, BillXiang wrote: > > > From: "Michael S. Tsirkin" > > Date:  Thu, Aug 1, 2024, 18:26 > > Subject:  Re: [PATCH v2] vhsot-user: Do not wait for replay for not sent > > VHOST_USER_SET_LOG_BASE > > To: "BillXiang" > > Cc: > > On Thu, Aug 01, 2024 at 05:48:36

[PATCH v3 14/14] migration/multifd: Move ram code into multifd-ram.c

2024-08-01 Thread Fabiano Rosas
In preparation for adding new payload types to multifd, move most of the ram-related code into multifd-ram.c. Let's try to keep a semblance of layering by not mixing general multifd control flow with the details of transmitting pages of ram. There are still some pieces leftover, namely the p->norm

[PATCH v3 05/14] migration/multifd: Introduce MultiFDSendData

2024-08-01 Thread Fabiano Rosas
Add a new data structure to replace p->pages in the multifd channel. This new structure will hide the multifd payload type behind an union, so we don't need to add a new field to the channel each time we want to handle a different data type. This also allow us to keep multifd_send_pages() as is, w

Re: [PATCH-for-9.1?] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-01 Thread Philippe Mathieu-Daudé
On 1/8/24 12:27, Michael S. Tsirkin wrote: On Thu, Aug 01, 2024 at 12:07:42PM +0200, Philippe Mathieu-Daudé wrote: When BAR aren't configured, we get: (qemu) info pci Bus 0, device 0, function 0: Host bridge: PCI device dead:beef ... BAR4: 32 bit memory at 0x

[PATCH v3 13/14] migration/multifd: Register nocomp ops dynamically

2024-08-01 Thread Fabiano Rosas
Prior to moving the ram code into multifd-ram.c, change the code to register the nocomp ops dynamically so we don't need to have the ops structure defined in multifd.c. While here, rename s/nocomp/ram/ and remove the docstrings which are mostly useless (if anything, it's the function pointers in m

[PATCH v3 08/14] migration/multifd: Move pages accounting into multifd_send_zero_page_detect()

2024-08-01 Thread Fabiano Rosas
All references to pages are being removed from the multifd worker threads in order to allow multifd to deal with different payload types. multifd_send_zero_page_detect() is called by all multifd migration paths that deal with pages and is the last spot where zero pages and normal page amounts are

[PATCH v3 10/14] migration/multifd: Don't send ram data during SYNC

2024-08-01 Thread Fabiano Rosas
Skip saving and loading any ram data in the packet in the case of a SYNC. This fixes a shortcoming of the current code which requires a reset of the MultiFDPages_t fields right after the previous pending_job finishes, otherwise the very next job might be a SYNC and multifd_send_fill_packet() will p

[PATCH v3 06/14] migration/multifd: Make MultiFDPages_t:offset a flexible array member

2024-08-01 Thread Fabiano Rosas
We're about to use MultiFDPages_t from inside the MultiFDSendData payload union, which means we cannot have pointers to allocated data inside the pages structure, otherwise we'd lose the reference to that memory once another payload type touches the union. Move the offset array into the end of the

[PATCH v3 04/14] migration/multifd: Pass in MultiFDPages_t to file_write_ramblock_iov

2024-08-01 Thread Fabiano Rosas
We want to stop dereferencing 'pages' so it can be replaced by an opaque pointer in the next patches. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas --- migration/file.c| 3 ++- migration/file.h| 2 +- migration/multifd.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) dif

[PATCH v3 03/14] migration/multifd: Remove pages->allocated

2024-08-01 Thread Fabiano Rosas
This value never changes and is always the same as page_count. We don't need a copy of it per-channel plus one in the extra slot. Remove it. Signed-off-by: Fabiano Rosas --- migration/multifd.c | 6 ++ migration/multifd.h | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a

[PATCH v3 09/14] migration/multifd: Isolate ram pages packet data

2024-08-01 Thread Fabiano Rosas
While we cannot yet disentangle the multifd packet from page data, we can make the code a bit cleaner by setting the page-related fields in a separate function. Signed-off-by: Fabiano Rosas --- migration/multifd.c| 110 - migration/trace-events | 9 +

[PATCH v3 02/14] migration/multifd: Inline page_size and page_count

2024-08-01 Thread Fabiano Rosas
The MultiFD*Params structures are for per-channel data. Constant values should not be there because that needlessly wastes cycles and storage. The page_size and page_count fall into this category so move them inline in multifd.h. Signed-off-by: Fabiano Rosas --- migration/multifd-qpl.c | 1

[PATCH v3 07/14] migration/multifd: Replace p->pages with an union pointer

2024-08-01 Thread Fabiano Rosas
We want multifd to be able to handle more types of data than just ram pages. To start decoupling multifd from pages, replace p->pages (MultiFDPages_t) with the new type MultiFDSendData that hides the client payload inside an union. The general idea here is to isolate functions that *need* to handl

[PATCH v3 11/14] migration/multifd: Replace multifd_send_state->pages with client data

2024-08-01 Thread Fabiano Rosas
Multifd currently has a simple scheduling mechanism that distributes work to the various channels by keeping storage space within each channel and an extra space that is given to the client. Each time the client fills the space with data and calls into multifd, that space is given to the next idle

[PATCH v3 12/14] migration/multifd: Allow multifd sync without flush

2024-08-01 Thread Fabiano Rosas
Separate the multifd sync from flushing the client data to the channels. These two operations are closely related but not strictly necessary to be executed together. The multifd sync is intrinsic to how multifd works. The multiple channels operate independently and may finish IO out of order in re

[PATCH v3 01/14] migration/multifd: Reduce access to p->pages

2024-08-01 Thread Fabiano Rosas
I'm about to replace the p->pages pointer with an opaque pointer, so do a cleanup now to reduce direct accesses to p->page, which makes the next diffs cleaner. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/multifd-qpl.c | 8 +--- migration/multifd-uadk.c | 9 +

[PATCH v3 00/14] migration/multifd: Remove multifd_send_state->pages

2024-08-01 Thread Fabiano Rosas
Hi, This v3 incorporates the suggestions done by Peter in v2. Aside from those, of note: - fixed the allocation of MultiFDSendData. The previous version didn't account for compiler-inserted holes; - kept the packet split patch; - added some patches to remove p->page_count, p->page_size, pag

Re: [PATCH-for-9.1?] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-01 Thread Philippe Mathieu-Daudé
On 1/8/24 14:36, Philippe Mathieu-Daudé wrote: On 1/8/24 12:27, Michael S. Tsirkin wrote: On Thu, Aug 01, 2024 at 12:07:42PM +0200, Philippe Mathieu-Daudé wrote: When BAR aren't configured, we get:    (qemu) info pci Bus  0, device   0, function 0:    Host bridge: PCI device dead:beef

Re: [PATCH-for-9.1?] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2024 at 02:36:11PM +0200, Philippe Mathieu-Daudé wrote: > On 1/8/24 12:27, Michael S. Tsirkin wrote: > > On Thu, Aug 01, 2024 at 12:07:42PM +0200, Philippe Mathieu-Daudé wrote: > > > When BAR aren't configured, we get: > > > > > >(qemu) info pci > > > Bus 0, device 0, f

Re: [PATCH v3 00/14] migration/multifd: Remove multifd_send_state->pages

2024-08-01 Thread Fabiano Rosas
Fabiano Rosas writes: > Hi, > > This v3 incorporates the suggestions done by Peter in v2. Aside from > those, of note: > > - fixed the allocation of MultiFDSendData. The previous version didn't > account for compiler-inserted holes; > > - kept the packet split patch; > > - added some patches to

[PATCH v3] vhost-user: Do not wait for reply for not sent VHOST_USER_SET_LOG_BASE

2024-08-01 Thread BillXiang
From: BillXiang Currently, we have added VHOST_USER_SET_LOG_BASE to vhost_user_per_device_request in commit 7c211eb078c4 ("vhost-user: Skip unnecessary duplicated VHOST_USER_SET_LOG_BASE requests"), as a result, VHOST_USER_SET_LOG_BASE will be sent only once when 'vq_index == 0'. In this patc

Re: [PATCH v3] util: use RETRY_ON_EINTR() on open() more consistently

2024-08-01 Thread Philippe Mathieu-Daudé
Hi Philipp, On 31/7/24 17:17, Philipp Reisner wrote: As with many syscalls, open() might be interrupted by a signal. The call trace img_open_file() blk_new_open() raw_open() raw_open_common() qemu_open() qemu_open_internal() qemu_open_cloexec() E

Re: [PATCH v3 3/7] acpi/ghes: Support GPIO error source.

2024-08-01 Thread Mauro Carvalho Chehab
Em Tue, 30 Jul 2024 10:40:28 +0200 Igor Mammedov escreveu: > > diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h > > index 674f6958e905..4f1ab1a73a06 100644 > > --- a/include/hw/acpi/ghes.h > > +++ b/include/hw/acpi/ghes.h > > @@ -58,6 +58,7 @@ enum AcpiGhesNotifyType { > > > > enum

  1   2   3   4   >