On Thu, Aug 01, 2024 at 09:00:36AM +1000, Richard Henderson wrote: > On 7/31/24 22:56, Philippe Mathieu-Daudé wrote: > > On 30/7/24 19:03, Daniel P. Berrangé wrote: > > > From: Thomas Huth <th...@redhat.com> > > > > > > The avocado test defined test functions for both, riscv32 and riscv64. > > > Since we can run the whole file with multiple targets in the new > > > framework, we can now consolidate the functions so we have to only > > > define one function per machine now. > > > > > > Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> > > > Signed-off-by: Thomas Huth <th...@redhat.com> > > > --- > > > tests/avocado/riscv_opensbi.py | 63 -------------------------- > > > tests/functional/meson.build | 8 ++++ > > > tests/functional/test_riscv_opensbi.py | 36 +++++++++++++++ > > > 3 files changed, 44 insertions(+), 63 deletions(-) > > > delete mode 100644 tests/avocado/riscv_opensbi.py > > > create mode 100755 tests/functional/test_riscv_opensbi.py > > > > Please squash: > > > > -- >8 -- > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 98eddf7ae1..a906218f9d 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -336,6 +337,7 @@ F: include/hw/riscv/ > > F: linux-user/host/riscv32/ > > F: linux-user/host/riscv64/ > > F: tests/tcg/riscv64/ > > +F: tests/functional/test_riscv_opensbi.py > > It seems worth taking this opportunity to add per-target subdirs of > tests/functional/, so that we don't have to list every individual test in > MAINTAINERS. > > Surely one > > F: tests/functional/riscv/ > > etc, is actually maintainable...
Either that or wildcard the filenames F: tests/functional/test_riscv_* but subdirs matching the target is probably a little nicer to really encourage people to follow conventions more strictly. We would also need a "tests/functional/common/" for tests which aren't target specific With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
