Re: [PATCH v6 0/8] target/riscv: Expose RV32 cpu to RV64 QEMU

2024-07-25 Thread Philippe Mathieu-Daudé
Hi Alistair, On 24/7/24 04:44, Alistair Francis wrote: On Sat, Jul 20, 2024 at 9:15 AM LIU Zhiwei wrote: This patch set aims to expose 32-bit RISC-V cpu to RV64 QEMU. Thus qemu-system-riscv64 can directly boot a RV32 Linux. This patch set has been tested with 6.9.0 Linux Image. And add an av

Re: [PATCH-for-9.1] target/riscv: Remove the deprecated 'any' CPU type

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 15:07, Philippe Mathieu-Daudé wrote: The 'any' CPU is deprecated since commit f57d5f8004b ("target/riscv: deprecate the 'any' CPU type"). Users are better off using the default CPUs or the 'max' CPU. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 13 ---

Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 12:51, Michael S. Tsirkin wrote: with max-bytes set to 0, quota is 0 and so device does not work. block this to avoid user confusion Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-rng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Math

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 11:55, Daniel P. Berrangé wrote: Daniel P. Berrangé (2): gitlab: record installed packages in /packages.txt in containers gitlab: display /packages.txt in build jobs Reviewed-by: Philippe Mathieu-Daudé

[RFC PATCH 6/6] RAMBlock: make guest_memfd require coordinate discard

2024-07-25 Thread Chenyi Qiang
As guest_memfd is now managed by guest_memfd_manager with RamDiscardManager, only block uncoordinated discard. Signed-off-by: Chenyi Qiang --- system/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system/physmem.c b/system/physmem.c index 98072ae246..ffd68debf0 100

[RFC PATCH 5/6] guest-memfd: Default to discarded (private) in guest_memfd_manager

2024-07-25 Thread Chenyi Qiang
guest_memfd was initially set to shared until the commit bd3bcf6962 ("kvm/memory: Make memory type private by default if it has guest memfd backend"). To align with this change, the default state in guest_memfd_manager is set to discarded. One concern raised by this commit is the handling of the v

[RFC PATCH 2/6] guest_memfd: Introduce a helper to notify the shared/private state change

2024-07-25 Thread Chenyi Qiang
Introduce a helper function within RamDiscardManager to efficiently notify all registered RamDiscardListeners, including VFIO listeners about the memory conversion events between shared and private in guest_memfd. The existing VFIO listener can dynamically DMA map/unmap the shared pages based on th

[RFC PATCH 0/6] Enable shared device assignment

2024-07-25 Thread Chenyi Qiang
Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") effectively disables device assignment with guest_memfd. guest_memfd is required for confidential guests, so device assignment to confidential guests is disabled. A supporting assumption for disabling device-assignment w

[RFC PATCH 1/6] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager

2024-07-25 Thread Chenyi Qiang
As the commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") highlighted, some subsystems like VFIO might disable ram block discard. However, guest_memfd relies on the discard operation to perform page conversion between private and shared memory. This can lead to stale IOM

[RFC PATCH 4/6] memory: Register the RamDiscardManager instance upon guest_memfd creation

2024-07-25 Thread Chenyi Qiang
Instantiate a new guest_memfd_manager object and register it in the target MemoryRegion. From this point, other subsystems such as VFIO can register their listeners in guest_memfd_manager and receive conversion events through RamDiscardManager. Signed-off-by: Chenyi Qiang --- system/physmem.c |

[RFC PATCH 3/6] KVM: Notify the state change via RamDiscardManager helper during shared/private conversion

2024-07-25 Thread Chenyi Qiang
Once exit to userspace to convert the page from private to shared or vice versa at runtime, notify the state change via the guest_memfd_state_change() helper so that other registered subsystems like VFIO can be notified. Signed-off-by: Chenyi Qiang --- accel/kvm/kvm-all.c | 7 +++ 1 file cha

Re: [PATCH v3] target/s390x: filter deprecated properties based on model expansion type

2024-07-25 Thread Markus Armbruster
Markus Armbruster writes: > Collin Walling writes: > >> On 7/24/24 3:56 AM, Markus Armbruster wrote: >>> Collin Walling writes: >> Let me try to explain the purpose of @deprecated-props and see if it >> helps bring us closer to some semblance of a mutual understanding so we >> can work together

Re: [PATCH v3] target/s390x: filter deprecated properties based on model expansion type

2024-07-25 Thread David Hildenbrand
On 25.07.24 09:35, Markus Armbruster wrote: Markus Armbruster writes: Collin Walling writes: On 7/24/24 3:56 AM, Markus Armbruster wrote: Collin Walling writes: Let me try to explain the purpose of @deprecated-props and see if it helps bring us closer to some semblance of a mutual unders

Re: [PATCH 0/3] S3 and S4 sleep for loongarch/virt & microvm

2024-07-25 Thread Igor Mammedov
On Sat, 15 Jun 2024 09:45:48 +0800 maobibo wrote: > On 2024/6/14 下午10:03, Daniel P. Berrangé wrote: > > On Fri, Jun 14, 2024 at 01:17:39PM +0800, maobibo wrote: > >> > >> > >> On 2024/6/14 下午12:27, Jiaxun Yang wrote: > >>> > >>> > >>> 在2024年6月14日六月 上午4:32,maobibo写道: > It is interesting

Re: [PATCH v4 11/11] pnv/xive2: Dump more END state with 'info pic'

2024-07-25 Thread Cédric Le Goater
On 7/24/24 23:21, Michael Kowal wrote: From: Frederic Barrat Additional END state 'info pic' information as added. The 'ignore', 'crowd' and 'precluded escalation control' bits of an Event Notification Descriptor are all used when delivering an interrupt targeting a VP-group or crowd. Signed-

Re: [PATCH v4 10/11] pnv/xive2: Refine TIMA 'info pic' output

2024-07-25 Thread Cédric Le Goater
On 7/24/24 23:21, Michael Kowal wrote: From: Frederic Barrat In XIVE Gen 2 there were some minor changes to the TIMA header that were updated when printed. Signed-off-by: Frederic Barrat Signed-off-by: Michael Kowal Reviewed-by: Cédric Le Goater Thanks, C. --- hw/intc/xive.c | 12

Re: [PATCH v4 09/11] pnv/xive2: Move xive2_nvp_pic_print_info() to xive2.c

2024-07-25 Thread Cédric Le Goater
On 7/24/24 23:21, Michael Kowal wrote: From: Frederic Barrat Moving xive2_nvp_pic_print_info() to align with the other "pic_print_info" functions. Signed-off-by: Frederic Barrat Signed-off-by: Michael Kowal Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/xive2_regs.h |

Re: [PATCH 1/3] acpi/ged: Implement S3 and S4 sleep

2024-07-25 Thread Igor Mammedov
On Thu, 13 Jun 2024 18:30:15 +0100 Jiaxun Yang wrote: > Implement S3 and S4 sleep with ACPI_GED_REG_SLEEP_CTL.SLP_TYP > writes. > > Implement wakeup callback and WAK_STS register to inform guest > about current states. > > All new functions are gated by "slp-typs" property, it is defaulted > to

Re: [PATCH 2/3] hw/loongarch/virt: Wire up S3 and S4 sleep

2024-07-25 Thread Igor Mammedov
On Thu, 13 Jun 2024 18:30:16 +0100 Jiaxun Yang wrote: > Wire up S3 and S4 sleep by setting relevant slp-typs bits for > GED and generate _S3 and _S4 methods in acpi table. > > Signed-off-by: Jiaxun Yang > --- > hw/loongarch/acpi-build.c | 18 ++ > hw/loongarch/virt.c | 3

Re: [PATCH 0/3] S3 and S4 sleep for loongarch/virt & microvm

2024-07-25 Thread Igor Mammedov
On Thu, 13 Jun 2024 18:30:14 +0100 Jiaxun Yang wrote: > Hi all, > > This series implemented S3 and S4 sleep for loongarch virt machine > and microvm. > > For loongarch/virt a kernel patch is requried [1]. > > [1]: > https://lore.kernel.org/loongarch/20240613-loongarch64-sleep-v1-0-a245232af..

Re: [PATCH 1/3] acpi/ged: Implement S3 and S4 sleep

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 10:22:15AM +0200, Igor Mammedov wrote: > On Thu, 13 Jun 2024 18:30:15 +0100 > Jiaxun Yang wrote: > > > Implement S3 and S4 sleep with ACPI_GED_REG_SLEEP_CTL.SLP_TYP > > writes. > > > > Implement wakeup callback and WAK_STS register to inform guest > > about current states

Re: [PATCH v3] pci-bridge: avoid linking a single downstream port more than once

2024-07-25 Thread Igor Mammedov
On Wed, 24 Jul 2024 23:27:31 -0400 Yao Xingtao via wrote: > Since the downstream port is not checked, two slots can be linked to > a single port. However, this can prevent the driver from detecting the > device properly. > > It is necessary to ensure that a downstream port is not linked more tha

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Markus Armbruster
Zhao Liu writes: > Hi Markus, > > I realized I should reply this mail first... > > On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: >> Date: Wed, 24 Jul 2024 13:35:17 +0200 >> From: Markus Armbruster >> Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object >> >> Zhao L

Re: [PATCH 1/3] acpi/ged: Implement S3 and S4 sleep

2024-07-25 Thread Igor Mammedov
On Thu, 25 Jul 2024 04:30:42 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 25, 2024 at 10:22:15AM +0200, Igor Mammedov wrote: > > On Thu, 13 Jun 2024 18:30:15 +0100 > > Jiaxun Yang wrote: > > > > > Implement S3 and S4 sleep with ACPI_GED_REG_SLEEP_CTL.SLP_TYP > > > writes. > > > > > > Impl

Re: [PATCH 8/8] qemu-options: Add the description of smp-cache object

2024-07-25 Thread Markus Armbruster
Zhao Liu writes: > Hi Markus and Daniel, > > I have the questions about the -object per cache implementation: > > On Wed, Jul 24, 2024 at 02:39:29PM +0200, Markus Armbruster wrote: >> Date: Wed, 24 Jul 2024 14:39:29 +0200 >> From: Markus Armbruster >> Subject: Re: [PATCH 8/8] qemu-options: Add t

RE: [PATCH v3] pci-bridge: avoid linking a single downstream port more than once

2024-07-25 Thread Xingtao Yao (Fujitsu)
> -Original Message- > From: Igor Mammedov > Sent: Thursday, July 25, 2024 4:36 PM > To: Yao Xingtao via > Cc: Yao, Xingtao/姚 幸涛 ; m...@redhat.com; > marcel.apfelb...@gmail.com > Subject: Re: [PATCH v3] pci-bridge: avoid linking a single downstream port > more > than once > > On Wed,

[PATCH v4] pci-bridge: avoid linking a single downstream port more than once

2024-07-25 Thread Yao Xingtao via
Since the downstream port is not checked, two slots can be linked to a single port. However, this can prevent the driver from detecting the device properly. It is necessary to ensure that a downstream port is not linked more than once. Links: https://lore.kernel.org/qemu-devel/oszpr01mb6453bc61d

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Manos Pitsidianakis
Hello Daniel, On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote: Many times we see a build job start failing, we wonder if the installed packages have changed since the last passing build. We can rarely diagnose this, however, since we only have the new container image, not the old one.

Re: [PATCH v3 4/7] acpi/ghes: Add a logic to handle block addresses and FW first ARM processor error injection

2024-07-25 Thread Markus Armbruster
Mauro Carvalho Chehab writes: > From: Jonathan Cameron > > 1. Some GHES functions require handling addresses. Add a helper function >to support it. > > 2. Add support for ACPI CPER (firmware-first) ARM processor error injection. > > Compliance with N.2.4.4 ARM Processor Error Section in UEFI

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-25 Thread Paolo Bonzini
Il gio 25 lug 2024, 08:19 Manos Pitsidianakis < manos.pitsidiana...@linaro.org> ha scritto: > >(before the call to qemu_chr_fe_accept_input): > >// TODO: this causes a callback that creates another "&mut self". > >// This is forbidden by Rust aliasing rules and has to be fixed > >// using interior

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 09:35:22AM +1000, Richard Henderson wrote: > On 7/25/24 03:52, Thomas Huth wrote: > > The Avocado v88 that we use in QEMU is already on a life support > > system: It is not supported by upstream anymore, and with the latest > > versions of Python, it won't work anymore since

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
Hi Michael, thanks for the review! On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > > From: David Woodhouse > > > > The vmclock "device" provides a shared memory region with precision clock > > information. By using

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Thomas Huth
On 25/07/2024 11.42, Manos Pitsidianakis wrote: Hello Daniel, On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote: Many times we see a build job start failing, we wonder if the installed packages have changed since the last passing build. We can rarely diagnose this, however, since we only h

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 01:54 -0400, Michael S. Tsirkin wrote: > one other thing worth mentioning is that this design can't work > with confidential computing setups. By comparison, mapping e.g. a > range in a PCI BAR would work for these setups. Why so? This is just like mapping a PCI BAR, isn't it

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 12:42:18PM +0300, Manos Pitsidianakis wrote: > Hello Daniel, > > On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote: > > Many times we see a build job start failing, we wonder if the installed > > packages have changed since the last passing build. We can rarely > > dia

Re: [PATCH v3 7/7] acpi/ghes: extend arm error injection logic

2024-07-25 Thread Markus Armbruster
Mauro Carvalho Chehab writes: > Enrich CPER error injection logic for ARM processor to allow > setting values to from UEFI 2.10 tables N.16 and N.17. > > It should be noticed that, with such change, all arguments are > now optional, so, once QMP is negotiated with: > > { "execute": "qmp_ca

Re: [PULL v2 25/25] qga/linux: Add new api 'guest-network-get-route'

2024-07-25 Thread Peter Maydell
On Tue, 23 Jul 2024 at 08:03, Konstantin Kostiuk wrote: > > From: Dehan Meng > > The Route information of the Linux VM needs to be used > by administrators and users when debugging network problems > and troubleshooting. > > Signed-off-by: Dehan Meng > Reviewed-by: Konstantin Kostiuk > Message-

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-25 Thread Thomas Huth
On 25/07/2024 01.35, Richard Henderson wrote: On 7/25/24 03:52, Thomas Huth wrote: The Avocado v88 that we use in QEMU is already on a life support system: It is not supported by upstream anymore, and with the latest versions of Python, it won't work anymore since it depends on the "imp" module

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Alex Bennée
Manos Pitsidianakis writes: > Hello Daniel, > > On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote: >>Many times we see a build job start failing, we wonder if the installed >>packages have changed since the last passing build. We can rarely >>diagnose this, however, since we only have the ne

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-25 Thread Manos Pitsidianakis
On Thu, 25 Jul 2024 12:50, Paolo Bonzini wrote: Il gio 25 lug 2024, 08:19 Manos Pitsidianakis < manos.pitsidiana...@linaro.org> ha scritto: >(before the call to qemu_chr_fe_accept_input): >// TODO: this causes a callback that creates another "&mut self". >// This is forbidden by Rust aliasing

Re: [PULL 04/11] Add support for RAPL MSRs in KVM/Qemu

2024-07-25 Thread Peter Maydell
On Tue, 23 Jul 2024 at 15:17, Paolo Bonzini wrote: > > From: Anthony Harivel > > Starting with the "Sandy Bridge" generation, Intel CPUs provide a RAPL > interface (Running Average Power Limit) for advertising the accumulated > energy consumption of various power domains (e.g. CPU packages, DRAM,

Re: [PATCH 0/2] gitlab: expose installed package info in build logs

2024-07-25 Thread Manos Pitsidianakis
On Thu, 25 Jul 2024 12:56, Thomas Huth wrote: On 25/07/2024 11.42, Manos Pitsidianakis wrote: Hello Daniel, On Wed, 24 Jul 2024 12:55, "Daniel P. Berrangé" wrote: Many times we see a build job start failing, we wonder if the installed packages have changed since the last passing build. We ca

Re: [PATCH v6 8/8] tests/avocado: Boot Linux for RV32 cpu on RV64 QEMU

2024-07-25 Thread Alex Bennée
LIU Zhiwei writes: > make check-avocado AVOCADO_TESTS=tests/avocado/tuxrun_baselines.py: \ > TuxRunBaselineTest:test_riscv64_rv32 > > Signed-off-by: LIU Zhiwei > Suggested-by: Daniel Henrique Barboza Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL 03/11] tools: build qemu-vmsr-helper

2024-07-25 Thread Peter Maydell
On Tue, 23 Jul 2024 at 15:16, Paolo Bonzini wrote: > > From: Anthony Harivel > > Introduce a privileged helper to access RAPL MSR. Hi; Coverity points out an issue with this commit (CID 1558555): > +static void coroutine_fn vh_co_entry(void *opaque) > +{ > +VMSRHelperClient *client = opaqu

Re: [PULL 03/11] tools: build qemu-vmsr-helper

2024-07-25 Thread Paolo Bonzini
On Thu, Jul 25, 2024 at 12:28 PM Peter Maydell wrote: > > +if (r < 0) { > > +error_report_err(local_err); > > +goto out; > > Here we have a check for r < 0 that forces an early exit... > > > +} > > + > > +while (r < 0) { > > ...but then immediately we do a while (r < 0)

Re: [PULL v2 37/61] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-25 Thread Peter Maydell
On Tue, 23 Jul 2024 at 11:58, Michael S. Tsirkin wrote: > > From: Salil Mehta > > KVM vCPU creation is done once during the vCPU realization when Qemu vCPU > thread > is spawned. This is common to all the architectures as of now. > > Hot-unplug of vCPU results in destruction of the vCPU object i

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-25 Thread Richard Henderson
On 7/25/24 19:55, Daniel P. Berrangé wrote: On Thu, Jul 25, 2024 at 09:35:22AM +1000, Richard Henderson wrote: On 7/25/24 03:52, Thomas Huth wrote: The Avocado v88 that we use in QEMU is already on a life support system: It is not supported by upstream anymore, and with the latest versions of P

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-25 Thread Richard Henderson
On 7/25/24 20:13, Thomas Huth wrote:  Hi Richard, just for my understanding, did you try to run the tests in parallel (i.e. something like "make -j$(nproc)")? No, I ran "make check-functional" with zero parallelism. For me, it works fine if I use normal serial testing with "-j" (btw. Avocad

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Jonathan Cameron via
On Thu, 25 Jul 2024 11:50:59 +0100 Jonathan Cameron wrote: Resending as this bounced due (I think) to an address typo. > Hi Markus, Zhao Liu > > From the ARM server side this is something I want to see as well. > So I can comment on why we care. > > > >> This series adds a way to configure cac

Re: [PATCH v2 00/23] Convert avocado tests to normal Python unittests

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 08:42:31PM +1000, Richard Henderson wrote: > On 7/25/24 19:55, Daniel P. Berrangé wrote: > > On Thu, Jul 25, 2024 at 09:35:22AM +1000, Richard Henderson wrote: > > > On 7/25/24 03:52, Thomas Huth wrote: > > > > The Avocado v88 that we use in QEMU is already on a life support

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-25 Thread Paolo Bonzini
On Thu, Jul 25, 2024 at 12:14 PM Manos Pitsidianakis wrote: > >Unfortunately that's a *mut, not a &mut. A &mut must be unique, so the cast > >in pl011_read() is undefined behavior. > > Actually it's: > > unsafe { qemu_chr_fe_accept_input(&mut self.char_backend) }; > > And you can ensure there's

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Paolo Abeni
Hi, Just a bunch of 'nits below On 7/24/24 19:16, David Woodhouse wrote: diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c new file mode 100644 index ..9c508c21c062 --- /dev/null +++ b/drivers/ptp/ptp_vmclock.c [...] +/* + * Multiply a 64-bit count by a 64-bit t

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > Hi Michael, thanks for the review! > > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > > On Wed, Jul 24, 2024 at 06:16:37PM +0100, David Woodhouse wrote: > > > From: David Woodhouse > > > > > > The vmclock "device"

Re: [PATCH] misc: introduce strim-memory qapi to support free memory trimming

2024-07-25 Thread Markus Armbruster
Guoyi Tu writes: > In the test environment, we conducted IO stress tests on all storage disks > within a virtual machine that had five storage devices mounted.During > testing, > we found that the qemu process allocated a large amount of memory (~800MB) > to handle these IO operations. > > When

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Zhao Liu
Hi Markus, On Thu, Jul 25, 2024 at 10:51:49AM +0200, Markus Armbruster wrote: [snip] > >> What's the use case? The commit messages don't tell. > > > > i386 has the default cache topology model: l1 per core/l2 per core/l3 > > per die. > > > > Cache topology affects scheduler performance, e.g., k

Re: [PATCH-for-9.1] target/riscv: Remove the deprecated 'any' CPU type

2024-07-25 Thread Daniel Henrique Barboza
On 7/24/24 10:07 AM, Philippe Mathieu-Daudé wrote: The 'any' CPU is deprecated since commit f57d5f8004b ("target/riscv: deprecate the 'any' CPU type"). Users are better off using the default CPUs or the 'max' CPU. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst |

Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object

2024-07-25 Thread Zhao Liu
Thanks Jonathon! On Thu, Jul 25, 2024 at 11:59:02AM +0100, Jonathan Cameron wrote: [snip] > > > I think I understand why you want to configure caches. My question was > > > about the connection to SMP. > > > > > > Say we run a guest with a single core, no SMP. Could configuring caches > > > s

Re: [PATCH 1/4] hw/misc/bcm2835_property: Fix handling of FRAMEBUFFER_SET_PALETTE

2024-07-25 Thread Philippe Mathieu-Daudé
On 23/7/24 15:10, Peter Maydell wrote: The documentation of the "Set palette" mailbox property at https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface#set-palette says it has the form: Length: 24..1032 Value: u32: offset: first palette index to set (0-255)

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 13:20 +0200, Paolo Abeni wrote: > > > Just a bunch of 'nits below Thank you. Fixed in https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/vmclock I'll post a new version once I've finished resolving mst's and any other feedback. smime.p7s Description: S/

Re: [PATCH v2 09/23] tests/functional: Add a function for extracting files from an archive

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: Some Avocado-based tests use the "archive" module from avocado.utils to extract files from an archive. To be able to use these tests without Avocado, we have to provide our own function for extracting files. Fortunately, there is already the tarfile module tha

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 12:31 +0100, Daniel P. Berrangé wrote: > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > Hi Michael, thanks for the review! > > > > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote: > > > Do you want to just help complete virtio-rtc then? Would

Re: [PATCH v2 17/23] tests/functional: Convert most ppc avocado tests into standalone tests

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: Nothing thrilling in here, just straight forward conversions. Signed-off-by: Thomas Huth --- MAINTAINERS | 8 ++-- tests/functional/meson.build | 10 + .../test_ppc64_powernv.py}

Re: [PATCH v2 05/23] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-25 Thread Philippe Mathieu-Daudé
On 25/7/24 08:55, Philippe Mathieu-Daudé wrote: Hi Thomas, On 24/7/24 19:52, Thomas Huth wrote: These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. To ease debugging, make the files executable and add a shebang line and Python '__main

Re: [PATCH] misc: introduce strim-memory qapi to support free memory trimming

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 01:35:21PM +0200, Markus Armbruster wrote: > Guoyi Tu writes: > > > In the test environment, we conducted IO stress tests on all storage disks > > within a virtual machine that had five storage devices mounted.During > > testing, > > we found that the qemu process allocat

Re: [PATCH v2 05/23] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: These test are rather simple and don't need any modifications apart from adjusting the "from avocado_qemu" line. To ease debugging, make the files executable and add a shebang line and Python '__main__' handling, too, so that these tests can now be run by exec

Re: [PATCH v2 03/23] tests/Makefile.include: Increase the level of indentation in the help text

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: The next patch is going to add some entries that need more space between the command and the help text, so let's increase the indentation here first. Signed-off-by: Thomas Huth --- tests/Makefile.include | 30 +++--- 1 file changed

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Daniel P . Berrangé
On Thu, Jul 25, 2024 at 12:53:34PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 12:31 +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > Hi Michael, thanks for the review! > > > > > > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Ts

Re: [PATCH v2 06/23] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: These simple tests can be converted to stand-alone tests quite easily, e.g. by just setting the machine to 'none' now manually or by adding "-cpu" command line parameters, since we don't support the corresponding avocado tags in the new python test framework.

Re: [PATCH v2 08/23] tests/functional: Convert some tests that download files via fetch_asset()

2024-07-25 Thread Philippe Mathieu-Daudé
On 24/7/24 19:52, Thomas Huth wrote: Now that we've got a working fetch_asset() function, we can convert some Avocado tests that use this function for downloading their required files. Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- MAINTAINERS

RE: [PULL v2 37/61] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-25 Thread Salil Mehta via
HI Peter, > From: Peter Maydell > Sent: Thursday, July 25, 2024 11:36 AM > To: Michael S. Tsirkin > > On Tue, 23 Jul 2024 at 11:58, Michael S. Tsirkin wrote: > > > > From: Salil Mehta > > > > KVM vCPU creation is done once during the vCPU realization when Qemu > > vCPU thread is spa

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > Do you want to just help complete virtio-rtc then? Would be easier than > > trying to keep two specs in sync. > > The ACPI version is much more lightweight and doesn't take up a > valuable PCI slot#. (I know, you can do virtio wi

Re: [PULL v2 37/61] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-25 Thread Peter Maydell
On Thu, 25 Jul 2024 at 13:05, Salil Mehta wrote: > > HI Peter, > > > From: Peter Maydell > > Sent: Thursday, July 25, 2024 11:36 AM > > To: Michael S. Tsirkin > > > > On Tue, 23 Jul 2024 at 11:58, Michael S. Tsirkin wrote: > > > > > > From: Salil Mehta > > > > > > KVM vCPU creation is

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > Do you want to just help complete virtio-rtc then? Would be easier than > > > trying to keep two specs in sync. > > > > The ACPI version is much more lightweight an

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > > Do you want to just help complete virtio-rtc then? Would be easier than > > > > trying to keep

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote: > > > > > Do you want to just help

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > > On Thu, 2024-07-25 at 08:17 -0400, Michael S. Tsirkin wrote: > > > > On Thu, Jul 25, 2024 at 10:

Re: [PATCH] misc: introduce strim-memory qapi to support free memory trimming

2024-07-25 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Jul 25, 2024 at 01:35:21PM +0200, Markus Armbruster wrote: > > Guoyi Tu writes: > > > > > In the test environment, we conducted IO stress tests on all storage disks > > > within a virtual machine that had five storage devices mounted.Dur

Re: [PATCH v5 03/13] hw/riscv: add RISC-V IOMMU base emulation

2024-07-25 Thread Daniel Henrique Barboza
On 7/18/24 1:37 AM, Alistair Francis wrote: On Tue, Jul 9, 2024 at 3:37 AM Daniel Henrique Barboza wrote: From: Tomasz Jeznach The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at: https://github.com/riscv-

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 08:33 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 01:31:19PM +0100, David Woodhouse wrote: > > On Thu, 2024-07-25 at 08:29 -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 25, 2024 at 01:27:49PM +0100, David Woodhouse wrote: > > > > On Thu, 2024-07-25 at 08:17

Re: [RFC PATCH 0/6] Enable shared device assignment

2024-07-25 Thread David Hildenbrand
Open Implementing a RamDiscardManager to notify VFIO of page conversions causes changes in semantics: private memory is treated as discarded (or hot-removed) memory. This isn't aligned with the expectation of current RamDiscardManager users (e.g. VFIO or live migration) who really expect that

Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled

2024-07-25 Thread Peter Maydell
On Sat, 20 Jul 2024 at 16:19, Peter Maydell wrote: > > On Thu, 18 Jul 2024 at 03:15, Alistair Francis wrote: > > > > From: Atish Patra > > > > The timer is setup function is invoked in both hpmcounter > > write and mcountinhibit write path. If the OF bit set, the > > LCOFI interrupt is disabled.

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > Even if the virtio-rtc specification were official today, and I was > able to expose it via PCI, I probably wouldn't do it that way. There's > just far more in virtio-rtc than we need; the simple shared memory > region is perfectly

Re: [PULL 57/62] hw/xen: Support MSI mapping to PIRQ

2024-07-25 Thread Peter Maydell
On Tue, 19 Dec 2023 at 13:36, Peter Maydell wrote: > > On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote: > > > > From: David Woodhouse > > > > The way that Xen handles MSI PIRQs is kind of awful. > > > > There is a special MSI message which targets a PIRQ. The vector in the > > low bits of data

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-25 Thread Cleber Rosa
On Tue, Jul 16, 2024 at 7:28 AM Thomas Huth wrote: > > The Avocado v88 that we use in QEMU is already on a life support > system: It is not supported by upstream anymore, and with the latest > versions of Python, it won't work anymore since it depends on the > "imp" module that has been removed in

Re: [PATCH 1/4] gdbstub: Use specific MMU index when probing MTE addresses

2024-07-25 Thread Gustavo Romero
Hi Richard, On 7/24/24 7:14 AM, Richard Henderson wrote: On 7/23/24 02:07, Gustavo Romero wrote: +    /* Find out the current translation regime for probe. */ +    mmu_index = arm_mmu_idx(env) & ARM_MMU_IDX_COREIDX_MASK; The official interface is cpu_mmu_index(). Otherwise, Reviewed-by: Rich

Re: [PATCH] hw/arm/smmuv3: Assert input to oas2bits() is valid

2024-07-25 Thread Peter Maydell
On Mon, 22 Jul 2024 at 11:35, Mostafa Saleh wrote: > > Coverity has spotted a possible problem with the OAS handling > (CID 1558464), where the error return of oas2bits() -1 is not > checked, which can cause an overflow in oas value. > > oas2bits() is only called with valid inputs, harden the func

Re: [PATCH qemu] [hw/char/bcm2835_aux] Fix receive FIFO filling up (raspi3)

2024-07-25 Thread Peter Maydell
On Mon, 22 Jul 2024 at 10:44, Peter Maydell wrote: > > [Added missing cc of qemu-devel] > > On Mon, 22 Jul 2024 at 07:33, Philippe Mathieu-Daudé > wrote: > > > > On 21/7/24 18:13, ~fvanhovell wrote: > > > From: Frederik van Hövell > > > > > > When a bare-metal application on the raspi3 board re

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-25 Thread Manos Pitsidianakis
On Thu, 25 Jul 2024 at 14:19, Paolo Bonzini wrote: > > On Thu, Jul 25, 2024 at 12:14 PM Manos Pitsidianakis > wrote: > > >Unfortunately that's a *mut, not a &mut. A &mut must be unique, so the cast > > >in pl011_read() is undefined behavior. > > > > Actually it's: > > > > unsafe { qemu_chr_fe_a

[PATCH] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic

2024-07-25 Thread Salil Mehta via
Loop should exit prematurely on successfully finding out the parked vCPU (struct KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of parked vCPUs. Fixes: Coverity CID 1558552 Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code") Reported-by: Pet

RE: [PULL v2 37/61] accel/kvm: Extract common KVM vCPU {creation,parking} code

2024-07-25 Thread Salil Mehta via
Hi Peter, > From: Peter Maydell > Sent: Thursday, July 25, 2024 1:27 PM > To: Salil Mehta > > On Thu, 25 Jul 2024 at 13:05, Salil Mehta wrote: > > > > HI Peter, > > > > > From: Peter Maydell > > > Sent: Thursday, July 25, 2024 11:36 AM > > > To: Michael S. Tsirkin > > > > > >

[PATCH] tests/tcg: Skip failing ppc64 multi-threaded tests in CI

2024-07-25 Thread Nicholas Piggin
In Gitlab CI, some ppc64 multi-threaded tcg tests crash when run in the clang-user job with an assertion failure in glibc that seems to indicate corruption: signals: allocatestack.c:223: allocate_stack: Assertion `powerof2 (pagesize_m1 + 1)' failed. Disable these tests on CI for now. Signe

Re: [PATCH] tests/tcg: Skip failing ppc64 multi-threaded tests in CI

2024-07-25 Thread Peter Maydell
On Thu, 25 Jul 2024 at 16:00, Nicholas Piggin wrote: > > In Gitlab CI, some ppc64 multi-threaded tcg tests crash when run in the > clang-user job with an assertion failure in glibc that seems to > indicate corruption: > > signals: allocatestack.c:223: allocate_stack: > Assertion `powerof2 (p

Re: [PATCH 00/13] make range overlap check more readable

2024-07-25 Thread Peter Maydell
On Mon, 22 Jul 2024 at 08:00, Xingtao Yao (Fujitsu) via wrote: > > > > > -Original Message- > > From: Philippe Mathieu-Daudé > > Sent: Monday, July 22, 2024 2:43 PM > > To: Yao, Xingtao/姚 幸涛 ; qemu-devel@nongnu.org > > Subject: Re: [PATCH 00/13] make range overlap check more readable > >

Re: [RFC PATCH v5 0/8] Add Rust support, implement ARM PL011

2024-07-25 Thread Paolo Bonzini
On Thu, Jul 25, 2024 at 4:48 PM Manos Pitsidianakis wrote: > > pl011_receive (called by qemu_chr_fe_accept_input) creates a mutable > > reference that *overlaps* the lifetime of the outer reference created > > by pl011_read. This is undefined behavior. You're effectively writing: > > There is no o

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread David Woodhouse
On Thu, 2024-07-25 at 10:11 -0400, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > > Even if the virtio-rtc specification were official today, and I was > > able to expose it via PCI, I probably wouldn't do it that way. There's > > just far more in vir

[PATCH v2] tests/tcg: Skip failing ppc64 multi-threaded tests

2024-07-25 Thread Nicholas Piggin
In Gitlab CI, some ppc64 multi-threaded tcg tests crash when run in the clang-user job with an assertion failure in glibc that seems to indicate corruption: signals: allocatestack.c:223: allocate_stack: Assertion `powerof2 (pagesize_m1 + 1)' failed. Disable these tests for now. Signed-off-

Re: [PATCH] ptp: Add vDSO-style vmclock support

2024-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2024 at 04:18:43PM +0100, David Woodhouse wrote: > On Thu, 2024-07-25 at 10:11 -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2024 at 02:50:50PM +0100, David Woodhouse wrote: > > > Even if the virtio-rtc specification were official today, and I was > > > able to expose it via

[PATCH] contrib/plugins/cache.c: Remove redundant check of l2_access

2024-07-25 Thread Peter Maydell
In append_stats_line(), we have an expression l2_access ? l2_miss_rate : 0.0 But this is inside an if (l2_access && l2_misses) { ... } block, so Coverity points out that the false part of the ?: is dead code. Remove the unnecessary test. Resolves: Coverity CID 1522458 Signed-off-by: Peter Mayd

Re: [PATCH v2 1/3] hw/cxl/cxl-host: Fix segmentation fault when getting cxl-fmw property

2024-07-25 Thread Jonathan Cameron via
On Wed, 24 Jul 2024 07:53:48 +0300 Michael Tokarev wrote: > 05.07.2024 14:39, Jonathan Cameron via wrote: > > From: Zhao Liu > > > > QEMU crashes (Segmentation fault) when getting cxl-fmw property via > > qmp: > > > > (QEMU) qom-get path=machine property=cxl-fmw > > > > This issue is caused b

Re: [PATCH v3] target/s390x: filter deprecated properties based on model expansion type

2024-07-25 Thread Collin Walling
On 7/25/24 3:39 AM, David Hildenbrand wrote: > On 25.07.24 09:35, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Collin Walling writes: >>> On 7/24/24 3:56 AM, Markus Armbruster wrote: > Collin Walling writes: Let me try to explain the purpose of @deprecated-props and

  1   2   3   >