On Wed, 24 Jul 2024 07:53:48 +0300
Michael Tokarev <m...@tls.msk.ru> wrote:
> 05.07.2024 14:39, Jonathan Cameron via wrote:
> > From: Zhao Liu <zhao1....@intel.com>
> >
> > QEMU crashes (Segmentation fault) when getting cxl-fmw property via
> > qmp:
> >
> > (QEMU) qom-get path=machine property=cxl-fmw
> >
> > This issue is caused by accessing wrong callback (opaque) type in
> > machine_get_cfmw().
> >
> > cxl_machine_init() sets the callback as `CXLState *` type but
> > machine_get_cfmw() treats the callback as
> > `CXLFixedMemoryWindowOptionsList **`.
> >
> > Fix this error by casting opaque to `CXLState *` type in
> > machine_get_cfmw().
> >
> > Fixes: 03b39fcf64bc ("hw/cxl: Make the CXL fixed memory window setup a
> > machine parameter.")
> > Signed-off-by: Zhao Liu <zhao1....@intel.com>
> > Reviewed-by: Li Zhijian <lizhij...@fujitsu.com>
> > Reviewed-by: Xingtao Yao <yaoxt.f...@fujitsu.com>
> > Link:
> > https://lore.kernel.org/r/20240704093404.1848132-1-zhao1....@linux.intel.com
> > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com>
>
> Is this a stable@ material?
Yes please
Thanks,
Jonathan
>
> Thanks,
>
> /mjt
>
