Re: [PATCH 3/4] tests: Gently exit from GDB when tests complete

2024-05-16 Thread Philippe Mathieu-Daudé
On 15/5/24 19:31, Gustavo Romero wrote: GDB commit a207f6b3a38 ('Rewrite "python" command exception handling') changed how exit() called from Python scripts loaded by GDB behave, turning it into an exception instead of a generic error code that is returned. This change caused several QEMU tests t

Re: [PATCH ats_vtd v1 03/24] intel_iommu: check if the input address is canonical

2024-05-16 Thread CLEMENT MATHIEU--DRIF
Hi, On 16/05/2024 08:41, Duan, Zhenzhong wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > >> -Original Message- >> From: CLEMENT MATHIEU--DRIF >> Subject: Re: [PATCH ats_vtd v1 03

Re: [PATCH v2 03/15] hw/riscv: add RISC-V IOMMU base emulation

2024-05-16 Thread Frank Chang
On Mon, May 13, 2024 at 8:37 PM Daniel Henrique Barboza < dbarb...@ventanamicro.com> wrote: > Hi Frank, > > > On 5/8/24 08:15, Daniel Henrique Barboza wrote: > > Hi Frank, > > > > I'll reply with that I've done so far. Still missing some stuff: > > > > On 5/2/24 08:37, Frank Chang wrote: > >> Hi D

Re: [PATCH v6 4/9] vfio/migration: Add an Error** argument to vfio_migration_set_state()

2024-05-16 Thread Cédric Le Goater
On 5/15/24 09:20, Eric Auger wrote: Hi Cédric, On 5/14/24 17:31, Cédric Le Goater wrote: Add an Error** argument to vfio_migration_set_state() and adjust callers, including vfio_save_setup(). The error will be propagated up to qemu_savevm_state_setup() where the save_setup() handler is executed

[PULL v2 00/11] testing and plugin updates

2024-05-16 Thread Alex Bennée
The following changes since commit 922582ace2df59572a671f5c0c5c6c5c706995e5: Merge tag 'pull-hppa-20240515' of https://gitlab.com/rth7680/qemu into staging (2024-05-15 11:46:58 +0200) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-maintainer-may24-1605

Re: [PATCH v6 4/9] vfio/migration: Add an Error** argument to vfio_migration_set_state()

2024-05-16 Thread Avihai Horon
On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Add an Error** argument to vfio_migration_set_state() and adjust callers, including vfio_save_setup(). The error will be propagated up to qemu_savevm_state_setup() where the save_setup() hand

Re: [PATCH v6 5/9] vfio/migration: Add Error** argument to .vfio_save_config() handler

2024-05-16 Thread Avihai Horon
On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Use vmstate_save_state_with_err() to improve error reporting in the callers and store a reported error under the migration stream. Add documentation while at it. Reviewed-by: Philippe Mathie

Re: [PATCH v6 7/9] memory: Add Error** argument to memory_get_xlat_addr()

2024-05-16 Thread Avihai Horon
On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Let the callers do the reporting. This will be useful in vfio_iommu_map_dirty_notify(). Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: David Hildenbrand Reviewed-by: Peter Xu Signed-off-by

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
Hi Harsh, Thanks for your interest in the patch-set but taking away patches like this from other series without any discussion can disrupt others work and its acceptance on time. This is because we will have to put lot of effort in rebasing bigger series and then testing overhead comes along with

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-16 Thread Zhao Liu
On Wed, May 15, 2024 at 06:06:56PM +0100, Daniel P. Berrangé wrote: > Date: Wed, 15 May 2024 18:06:56 +0100 > From: "Daniel P. Berrangé" > Subject: Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > On Tue, May 14, 2024 at 11:49:40AM +0800, Zhao Liu wrote: > > > I'm

Re: [PATCH 1/1] vhost-vsock: add VIRTIO_F_RING_PACKED to feaure_bits

2024-05-16 Thread Stefano Garzarella
On Mon, Apr 29, 2024 at 01:33:34PM GMT, Halil Pasic wrote: Not having VIRTIO_F_RING_PACKED in feature_bits[] is a problem when the vhost-vsock device does not offer the feature bit VIRTIO_F_RING_PACKED but the in QEMU device is configured to try to use the packed layout (the virtio property "pack

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-16 Thread Zhao Liu
On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:57 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any > machine > > This effectively reverts > > commit 54c4ea8f3ae614054079395842128a85

[PATCH v4 1/3] migration: add "exists" info to load-state-field trace

2024-05-16 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu --- migration/vmstate.c| 5 +++-- migration/trace-events | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index ef26f26ccd..b51212a75b 100644 --- a

[PATCH v4 0/3] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-16 Thread marcandre . lureau
From: Marc-André Lureau Hi, The aforementioned patch breaks virtio-gpu device migrations for versions pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more complex than it may initially appear, as evidenced in the problematic commit dfcf74fa68c ("virtio-gpu: fix scanout mi

[PATCH v4 2/3] migration: fix a typo

2024-05-16 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu Reviewed-by: Fabiano Rosas --- migration/vmstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index b51212a75b..ff5d589a6d 100644 --- a/migration/v

[PATCH v4 3/3] virtio-gpu: fix v2 migration

2024-05-16 Thread marcandre . lureau
From: Marc-André Lureau Commit dfcf74fa ("virtio-gpu: fix scanout migration post-load") broke forward/backward version migration. Versioning of nested VMSD structures is not straightforward, as the wire format doesn't have nested structures versions. Introduce x-scanout-vmstate-version and a fiel

[PATCH v2 3/5] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-16 Thread Thomas Huth
We don't need C++ for the normal QEMU builds anymore, so installing g++ in each and every container seems to be a waste of time and disk space. The only container that still needs it is the Fedora MinGW container that builds the only remaining C++ code in ./qga/vss-win32/ and we can install it ther

[PATCH v2 0/5] tests: Remove xfsprogs and g++ from the dockerfiles

2024-05-16 Thread Thomas Huth
The xfsprogs package is not necessary anymore since commit a5730b8bd3 and we don't need g++ in any of the containers (except for the mingw cross compiler container which can be handled differently), so this patch series simplifies the dockerfiles a little bit accordingly. v2: - Include the "Treat

[PATCH v2 2/5] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-16 Thread Thomas Huth
From: Philippe Mathieu-Daudé QEMU's commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling") removed the need for the 'xfsprogs' package. Signed-off-by: Philippe Mathieu-Daudé [thuth: Adjusted the patch from the lcitools repo to QEMU's repo] Signed-off-by: Thomas Huth ---

[PATCH v2 5/5] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-16 Thread Thomas Huth
Run "make lcitool-refresh" after the previous changes to the lcitool files. This removes the g++ and xfslibs-dev packages from the dockerfiles (except for the fedora-win64-cross dockerfile where we keep the C++ compiler). Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker

[PATCH v2 1/5] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-16 Thread Thomas Huth
In case lcitool fails (e.g. with a python backtrace), this makes the output of lcitool much more readable. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/refresh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/lcitool/refresh b/tests

[PATCH v2 4/5] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-16 Thread Thomas Huth
Let's try to keep the entries in alphabetical order here! Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index b63b6bd850..7511ec

Re: [PATCH v6 8/9] vfio: Add Error** argument to .get_dirty_bitmap() handler

2024-05-16 Thread Avihai Horon
On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Let the callers do the error reporting. Add documentation while at it. Signed-off-by: Cédric Le Goater --- Changes in v6: - Fixed the line wrapping (Avihai) - Fixed query_dirty_bitm

Re: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-16 Thread Zhao Liu
On Mon, May 13, 2024 at 01:33:58PM +0100, Daniel P. Berrangé wrote: > Date: Mon, 13 May 2024 13:33:58 +0100 > From: "Daniel P. Berrangé" > Subject: [PATCH 2/2] tests: add testing of parameter=1 for SMP topology > > Validate that it is possible to pass 'parameter=1' for any SMP topology > paramete

[PATCH v4] hw/pflash: fix block write start

2024-05-16 Thread Gerd Hoffmann
Move the pflash_blk_write_start() call. We need the offset of the first data write, not the offset for the setup (number-of-bytes) write. Without this fix u-boot can do block writes to the first flash block only. While being at it drop a leftover FIXME. Cc: qemu-sta...@nongnu.org Resolves: http

Re: [PATCH v2 1/5] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:55AM +0200, Thomas Huth wrote: > In case lcitool fails (e.g. with a python backtrace), this makes > the output of lcitool much more readable. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Thomas Huth > --- > tests/lcitool/refresh | 4 ++-- > 1 file changed

Re: [PATCH v2 2/5] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:56AM +0200, Thomas Huth wrote: > From: Philippe Mathieu-Daudé > > QEMU's commit a5730b8bd3 ("block/file-posix: Simplify the > XFS_IOC_DIOINFO handling") removed the need for the 'xfsprogs' > package. > > Signed-off-by: Philippe Mathieu-Daudé > [thuth: Adjusted the

Re: [PATCH v2 3/5] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:57AM +0200, Thomas Huth wrote: > We don't need C++ for the normal QEMU builds anymore, so installing > g++ in each and every container seems to be a waste of time and disk > space. The only container that still needs it is the Fedora MinGW > container that builds the o

Re: [PATCH v2 4/5] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:58AM +0200, Thomas Huth wrote: > Let's try to keep the entries in alphabetical order here! > > Signed-off-by: Thomas Huth > --- > tests/lcitool/projects/qemu.yml | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrang

Re: [PATCH v2 5/5] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:59AM +0200, Thomas Huth wrote: > Run "make lcitool-refresh" after the previous changes to the > lcitool files. This removes the g++ and xfslibs-dev packages > from the dockerfiles (except for the fedora-win64-cross dockerfile > where we keep the C++ compiler). > > Sig

[PULL 2/5] hw/loongarch: Remove minimum and default memory size

2024-05-16 Thread Song Gao
From: Bibo Mao Some qtest test cases such as numa use default memory size of generic machine class, which is 128M by fault. Here generic default memory size is used, and also remove minimum memory size which is 1G originally. Signed-off-by: Bibo Mao Reviewed-by: Song Gao Message-Id: <20240511

[PULL 1/5] hw/loongarch: Add compat machine for 9.1

2024-05-16 Thread Song Gao
From: Bibo Mao Since migration test case requires compat machine type support, compat machine is added for qemu 9.1 here. Signed-off-by: Bibo Mao Reviewed-by: Song Gao Message-Id: <20240511034220.3030560-2-maob...@loongson.cn> Signed-off-by: Song Gao --- hw/loongarch/virt.c | 61

[PULL 3/5] tests: Add migration test for loongarch64

2024-05-16 Thread Song Gao
From: Bibo Mao This patch adds migration test support for loongarch64. The test code comes from aarch64 mostly, only that it booted as bios in qemu since kernel requires elf format and bios uses binary format. In addition to providing the binary, this patch also includes the source code and the

[PULL 0/5] loongarch-to-apply queue

2024-05-16 Thread Song Gao
The following changes since commit 922582ace2df59572a671f5c0c5c6c5c706995e5: Merge tag 'pull-hppa-20240515' of https://gitlab.com/rth7680/qemu into staging (2024-05-15 11:46:58 +0200) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarc

[PULL 5/5] target/loongarch/kvm: fpu save the vreg registers high 192bit

2024-05-16 Thread Song Gao
On kvm side, get_fpu/set_fpu save the vreg registers high 192bits, but QEMU missing. Signed-off-by: Song Gao Reviewed-by: Bibo Mao Message-Id: <20240514110752.989572-1-gaos...@loongson.cn> --- target/loongarch/kvm/kvm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/loongarch/

[PULL 4/5] target/loongarch/kvm: Fix VM recovery from disk failures

2024-05-16 Thread Song Gao
vmstate does not save kvm_state_conter, which can cause VM recovery from disk to fail. Cc: qemu-sta...@nongnu.org Signed-off-by: Song Gao Acked-by: Peter Xu Message-Id: <20240508024732.3127792-1-gaos...@loongson.cn> --- target/loongarch/machine.c | 6 -- 1 file changed, 4 insertions(+), 2 d

Re: [PULL v2 00/11] testing and plugin updates

2024-05-16 Thread Richard Henderson
On 5/16/24 09:59, Alex Bennée wrote: The following changes since commit 922582ace2df59572a671f5c0c5c6c5c706995e5: Merge tag 'pull-hppa-20240515' ofhttps://gitlab.com/rth7680/qemu into staging (2024-05-15 11:46:58 +0200) are available in the Git repository at: https://gitlab.com/stsquad

Re: [PULL 1/5] hw/loongarch: Add compat machine for 9.1

2024-05-16 Thread Peter Maydell
On Thu, 16 May 2024 at 10:12, Song Gao wrote: > > From: Bibo Mao > > Since migration test case requires compat machine type support, > compat machine is added for qemu 9.1 here. This is not a good justification for adding versioned machine types. Adding versioned machine types is putting a massi

Re: [PULL 0/5] loongarch-to-apply queue

2024-05-16 Thread Peter Maydell
ilable in the Git repository at: > > https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240516 > > for you to fetch changes up to d55d16700a2e2b36c7e34724d4d77f4a75c5243a: > > target/loongarch/kvm: fpu save the vreg re

Re: [PATCH v4 0/3] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-16 Thread Fiona Ebner
Am 16.05.24 um 10:40 schrieb marcandre.lur...@redhat.com: > From: Marc-André Lureau > > Hi, > > The aforementioned patch breaks virtio-gpu device migrations for versions > pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more > complex than it may initially appear, as evid

Re: [PATCH 08/20] qapi/parser: differentiate intro and outro paragraphs

2024-05-16 Thread Markus Armbruster
John Snow writes: > Add a semantic tag to paragraphs that appear *before* tagged > sections/members/features and those that appear after. This will control > how they are inlined when doc sections are merged and flattened. This future use is not obvious to me now. I guess the effective way to h

[RFC QEMU PATCH v7 1/1] xen/pci: get gsi for passthrough devices

2024-05-16 Thread Jiqian Chen
In PVH dom0, it uses the linux local interrupt mechanism, when it allocs irq for a gsi, it is dynamic, and follow the principle of applying first, distributing first. And the irq number is alloced from small to large, but the applying gsi number is not, may gsi 38 comes before gsi 28, that causes t

Re: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Harsh Prateek Bora
Hi Salil, Thanks for your email. Your patch 1/8 is included here based on review comments on my previous patch from one of the maintainers in the community and therefore I had kept you in CC to be aware of the desire of having this independent patch to get merged earlier even if your other pat

[RFC QEMU PATCH v7 0/1] Support device passthrough when dom0 is PVH on Xen

2024-05-16 Thread Jiqian Chen
Hi All, This is v7 series to support passthrough on Xen when dom0 is PVH. v6->v7 changes: * Due to changes in the implementation of obtaining gsi in the kernel and Xen. Change to use xc_physdev_gsi_from_dev, that requires passing in sbdf instead of irq. Best regards, Jiqian Chen v5->v6 chan

Re: [PATCH 1/4] gdbstub: Add support for target-specific stubs

2024-05-16 Thread Philippe Mathieu-Daudé
On 15/5/24 19:31, Gustavo Romero wrote: Currently, it's not possible to have stubs specific to a given target, even though there are GDB features which are target-specific, like, for instance, memory tagging. This commit introduces set_query_supported_arch, set_gdb_gen_query_table_arch, and set_

Re: [PATCH 2/4] gdbstub: Add support for MTE in user mode

2024-05-16 Thread Philippe Mathieu-Daudé
Hi Gustavo, On 15/5/24 19:31, Gustavo Romero wrote: This commit implements the stubs to handle the qIsAddressTagged, qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 user mode. It also implements the get/set function for the special

Re: [PATCH 0/5] hw/mips/loongson3_virt: Implement IPI support

2024-05-16 Thread Jiaxun Yang
在2024年5月8日五月 下午10:41,Philippe Mathieu-Daudé写道: > On 8/5/24 15:06, Jiaxun Yang wrote: >> Hi all, >> >> This series enabled IPI support for loongson3 virt board, loosely >> based on my previous work[1]. >> It generalized loongarch_ipi device to share among both loongarch >> and MIPS machines. > >

Re: [PATCH v2 1/2] hw/intc/loongarch_extioi: Add extioi virt extension definition

2024-05-16 Thread maobibo
On 2024/5/14 下午5:07, Song Gao wrote: On LoongArch, IRQs can be routed to four vcpus with hardware extioi. This patch adds the extioi virt extension definition so that the IRQ can route to 256 vcpus. Signed-off-by: Song Gao --- include/hw/intc/loongarch_extioi.h | 21 +++ hw/intc/loong

Re: [PATCH v2 2/2] hw/loongarch/virt: Enable extioi virt extension

2024-05-16 Thread maobibo
On 2024/5/14 下午5:07, Song Gao wrote: This patch adds a new board attribute 'v-eiointc'. A value of true enables the virt extended I/O interrupt controller. VMs working in kvm mode have 'v-eiointc' enabled by default. Signed-off-by: Song Gao --- include/hw/loongarch/virt.h | 2 + target/

Re: [PATCH v3 5/5] accel/tcg: Always call tcg_flush_jmp_cache() on reset

2024-05-16 Thread Fiona Ebner
Hi, Am 03.05.24 um 14:34 schrieb Philippe Mathieu-Daudé: > In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") > we unfortunately restricted the tcg_flush_jmp_cache() to system > emulation. Move it to the common tcg_exec_cpu_reset_hold() handler > so user emulation gets the jmp_cac

Re: riscv disassembler error with pmpcfg0

2024-05-16 Thread Eric DeVolder
Thank you! Eric On Tuesday, May 14, 2024 at 12:19:55 AM CDT, Alistair Francis wrote: On Thu, Apr 4, 2024 at 5:02 AM Eric DeVolder wrote: > > I've been using QEMU8 to collect instruction information on U-Boot + OpenSBI. > > I'm running QEMU in this fashion to collect the information:

Re: [PATCH v4] hw/pflash: fix block write start

2024-05-16 Thread Fiona Ebner
Am 16.05.24 um 10:46 schrieb Gerd Hoffmann: > Move the pflash_blk_write_start() call. We need the offset of the > first data write, not the offset for the setup (number-of-bytes) > write. Without this fix u-boot can do block writes to the first > flash block only. > > While being at it drop a le

Re: [PATCH 2/4] gdbstub: Add support for MTE in user mode

2024-05-16 Thread Richard Henderson
On 5/15/24 19:31, Gustavo Romero wrote: +static int aarch64_gdb_set_tag_ctl_reg(CPUState *cs, uint8_t *buf, int reg) +{ +ARMCPU *cpu = ARM_CPU(cs); +CPUARMState *env = &cpu->env; + +assert(reg == 0); + +/* Sanitize TCF0 bits. */ +*buf &= 0x03; + +if (!isar_feature_aa64_mte

[PATCH 0/4] MAINTAINERS: update kraxel's entries.

2024-05-16 Thread Gerd Hoffmann
I have not found much time to work on qemu due to being busy with firmware (edk2 for the most part). Time to update the MAINTAINERS file entries to match reality. I drop spice, ui, audio and usb due to lack of time. I drop virtio-gpu, I don't follow recent development (venus etc.) close enough t

[PATCH 3/4] MAINTAINERS: drop virtio-gpu maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from virtio-gpu entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d81376f84746..4d9f4fd09823 100644 --- a/MA

[PATCH 2/4] MAINTAINERS: drop usb maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from usb entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7f52e2912fc3..d81376f84746 100644 --- a/MAINTAINE

[PATCH 4/4] MAINTAINERS: drop spice+ui maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from spice and ui entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4d9f4fd09823..d5b6a1c76abb 100644 --- a/

[PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-16 Thread Gerd Hoffmann
Remove myself from audio (both devices and backend) entries. Flip status to "Orphan" for entries which have nobody else listed. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1b

Re: [PATCH v6 4/9] vfio/migration: Add an Error** argument to vfio_migration_set_state()

2024-05-16 Thread Cédric Le Goater
On 5/16/24 10:18, Avihai Horon wrote: On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Add an Error** argument to vfio_migration_set_state() and adjust callers, including vfio_save_setup(). The error will be propagated up to qemu_savevm_sta

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
Hi Harsh, > From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 11:15 AM > > Hi Salil, > > Thanks for your email. > Your patch 1/8 is included here based on review comments on my previous > patch from one of the maintainers in the community and therefore I had > kept you in CC to b

[PATCH v5] hw/pflash: fix block write start

2024-05-16 Thread Gerd Hoffmann
Move the pflash_blk_write_start() call. We need the offset of the first data write, not the offset for the setup (number-of-bytes) write. Without this fix u-boot can do block writes to the first flash block only. While being at it drop a leftover FIXME. Cc: qemu-sta...@nongnu.org Resolves: http

Re: [PATCH v5 6/8] xen: mapcache: Pass the ram_addr offset to xen_map_cache()

2024-05-16 Thread Edgar E. Iglesias
On Thu, May 16, 2024 at 1:08 AM Stefano Stabellini wrote: > > On Fri, 3 May 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Pass the ram_addr offset to xen_map_cache. > > This is in preparation for adding grant mappings that need > > to compute the address within the RAMBlock

Re: [PATCH v6 8/9] vfio: Add Error** argument to .get_dirty_bitmap() handler

2024-05-16 Thread Cédric Le Goater
On 5/16/24 10:42, Avihai Horon wrote: On 14/05/2024 18:31, Cédric Le Goater wrote: External email: Use caution opening links or attachments Let the callers do the error reporting. Add documentation while at it. Signed-off-by: Cédric Le Goater ---   Changes in v6:   - Fixed the line wrappi

Re: [PATCH 2/4] gdbstub: Add support for MTE in user mode

2024-05-16 Thread Richard Henderson
On 5/15/24 19:31, Gustavo Romero wrote: +/* Remove any non-addressing bits. */ +clean_addr = useronly_clean_ptr(addr); + +/* + * Get pointer to all tags in the page where the address is. Note that tags + * are packed, so there are 2 tags packed in one byte. + */ +tags

[PATCH] target/riscv: zvbb implies zvkb

2024-05-16 Thread Jerry Zhang Jian
- According to RISC-V crypto spec, Zvkb extension is a proper subset of the Zvbb extension. - Reference: https://github.com/riscv/riscv-crypto/blob/1769c2609bf4535632e0c0fd715778f212bb272e/doc/vector/riscv-crypto-vector-zvkb.adoc?plain=1#L10 Signed-off-by: Jerry Zhang Jian --- target/riscv/tc

[PATCH v7 5/9] vfio/migration: Add Error** argument to .vfio_save_config() handler

2024-05-16 Thread Cédric Le Goater
Use vmstate_save_state_with_err() to improve error reporting in the callers and store a reported error under the migration stream. Add documentation while at it. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Reviewed-by: Avihai Horon Signed-off-by: Cédric Le Goater --- include/h

[PATCH v7 6/9] vfio: Reverse test on vfio_get_xlat_addr()

2024-05-16 Thread Cédric Le Goater
It will simplify the changes coming after. Reviewed-by: Avihai Horon Reviewed-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 2c97de6c730d9

[PATCH v7 4/9] vfio/migration: Add an Error** argument to vfio_migration_set_state()

2024-05-16 Thread Cédric Le Goater
Add an Error** argument to vfio_migration_set_state() and adjust callers, including vfio_save_setup(). The error will be propagated up to qemu_savevm_state_setup() where the save_setup() handler is executed. Modify vfio_vmstate_change_prepare() and vfio_vmstate_change() to store a reported error u

[PATCH v7 8/9] vfio: Add Error** argument to .get_dirty_bitmap() handler

2024-05-16 Thread Cédric Le Goater
Let the callers do the error reporting. Add documentation while at it. Reviewed-by: Eric Auger Reviewed-by: Avihai Horon Signed-off-by: Cédric Le Goater --- Changes in v7: - Fixed even more line wrapping of *dirty_bitmap() routines (Avihai) - vfio_sync_dirty_bitmap() Fixed return when

[PATCH v7 2/9] vfio: Add Error** argument to vfio_devices_dma_logging_start()

2024-05-16 Thread Cédric Le Goater
This allows to update the Error argument of the VFIO log_global_start() handler. Errors for container based logging will also be propagated to qemu_savevm_state_setup() when the ram save_setup() handler is executed. Also, errors from vfio_container_set_dirty_page_tracking() are now collected and re

[PATCH v7 7/9] memory: Add Error** argument to memory_get_xlat_addr()

2024-05-16 Thread Cédric Le Goater
Let the callers do the reporting. This will be useful in vfio_iommu_map_dirty_notify(). Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: David Hildenbrand Reviewed-by: Peter Xu Reviewed-by: Eric Auger Reviewed-by: Avihai Horon Signed-off-by: Cédric Le Goater --- include/exec/memory.h | 15 +++

[PATCH v7 1/9] vfio: Add Error** argument to .set_dirty_page_tracking() handler

2024-05-16 Thread Cédric Le Goater
We will use the Error object to improve error reporting in the .log_global*() handlers of VFIO. Add documentation while at it. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Avihai Horon Reviewed-by: Eric Auger Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 18 +

[PATCH v7 0/9] vfio: Improve error reporting (part 2)

2024-05-16 Thread Cédric Le Goater
Hello, The motivation behind these changes is to improve error reporting to the upper management layer (libvirt) with a more detailed error, this to let it decide, depending on the reported error, whether to try migration again later. It would be useful in cases where migration fails due to lack o

[PATCH v7 9/9] vfio: Also trace event failures in vfio_save_complete_precopy()

2024-05-16 Thread Cédric Le Goater
vfio_save_complete_precopy() currently returns before doing the trace event. Change that. Reviewed-by: Avihai Horon Reviewed-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/migration.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c in

[PATCH v7 3/9] migration: Extend migration_file_set_error() with Error* argument

2024-05-16 Thread Cédric Le Goater
Use it to update the current error of the migration stream if available and if not, simply print out the error. Next changes will update with an error to report. Reviewed-by: Avihai Horon Acked-by: Fabiano Rosas Reviewed-by: Eric Auger Signed-off-by: Cédric Le Goater --- Changes in v7: - v

Re: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Harsh Prateek Bora
Hi Salil, On 5/16/24 17:42, Salil Mehta wrote: Hi Harsh, From: Harsh Prateek Bora Sent: Thursday, May 16, 2024 11:15 AM Hi Salil, Thanks for your email. Your patch 1/8 is included here based on review comments on my previous patch from one of the maintainers in the communit

Re: [PATCH 2/4] MAINTAINERS: drop usb maintainership

2024-05-16 Thread Peter Maydell
On Thu, 16 May 2024 at 13:04, Gerd Hoffmann wrote: > > Remove myself from usb entries. > Flip status to "Orphan" for entries which have nobody else listed. > diff --git a/MAINTAINERS b/MAINTAINERS > index 7f52e2912fc3..d81376f84746 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS Thanks for your t

Re: [PATCH 2/4] MAINTAINERS: drop usb maintainership

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 02:11:52PM +0100, Peter Maydell wrote: > On Thu, 16 May 2024 at 13:04, Gerd Hoffmann wrote: > > > > Remove myself from usb entries. > > Flip status to "Orphan" for entries which have nobody else listed. > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 7f52e2912fc3..d

Re: [PATCH 01/17] ppc64: Fix include order

2024-05-16 Thread Richard Henderson
On 5/15/24 18:55, Philippe Mathieu-Daudé wrote: On 15/5/24 15:53, Richard Henderson wrote: On 5/15/24 15:11, Philippe Mathieu-Daudé wrote: Hi Richard, On 11/5/24 13:53, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   risu_ppc64.c | 3 +--   1 file changed, 1 insertion(+), 2 de

RE: [PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta via
> From: Harsh Prateek Bora > Sent: Thursday, May 16, 2024 2:07 PM > > Hi Salil, > > On 5/16/24 17:42, Salil Mehta wrote: > > Hi Harsh, > > > >> From: Harsh Prateek Bora > >> Sent: Thursday, May 16, 2024 11:15 AM > >> > >> Hi Salil, > >> > >> Thanks for your email. > >>

Re: [PULL 04/17] virtio-net: Add support for USO features

2024-05-16 Thread Fiona Ebner
Hi, Am 08.09.23 um 08:44 schrieb Jason Wang: > diff --git a/hw/core/machine.c b/hw/core/machine.c > index da699cf..230aab8 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -38,6 +38,7 @@ > #include "exec/confidential-guest-support.h" > #include "hw/virtio/virtio.h" > #include "hw

Re: [PATCH v2 15/15] hw/misc: EDU: add ATS/PRI capability

2024-05-16 Thread Daniel Henrique Barboza
Hi Frank! On 5/7/24 12:32, Frank Chang wrote: Hi Daniel, Daniel Henrique Barboza 於 2024年3月8日 週五 上午12:05寫道: From: Tomasz Jeznach Mimic ATS interface with IOMMU translate request with IOMMU_NONE. If mapping exists, translation service will return current permission flags, otherwise will rep

Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config

2024-05-16 Thread Hongren Zheng
On Mon, May 13, 2024 at 03:18:53PM +0800, Yangyu Chen wrote: > I think this patch also needs to back-port to stable-8.2. Indeed, downstream OpenSSL CI using Ubuntu 24.04, which ships QEMU 8.2.2, encountered this bug and that is quite confusing QEMU 9.0.0 is also affected Links https://github.com

Re: [RFC PATCH v3 3/5] KVM: x86: Add notifications for Heki policy configuration and violation

2024-05-16 Thread Nicolas Saenz Julienne
On Tue May 14, 2024 at 12:23 PM UTC, Mickaël Salaün wrote: > > Development happens > > https://github.com/vianpl/{linux,qemu,kvm-unit-tests} and the vsm-next > > branch, but I'd advice against looking into it until we add some order > > to the rework. Regardless, feel free to get in touch. > > Than

[PATCH v2 1/4] accel/kvm: Extract common KVM vCPU {creation, parking} code

2024-05-16 Thread Salil Mehta
[+] Adding this email address to the conversation. (sorry for the noise) > From: Salil Mehta > Sent: Thursday, May 16, 2024 2:36 PM > > > From: Harsh Prateek Bora > > Sent: Thursday, May 16, 2024 2:07 PM > > > > Hi Salil, > > > > On 5/16/24 17:42, Salil Mehta wrote: > > > Hi Harsh,

Re: [PATCH 05/20] qapi/parser: adjust info location for doc body section

2024-05-16 Thread John Snow
On Thu, May 16, 2024, 1:58 AM Markus Armbruster wrote: > John Snow writes: > > > Instead of using the info object for the doc block as a whole, update > > the info pointer for each call to ensure_untagged_section when the > > existing section is otherwise empty. This way, Sphinx error informatio

[RFC/PATCH v2 00/12] Gunyah hypervisor support

2024-05-16 Thread Srivatsa Vaddagiri
Appreciate any quick comments you have. This is v2 that I intend to publish on qemu lists. Main changes since v1 is adding support for protected VM. === Gunyah is an open-source Type-1 hypervisor, that is currently supported on ARM64 architecture. Source code for it can be obtained from: htt

[RFC/PATCH v2 00/12] Gunyah hypervisor support

2024-05-16 Thread Srivatsa Vaddagiri
Gunyah is an open-source Type-1 hypervisor, that is currently supported on ARM64 architecture. Source code for it can be obtained from: https://github.com/quic/gunyah-hypervisor This patch series adds support for Gunyah hypervisor via a new accelerator option, 'gunyah'. This patch series is bas

[RFC/PATCH v2 03/12] hw/arm/virt: confidential guest support

2024-05-16 Thread Srivatsa Vaddagiri
This adds support to launch hypervisor-assisted confidential guests, where guest's memory is protected from a potentially untrusted host. Hypervisor can setup host's page-tables so that it loses access to guest memory. Since some guest drivers may need to communicate data with their host counterpa

[RFC/PATCH v2 05/12] gunyah: Support memory assignment

2024-05-16 Thread Srivatsa Vaddagiri
Gunyah hypervisor supports several APIs for a host VM to assign some of its memory to the VM being created. Lend - assigned memory is made private to VM (host loses access) Share - assigned memory is shared between host and guest VM No APIs exist however, at this time, for a confidential

[RFC/PATCH v2 02/12] accel: Introduce check_capability() callback

2024-05-16 Thread Srivatsa Vaddagiri
check_capability() offers a mechanism to discover accelerator capabilities. Two capabilities are introduced at this time to discover if confidential guest support exists and whether a confidential guest can share its private memory with host (using appropriate hypervisor APIs). Signed-off-by: Sri

[RFC/PATCH v2 04/12] gunyah: Basic support

2024-05-16 Thread Srivatsa Vaddagiri
Add a new accelerator, gunyah, with basic functionality of creating a VM. Subsequent patches will add support for other functions required to run a VM. Signed-off-by: Srivatsa Vaddagiri --- MAINTAINERS | 7 ++ docs/about/build-platforms.rst | 2 +- meson.build

[RFC/PATCH v2 09/12] gunyah: Customize device-tree

2024-05-16 Thread Srivatsa Vaddagiri
Customize device-tree with Gunyah specific properties. Some of these properties include specification of doorbells that need to be created and associated with various interrupts. Signed-off-by: Srivatsa Vaddagiri --- include/sysemu/gunyah.h | 2 + accel/stubs/gunyah-stub.c | 5 +++ hw/arm/vi

[RFC/PATCH v2 08/12] gunyah: Specific device-tree location

2024-05-16 Thread Srivatsa Vaddagiri
Specify the location of device-tree and its size, as Gunyah requires the device-tree to be parsed before VM can begin its execution. Signed-off-by: Srivatsa Vaddagiri --- MAINTAINERS | 1 + include/sysemu/gunyah.h | 2 ++ accel/stubs/gunyah-stub.c | 5 + hw/arm/virt.c

[RFC/PATCH v2 10/12] gunyah: CPU execution loop

2024-05-16 Thread Srivatsa Vaddagiri
Complete the cpu execution loop. At this time, we recognize exits associated with only MMIO access. Future patches will add support for recognizing other exit reasons, such as PSCI calls made by guest. Signed-off-by: Srivatsa Vaddagiri --- include/sysemu/gunyah_int.h | 9 ++ accel/gunyah/g

Re: [RFC/PATCH v2 00/12] Gunyah hypervisor support

2024-05-16 Thread Srivatsa Vaddagiri
* Srivatsa Vaddagiri [2024-05-16 14:33:08]: > Appreciate any quick comments you have. This is v2 that I intend to publish on > qemu lists. Main changes since v1 is adding support for protected VM. Pls ignore this !

[RFC/PATCH v2 11/12] gunyah: Workarounds (NOT FOR MERGE)

2024-05-16 Thread Srivatsa Vaddagiri
These are some work-arounds required temporarily until some limitations with Gunyah hypervisor are addressed. Signed-off-by: Srivatsa Vaddagiri --- include/sysemu/gunyah_int.h | 1 + accel/gunyah/gunyah-all.c | 18 ++ hw/arm/boot.c | 17 - hw/arm/

[RFC/PATCH v2 07/12] gunyah: Add gicv3 interrupt controller

2024-05-16 Thread Srivatsa Vaddagiri
Gunyah hypervisor supports emulation of a GICv3 compatible interrupt controller. Emulation is handled by hypervisor itself, with Qemu being allowed to specify some of the properties such as IO address at which GICv3 should be mapped in guest address space. These properties are conveyed to hyperviso

[RFC/PATCH v2 12/12] gunyah: Documentation

2024-05-16 Thread Srivatsa Vaddagiri
Add gunyah.rst that provide some informaiton on how to build and test 'gunyah' accelerator with open-source Gunyah hypervisor. Signed-off-by: Srivatsa Vaddagiri --- MAINTAINERS| 1 + docs/system/arm/gunyah.rst | 326 + 2 files changed, 327 in

[RFC/PATCH v2 06/12] gunyah: Add IRQFD and IOEVENTFD functions

2024-05-16 Thread Srivatsa Vaddagiri
IRQFD function allows registering of an @eventfd and @irq. @irq will be injected inside guest when @eventfd is written into. IOEVENTFD function allows registering an @eventfd and a guest physical address, @addr, along with optional data. A poll() on @eventfd will be woken up when guest attempts t

  1   2   3   >