Re: [PATCH] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Yong Huang
On Tue, Apr 23, 2024 at 2:19 PM Masato Imai wrote: > When the KVM acceleration parameter is not set, executing calc_dirty_rate > with the -r option results in a segmentation fault due to accessing a > null kvm_state pointer in the kvm_dirty_rate_enabled function. > s/kvm_dirty_rate_enabled/kvm_d

Re: [PATCH] target/arm: Restrict translation disabled alignment check to VMSA

2024-04-23 Thread Clément Chigot
On Mon, Apr 22, 2024 at 11:02 PM Philippe Mathieu-Daudé wrote: > > On 22/4/24 19:09, Richard Henderson wrote: > > On 4/22/24 10:07, Richard Henderson wrote: > >> For cpus using PMSA, when the MPU is disabled, the default memory > >> type is Normal, Non-cachable. > >> > >> Fixes: 59754f85ed3 ("targ

Re: [PATCH 00/27] Add qapi-domain Sphinx extension

2024-04-23 Thread Markus Armbruster
John Snow writes: > On Mon, Apr 22, 2024 at 5:20 AM Markus Armbruster wrote: >> >> John Snow writes: >> >> > On Fri, Apr 19, 2024, 10:45 AM Markus Armbruster wrote: >> > >> >> John Snow writes: >> >> >> >> > This series adds a new qapi-domain extension for Sphinx, which adds a >> >> > series

Re: Missing features in QEMU SapphireRapid definition

2024-04-23 Thread Wang, Lei
Hi Manish, Thanks for the information. It seems those 3 features are missing in the SPR CPU Model definition, we are currently polishing our new SPR CPU Model version, you can launch the SPR CPU Model using: -cpu SapphireRapids,+cldemote,+movdiri,+movdir64b as a workaround and sorry for

Re: Missing features in QEMU SapphireRapid definition

2024-04-23 Thread Manish Mishra
Thanks Wang Lie. Yes sure will do same until we have new version. Thanks Manish Mishra From: Wang, Lei Date: Tuesday, 23 April 2024 at 12:50 PM To: Manish Mishra , qemu-devel@nongnu.org Cc: christopher.r.blev...@intel.com , robert...@linux.intel.com Subject: Re: Missing features in QEMU Sapp

Re: [PATCH 0/3] target/arm: Make the counter frequency default 1GHz for new CPUs, machines

2024-04-23 Thread Marcin Juszkiewicz
W dniu 22.04.2024 o 17:37, Marcin Juszkiewicz pisze: It also seems to be hardcoded in TF-A's support for the virt board too, annoyingly. I looked at it and it seems that TF-A can just read what is in CNTFRQ_EL0 instead of hardcoding the value. Submitted patch: https://review.trustedfirmware

Re: [PATCH 00/27] Add qapi-domain Sphinx extension

2024-04-23 Thread Markus Armbruster
John Snow writes: > On Mon, Apr 22, 2024 at 12:38 PM John Snow wrote: >> >> On Mon, Apr 22, 2024 at 5:20 AM Markus Armbruster wrote: >> > >> > John Snow writes: >> > >> > > On Fri, Apr 19, 2024, 10:45 AM Markus Armbruster >> > > wrote: >> > > >> > >> John Snow writes: >> > >> >> > >> > This

Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Philippe Mathieu-Daudé
On 22/4/24 21:03, Volker Rümelin wrote: Am 20.04.24 um 07:40 schrieb Mark Cave-Ayland: On 20/04/2024 02:21, Richard Henderson wrote: On 4/19/24 12:51, Mark Cave-Ayland wrote: The various Intel CPU manuals claim that SGDT and SIDT can write either 24-bits or 32-bits depending upon the operand

Re: [PATCH v1 3/4] virtio-snd: factor card removal out of unrealize()

2024-04-23 Thread Philippe Mathieu-Daudé
On 22/4/24 15:27, Philippe Mathieu-Daudé wrote: On 22/4/24 14:52, Manos Pitsidianakis wrote: Extract audio card removal logic out of the device unrealize callback so that it can be re-used in follow up commits. Signed-off-by: Manos Pitsidianakis ---   hw/audio/virtio-snd.c | 20 ++-

Re: [PATCH intel_iommu 3/7] intel_iommu: make types match

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 07:05, CLEMENT MATHIEU--DRIF wrote: On 22/04/2024 19:03, Philippe Mathieu-Daudé wrote: On 22/4/24 17:52, CLEMENT MATHIEU--DRIF wrote: The 'level' field in vtd_iotlb_key is an uint8_t. We don't need to store level as an int in vtd_lookup_iotlb Signed-off-by: Clément Mathieu--Drif -

Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 10:15:57AM +0200, Philippe Mathieu-Daudé wrote: > On 22/4/24 21:03, Volker Rümelin wrote: > > Am 20.04.24 um 07:40 schrieb Mark Cave-Ayland: > > > On 20/04/2024 02:21, Richard Henderson wrote: > > > > > > > On 4/19/24 12:51, Mark Cave-Ayland wrote: > > > > > The various Int

Re: [PATCH v8 00/11] Support blob memory and venus on qemu

2024-04-23 Thread Alex Bennée
Dmitry Osipenko writes: > Hello, > > This series enables Vulkan Venus context support on virtio-gpu. > > All virglrender and almost all Linux kernel prerequisite changes > needed by Venus are already in upstream. For kernel there is a pending > KVM patchset that fixes mapping of compound pages ne

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Manos Pitsidianakis
On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: > > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > > > > Since VirtIO devices can change

Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Paolo Bonzini
On Mon, Apr 22, 2024 at 9:10 PM Volker Rümelin wrote: > > Am 20.04.24 um 07:40 schrieb Mark Cave-Ayland: > >> Current documentation agrees that all 32 bits are written, so I don't > >> think you need this comment: > > > > Ah that's good to know the docs are now correct. I added the comment > > as

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Manos Pitsidianakis
On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: > > On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: > > > > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > > > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > > > On Mon, Apr 22, 2024 at 04:20:56PM +0200,

Re: [PATCH v2 02/22] target/arm: Add confidential guest support

2024-04-23 Thread Jean-Philippe Brucker
On Fri, Apr 19, 2024 at 05:25:12PM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 19, 2024 at 04:56:50PM +0100, Jean-Philippe Brucker wrote: > > Add a new RmeGuest object, inheriting from ConfidentialGuestSupport, to > > support the Arm Realm Management Extension (RME). It is instantiated by > > pa

Re: [PATCH v2 02/22] target/arm: Add confidential guest support

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 10:44:56AM +0100, Jean-Philippe Brucker wrote: > On Fri, Apr 19, 2024 at 05:25:12PM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 19, 2024 at 04:56:50PM +0100, Jean-Philippe Brucker wrote: > > > Add a new RmeGuest object, inheriting from ConfidentialGuestSupport, to > > >

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-23 Thread Alexandra Diupina
17/04/24 13:05, Konrad, Frederic пишет: Hi, -Original Message- From: qemu-devel-bounces+fkonrad=amd@nongnu.org On Behalf Of Peter Maydell Sent: Friday, April 12, 2024 12:07 PM To: Alexandra Diupina Cc: Alistair Francis ; Edgar E. Iglesias ; qemu-...@nongnu.org; qemu- de...@n

Re: [PATCH 0/6] Add ivshmem-flat device

2024-04-23 Thread Markus Armbruster
Gustavo Romero writes: > Hi Markus, > > Thanks for interesting in the ivshmem-flat device. > > Bill Mills (cc:ed) is the best person to answer your question, > so please find his answer below. > > On 2/28/24 3:29 AM, Markus Armbruster wrote: >> Gustavo Romero writes: >> >> [...] >> >>> This pa

Re: [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address()

2024-04-23 Thread Peter Maydell
On Tue, 23 Apr 2024 at 11:23, Alexandra Diupina wrote: > 17/04/24 13:05, Konrad, Frederic пишет: > > Peter Maydell wrote: > >> Also, this device looks like it has a host-endianness bug: the > >> DPDMADescriptor struct is read directly from guest memory in > >> dma_memory_read(), but the device nev

Re: [PATCH 3/6] hw/acpi: Generic Port Affinity Structure support

2024-04-23 Thread Markus Armbruster
Jonathan Cameron writes: > These are very similar to the recently added Generic Initiators > but instead of representing an initiator of memory traffic they > represent an edge point beyond which may lie either targets or > initiators. Here we add these ports such that they may > be targets of h

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 11:18, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: On 22/4/24 23:02, Michael S. Tsirkin wrote: On Mon, Apr 22,

Re: [PATCH 2/3] target/arm: Refactor default generic timer frequency handling

2024-04-23 Thread Philippe Mathieu-Daudé
On 19/4/24 20:46, Peter Maydell wrote: The generic timer frequency is settable by board code via a QOM property "cntfrq", but otherwise defaults to 62.5MHz. The way this is done includes some complication resulting from how this was originally a fixed value with no QOM property. Clean it up:

Re: [PATCH v2 02/22] target/arm: Add confidential guest support

2024-04-23 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Apr 19, 2024 at 04:56:50PM +0100, Jean-Philippe Brucker wrote: >> Add a new RmeGuest object, inheriting from ConfidentialGuestSupport, to >> support the Arm Realm Management Extension (RME). It is instantiated by >> passing on the command-line: >> >> -M vir

Re: [PATCH v2 14/22] target/arm/kvm-rme: Add Realm Personalization Value parameter

2024-04-23 Thread Markus Armbruster
Jean-Philippe Brucker writes: > The Realm Personalization Value (RPV) is provided by the user to > distinguish Realms that have the same initial measurement. > > The user provides up to 64 hexadecimal bytes. They are stored into the > RPV in the same order, zero-padded on the right. > > Cc: Eric

Re: [PATCH v2 14/22] target/arm/kvm-rme: Add Realm Personalization Value parameter

2024-04-23 Thread Peter Maydell
On Fri, 19 Apr 2024 at 16:59, Jean-Philippe Brucker wrote: > > The Realm Personalization Value (RPV) is provided by the user to > distinguish Realms that have the same initial measurement. > > The user provides up to 64 hexadecimal bytes. They are stored into the > RPV in the same order, zero-padd

Re: [PATCH v2 15/22] target/arm/kvm-rme: Add measurement algorithm property

2024-04-23 Thread Markus Armbruster
Jean-Philippe Brucker writes: > This option selects which measurement algorithm to use for attestation. > Supported values are SHA256 and SHA512. Default to SHA512 arbitrarily. > > SHA512 is generally faster on 64-bit architectures. On a few arm64 CPUs > I tested SHA256 is much faster, but that's

Re: [PATCH v2 14/22] target/arm/kvm-rme: Add Realm Personalization Value parameter

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 01:20:20PM +0100, Peter Maydell wrote: > On Fri, 19 Apr 2024 at 16:59, Jean-Philippe Brucker > wrote: > > > > The Realm Personalization Value (RPV) is provided by the user to > > distinguish Realms that have the same initial measurement. > > > > The user provides up to 64 h

Re: [PATCH v2 14/22] target/arm/kvm-rme: Add Realm Personalization Value parameter

2024-04-23 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 19 Apr 2024 at 16:59, Jean-Philippe Brucker > wrote: >> >> The Realm Personalization Value (RPV) is provided by the user to >> distinguish Realms that have the same initial measurement. >> >> The user provides up to 64 hexadecimal bytes. They are stored into the >

Re: [PATCH] target/riscv: change RISCV_EXCP_SEMIHOST exception number to 63

2024-04-23 Thread Clément Léger
On 22/04/2024 21:58, Daniel Henrique Barboza wrote: > > > On 4/22/24 16:44, Richard Henderson wrote: >> On 4/22/24 10:45, Daniel Henrique Barboza wrote: >>> Palmer, Anup, >>> >>> On 4/22/24 10:58, Clément Léger wrote: The current semihost exception number (16) is a reserved number (range

[PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Masato Imai
When the KVM acceleration parameter is not set, executing calc_dirty_rate with the -r or -b option results in a segmentation fault due to accessing a null kvm_state pointer in the kvm_dirty_ring_enabled function. This commit adds a check for kvm_enabled to prevent segmentation faults. Signed-off-b

[PATCH] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Masato Imai
When the KVM acceleration parameter is not set, executing calc_dirty_rate with the -r option results in a segmentation fault due to accessing a null kvm_state pointer in the kvm_dirty_rate_enabled function. This commit adds a check for kvm_enabled to prevent segmentation faults. Signed-off-by: Mas

[PATCH v2 0/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Masato Imai
Changes from v1: - fix typo in commit message - added an extra check for dirty bitmap mode Masato Imai (1): migration/dirtyrate: Fix segmentation fault migration/dirtyrate.c | 7 +++ 1 file changed, 7 insertions(+) -- 2.34.1

[PATCH 03/22] arm: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
For ARM targets, boards that require TCG are already using "default y". Switch ARM_VIRT to the same selection mechanism. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/arm-softmmu/default.mak | 3 ++- hw/arm/Kconfig | 2

[PATCH 00/22] configs: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some boards, notably ARM boards that use TCG, are already using "default y". This was done to remove TCG-only boards from a KVM-only build in commit 29d9efca16 (2023-04-26). This series converts all other boards to that, so that the requirements of each board are clearer in the Kconfig files. Fo

[PATCH 06/22] hppa: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with PARISC. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/hppa-softmmu/default.mak | 5

[PATCH 02/22] alpha: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Start with Alpha. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/alpha-softmmu/default.mak | 5 ++-

[PATCH 01/22] configs: list "implied" device groups in the default configs

2024-04-23 Thread Paolo Bonzini
Match the optional device groups to what is actually included in the config-devices.mak files. Signed-off-by: Paolo Bonzini --- configs/devices/arm-softmmu/default.mak | 2 ++ configs/devices/loongarch64-softmmu/default.mak | 3 +++ configs/devices/or1k-softmmu/default.mak| 4 +++

[PATCH 17/22] rx: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with RX. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/rx-softmmu/default.mak | 3 ++- h

[PATCH 12/22] mips: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with MIPS. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/mips-softmmu/common.mak |

[PATCH 08/22] loongarch: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Loongarch. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/loongarch64-softmmu/defaul

[PATCH 20/22] sparc: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with SPARC and SPARC64. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/sparc-softmmu/defa

[PATCH 13/22] nios2: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Nios2. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/nios2-softmmu/default.mak | 7

[PATCH 16/22] riscv: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with RISC-V. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/riscv32-softmmu/default.mak |

[PATCH 22/22] xtensa: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Xtensa. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/xtensa-softmmu/default.mak |

[PATCH 07/22] i386: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with i386. No changes to generated config-devices.mak files, other than adding CONFIG_I386 to the x86_64-softmmu target. Signed-off-by: Paolo

[PATCH 15/22] ppc: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with PowerPC/POWER. No changes to generated config-devices.mak files, other than adding CONFIG_PPC to the ppc64-softmmu target. Signed-off-by:

[PATCH 21/22] tricore: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with TriCore. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/tricore-softmmu/default.mak

[PATCH 18/22] s390x: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with s390. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/s390x-softmmu/default.mak | 5 +

[PATCH 09/22] m68k: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with m68k. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/m68k-softmmu/default.mak | 13 +

[PATCH 10/22] microblaze: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Microblaze. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/microblaze-softmmu/defaul

[PATCH 04/22] avr: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with AVR. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/avr-softmmu/default.mak | 5 ++--

[PATCH 11/22] meson: make target endianneess available to Kconfig

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. MIPS boards may only be available for big-endian or only for little-endian emulators, add a symbol so that this can be described with a "depends on" clau

[PATCH 05/22] cris: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with CRIS. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/cris-softmmu/default.mak | 5 ++

[PATCH 19/22] sh4: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with SH. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/sh4-softmmu/default.mak | 7 +++--

[PATCH 14/22] openrisc: switch boards to "default y"

2024-04-23 Thread Paolo Bonzini
Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with OpenRISC. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs/devices/or1k-softmmu/default.mak |

Re: [PATCH 04/22] avr: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with AVR. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- config

Re: [PATCH 17/22] rx: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with RX. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs

Re: [PATCH 19/22] sh4: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with SH. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs

Re: [PATCH 21/22] tricore: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with TriCore. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- co

Re: [PATCH v2 1/1] migration/dirtyrate: Fix segmentation fault

2024-04-23 Thread Peter Xu
On Tue, Apr 23, 2024 at 09:13:08AM +, Masato Imai wrote: > When the KVM acceleration parameter is not set, executing calc_dirty_rate > with the -r or -b option results in a segmentation fault due to accessing > a null kvm_state pointer in the kvm_dirty_ring_enabled function. > This commit adds

Re: [PATCH 22/22] xtensa: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Xtensa. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- con

Re: [PATCH 10/22] microblaze: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Microblaze. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini ---

Re: [PATCH 09/22] m68k: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with m68k. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- confi

Re: [PATCH 06/22] hppa: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with PARISC. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- con

Re: [PATCH 05/22] cris: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with CRIS. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- confi

Re: [PATCH 02/22] alpha: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Start with Alpha. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- configs

Re: [PATCH 08/22] loongarch: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:15, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Loongarch. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini ---

Re: [PATCH 14/22] openrisc: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with OpenRISC. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- c

Re: [PATCH 13/22] nios2: switch boards to "default y"

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 15:16, Paolo Bonzini wrote: Some targets use "default y" for boards to filter out those that require TCG. For consistency we are switching all other targets to do the same. Continue with Nios2. No changes to generated config-devices.mak file. Signed-off-by: Paolo Bonzini --- conf

Re: [PATCH v10 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0

2024-04-23 Thread Daniel P . Berrangé
On Mon, Apr 22, 2024 at 07:22:48PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > 'fence_fd' needs to be validated always before being referenced > And the passing condition should include '== 0' as 0 is a valid > value for the file descriptor. > > Suggested-by: Marc-André Lureau >

Re: [PATCH-for-9.0? 01/21] host/atomic128: Include missing 'qemu/atomic.h' header

2024-04-23 Thread Philippe Mathieu-Daudé
On 21/3/24 18:05, Richard Henderson wrote: On 3/21/24 05:48, Philippe Mathieu-Daudé wrote: qatomic_cmpxchg__nocheck(), qatomic_read__nocheck(), qatomic_set__nocheck() are defined in "qemu/atomic.h". Include it in order to avoid:    In file included from include/exec/helper-proto.h:10:    In fil

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
On Mon, Apr 22, 2024 at 07:22:49PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > New header and source files are added for containing QemuDmaBuf struct > definition and newly introduced helpers for creating/freeing the struct > and accessing its data. > > v10: Change the license ty

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
On Mon, Apr 22, 2024 at 07:22:49PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > New header and source files are added for containing QemuDmaBuf struct > definition and newly introduced helpers for creating/freeing the struct > and accessing its data. > > v10: Change the license ty

hppa-firmware.img missing build-id

2024-04-23 Thread Cole Robinson
Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm builds on Fedora will error if an ELF binary doesn't have build-id: RPM build errors: Missing build-id in /tmp/rpmbuild/BUILDROOT/qemu-9.0.0-1.rc2.fc41.x86_64/usr/share/qemu/hppa-firmware.img

Re: [PATCH v10 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead

2024-04-23 Thread Daniel P . Berrangé
On Mon, Apr 22, 2024 at 07:22:50PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > This commit updates all instances where fields within the QemuDmaBuf > struct are directly accessed, replacing them with calls to these new > helper functions. > > v6: fix typos in helper names in ui/s

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Cole Robinson
On 4/23/24 10:11 AM, Cole Robinson wrote: > Hi, > > hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF > build-id annotations. rpm builds on Fedora will error if an ELF binary > doesn't have build-id: > > RPM build errors: > Missing build-id in > /tmp/rpmbuild/BUILDROOT/qem

[PATCH v8 2/2] Implement SSH commands in QEMU GA for Windows

2024-04-23 Thread aidan_leuck
From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-windows-ssh.c | 712 + qga/commands-windows-ssh.h | 26 ++ qga/meson.build| 5 +- qga/qapi-schema.json | 17 +- 4 files changed, 749 insertions(+), 11 deletions(-) create mode 1006

[PATCH v8 1/2] Refactor common functions between POSIX and Windows implementation

2024-04-23 Thread aidan_leuck
From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-common-ssh.c | 50 +++ qga/commands-common-ssh.h | 10 qga/commands-posix-ssh.c | 47 +--- qga/meson.build | 1 + 4 files changed, 62 insertions(+), 4

[PATCH v8 0/2] Implement SSH commands in QEMU GA for Windows

2024-04-23 Thread aidan_leuck
From: aidaleuc This patch aims to implement guest-ssh-add-authorized-keys, guest-ssh-remove-authorized-keys, and guest-ssh-get-authorized-keys for Windows. This PR is based on Microsoft's OpenSSH implementation https://github.com/PowerShell/Win32-OpenSSH. The guest agents will support Kubevirt

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Richard W.M. Jones
On Tue, Apr 23, 2024 at 10:11:50AM -0400, Cole Robinson wrote: > Hi, > > hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF > build-id annotations. rpm builds on Fedora will error if an ELF binary > doesn't have build-id: > > RPM build errors: > Missing build-id in > /tmp/r

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Helge Deller
On 4/23/24 16:58, Cole Robinson wrote: On 4/23/24 10:11 AM, Cole Robinson wrote: Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm builds on Fedora will error if an ELF binary doesn't have build-id: RPM build errors: Missing build-id in /t

[PULL 00/63] First batch of i386 and build system patch for QEMU 9.1

2024-04-23 Thread Paolo Bonzini
The following changes since commit 62dbe54c24dbf77051bafe1039c31ddc8f37602d: Update version for v9.0.0-rc4 release (2024-04-16 18:06:15 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 254fade7854a6b3d5b7c54a

[PULL 02/63] tests: only build plugins if TCG is enabled

2024-04-23 Thread Paolo Bonzini
There is no way to use them for testing, if all the available accelerators use hardware virtualization. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- te

[PULL 01/63] meson: do not link pixman automatically into all targets

2024-04-23 Thread Paolo Bonzini
The dependency on pixman is listed manually in all sourcesets that need it. There is no need to bring into libqemuutil, since there is nothing in util/ that needs pixman either. Reported-by: Michael Tokarev Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson Message-ID: <20240408155330.

[PULL 10/63] hw/usb: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the USB stubs are needed exactly when the Kconfig symbols are not enabled, they can be placed in hw/usb/ and conditionalized on CONFIG_USB. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-ID: <20240408155330.522792-11-pbonz...@redhat

[PULL 17/63] stubs: include stubs only if needed

2024-04-23 Thread Paolo Bonzini
Currently it is not documented anywhere why some functions need to be stubbed. Group the files in stubs/meson.build according to who needs them, both to reduce the size of the compilation and to clarify the use of stubs. Signed-off-by: Paolo Bonzini Message-ID: <20240408155330.522792-18-pbonz...

[PULL 04/63] tests/unit: match some unit tests to corresponding feature switches

2024-04-23 Thread Paolo Bonzini
Try not to test code that is not used by user mode emulation, or by the block layer, unless they are being compiled; and fix test-timed-average which was not compiled with --disable-system --enable-tools. This is by no means complete, it only touches the more blatantly wrong cases. Signed-off-by:

[PULL 21/63] kvm: use configs/ definition to conditionalize debug support

2024-04-23 Thread Paolo Bonzini
If an architecture adds support for KVM_CAP_SET_GUEST_DEBUG but QEMU does not have the necessary code, QEMU will fail to build after updating kernel headers. Avoid this by using a #define in config-target.h instead of KVM_CAP_SET_GUEST_DEBUG. Signed-off-by: Paolo Bonzini --- configs/targets/aar

[PULL 50/63] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2024-04-23 Thread Paolo Bonzini
From: Chao Peng Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that backend'ed both by hva-based shared memory and guest memfd based private memory. Signed-off-by: Chao Peng Co-developed-by: Xiaoyao Li Signed-off-by

[PULL 30/63] q35: Introduce smm_ranges property for q35-pci-host

2024-04-23 Thread Paolo Bonzini
From: Isaku Yamahata Add a q35 property to check whether or not SMM ranges, e.g. SMRAM, TSEG, etc... exist for the target platform. TDX doesn't support SMM and doesn't play nice with QEMU modifying related guest memory ranges. Signed-off-by: Isaku Yamahata Co-developed-by: Sean Christopherson

[PULL 56/63] kvm/tdx: Don't complain when converting vMMIO region to shared

2024-04-23 Thread Paolo Bonzini
From: Isaku Yamahata Because vMMIO region needs to be shared region, guest TD may explicitly convert such region from private to shared. Don't complain such conversion. Signed-off-by: Isaku Yamahata Signed-off-by: Xiaoyao Li Message-ID: <20240229063726.610065-34-xiaoyao...@intel.com> Signed-o

[PULL 57/63] kvm/tdx: Ignore memory conversion to shared of unassigned region

2024-04-23 Thread Paolo Bonzini
From: Isaku Yamahata TDX requires vMMIO region to be shared. For KVM, MMIO region is the region which kvm memslot isn't assigned to (except in-kernel emulation). qemu has the memory region for vMMIO at each device level. While OVMF issues MapGPA(to-shared) conservatively on 32bit PCI MMIO regio

[PULL 34/63] ppc/pef: switch to use confidential_guest_kvm_init/reset()

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Use the unified interface to call confidential guest related kvm_init() and kvm_reset(), to avoid exposing pef specific functions. As a bonus, pef.h goes away since there is no direct call from sPAPR board code to PEF code anymore. Signed-off-by: Xiaoyao Li Signed-off-by: Paol

[PULL 08/63] hw: Include minimal source set in user emulation build

2024-04-23 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Only the files in hwcore_ss[] are required to link a user emulation binary. Have meson process the hw/ sub-directories if system emulation is selected, otherwise directly process hw/core/ to get hwcore_ss[], which is the only set required by user emulation. This rem

[PULL 51/63] kvm/memory: Make memory type private by default if it has guest memfd backend

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li KVM side leaves the memory to shared by default, which may incur the overhead of paging conversion on the first visit of each page. Because the expectation is that page is likely to private for the VMs that require private memory (has guest memfd). Explicitly set the memory to p

[PULL 53/63] RAMBlock: make guest_memfd require uncoordinated discard

2024-04-23 Thread Paolo Bonzini
Some subsystems like VFIO might disable ram block discard, but guest_memfd uses discard operations to implement conversions between private and shared memory. Because of this, sequences like the following can result in stale IOMMU mappings: 1. allocate shared page 2. convert page shared->private

[PULL 48/63] kvm: Introduce support for memory_attributes

2024-04-23 Thread Paolo Bonzini
From: Xiaoyao Li Introduce the helper functions to set the attributes of a range of memory to private or shared. This is necessary to notify KVM the private/shared attribute of each gpa range. KVM needs the information to decide the GPA needs to be mapped at hva-based shared memory or guest_memf

[PULL 12/63] semihosting: move stubs out of stubs/

2024-04-23 Thread Paolo Bonzini
Since the semihosting stubs are needed exactly when the Kconfig symbols are not needed, move them to semihosting/ and conditionalize them on CONFIG_SEMIHOSTING and/or CONFIG_SYSTEM_ONLY. Signed-off-by: Paolo Bonzini Message-ID: <20240408155330.522792-13-pbonz...@redhat.com> Signed-off-by: Paolo B

[PULL 38/63] linux-headers: update to current kvm/next

2024-04-23 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/standard-headers/asm-x86/bootparam.h | 17 +- include/standard-headers/asm-x86/kvm_para.h | 3 +- include/standard-headers/asm-x86/setup_data.h | 83 +++ include/standard-headers/linux/ethtool.h | 48 ++ include/standard-headers/linux/fuse.h

  1   2   3   >