Re: [PATCH] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-26 Thread Akihiko Odaki
On 2024/03/26 15:51, Jason Wang wrote: On Sun, Mar 24, 2024 at 4:32 PM Akihiko Odaki wrote: It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when checksum offloading is disabled so clear the bit. Set the VIRTIO_NET_HDR_F_DATA_VALID bit instead to tell the checksum is valid. TCP/UDP

[PULL 09/20] qapi: Fix typo in request-ebpf documentation

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-7-arm...@redhat.com> --- qapi/ebpf.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/ebpf.json b/qapi/ebpf.json index f413d00154..61359e1c0f 100644 --- a/qapi/ebpf.json +++ b/qapi/ebpf.json @@ -51,7 +5

[PULL 12/20] qapi: Don't repeat member type in its documentation text

2024-03-26 Thread Markus Armbruster
Documentation generated for the arguments of MEMORY_FAILURE looks like "recipient": "MemoryFailureRecipient" recipient is defined as "MemoryFailureRecipient". "action": "MemoryFailureAction" action that has been taken. action is defined as "MemoryFailureAction".

[PULL 15/20] qga/qapi-schema: Refill doc comments to conform to current conventions

2024-03-26 Thread Markus Armbruster
For legibility, wrap text paragraphs so every line is at most 70 characters long. To check the generated documentation does not change, I compared the generated HTML before and after this commit with "wdiff -3". Finds no differences. Comparing with diff is not useful, as the refilled paragraphs

[PULL 03/20] qapi: Fix bogus documentation of query-migrationthreads

2024-03-26 Thread Markus Armbruster
The doc comment documents an argument that doesn't exist. Would fail compilation if it was marked up correctly. Delete. The Returns: section fails to refer to the data type, leaving the user to guess. Fix that. The command name violates QAPI naming rules: it should be query-migration-threads.

[PULL 11/20] qapi: Start sentences with a capital letter, end them with a period

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-9-arm...@redhat.com> --- qapi/migration.json | 16 qapi/ui.json| 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index a4319f87bf..8fa1b7f8e

[PULL 06/20] qapi: Tidy up block-latency-histogram-set documentation some more

2024-03-26 Thread Markus Armbruster
Commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions) reflowed some text that should have been left alone. Revert that. Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-4-arm...@redhat.com> --- qapi/block.json | 10 +- 1 file changed, 5 ins

[PULL 04/20] qapi: Drop stray Arguments: line from qmp_capabilities docs

2024-03-26 Thread Markus Armbruster
Reported-by: John Snow Fixes: 119ebac1feb2 (qapi-schema: use generated marshaller for 'qmp_capabilities') Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-2-arm...@redhat.com> Reviewed-by: John Snow --- qapi/control.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/q

[PULL 08/20] qapi: Fix argument markup in drive-mirror documentation

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-6-arm...@redhat.com> --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 1874f880a8..64668b080d 100644 --- a/qapi/block-core.json +++ b/qa

[PULL 18/20] qapi: document leftover members in qapi/stats.json

2024-03-26 Thread Markus Armbruster
From: Paolo Bonzini Suggested-by: Markus Armbruster Signed-off-by: Paolo Bonzini Message-ID: <20240325104504.1358734-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json | 5 + qapi/stats.json | 14 +++

[PULL 07/20] qapi: Tidy up indentation of add_client's example

2024-03-26 Thread Markus Armbruster
Commit d23055b8db8 (qapi: Require descriptions and tagged sections to be indented) indented add_client's example too much. Revert that. Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-5-arm...@redhat.com> [Move a stray hunk to the later patch it belongs to] --- qapi/misc.jso

[PULL 05/20] qapi: Expand a few awkward abbreviations in documentation

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-3-arm...@redhat.com> --- qapi/replay.json | 4 ++-- qapi/virtio.json | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/qapi/replay.json b/qapi/replay.json index 8626fb58f4..d3559f9c8f 100644 --- a/qapi/

[PULL 13/20] qapi: Refill doc comments to conform to current conventions

2024-03-26 Thread Markus Armbruster
For legibility, wrap text paragraphs so every line is at most 70 characters long. To check the generated documentation does not change, I compared the generated HTML before and after this commit with "wdiff -3". Finds no differences. Comparing with diff is not useful, as the refilled paragraphs

[PULL 02/20] qapi: Resync MigrationParameter and MigrateSetParameters

2024-03-26 Thread Markus Armbruster
Enum MigrationParameter mirrors the members of struct MigrateSetParameters. Differences to MigrateSetParameters's member documentation are pointless. Clean them up: * @compress-level, @compress-threads, @decompress-threads, and x-checkpoint-delay are more thoroughly documented for MigrationP

[PULL 14/20] qapi: Correct documentation indentation and whitespace

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-12-arm...@redhat.com> [Add a previous patch's stray hunk] --- qapi/block-core.json | 20 ++-- qapi/crypto.json | 12 ++-- qapi/dump.json | 2 +- qapi/machine.json| 3 +-- qapi/migration.jso

[PULL 17/20] qapi: document leftover members in qapi/run-state.json

2024-03-26 Thread Markus Armbruster
From: Paolo Bonzini Suggested-by: Markus Armbruster Signed-off-by: Paolo Bonzini Message-ID: <20240325104502.1358693-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Capitalize "ID", update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json| 4 +--- qapi/run-s

[PULL 10/20] qapi: Fix abbreviation punctuation in doc comments

2024-03-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-ID: <20240322140910.328840-8-arm...@redhat.com> --- qapi/migration.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index c865ab00c8..a4319f87bf 100644 --- a/qapi/migration.json +++ b/qa

[PULL 00/20] QAPI patches patches for 2024-03-26

2024-03-26 Thread Markus Armbruster
This pull request does not touch code, only QAPI schema documentation comments and error-suppressing QAPI schema pragma documentation-exceptions. The following changes since commit 6a4180af9686830d88c387baab6d79563ce42a15: Merge tag 'pull-request-2024-03-25' of https://gitlab.com/thuth/qemu int

[PULL 01/20] qapi: Improve migration TLS documentation

2024-03-26 Thread Markus Armbruster
MigrateSetParameters is about setting parameters, and MigrationParameters is about querying them. Their documentation of @tls-creds and @tls-hostname has residual damage from a failed attempt at de-duplicating them (see commit de63ab61241 "migrate: Share common MigrationParameters struct" and comm

[PULL 16/20] qapi: document InputMultiTouchType

2024-03-26 Thread Markus Armbruster
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-ID: <20240325095648.2835381-1-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster [Update qapi/pragma.json] Signed-off-by: Markus Armbruster --- qapi/pragma.json | 2 -- qapi/ui.json | 12 2 files chang

[PULL 19/20] qapi/block-core: improve Qcow2OverlapCheckFlags documentation

2024-03-26 Thread Markus Armbruster
From: Vladimir Sementsov-Ogievskiy Most of fields have no description at all. Let's fix that. Still, no reason to place here more detailed descriptions of what these structures are, as we have public Qcow2 format specification. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-ID: <2024032512

[PULL 20/20] qapi: document parameters of query-cpu-model-* QAPI commands

2024-03-26 Thread Markus Armbruster
From: David Hildenbrand Let's document the parameters of these commands, so we can remove them from the "documentation-exceptions" list. While at it, extend the "Returns:" documentation as well, fixing a wrong use of CpuModelBaselineInfo vs. CpuModelCompareInfo for query-cpu-model-comparison. C

Re: Let's close member documentation gaps

2024-03-26 Thread Markus Armbruster
Markus Armbruster writes: > If you're cc'ed, I have a bit of doc work for you. Search for your > name to find it. > > The QAPI generator forces you to document your stuff. Except for > commands, events, enum and object types listed in pragma > documentation-exceptions, the generator silently de

Re: [PATCH 25/26] kvm: handle KVM_EXIT_MEMORY_FAULT

2024-03-26 Thread Xiaoyao Li
On 3/23/2024 2:11 AM, Paolo Bonzini wrote: From: Chao Peng When geeting KVM_EXIT_MEMORY_FAULT exit, it indicates userspace needs to typo: /s/geeting/getting do the memory conversion on the RAMBlock to turn the memory into desired attribute, i.e., private/shared. Currently only KVM_MEMORY_E

Re: [PATCH v6 10/11] virtio-gpu: Initialize Venus

2024-03-26 Thread Pierre-Eric Pelloux-Prayer
Le 23/02/2024 à 10:15, Huang Rui a écrit : On Tue, Jan 02, 2024 at 09:33:11PM +0800, Marc-André Lureau wrote: Hi On Tue, Dec 19, 2023 at 11:55 AM Huang Rui wrote: From: Antonio Caggiano Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --

Re: [PATCH 21/26] kvm/memory: Make memory type private by default if it has guest memfd backend

2024-03-26 Thread Xiaoyao Li
On 3/23/2024 2:11 AM, Paolo Bonzini wrote: From: Xiaoyao Li KVM side leaves the memory to shared by default, while may incur the /s/while/which/ fix typo from myself. overhead of paging conversion on the first visit of each page. Because the expectation is that page is likely to private fo

Re: [PATCH 1/2] copy-before-write: allow specifying minimum cluster size

2024-03-26 Thread Markus Armbruster
Fiona Ebner writes: > Useful to make discard-source work in the context of backup fleecing > when the fleecing image has a larger granularity than the backup > target. > > Copy-before-write operations will use at least this granularity and in > particular, discard requests to the source node will

Re: [PATCH 1/3] target/hppa: Squash d for pa1.x during decode

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: The cond_need_ext predicate was created while we still had a 32-bit compilation mode. It now makes more sense to treat D as an absolute indicator of a 64-bit operation. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Del

Re: [PATCH 2/3] target/hppa: Replace c with uv in do_cond

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: Prepare for proper indication of shladd unsigned overflow. The UV indicator will be zero/not-zero instead of a single bit. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Helge --- target/hppa/translate.c |

Re: [PATCH v2] target/riscv/kvm/kvm-cpu.c: kvm_riscv_handle_sbi() fail with vendor-specific SBI

2024-03-26 Thread Andrew Jones
On Mon, Mar 25, 2024 at 04:01:16PM +0300, Alexei Filippov wrote: > kvm_riscv_handle_sbi() may return not supported return code to not trigger > qemu abort with vendor-specific sbi. > > Added SBI related return code's defines. > > Signed-off-by: Alexei Filippov > Fixes: 4eb47125 ("target/riscv: H

Re: [PATCH 3/3] target/hppa: Fix overflow computation for shladd

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: Overflow indicator should include the effect of the shift step. We had previously left ??? comments about the issue. Signed-off-by: Richard Henderson Tested-by: Helge Deller Helge --- target/hppa/translate.c | 85 ++

Re: [PULL 00/15] riscv-to-apply queue

2024-03-26 Thread Michael Tokarev
On 24.03.2024 21:12, Daniel Henrique Barboza wrote: On 3/24/24 12:07, Michael Tokarev wrote: Unfortunately this doesn't quite work, the following changes fail to apply to 8.2: 929e521a47 target/riscv: always clear vstart for ldst_whole insns b46631f122 target/riscv: remove 'over' brconds from

Re: [PATCH for-9.0 0/3] target/hppa: Fix overflow computation for shladd

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: These ??? notes have been there since day one. This fixes l2diag test 59. Your patches fix the 64-bit wdiag test 66 (shladd) too. I tested 32/64-bit Linux & 32-bit HP-UX. No regressions. Helge Richard Henderson (3): target/hppa: Squash d for pa

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 04:33, Pierrick Bouvier wrote: On 3/26/24 05:52, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70.     Use g_pattern_spec_match_string() instead to avoid this problem. 2. The type of second parameter in g_ptr_array_add() is     'gpointer' {a

Re: [PATCH] misc/pca955*: Move models under hw/gpio

2024-03-26 Thread Philippe Mathieu-Daudé
On 25/3/24 14:48, Cédric Le Goater wrote: The PCA9552 and PCA9554 devices are both I2C GPIO controllers and the PCA9552 also can drive LEDs. Do all the necessary adjustments to move the models under hw/gpio. Cc: Glenn Miles Signed-off-by: Cédric Le Goater --- MAINTAINERS

Re: [PATCH] docs/system/ppc/amigang.rst: Fix formatting

2024-03-26 Thread Philippe Mathieu-Daudé
On 24/3/24 17:11, BALATON Zoltan wrote: Add missing space to fix character formatting where it was missed in two places. Fixes: 623d9065b6 (docs/system/ppc: Document running Linux on AmigaNG machines) Signed-off-by: BALATON Zoltan --- docs/system/ppc/amigang.rst | 4 ++-- 1 file changed, 2 i

Re: [PATCH v2 0/3] Fixes for "ui/cocoa: Let the platform toggle fullscreen"

2024-03-26 Thread Philippe Mathieu-Daudé
On 23/3/24 07:20, Akihiko Odaki wrote: This series contains patches for regressions caused by commit 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen"). --- Akihiko Odaki (3): ui/cocoa: Fix aspect ratio ui/cocoa: Resize window after toggling zoom-to-fit ui/coco

Re: [PULL 00/15] riscv-to-apply queue

2024-03-26 Thread Alistair Francis
On Tue, Mar 26, 2024 at 7:53 PM Michael Tokarev wrote: > > On 24.03.2024 21:12, Daniel Henrique Barboza wrote: > > On 3/24/24 12:07, Michael Tokarev wrote: > > >> Unfortunately this doesn't quite work, the following changes > >> fail to apply to 8.2: > >> > >> 929e521a47 target/riscv: always clear

Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()

2024-03-26 Thread Philippe Mathieu-Daudé
On 19/3/24 06:14, Philippe Mathieu-Daudé wrote: 'address' got converted from target_ulong to vaddr in commit 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill"). Use the corresponding format string to avoid casting. Signed-off-by: Philippe Mathieu-Daudé --- target/tricore/helper.c |

Re: [PATCH] monitor/hmp-cmds-target.c: append a space in error message in gpa2hva()

2024-03-26 Thread Philippe Mathieu-Daudé
On 19/3/24 03:16, Shiyang Ruan via wrote: From: Yao Xingtao In qemu monitor mode, when we use gpa2hva command to print the host virtual address corresponding to a guest physical address, if the gpa is not in RAM, the error message is below: (qemu) gpa2hva 0x75000 Memory at address 0x75

[PATCH 1/1] docs: sbsa: update specs, add dt note

2024-03-26 Thread Marcin Juszkiewicz
Hardware of sbsa-ref board is nowadays defined by both BSA and SBSA specifications. Then BBR defines firmware interface. Added note about DeviceTree data passed from QEMU to firmware. It is very minimal and provides only data we use in firmware. Added NUMA information to list of things reported b

Re: [PATCH] scsi-generic: fix io_timeout property not applying

2024-03-26 Thread Philippe Mathieu-Daudé
On 15/3/24 15:58, Lorenz Brun wrote: The io_timeout property, introduced in c9b6609 (part of 6.0) is silently overwritten by the hardcoded default value of 30 seconds (DEFAULT_IO_TIMEOUT) in scsi_generic_realize because that function is being called after the properties have already been applied.

[PATCH 0/2] virtio-net: Fix RSS

2024-03-26 Thread Akihiko Odaki
Some recent changes made RSS unfunctional so here are fixes. Signed-off-by: Akihiko Odaki --- Akihiko Odaki (2): virtio-net: Fix vhost virtqueue notifiers for RSS ebpf: Fix indirections table setting ebpf/ebpf_rss.h | 2 +- ebpf/ebpf_rss.c | 5 +++-- hw/net/virtio-net.c | 4

[PATCH 2/2] ebpf: Fix indirections table setting

2024-03-26 Thread Akihiko Odaki
The kernel documentation says: > The value stored can be of any size, however, all array elements are > aligned to 8 bytes. https://www.kernel.org/doc/html/v6.8/bpf/map_array.html Fixes: 333b3e5fab75 ("ebpf: Added eBPF map update through mmap.") Signed-off-by: Akihiko Odaki --- ebpf/ebpf_rss.h |

[PATCH 1/2] virtio-net: Fix vhost virtqueue notifiers for RSS

2024-03-26 Thread Akihiko Odaki
virtio_net_guest_notifier_pending() and virtio_net_guest_notifier_mask() checked VIRTIO_NET_F_MQ to know there are multiple queues, but VIRTIO_NET_F_RSS also enables multiple queues. Refer to n->multiqueue, which is set to true either of VIRTIO_NET_F_MQ or VIRTIO_NET_F_RSS is enabled. Fixes: 68b0a

Re: [RFC v2 0/5] ARM Nested Virt Support

2024-03-26 Thread Eric Auger
Hi Peter, On 3/5/24 17:57, Peter Maydell wrote: > On Fri, 9 Feb 2024 at 16:00, Eric Auger wrote: >> This series adds ARM Nested Virtualization support in KVM mode. >> This is a respin of previous contributions from Miguel [1] and Haibo [2]. >> >> This was tested with Marc's v11 [3] on Ampere HW w

Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1

2024-03-26 Thread Harsh Prateek Bora
On 3/25/24 19:44, Paolo Bonzini wrote: Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. Cc: Cornelia Huck Cc: Thomas Huth Cc: Harsh Prateek Bora Cc: Gavin Shan Signed-off-by: Paolo Bonzini --- include/hw/boards.h| 3 +++ include/hw/i386/pc.h | 3 +++ hw/arm/

Re: [PATCH] misc/pca955*: Move models under hw/gpio

2024-03-26 Thread Cédric Le Goater
On 3/26/24 10:55, Philippe Mathieu-Daudé wrote: On 25/3/24 14:48, Cédric Le Goater wrote: The PCA9552 and PCA9554 devices are both I2C GPIO controllers and the PCA9552 also can drive LEDs. Do all the necessary adjustments to move the models under hw/gpio. Cc: Glenn Miles Signed-off-by: Cédric

Re: [RFC PATCH-for-9.1 00/21] qapi: Make @query-cpu-definitions command target-agnostic

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Alex, Markus, > > Markus mentioned QAPI problems with the heterogeneous emulation > binary. My understanding is, while QAPI can use host-specific > conditional (OS, library available, configure option), it > shouldn't use target-specific ones. "Shouldn't" is t

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Peter Maydell
On Tue, 26 Mar 2024 at 09:54, Philippe Mathieu-Daudé wrote: > > On 26/3/24 04:33, Pierrick Bouvier wrote: > > On 3/26/24 05:52, Yao Xingtao wrote: > >> 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. > >> Use g_pattern_spec_match_string() instead to avoid this problem

Re: [PATCH-for-9.1 06/21] target/i386: Make X86_CPU common to new I386_CPU / X86_64_CPU types

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > "target/foo/cpu-qom.h" can not use any target specific definitions. > > Currently "target/i386/cpu-qom.h" defines TYPE_X86_CPU depending > on the i386/x86_64 build type. This doesn't scale in a heterogeneous > context where we need to access both types concurrentl

Question about block graph lock limitation with generated co-wrappers

2024-03-26 Thread Fiona Ebner
Hi, we have a custom block driver downstream, which currently calls bdrv_get_info() (for its file child) in the bdrv_refresh_limits() callback. However, with graph locking, this doesn't work anymore. AFAICT, the reason is the following: The block driver has a backing file option. During initializa

Re: [RFC v2 2/5] hw/arm: Allow setting KVM vGIC maintenance IRQ

2024-03-26 Thread Eric Auger
Hi Peter, On 3/5/24 17:46, Peter Maydell wrote: > On Fri, 9 Feb 2024 at 16:00, Eric Auger wrote: >> From: Haibo Xu >> >> Allow virt arm machine to set the intid for the KVM GIC maintenance >> interrupt. >> >> Signed-off-by: Haibo Xu >> Signed-off-by: Miguel Luis >> Signed-off-by: Eric Auger >

Re: [PATCH v1] coroutine: avoid inserting duplicate coroutine to co_queue_wakeup

2024-03-26 Thread zhuyangyang via
On Mon, 25 Mar 2024 11:50:41 -0400, Stefan Hajnoczi wrote: > On Mon, Mar 25, 2024 at 05:18:50PM +0800, zhuyangyang wrote: > > If g_main_loop_run()/aio_poll() is called in the coroutine context, > > the pending coroutine may be woken up repeatedly, and the co_queue_wakeup > > may be disordered. > >

Re: [PATCH] virt: set the CPU type in BOOTINFO

2024-03-26 Thread Philippe Mathieu-Daudé
On 23/2/24 16:57, Laurent Vivier wrote: BI_CPUTYPE/BI_MMUTYPE/BI_FPUTYPE were statically assigned to the 68040 information. This patch changes the code to set in bootinfo the information provided by the command line '-cpu' parameter. Bug: https://gitlab.com/qemu-project/qemu/-/issues/2091 Report

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 11:33, Peter Maydell wrote: On Tue, 26 Mar 2024 at 09:54, Philippe Mathieu-Daudé wrote: On 26/3/24 04:33, Pierrick Bouvier wrote: On 3/26/24 05:52, Yao Xingtao wrote: 1. The g_pattern_match_string() is deprecated when glib2 version >= 2.70. Use g_pattern_spec_match_string() i

Re: [PATCH] misc/pca955*: Move models under hw/gpio

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 11:16, Cédric Le Goater wrote: On 3/26/24 10:55, Philippe Mathieu-Daudé wrote: On 25/3/24 14:48, Cédric Le Goater wrote: The PCA9552 and PCA9554 devices are both I2C GPIO controllers and the PCA9552 also can drive LEDs. Do all the necessary adjustments to move the models under hw/gpi

Re: [PULL 00/15] riscv-to-apply queue

2024-03-26 Thread Daniel Henrique Barboza
On 3/26/24 06:56, Alistair Francis wrote: On Tue, Mar 26, 2024 at 7:53 PM Michael Tokarev wrote: On 24.03.2024 21:12, Daniel Henrique Barboza wrote: On 3/24/24 12:07, Michael Tokarev wrote: Unfortunately this doesn't quite work, the following changes fail to apply to 8.2: 929e521a47 ta

Re: [PATCH] tests/qemu-iotests: Test 157 and 227 require virtio-blk

2024-03-26 Thread Kevin Wolf
Am 25.03.2024 um 16:47 hat Thomas Huth geschrieben: > Tests 157 and 227 use the virtio-blk device, so we have to mark these > tests accordingly to be skipped if this devices is not available (e.g. > when running the tests with qemu-system-avr only). > > Signed-off-by: Thomas Huth Thanks, applied

Re: [PATCH-for-9.1 09/21] qapi: Merge machine-common.json with qapi/machine.json

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > machine-common.json declares a single type, which isn't > restricted to a particular target. Move this type in > machine.json. > > Signed-off-by: Philippe Mathieu-Daudé Previous discussion at https://lore.kernel.org/qemu-devel/875y45kt8i@pond.sub.org/ CpuS3

Re: [PATCH-for-9.1 10/21] qapi: Make CpuModel* definitions target agnostic

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > CpuModelInfo, CpuModelExpansionType and CpuModelCompareResult > are not restricted to any particular target. Define them in > machine.json to generate them once. > > Signed-off-by: Philippe Mathieu-Daudé Well, the stuff in machine-target.json is generated once j

Re: [PATCH-for-9.1 06/21] target/i386: Make X86_CPU common to new I386_CPU / X86_64_CPU types

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 11:57, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: "target/foo/cpu-qom.h" can not use any target specific definitions. Currently "target/i386/cpu-qom.h" defines TYPE_X86_CPU depending on the i386/x86_64 build type. This doesn't scale in a heterogeneous context where we

Re: [PATCH v1] coroutine: avoid inserting duplicate coroutine to co_queue_wakeup

2024-03-26 Thread zhuyangyang via
On Mon, 25 Mar 2024 11:00:31 -0500 Eric Blake wrote: > > util/async.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/util/async.c b/util/async.c > > index 0467890052..25fc1e6083 100644 > > --- a/util/async.c > > +++ b/util/async.c > > @@ -705,7 +705,1

[PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy()

2024-03-26 Thread Igor Mammedov
QEMU build fails with hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch +++ b/configs/devices/i386-softmmu/default.mak @@ -26,7 +26,7 @@ # Boards: # -CONFIG_ISAPC=y -CONFIG_I440FX=y -CONFI

Re: [PATCH v3 7/8] plugins: distinct types for callbacks

2024-03-26 Thread Pierrick Bouvier
On 3/25/24 23:23, Richard Henderson wrote: On 3/25/24 02:41, Pierrick Bouvier wrote: To prevent errors when writing new types of callbacks or inline operations, we split callbacks data to distinct types. Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 46 ++-

Re: [PATCH trivial for-9.0] hw/i386/fw_cfg.c: fix non-legacy smbios build

2024-03-26 Thread Igor Mammedov
On Mon, 25 Mar 2024 21:01:42 +0300 Michael Tokarev wrote: > 25.03.2024 18:20, Igor Mammedov wrote > > On Mon, 25 Mar 2024 16:09:20 +0300 > > Michael Tokarev wrote: > > > >> When building qemu with smbios but not legacy mode (eg minimal microvm > >> build), > >> link fails with: > >> > >>

[PATCH for 9.1 v2 2/2] meson: Fix MESONINTROSPECT parsing

2024-03-26 Thread Akihiko Odaki
The arguments in MESONINTROSPECT are quoted with shlex.quote() so it must be parsed with shlex.split(). Fixes: cf60ccc330 ("cutils: Introduce bundle mechanism") Reported-by: Michael Tokarev Reviewed-by: Michael Tokarev Tested-by: Michael Tokarev Reviewed-by: Philippe Mathieu-Daudé Signed-off-b

[PATCH v4 0/9] TCG plugins new inline operations

2024-03-26 Thread Pierrick Bouvier
This series implement two new operations for plugins: - Store inline allows to write a specific value to a scoreboard. - Conditional callback executes a callback only when a given condition is true. The condition is evaluated inline. It's possible to mix various inline operations (add, store) wi

[PATCH for 9.1 v2 1/2] buildsys: Bump known good meson version to v1.4.0

2024-03-26 Thread Akihiko Odaki
We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: https://github.com/mesonbuild/meson/pull/12807 Signed-off-by: Akihiko Odaki --- python/scripts/vendor.py | 4 ++-- python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes python/wheels/meson-1.4.0-py3

[PATCH v4 2/9] plugins: extract generate ptr for qemu_plugin_u64

2024-03-26 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 41d4d83f547..d3667203546 100644 --- a/accel/tcg/plugin-

[PATCH v4 3/9] plugins: add new inline op STORE_U64

2024-03-26 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 1 + include/qemu/qemu-plugin.h | 4 ++-- accel/tcg/plugin-gen.c | 13 + plugins/core.c | 6 ++ 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/inclu

[PATCH v4 4/9] tests/plugin/inline: add test for STORE_U64 inline op

2024-03-26 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- tests/plugin/inline.c | 41 + 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/tests/plugin/inline.c b/tests/plugin/inline.c index 0163e9b51c5..103c3a22f6e 100644 --- a/tests/

[PATCH v4 9/9] plugins: remove op from qemu_plugin_inline_cb

2024-03-26 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 1 - plugins/plugin.h | 4 +++- plugins/core.c| 13 +++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index a078229942f..7f7b915e495 100644 --- a/in

[PATCH v4 1/9] plugins: prepare introduction of new inline ops

2024-03-26 Thread Pierrick Bouvier
Until now, only add_u64 was available, and all functions assumed this or were named uniquely. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/qemu/plugin.h | 2 +- accel/tcg/plugin-gen.c | 6 +++--- plugins/core.c | 14 -- 3 files changed, 16 in

[PATCH for 9.1 v2 0/2] meson: Fix MESONINTROSPECT parsing

2024-03-26 Thread Akihiko Odaki
scripts/symlink-install-tree.py| 3 ++- 5 files changed, 5 insertions(+), 4 deletions(-) --- base-commit: ba49d760eb04630e7b15f423ebecf6c871b8f77b change-id: 20240326-meson-b5e2c7a2fb2f Best regards, -- Akihiko Odaki

[PATCH v4 8/9] plugins: extract cpu_index generate

2024-03-26 Thread Pierrick Bouvier
Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- accel/tcg/plugin-gen.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index d00a2b3fd67..eaa0160cab1 100644 --- a/accel/tcg/plugi

[PATCH v4 6/9] tests/plugin/inline: add test for conditional callback

2024-03-26 Thread Pierrick Bouvier
Count number of tb and insn executed using a conditional callback. We ensure the callback has been called expected number of time (per vcpu). Signed-off-by: Pierrick Bouvier --- tests/plugin/inline.c | 89 +-- 1 file changed, 86 insertions(+), 3 deletions(

Re: [PATCH v3] contrib/plugins/execlog: Fix compiler warning

2024-03-26 Thread Pierrick Bouvier
On 3/26/24 13:54, Philippe Mathieu-Daudé wrote: I will post a small PR later today, so until Peter has something else planned, I can take it, since the patch LGTM now. Thanks Philippe :)

Re: [PATCH for 9.1 v2 1/2] buildsys: Bump known good meson version to v1.4.0

2024-03-26 Thread Peter Maydell
On Tue, 26 Mar 2024 at 12:35, Akihiko Odaki wrote: > > We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: > https://github.com/mesonbuild/meson/pull/12807 > > Signed-off-by: Akihiko Odaki > --- > python/scripts/vendor.py | 4 ++-- > python/wheels/meson-1.2.3-py3-

Re: [PULL 00/20] QAPI patches patches for 2024-03-26

2024-03-26 Thread Peter Maydell
On Tue, 26 Mar 2024 at 07:34, Markus Armbruster wrote: > > This pull request does not touch code, only QAPI schema documentation > comments and error-suppressing QAPI schema pragma > documentation-exceptions. > > The following changes since commit 6a4180af9686830d88c387baab6d79563ce42a15: > > Me

Re: [PATCH v3 2/4] block-backend: fix edge case in bdrv_next() where BDS associated to BB changes

2024-03-26 Thread Kevin Wolf
Am 22.03.2024 um 10:50 hat Fiona Ebner geschrieben: > The old_bs variable in bdrv_next() is currently determined by looking > at the old block backend. However, if the block graph changes before > the next bdrv_next() call, it might be that the associated BDS is not > the same that was referenced p

Re: [PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy()

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 13:26, Igor Mammedov wrote: QEMU build fails with hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch +++ b/configs/devices/i386-softmmu/default.mak @@ -26,7 +26,7 @@ # Boards: #

Re: [PATCH for 9.1 v2 1/2] buildsys: Bump known good meson version to v1.4.0

2024-03-26 Thread Akihiko Odaki
On 2024/03/26 21:40, Peter Maydell wrote: On Tue, 26 Mar 2024 at 12:35, Akihiko Odaki wrote: We need meson v1.4.0 to fix MESONINTROSPECT quoting on Windows: https://github.com/mesonbuild/meson/pull/12807 Signed-off-by: Akihiko Odaki --- python/scripts/vendor.py | 4 ++--

[PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Igor Mammedov
ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 host in only TCG mode, while in KVM mode it hung in the middle of boot) Rathe

Re: [PATCH v3 0/4] fix two edge cases related to stream block jobs

2024-03-26 Thread Kevin Wolf
Am 25.03.2024 um 21:11 hat Stefan Hajnoczi geschrieben: > On Fri, Mar 22, 2024 at 10:50:05AM +0100, Fiona Ebner wrote: > > Changes in v3: > > * Also deal with edge case in bdrv_next_cleanup(). Haven't run > > into an actual issue there, but at least the caller in > > migration/block

Re: [RFC PATCH-for-9.1 14/21] system: Introduce QMP generic_query_cpu_definitions()

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Each target use a common template for qmp_query_cpu_definitions(). > > Extract it as generic_query_cpu_definitions(), keeping the > target-specific implementations as the following SysemuCPUOps > handlers: > - cpu_list_compare() > - add_definition() > - add_ali

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Ani Sinha
> On 26 Mar 2024, at 18:21, Igor Mammedov wrote: > > ISAPC machine was introduced 25 years ago and it's a lot of time since > such machine was around with real ISA only PC hardware practically defunct. > Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 host > in only T

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Thomas Huth
s/iaspc/isapc/ in the subject On 26/03/2024 13.51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 h

Re: [PATCH trivial for-9.0] smbios: add stub for smbios_get_table_legacy()

2024-03-26 Thread Philippe Mathieu-Daudé
On 26/3/24 13:44, Philippe Mathieu-Daudé wrote: On 26/3/24 13:26, Igor Mammedov wrote: QEMU build fails with    hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch     +++ b/configs/devices/i386-softmmu/default.

[PATCH-for-9.1] hw/i386: Add a config to only build the microvm machine

2024-03-26 Thread Philippe Mathieu-Daudé
Add a config file to build a binary only containing the microvm machine, inspired by a discussion on the list: https://lore.kernel.org/qemu-devel/604bf457-23a7-4d06-b59f-a7b46945c...@tls.msk.ru/ As suggested in commit d1d5e9eefd ("configure: allow the selection of alternate config in the build"),

Re: [PATCH-for-9.0 v3 0/3] hw/clock: Propagate clock changes when STM32L4X5 MUX is updated

2024-03-26 Thread Philippe Mathieu-Daudé
On 25/3/24 16:28, Philippe Mathieu-Daudé wrote: Per https://www.qemu.org/docs/master/devel/clocks.html#clock-multiplier-and-divider-settings: Note that clock_set_mul_div() does not automatically call clock_propagate(). If you make a runtime change to the multiplier or divider you must

Re: [PATCH v3 0/1] target/i386: Fix page walking from MMIO memory.

2024-03-26 Thread Philippe Mathieu-Daudé
On 7/3/24 16:53, Jonathan Cameron via wrote: Previously: tcg/i386: Page tables in MMIO memory fixes (CXL) Richard Henderson picked up patches 1 and 3 which were architecture independent leaving just this x86 specific patch. No change to the patch. Resending because it's hard to spot individual u

[PATCH for-9.0 0/3] qtest/virtio-9p-test.c: fix slow tests

2024-03-26 Thread Daniel Henrique Barboza
Hi, Thomas reported in [1] a problem that happened with the RISC-V machine where some tests from virtio-9p-test.c were failing with '-m slow', i.e. enabling slow tests. In the end it wasn't a RISC-V specific problem. It just so happens that the recently added riscv machine nodes runs the tests fr

[PATCH for-9.0 3/3] qtest/virtio-9p-test.c: remove g_test_slow() gate

2024-03-26 Thread Daniel Henrique Barboza
Commit 558f5c42ef gated the local tests with g_test_slow() to skip them in 'make check'. The reported issue back then was this following CI problem: https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html This problem ended up being fixed when the recently added risc-v machine node

[PATCH for-9.0 1/3] qtest/virtio-9p-test.c: consolidate create dir, file and symlink tests

2024-03-26 Thread Daniel Henrique Barboza
The local 9p driver in virtio-9p-test.c its temporary dir right at the start of qos-test (via virtio_9p_create_local_test_dir()) and only deletes it after qos-test is finished (via virtio_9p_remove_local_test_dir()). This means that any qos-test machine that ends up running virtio-9p-test local te

[PATCH for-9.0 2/3] qtest/virtio-9p-test.c: consolidate hardlink tests

2024-03-26 Thread Daniel Henrique Barboza
We need all virtio-9p-test.c tests to clean themselves up after being executed to avoid an issue where multiple test runs of this same test will find remains of the previous run. See [1] to see the side effects of that. Previous patch dealt with most tests in this file. We're now consolidating the

Re: [RFC PATCH-for-9.1 14/21] system: Introduce QMP generic_query_cpu_definitions()

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Each target use a common template for qmp_query_cpu_definitions(). > > Extract it as generic_query_cpu_definitions(), keeping the > target-specific implementations as the following SysemuCPUOps > handlers: > - cpu_list_compare() > - add_definition() > - add_ali

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Philippe Mathieu-Daudé
Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s/iaspc/isapc/ in the subject On 26/03/2024 13.51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-26 Thread Mark Cave-Ayland
On 26/03/2024 12:51, Igor Mammedov wrote: ISAPC machine was introduced 25 years ago and it's a lot of time since such machine was around with real ISA only PC hardware practically defunct. Also it's slowly bit-rots (for example: I was able to boot RHEL6 on RHEL9 host in only TCG mode, while in K

Re: [RFC PATCH-for-9.1 21/21] qapi: Make @query-cpu-definitions target-agnostic

2024-03-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > All targets use the generic_query_cpu_definitions() method, > which is not target-specific. Make the command target agnostic > by moving it to machine.json. Rename generic_query_cpu_definitions > as qmp_query_cpu_definitions. > > This is an introspection change fo

  1   2   3   >