Re: [PATCH 7/8] tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy

2024-03-01 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu Currently, -smp supports up to 7-levels topology hierarchy: -drawers/books/sockets/dies/clusters/cores/threads. Though no machine supports all these 7 levels yet, these 7 levels have the strict containment relationship and together form th

Re: [PATCH 8/8] tests/unit/test-smp-parse.c: Test smp_props.has_clusters

2024-03-01 Thread Thomas Huth
On 18/01/2024 15.48, Zhao Liu wrote: From: Zhao Liu The smp_props.has_clusters in MachineClass is not a user configured field, and it indicates if user specifies "clusters" in -smp. After -smp parsing, other module could aware if the cluster level is configured by user. This is used when the m

[PULL 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup()

2024-03-01 Thread Thomas Huth
From: Daniel Henrique Barboza The loop isn't setting the values for the last element. Every other element is being initialized with addr = 0, flags = VRING_DESC_F_NEXT and next = i + 1. The last elem is never touched. This became a problem when enabling a RISC-V 'virt' libqos machine in the 'ind

[PULL 2/6] libqos/virtio.c: fix 'avail_event' offset in qvring_init()

2024-03-01 Thread Thomas Huth
From: Daniel Henrique Barboza In qvring_init() we're writing vq->used->avail_event at "vq->used + 2 + array_size". The struct pointed by vq->used is, from virtio_ring.h Linux header): * // A ring of used descriptor heads with free-running index. * __virtio16 used_flags; * __vi

[PULL 6/6] chardev/char-socket: Fix TLS io channels sending too much data to the backend

2024-03-01 Thread Thomas Huth
Commit ffda5db65a ("io/channel-tls: fix handling of bigger read buffers") changed the behavior of the TLS io channels to schedule a second reading attempt if there is still incoming data pending. This caused a regression with backends like the sclpconsole that check in their read function that the

[PULL 0/6] Misc fixes (libqos vring, Kconfig, TLS io channels, ...)

2024-03-01 Thread Thomas Huth
Hi Peter! The following changes since commit c0c6a0e3528b88aaad0b9d333e295707a195587b: Merge tag 'migration-next-pull-request' of https://gitlab.com/peterx/qemu into staging (2024-02-28 17:27:10 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-req

[PULL 5/6] tests/unit/test-util-sockets: Remove temporary file after test

2024-03-01 Thread Thomas Huth
test-util-sockets leaves the temporary socket files around in the temporary files folder. Let's better remove them at the end of the testing. Fixes: 4d3a329af5 ("tests/util-sockets: add abstract unix socket cases") Message-ID: <20240226082728.249753-1-th...@redhat.com> Reviewed-by: Marc-André Lure

[PULL 3/6] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

2024-03-01 Thread Thomas Huth
When using "--without-default-devices", the ARM_GICV3_TCG and ARM_GIC_KVM settings currently get disabled, though the arm virt machine is only of very limited use in that case. This also causes the migration-test to fail in such builds. Let's make sure that we always keep the GIC switches enabled i

[PULL 4/6] hw/usb/bus.c: PCAP adding 0xA in Windows version

2024-03-01 Thread Thomas Huth
From: Benjamin David Lunt Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show an example, when using

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Daniel P . Berrangé
On Fri, Mar 01, 2024 at 09:50:32AM +0800, Peter Xu wrote: > On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > > peterx/migration-next > > > > Hi, > > > > In this v6: > > > > - Minor fixes to 17/23 and 19/23 >

Re: [PATCH] hw/us/bus.c PCAP adding 0xA in Windows version

2024-03-01 Thread Thomas Huth
On 25/02/2024 20.49, benl...@fysnet.net wrote: Since Windows text files use CRLFs for all \n, the Windows version of QEMU inserts a CR in the PCAP stream when a LF is encountered when using USB PCAP files. This is due to the fact that the PCAP file is opened as TEXT instead of BINARY. To show an

[PATCH v1 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-01 Thread Ho-Ren (Jack) Chuang
* Introduce `mt_init_with_hmat()` We defer memory tier initialization for those CPUless NUMA nodes until acquiring HMAT info. `mt_init_with_hmat()` is introduced to post-create CPUless memory tiers after obtaining HMAT info. It iterates through each CPUless memory node, creating memory tiers if nec

[PATCH v1 0/1] Improved Memory Tier Creation for CPUless NUMA Nodes

2024-03-01 Thread Ho-Ren (Jack) Chuang
The memory tiering component in the kernel is functionally useless for CPUless memory/non-DRAM devices like CXL1.1 type3 memory because the nodes are lumped together in the DRAM tier. https://lore.kernel.org/linux-mm/ph0pr08mb7955e9f08ccb64f23963b5c3a8...@ph0pr08mb7955.namprd08.prod.outlook.com/T/

Re: [PATCH v7 2/2] hw/acpi: Implement the SRAT GI affinity structure

2024-03-01 Thread Ankit Agrawal
>> >> One more thing.  Right now we can't use Generic Initiators as >> HMAT initiators.  That also wants fixing given that's their >> normal usecase rather than what you are using them for so it >> should 'work'. > > Something along the lines of this will do the job. Thanks! Will incorporate the p

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-03-01 Thread Ankit Agrawal
>> As for your suggestion of using acpi-dev as the arg to take both >> pci-dev and acpi-dev.. Would that mean sending a pure pci device >> (not the corner case you mentioned) through the acpi-dev argument >> as well? Not sure if that would appropriate. > > Ah, looking up my description is unclear.

Re: [PATCH 06/19] smbios: get rid of smbios_legacy global

2024-03-01 Thread Ani Sinha
> On 29-Feb-2024, at 19:59, Igor Mammedov wrote: > > On Thu, 29 Feb 2024 16:23:21 +0530 > Ani Sinha wrote: > >>> On 27-Feb-2024, at 21:17, Igor Mammedov wrote: >>> >>> clean up smbios_set_defaults() which is reused by legacy >>> and non legacy machines from being aware of 'legacy' notion >

Re: [PATCH v6 00/23] migration: File based migration with multifd and mapped-ram

2024-03-01 Thread Peter Xu
On Thu, Feb 29, 2024 at 12:29:54PM -0300, Fabiano Rosas wrote: > Based-on: 74aa0fb297 (migration: options incompatible with cpr) # > peterx/migration-next > > Hi, > > In this v6: > > - Minor fixes to 17/23 and 19/23 Thanks both for confirming, queued now. -- Peter Xu

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Het Gala
On 29/02/24 6:47 am, Fabiano Rosas wrote: Het Gala writes: On 27/02/24 1:04 am, Het Gala wrote: On 26/02/24 6:31 pm, Fabiano Rosas wrote: Het Gala writes: On 24/02/24 1:42 am, Fabiano Rosas wrote: this was the same first approach that I attempted. It won't work because The final 'migr

[PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread peterx
From: Peter Xu Add two documentations for mapped-ram migration on two spots that may not be extremely clear. Signed-off-by: Peter Xu --- Based-on: <20240229153017.2221-1-faro...@suse.de> --- migration/multifd.c | 12 migration/ram.c | 8 +++- 2 files changed, 19 insertion

[PATCH v5 10/17] hw/loongarch: fdt adds cpu interrupt controller node

2024-03-01 Thread Song Gao
fdt adds cpu interrupt controller node, we use 'loongson,cpu-interrupt-controller'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongarch-cpu.c https://lore.kernel.org/r/20221114113824.1880-2-liupei...@loongson.cn Signed-off-by: Song Gao --- hw/loongarch/virt.c | 20 +++

[PATCH v5 08/17] hw/loongarch: Init efi_fdt table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 4 hw/loongarch/boot.c | 11 +++ 2 files changed, 15 insertions(+) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h index ce47056608..bbe8c8dd5d 100644 --- a/include/hw/loongarch/boot.h +++ b/in

[PATCH v5 02/17] hw/loongarch: Add load initrd

2024-03-01 Thread Song Gao
we load initrd ramdisk after kernel_high address Signed-off-by: Song Gao --- hw/loongarch/boot.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index 0f2bc15fdf..3075c276d4 100644 --- a/hw/loongarch/boot

[PATCH v5 07/17] hw/loongarch: Init efi_initrd table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 9 + hw/loongarch/boot.c | 23 +-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h index 7ad25080c5..ce47056608 100644 --- a/inc

[PATCH v5 00/17] Add boot LoongArch elf kernel with FDT

2024-03-01 Thread Song Gao
Hi, All We already support boot efi kernel with bios, but not support boot elf kernel. This series adds boot elf kernel with FDT. 'LoongArch supports ACPI and FDT. The information that needs to be passed to the kernel includes the memmap, the initrd, the command line, optionally the ACPI/FDT ta

[PATCH v5 16/17] hw/loongarch: Add cells missing from uart node

2024-03-01 Thread Song Gao
uart node need interrupts and interrupt-parent cells. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index e2185d7bb4..5d92b2f1aa 100644 --- a/hw/loongarch/virt.c +++ b/hw/loon

[PATCH v5 17/17] hw/loongarch: Add cells missing from rtc node

2024-03-01 Thread Song Gao
rtc node need interrupts and interrupt-parent cells. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 5d92b2f1aa..6810f78ebd 100644 --- a/hw/loongarch/virt.c +++ b/hw/l

[PATCH v5 09/17] hw/loongarch: Fix fdt memory node wrong 'reg'

2024-03-01 Thread Song Gao
The right fdt memory node like [1], not [2] [1] memory@0 { device_type = "memory"; reg = <0x00 0x00 0x00 0x1000>; }; [2] memory@0 { device_type = "memory"; reg = <0x02 0x00 0x02 0x1000>; };

[PATCH v5 04/17] hw/loongarch: Add init_cmdline

2024-03-01 Thread Song Gao
Add init_cmline and set boot_info->a0, a1 Signed-off-by: Song Gao --- include/hw/loongarch/virt.h | 2 ++ target/loongarch/cpu.h | 2 ++ hw/loongarch/boot.c | 19 +++ 3 files changed, 23 insertions(+) diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch

[PATCH v5 06/17] hw/loongarch: Init efi_boot_memmap table

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 27 + include/hw/loongarch/virt.h | 10 ++ hw/loongarch/boot.c | 39 + hw/loongarch/virt.c | 11 ++- 4 files changed, 78 insertions(+), 9 deletions

[PATCH v5 03/17] hw/loongarch: Add slave cpu boot_code

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/boot.c | 70 - 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index 3075c276d4..2f398260af 100644 --- a/hw/loongarch/boot.c +++ b/hw/loongarch/boot.c @@ -1

[PATCH v5 15/17] hw/loongarch: fdt remove unused irqchip node

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/virt.c | 31 +-- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index ea73a80628..e2185d7bb4 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -410,34 +410,6 @

[PATCH v5 01/17] hw/loongarch: Move boot fucntions to boot.c

2024-03-01 Thread Song Gao
Move some boot functions to boot.c and struct loongarch_boot_info into struct LoongArchMachineState. Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 21 ++ include/hw/loongarch/virt.h | 2 + hw/loongarch/boot.c | 125 hw/loongarch/vir

Re: [PATCH v5 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 5:46 PM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 11:08 AM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 2:08 AM, Alex Bennée wrote: Luc Michel writes: Hi Pierrick, My bad. Other plugins enable only inline when both are supplied, so I missed th

Re: [PATCH v6 06/12] tests/plugin/mem: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 10:08 PM, Alex Bennée wrote: Pierrick Bouvier writes: Reviewed-by: Luc Michel Signed-off-by: Pierrick Bouvier --- tests/plugin/mem.c | 46 +++--- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/tests/plugin/mem.c b/tests/p

Re: [PATCH v5 00/17] Add boot LoongArch elf kernel with FDT

2024-03-01 Thread gaosong
Hi, If there are no new comments, I'll add this series to the loongarch-next branch next week. Thanks. Song Gao 在 2024/3/1 下午5:38, Song Gao 写道: Hi, All We already support boot efi kernel with bios, but not support boot elf kernel. This series adds boot elf kernel with FDT. 'LoongArch suppo

[PATCH v5 14/17] hw/loongarch: fdt adds pcie irq_map node

2024-03-01 Thread Song Gao
Signed-off-by: Song Gao --- hw/loongarch/virt.c | 73 ++--- 1 file changed, 69 insertions(+), 4 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index e1fe1ea97f..ea73a80628 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -

[PATCH v5 05/17] hw/loongarch: Init efi_system_table

2024-03-01 Thread Song Gao
Add init_systab and set boot_info->a2 Signed-off-by: Song Gao --- include/hw/loongarch/boot.h | 48 + hw/loongarch/boot.c | 22 + 2 files changed, 70 insertions(+) diff --git a/include/hw/loongarch/boot.h b/include/hw/loongarch/boot.h

[PATCH v5 12/17] hw/loongarch: fdt adds pch_pic Controller

2024-03-01 Thread Song Gao
fdt adds pch pic controller, we use 'loongson,pch-pic-1.0' See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-pch-pic.c https://lore.kernel.org/r/20200528152757.1028711-4-jiaxun.y...@flygoat.com Signed-off-by: Song Gao --- include/hw/pci-host/ls7a.h | 1 + hw/loongar

[PATCH v5 13/17] hw/loongarch: fdt adds pch_msi Controller

2024-03-01 Thread Song Gao
fdt adds pch msi controller, we use 'loongson,pch-msi-1.0'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-pch-msi.c https://lore.kernel.org/r/20200528152757.1028711-6-jiaxun.y...@flygoat.com Signed-off-by: Song Gao --- include/hw/pci-host/ls7a.h | 1 + hw/loonga

[PATCH v5 11/17] hw/loongarch: fdt adds Extend I/O Interrupt Controller

2024-03-01 Thread Song Gao
fdt adds Extend I/O Interrupt Controller, we use 'loongson,ls2k2000-eiointc'. See: https://github.com/torvalds/linux/blob/v6.7/drivers/irqchip/irq-loongson-eiointc.c https://lore.kernel.org/r/764e02d924094580ac0f1d15535f4b98308705c6.1683279769.git.zhoubin...@loongson.cn Signed-off-by: Song Gao -

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 2/29/24 6:21 PM, Alex Bennée wrote: Pierrick Bouvier writes: Signed-off-by: Pierrick Bouvier I did notice there is a discrepancy between what libisns and libb report. The libb looks like an overcount so I wonder if there are some instructions we are not picking up but I can't see where t

[PATCH 0/1] kvm: add support for guest physical bits

2024-03-01 Thread Gerd Hoffmann
The matching kernel bits are here: https://lore.kernel.org/kvm/20240301101410.356007-1-kra...@redhat.com/T/ Gerd Hoffmann (1): kvm: add support for guest physical bits target/i386/cpu.h | 1 + target/i386/cpu.c | 1 + target/i386/kvm/kvm.c | 8 3 files changed, 10 insertions(+

[PATCH 1/1] kvm: add support for guest physical bits

2024-03-01 Thread Gerd Hoffmann
query kvm for supported guest physical address bits using KVM_CAP_VM_GPA_BITS. Expose the value to the guest via cpuid (leaf 0x8008, eax, bits 16-23). Signed-off-by: Gerd Hoffmann --- target/i386/cpu.h | 1 + target/i386/cpu.c | 1 + target/i386/kvm/kvm.c | 8 3 files chang

Re: [PATCH v2 0/5] Add device DM163 (led driver, matrix colors shield & display)

2024-03-01 Thread Peter Maydell
On Wed, 28 Feb 2024 at 12:06, Thomas Huth wrote: > > On 28/02/2024 12.31, Inès Varhol wrote: > > TLDR: how can I provide a test or an example? > > > > I've tested the display by running custom executables and > > comparing to the result on the real board, but I don't > > know how to test it using

Re: [PULL 26/29] contrib/plugins: extend execlog to track register changes

2024-03-01 Thread Alex Bennée
Zhao Liu writes: > Hi Alex, > > I hit the following warnings (with "./configure --enable-werror"): > > /qemu/contrib/plugins/execlog.c: In function ‘registers_init’: > /qemu/contrib/plugins/execlog.c:330:17: warning: ‘g_pattern_match_string’ is > deprecated: Use 'g_pattern_spec_match_string' ins

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Alex Bennée
Pierrick Bouvier writes: > On 2/29/24 6:21 PM, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> Signed-off-by: Pierrick Bouvier >> I did notice there is a discrepancy between what libisns and libb >> report. The libb looks like an overcount so I wonder if there are some >> instructions we

Re: [PATCH V4 10/14] migration: stop vm for cpr

2024-03-01 Thread Cédric Le Goater
On 3/1/24 02:28, Peter Xu wrote: On Thu, Feb 29, 2024 at 10:21:14AM -0500, Steven Sistare wrote: On 2/25/2024 9:08 PM, Peter Xu wrote: On Thu, Feb 22, 2024 at 09:28:36AM -0800, Steve Sistare wrote: When migration for cpr is initiated, stop the vm and set state RUN_STATE_FINISH_MIGRATE before r

Re: [PATCH v5 08/12] tests/plugin/bb: migrate to new per_vcpu API

2024-03-01 Thread Pierrick Bouvier
On 3/1/24 2:26 PM, Alex Bennée wrote: Pierrick Bouvier writes: On 2/29/24 6:21 PM, Alex Bennée wrote: Pierrick Bouvier writes: Signed-off-by: Pierrick Bouvier I did notice there is a discrepancy between what libisns and libb report. The libb looks like an overcount so I wonder if there a

Re: [PATCH v2 0/5] Add device DM163 (led driver, matrix colors shield & display)

2024-03-01 Thread Thomas Huth
On 01/03/2024 11.21, Peter Maydell wrote: On Wed, 28 Feb 2024 at 12:06, Thomas Huth wrote: On 28/02/2024 12.31, Inès Varhol wrote: TLDR: how can I provide a test or an example? I've tested the display by running custom executables and comparing to the result on the real board, but I don't kn

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-03-01 Thread Anthony Harivel
Hi Paolo, > > > +static void compute_default_paths(void) > > > +{ > > > +socket_path = g_build_filename("/run", "qemu-vmsr-helper.sock", > > > NULL); > > > +pidfile = g_build_filename("/run", "qemu-vmsr-helper.pid", NULL); > > > +} > > > > We shouldn't be hardcoding /run, we need to honou

Re: [QEMU][PATCH v3 1/7] softmmu: physmem: Split ram_block_add()

2024-03-01 Thread Alex Bennée
Vikram Garhwal writes: > Extract ram block list update to a new function ram_block_add_list(). This is > done to support grant mappings which adds a memory region for granted memory > and > updates the ram_block list. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal > Reviewed-

Re: [PATCH v7 0/3] string list functions

2024-03-01 Thread Markus Armbruster
Steven Sistare writes: > All the changes look good - steve Thanks! I can stick this into my next PR, ETA early next week.

[PATCH] replay: Improve error messages about configuration conflicts

2024-03-01 Thread Markus Armbruster
Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot' to Record/replay is not supported with -rtc base=localtime Record/replay is not supported with multiple

Re: [PATCH] migration/multifd: Document two places for mapped-ram

2024-03-01 Thread Fabiano Rosas
pet...@redhat.com writes: > From: Peter Xu > > Add two documentations for mapped-ram migration on two spots that may not > be extremely clear. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Het Gala
On 01/03/24 2:19 pm, Het Gala wrote: On 29/02/24 6:47 am, Fabiano Rosas wrote: Het Gala writes: On 27/02/24 1:04 am, Het Gala wrote: On 26/02/24 6:31 pm, Fabiano Rosas wrote: Het Gala  writes: On 24/02/24 1:42 am, Fabiano Rosas wrote: this was the same first approach that I attempted.

Re: [PATCH v2] hw/nvme/ns: Add NVMe NGUID property

2024-03-01 Thread Klaus Jensen
On Feb 22 17:50, Nabih Estefan wrote: > From: Roque Arcudia Hernandez > > This patch adds a way to specify an NGUID for a given NVMe Namespace using a > string of hexadecimal digits with an optional '-' separator to group bytes. > For > instance: > > -device nvme-ns,nguid="e9accd3b83904e13167cf

Re: [PATCH v5 09/12] contrib/plugins/hotblocks: migrate to new per_vcpu API

2024-03-01 Thread Luc Michel
On 14:33 Thu 29 Feb , Alex Bennée wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Luc Michel writes: > > > On 15:09 Tue 27 Feb , Pierrick Bouvier wrote: > >> On 2/27/24 2:54 PM, Luc M

Re: [PULL v2 1/1] loongarch: Change the UEFI loading mode to loongarch

2024-03-01 Thread Philippe Mathieu-Daudé
On 29/2/24 12:38, Song Gao wrote: From: Xianglai Li The UEFI loading mode in loongarch is very different from that in other architectures:loongarch's UEFI code is in rom, while other architectures' UEFI code is in flash. loongarch UEFI can be loaded as follows: -machine virt,pflash=pflash0-for

Re: [PATCH v2 3/5] linux-user: Add strace for shmat

2024-03-01 Thread Philippe Mathieu-Daudé
On 28/2/24 21:25, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/strace.c| 23 +++ linux-user/strace.list | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

2024-03-01 Thread Fabiano Rosas
Het Gala writes: > On 01/03/24 2:19 pm, Het Gala wrote: >> >> On 29/02/24 6:47 am, Fabiano Rosas wrote: >>> Het Gala writes: >>> On 27/02/24 1:04 am, Het Gala wrote: > > On 26/02/24 6:31 pm, Fabiano Rosas wrote: >> Het Gala  writes: >> >>> On 24/02/24 1:42 am, Fabiano Ro

[RFC 1/8] virtio/virtio-pci: Handle extra notification data

2024-03-01 Thread Jonah Palmer
Add support to virtio-pci devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-pci device when this feature is enabled varies depending on the device's virtqueue

[RFC 5/8] virtio-ccw: Handle extra notification data

2024-03-01 Thread Jonah Palmer
Add support to virtio-ccw devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-ccw device when this feature is enabled varies depending on the device's virtqueue

[RFC 8/8] virtio: Add VIRTIO_F_NOTIFICATION_DATA property definition

2024-03-01 Thread Jonah Palmer
Extend the virtio device property definitions to include the VIRTIO_F_NOTIFICATION_DATA feature. The default state of this feature is disabled, allowing it to be explicitly enabled where it's supported. Signed-off-by: Jonah Palmer --- include/hw/virtio/virtio.h | 4 +++- 1 file changed, 3 inser

[RFC 7/8] vhost/vhost-user: Add VIRTIO_F_NOTIFICATION_DATA to vhost feature bits

2024-03-01 Thread Jonah Palmer
Add support for the VIRTIO_F_NOTIFICATION_DATA feature across a variety of vhost devices. The inclusion of VIRTIO_F_NOTIFICATION_DATA in the feature bits arrays for these devices ensures that the backend is capable of offering and providing support for this feature, and that it can be disabled if

[RFC 0/8] virtio,vhost: Add VIRTIO_F_NOTIFICATION_DATA support

2024-03-01 Thread Jonah Palmer
The goal of these patches are to add support to a variety of virtio and vhost devices for the VIRTIO_F_NOTIFICATION_DATA transport feature. This feature indicates that a driver will pass extra data (instead of just a virtqueue's index) when notifying the corresponding device. The data passed in by

[RFC 6/8] virtio-ccw: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-01 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-ccw device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to the ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-ccw

[RFC 4/8] virtio-mmio: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-01 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-mmio device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-mmio d

[RFC 3/8] virtio-mmio: Handle extra notification data

2024-03-01 Thread Jonah Palmer
Add support to virtio-mmio devices for handling the extra data sent from the driver to the device when the VIRTIO_F_NOTIFICATION_DATA transport feature has been negotiated. The extra data that's passed to the virtio-mmio device when this feature is enabled varies depending on the device's virtqueu

[RFC 2/8] virtio-pci: Lock ioeventfd state with VIRTIO_F_NOTIFICATION_DATA

2024-03-01 Thread Jonah Palmer
Prevent ioeventfd from being enabled/disabled when a virtio-pci device has negotiated the VIRTIO_F_NOTIFICATION_DATA transport feature. Due to ioeventfd not being able to carry the extra data associated with this feature, the ioeventfd should be left in a disabled state for emulated virtio-pci dev

Re: [PATCH 00/19] Workaround Windows failing to find 64bit SMBIOS entry point with SeaBIOS

2024-03-01 Thread Fiona Ebner
Am 29.02.24 um 14:18 schrieb Fiona Ebner: > Am 27.02.24 um 16:47 schrieb Igor Mammedov: >> Windows (10) bootloader when running on top of SeaBIOS, fails to find >> >> SMBIOSv3 entry point. Tracing it shows that it looks for v2 anchor markers >> >> only and not v3. Tricking it i

Re: [QEMU][PATCH v3 2/7] xen: add pseudo RAM region for grant mappings

2024-03-01 Thread Alex Bennée
Vikram Garhwal writes: > From: Juergen Gross > > Add a memory region which can be used to automatically map granted > memory. It is starting at 0x8000ULL in order to be able to > distinguish it from normal RAM. Is the Xen memory map for HVM guests documented anywhere? I couldn't fin

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 29.02.24 17:50, Fiona Ebner wrote: Am 29.02.24 um 13:00 schrieb Vladimir Sementsov-Ogievskiy: But anyway, this all could be simply achieved with bitmap-copying/merging API, if we allow to pass user-given bitmap to the mirror as working bitmap. I see, I'll drop the 'bitmap-mode' in the nex

Re: [PULL 0/6] Misc fixes (libqos vring, Kconfig, TLS io channels, ...)

2024-03-01 Thread Peter Maydell
On Fri, 1 Mar 2024 at 08:09, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit c0c6a0e3528b88aaad0b9d333e295707a195587b: > > Merge tag 'migration-next-pull-request' of https://gitlab.com/peterx/qemu > into staging (2024-02-28 17:27:10 +) > > are available in the Git r

Re: [PULL v2 0/1] loongarch-to-apply queue

2024-03-01 Thread Peter Maydell
On Thu, 29 Feb 2024 at 11:38, Song Gao wrote: > > The following changes since commit bfe8020c814a30479a4241aaa78b63960655962b: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2024-02-28 14:23:21 +) > > are available in the Git repository at: > > https://git

[PATCH] target/riscv: move ratified/frozen exts to non-experimental

2024-03-01 Thread Daniel Henrique Barboza
smaia and ssaia were ratified in August 25th 2023 [1]. zvfh and zvfhmin were ratified in August 2nd 2023 [2]. zfbfmin and zvfbf(min|wma) are frozen and moved to public review since Dec 16th 2023 [3]. zaamo and zalrsc are both marked as "Frozen" since January 24th 2024 [4]. [1] https://jira.risc

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 29.02.24 16:21, Markus Armbruster wrote: Thomas Huth writes: On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 09:32, Markus Armbruster wrote: [...] Anti-pattern: fail without setting an error.  There might be more elsewhere in the series. qapi/error.h's big comment

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-01 Thread Fiona Ebner
Am 01.03.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy: > > As we already understood, (block-)job-api needs some spring-cleaning. > Unfortunately I don't have much time on it, but still I decided to start > from finally depreacting block-job-* API and moving to job-*.. Probably > bitmap/bitmap-

Re: [PATCH v2 06/21] migration: Add Error** argument to .save_setup() handler

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 01.03.24 17:44, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 16:21, Markus Armbruster wrote: Thomas Huth writes: On 29/02/2024 08.20, Vladimir Sementsov-Ogievskiy wrote: On 29.02.24 09:32, Markus Armbruster wrote: [...] Anti-pattern: fail without setting an error.  There might be m

[PATCH] Fix unexpected Illegal instruction error on RISC-V.

2024-03-01 Thread SiHuaN
Avoid right-shifting by a negative number of bits when lmul is 8. Signed-off-by: SiHuaN --- target/riscv/vector_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 84cec73eb2..f0158ea237 100644 --- a/tar

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 01.03.24 17:52, Fiona Ebner wrote: Am 01.03.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy: As we already understood, (block-)job-api needs some spring-cleaning. Unfortunately I don't have much time on it, but still I decided to start from finally depreacting block-job-* API and moving to

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-01 Thread Fiona Ebner
Am 01.03.24 um 16:02 schrieb Vladimir Sementsov-Ogievskiy: > On 01.03.24 17:52, Fiona Ebner wrote: >> Am 01.03.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy: >>> >>> As we already understood, (block-)job-api needs some spring-cleaning. >>> Unfortunately I don't have much time on it, but still I

Re: QNX VM hang on Qemu

2024-03-01 Thread Clément Chigot
Hi Faiq, On Fri, Feb 23, 2024 at 3:55 PM Faiq Ali Sayed wrote: > > So as far as my understanding, we provide these binaries using Qemu command > as depicted in the example you provided and there is no way I found to put > them into a single image. > Regarding the overlapping space, I don't have

Re: [PULL 26/29] contrib/plugins: extend execlog to track register changes

2024-03-01 Thread Zhao Liu
On Fri, Mar 01, 2024 at 10:22:08AM +, Alex Bennée wrote: > Date: Fri, 01 Mar 2024 10:22:08 + > From: Alex Bennée > Subject: Re: [PULL 26/29] contrib/plugins: extend execlog to track register > changes > > Zhao Liu writes: > > > Hi Alex, > > > > I hit the following warnings (with "./con

[PATCH v9 1/1] hw: add some convenient trace-events for pcie and shpc hotplug

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
Add trace-events that may help to debug problems with hotplugging. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci/pcie.c | 56 + hw/pci/shpc.c | 46 + hw/pci/trace-events | 6 + 3 files chang

[PATCH v9 0/1] pci hotplug tracking

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
v9: I was convinced, that adding new qapi interfaces here is questionable. So, to conclude, let's still add two convenient trace-points, which may help to debug hotplug problems. Vladimir Sementsov-Ogievskiy (1): hw: add some convenient trace-events for pcie and shpc hotplug hw/pci/pcie.c

Re: [RFC 0/4] mirror: implement incremental and bitmap modes

2024-03-01 Thread Vladimir Sementsov-Ogievskiy
On 01.03.24 18:14, Fiona Ebner wrote: Am 01.03.24 um 16:02 schrieb Vladimir Sementsov-Ogievskiy: On 01.03.24 17:52, Fiona Ebner wrote: Am 01.03.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy: As we already understood, (block-)job-api needs some spring-cleaning. Unfortunately I don't have mu

Re: [Spam][PATCH] replay: Improve error messages about configuration conflicts

2024-03-01 Thread Pavel Dovgalyuk
Reviewed-by: Pavel Dovgalyuk On 01.03.2024 15:06, Markus Armbruster wrote: Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot' to Record/replay is not

Re: [PULL 2/2] aspeed: fix hardcode boot address 0

2024-03-01 Thread Philippe Mathieu-Daudé
Hi Jamin, On 27/2/24 13:52, Cédric Le Goater wrote: From: Jamin Lin In the previous design of ASPEED SOCs QEMU model, it set the boot address at "0" which was the hardcode setting for ast10x0, ast2600, ast2500 and ast2400. According to the design of ast2700, it has a bootmcu(riscv-32) which i

Re: [PATCH] Fix unexpected Illegal instruction error on RISC-V.

2024-03-01 Thread Philippe Mathieu-Daudé
Hi SiHuaN, On 1/3/24 15:55, SiHuaN wrote: Avoid right-shifting by a negative number of bits when lmul is 8. FYI Demin posted a similar patch, see: https://lore.kernel.org/qemu-devel/20240225174114.5298-1-demin@starfivetech.com/ Signed-off-by: SiHuaN --- target/riscv/vector_helper.c |

Re: [PATCH v9 1/1] hw: add some convenient trace-events for pcie and shpc hotplug

2024-03-01 Thread Philippe Mathieu-Daudé
On 1/3/24 16:41, Vladimir Sementsov-Ogievskiy wrote: Add trace-events that may help to debug problems with hotplugging. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci/pcie.c | 56 + hw/pci/shpc.c | 46 +++

Re: [PATCH] replay: Improve error messages about configuration conflicts

2024-03-01 Thread Philippe Mathieu-Daudé
On 1/3/24 13:06, Markus Armbruster wrote: Improve Record/replay feature is not supported for '-rtc base=localtime' Record/replay feature is not supported for 'smp' Record/replay feature is not supported for '-snapshot' to Record/replay is not supported with -rtc base=localtime

Re: [PATCH v2 1/6] libqos/virtio.c: init all elems in qvring_indirect_desc_setup()

2024-03-01 Thread Michael Tokarev
17.02.2024 22:26, Daniel Henrique Barboza: diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c index 410513225f..4f39124eba 100644 --- a/tests/qtest/libqos/virtio.c +++ b/tests/qtest/libqos/virtio.c @@ -280,14 +280,27 @@ QVRingIndirectDesc *qvring_indirect_desc_setup(QTestStat

Re: [PATCH v7 1/2] qom: new object to associate device to numa node

2024-03-01 Thread Alex Williamson
On Fri, 1 Mar 2024 08:33:42 + Ankit Agrawal wrote: > >> As for your suggestion of using acpi-dev as the arg to take both > >> pci-dev and acpi-dev.. Would that mean sending a pure pci device > >> (not the corner case you mentioned) through the acpi-dev argument > >> as well? Not sure if that

Re: Re: [PATCH] Fix unexpected Illegal instruction error on RISC-V.

2024-03-01 Thread 李永泰
Hi Philippe, Thanks for the heads up. Sorry I didn't check for this before sending out my patch. I'll track this in Demin's thread. > -原始邮件- > 发件人: "Philippe Mathieu-Daudé" > 发送时间: 2024-03-01 23:51:03 (星期五) > 收件人: SiHuaN , qemu-devel@nongnu.org > 抄送: "demin.han" , qemu-riscv , "Daniel

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Chalapathi V
Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, Chalapathi On 07-02-2024 21:38, Chalapathi V wrote: Hello, In this series of patchset, SPI controller and responder models for Power10 processor are modelled. Serial peripheral interface pr

Re: [PULL 26/29] contrib/plugins: extend execlog to track register changes

2024-03-01 Thread Alex Bennée
Zhao Liu writes: > On Fri, Mar 01, 2024 at 10:22:08AM +, Alex Bennée wrote: >> Date: Fri, 01 Mar 2024 10:22:08 + >> From: Alex Bennée >> Subject: Re: [PULL 26/29] contrib/plugins: extend execlog to track register >> changes >> >> Zhao Liu writes: >> >> > Hi Alex, >> > >> > I hit the

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Cédric Le Goater
Chalapathi, On 3/1/24 17:17, Chalapathi V wrote: Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, I didn't forget but I lacked the time in this release cycle. Sorry about that. I have one quick comment though. There are already a few mode

Re: [PATCH 3/9] backends/confidential-guest-support: Add functions to support IGVM

2024-03-01 Thread Daniel P . Berrangé
On Tue, Feb 27, 2024 at 02:50:09PM +, Roy Hopkins wrote: > In preparation for supporting the processing of IGVM files to configure > guests, this adds a set of functions to ConfidentialGuestSupport > allowing configuration of secure virtual machines that can be > implemented for each supported

Re: [PATCH] hw/misc: zynq_slcr: set SLC_RST bit in REBOOT_STATUS register

2024-03-01 Thread Peter Maydell
On Wed, 28 Feb 2024 at 01:40, Gregory Anders wrote: > > When the CPU is reset using PSS_RST_CTRL in the SLCR, bit 19 in > REBOOT_STATUS should be set. > > Refer to page 1602 of the Xilinx Zynq 7000 Technical Reference Manual. > > Signed-off-by: Gregory Anders > --- > hw/misc/zynq_slcr.c | 2 ++ >

Re: [PATCH 4/9] backends/igvm: Implement parsing and processing of IGVM files

2024-03-01 Thread Daniel P . Berrangé
On Tue, Feb 27, 2024 at 02:50:10PM +, Roy Hopkins wrote: > This commit adds an implementation of an IGVM loader which parses the > file specified as a pararameter to ConfidentialGuestSupport and provides > a function that uses the interface in the same object to configure and > populate guest m

  1   2   3   4   >