Re: [PATCH v6 12/15] hw/pci: Use -1 as a default value for rombar

2024-02-21 Thread Markus Armbruster
Akihiko Odaki writes: > Currently there is no way to distinguish the case that rombar is > explicitly specified as 1 and the case that rombar is not specified. > > Set rombar -1 by default to distinguish these cases just as it is done > for addr and romsize. It was confirmed that changing the def

Re: [PATCH] hw/virtio: Add support for VDPA network simulation devices

2024-02-21 Thread Michael S. Tsirkin
On Wed, Feb 21, 2024 at 03:38:02PM +0800, Hao Chen wrote: > This patch adds support for VDPA network simulation devices. > The device is developed based on virtio-net and tap backend, > and supports hardware live migration function. > > For more details, please refer to "docs/system/devices/vdpa-n

Re: [PATCH] tests: skip dbus-display tests that need a console

2024-02-21 Thread Thomas Huth
On 21/02/2024 08.37, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau When compiling with "configure --without-default-devices", the dbus-display-test fails since it implicitly assumes that the machine comes with a default console. There doesn't seem to be an easy way to figure this

Re: [PATCH v6 13/15] hw/pci: Determine if rombar is explicitly enabled

2024-02-21 Thread Markus Armbruster
Akihiko Odaki writes: > vfio determines if rombar is explicitly enabled by inspecting QDict. > Inspecting QDict is not nice because QDict is untyped and depends on the > details on the external interface. Add an infrastructure to determine if > rombar is explicitly enabled to hw/pci. > > Signed-o

Re: [PATCH v6 14/15] vfio: Avoid inspecting option QDict for rombar

2024-02-21 Thread Markus Armbruster
Akihiko Odaki writes: > Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly > enabled. > > Signed-off-by: Akihiko Odaki > --- > hw/vfio/pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 4fa387f0430d..647f

Re: [PATCH v6 15/15] hw/qdev: Remove opts member

2024-02-21 Thread Markus Armbruster
Akihiko Odaki writes: > It is no longer used. > > Signed-off-by: Akihiko Odaki > Reviewed-by: Philippe Mathieu-Daudé > --- > include/hw/qdev-core.h | 4 > hw/core/qdev.c | 1 - > system/qdev-monitor.c | 12 +++- > 3 files changed, 7 insertions(+), 10 deletions(-) > > di

[Stable-8.2.2 v0 00/60] Patch Round-up for stable 8.2.2, freeze on 2024-03-02

2024-02-21 Thread Michael Tokarev
The following patches are queued for QEMU stable v8.2.2: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 Patch freeze is 2024-03-02, and the release is planned for 2024-03-04: https://wiki.qemu.org/Planning/8.2 Please respond here or CC qemu-sta...@nongnu.org on any additional pa

[Stable-8.2.2 01/60] migration: Plug memory leak on HMP migrate error path

2024-02-21 Thread Michael Tokarev
From: Markus Armbruster hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak with g_autoptr(). Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration flow.) v8.2.0-rc0 Fixes: CID 1533125 Signed-off-by: Markus Armbruster Link: https://lore.kernel.org/r/20240

Re: [RESEND PATCH v4 00/17] Add boot LoongArch elf kernel with FDT

2024-02-21 Thread gaosong
Ping ! 在 2024/1/18 下午7:31, Song Gao 写道: Hi, All We already support boot efi kernel with bios, but not support boot elf kernel. This series adds boot elf kernel with FDT. 'LoongArch supports ACPI and FDT. The information that needs to be passed to the kernel includes the memmap, the initrd, t

[Stable-8.2.2 16/60] iotests: give tempdir an identifying name

2024-02-21 Thread Michael Tokarev
From: Daniel P. Berrangé If something goes wrong causing the iotests not to cleanup their temporary directory, it is useful if the dir had an identifying name to show what is to blame. Signed-off-by: Daniel P. Berrangé Message-ID: <20240205155158.1843304-1-berra...@redhat.com> Revieved-by: Mich

[Stable-8.2.2 11/60] pci-host: designware: Limit value range of iATU viewport register

2024-02-21 Thread Michael Tokarev
From: Guenter Roeck The latest version of qemu (v8.2.0-869-g7a1dc45af5) crashes when booting the mcimx7d-sabre emulation with Linux v5.11 and later. qemu-system-arm: ../system/memory.c:2750: memory_region_set_alias_offset: Assertion `mr->alias' failed. Problem is that the Designware PCIe emula

[Stable-8.2.2 13/60] linux-user/aarch64: Add padding before __kernel_rt_sigreturn

2024-02-21 Thread Michael Tokarev
From: Richard Henderson Without this padding, an unwind through the signal handler will pick up the unwind info for the preceding syscall. This fixes gcc's 30_threads/thread/native_handle/cancel.cc. Cc: qemu-sta...@nongnu.org Fixes: ee95fae075c6 ("linux-user/aarch64: Add vdso") Resolves: https:

[Stable-8.2.2 10/60] target/arm: Reinstate "vfp" property on AArch32 CPUs

2024-02-21 Thread Michael Tokarev
From: Peter Maydell In commit 4315f7c614743 we restructured the logic for creating the VFP related properties to avoid testing the aa32_simd_r32 feature on AArch64 CPUs. However in the process we accidentally stopped exposing the "vfp" QOM property on AArch32 TCG CPUs. This mostly hasn't had an

[Stable-8.2.2 12/60] tcg/loongarch64: Set vector registers call clobbered

2024-02-21 Thread Michael Tokarev
From: Richard Henderson Because there are more call clobbered registers than call saved registers, we begin with all registers as call clobbered and then reset those that are saved. This was missed when we introduced the LSX support. Cc: qemu-sta...@nongnu.org Fixes: 16288ded944 ("tcg/loongarch

[Stable-8.2.2 09/60] qemu-options.hx: Improve -serial option documentation

2024-02-21 Thread Michael Tokarev
From: Peter Maydell The -serial option documentation is a bit brief about '-serial none' and '-serial null'. In particular it's not very clear about the difference between them, and it doesn't mention that it's up to the machine model whether '-serial none' means "don't create the serial port" or

[Stable-8.2.2 07/60] target/arm: fix exception syndrome for AArch32 bkpt insn

2024-02-21 Thread Michael Tokarev
From: Jan Klötzke Debug exceptions that target AArch32 Hyp mode are reported differently than on AAarch64. Internally, Qemu uses the AArch64 syndromes. Therefore such exceptions need to be either converted to a prefetch abort (breakpoints, vector catch) or a data abort (watchpoints). Cc: qemu-st

[Stable-8.2.2 34/60] virtio-gpu: Correct virgl_renderer_resource_get_info() error check

2024-02-21 Thread Michael Tokarev
From: Dmitry Osipenko virgl_renderer_resource_get_info() returns errno and not -1 on error. Correct the return-value check. Reviewed-by: Marc-André Lureau Signed-off-by: Dmitry Osipenko Message-Id: <20240129073921.446869-1-dmitry.osipe...@collabora.com> Cc: qemu-sta...@nongnu.org Reviewed-by:

[Stable-8.2.2 08/60] system/vl.c: Fix handling of '-serial none -serial something'

2024-02-21 Thread Michael Tokarev
From: Peter Maydell Currently if the user passes multiple -serial options on the command line, we mostly treat those as applying to the different serial devices in order, so that for example -serial stdio -serial file:filename will connect the first serial port to stdio and the second to the nam

[Stable-8.2.2 06/60] block/blkio: Make s->mem_region_alignment be 64 bits

2024-02-21 Thread Michael Tokarev
From: "Richard W.M. Jones" With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type [-Wincompatible-pointer-type

[Stable-8.2.2 02/60] migration: Fix use-after-free of migration state object

2024-02-21 Thread Michael Tokarev
From: Fabiano Rosas We're currently allowing the process_incoming_migration_bh bottom-half to run without holding a reference to the 'current_migration' object, which leads to a segmentation fault if the BH is still live after migration_shutdown() has dropped the last reference to current_migrati

[Stable-8.2.2 05/60] qemu-docs: Update options for graphical frontends

2024-02-21 Thread Michael Tokarev
From: Yihuan Pan The command line options `-ctrl-grab` and `-alt-grab` have been removed in QEMU 7.1. Instead, use the `-display sdl,grab-mod=` option to specify the grab modifiers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103 Signed-off-by: Yihuan Pan Signed-off-by: Michael Tok

Re: [PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-02-21 Thread Markus Armbruster
Zhao Liu writes: > From: Zhao Liu > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be dereferenced, because it may be null. > *

[Stable-8.2.2 30/60] cxl/cdat: Handle cdat table build errors

2024-02-21 Thread Michael Tokarev
From: Ira Weiny The callback for building CDAT tables may return negative error codes. This was previously unhandled and will result in potentially huge allocations later on in ct3_build_cdat() Detect the negative error code and defer cdat building. Fixes: f5ee7413d592 ("hw/mem/cxl-type3: Add C

[RFC PATCH v2 00/22] target/arm: Implement FEAT_NMI and FEAT_GICv3_NMI

2024-02-21 Thread Jinjie Ruan via
This patch set implements FEAT_NMI and FEAT_GICv3_NMI for armv8. These introduce support for a new category of interrupts in the architecture which we can use to provide NMI like functionality. There are two modes for using this FEAT_NMI. When PSTATE.ALLINT or PSTATE.SP & SCTLR_ELx.SCTLR_SPINTMASK

[Stable-8.2.2 28/60] tcg/arm: Fix goto_tb for large translation blocks

2024-02-21 Thread Michael Tokarev
From: Richard Henderson Correct arithmetic for separating high and low on a large negative number. Cc: qemu-sta...@nongnu.org Fixes: 79ffece4447 ("tcg/arm: Implement direct branch for goto_tb") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1714 Signed-off-by: Richard Henderson Reviewe

[qemu-web PATCH] Replace deprecated "bundle install --path vendor"

2024-02-21 Thread Thomas Huth
When running "bundle install --path vendor", the command complains that the --path parameter is deprecated nowadays and that "bundle config set --local path 'vendor'" should be used instead. So let's update our README accordingly. Signed-off-by: Thomas Huth --- README | 3 ++- 1 file changed, 2

[Stable-8.2.2 27/60] tcg: Increase width of temp_subindex

2024-02-21 Thread Michael Tokarev
From: Richard Henderson We need values 0-3 for TCG_TYPE_I128 on 32-bit hosts. Cc: qemu-sta...@nongnu.org Fixes: 43eef72f4109 ("tcg: Add temp allocation for TCGv_i128") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2159 Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Dau

[Stable-8.2.2 04/60] Make 'uri' optional for migrate QAPI

2024-02-21 Thread Michael Tokarev
From: Het Gala 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migration: New migrate and migrate-incoming argument 'channels') Signed-off-by: Het Gala Link: https://lore.kernel.org/r/20240123064219.40514-1-het.g...@nut

[RFC PATCH v2 11/22] target/arm: Set pstate.ALLINT in arm_cpu_reset_hold

2024-02-21 Thread Jinjie Ruan via
Set pstate.ALLINT in arm_cpu_reset_hold as daif do it. Signed-off-by: Jinjie Ruan --- target/arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 055670343e..e850763158 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -357,6 +357,10 @

[Stable-8.2.2 47/60] iotests: Make 144 deterministic again

2024-02-21 Thread Michael Tokarev
From: Kevin Wolf Since commit effd60c8 changed how QMP commands are processed, the order of the block-commit return value and job events in iotests 144 wasn't fixed and more and caused the test to fail intermittently. Change the test to cache events first and then print them in a predefined orde

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Peter Xu
Thanks, Markus. On Wed, Feb 21, 2024 at 12:36:57PM +0530, Het Gala wrote: > > > diff --git a/qapi/migration.json b/qapi/migration.json > > > index 5a565d9b8d..5756e650b0 100644 > > > --- a/qapi/migration.json > > > +++ b/qapi/migration.json > > > @@ -1728,6 +1728,7 @@ > > > # > > > # -> { "exe

[Stable-8.2.2 03/60] vfio/pci: Clear MSI-X IRQ index always

2024-02-21 Thread Michael Tokarev
From: Cédric Le Goater When doing device assignment of a physical device, MSI-X can be enabled with no vectors enabled and this sets the IRQ index to VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ index is left untouched if no vectors are in use. Then, when INTx is enabled, the

Re: [PATCH v2 1/2] qapi/migration.json: add reason to MIGRATION event

2024-02-21 Thread Roman Khapov
If I understood you right, you suggest to improve migrate_generate_event to accept MigrationState* instead of int* state (which is pointing to field MigrationState.state in all usages), and get error reason from MigrationState.error, if the new state is MIGRATION_STATE_FAILED, is it? That soun

Re: [PATCH v2] virtio-iommu: Use qemu_real_host_page_mask as default page_size_mask

2024-02-21 Thread Jean-Philippe Brucker
On Wed, Feb 21, 2024 at 11:41:57AM +0100, Eric Auger wrote: > Hi, > > On 2/13/24 13:00, Michael S. Tsirkin wrote: > > On Tue, Feb 13, 2024 at 12:24:22PM +0100, Eric Auger wrote: > >> Hi Michael, > >> On 2/13/24 12:09, Michael S. Tsirkin wrote: > >>> On Tue, Feb 13, 2024 at 11:32:13AM +0100, Eric A

[Stable-8.2.2 23/60] configure: run plugin TCG tests again

2024-02-21 Thread Michael Tokarev
From: Paolo Bonzini Commit 39fb3cfc28b ("configure: clean up plugin option handling", 2023-10-18) dropped the CONFIG_PLUGIN line from tests/tcg/config-host.mak, due to confusion caused by the shadowing of $config_host_mak. However, TCG tests were still expecting it. Oops. Put it back, in the m

Re: [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection.

2024-02-21 Thread Elena Ufimtseva
On Fri, Feb 16, 2024 at 2:41 PM Hao Xiang wrote: > This new parameter controls where the zero page checking is running. > 1. If this parameter is set to 'legacy', zero page checking is > done in the migration main thread. > 2. If this parameter is set to 'none', zero page checking is disabled. >

[RFC PATCH v2 07/22] target/arm: Add support for NMI event state

2024-02-21 Thread Jinjie Ruan via
The NMI exception state include whether the interrupt with super priority is IRQ or FIQ, so add a nmi_is_irq flag in CPUARMState to distinguish it. Signed-off-by: Jinjie Ruan --- target/arm/cpu.h| 2 ++ target/arm/helper.c | 9 + 2 files changed, 11 insertions(+) diff --git a/target

Re: [PATCH 01/10] hw/i386: Store pointers to IDE buses in PCMachineState

2024-02-21 Thread Philippe Mathieu-Daudé
Hi Peter, On 20/2/24 17:06, Peter Maydell wrote: Add the two IDE bus BusState pointers to the set we keep in PCMachineState. This allows us to avoid passing them to pc_cmos_init(), and also will allow a refactoring of how we call pc_cmos_init_late(). Signed-off-by: Peter Maydell --- include/

[Stable-8.2.2 38/60] hw/i386: Fix _STA return value for ACPI0017

2024-02-21 Thread Michael Tokarev
From: Jonathan Cameron Found whilst testing a series for the linux kernel that actually bothers to check if enabled is set. 0xB is the option used for vast majority of DSDT entries in QEMU. It is a little odd for a device that doesn't really exist and is simply a hook to tell the OS there is a CE

[RFC PATCH v2 09/22] target/arm: Add support for FEAT_NMI, Non-maskable Interrupt

2024-02-21 Thread Jinjie Ruan via
Add support for FEAT_NMI. NMI (FEAT_NMI) is an mandatory feature in ARMv8.8-A and ARM v9.3-A. Signed-off-by: Jinjie Ruan --- target/arm/internals.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/internals.h b/target/arm/internals.h index 50bff44549..fee65caba5 100644 --- a/tar

[Stable-8.2.2 51/60] i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F

2024-02-21 Thread Michael Tokarev
From: Xiaoyao Li Existing code misses a decrement of cpuid_i when skip leaf 0x1F. There's a blank CPUID entry(with leaf, subleaf as 0, and all fields stuffed 0s) left in the CPUID array. It conflicts with correct CPUID leaf 0. Signed-off-by: Xiaoyao Li Reviewed-by:Yang Weijiang Message-ID: <2

[RFC PATCH v2 16/22] hw/intc/arm_gicv3: Implement GICD_INMIR

2024-02-21 Thread Jinjie Ruan via
Add GICD_INMIR0, GICD_INMIRnE register and support access GICD_INMIR0. Signed-off-by: Jinjie Ruan --- hw/intc/arm_gicv3_dist.c | 38 ++ hw/intc/gicv3_internal.h | 2 ++ 2 files changed, 40 insertions(+) diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gic

[PATCH] docs/system: Fix key for input grab

2024-02-21 Thread Tianlan Zhou
Key for input grab should be Ctrl-Alt-g, not just Ctrl-Alt. Signed-off-by: Tianlan Zhou --- v1: - Initial patch --- docs/system/keys.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc index 2e2c97aa23..59966a3fe7 1006

[Stable-8.2.2 39/60] tests/acpi: Update DSDT.cxl to reflect change _STA return value.

2024-02-21 Thread Michael Tokarev
From: Jonathan Cameron _STA will now return 0xB (in common with most other devices) rather than not setting the bits to indicate this fake device has not been enabled, and self tests haven't passed. Signed-off-by: Jonathan Cameron Message-Id: <20240126120132.24248-13-jonathan.came...@huawei.com

[PATCH 5/6] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-02-21 Thread Zhao Liu
From: Zhao Liu As the comment in qapi/error, dereferencing @errp requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null. * - It should not be passed to error_pr

Re: [PATCH] migration: Fix qmp_query_migrate mbps value

2024-02-21 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Feb 19, 2024 at 04:44:57PM -0300, Fabiano Rosas wrote: >> The QMP command query_migrate might see incorrect throughput numbers >> if it runs after we've set the migration completion status but before >> migration_calculate_complete() has updated s->total_time and s->mbp

Re: [PATCH v3] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-21 Thread Gerd Hoffmann
Hi, > Looking at the edk2 GH, are these the PR that are waiting for upstream > review/merge that relate to vcpu scaling? > > https://github.com/tianocore/edk2/pull/5375 > https://github.com/tianocore/edk2/pull/5327 These are draft MRs for running CI. The current devel branches are: https:/

Re: [PATCH V4 2/5] qapi: QAPI_LIST_LENGTH

2024-02-21 Thread Markus Armbruster
Steve Sistare writes: > Signed-off-by: Steve Sistare > Reviewed-by: Marc-André Lureau > --- > include/qapi/util.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/include/qapi/util.h b/include/qapi/util.h > index 81a2b13..e1b8b1d 100644 > --- a/include/qapi/util.h > +++

[Stable-8.2.2 56/60] ui/clipboard: add asserts for update and request

2024-02-21 Thread Michael Tokarev
From: Fiona Ebner Should an issue like CVE-2023-6683 ever appear again in the future, it will be more obvious which assumption was violated. Suggested-by: Marc-André Lureau Signed-off-by: Fiona Ebner Reviewed-by: Marc-André Lureau Message-ID: <20240124105749.204610-2-f.eb...@proxmox.com> (che

Re: [PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command

2024-02-21 Thread Konstantin Kostiuk
On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng wrote: > Add support of Windows Server 2025 in get-osinfo command > > Signed-off-by: Dehan Meng > --- > qga/commands-win32.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 697c65507c..f3c7e

[RFC PATCH v2 17/22] hw/intc: Enable FEAT_GICv3_NMI Feature

2024-02-21 Thread Jinjie Ruan via
Added properties to enable FEAT_GICv3_NMI feature, setup distributor and redistributor registers to indicate NMI support. Signed-off-by: Jinjie Ruan --- hw/intc/arm_gicv3_common.c | 1 + hw/intc/arm_gicv3_dist.c | 2 ++ hw/intc/gicv3_internal.h | 1 + include/hw/intc/

[Stable-8.2.2 58/60] audio: Depend on dbus_display1_dep

2024-02-21 Thread Michael Tokarev
From: Akihiko Odaki dbusaudio needs dbus_display1_dep. Fixes: 739362d4205c ("audio: add "dbus" audio backend") Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Message-Id: <20240214-dbus-v7-1-7eff29f04...@daynix.com> (cherry picked from commit d67611907590a1e6c998b7c5a5cb4394acf8432

Re: [PATCH 2/2] migration/multifd: Drop registered_yank

2024-02-21 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Feb 08, 2024 at 09:48:33AM -0300, Fabiano Rosas wrote: >> pet...@redhat.com writes: >> >> > From: Peter Xu >> > >> > With a clear definition of p->c protocol, where we only set it up if the >> > channel is fully established (TLS or non-TLS), registered_yank boolean wi

[PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-02-21 Thread Zhao Liu
From: Zhao Liu As the comment in qapi/error, dereferencing @errp requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null. * - It should not be passed to error_pr

Re: [PATCH] qapi: Misc cleanups to migrate QAPIs

2024-02-21 Thread Markus Armbruster
Peter Xu writes: > Thanks, Markus. [...] > Reviewed-by: Peter Xu > > Markus, do you want us to pick it up, or let it go via qapi? I can stick it into my next qapi PR in a few days, if you guys don't beat me to the punch.

Re: [PATCH v9 4/5] qmp: Added new command to retrieve eBPF blob.

2024-02-21 Thread Markus Armbruster
Commit message style nitpick: qmp: Add command to retrieve eBPF blob or qmp: New command to retrieve eBPF blob It's a title, not a sentence. Andrew Melnychenko writes: > Now, the binary objects may be retrieved by id. > It would require for future qmp commands that may require specif

Re: [PATCH 2/9] hw/i386/pc_piix: Share pc_cmos_init() invocation between pc and isapc machines

2024-02-21 Thread Philippe Mathieu-Daudé
On 8/2/24 23:03, Bernhard Beschow wrote: Both invocations are the same and either one is always executed. Avoid this redundancy. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[Stable-8.2.2 40/60] linux-user/aarch64: Choose SYNC as the preferred MTE mode

2024-02-21 Thread Michael Tokarev
From: Richard Henderson The API does not generate an error for setting ASYNC | SYNC; that merely constrains the selection vs the per-cpu default. For qemu linux-user, choose SYNC as the default. Cc: qemu-sta...@nongnu.org Reported-by: Gustavo Romero Signed-off-by: Richard Henderson Tested-by:

[PATCH 1/1] tests/9p: add 'use-after-unlink' test

2024-02-21 Thread Christian Schoenebeck
After removing a file from the file system, we should still be able to do I/O on the file if we already had it open before removal. Signed-off-by: Christian Schoenebeck --- OK, this was a bit surprising to me. I was expecting this test to fail, but it works! tests/qtest/virtio-9p-test.c | 41

[RFC PATCH v2 03/22] target/arm: Add PSTATE.ALLINT

2024-02-21 Thread Jinjie Ruan via
The ALLINT bit in PSTATE is used to mask all IRQ or FIQ interrupts. Place this in its own field within ENV, as that will make it easier to reset from within TCG generated code. With the change to pstate_read/write, exception entry and return are automatically handled. Signed-off-by: Jinjie Ruan

Re: [PATCH v5 2/7] trans_rvv.c.inc: remove 'is_store' bool from load/store fns

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 03:22, Daniel Henrique Barboza wrote: After the 'mark_vs_dirty' changes from the previous patch the 'is_store' bool is unused in all load/store functions that were changed. Remove it. Signed-off-by: Daniel Henrique Barboza --- target/riscv/insn_trans/trans_rvv.c.inc | 69 ++

[Stable-8.2.2 59/60] meson: Explicitly specify dbus-display1.h dependency

2024-02-21 Thread Michael Tokarev
From: Akihiko Odaki Explicitly specify dbus-display1.h as a dependency so that files depending on it will not get compiled too early. Fixes: 1222070e7728 ("meson: ensure dbus-display generated code is built before other units") Signed-off-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Messa

[PATCH v4 0/3] Adjust the output of x-query-virtio-status

2024-02-21 Thread Hyman Huang
v4: - Rebase on master - Fix the syntax mistake within the commit message of [PATCH v3 1/3] - Adjust the linking file in hw/virtio/meson.build suggested by Markus Please review, Yong v3: - Rebase on master - Use the refined commit message furnished by Markus for [PATCH v2 1/2] - Drop the [PATCH v

Re: [PATCH] vhost-user: fix the issue of vhost deadlock in nested virtualization

2024-02-21 Thread Hao Chen
在 2024/2/21 17:02, Maxime Coquelin 写道: On 2/20/24 12:43, Michael S. Tsirkin wrote: On Tue, Feb 20, 2024 at 12:26:49PM +0100, Maxime Coquelin wrote: On 2/13/24 11:05, Michael S. Tsirkin wrote: On Fri, Jan 26, 2024 at 06:07:37PM +0800, Hao Chen wrote: I run "dpdk-vdpa" and "qemur-L2" in

[Stable-8.2.2 48/60] .gitlab-ci/windows.yml: Don't install libusb or spice packages on 32-bit

2024-02-21 Thread Michael Tokarev
From: Peter Maydell When msys2 updated their libusb packages to libusb 1.0.27, they dropped support for building them for mingw32, leaving only mingw64 packages. This broke our CI job, as the 'pacman' package install now fails with: error: target not found: mingw-w64-i686-libusb error: target n

Re: [PATCH v4 30/34] monitor: Honor QMP request for fd removal immediately

2024-02-21 Thread Markus Armbruster
Fabiano Rosas writes: > We're currently only removing an fd from the fdset if the VM is > running. This causes a QMP call to "remove-fd" to not actually remove > the fd if the VM happens to be stopped. > > While the fd would eventually be removed when monitor_fdset_cleanup() > is called again, th

Re: [PATCH 2/6] hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize()

2024-02-21 Thread Markus Armbruster
Zhao Liu writes: > From: Zhao Liu > > As the comment in qapi/error, dereferencing @errp requires > ERRP_GUARD(): > > * = Why, when and how to use ERRP_GUARD() = > * > * Without ERRP_GUARD(), use of the @errp parameter is restricted: > * - It must not be dereferenced, because it may be null. > *

Re: [PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize()

2024-02-21 Thread Zhao Liu
On Wed, Feb 21, 2024 at 12:35:47PM +0100, Markus Armbruster wrote: > Date: Wed, 21 Feb 2024 12:35:47 +0100 > From: Markus Armbruster > Subject: Re: [PATCH 3/6] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in > ct3_realize() > > Zhao Liu writes: > > > From: Zhao Liu > > > > As the comment in qap

[Stable-8.2.2 45/60] target/arm: Fix SVE/SME gross MTE suppression checks

2024-02-21 Thread Michael Tokarev
From: Richard Henderson The TBI and TCMA bits are located within mtedesc, not desc. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Tested-by: Gustavo Romero Message-id: 20240207025210.8837-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell (ch

Re: [PATCH 18/23] plugins: add an API to read registers

2024-02-21 Thread Alex Bennée
Akihiko Odaki writes: > On 2024/02/21 19:02, Alex Bennée wrote: >> Akihiko Odaki writes: >> >>> On 2024/02/20 23:14, Alex Bennée wrote: Akihiko Odaki writes: > On 2024/02/17 1:30, Alex Bennée wrote: >> We can only request a list of registers once the vCPU has been >> init

Re: [PATCH] qapi: Craft the BlockdevCreateOptionsLUKS comment

2024-02-21 Thread Markus Armbruster
Yong Huang writes: > On Wed, Feb 21, 2024 at 2:43 PM Markus Armbruster wrote: > >> Hyman Huang writes: >> >> > Add comment in detail for commit 433957bb7f (qapi: >> > Make parameter 'file' optional for >> > BlockdevCreateOptionsLUKS). >> > >> > Signed-off-by: Hyman Huang >> > --- >> > qapi/bl

[Stable-8.2.2 33/60] hw/cxl: Pass CXLComponentState to cache_mem_ops

2024-02-21 Thread Michael Tokarev
From: Li Zhijian cache_mem_ops.{read,write}() interprets opaque as CXLComponentState(cxl_cstate) instead of ComponentRegisters(cregs). Fortunately, cregs is the first member of cxl_cstate, so their values are the same. Fixes: 9e58f52d3f8 ("hw/cxl/component: Introduce CXL components (8.1.x, 8.2.

Re: [PATCH] vl, pc: turn -no-fd-bootchk into a machine property

2024-02-21 Thread Paolo Bonzini
On Tue, Feb 20, 2024 at 11:43 PM Bernhard Beschow wrote: > > > > Am 20. Februar 2024 15:53:52 UTC schrieb Paolo Bonzini : > >Add a fd-bootchk property to PC machine types, so that -no-fd-bootchk > >returns an error if the machine does not support booting from floppies > >and checking for boot sign

Re: [PATCH 3/5] hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines

2024-02-21 Thread BALATON Zoltan
On Wed, 21 Feb 2024, Mark Cave-Ayland wrote: On 18/02/2024 13:16, Bernhard Beschow wrote: Port 92 is an integral part of the PIIX and ICH south bridges, so instantiate it there. The isapc machine now needs to instantiate it explicitly, analoguous to the RTC. Note that due to migration compati

Re: [PATCH 2/5] hw/i386/port92: Allow for TYPE_PORT92 to be embedded in devices

2024-02-21 Thread Mark Cave-Ayland
On 18/02/2024 13:16, Bernhard Beschow wrote: Port 92 is an integral part of south bridges. Allow for embedding it there. South bridges aren't architecture-specific, so move port92.c to hw/isa which is accessible to other architectures than x86. Signed-off-by: Bernhard Beschow --- include/hw

Re: [PATCH V4 4/5] util: strList unit tests

2024-02-21 Thread Markus Armbruster
Steve Sistare writes: > Signed-off-by: Steve Sistare > Reviewed-by: Marc-André Lureau > --- > tests/unit/meson.build| 1 + > tests/unit/test-strList.c | 80 > +++ > 2 files changed, 81 insertions(+) > create mode 100644 tests/unit/test-strList

[RFC PATCH v2 05/22] target/arm: Support MSR access to ALLINT

2024-02-21 Thread Jinjie Ruan via
Support ALLINT msr access as follow: mrs , ALLINT// read allint msr ALLINT, // write allint with imm Signed-off-by: Jinjie Ruan --- target/arm/helper.c | 32 1 file changed, 32 insertions(+) diff --git a/target/arm/helper.c b/targ

[RFC PATCH v2 13/22] hw/intc/arm_gicv3: Add external IRQ lines for NMI

2024-02-21 Thread Jinjie Ruan via
Augment the GICv3's QOM device interface by adding one new set of sysbus IRQ line, to signal NMI to each CPU. Signed-off-by: Jinjie Ruan --- hw/intc/arm_gicv3_common.c | 3 +++ include/hw/intc/arm_gic_common.h | 1 + include/hw/intc/arm_gicv3_common.h | 1 + 3 files changed, 5 insertio

Re: [PATCH v4 11/34] migration/ram: Introduce 'fixed-ram' migration capability

2024-02-21 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> Add a new migration capability 'fixed-ram'. >> >> The core of the feature is to ensure that each RAM page has a specific >> offset in the resulting migration stream. The reasons why we'd want >> such behavior are: >> >> - The resulting file

[RFC PATCH v2 20/22] hw/intc/arm_gicv3: Add NMI handling CPU interface registers

2024-02-21 Thread Jinjie Ruan via
Add the NMIAR CPU interface registers which deal with acknowledging NMI. When introduce NMI interrupt, there are some updates to the semantics for the register ICC_IAR1_EL1 and ICC_HPPIR1_EL1. For ICC_IAR1_EL1 register, it should return 1022 if the intid has super priority. And for ICC_NMIAR1_EL1

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-21 Thread Philippe Mathieu-Daudé
On 20/2/24 20:25, Bernhard Beschow wrote: Am 19. Februar 2024 16:38:46 UTC schrieb "Philippe Mathieu-Daudé" : Expose TYPE_ICH_DMI_PCI_BRIDGE to the new "hw/pci-bridge/ich_dmi_pci.h" header. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + include/hw/pci-b

Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU

2024-02-21 Thread Zhao Liu
On Wed, Feb 21, 2024 at 01:41:35PM +0100, Markus Armbruster wrote: > Date: Wed, 21 Feb 2024 13:41:35 +0100 > From: Markus Armbruster > Subject: Re: [PATCH v8 00/21] Introduce smp.modules for x86 in QEMU > > Zhao Liu writes: > > > From: Zhao Liu > > > > Hi list, > > > > This is the our v8 patch

Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Fabiano Rosas
Steve Sistare writes: > Simplify the exec migration code by using list utility functions. > > As a side effect, this also fixes a minor memory leak. On function return, > "g_auto(GStrv) argv" frees argv and each element, which is wrong, because > the function does not own the individual elements

Re: [PATCH v2 0/2] Field 'reason' for MIGRATION event

2024-02-21 Thread Fabiano Rosas
Roman Khapov writes: Hi Roman, > This is resending of series 20240215082659.1378342-1-rkha...@yandex-team.ru, > where patch subjects numbers were broken in patch 2/2. > > Sometimes, when migration fails, it is hard to find out > the cause of the problems: you have to grep qemu logs. > At the sam

[PATCH] qga-win: Add support of Windows Server 2025 in get-osinfo command

2024-02-21 Thread Dehan Meng
Add support of Windows Server 2025 in get-osinfo command Signed-off-by: Dehan Meng --- qga/commands-win32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 697c65507c..f3c7e604c9 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@

[PATCH 1/1] qga/linux: Add new api 'guest-network-get-route'

2024-02-21 Thread Dehan Meng
v1 -> v2 - Replace snprintf() to g_strdup_printf() to avoid memory problems. - Remove the parameter 'char ipAddress[16]' in function 'char *hexToIPAddress()'. - Add a piece of logic to skip traversing the first line of the file Dehan Meng (1): qga/linux: Add new api 'guest-network-get-route'

Re: [PATCH] linux-user: Add FIFREEZE and FITHAW ioctls

2024-02-21 Thread Daniel P . Berrangé
Adding the linux-user maintainer to the CC list On Tue, Feb 20, 2024 at 11:57:21AM +0100, Michael Vogt wrote: > Add missing FIFREEZE and FITHAW ioctls. > > Signed-off-by: Michael Vogt > --- > linux-user/ioctls.h | 6 ++ > linux-user/syscall_defs.h | 3 +++ > 2 files changed, 9 inserti

[PULL 1/1] loongarch: Change the UEFI loading mode to loongarch

2024-02-21 Thread Song Gao
From: Xianglai Li The UEFI loading mode in loongarch is very different from that in other architectures:loongarch's UEFI code is in rom, while other architectures' UEFI code is in flash. loongarch UEFI can be loaded as follows: -machine virt,pflash=pflash0-format -bios ./QEMU_EFI.fd Other archi

Re: [PATCH v5 5/9] target/ppc: Simplify syscall exception handlers

2024-02-21 Thread Harsh Prateek Bora
On 1/19/24 03:31, BALATON Zoltan wrote: After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simpilfy this code. Also add "unlikely" to mark the less freqiently used branch for the compiler. Signed-off-by: BALATON Zoltan Ni

Re: [RFC PATCH 0/2] hw: Replace cpu_interrupt() calls by qemu_irq(QDev GPIO)

2024-02-21 Thread Mark Cave-Ayland
On 20/02/2024 19:26, Philippe Mathieu-Daudé wrote: Hi, cpu_interrupt() doesn't scale well with heterogenous machines because its mask is target specific (defined in target/ARCH/cpu.h). While it is (often...) used by target-specific hw to notify cpu, there is no restriction to use such target-s

[PATCH 1/6] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config()

2024-02-21 Thread Zhao Liu
From: Zhao Liu As the comment in qapi/error, dereferencing @errp requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: * - It must not be dereferenced, because it may be null. * - It should not be passed to error_pr

Re: [PATCH 5/6] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize()

2024-02-21 Thread Zhao Liu
On Wed, Feb 21, 2024 at 12:49:46PM +0100, Markus Armbruster wrote: > Date: Wed, 21 Feb 2024 12:49:46 +0100 > From: Markus Armbruster > Subject: Re: [PATCH 5/6] hw/pci-bridge/cxl_upstream: Fix missing > ERRP_GUARD() in cxl_usp_realize() > > Zhao Liu writes: > > > From: Zhao Liu > > > > As the

[Stable-8.2.2 37/60] tests/acpi: Allow update of DSDT.cxl

2024-02-21 Thread Michael Tokarev
From: Jonathan Cameron The _STA value returned currently indicates the ACPI0017 device is not enabled. Whilst this isn't a real device, setting _STA like this may prevent an OS from enumerating it correctly and hence from parsing the CEDT table. Signed-off-by: Jonathan Cameron Message-Id: <202

Re: [PATCH V4 5/5] migration: simplify exec migration functions

2024-02-21 Thread Markus Armbruster
Het Gala, Peter, or Fabiano, please review. Steve Sistare writes: > Simplify the exec migration code by using list utility functions. > > As a side effect, this also fixes a minor memory leak. On function return, > "g_auto(GStrv) argv" frees argv and each element, which is wrong, because > the

Re: [PATCH 1/6] hw/arm: Inline sysbus_create_simple(PL110 / PL111)

2024-02-21 Thread Mark Cave-Ayland
On 19/02/2024 13:35, Peter Maydell wrote: On Mon, 19 Feb 2024 at 13:33, Mark Cave-Ayland wrote: On 19/02/2024 13:05, Peter Maydell wrote: On Mon, 19 Feb 2024 at 12:49, Mark Cave-Ayland wrote: On 19/02/2024 12:00, BALATON Zoltan wrote: For new people trying to contribute to QEMU QDev is

[PATCH v4] pc: q35: Bump max_cpus to 4096 vcpus

2024-02-21 Thread Ani Sinha
Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow up to 4096 vCPUs") Linux kernel can support upto a maximum number of 4096 vCPUS when MAXSMP is enabled in the kernel. At present, QEMU has been tested to correctly boot a linux guest with 4096 vcpus with edk2 pending vario

Re: [PATCH 18/23] plugins: add an API to read registers

2024-02-21 Thread Akihiko Odaki
On 2024/02/21 19:02, Alex Bennée wrote: Akihiko Odaki writes: On 2024/02/20 23:14, Alex Bennée wrote: Akihiko Odaki writes: On 2024/02/17 1:30, Alex Bennée wrote: We can only request a list of registers once the vCPU has been initialised so the user needs to use either call the get functi

[Stable-8.2.2 32/60] hw/cxl/device: read from register values in mdev_reg_read()

2024-02-21 Thread Michael Tokarev
From: Hyeonggon Yoo <42.hye...@gmail.com> In the current mdev_reg_read() implementation, it consistently returns that the Media Status is Ready (01b). This was fine until commit 25a52959f99d ("hw/cxl: Add support for device sanitation") because the media was presumed to be ready. However, as per

Re: [PATCH v5 5/9] target/ppc: Simplify syscall exception handlers

2024-02-21 Thread Harsh Prateek Bora
On 1/19/24 03:31, BALATON Zoltan wrote: After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simpilfy this code. Also add "unlikely" to mark the less freqiently used branch for the compiler. Signed-off-by: BALATON Zoltan Re

[Stable-8.2.2 53/60] target/i386: Generate an illegal opcode exception on cmp instructions with lock prefix

2024-02-21 Thread Michael Tokarev
From: Ziqiao Kong target/i386: As specified by Intel Manual Vol2 3-180, cmp instructions are not allowed to have lock prefix and a `UD` should be raised. Without this patch, s1->T0 will be uninitialized and used in the case OP_CMPL. Signed-off-by: Ziqiao Kong Message-ID: <20240215095015.570748-

  1   2   3   4   5   >