Re: [PATCH 05/22] target/sparc: Inline FNEG, FABS

2024-01-30 Thread Philippe Mathieu-Daudé
On 3/11/23 18:38, Richard Henderson wrote: These are simple bit manipulation insns. Begin using i128 for float128. Implement FMOVq with do_qq. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 6 target/sparc/fop_helper.c | 34 - target/sparc/transla

RE: [PATCH v2] target/i386/host-cpu: Use iommu phys_bits with VFIO assigned devices on Intel h/w

2024-01-30 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, January 26, 2024 5:20 AM > > On Thu, 25 Jan 2024 09:18:02 +0100 > Eric Auger wrote: > > > Hi Vivek, > > > > On 1/18/24 20:20, Vivek Kasireddy wrote: > > > > > > +if (iommu_phys_bits && phys_bits > iommu_phys_bits) { > > > +phys_bits = iommu_phy

Re: [PATCH 15/22] target/sparc: Introduce cpu_get_fsr, cpu_put_fsr

2024-01-30 Thread Philippe Mathieu-Daudé
On 3/11/23 18:38, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 4 +++- target/sparc/helper.h | 1 + linux-user/sparc/cpu_loop.c | 2 +- linux-user/sparc/signal.c | 14 +- target/sparc/cpu.c | 5 +++-- target/s

Re: [PATCH 16/22] target/split: Split ver from env->fsr

2024-01-30 Thread Philippe Mathieu-Daudé
On 3/11/23 18:38, Richard Henderson wrote: This field is read-only. It is easier to store it separately and merge it only upon read. While we're at it, use FSR_VER_SHIFT to initialize fpu_version. Signed-off-by: Richard Henderson --- target/sparc/cpu.h| 3 +++ target/sparc/cpu.c

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote: > Check if a file argument is a cover letter patch produced by > git-format-patch --cover-letter; It is initialized with subject suffix " > *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > exist, warn the use

Re: [PATCH 01/33] include/hw/core: Add mmu_index to CPUClass

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 08:51, Richard Henderson wrote: On 1/30/24 17:46, Philippe Mathieu-Daudé wrote: Hi Richard, On 30/1/24 00:30, Richard Henderson wrote: To be used after all targets have populated the hook. Signed-off-by: Richard Henderson ---   include/hw/core/cpu.h | 3 +++   1 file changed, 3 ins

Re: [PATCH 32/33] include/exec: Implement cpu_mmu_index generically

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 00:30, Richard Henderson wrote: For user-only mode, use MMU_USER_IDX. For system mode, use CPUClass.mmu_index. Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 4 include/exec/cpu-common.h | 19 +++ target/alpha/cpu.h| 5 - targ

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Philippe Mathieu-Daudé
What is the rationale here? (I'm trying to generically understand in which case one is better than another). On 30/1/24 00:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 2 +- include/exec/cpu-common.h | 3 +-- target/sparc/cp

Re: [PATCH 00/33] hw/core: Introduce CPUClass hook for mmu_index

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 00:30, Richard Henderson wrote: While the primary use of mmu_index is for the softmmu index for system-mode tcg, it has a secondary use in encoding cpu state for the page table walker, and thus depending on the target may also be used by memory_rw_debug with kvm et al. This is why I p

Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 01:27, Stefan Hajnoczi wrote: The following expression is incorrect because blk_pread_nonzeroes() deals in units of bytes, not sectors: bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) ^^^ BDRV_REQUEST_MAX_BYTES is the appropr

Re: [PATCH v3 22/29] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Philippe Mathieu-Daudé
On 29/1/24 22:53, Daniel Henrique Barboza wrote: Hey Phil, This patch is giving me a conflict in target/riscv/cpu_helper.c when applying on top of master. Not sure if I'm missing any dependency. My 'master' was commit 7a1dc45af5. It's a trivial conflict though, just a FYI. As for the patch

Re: [PATCH v2 0/8] sparc/leon3: Add support for -smp

2024-01-30 Thread Clément Chigot
Hey Philippe, Gentle ping on this serie Thanks, Clément On Tue, Jan 16, 2024 at 2:02 PM Clément Chigot wrote: > > V2 modifications > - Patch1: Add SPDX copyright tags. > - Patch3: Add defines for MP_STATUS fields. Improve comments. > - Patch4: Improve a comment. > - Patch6: Dropped as alr

Re: [PATCH 05/22] target/sparc: Inline FNEG, FABS

2024-01-30 Thread Philippe Mathieu-Daudé
Hi Richard, On 3/11/23 18:38, Richard Henderson wrote: These are simple bit manipulation insns. Begin using i128 for float128. Implement FMOVq with do_qq. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 6 target/sparc/fop_helper.c | 34 - target/

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-30 Thread Peter Xu
On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: > >> +static MultiFDMethods multifd_socket_ops = { > >> +.send_setup = multifd_socket_send_setup, > >> +.send_cleanup = multifd_socket_sen

Re: [PATCH v2 1/8] sparc/grlib: split out the headers for each peripherals

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: ... and move them in their right hardware directory. Update Copyright and add SPDX-License-Identifier at the same time. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/char/grlib_apbuart.c | 6 ++-- hw/int

Re: [PATCH [repost]] block/blkio: Don't assume size_t is 64 bit

2024-01-30 Thread Kevin Wolf
Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben: > With GCC 14 the code failed to compile on i686 (and was wrong for any > version of GCC): > > ../block/blkio.c: In function ‘blkio_file_open’: > ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from > incompatible

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote: > > On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote: > > Check if a file argument is a cover letter patch produced by > > git-format-patch --cover-letter; It is initialized with subject suffix " > > *** SUBJECT HERE ***" a

Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-30 Thread lixianglai
Hi Andrea:     I'm sorry for taking so long to reply you! Hi Philippe:     When developing libvirt on loongarch, we encountered some problems related to pflash. libvirt and qemu met some difficulties in the coordination of UEFI loading. I think we need your suggestions and opinions on the s

Re: [PATCH v2 4/8] intc/grlib_irqmp: implements multicore irq

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: Now there is an ncpus property, use it in order to deliver the IRQ to multiple CPU. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/intc/grlib_irqmp.c | 43 ++- hw/sparc/leon3.c

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-01-30 Thread Daniel P . Berrangé
On Thu, Jan 25, 2024 at 08:22:14AM +0100, Anthony Harivel wrote: > Starting with the "Sandy Bridge" generation, Intel CPUs provide a RAPL > interface (Running Average Power Limit) for advertising the accumulated > energy consumption of various power domains (e.g. CPU packages, DRAM, > etc.). > > T

[PATCH v3] blockcommit: Reopen base image as RO after abort

2024-01-30 Thread Alexander Ivanov
If a blockcommit is aborted the base image remains in RW mode, that leads to a fail of subsequent live migration. How to reproduce: $ virsh snapshot-create-as vm snp1 --disk-only *** write something to the disk inside the guest *** $ virsh blockcommit vm vda --active --shallow && virsh blo

Re: [PATCH v2 7/8] leon3: check cpu_id in the tiny bootloader

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: Now that SMP is possible, the asr17 must be checked in the little boot code or the secondary CPU will reinitialize the Timer and the Uart. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/sparc/leon3.c | 22 --

Re: [PATCH] hw/hyperv: Include missing headers

2024-01-30 Thread Manos Pitsidianakis
On Mon, 29 Jan 2024 19:00, Philippe Mathieu-Daudé wrote: Include missing headers in order to avoid when refactoring unrelated headers: hw/hyperv/hyperv.c:33:18: error: field ‘msg_page_mr’ has incomplete type 33 | MemoryRegion msg_page_mr; | ^~~ hw/hyperv/

Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-30 Thread Chao Li
Hi All, Added my notes below. Thanks, Chao On 2024/1/30 16:59, lixianglai wrote: Hi Andrea:     I'm sorry for taking so long to reply you! Hi Philippe:     When developing libvirt on loongarch, we encountered some problems related to pflash. libvirt and qemu met some difficulties in the

Re: [PATCH v3 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-01-30 Thread Daniel P . Berrangé
On Thu, Jan 25, 2024 at 08:22:14AM +0100, Anthony Harivel wrote: > Starting with the "Sandy Bridge" generation, Intel CPUs provide a RAPL > interface (Running Average Power Limit) for advertising the accumulated > energy consumption of various power domains (e.g. CPU packages, DRAM, > etc.). > > T

Re: [PATCH v3 2/9] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support

2024-01-30 Thread Jonathan Cameron via
On Mon, 29 Jan 2024 09:32:39 -0800 fan wrote: > On Wed, Jan 24, 2024 at 02:51:18PM +, Jonathan Cameron wrote: > > On Tue, 7 Nov 2023 10:07:06 -0800 > > nifan@gmail.com wrote: > > > > > From: Fan Ni > > > > > > Per cxl spec 3.0, add dynamic capacity region representative based on > >

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote: > On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote: > > > > On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote: > > > Check if a file argument is a cover letter patch produced by > > > git-format-patch --co

Re: [PATCH v3 06/29] target: Replace CPU_GET_CLASS(cpu -> obj) in cpu_reset_hold() handler

2024-01-30 Thread Richard Henderson
On 1/30/24 02:44, Philippe Mathieu-Daudé wrote: Since CPU() macro is a simple cast, the following are equivalent: Object *obj; CPUState *cs = CPU(obj) In order to ease static analysis when running scripts/coccinelle/cpu_env.cocci from the previous commit, replace: - CPU_GET_CLASS(cpu);

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote: > > On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote: > > Check if a file argument is a cover l

Re: [PATCH v3 08/29] target/arm: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Richard Henderson
On 1/30/24 02:44, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/arm_gicv3_cpuif.c| 7 ++- hw/intc/arm_gicv3_cpuif_common.c | 5 +

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 11:54:51AM +0200, Manos Pitsidianakis wrote: > On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote: > > On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote: > > > On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé > > > wrote: > > > > > > > > On Tue, Jan 3

Re: [PATCH v3 11/29] target/hexagon: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Richard Henderson
On 1/30/24 02:44, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/cpu.c | 25 ++--- target/hexagon/gdbstub.c | 6 ++

Re: [PATCH v3 2/6] hw/arm/z2: convert DPRINTF to trace events and guest errors

2024-01-30 Thread Alex Bennée
Manos Pitsidianakis writes: > Tracing DPRINTFs to stderr might not be desired. A developer that relies > on trace events should be able to opt-in to each trace event and rely on > QEMU's log redirection, instead of stderr by default. > > This commit converts DPRINTFs in this file that are used fo

Re: [PATCH v3 3/6] hw/arm/xen_arm.c: convert DPRINTF to trace events and error/warn reports

2024-01-30 Thread Alex Bennée
Manos Pitsidianakis writes: > Tracing DPRINTFs to stderr might not be desired. A developer that relies > on trace events should be able to opt-in to each trace event and rely on > QEMU's log redirection, instead of stderr by default. > > This commit converts DPRINTFs in this file that are used fo

Re: [PATCH v3 4/6] hw/xen/xen-mapcache.c: convert DPRINTF to tracepoints

2024-01-30 Thread Alex Bennée
Manos Pitsidianakis writes: > Tracing DPRINTFs to stderr might not be desired. A developer that relies > on tracepoints should be able to opt-in to each tracepoint and rely on > QEMU's log redirection, instead of stderr by default. > > This commit converts DPRINTFs in this file that are used for

Re: [PATCH v3 5/6] hw/xen/xen-hvm-common.c: convert DPRINTF to tracepoints

2024-01-30 Thread Alex Bennée
Manos Pitsidianakis writes: > Tracing DPRINTFs to stderr might not be desired. A developer that relies > on tracepoints should be able to opt-in to each tracepoint and rely on > QEMU's log redirection, instead of stderr by default. > > This commit converts DPRINTFs in this file that are used for

Re: [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports

2024-01-30 Thread Alex Bennée
Manos Pitsidianakis writes: > According to the QEMU Coding Style document: > >> Do not use printf(), fprintf() or monitor_printf(). Instead, use >> error_report() or error_vreport() from error-report.h. This ensures the >> error is reported in the right place (current monitor or stderr), and in >

Re: [PATCH v3 14/29] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Richard Henderson
On 1/30/24 02:44, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h| 13 ++--- hw/i386/fw_cfg.c |

[PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is initialized with subject suffix " *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they exist, warn the user. Signed-off-by: Manos Pitsidianakis --- Range-diff against v1: 1: 64b7ec

Re: [PATCH v3 15/29] target/loongarch: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Richard Henderson
On 1/30/24 02:44, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/loongarch/cpu.c| 39 - target/loongarch/gdbstu

Re: [PATCH v2 6/6] target/i386: Add new CPU model GraniteRapids

2024-01-30 Thread Igor Mammedov
On Thu, 6 Jul 2023 13:49:49 +0800 Tao Su wrote: > The GraniteRapids CPU model mainly adds the following new features > based on SapphireRapids: > - PREFETCHITI CPUID.(EAX=7,ECX=1):EDX[bit 14] > - AMX-FP16 CPUID.(EAX=7,ECX=1):EAX[bit 21] it seems the list/definition is not complete, see https://

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: > Check if a file argument is a cover letter patch produced by > git-format-patch --cover-letter; It is initialized with subject suffix " > *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > exist, warn the use

Re: [PATCH v3 29/29] user: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-30 Thread Richard Henderson
On 1/30/24 02:45, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/signal.c | 3 +-- linux-user/signal.c | 6 ++ 2 files changed, 3 insertions(

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-30 Thread Peter Maydell
On Mon, 29 Jan 2024 at 23:31, Fabiano Rosas wrote: > > Fabiano Rosas writes: > > > Peter Xu writes: > > > >> On Fri, Jan 26, 2024 at 11:54:32AM -0300, Fabiano Rosas wrote: > > The issue that occurs to me now is that 'cpu host' will not work with > > TCG. We might actually need to go poking /dev/

Re: [PATCH v1] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 11:59, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 11:54:51AM +0200, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote: > On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 10:12, Daniel P.

Re: [PATCH v2 02/14] plugins: scoreboard API

2024-01-30 Thread Alex Bennée
Pierrick Bouvier writes: > On 1/26/24 19:14, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> We introduce a cpu local storage, automatically managed (and extended) >>> by QEMU itself. Plugin allocate a scoreboard, and don't have to deal >>> with how many cpus are launched. >>> >>> This AP

Re: Assistance Required for QEMU Hardfault Error with Cortex-M33 on MPS2AN505

2024-01-30 Thread Peter Maydell
On Tue, 30 Jan 2024 at 07:48, sanjana gogte wrote: > > I wanted to express my gratitude for your insightful solution concerning the > INVSTATE fault I was encountering. After recompiling my code with the -mthumb > compiler flag, the exception is no longer being raised, which marks a > significa

Re: [PATCH [repost]] block/blkio: Don't assume size_t is 64 bit

2024-01-30 Thread Richard W.M. Jones
On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote: > Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben: > > With GCC 14 the code failed to compile on i686 (and was wrong for any > > version of GCC): > > > > ../block/blkio.c: In function ‘blkio_file_open’: > > ../block/blkio.c:857:

Re: [PATCH v3 0/4] Live Migration Acceleration with IAA Compression

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 03:56:05AM +, Liu, Yuan1 wrote: > > -Original Message- > > From: Peter Xu > > Sent: Monday, January 29, 2024 6:43 PM > > To: Liu, Yuan1 > > Cc: faro...@suse.de; leob...@redhat.com; qemu-devel@nongnu.org; Zou, > > Nanhai > > Subject: Re: [PATCH v3 0/4] Live Mig

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is initialized with subject suffix " *** SUBJECT HERE ***" and body prefix

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Peter Maydell
On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis wrote: > > Check if a file argument is a cover letter patch produced by > git-format-patch --cover-letter; It is initialized with subject suffix " > *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > exist, warn the user. FWIW,

Re: [PATCH v8 1/5] ebpf: Added eBPF map update through mmap.

2024-01-30 Thread Daniel P . Berrangé
On Thu, Jan 25, 2024 at 03:06:50PM +0200, Andrew Melnychenko wrote: > Changed eBPF map updates through mmaped array. > Mmaped arrays provide direct access to map data. > It should omit using bpf_map_update_elem() call, > which may require capabilities that are not present. > > Signed-off-by: Andre

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > wrote: > > > > Check if a file argument is a cover letter patch produced by > > git-format-patch --cover-letter; It is initialized with subject suffix " > > *** SUBJECT HERE ***" and body pr

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Peter Maydell
On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote: > > > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > > wrote: > > > > > > Check if a file argument is a cover letter patch produced by > > > git-format-patch --cover-letter; It

Re: [PATCH v3 23/33] linux-user: Split out mmap_h_gt_g

2024-01-30 Thread Ilya Leoshkevich
On Tue, Jan 02, 2024 at 12:57:58PM +1100, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/mmap.c | 288 ++ > 1 file changed, 139 insertions(+), 149 deletions(-) > > diff --git a/linux-user/mmap.c b/linux-user/mmap.c > ind

Re: [PATCH v3 24/33] tests/tcg: Remove run-test-mmap-*

2024-01-30 Thread Ilya Leoshkevich
On Tue, Jan 02, 2024 at 12:57:59PM +1100, Richard Henderson wrote: > These tests are confused, because -p does not change > the guest page size, but the host page size. > > Signed-off-by: Richard Henderson > --- > tests/tcg/alpha/Makefile.target | 3 --- > tests/tcg/arm/Makefile.target

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 10:18:07AM +, Peter Maydell wrote: > On Mon, 29 Jan 2024 at 23:31, Fabiano Rosas wrote: > > > > Fabiano Rosas writes: > > > > > Peter Xu writes: > > > > > >> On Fri, Jan 26, 2024 at 11:54:32AM -0300, Fabiano Rosas wrote: > > > The issue that occurs to me now is that '

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > wrote: > > > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell > > wrote: > > > > > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > > > wrote: > > > > > > > > Check if a file argument i

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Peter Maydell
On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: > > > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > > wrote: > > > > > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell > > > wrote: > > > > > > > > On Tue, 30 Jan 2024 at 10:11

[PULL 0/4] Misc changes guest agent

2024-01-30 Thread Konstantin Kostiuk
The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into staging (2024-01-29 10:53:56 +) are available in the Git repository at: https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-01-30 f

[PULL 2/4] tests/unit/test-qga: do not qualify executable paths

2024-01-30 Thread Konstantin Kostiuk
From: Samuel Tardieu guest-exec invocation does not need the full path of the executable to execute. Using only the command names ensures correct execution of the test on systems not adhering to the FHS. Signed-off-by: Samuel Tardieu Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe Mathie

[PULL 1/4] guest-agent: improve help for --allow-rpcs and --block-rpcs

2024-01-30 Thread Konstantin Kostiuk
From: "Angel M. Villegas" Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757 Updates to qga help output and documentation for --allow-rpcs and --blocks-rpcs Signed-off-by: "Angel M. Villegas" Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- docs/interop/qemu-g

[PULL 3/4] qga-win: Fix guest-get-fsinfo multi-disks collection

2024-01-30 Thread Konstantin Kostiuk
From: Peng Ji When a volume has more than one disk, all disks cannot be returned correctly because there is not enough malloced memory for disk extents, so before executing DeviceIoControl for the second time, get the correct size of the required memory space to store all disk extents. Details:

[PULL 4/4] qga: Solaris has net/if_arp.h and netinet/if_ether.h but not ETHER_ADDR_LEN

2024-01-30 Thread Konstantin Kostiuk
From: Nick Briggs Solaris has net/if_arp.h and netinet/if_ether.h rather than net/ethernet.h, but does not define ETHER_ADDR_LEN, instead providing ETHERADDRL. Signed-off-by: Nick Briggs Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- qga/commands-posix.c | 5 - 1 f

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Manos Pitsidianakis
On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis > wrote: > > > > On Tue, 30 Jan 2024 at 12:42, Peter Maydell > > wrote: > > > > > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > > > wrote: > > > > > > > > On Tue, 30 Jan 2024 at 12:

Re: [PATCH 01/33] include/hw/core: Add mmu_index to CPUClass

2024-01-30 Thread Richard Henderson
On 1/30/24 18:20, Philippe Mathieu-Daudé wrote: Can the index ever be negative? No. Then why not return an unsigned type? The existing function didn't, and I didn't think about it. Does it really matter? r~

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Richard Henderson
On 1/30/24 18:26, Philippe Mathieu-Daudé wrote: What is the rationale here? (I'm trying to generically understand in which case one is better than another). Didn't you ask Anton why a generic cpu_* function was using CPUArchState? Anyway, I think we've generally used CPUState more often with g

[PATCH] target/riscv: Use RISCVException as return type for all csr ops

2024-01-30 Thread LIU Zhiwei
The real return value type has been converted to RISCVException, but some function declarations still not. This patch makes all csr operation declarations use RISCVExcetion. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 117 - 1 file changed, 74 i

[PATCH] target/riscv: FCSR doesn't contain vxrm and vxsat

2024-01-30 Thread LIU Zhiwei
vxrm and vxsat have been moved into a special register vcsr since RVV v1.0. So remove them from FCSR for vector 1.0. Signed-off-by: LIU Zhiwei --- target/riscv/cpu_bits.h | 8 1 file changed, 8 deletions(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index ebd7917d49

Re: [PATCH v2 02/14] plugins: scoreboard API

2024-01-30 Thread Pierrick Bouvier
On 1/30/24 14:23, Alex Bennée wrote: Pierrick Bouvier writes: On 1/26/24 19:14, Alex Bennée wrote: Pierrick Bouvier writes: We introduce a cpu local storage, automatically managed (and extended) by QEMU itself. Plugin allocate a scoreboard, and don't have to deal with how many cpus are lau

[PATCH] target/mips: Use qemu_irq typedef for CPUMIPSState::irq member

2024-01-30 Thread Philippe Mathieu-Daudé
Missed during commit d537cf6c86 ("Unify IRQ handling") when qemu_irq typedef was introduced for IRQState. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index 1163a71f3c..74408c

[PATCH 1/2] target/riscv: Register vendors CSR

2024-01-30 Thread LIU Zhiwei
riscv specification allows custom CSRs in decode area. So we should register all vendor CSRs in cpu realize stage. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c | 3 +++ target/riscv/tcg/tcg-cpu.c | 26 ++ target/riscv/tcg/tcg-cpu.h | 1 + 3 files changed, 30

[PATCH 0/2] target/riscv: Support mxstatus CSR for thead-c906

2024-01-30 Thread LIU Zhiwei
We first add a framework for vendor CSRs in patch 1. After that we add one thead-c906 CSR mxstatus, which is used for mmu extension xtheadmaee. This patch set fix the regression on kernel pointed by Björn Töpel in https://www.mail-archive.com/qemu-devel@nongnu.org/msg1018232.html. LIU Zhiwei (2):

[PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-01-30 Thread LIU Zhiwei
thead-c906 uses some flags in pte [60-63] bits. It has history reasons that SVPBMT didn't exist when thead-c906 came to world. We named this feature as xtheadmaee. this feature is controlled by an custom CSR named mxstatus, whose maee field encodes whether enable the pte [60-63] bits. The sectio

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Philippe Mathieu-Daudé
Hi Manos, On 30/1/24 12:02, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis wrote: On Tue, 30 Ja

Re: Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-30 Thread Andrea Bolognani
On Tue, Jan 30, 2024 at 04:59:53PM +0800, lixianglai wrote: > Hi Andrea: > >     I'm sorry for taking so long to reply you! No worries. In the meantime, I've been busy working on some of the enhancements the the libvirt code structure that I've mentioned during the previous round of review, and th

Re: [PATCH 01/33] include/hw/core: Add mmu_index to CPUClass

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 12:02, Richard Henderson wrote: On 1/30/24 18:20, Philippe Mathieu-Daudé wrote: Can the index ever be negative? No. Then why not return an unsigned type? The existing function didn't, and I didn't think about it. Does it really matter? No :)

Re: [PATCH 33/33] include/exec: Change cpu_mmu_index argument to CPUState

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 12:05, Richard Henderson wrote: On 1/30/24 18:26, Philippe Mathieu-Daudé wrote: What is the rationale here? (I'm trying to generically understand in which case one is better than another). Didn't you ask Anton why a generic cpu_* function was using CPUArchState? Anyway, I think we'

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Peter Maydell
On Tue, 30 Jan 2024 at 11:24, Philippe Mathieu-Daudé wrote: > > Hi Manos, > > On 30/1/24 12:02, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:57, Peter Maydell > > wrote: > >> > >> On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis > >> wrote: > >>> > >>> On Tue, 30 Jan 2024 at 12:42,

[PATCH 0/2] hw/sparc/leon3: Minor cleanups

2024-01-30 Thread Philippe Mathieu-Daudé
Minor cleanups noticed while reviewing Clément series: https://lore.kernel.org/qemu-devel/20240116130213.172358-1-chi...@adacore.com/ Philippe Mathieu-Daudé (2): target/sparc: Provide hint about CPUSPARCState::irq_manager member hw/sparc/leon3: Remove duplicated code target/sparc/cpu.h | 5 +

[PATCH 2/2] hw/sparc/leon3: Remove duplicated code

2024-01-30 Thread Philippe Mathieu-Daudé
Since commit b04d989054 ("SPARC: Emulation of Leon3") the main_cpu_reset() handler sets both pc/npc when the CPU is reset, after the machine is realized. It is pointless to set it in leon3_generic_hw_init(). Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 2 -- 1 file changed, 2 del

[PATCH 1/2] target/sparc: Provide hint about CPUSPARCState::irq_manager member

2024-01-30 Thread Philippe Mathieu-Daudé
CPUSPARCState::irq_manager holds a pointer to a QDev, so declare it as DeviceState instead of void. Move the comment about Leon3 fields. Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/cpu.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/sparc/cpu.h b/tar

Re: [PATCH v2 6/8] leon3: implement multiprocessor

2024-01-30 Thread Philippe Mathieu-Daudé
Hi Clément, On 16/1/24 14:02, Clément Chigot wrote: This allows to register more than one CPU on the leon3_generic machine. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/sparc/leon3.c | 106 +-- 1 file changed, 74 insertio

Re: [PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-01-30 Thread Christoph Müllner
On Tue, Jan 30, 2024 at 12:12 PM LIU Zhiwei wrote: > > thead-c906 uses some flags in pte [60-63] bits. It has history reasons that > SVPBMT didn't exist when thead-c906 came to world. > > We named this feature as xtheadmaee. this feature is controlled by an custom > CSR named mxstatus, whose maee

Re: [PATCH v2 5/8] target/sparc: implement asr17 feature for smp

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: This allows the guest program to know its cpu id. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot Reviewed-by: Richard Henderson --- target/sparc/helper.c| 16 target/sparc/helper.h| 1 + target/sparc/transla

Re: [PATCH v2 3/8] intc/grlib_irqmp: implements the multiprocessor status register

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: This implements the multiprocessor status register in grlib-irqmp and bind it to a start signal, which will be later wired in leon3-generic to start a cpu. The EIRQ and BA bits are not implemented. Based on https://gaisler.com/doc/gr712rc-usermanual.pdf,

Re: [PATCH v2 6/8] leon3: implement multiprocessor

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: This allows to register more than one CPU on the leon3_generic machine. Co-developed-by: Frederic Konrad Signed-off-by: Clément Chigot --- hw/sparc/leon3.c | 106 +-- 1 file changed, 74 insertions(+), 32 del

Re: [PATCH v2 0/8] sparc/leon3: Add support for -smp

2024-01-30 Thread Philippe Mathieu-Daudé
On 16/1/24 14:02, Clément Chigot wrote: V2 modifications - Patch1: Add SPDX copyright tags. - Patch3: Add defines for MP_STATUS fields. Improve comments. - Patch4: Improve a comment. - Patch6: Dropped as already merged. --- This series allows leon3 emulations to record up 4 CPUs. It re

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 12:30, Peter Maydell wrote: On Tue, 30 Jan 2024 at 11:24, Philippe Mathieu-Daudé wrote: Hi Manos, On 30/1/24 12:02, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 1

Re: [PATCH [repost]] block/blkio: Don't assume size_t is 64 bit

2024-01-30 Thread Kevin Wolf
Am 30.01.2024 um 11:30 hat Richard W.M. Jones geschrieben: > On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote: > > Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben: > > > With GCC 14 the code failed to compile on i686 (and was wrong for any > > > version of GCC): > > > > > > ../

Re: [PATCH [repost]] block/blkio: Don't assume size_t is 64 bit

2024-01-30 Thread Richard W.M. Jones
On Tue, Jan 30, 2024 at 01:04:46PM +0100, Kevin Wolf wrote: > Am 30.01.2024 um 11:30 hat Richard W.M. Jones geschrieben: > > On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote: > > > Am 29.01.2024 um 19:53 hat Richard W.M. Jones geschrieben: > > > > With GCC 14 the code failed to compile on

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Eugenio Perez Martin
On Mon, Jan 29, 2024 at 8:40 PM Stefan Hajnoczi wrote: > > On Mon, 29 Jan 2024 at 13:53, Eugenio Perez Martin > wrote: > > > > On Mon, Jan 15, 2024 at 5:33 PM Stefan Hajnoczi wrote: > > > > > > Dear QEMU and KVM communities, > > > QEMU will apply for the Google Summer of Code and Outreachy inte

Re: RE: [RESEND v2 1/2] hw/arm/virt-acpi-build.c: Migrate SPCR creation to common location

2024-01-30 Thread Andrew Jones
On Tue, Jan 30, 2024 at 03:16:34AM +, JeeHeng Sia wrote: ... > > I think either there should be a comment that this supports only v2 of > > SPCR spec or it should be able to create SPCR of any version. IMO, I > > think it is better to add support till v4 (latest). Since consumers like > > Linux

Re: [PATCH v2 7/8] leon3: check cpu_id in the tiny bootloader

2024-01-30 Thread Clément Chigot
On Tue, Jan 30, 2024 at 10:15 AM Philippe Mathieu-Daudé wrote: > > On 16/1/24 14:02, Clément Chigot wrote: > > Now that SMP is possible, the asr17 must be checked in the little boot code > > or the secondary CPU will reinitialize the Timer and the Uart. > > > > Co-developed-by: Frederic Konrad >

[PATCH v2] block/blkio: Make s->mem_region_alignment be 64 bits

2024-01-30 Thread Richard W.M. Jones
With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type [-Wincompatible-pointer-types] 857 |

Re: [PATCH v2 2/3] virtio-gpu.c: add resource_destroy class method

2024-01-30 Thread Marc-André Lureau
Hi On Mon, Jan 29, 2024 at 7:46 PM Manos Pitsidianakis wrote: > > When destroying/unrefing resources, devices such as virtio-gpu-rutabaga > need to do their own bookkeeping (free rutabaga resources that are > associated with the virtio_gpu_simple_resource). > > This commit adds a class method so

Re: [PATCH v2 3/3] virtio-gpu-rutabaga.c: override resource_destroy method

2024-01-30 Thread Marc-André Lureau
Hi On Mon, Jan 29, 2024 at 7:46 PM Manos Pitsidianakis wrote: > > When the Rutabaga GPU device frees resources, it calls > rutabaga_resource_unref for that resource_id. However, when the generic > VirtIOGPU functions destroys resources, it only removes the > virtio_gpu_simple_resource from the de

Re: RE: [RESEND v2 1/2] hw/arm/virt-acpi-build.c: Migrate SPCR creation to common location

2024-01-30 Thread Andrew Jones
On Tue, Jan 30, 2024 at 03:30:13AM +, JeeHeng Sia wrote: ... > > Sharing code is good, but if we have to parametrize the entire table, then > > we might as well keep Arm and RISCV separate. Building the table first > > with this struct, just to have it built again with the build_append API, > >

Re: [PATCH 16/22] target/split: Split ver from env->fsr

2024-01-30 Thread BALATON Zoltan
On Tue, 30 Jan 2024, Philippe Mathieu-Daudé wrote: On 3/11/23 18:38, Richard Henderson wrote: This field is read-only. It is easier to store it separately and merge it only upon read. While we're at it, use FSR_VER_SHIFT to initialize fpu_version. Signed-off-by: Richard Henderson --- targe

Re: [PATCH 2/4] isa: extract FDC37M81X to a separate file

2024-01-30 Thread Bernhard Beschow
Am 30. Januar 2024 07:48:50 UTC schrieb "Philippe Mathieu-Daudé" : >On 29/1/24 21:26, Paolo Bonzini wrote: >> On Mon, Jan 29, 2024 at 8:49 PM Bernhard Beschow wrote: >>> Don't we prefer a macro for below code? While touching the code we could >>> use it. (Sorry I can't recall its name from th

  1   2   3   >