[PATCH 20/29] scsi: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- scsi/qemu-pr-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index c6c6347e9b..b69dd982d6 100644 --- a/scsi/qemu-p

[PATCH 15/29] qga: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qga/commands-bsd.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 2 +- qga/commands.c | 2 +- qga/guest-agent-core.h | 2 +- qga/main.c | 6 +++---

[PATCH 07/29] docs: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- docs/devel/qapi-code-gen.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/qapi-code-gen.rst b/docs/devel/qapi-code-gen.rst index 7f78183cd4..580ff9cbe0

[PATCH 17/29] qom: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qom/object.c| 12 ++-- qom/object_interfaces.c | 8 qom/qom-hmp-cmds.c | 4 ++-- qom/qom-qmp-cmds.c | 4 ++-- 4 files changed, 14 insertions(+), 14

[PATCH 01/29] include: move include/qapi/qmp/ to include/qobject/

2024-01-08 Thread Daniel P . Berrangé
The general expectation is that header files should follow the same file/path naming scheme as the corresponding source file. There are various historical exceptions to this practice in QEMU, with one of the most notable being the include/qapi/qmp/ directory. Most of the headers there correspond to

[PATCH 25/29] tests: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- tests/qtest/adm1266-test.c| 4 ++-- tests/qtest/adm1272-test.c| 4 ++-- tests/qtest/ahci-test.c | 2 +- tests/qtest/arm-cpu-features.c

[PATCH 08/29] dump: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- dump/dump-hmp-cmds.c | 2 +- dump/dump.c | 2 +- dump/win_dump.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cm

[PATCH 23/29] system: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- system/balloon.c | 2 +- system/cpus.c | 2 +- system/device_tree.c | 2 +- system/dirtylimit.c| 2 +- system/qdev-monitor.c | 8 system/r

[PATCH 05/29] backends: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- backends/cryptodev-hmp-cmds.c | 2 +- backends/cryptodev-vhost-user.c | 2 +- backends/dbus-vmstate.c | 2 +- backends/iommufd.c | 2 +- backends/rng-egd.c

[PATCH 00/29] include: move include/qapi/qmp/ to include/qobject/

2024-01-08 Thread Daniel P . Berrangé
To repeat the 1st patch commit message... The general expectation is that header files should follow the same file/path naming scheme as the corresponding source file. There are various historical exceptions to this practice in QEMU, with one of the most notable being the include/qapi/qmp/ directo

[PATCH 14/29] qapi: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- qapi/opts-visitor.c | 2 +- qapi/qapi-clone-visitor.c | 2 +- qapi/qapi-dealloc-visitor.c | 2 +- qapi/qapi-forward-visitor.c | 16 qapi/qapi-util.c

[PATCH 12/29] monitor: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- monitor/fds.c | 2 +- monitor/hmp-cmds-target.c | 2 +- monitor/hmp-cmds.c | 2 +- monitor/hmp.c | 4 ++-- monitor/monitor-internal.h | 4 ++-- monitor/mo

[PATCH 04/29] block: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- block.c | 8 block/blkdebug.c | 6 +++--- block/blkio.c| 2 +- block/blklogwrites.c | 4

[PATCH 18/29] replay: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- replay/replay-debugging.c | 2 +- replay/replay-snapshot.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c inde

[PATCH 03/29] authz: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- authz/listfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/authz/listfile.c b/authz/listfile.c index 45a60e987d..d31d9103f7 100644 --- a/authz/listfile.c +++ b

[PATCH 02/29] audio: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- audio/audio-hmp-cmds.c | 2 +- audio/audio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/audio-hmp-cmds.c b/audio/audio-hmp-cmds.c index c9608b715b

[PATCH 09/29] hw: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- hw/arm/mps2-tz.c | 2 +- hw/arm/mps2.c| 2 +- hw/arm/sbsa-ref.c| 2 +- hw/arm/stellaris.c | 2 +- hw/arm/vexpress.c

[PATCH 26/29] trace: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- trace/trace-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/trace-hmp-cmds.c b/trace/trace-hmp-cmds.c index 86211fce27..c561b18e23 100644 --- a/trace/tr

[PATCH 11/29] migration: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- migration/dirtyrate.c | 2 +- migration/migration-hmp-cmds.c | 2 +- migration/migration.c | 4 ++-- migration/migration.h | 2 +- migration/options.c

[PATCH 24/29] target: adapt to new import path for qobject data type headers

2024-01-08 Thread Daniel P . Berrangé
The qobject data type headers have moved from qapi/qmp/ to qobject/. Signed-off-by: Daniel P. Berrangé --- target/arm/arm-qmp-cmds.c | 4 ++-- target/i386/cpu-sysemu.c | 2 +- target/i386/cpu.c | 2 +- target/i386/monitor.c | 2 +- tar

Re: [PATCH] softmmu: remove obsolete comment about libvirt timeouts

2024-01-08 Thread Daniel P . Berrangé
On Wed, Jan 03, 2024 at 10:49:20PM +0800, Zhao Liu wrote: > On Wed, Jan 03, 2024 at 12:30:42PM +, Daniel P. Berrangé wrote: > > Date: Wed, 3 Jan 2024 12:30:42 + > > From: "Daniel P. Berrangé" > > Subject: [PATCH] softmmu: remove obsolete comment about libvirt timeouts > > > > For a long

Re: [PATCH v1 1/2] oslib-posix: refactor memory prealloc threads

2024-01-08 Thread Mark Kanda
On 1/8/24 9:40 AM, David Hildenbrand wrote: On 08.01.24 16:10, Mark Kanda wrote: Refactor the memory prealloc threads support: - Make memset context a global qlist - Move the memset thread join/cleanup code to a separate routine This is functionally equivalent and facilitates multiple memset co

Re: [PATCH 01/29] include: move include/qapi/qmp/ to include/qobject/

2024-01-08 Thread Daniel P . Berrangé
On Mon, Jan 08, 2024 at 06:23:37PM +, Daniel P. Berrangé wrote: > The general expectation is that header files should follow the same > file/path naming scheme as the corresponding source file. There are > various historical exceptions to this practice in QEMU, with one of > the most notable be

[PATCH v2 2/2] nubus: add nubus-virtio-mmio device

2024-01-08 Thread Mark Cave-Ayland
The nubus-virtio-mmio device is a Nubus card that contains a set of 32 virtio-mmio devices and a goldfish PIC similar to the m68k virt machine that can be plugged into the m68k q800 machine. There are currently a number of drivers under development that can be used in conjunction with this device

[PATCH v2 0/2] nubus: add nubus-virtio-mmio device

2024-01-08 Thread Mark Cave-Ayland
This series introduces a new nubus-virtio-mmio device which can be plugged into the q800 machine to enable a 68k Classic MacOS guest to access virtio devices such as virtio-9p-device (host filesharing), virtio-gpu (extended framebuffer support) and virtio-tablet-device (absolute positioning). Once

[PATCH v2 1/2] nubus-device: round Declaration ROM memory region address to qemu_target_page_size()

2024-01-08 Thread Mark Cave-Ayland
Declaration ROM binary images can be any arbitrary size, however if a host ROM memory region is not aligned to qemu_target_page_size() then we fail the "assert(!(iotlb & ~TARGET_PAGE_MASK))" check in tlb_set_page_full(). Ensure that the host ROM memory region is aligned to qemu_target_page_size()

Re: [PATCH 1/2] nubus-device: round Declaration ROM memory region address to qemu_target_page_size()

2024-01-08 Thread Mark Cave-Ayland
On 08/01/2024 13:17, Philippe Mathieu-Daudé wrote: On 8/1/24 13:46, Mark Cave-Ayland wrote: On 08/01/2024 12:01, Philippe Mathieu-Daudé wrote: On 7/1/24 22:25, Mark Cave-Ayland wrote: Declaration ROM binary images can be any arbitrary size, however if a host ROM memory region is not aligned

Re: [External] Re: [PATCH 3/5] migration: Introduce unimplemented 'qatzip' compression method

2024-01-08 Thread Fabiano Rosas
Hao Xiang writes: > On Fri, Jan 5, 2024 at 3:52 PM Hao Xiang wrote: >> >> On Fri, Jan 5, 2024 at 12:07 PM Fabiano Rosas wrote: >> > >> > Bryan Zhang writes: >> > >> > +cc Yuan Liu, Daniel Berrangé >> > >> > > Adds support for 'qatzip' as an option for the multifd compression >> > > method para

RE: [External] Re: [PATCH 3/5] migration: Introduce unimplemented 'qatzip' compression method

2024-01-08 Thread Fabiano Rosas
"Liu, Yuan1" writes: >> -Original Message- >> From: Hao Xiang >> Sent: Saturday, January 6, 2024 7:53 AM >> To: Fabiano Rosas >> Cc: Bryan Zhang ; qemu-devel@nongnu.org; >> marcandre.lur...@redhat.com; pet...@redhat.com; quint...@redhat.com; >> peter.mayd...@linaro.org; Liu, Yuan1 ; >>

Re: [PATCH v4 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 13:59:44 UTC schrieb BALATON Zoltan : >On Sat, 6 Jan 2024, Bernhard Beschow wrote: >> The VIA south bridges are able to relocate and toggle (enable or disable) >> their >> SuperI/O functions. So far this is hardcoded such that all functions are >> always >> enabled and are lo

Re: [PATCH v4 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 14:13:44 UTC schrieb Mark Cave-Ayland : >On 06/01/2024 21:05, Bernhard Beschow wrote: > >> This series implements relocation of the SuperI/O functions of the VIA south >> bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t >> branch [1] which is an extens

Re: [PATCH v4 10/11] hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions

2024-01-08 Thread Bernhard Beschow
Am 7. Januar 2024 13:54:57 UTC schrieb BALATON Zoltan : >On Sat, 6 Jan 2024, Bernhard Beschow wrote: >> This is a preparation for implementing relocation and toggling of SuperI/O >> functions in the VT8231 device model. Upon reset, all SuperI/O functions >> will be >> deactivated, so in case if

Re: [PATCH v3 01/20] multifd: Add capability to enable/disable zero_page

2024-01-08 Thread Fabiano Rosas
Hao Xiang writes: > From: Juan Quintela > > We have to enable it by default until we introduce the new code. > > Signed-off-by: Juan Quintela > --- > migration/options.c | 15 +++ > migration/options.h | 1 + > qapi/migration.json | 8 +++- > 3 files changed, 23 insertions(+)

[PATCH v3 34/46] hw/microblaze: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/microblaze/petalogix_ml605_mmu.c | 3 +-- hw/microblaze/petalogix_s3adsp1800_mmu.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c

[PATCH v3 16/46] hw/ppc/spapr: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Avoid directly referencing nd_table[] by first instantiating any spapr-vlan devices using a qemu_get_nic_info() loop, then calling pci_init_nic_devices() to do the rest. No functional change intended. Signed-off-by: David Woodhouse --- hw/ppc/spapr.c | 18 +--

[PATCH v3 18/46] hw/sh4/r2d: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Previously, the first PCI NIC would be assigned to slot 2 even if the user override the model and made it something other than an rtl8139 which is the default. Everything else would be dynamically assigned. Now, the first rtl8139 gets slot 2 and everything else is dynamic.

[PATCH v3 30/46] hw/arm: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/mps2-tz.c | 8 ++-- hw/arm/msf2-soc.c| 6 +- hw/arm/musicpal.c| 3 +-- hw/arm/xilinx_zynq.c | 11 --- hw/arm/xlnx-versal.c | 7 +-- hw/arm/xlnx-zynqmp.c | 8 +--- 6 files changed, 10 inserti

[PATCH v3 21/46] hw/arm/allwinner: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/allwinner-a10.c | 6 +- hw/arm/allwinner-h3.c | 6 +- hw/arm/allwinner-r40.c | 27 ++- 3 files changed, 4 insertions(+), 35 deletions(-) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10

[PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling pci_init_nic_devices() for the rest. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/pc.c| 26 --

[PATCH v3 44/46] hw/pci: remove pci_nic_init_nofail()

2024-01-08 Thread David Woodhouse
From: David Woodhouse This function is no longer used. Signed-off-by: David Woodhouse --- hw/pci/pci.c | 72 include/hw/pci/pci.h | 3 -- 2 files changed, 75 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 5849606f66..449abfb18

[PATCH v3 13/46] hw/mips/malta: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse The Malta board setup code would previously place the first NIC into PCI slot 11 if was a PCNet card, and the rest (including the first if it was anything other than a PCNet card) would be dynamically assigned. Now it will place any PCNet NIC into slot 11, and then anything

[PATCH v3 42/46] hw/xtensa/xtfpga: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xtensa/xtfpga.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.c index fbad1c83a3..f49e6591dc 100644 --- a/hw/xtensa/xtfpga.c +++ b/hw/xtensa/xtfpga.c @@ -141,14

[PATCH v3 02/46] net: report list of available models according to platform

2024-01-08 Thread David Woodhouse
From: David Woodhouse By noting the models for which a configuration was requested, we can give the user an accurate list of which NIC models were actually available on the platform/configuration that was otherwise chosen. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- net/net.c

[PATCH v3 39/46] hw/riscv: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/riscv/microchip_pfsoc.c | 14 ++ hw/riscv/sifive_u.c| 7 +-- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/hw/riscv/microchip_pfsoc.c b/hw/riscv/microchip_pfsoc.c index b775aa8946..7725dfbde5

[PATCH v3 12/46] hw/mips/fuloong2e: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse The previous behaviour was: *if* the first NIC specified on the command line was an RTL8139 (or unspecified model) then it gets assigned to PCI slot 7, which is where the Fuloong board had an RTL8139. All other devices (including the first, if it was specified a anything oth

[PATCH v3 24/46] hw/arm/fsl: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/fsl-imx25.c | 2 +- hw/arm/fsl-imx6.c | 2 +- hw/arm/fsl-imx6ul.c | 2 +- hw/arm/fsl-imx7.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c index 9d2fb75a68..a24fa

[PATCH v3 09/46] hw/arm/virt: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 2793121cb4..8cf9237001 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1454,9 +1454,7 @@ static void create_pcie(V

[PATCH v3 22/46] hw/arm/aspeed: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/aspeed.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index cc59176563..bed5e4f40b 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -356,7 +356,6 @@ static void

[PATCH v3 41/46] hw/sparc/sun4m: use qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Obtain the MAC address from the NIC configuration if there is one, or generate one explicitly so that it can be placed in the PROM. Signed-off-by: David Woodhouse --- hw/sparc/sun4m.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH v3 20/46] hw/xtensa/virt: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/xtensa/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xtensa/virt.c b/hw/xtensa/virt.c index a6cf646e99..5310a88861 100644 --- a/hw/xtensa/virt.c +++ b/hw/xtensa/virt.c @@ -102,9 +102,7 @@ static void

[PATCH v3 46/46] net: make nb_nics and nd_table[] static in net/net.c

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- include/net/net.h | 4 net/net.c | 3 +++ system/globals.c | 2 -- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 19fb82833c..766201c62c 100644 --- a/include/net/ne

[PATCH v3 07/46] hw/alpha/dp264: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/alpha/dp264.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index 03495e1e60..52a1fa310b 100644 --- a/hw/alpha/dp264.c +++ b/hw/alpha/dp264.c @@ -124,9 +124,7 @@ static void

[PATCH v3 11/46] hw/loongarch: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/loongarch/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 4b7dc67a2d..c48804ac38 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -504,9 +504,7

[PATCH v3 17/46] hw/ppc: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/ppc/e500.c | 4 +--- hw/ppc/mac_newworld.c | 4 +--- hw/ppc/mac_oldworld.c | 4 +--- hw/ppc/ppc440_bamboo.c | 14 +- 4 files changed, 8 insertions(+), 18 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.

[PATCH v3 08/46] hw/arm/sbsa-ref: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Leif Lindholm --- hw/arm/sbsa-ref.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 477dca0637..f0171176ea 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c

[PATCH v3 06/46] hw/xen: use qemu_create_nic_bus_devices() to instantiate Xen NICs

2024-01-08 Thread David Woodhouse
From: David Woodhouse When instantiating XenBus itself, for each NIC which is configured with either the model unspecified, or set to to "xen" or "xen-net-device", create a corresponding xen-net-device for it. Now we can revert the previous more hackish version which relied on the platform code

[PATCH v3 29/46] hw/arm/stellaris: use qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Rather than just using qemu_configure_nic_device(), populate the MAC address in the system-registers device by peeking at the NICInfo before it's assigned to the device. Generate the MAC address early, if there is no matching -nic option. Otherwise the MAC address wouldn't

[PATCH v3 32/46] hw/m68k/mcf5208: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/m68k/mcf5208.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index d22d8536db..0cfb806c20 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -206,1

[PATCH v3 04/46] hw/pci: add pci_init_nic_devices(), pci_init_nic_in_slot()

2024-01-08 Thread David Woodhouse
From: David Woodhouse The loop over nd_table[] to add PCI NICs is repeated in quite a few places. Add a helper function to do it. Some platforms also try to instantiate a specific model in a specific slot, to match the real hardware. Add pci_init_nic_in_slot() for that purpose. Signed-off-by: D

[PATCH v3 35/46] hw/mips/mipssim: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse The MIPS SIM platform instantiates its NIC only if a corresponding configuration exists for it. Use qemu_create_nic_device() function for that. Signed-off-by: David Woodhouse --- hw/mips/mipssim.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff -

[PATCH v3 33/46] hw/m68k/q800: use qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse If a corresponding NIC configuration was found, it will have a MAC address already assigned, so use that. Else, generate and assign a default one. Using qemu_find_nic_info() is simpler than the alternative of using qemu_configure_nic_device() and then having to fetch the "m

[PATCH v3 19/46] hw/sparc64/sun4u: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse The first sunhme NIC gets placed a function 1 on slot 1 of PCI bus A, and the rest are dynamically assigned on PCI bus B. Previously, any PCI NIC would get the special treatment purely by virtue of being first in the list. Signed-off-by: David Woodhouse --- hw/sparc64/su

[PATCH v3 14/46] hw/mips/loongson3_virt: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/mips/loongson3_virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c index 33eae01eca..caedde2df0 100644 --- a/hw/mips/loongson3_virt.c +++ b/hw/mips/loongson3

[PATCH v3 00/46] Rework matching of network devices to -nic options

2024-01-08 Thread David Woodhouse
Most platforms iterating directly over the nd_table[] are doing one of two things. Either they are creating the NIC for their platform and want to find a matching -nic configuration for it, if such exists. Or they are only going to create that platform NIC if a matching config *does* exist. All

[PATCH v3 37/46] hw/net/lasi_i82596: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/net/lasi_i82596.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/lasi_i82596.c b/hw/net/lasi_i82596.c index 6a3147fe2d..2bb4f2c4ca 100644 --- a/hw/net/lasi_i82596.c +++ b/hw/net/lasi_i82596.c @@ -125,11 +1

[PATCH v3 28/46] hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases

2024-01-08 Thread David Woodhouse
From: David Woodhouse Also update the test to specify which device to attach the test socket to, and remove the comment lamenting the fact that we can't do so. Signed-off-by: David Woodhouse --- hw/arm/npcm7xx.c | 16 +--- tests/qtest/npcm7xx_emc-test.c | 18 -

[PATCH v3 27/46] hw/arm/highbank: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/highbank.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index c21e18d08f..6a0e20e58d 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -296,19 +296,1

[PATCH v3 15/46] hw/ppc/prep: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Previously, the first PCI NIC would be placed in PCI slot 3 and the rest would be dynamically assigned. Even if the user overrode the default NIC type and made it something other than PCNet. Now, the first PCNet NIC (that is, anything not explicitly specified to be anything

[PATCH v3 10/46] hw/hppa: use pci_init_nic_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/hppa/machine.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index c8da7c18d5..19d477105e 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -338,7 +338,6 @@ sta

Re: [PATCH v4 11/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread BALATON Zoltan
On Mon, 8 Jan 2024, Bernhard Beschow wrote: Am 7. Januar 2024 13:59:44 UTC schrieb BALATON Zoltan : On Sat, 6 Jan 2024, Bernhard Beschow wrote: The VIA south bridges are able to relocate and toggle (enable or disable) their SuperI/O functions. So far this is hardcoded such that all functions ar

[PATCH v3 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/s390x/s390-virtio-ccw.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 1169e20b94..202c378131 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/

[PATCH v3 26/46] hw/net/lan9118: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preseve the existing behaviour for now. Signed-off-by: David Woodhouse --- hw/arm/kzm.c | 4 ++-- hw/arm/mps2

[PATCH v3 31/46] hw/net/etraxfs-eth: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/cris/axis_dev88.c | 9 - hw/net/etraxfs_eth.c | 5 ++--- include/hw/cris/etraxfs.h | 2 +- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index d82050d927..5

[PATCH v3 03/46] net: add qemu_create_nic_bus_devices()

2024-01-08 Thread David Woodhouse
From: David Woodhouse This will instantiate any NICs which live on a given bus type. Each bus is allowed *one* substitution (for PCI it's virtio → virtio-net-pci, for Xen it's xen → xen-net-device; no point in overengineering it unless we actually want more). Signed-off-by: David Woodhouse Revi

[PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preserve the existing behaviour for now. Signed-off-by: David Woodhouse --- hw/arm/gumstix.c | 6 ++ hw/ar

[PATCH v3 45/46] net: remove qemu_show_nic_models(), qemu_find_nic_model()

2024-01-08 Thread David Woodhouse
From: David Woodhouse These old functions can be removed now too. Let net_param_nic() print the full set of network devices directly, and also make it note that a list more specific to this platform/config will be available by using '-nic model=help' instead. Signed-off-by: David Woodhouse ---

[PATCH v3 23/46] hw/arm/exynos4: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/arm/exynos4_boards.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index b0e13eb4f0..003992189b 100644 --- a/hw/arm/exynos4_boards.c +++ b/hw/arm/exynos4_boa

[PATCH v3 36/46] hw/mips/jazz: use qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Extract the MAC address from the NICInfo, or generate one explicitly if there was no corresponding NIC configuration, to put it in the PROM. Signed-off-by: David Woodhouse --- hw/mips/jazz.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH v3 43/46] net: remove qemu_check_nic_model()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- include/net/net.h | 1 - net/net.c | 13 - 2 files changed, 14 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 31e63d1f0d..1be8b40074 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -2

[PATCH v3 38/46] hw/openrisc/openrisc_sim: use qemu_create_nic_device()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/openrisc/openrisc_sim.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index 35da123aef..bffd6f721f 100644 --- a/hw/openrisc/openrisc_sim.c

[PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-08 Thread David Woodhouse
From: David Woodhouse Most code which directly accesses nd_table[] and nb_nics uses them for one of two things. Either "I have created a NIC device and I'd like a configuration for it", or "I will create a NIC device *if* there is a configuration for it". With some variants on the theme around w

Re: [PATCH 3/6] linux-user: Add code for PR_GET/SET_UNALIGN

2024-01-08 Thread Richard Henderson
On 1/9/24 04:15, Philippe Mathieu-Daudé wrote: +/* + * This can't go in hw/core/cpu.c because that file is compiled only + * once for both user-mode and system builds. + */   static Property cpu_common_props[] = { -#ifndef CONFIG_USER_ONLY +#ifdef CONFIG_USER_ONLY   /* - * Create a memory

Re: [PATCH] util: fix build with musl libc on ppc64le

2024-01-08 Thread Richard Henderson
On 1/5/24 03:26, Philippe Mathieu-Daudé wrote: Hi Natanael, On 19/12/23 11:51, Natanael Copa wrote: Use PPC_FEATURE2_ISEL and PPC_FEATURE2_VEC_CRYPTO from linux headers instead of the GNU specific PPC_FEATURE2_HAS_ISEL and PPC_FEATURE2_HAS_VEC_CRYPTO. This fixes build with musl libc. Fixes: 62

Re: [PATCH-for-9.0] accel/tcg: Remove tb_invalidate_phys_page() from system emulation

2024-01-08 Thread Richard Henderson
On 12/1/23 07:56, Philippe Mathieu-Daudé wrote: Since previous commit, tb_invalidate_phys_page() is not used anymore in system emulation. Make it static for user emulation and remove its public declaration in "exec/translate-all.h". Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <202311302

Re: [PATCH v6 3/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-08 Thread Philippe Mathieu-Daudé
Hi Inès, On 8/1/24 19:03, Inès Varhol wrote: Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 590 ++ 2 files changed, 595 insertions(+) creat

Re: [PATCH v2 00/35] tcg: Introduce TCG_COND_TST{EQ,NE}

2024-01-08 Thread Richard Henderson
On 1/7/24 04:43, Paolo Bonzini wrote: On Sat, Oct 28, 2023 at 9:45 PM Richard Henderson wrote: Expose a pair of comparison operators that map to the "test" comparison that is available on many architectures. Changes for v2: * Add TCGCond to tcg_target_const_match. This fixes a long-st

Re: [PATCH 1/2] tracetool: remove redundant --target-type / --target-name args

2024-01-08 Thread John Snow
On Mon, Jan 8, 2024 at 12:14 PM Daniel P. Berrangé wrote: > > The --target-type and --target-name args are used to construct > the default probe prefix if '--probe-prefix' is not given. The > meson.build will always pass '--probe-prefix', so the other args > are effectively redundant. > > Signed-o

Re: [PATCH v4 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions

2024-01-08 Thread Mark Cave-Ayland
On 08/01/2024 20:07, Bernhard Beschow wrote: Am 7. Januar 2024 14:13:44 UTC schrieb Mark Cave-Ayland : On 06/01/2024 21:05, Bernhard Beschow wrote: This series implements relocation of the SuperI/O functions of the VIA south bridges which resolves some FIXME's. It is part of my via-apollo-pr

[PATCH v10 10/10] tests/qtest: Adding PCS Module test to GMAC Qtest

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff -

[PATCH v10 01/10] hw/misc: Add Nuvoton's PCI Mailbox Module

2024-01-08 Thread Nabih Estefan
From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

[PATCH v10 00/10] Implementation of NPI Mailbox and GMAC Networking Module

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v9] More cleanup and fixes based on suggestions from Peter Maydell (peter.mayd...@linaro.org) suggestions. [Changes since v8] Suggestions and Fixes from Peter Maydell (peter.mayd...@linaro.org), also cleaned up changes so nothing is deleted in a later patc

[PATCH v10 05/10] hw/arm: Add GMAC devices to NPCM7XX SoC

2024-01-08 Thread Nabih Estefan
From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletion

[PATCH v10 09/10] hw/net: GMAC Tx Implementation

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC.

[PATCH v10 06/10] tests/qtest: Creating qtest for GMAC Module

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 + tests/qtest/

[PATCH v10 02/10] hw/arm: Add PCI mailbox module to Nuvoton SoC

2024-01-08 Thread Nabih Estefan
From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I14c42c628258804030f0583889882842bde0d972 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 2 ++ include/hw/arm/npc

[PATCH v10 04/10] hw/net: Add NPCMXXX GMAC device

2024-01-08 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmm

[PATCH v10 03/10] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2024-01-08 Thread Nabih Estefan
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 Signed-off-by: Hao Wu Signed-off-by: Nabih Estef

[PATCH v10 08/10] hw/net: GMAC Rx Implementation

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP N

[PATCH v10 07/10] include/hw/net: GMAC IRQ Implementation

2024-01-08 Thread Nabih Estefan
From: Nabih Estefan Diaz Implement Update IRQ Method for GMAC functionality. Added relevant trace-events Change-Id: I7a2d3cd3f493278bcd0cf483233c1e05c37488b7 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/net/npcm_gmac.c | 40 hw/net/tr

testing without the translation cache

2024-01-08 Thread Brian Cain
Alex, A very long time ago QEMU supported disabling the translation cache via "-translation no-cache". That option was deliberately removed. We are looking into a hexagon-specific failure when there's a TB lookup miss from a cpu_loop_exit_restore().I'd like to test our fix for this failur

<    1   2   3   4   >