Fair enough. After all of this, I'm inclined to turn this into a proper
error and deny not page aligned sizes. There's no real benefit in having
them and furthermore, the original bug report is about cryptic error
message.
I guess if we glue this to compat machines we should be definitely fi
On Mon, 4 Dec 2023 at 13:37, Michal Suchánek wrote:
>
> Hello,
>
> When running a VM with libvirt I get:
>
> /usr/bin/qemu-system-ppc64 --version
> QEMU emulator version 8.1.3 (Virtualization / 15.5)
> Copyright (c) 2003-2023 Fabrice Bellard and the QEMU Project developers
>
> /usr/bin/qemu-system
From: Inès Varhol
Signed-off-by: Arnaud Minier
Signed-off-by: Inès Varhol
---
hw/arm/Kconfig| 1 +
hw/arm/stm32l4x5_soc.c| 65 +++-
hw/misc/Kconfig | 3 +
hw/misc/meson.build | 1 +
hw/misc/stm32l4x5_exti.c | 306 +
This patch allows to emulate the STM32L4x5 EXTI device.
It implements register access and software interruptions.
This is RFC because we're new at contributing to QEMU.
We had some difficulties writing qtests and the result might be bizarre.
We have some questions about the next steps for our stm
Hi Jeuk,
On 4/12/23 17:50, Philippe Mathieu-Daudé wrote:
On 4/12/23 16:05, Akinobu Mita wrote:
QEMU would not start when trying to create two UFS host controllers and
a UFS logical unit for each with the following options:
-device ufs,id=bus0 \
-device ufs-lu,drive=drive1,bus=bus0,lun=0 \
-dev
On 11/29/23 14:03, Max Chou wrote:
The ratified version of RISC-V V spec section 16.6 says that
`The instructions operate as if EEW=SEW`.
So the whole vector register move instructions depend on the vtype
register that means the whole vector register move instructions should
raise an illegal-
Peter Xu writes:
> On Fri, Dec 01, 2023 at 11:23:33AM -0500, Steven Sistare wrote:
>> >> @@ -109,6 +117,7 @@ static int global_state_post_load(void *opaque, int
>> >> version_id)
>> >> return -EINVAL;
>> >> }
>> >> s->state = r;
>> >> +vm_set_suspended(s->vm_was_suspended
Unplugging vCPU triggers the following assertion in
tcg_register_thread():
796 void tcg_register_thread(void)
797 {
...
812 /* Claim an entry in tcg_ctxs */
813 n = qatomic_fetch_inc(&tcg_cur_ctxs);
814 g_assert(n < tcg_max_ctxs);
Implement and use tcg_unregister_thread() so whe
Hi,
On 4/12/23 19:57, Stefan Hajnoczi wrote:
On Mon, 4 Dec 2023 at 13:37, Michal Suchánek wrote:
Looking at tcg.c line 784 is here:
ster_thread(void)
{
TCGContext *s = g_malloc(sizeof(*s));
unsigned int i, n;
*s = tcg_init_ctx;
/* Relink mem_base. */
for (i = 0,
On Mon, 4 Dec 2023 at 14:40, Philippe Mathieu-Daudé wrote:
>
> Unplugging vCPU triggers the following assertion in
Unplugging leaks the tcg context refcount but does not trigger the
assertion directly. Maybe clarify that by changing the wording:
"Plugging a vCPU after it has been unplugged trigg
On Mon, Dec 04, 2023 at 04:31:56PM -0300, Fabiano Rosas wrote:
> Peter Xu writes:
>
> > On Fri, Dec 01, 2023 at 11:23:33AM -0500, Steven Sistare wrote:
> >> >> @@ -109,6 +117,7 @@ static int global_state_post_load(void *opaque, int
> >> >> version_id)
> >> >> return -EINVAL;
> >> >>
On Mon, Dec 04, 2023 at 02:50:17PM -0500, Stefan Hajnoczi wrote:
> On Mon, 4 Dec 2023 at 14:40, Philippe Mathieu-Daudé wrote:
> >
> > Unplugging vCPU triggers the following assertion in
>
> Unplugging leaks the tcg context refcount but does not trigger the
> assertion directly. Maybe clarify that
On Thu, Nov 30, 2023 at 01:37:24PM -0800, Steve Sistare wrote:
> Add a test case to verify that the suspended state is handled correctly
> during live migration precopy. The test suspends the src, migrates, then
> wakes the dest.
>
> Signed-off-by: Steve Sistare
> ---
> tests/qtest/migration-he
Peter Xu writes:
> On Mon, Dec 04, 2023 at 04:31:56PM -0300, Fabiano Rosas wrote:
>> Peter Xu writes:
>>
>> > On Fri, Dec 01, 2023 at 11:23:33AM -0500, Steven Sistare wrote:
>> >> >> @@ -109,6 +117,7 @@ static int global_state_post_load(void *opaque,
>> >> >> int version_id)
>> >> >>
Steve Sistare writes:
> Create a separate bootfile for the outgoing and incoming vm, so the block
> layer can lock the file during the background migration test. Otherwise,
> the test fails with:
> "Failed to get "write" lock. Is another process using the image
>[/tmp/migration-test-WAKPD
Steve Sistare writes:
> Add a test case to verify that the suspended state is handled correctly by
> a background migration. The test suspends the src, migrates, then wakes
> the dest.
>
> Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
Steve Sistare writes:
> Add an option to suspend the src in a-b-bootblock.S, which puts the guest
> in S3 state after one round of writing to memory. The option is enabled by
> poking a 1 into the suspend_me word in the boot block prior to starting the
> src vm. Generate symbol offsets in a-b-b
Hi,
GitLab is reporting that that the CentOS Stream 8 x86_64 runner
(#12198892) has been offline for a few hours.
The machine responds to ping so maybe gitlab-runner just needs to be
restarted?
Thanks,
Stefan
signature.asc
Description: PGP signature
On Mon, Dec 04, 2023 at 06:09:16PM -0300, Fabiano Rosas wrote:
> Right, I got your point. I just think we could avoid designing this new
> string format by creating new fields with the extra space:
>
> typedef struct QEMU_PACKED {
> uint32_t size;
> uint8_t runstate[50];
> uint8_t unus
On 12/4/2023 12:24 PM, Peter Xu wrote:
> On Fri, Dec 01, 2023 at 11:23:33AM -0500, Steven Sistare wrote:
@@ -109,6 +117,7 @@ static int global_state_post_load(void *opaque, int
version_id)
return -EINVAL;
}
s->state = r;
+vm_set_suspended(s->vm_
On Mon, Dec 04, 2023 at 06:13:36PM -0300, Fabiano Rosas wrote:
> Steve Sistare writes:
>
> > Create a separate bootfile for the outgoing and incoming vm, so the block
> > layer can lock the file during the background migration test. Otherwise,
> > the test fails with:
> > "Failed to get "write
On 12/4/23 12:09, Michal Suchánek wrote:
On Mon, Dec 04, 2023 at 02:50:17PM -0500, Stefan Hajnoczi wrote:
On Mon, 4 Dec 2023 at 14:40, Philippe Mathieu-Daudé wrote:
+void tcg_unregister_thread(void)
+{
+unsigned int n;
+
+n = qatomic_fetch_dec(&tcg_cur_ctxs);
+g_free(tcg_ctxs[n]);
This adds support for vhost-scsi to be able to create a worker thread
per virtqueue. Right now for vhost-net we get a worker thread per
tx/rx virtqueue pair which scales nicely as we add more virtqueues and
CPUs, but for scsi we get the single worker thread that's shared by all
virtqueues. When try
This adds the vhost backend callouts for the worker ioctls added in the
6.4 linux kernel commit:
c1ecd8e95007 ("vhost: allow userspace to create workers")
Signed-off-by: Mike Christie
Reviewed-by: Stefano Garzarella
Reviewed-by: Stefan Hajnoczi
---
hw/virtio/vhost-backend.c | 28
The following patches allow users to configure the vhost worker threads
for vhost-scsi. With vhost-net we get a worker thread per rx/tx virtqueue
pair, but for vhost-scsi we get one worker for all workqueues. This
becomes a bottlneck after 2 queues are used.
In the upstream linux kernel commit:
h
The ACPI sleep button can be implemented as a fixed hardware button
or Control Method Sleep button.
The patch of implementing a fixed hardware sleep button was posted
here 1). More discussions can be found here 2). Essentially, the
discussion mainly focuses on whether the sleep button is implement
Following hmp/qmp commands are implemented for pressing virtual
sleep button,
hmp: system_sleep
qmp: { "execute": "system_sleep" }
These commands put the guest into suspend or other power states
depending on the power settings inside the guest.
Signed-off-by: Annie Li
---
hmp-commands.hx
The control method sleep button is added, as well as its GPE event
handler.
Co-Developed-by: Miguel Luis
Signed-off-by: Annie Li
---
hw/acpi/control_method_device.c | 49 +
hw/acpi/meson.build | 1 +
include/hw/acpi/control_method_device.h |
Add Control Method Sleep button and its GPE event handler for
x86.
Signed-off-by: Annie Li
---
hw/i386/acpi-build.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 80db183b78..75985e1423 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i38
Update various DSDT tables and empty bios-tables-test-allowed-diff.h
Following the step 5 and 6 in tests/qtest/bios-tables-test.c, the changes
in the tables are:
DSDT:
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20210604 (64-bit version)
* Copyright (c) 2000 - 2
The GPE event is triggered to notify the guest to suspend or
wakeup itself. This patch removes the previous implementation
of QEMU_WAKEUP_REASON_OTHER pretending the resume was caused
by power button.
Signed-off-by: Annie Li
---
hw/acpi/core.c | 17 +
hw/cor
From: Miguel Luis
List changed files for FACP and DSDT table changes for the arm/virt.
Signed-off-by: Miguel Luis
---
tests/qtest/bios-tables-test-allowed-diff.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-te
From: Miguel Luis
*
* ACPI Data Table [FACP]
*
* Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
*/
[000h 4]Signature : "FACP"[Fixed ACPI
Description Table (FADT)]
[004h 0004 4] Table Length : 0114
[008h 0008
From: Miguel Luis
This is for reference that qmp_system_sleep relies on wakeup support delegated
by qemu_wakeup_suspend_enabled() hence the need for calling
qemu_register_wakeup_support().
Signed-off-by: Miguel Luis
---
hw/arm/virt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/v
From: Miguel Luis
Include the ACPI control method device into arm/virt ACPI tables and the
corresponding handling which enables triggering the event.
Signed-off-by: Miguel Luis
---
hw/arm/virt-acpi-build.c | 13 +
hw/arm/virt.c| 13 -
include/hw/arm/virt.h
List various DSDT files allowed to be changed in
tests/qtest/bios-tables-test-allowed-diff.h
Signed-off-by: Annie Li
---
tests/qtest/bios-tables-test-allowed-diff.h | 41 +
1 file changed, 41 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qte
From: Miguel Luis
Add support for ACPI GED sleep event on the ACPI device interface so that
HW-reduced systems can enable guests to sleep.
Signed-off-by: Miguel Luis
---
hw/acpi/generic_event_device.c | 9 +
include/hw/acpi/generic_event_device.h | 1 +
2 files changed, 10 inse
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_helper_protos.py | 184
target/hexagon/hex_common.py| 15 +--
2 files changed, 55 insertions(+), 144 deletions(-)
diff --git a/target/hexagon/gen_helper_protos.py
b/target/hexagon/gen_helper_protos.py
ind
See commit message in second patch
Taylor Simpson (9):
Hexagon (target/hexagon) Clean up handling of modifier registers
Hexagon (target/hexagon) Make generators object oriented -
gen_tcg_funcs
Hexagon (target/hexagon) Make generators object oriented -
gen_helper_protos
Hexagon (tar
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_idef_parser_funcs.py | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/target/hexagon/gen_idef_parser_funcs.py
b/target/hexagon/gen_idef_parser_funcs.py
index f4518e653f..550a48cb7b 100644
--- a/target/h
This is the only remaining use of the is_written function. We will
remove it in the subsequent commit.
Signed-off-by: Taylor Simpson
---
target/hexagon/attribs_def.h.inc | 1 -
target/hexagon/hex_common.py | 11 ---
2 files changed, 12 deletions(-)
diff --git a/target/hexagon/attr
On Tue, Dec 5, 2023 at 1:44 AM Daniel P. Berrangé
wrote:
> On Tue, Dec 05, 2023 at 01:32:51AM +0800, Yong Huang wrote:
> > On Tue, Dec 5, 2023 at 12:51 AM Daniel P. Berrangé
> > wrote:
> >
> > > On Tue, Dec 05, 2023 at 12:41:16AM +0800, Yong Huang wrote:
> > > > On Tue, Dec 5, 2023 at 12:24 AM D
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_op_regs.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/hexagon/gen_op_regs.py b/target/hexagon/gen_op_regs.py
index a8a7712129..7b7b33895a 100755
--- a/target/hexagon/gen_op_regs.py
+++ b/target/hexagon/gen_
The generators are generally a bunch of Python if-then-else
statements based on the regtype and regid. Encapsulate regtype/regid
into a class hierarchy. Clients lookup the register and invoke
methods.
This has several advantages for making the code easier to read,
understand, and maintain
- The
Currently, the register number (MuN) for modifier registers is the
modifier register number rather than the index into hex_gpr. This
patch changes MuN to the hex_gpr index, which is consistent with
the handling of control registers.
Note that HELPER(fcircadd) needs the CS register corresponding t
This patch conflicts with
https://lists.gnu.org/archive/html/qemu-devel/2023-11/msg00729.html
If that series goes in first, we'll rework this patch and vice versa.
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_analyze_funcs.py | 163 +---
target/hexagon/hex_common.
These functions are no longer used after making the generators
object oriented.
Signed-off-by: Taylor Simpson
---
target/hexagon/hex_common.py | 51
1 file changed, 51 deletions(-)
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
inde
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_helper_funcs.py | 400 +++--
target/hexagon/hex_common.py | 58 -
2 files changed, 151 insertions(+), 307 deletions(-)
diff --git a/target/hexagon/gen_helper_funcs.py
b/target/hexagon/gen_helper_funcs.py
ind
If the guest state is paused before it gets a response for the current
scanout frame submission (resource-flush), it won't start submitting
new frames after being restored as it still waits for the old response,
which is accepted as a scanout render done signal. So it's needed to
unblock the curren
> -Original Message-
> From: Taylor Simpson
> Sent: Monday, December 4, 2023 7:53 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain ; Matheus Bernardino (QUIC)
> ; Sid Manning ; Marco
> Liebel (QUIC) ; richard.hender...@linaro.org;
> phi...@linaro.org; a...@rev.ng; a...@rev.ng; ltaylorsimp
> -Original Message-
> From: Taylor Simpson
> Sent: Monday, December 4, 2023 7:53 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain ; Matheus Bernardino (QUIC)
> ; Sid Manning ; Marco
> Liebel (QUIC) ; richard.hender...@linaro.org;
> phi...@linaro.org; a...@rev.ng; a...@rev.ng; ltaylorsimp
> -Original Message-
> From: Taylor Simpson
> Sent: Monday, December 4, 2023 7:53 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain ; Matheus Bernardino (QUIC)
> ; Sid Manning ; Marco
> Liebel (QUIC) ; richard.hender...@linaro.org;
> phi...@linaro.org; a...@rev.ng; a...@rev.ng; ltaylorsimp
Hi Thomas,
On Mon, Dec 04, 2023 at 10:07:12AM +0100, Thomas Huth wrote:
> Date: Mon, 4 Dec 2023 10:07:12 +0100
> From: Thomas Huth
> Subject: Re: [RFC 1/3] scripts/checkpatch: Check common spelling be default
>
> On 04/12/2023 09.29, Zhao Liu wrote:
> > From: Zhao Liu
> >
> > Add the check for
Hi maintainers,
Just a friendly ping. Do I need to refresh another version?
Thanks,
Zhao
On Fri, Nov 17, 2023 at 03:50:50PM +0800, Zhao Liu wrote:
> Date: Fri, 17 Nov 2023 15:50:50 +0800
> From: Zhao Liu
> Subject: [PATCH v6 00/16] Support smp.clusters for x86 in QEMU
> X-Mailer: git-send-email
> -Original Message-
> From: Taylor Simpson
> Sent: Monday, December 4, 2023 7:53 PM
> To: qemu-devel@nongnu.org
> Cc: Brian Cain ; Matheus Bernardino (QUIC)
> ; Sid Manning ; Marco
> Liebel (QUIC) ; richard.hender...@linaro.org;
> phi...@linaro.org; a...@rev.ng; a...@rev.ng; ltaylorsimp
Hello maintainers,
This is a friendly ping.
Are there any other review comments for this patch?
Thanks,
Jai Arora
On Sat, 2 Dec 2023 at 10:19, Jai Arora wrote:
> Patch removes DPRINTF macro and adds multiple tracepoints
> to capture different kvm events.
>
> We also drop the DPRINTFs that don
On 4/12/23 16:05, Akinobu Mita wrote:
> QEMU would not start when trying to create two UFS host controllers and
> a UFS logical unit for each with the following options:
>
> -device ufs,id=bus0 \
> -device ufs-lu,drive=drive1,bus=bus0,lun=0 \
> -device ufs,id=bus1 \
> -device ufs-lu,drive=drive2,
Hi Philippe,
Thank you for informing me.
I want this issue is fixed for the 8.2 release.
I created an issue like you said, but I couldn't assign the milestone (I'm
guessing it's a permission problem).
https://gitlab.com/qemu-project/qemu/-/issues/2018
Could you help me with this?
Regardless, I'
From: Akinobu Mita
QEMU would not start when trying to create two UFS host controllers and
a UFS logical unit for each with the following options:
-device ufs,id=bus0 \
-device ufs-lu,drive=drive1,bus=bus0,lun=0 \
-device ufs,id=bus1 \
-device ufs-lu,drive=drive2,bus=bus1,lun=0 \
This is becaus
From: Jeuk Kim
The following changes since commit 1664d74c50739401c8b40e8b514d12b5fc250067:
tests/avocado: Update yamon-bin-02.22.zip URL (2023-12-04 08:17:35 -0500)
are available in the Git repository at:
https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20231205
for you to fetch chan
From: Tianren Zhang
The stop process is not finished until bdrv_flush_all
is done. Some users (e.g., libvirt) detect the STOP
event and invokes some lock release logic to revoke
the disk lock held by current qemu when such event is
emitted. In such case, if the bdrv_flush_all is after
the stop ev
Hi
On Tue, Dec 5, 2023 at 6:40 AM Dongwon Kim wrote:
>
> If the guest state is paused before it gets a response for the current
> scanout frame submission (resource-flush), it won't start submitting
> new frames after being restored as it still waits for the old response,
> which is accepted as a
Ping.
https://patchew.org/QEMU/20231122053251.440723-1-etha...@andestech.com/
On Wed, Nov 22, 2023 at 01:32:47PM +0800, Ethan Chen wrote:
> This series implements IOPMP specification v1.0.0-draft4 rapid-k model.
> The specification url:
> https://github.com/riscv-non-isa/iopmp-spec/blob/main/riscv
101 - 163 of 163 matches
Mail list logo