Re: [PATCH for-8.2] test-resv-mem: Fix CID 1523911

On 13/11/2023 08.56, Cédric Le Goater wrote: On 11/13/23 08:21, Thomas Huth wrote: On 10/11/2023 09.36, Eric Auger wrote: Coverity complains about passing "&expected" to "run_range_inverse_array", which dereferences null "expected". I guess the problem is that the compare_ranges() loop derefere

Re: [risu PATCH 0/5] Add LoongArch LSX/LASX instructions

Ping ! 在 2023/10/25 下午5:29, Song Gao 写道: Hi, Peter! This series adds LSX/LASX instructions. We tested 10 million instructions without any problems. client: x86 host QEMU + patches [1]. server: 3A5000 host. [1] https://patchwork.kernel.org/project/qemu-devel/list/?series=791633 Please re

Re: [PATCH v6 06/21] net: Remove flag propagation

On 11.11.2023 17:27, Akihiko Odaki wrote: On 2023/11/10 16:35, Pavel Dovgalyuk wrote: You need to bump REPLAY_VERSION in replay/replay.c, because your patch changes the replay log format. Otherwise, for replay part: Acked-by: Pavel Dovgalyuk I'll drop this change then. It's just a cleanup a

[PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Fixes: bbef882cc193 ("msi: add API to get notified about pending bit poll") Signed-off-by: Robert Hoo --- hw/pci/msix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci/msix

[PATCH v1] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide which PMU events are provided to the guest. Add a new option `pmu-filter` as -accel sub-option to set the PMU Event Filtering. The `pmu-filter` has such format: pmu-filter="{A,D}:start-end[;{A,D}:start-end...]" The A mean

Re: [RFC PATCH v2 17/19] heki: x86: Update permissions counters during text patching

On Sun, Nov 12, 2023 at 09:23:24PM -0500, Mickaël Salaün wrote: > From: Madhavan T. Venkataraman > > X86 uses a function called __text_poke() to modify executable code. This > patching function is used by many features such as KProbes and FTrace. > > Update the permissions counters for the text

Re: [PATCH for 8.2] ui/gtk-egl: move function calls back to regular code path

Hi On Sat, Nov 11, 2023 at 2:40 PM Volker Rümelin wrote: > > Commit 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing > scanout") introduced a regression when QEMU is running with a > virtio-gpu-gl-device on a host under X11. After the guest has > initialized the virtio-gpu-gl-device, the gu

[GIT PULL 0/1] Host Memory Backends and Memory devices queue 2023-11-13

The following changes since commit 69680740eafa1838527c90155a7432d51b8ff203: Merge tag 'qdev-array-prop' of https://repo.or.cz/qemu/kevin into staging (2023-11-11 11:23:25 +0800) are available in the Git repository at: https://github.com/davidhildenbrand/qemu.git tags/mem-2023-11-13 for yo

[GIT PULL 1/1] virtio-mem: fix division by zero in virtio_mem_activate_memslots_to_plug()

When running with "dynamic-memslots=off", we enter virtio_mem_activate_memslots_to_plug() to return immediately again because "vmem->dynamic_memslots == false". However, the compiler might not optimize out calculating start_idx+end_idx, where we divide by vmem->memslot_size. In such a configuration

Re: [RFC PATCH v2 18/19] heki: x86: Protect guest kernel memory using the KVM hypervisor

On Sun, Nov 12, 2023 at 09:23:25PM -0500, Mickaël Salaün wrote: > From: Madhavan T. Venkataraman > > Implement a hypervisor function, kvm_protect_memory() that calls the > KVM_HC_PROTECT_MEMORY hypercall to request the KVM hypervisor to > set specified permissions on a list of guest pages. > > U

Re: [PATCH] hv-balloon: avoid alloca() usage

On 09.11.23 17:02, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Reviewed-by: David Hildenbrand If this fixes a coverity issue of #number, we usually indicate that using "CID: #number" or Fixes: CID: #number" -

Re: [PATCH v2 1/8] ppc/pnv: Add pca9552 to powernv10 for PCIe hotplug power control

On 11/10/23 20:49, Glenn Miles wrote: The Power Hypervisor code expects to see a pca9552 device connected to the 3rd PNV I2C engine on port 1 at I2C address 0x63 (or left- justified address of 0xC6). This is used by hypervisor code to control PCIe slot power during hotplug events. Signed-off-by

Re: [PATCH v2 3/8] ppc/pnv: PNV I2C engines assigned incorrect XSCOM addresses

On 11/10/23 20:49, Glenn Miles wrote: The PNV I2C engines for power9 and power10 were being assigned a base XSCOM address that was off by one I2C engine's address range such that engine 0 had engine 1's address and so on. The xscom address assignment was being based on the device tree engine num

Re: [PATCH v2 4/8] ppc/pnv: Fix PNV I2C invalid status after reset

On 11/10/23 20:49, Glenn Miles wrote: The PNV I2C Controller was clearing the status register after a reset without repopulating the "upper threshold for I2C ports", "Command Complete" and the SCL/SDA input level fields. Fixed this for resets caused by a system reset as well as from writing to t

Re: [PATCH v3 05/20] mcdstub: tcp packet processing added

Hi Phil, as of right now, there is no official spec for the TCP packet contents. However, in the client code it is rather easy see how the packets are constructed. I hope I will get the client code online by the end of the week. I will also look into qtest. We definetely need a test like this

Re: [PATCH v3 00/20] first version of mcdstub

Hi Phil, okay thanks! I'll add the license. Regards, Nicolas On 08/11/2023 15:27, Philippe Mathieu-Daudé wrote: Hi Nicolas, On 7/11/23 14:03, Nicolas Eder wrote: SUMMARY === This patch-set introduces the first version of the mcdstub.   30 files changed, 3749 insertions(+), 38 deletio

Re: [PATCH] hv-balloon: avoid alloca() usage

On 13.11.2023 09:59, David Hildenbrand wrote: On 09.11.23 17:02, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" alloca() is frowned upon, replace it with g_malloc0() + g_autofree. Reviewed-by: David Hildenbrand If this fixes a coverity issue of #number, we usually indicate that us

Re: [PATCH v1] target/i386/host-cpu: Use IOMMU addr width for passthrough devices on Intel platforms

On 11/13/23 08:32, Vivek Kasireddy wrote: > A recent OVMF update has resulted in MMIO regions being placed at > the upper end of the physical address space. As a result, when a > Host device is passthrough'd to the Guest via VFIO, the following > mapping failures occur when VFIO tries to map the MM

[PULL 1/2] block/snapshot: Fix compiler warning with -Wshadow=local

From: Thomas Huth No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. With this change, the code can now be successfully compiled with -Wshadow=local again. Signed-off-by: Thomas Huth Messa

[PULL 0/2] -Wshadow=local patches for 2023-11-13

The following changes since commit 69680740eafa1838527c90155a7432d51b8ff203: Merge tag 'qdev-array-prop' of https://repo.or.cz/qemu/kevin into staging (2023-11-11 11:23:25 +0800) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-shadow-2023-11-13 for you

[PULL 2/2] meson: Enable -Wshadow=local

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: commit bbde656263d (migration/rdma: Fix save_page method to fail on polling error). Enable -Wshadow=local to prevent such issues. Possible thanks t

Re: [PATCH v3 04/21] parallels: Add parallels_mark_unused() helper

On 10/30/23 10:09, Denis V. Lunev wrote: On 10/30/23 10:06, Denis V. Lunev wrote: On 10/27/23 09:46, Alexander Ivanov wrote: Add a helper to set unused areas in the used bitmap. Signed-off-by: Alexander Ivanov ---   block/parallels.c | 17 +   block/parallels.h |  2 ++   2 f

Re: [PATCH for 8.2] ui/gtk-egl: move function calls back to regular code path

Hi Volker, Thank you for finding this! On 11/11/2023 11:40, Volker Rümelin wrote: Commit 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing scanout") introduced a regression when QEMU is running with a virtio-gpu-gl-device on a host under X11. After the guest has initialized the virtio-gpu-

[RFC PATCH 2/2] RISC-V: Add support for Ssdtso

From: Christoph Müllner The Ssdtso extension introduces a DTSO field to the {m,s,h}envcfg register to enable TSO at run-time. Building on top of Ztso support, this patch treates Ssdtso just like Ztso (always execute in TSO mode), which should be fine from a correctness perspective. Similar like

[RFC PATCH 1/2] RISC-V: Add support for Ztso

From: Palmer Dabbelt The Ztso extension is already ratified, this adds it as a CPU property and adds various fences throughout the port in order to allow TSO targets to function on weaker hosts. We need no fences for AMOs as they're already SC, the placess we need barriers are described. These f

[RFC PATCH 0/2] RISC-V: Add TSO extensions (Ztso/Ssdtso)

From: Christoph Müllner This series picks up an earlier v2 Ztso patch from Palmer and adds a second to support Ssdtso. Palmer's v2 Ztso patch can be found here: https://patchwork.kernel.org/project/qemu-devel/patch/20220917072635.11616-1-pal...@rivosinc.com/ This patch did not apply cleanly b

Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

Hi Robert, On 13/11/23 09:13, Robert Hoo wrote: In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Out of curiosity, nobody complained during 11 years, so in which use case did you notice this? Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] test/qtest: Add an API function to capture IRQ toggling

On 13/11/23 07:59, Thomas Huth wrote: On 12/11/2023 02.38, Gustavo Romero wrote: Currently the QTest API does not provide a function to allow capturing when an IRQ line is toggled (raised then lowered). Functions like qtest_get_irq() read the current state of the intercepted IRQ lines, which is

[PULL 3/3] tests/qapi-schema: Tidy up pylint warnings and advice

Pylint warns: tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) Add encoding='utf-8'. Pylint

[PULL 0/3] QAPI patches patches for 2023-11-13

The following changes since commit 69680740eafa1838527c90155a7432d51b8ff203: Merge tag 'qdev-array-prop' of https://repo.or.cz/qemu/kevin into staging (2023-11-11 11:23:25 +0800) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2023-11-13 for you to

[PULL 1/3] qapi: Fix QAPISchemaEntity.__repr__()

I messed it up on merge. It's a debugging aid, so no impact on build. Fixes: e307a8174bb8 (qapi: provide a friendly string representation of QAPI classes) Signed-off-by: Markus Armbruster Message-ID: <20231024104841.1569250-1-arm...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Phil

Re: [PATCH] hv-balloon: avoid alloca() usage

On Mon, 13 Nov 2023 at 08:59, David Hildenbrand wrote: > > On 09.11.23 17:02, Maciej S. Szmigiero wrote: > > From: "Maciej S. Szmigiero" > > > > alloca() is frowned upon, replace it with g_malloc0() + g_autofree. > > > > Reviewed-by: David Hildenbrand > > If this fixes a coverity issue of #numbe

[PULL 2/3] sphinx/qapidoc: Tidy up pylint warning raise-missing-from

Pylint advises: docs/sphinx/qapidoc.py:518:12: W0707: Consider explicitly re-raising using 'raise ExtensionError(str(err)) from err' (raise-missing-from) >From its manual: Python's exception chaining shows the traceback of the current exception, but also of the original exception.

Re: [PATCH v4 0/8] Misc clean ups to target/ppc exception handling

On Wed Nov 1, 2023 at 8:44 PM AEST, BALATON Zoltan wrote: > On Tue, 24 Oct 2023, BALATON Zoltan wrote: > > These are some small clean ups for target/ppc/excp_helper.c trying to > > make this code a bit simpler. No functional change is intended. This > > series was submitted before but only partiall

Re: [PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

On 08/11/2023 18.57, Richard Henderson wrote: On 11/8/23 00:59, Thomas Huth wrote: When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /

Re: [PULL 21/38] plugins: update lockstep to use g_memdup2

On 03/07/2023 15.44, Alex Bennée wrote: The old g_memdup is deprecated, use the replacement. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230630180423.558337-22-alex.ben...@linaro.org> diff --git a/contrib/plugins/lockstep.c b/c

Re: [PATCH v3 19/36] plugins: update lockstep to use g_memdup2

Hi Alex, On 27/6/23 18:09, Alex Bennée wrote: The old g_memdup is deprecated, use the replacement. Message-Id: <20230623122100.1640995-21-alex.ben...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v5 03/20] vfio/iommufd: Implement the iommufd backend

On 11/10/23 11:18, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Friday, November 10, 2023 5:34 PM Subject: Re: [PATCH v5 03/20] vfio/iommufd: Implement the iommufd backend On 11/9/23 12:45, Zhenzhong Duan wrote: From: Yi Liu Add the iommufd backend. The I

[PULL 09/12] tests/vm/netbsd: Use Python v3.11

From: Philippe Mathieu-Daudé We requiere the 'ninja-build', which depends on 'python311': $ pkgin show-deps ninja-build direct dependencies for ninja-build-1.11.1nb1 python311>=3.11.0 So we end up installing both Python v3.10 and v3.11: [31/76] installing python311-3.11.5...

[PULL 07/12] MAINTAINERS: Extend the Stellaris section

This header include/hw/timer/stellaris-gptm.h obviously belongs to the Stellaris machines, so let's add it to the corresponding section. And hw/display/ssd0303.c and hw/display/ssd0323.c are only used by hw/arm/stellaris.c, so add them to the corresponding section in the MAINTAINERS file, too. Me

[PULL 06/12] MAINTAINERS: Add hw/display/sii9022.c to the Versatile Express section

This graphics adapter is only used by the Versatile Express machine, so add it to the corresponding section in MAINTAINERS. Message-ID: <20231020060936.524988-4-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)

[PULL 00/12] Misc patches for 8.2-rc0

The following changes since commit 69680740eafa1838527c90155a7432d51b8ff203: Merge tag 'qdev-array-prop' of https://repo.or.cz/qemu/kevin into staging (2023-11-11 11:23:25 +0800) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023-11-13 for you

[PULL 10/12] test-resv-mem: Fix CID 1523911

From: Eric Auger Coverity complains about passing "&expected" to "run_range_inverse_array", which dereferences null "expected". I guess the problem is that the compare_ranges() loop dereferences 'e' without testing it. However the loop condition is based on 'ranges' which is garanteed to have the

[PULL 03/12] s390x/pci: only limit DMA aperture if vfio DMA limit reported

From: Matthew Rosato If the host kernel lacks vfio DMA limit reporting, do not attempt to shrink the guest DMA aperture. Fixes: df202e3ff3 ("s390x/pci: shrink DMA aperture to be bound by vfio DMA limit") Signed-off-by: Matthew Rosato Message-ID: <20231110175108.465851-3-mjros...@linux.ibm.com>

[PULL 08/12] MAINTAINERS: Add a general architecture section for x86

It's a little bit weird that the files in target/i386/ which are not in a subfolder there do not have any associated maintainer (and thus nobody might be CC:-ed on changes to these files). We should have a general x86 section for these files, similar to what we already have for s390x and mips. Sinc

[PULL 11/12] tests/tsan: Rename the file with the entries that should be ignored

Let's use a better file name here. Message-ID: <20231109174720.375873-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- docs/devel/testing.rst | 4 ++-- tests/tsan/{blacklist.tsan => ignore.tsan} | 6 +++--- 2 files changed, 5 insertions(

[PULL 04/12] MAINTAINERS: Add include/hw/input/pl050.h to the PrimeCell/CMSDK section

The corresponding pl050.c file is already listed here, so we should mention the header here, too. Message-ID: <20231020060936.524988-2-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS

[PULL 05/12] MAINTAINERS: Add hw/input/ads7846.c to the PXA2XX section

The code from hw/input/ads7846.c is only used by hw/arm/spitz.c, so add this file to the same section where hw/arm/spitz.c is listed. Message-ID: <20231020060936.524988-3-th...@redhat.com> Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+

[PULL 12/12] hw/audio/es1370: Clean up comment

From: Peter Maydell Replace a sweary comment with one that's a bit more helpful to future readers of the code. Signed-off-by: Peter Maydell Reviewed-by: Volker Rümelin Message-ID: <20231110164318.2197569-1-peter.mayd...@linaro.org> Signed-off-by: Thomas Huth --- hw/audio/es1370.c | 9 +++

Re: [PATCH v5 10/20] vfio/pci: Make vfio cdev pre-openable by passing a file handle

On 11/13/23 04:00, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Friday, November 10, 2023 6:53 PM Subject: Re: [PATCH v5 10/20] vfio/pci: Make vfio cdev pre-openable by passing a file handle On 11/9/23 12:45, Zhenzhong Duan wrote: This gives management tool

Re: [PULL 0/8] Firmware/edk2 20230918 patches

> Hi, > > This apparently broke EDK2 for AArch64. I tried the following command: > build/qemu-system-aarch64 -drive > file=build/pc-bios/edk2-aarch64-code.fd,format=raw,if=pflash,readonly=on -M > virt -cpu max -nographic -cdrom Fedora-Silverblue-ostree-aarch64-37-1.7.iso https://bugzilla.redhat.c

[PULL 02/12] s390x/pci: bypass vfio DMA counting when using cdev

From: Matthew Rosato The current code assumes that there is always a vfio group, but that's no longer guaranteed with the iommufd backend when using cdev. In this case, we don't need to track the vfio dma limit anyway. Signed-off-by: Matthew Rosato Message-ID: <20231110175108.465851-2-mjros...

[PULL 01/12] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qemu/host/include/generic/host/atomic128-

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

>> +    for (l = gi->nodelist; l; l = l->next) { >> +    PCIDeviceHandle dev_handle = {0}; >> +    PCIDevice *pci_dev = PCI_DEVICE(o); >> +    dev_handle.bdf = >> PCI_BUILD_BDF(pci_bus_num(pci_get_bus(pci_dev)), >> +  

Re: [PULL 06/23] tests/tcg: add an explicit gdbstub register tester

On Wed Nov 8, 2023 at 12:23 AM AEST, Alex Bennée wrote: > We already do a couple of "info registers" for specific tests but this > is a more comprehensive multiarch test. It also has some output > helpful for debugging the gdbstub by showing which XML features are > advertised and what the underlyi

Re: [PATCH] MAINTAINERS: update virtio-fs mailing list address

On Sat, Nov 11, 2023 at 1:49 AM Stefan Hajnoczi wrote: > > The old virtio-fs mailing list address is no longer in use. Switch to > the new mailing list address. > > Cc: Philippe Mathieu-Daudé > Cc: Vivek Goyal > Cc: German Maglione > Cc: Hanna Czenczek > Signed-off-by: Stefan Hajnoczi > --- >

Re: [PULL 21/38] plugins: update lockstep to use g_memdup2

Thomas Huth writes: > On 03/07/2023 15.44, Alex Bennée wrote: >> The old g_memdup is deprecated, use the replacement. >> Reviewed-by: Philippe Mathieu-Daudé >> Reviewed-by: Richard Henderson >> Signed-off-by: Alex Bennée >> Message-Id: <20230630180423.558337-22-alex.ben...@linaro.org> >> diff

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki wrote: > On 2023/11/03 22:14, Yuri Benditovich wrote: > > > > > > On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki > > wrote: > > > > On 2023/11/03 18:35, Yuri Benditovich wrote: > > > > > > > > > On T

Re: [PULL 21/38] plugins: update lockstep to use g_memdup2

On Mon, Nov 13, 2023 at 11:40:18AM +, Alex Bennée wrote: > Thomas Huth writes: > > > On 03/07/2023 15.44, Alex Bennée wrote: > >> The old g_memdup is deprecated, use the replacement. > >> Reviewed-by: Philippe Mathieu-Daudé > >> Reviewed-by: Richard Henderson > >> Signed-off-by: Alex Bennée

Re: [PATCH v1 7/7] xen_arm: Add basic virtio-pci support

Hi David, David Woodhouse writes: > [[S/MIME Signed Part:Undecided]] > On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: >> From: Oleksandr Tyshchenko >> >> This patch adds basic virtio-pci support for xen_arm machine. > > Why only xen_arm? Couldn't this be a fairly generic device

Re: [PATCH v4 0/8] Misc clean ups to target/ppc exception handling

On Mon, 13 Nov 2023, Nicholas Piggin wrote: On Wed Nov 1, 2023 at 8:44 PM AEST, BALATON Zoltan wrote: On Tue, 24 Oct 2023, BALATON Zoltan wrote: These are some small clean ups for target/ppc/excp_helper.c trying to make this code a bit simpler. No functional change is intended. This series was

Re: [PULL 21/38] plugins: update lockstep to use g_memdup2

On 13/11/2023 12.40, Alex Bennée wrote: Thomas Huth writes: On 03/07/2023 15.44, Alex Bennée wrote: The old g_memdup is deprecated, use the replacement. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230630180423.558337-22-alex.

Re: [PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

On 13/11/23 11:34, Thomas Huth wrote: On 08/11/2023 18.57, Richard Henderson wrote: On 11/8/23 00:59, Thomas Huth wrote: When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-pro

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/13 20:44, Yuri Benditovich wrote: On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki > wrote: On 2023/11/03 22:14, Yuri Benditovich wrote: > > > On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

[PATCH v6] limit address space used for pci devices.

For better compatibility with old linux kernels, see source code comment. Also rename some variables to make the code more readable, following suggestions by Kevin. Related (same problem in ovmf): https://github.com/tianocore/edk2/commit/c1e853769046 Cc: Kevin O'Connor Reported-by: Claudio Font

Re: [PATCH v1 3/7] xen: xenstore: add possibility to preserve owner

Hi David, David Woodhouse writes: > [[S/MIME Signed Part:Undecided]] > On Fri, 2023-11-10 at 20:42 +, Volodymyr Babchuk wrote: >> Add option to preserve owner when creating an entry in Xen Store. This >> may be needed in cases when Qemu is working as device model in a >> domain that is Domai

Re: [PATCH v1 3/7] xen: xenstore: add possibility to preserve owner

Hi David, David Woodhouse writes: > [[S/MIME Signed Part:Undecided]] > On Sat, 2023-11-11 at 11:01 +, David Woodhouse wrote: >> >> > --- a/hw/xen/xen-operations.c >> > +++ b/hw/xen/xen-operations.c >> > @@ -300,6 +300,18 @@ static bool libxenstore_create(struct qemu_xs_handle >> > *h, xs_

Re: [PATCH] msix: unset PCIDevice::msix_vector_poll_notifier in rollback

On 11/13/2023 6:05 PM, Philippe Mathieu-Daudé wrote: Hi Robert, On 13/11/23 09:13, Robert Hoo wrote: In the rollback in msix_set_vector_notifiers(), original patch forgot to undo msix_vector_poll_notifier pointer. Out of curiosity, nobody complained during 11 years, so in which use case did y

Re: [PATCH-for-8.2 v4 00/10] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

On Thu, 9 Nov 2023 at 20:59, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 9/11/23 20:29, Peter Maydell wrote: > > On Thu, 9 Nov 2023 at 19:28, Philippe Mathieu-Daudé > > wrote: > >> > >> Missing review: #10 > >> > >> Hi, > >> > >> This series add support for (async) FIFO on the transmit pa

Re: [PATCH] hw/arm/virt: fix GIC maintenance IRQ registration

On Fri, 10 Nov 2023 at 11:45, Jean-Philippe Brucker wrote: > > On Fri, Nov 10, 2023 at 10:19:30AM +, Peter Maydell wrote: > > On Fri, 10 Nov 2023 at 09:07, Jean-Philippe Brucker > > wrote: > > > > > > Since commit 9036e917f8 ("{include/}hw/arm: refactor virt PPI logic"), > > > GIC maintenance

Re: [PATCH v2 00/14] Nested PAPR API (KVM on PowerVM)

This will have to wait until the next release. There should not be big changes to rebase on. I'll take a better look before then. Linux now has this merged upstream so it will be much easier to test. I posted some RFCs for new avocado tests including a KVM guest boot (https://lists.gnu.org/archiv

Re: [virtio] Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

It seems that the original mail did not make it to some of the mailing lists it was intended to go to, possibly due to the html part of the original mail. Therefore, I'm trying again, this time with plain text only. Apologies in advance for any duplicates. On Wed, Nov 08 2023, Paul Knight wrote:

[PATCH 0/2] Replace anti-social QOM type names (again)

We got rid of QOM type names containing ',' in 6.0, but some have crept back in. Replace them just like we did in 6.0. Cover letter of 6.0's replacement: https://lore.kernel.org/qemu-devel/20210304140229.575481-1-arm...@redhat.com/ Markus Armbruster (2): docs/system/arm: Fix for rename of type

[PATCH 2/2] hw: Replace anti-social QOM type names (again)

QOM type names containing ',' result in awful UI. We got rid of them in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names). A few have crept back since: xlnx,cframe-reg xlnx,efuse xlnx,pmc-efuse-cache xlnx,versal-cfu-apb xlnx,versal-cfu-fdro xlnx,versal-cfu

[PATCH 1/2] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster --- docs/system/arm/xlnx-versal-virt.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.rst index

Re: [PATCH 0/2] Replace anti-social QOM type names (again)

On Mon, Nov 13, 2023 at 02:43:42PM +0100, Markus Armbruster wrote: > We got rid of QOM type names containing ',' in 6.0, but some have > crept back in. Replace them just like we did in 6.0. It is practical to add assert(strchr(name, ',') == NULL) to some place in QOM to stop them coming back

Re: [PATCH 1/2] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

On 2023-11-13 14:43, Markus Armbruster wrote: Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster Reviewed-by: Francisco Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] tests/avocado/machine_s390_ccw_virtio.py: Fix SyntaxWarnings from python 3.12

Python 3.12 now warns about backslashes in strings that aren't used for escaping a special character from Python. Silence the warning by using raw strings here instead. Signed-off-by: Thomas Huth --- tests/avocado/machine_s390_ccw_virtio.py | 18 +- 1 file changed, 9 insertions(+

Re: [PATCH 2/2] hw: Replace anti-social QOM type names (again)

On 2023-11-13 14:43, Markus Armbruster wrote: QOM type names containing ',' result in awful UI. We got rid of them in v6.0.0 (commit e178113ff64 hw: Replace anti-social QOM type names). A few have crept back since: xlnx,cframe-reg xlnx,efuse xlnx,pmc-efuse-cache xlnx,vers

Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure

On Mon, Nov 13, 2023 at 11:14:00AM +, Ankit Agrawal wrote: > > It also looks like this support just silently fails if the device > > string isn't the right type or isn't found. That's not good. Should > > the previous patch validate the device where the Error return is more > > readily availa

[PATCH] util/qemu-config: Remove unnecessary traversal

From: Gao Shiyuan No remove QemuOptsList from *_config_groups, so no need to traverse from the beginning every time. No functional changes. Signed-off-by: Gao Shiyuan --- include/qemu/config-file.h | 3 +++ util/qemu-config.c | 18 -- 2 files changed, 11 insertions(+)

RE: [PATCH v5 01/11] hw/misc: Add Nuvoton's PCI Mailbox Module

-Original Message- From: Nabih Estefan Sent: Saturday, October 28, 2023 1:55 AM To: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing ; wuhao...@google.com; jasonw...@redhat.com; IS20 Avi Fishman ; nabiheste...@google.com; CS20 KWLiu ; IS20 Tomer Mai

[PATCH 1/1] hw/i2c: add pca9543 i2c-mux switch

Add pca9543 2-channel i2c-mux switch support. Signed-off-by: Potin Lai --- hw/i2c/i2c_mux_pca954x.c | 12 include/hw/i2c/i2c_mux_pca954x.h | 1 + 2 files changed, 13 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index db5db956a6..6aace0fc47

RE: [PATCH v5 02/11] hw/arm: Add PCI mailbox module to Nuvoton SoC

-Original Message- From: Nabih Estefan Sent: Saturday, October 28, 2023 1:55 AM To: peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; CS20 KFTing ; wuhao...@google.com; jasonw...@redhat.com; IS20 Avi Fishman ; nabiheste...@google.com; CS20 KWLiu ; IS20 Tomer Mai

Re: [PULL 29/32] virtio-blk: implement BlockDevOps->drained_begin()

Am 03.11.23 um 14:12 schrieb Fiona Ebner: > Hi, > > Am 30.05.23 um 18:32 schrieb Kevin Wolf: >> From: Stefan Hajnoczi >> >> Detach ioeventfds during drained sections to stop I/O submission from >> the guest. virtio-blk is no longer reliant on aio_disable_external() >> after this patch. This will

Re: [PATCH] tests/avocado/machine_s390_ccw_virtio.py: Fix SyntaxWarnings from python 3.12

On 13/11/23 15:07, Thomas Huth wrote: Python 3.12 now warns about backslashes in strings that aren't used for escaping a special character from Python. Silence the warning by using raw strings here instead. Signed-off-by: Thomas Huth --- tests/avocado/machine_s390_ccw_virtio.py | 18 +

Re: [PATCH v2 0/2] s390x/pci: small set of fixes

On Fri, 2023-11-10 at 12:51 -0500, Matthew Rosato wrote: > The following set of changes are associated with issues exposed by > testing > of the 'vfio: Adopt iommufd' series. ...snip... > Matthew Rosato (2): >   s390x/pci: bypass vfio DMA counting when using cdev >   s390x/pci: only limit DMA ape

Re: [PATCH 1/2] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

On 13/11/23 14:43, Markus Armbruster wrote: Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster --- docs/system/arm/xlnx-versal-virt.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH-for-9.0 00/10] hw/xen: Have most of Xen files become target-agnostic

Hi, After discussing with Alex Bennée I realized most Xen code should be target-agnostic. David Woodhouse confirmed that last week, so I had a quick look and here is the result. More work is required to be able to instanciate Xen HW in an heterogeneous machine, but this doesn't make sense yet unt

[PATCH-for-9.0 05/10] hw/xen: Use target-agnostic qemu_target_page_bits()

Instead of the target-specific TARGET_PAGE_BITS definition, use qemu_target_page_bits() which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé --- hw/xen/xen-hvm-common.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-c

[PATCH-for-9.0 09/10] hw/xen: Extract 'xen_igd.h' from 'xen_pt.h'

"hw/xen/xen_pt.h" requires "hw/xen/xen_native.h" which is target specific. It also declares IGD methods, which are not target specific. Target-agnostic code can use IGD methods. To allow that, extract these methos into a new "hw/xen/xen_igd.h" header. Signed-off-by: Philippe Mathieu-Daudé --- Wh

[PATCH-for-9.0 08/10] system/physmem: Only include 'hw/xen/xen.h' when Xen is available

"hw/xen/xen.h" contains declarations for Xen hardware. There is no point including it when Xen is not available. When Xen is not available, we have enough with declarations of "sysemu/xen.h". Signed-off-by: Philippe Mathieu-Daudé --- system/physmem.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH-for-9.0 06/10] hw/xen: Reduce inclusion of 'cpu.h' to target-specific sources

We rarely need to include "cpu.h" in headers. Including it 'taint' headers to be target-specific. Here only the i386/arm implementations requires "cpu.h", so include it there and remove from the "hw/xen/xen-hvm-common.h" *common* header. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/xen/x

[PATCH-for-9.0 07/10] sysemu/xen-mapcache: Check Xen availability with CONFIG_XEN_IS_POSSIBLE

"sysemu/xen.h" defines CONFIG_XEN_IS_POSSIBLE as a target-agnostic version of CONFIG_XEN. Use it in order to use "sysemu/xen-mapcache.h" in target-agnostic files. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/xen-mapcache.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH-for-9.0 03/10] hw/xen: Merge 'hw/xen/arch_hvm.h' in 'hw/xen/xen-hvm-common.h'

We don't need a target-specific header for common target-specific prototypes. Declare xen_arch_handle_ioreq() and xen_arch_set_memory() in "hw/xen/xen-hvm-common.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/xen_arch_hvm.h | 9 - include/hw/i386/xen_arch_hvm.h | 11 ---

[PATCH-for-9.0 04/10] hw/xen: Factor xen_arch_align_ioreq_data() out of handle_ioreq()

Per commit f17068c1c7 ("xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common"), handle_ioreq() is expected to be target-agnostic. However it uses 'target_ulong', which is a target specific definition. In order to compile this file once for all targets, factor the target-specific

[PATCH-for-9.0 02/10] hw/xen/xen_arch_hvm: Rename prototypes using 'xen_arch_' prefix

Use a common 'xen_arch_' prefix for architecture-specific functions. Rename xen_arch_set_memory() and xen_arch_handle_ioreq(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/xen_arch_hvm.h | 4 ++-- include/hw/i386/xen_arch_hvm.h | 4 ++-- hw/arm/xen_arm.c | 4 ++-- hw/i

[PATCH-for-9.0 01/10] sysemu/xen: Forbid using Xen headers in user emulation

Xen is a system specific accelerator, it makes no sense to include its headers in user emulation. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/xen.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/sysemu/xen.h b/include/sysemu/xen.h index bc13ad569

[PATCH-for-9.0 10/10] hw/xen: Have most of Xen files become target-agnostic

Previous commits re-organized the target-specific bits from Xen files. We can now build the common files once instead of per-target. Signed-off-by: Philippe Mathieu-Daudé --- accel/xen/meson.build | 2 +- hw/block/dataplane/meson.build | 2 +- hw/xen/meson.build | 13 -

Re: [PATCH-for-8.2 v4 00/10] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

Hi Peter, Cc'ing Mikko. On 13/11/23 14:11, Peter Maydell wrote: On Thu, 9 Nov 2023 at 20:59, Philippe Mathieu-Daudé wrote: Hi Peter, On 9/11/23 20:29, Peter Maydell wrote: On Thu, 9 Nov 2023 at 19:28, Philippe Mathieu-Daudé wrote: Missing review: #10 Hi, This series add support for (a

  1   2   3   4   >