Re: [PATCH 1/4] dump: Set dump info function pointers to NULL

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > Better to not rely on the struct zeroing since NULL is not necessarily > 0. > > Signed-off-by: Janosch Frank > --- > dump/dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dump/dump.c b/dump/dump.c > index d355ada62e..1

Re: [PATCH 2/2] dump: Fix HMP dump-guest-memory -z without -R

2023-11-08 Thread Marc-André Lureau
On Wed, Nov 8, 2023 at 9:38 AM Markus Armbruster wrote: > > -z without -R has no effect: the dump format remains @elf. Fix the > logic error so it becomes @kdump-zlib. > > Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) > Fixes: CID 1523841 > Signed-off-by: Markus Armbrust

Re: [PATCH 2/4] target/s390x/dump: Remove unneeded dump info function pointer init

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > dump_state_prepare() now sets the fucntion pointers to NULL so we only function > need to touch them if we're going to use them. > > Signed-off-by: Janosch Frank regardless if the previous patch is applied, this patch lgtm Reviewed-b

Re: [PATCH 4/4] target/s390x/arch_dump: Add arch cleanup function for PV dumps

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > PV dumps block vcpu runs until dump end is reached. If there's an > error between PV dump init and PV dump end the vm will never be able > to run again. One example of such an error is insufficient disk space > for the dump file. > > Let'

RE: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Matthew Rosato >Sent: Wednesday, November 8, 2023 11:27 AM >Subject: Re: [PATCH v4 00/41] vfio: Adopt iommufd > >On 11/7/23 1:28 PM, Cédric Le Goater wrote: >> On 11/2/23 08:12, Zhenzhong Duan wrote: >>> Hi, >>> >>> Thanks all for giving guides and comments on

Re: [PATCH 1/4] dump: Set dump info function pointers to NULL

2023-11-08 Thread Janosch Frank
On 11/8/23 09:03, Marc-André Lureau wrote: Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: Better to not rely on the struct zeroing since NULL is not necessarily 0. Signed-off-by: Janosch Frank --- dump/dump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dump/dump.c b/du

[PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

2023-11-08 Thread Thomas Huth
When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qemu/host/include/generic/host/atomic128-

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Antonio Caggiano
Hi Hans, +cc Gert and Dmitry On 17/10/2023 02:48, Hans de Ruiter wrote: Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features are currently stable enough to use. Looking at the master QEMU branch, both Virgl and blob resources are supported, but NOT at the

RE: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Duan, Zhenzhong >Sent: Wednesday, November 8, 2023 4:38 PM >Subject: RE: [PATCH v4 00/41] vfio: Adopt iommufd > > > >>-Original Message- >>From: Matthew Rosato >>Sent: Wednesday, November 8, 2023 11:27 AM >>Subject: Re: [PATCH v4 00/41] vfio: Adopt iomm

Re: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Cédric Le Goater
On 11/8/23 04:26, Matthew Rosato wrote: On 11/7/23 1:28 PM, Cédric Le Goater wrote: On 11/2/23 08:12, Zhenzhong Duan wrote: Hi, Thanks all for giving guides and comments on previous series, here is the v4 of pure iommufd support part. Based on Cédric's suggestion, this series includes an effo

Re: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Cédric Le Goater
FYI, I first tried this vfio-8.2 branch on s390x but wasn't actually able to use the iommufd backend (was getting errors like Property 'vfio-pci.iommufd' not found) so I think something isn't actually enabling IOMMUFD as expected with your change... It looks CONFIG_IOMMUFD is recognized by Kcon

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Cédric Le Goater
+ hwaddr iova, ram_addr_t size) +{ +int ret; +struct iommu_ioas_unmap unmap = { +.size = sizeof(unmap), +.ioas_id = ioas_id, +.iova = iova, +.length = size, +}; + +ret = ioctl(be->fd, IOMMU_IOAS_UNMAP, &unmap); +trace

Re: [PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 09:59, Thomas Huth wrote: When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qe

RE: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Wednesday, November 8, 2023 5:41 PM >Subject: Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object > + hwaddr iova, ram_addr_t size) +{ +int ret; +struct iommu_ioas_

Re: [PATCH v1 4/9] target/loongarch: Implement kvm get/set registers

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Tianrui, Xianglai, On 8/11/23 02:41, xianglai li wrote: From: Tianrui Zhao Implement kvm_arch_get/set_registers interfaces, many regs can be get/set in the function, such as core regs, csr regs, fpu regs, mp state, etc. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- meson.b

Re: [PATCH v2] coverity: physmem: use simple assertions instead of modelling

2023-11-08 Thread Vladimir Sementsov-Ogievskiy
ping) Is it queued? On 06.10.23 01:53, Paolo Bonzini wrote: On Thu, Oct 5, 2023 at 4:04 PM Vladimir Sementsov-Ogievskiy wrote: +/* + * Assure Coverity (and ourselves) that we are not going to OVERRUN + * the buffer by following ldn_he_p(). + */ +

Re: [PATCH v1 8/9] target/loongarch: Implement set vcpu intr for kvm

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 02:41, xianglai li wrote: From: Tianrui Zhao Implement loongarch kvm set vcpu interrupt interface, when a irq is set in vcpu, we use the KVM_INTERRUPT ioctl to set intr into kvm. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- target/loongarch/cpu.c | 18 +++

Re: [PATCH v4] virtio: add VIRTQUEUE_ERROR QAPI event

2023-11-08 Thread Vladimir Sementsov-Ogievskiy
ping :) On 17.10.23 15:39, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or do some other debuggi

Re: [PATCH v1 1/9] linux-headers: Add KVM headers for loongarch

2023-11-08 Thread Cornelia Huck
On Wed, Nov 08 2023, xianglai li wrote: > From: zhaotianrui > > Update linux KVM headers about LoongArch KVM form linux > kernel. Mainly contains some KVM structures and macro > defines such as LoongArch KVM registers number, LoongArch > fpu structure, exit reason of LoongArch IOCSR, etc. > > Si

Re: [PATCH] Fix Windows 2000 and XP HDAudio Support

2023-11-08 Thread Philippe Mathieu-Daudé
Thanks Christopher for your patch, I'm Cc'ing Volker and Gerd who know better this hardware model. On 7/11/23 20:27, Christopher Lentocha wrote: Change the ID to be a Realtek ALC885 so that both Windows 2000 and up (including XP) and macOS (on a later patch for HDEF ACPI Fixes) support HDA HDA

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Cédric Le Goater
Hello Markus, On 11/8/23 06:50, Markus Armbruster wrote: Cédric Le Goater writes: On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iommu device. The /dev/iommu can have been already pre-opened outside of qem

Re: [PATCH 06/71] target/cris: Constify VMState in machine.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/cris/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 07/71] target/hppa: Constify VMState in machine.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 22/71] hw/adc: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/adc/aspeed_adc.c| 2 +- hw/adc/max111x.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- hw/adc/stm32f2xx_adc.c | 2 +- hw/adc/zynq-xadc.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) Rev

Re: [PATCH 37/71] hw/isa: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/isa/apm.c | 2 +- hw/isa/i82378.c | 2 +- hw/isa/lpc_ich9.c | 8 hw/isa/pc87312.c | 2 +- hw/isa/piix.c | 8 hw/isa/vt82c686.c | 4 ++-- 6 files changed, 13 insertions(+), 13

Re: [PATCH 49/71] hw/rtc: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/aspeed_rtc.c | 2 +- hw/rtc/ds1338.c | 2 +- hw/rtc/exynos4210_rtc.c | 2 +- hw/rtc/goldfish_rtc.c| 2 +- hw/rtc/ls7a_rtc.c| 2 +- hw/rtc/m48

Re: [PATCH 03/71] targt/arm: Constify hvf/hvf.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 12:54, Philippe Mathieu-Daudé wrote: On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   target/arm/hvf/hvf.c | 13 -   1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [PATCH 65/71] cpu-target: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- cpu-target.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 69/71] util/fifo8: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- util/fifo8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info

2023-11-08 Thread Philippe Mathieu-Daudé
On 26/10/23 23:19, Dongli Zhang wrote: While the default "info lapic" always synchronizes cpu state ... mon_get_cpu() -> mon_get_cpu_sync(mon, true) -> cpu_synchronize_state(cpu) -> ioctl KVM_GET_LAPIC (taking KVM as example) ... the cpu state is not synchronized when the apic-id is

Re: [PATCH v4 0/4] hw/audio/pcspk: Inline pcspk_init()

2023-11-08 Thread Philippe Mathieu-Daudé
On 3/11/23 09:56, Markus Armbruster wrote: Bernhard Beschow writes: Am 20. Oktober 2023 17:15:04 UTC schrieb "Philippe Mathieu-Daudé" : Unfortunately v2 was merged as commit 40f8214fcd, so adapt v3 to clean the mess. Philippe Mathieu-Daudé (4): hw/i386/pc: Pass Error** argument to pc_basi

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Markus Armbruster
Cédric Le Goater writes: > Hello Markus, > > On 11/8/23 06:50, Markus Armbruster wrote: >> Cédric Le Goater writes: >> >>> On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iommu device. The

Re: [PATCH 6/8] docs/specs/virt-ctlr: Convert to rST

2023-11-08 Thread Philippe Mathieu-Daudé
On 31/10/23 16:43, Peter Maydell wrote: On Tue, 31 Oct 2023 at 15:39, Philippe Mathieu-Daudé wrote: On 27/9/23 17:12, Peter Maydell wrote: Convert docs/specs/virt-ctlr.txt to rST format. I added the name of the device to give readers a bit more idea of which device we're actually documenting

Re: [PATCH 0/2] dump: Fix issues flagged by Coverity

2023-11-08 Thread Markus Armbruster
Stephen Brennan writes: > Markus Armbruster writes: >> Markus Armbruster (2): >> dump: Plug file descriptor leak on non-seekable file >> dump: Fix HMP dump-guest-memory -z without -R > > Hi Markus, > > I'm a bit late on the uptake here as these are already queued, but thank > you so much for

Re: [PATCH 1/1] hw/sd: Declare CPU QOM types using DEFINE_TYPES() macro

2023-11-08 Thread Philippe Mathieu-Daudé
On 31/10/23 09:31, Cédric Le Goater wrote: On 10/31/23 09:06, Philippe Mathieu-Daudé wrote: When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Mechanical tran

Re: [PATCH] vl: constify default_list

2023-11-08 Thread Philippe Mathieu-Daudé
On 30/10/23 11:19, Philippe Mathieu-Daudé wrote: On 30/10/23 11:15, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau It's not modified, let's make it const. Signed-off-by: Marc-André Lureau ---   system/vl.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Phil

[PATCH] tracetool: avoid invalid escape in Python string

2023-11-08 Thread marcandre . lureau
From: Marc-André Lureau This is an error in Python 3.12; fix it by using a raw string literal. Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau --- scripts/tracetool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scrip

RE: [PATCH V6 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-11-08 Thread Salil Mehta via
Hi Igor, > From: Igor Mammedov > Sent: Friday, October 27, 2023 2:18 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; Jonathan Cameron ; > lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org; andrew.j

virtio...@redhat.com bouncing

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Stefan, You are listed as virtiofs maintainer, see MAINTAINERS: virtiofs M: Stefan Hajnoczi S: Supported F: hw/virtio/vhost-user-fs* F: include/hw/virtio/vhost-user-fs.h L: virtio...@redhat.com Mails sent to this list address are bouncing: : host int-mx-rdu2.corp.redhat.com[10.

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Marc-André Lureau
Hi On Wed, Nov 8, 2023 at 1:04 PM Antonio Caggiano wrote: > > Hi Hans, > > +cc Gert and Dmitry > > On 17/10/2023 02:48, Hans de Ruiter wrote: > > Hi, > > > > I'm working on Virtio GPU drivers for AmigaOS, and would like to know > > what features are currently stable enough to use. Looking at the

Re: [PATCH] Fix Windows 2000 and XP HDAudio Support

2023-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2023 at 11:02:06AM +0100, Philippe Mathieu-Daudé wrote: > Thanks Christopher for your patch, > > I'm Cc'ing Volker and Gerd who know better this hardware model. > > On 7/11/23 20:27, Christopher Lentocha wrote: > > > > Change the ID to be a Realtek ALC885 so that both No. Rewri

Re: virtio...@redhat.com bouncing

2023-11-08 Thread Stefan Hajnoczi
On Wed, 8 Nov 2023 at 19:05, Philippe Mathieu-Daudé wrote: > > Hi Stefan, > > You are listed as virtiofs maintainer, see MAINTAINERS: > >virtiofs >M: Stefan Hajnoczi >S: Supported >F: hw/virtio/vhost-user-fs* >F: include/hw/virtio/vhost-user-fs.h >L: virtio...@redhat.com >

Re: virtio...@redhat.com bouncing

2023-11-08 Thread Mauro Matteo Cascella
Hi, On Wed, Nov 8, 2023 at 12:40 PM Stefan Hajnoczi wrote: > > On Wed, 8 Nov 2023 at 19:05, Philippe Mathieu-Daudé wrote: > > > > Hi Stefan, > > > > You are listed as virtiofs maintainer, see MAINTAINERS: > > > >virtiofs > >M: Stefan Hajnoczi > >S: Supported > >F: hw/virtio/vhos

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-08 Thread Paolo Bonzini
On Tue, Nov 7, 2023 at 1:43 PM Greg Manning wrote: > Windows will look for __pfnDliFailureHook2 in the module doing the delay > loading, which in this case is the plugin DLL. Fair enough, this is what was not clear from the Microsoft docs. Paolo

Re: [PULL 00/23] Final test, gdbstub, plugin and gitdm updates for 8.2

2023-11-08 Thread Stefan Hajnoczi
On Tue, 7 Nov 2023 at 22:25, Alex Bennée wrote: > > The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683: > > Merge tag 'pixman-pull-request' of https://gitlab.com/marcandre.lureau/qemu > into staging (2023-11-07 19:00:03 +0800) > > are available in the Git repository at:

[PATCH 1/1] Changed the way aclint gets CPUState from hartid-base to cpu_index

2023-11-08 Thread Leo Hou
From: Leo Hou cpu_by_arch_id() uses hartid-base as the index to obtain the corresponding CPUState structure variable. qemu_get_cpu() uses cpu_index as the index to obtain the corresponding CPUState structure variable. In heterogeneous CPU or multi-socket scenarios, multiple aclint needs to be

Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend

2023-11-08 Thread Jason Gunthorpe
On Wed, Nov 08, 2023 at 07:16:52AM +, Duan, Zhenzhong wrote: > >> +ret = iommufd_backend_alloc_hwpt(iommufd, vbasedev->devid, > >> + container->ioas_id, &hwpt_id); > >> + > >> +if (ret) { > >> +error_setg_errno(errp, errno, "error alloc shado

Re: [PATCH v2] hw/ide/ahci: fix legacy software reset

2023-11-08 Thread Kevin Wolf
Am 08.11.2023 um 00:57 hat Niklas Cassel geschrieben: > On Tue, Nov 07, 2023 at 07:14:07PM +0100, Kevin Wolf wrote: > > Am 05.10.2023 um 12:04 hat Niklas Cassel geschrieben: > > > From: Niklas Cassel > > > > > > Legacy software contains a standard mechanism for generating a reset to a > > > Seria

Re: [PATCH] tracetool: avoid invalid escape in Python string

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 11:56, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau This is an error in Python 3.12; fix it by using a raw string literal. Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau --- scripts/tracetool/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deleti

RE: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Jason Gunthorpe >Sent: Wednesday, November 8, 2023 8:48 PM >Subject: Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend > >On Wed, Nov 08, 2023 at 07:16:52AM +, Duan, Zhenzhong wrote: > >> >> +ret = iommufd_backend_alloc_hwpt(iommufd, vba

[PATCH] ui/console: fix default VC when there are no display

2023-11-08 Thread marcandre . lureau
From: Marc-André Lureau When display is "none", we may still have remote displays (I think it would be simpler if VNC/Spice were regular display btw). Return the default VC then, and set them up to fix a regression when using remote display and it used the TTY instead. Fixes: commit 1bec1cc0d ("

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Antonio Caggiano
Hi Marc-André, On 08/11/2023 12:07, Marc-André Lureau wrote: Hi On Wed, Nov 8, 2023 at 1:04 PM Antonio Caggiano wrote: Hi Hans, +cc Gert and Dmitry On 17/10/2023 02:48, Hans de Ruiter wrote: Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features are curre

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Cédric Le Goater
On 11/8/23 11:30, Markus Armbruster wrote: Cédric Le Goater writes: Hello Markus, On 11/8/23 06:50, Markus Armbruster wrote: Cédric Le Goater writes: On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iomm

Re: [PATCH v4 28/41] vfio/iommufd: Implement the iommufd backend

2023-11-08 Thread Jason Gunthorpe
On Wed, Nov 08, 2023 at 01:25:34PM +, Duan, Zhenzhong wrote: > >I was expecting that hwpt manipulation would be done exclusively > >inside the device-specific vIOMMU userspace driver. Generic code paths > >that don't have that knowledge should use the IOAS for everything > > Yes, this way we

Re: [PULL 00/11] s390x and MAINTAINERS updates

2023-11-08 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/9] ppc queue

2023-11-08 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/75] Misc HW/UI patches for 2023-11-07

2023-11-08 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v9 5/5] amd_iommu: report x2APIC support to the operating system

2023-11-08 Thread Bui Quang Minh
On 11/7/23 07:39, Michael S. Tsirkin wrote: On Tue, Oct 24, 2023 at 10:21:05PM +0700, Bui Quang Minh wrote: This commit adds XTSup configuration to let user choose to whether enable this feature or not. When XTSup is enabled, additional bytes in IRTE with enabled guest virtual VAPIC are used to

Re: [PULL 0/5] Misc fixes patches

2023-11-08 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v3 00/20] first version of mcdstub

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Nicolas, On 7/11/23 14:03, Nicolas Eder wrote: SUMMARY === This patch-set introduces the first version of the mcdstub. 30 files changed, 3749 insertions(+), 38 deletions(-) create mode 100644 debug/debug-common.c create mode 100644 debug/debug-gdb.c create mode 100644 debug/d

Re: [PATCH v3 05/20] mcdstub: tcp packet processing added

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Nicolas, On 7/11/23 14:03, Nicolas Eder wrote: --- include/mcdstub/mcdstub.h | 144 mcdstub/mcdstub.c | 277 ++ 2 files changed, 421 insertions(+) diff --git a/include/mcdstub/mcdstub.h b/include/mcdstub/mcdstub.h index 360

[PATCH v2 11/35 1/2] tcg/arm: Factor tcg_out_cmp() out

2023-11-08 Thread Philippe Mathieu-Daudé
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20231028194522.245170-12-richard.hender...@linaro.org> [PMD: Split from bigger patch, part 1/2] Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 32 +--- 1 file changed, 17 ins

[PATCH v2 11/35 2/2] tcg/arm: Support TCG_COND_TST{EQ,NE}

2023-11-08 Thread Philippe Mathieu-Daudé
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20231028194522.245170-12-richard.hender...@linaro.org> [PMD: Split from bigger patch, part 2/2] Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 29 - 1 file changed, 28 insert

Re: [PULL 00/23] Final test, gdbstub, plugin and gitdm updates for 8.2

2023-11-08 Thread Alex Bennée
Stefan Hajnoczi writes: > On Tue, 7 Nov 2023 at 22:25, Alex Bennée wrote: >> >> The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683: >> >> Merge tag 'pixman-pull-request' of >> https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-07 19:00:03 >> +0800) >> >>

Re: [PATCH v5] tests/avocado: add test to exercize processor address space memory bound checks

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Ani, On 3/11/23 12:06, Ani Sinha wrote: QEMU has validations to make sure that a VM is not started with more memory (static and hotpluggable memory) than what the guest processor can address directly with its addressing bits. This change adds a test to make sure QEMU fails to start with a spe

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Alex Bennée
Hans de Ruiter writes: (Cc: Adding others with interest in VirtIO GPUs to the thread) > Hi, > > I'm working on Virtio GPU drivers for AmigaOS, and would like to know > what features are currently stable enough to use. Looking at the > master QEMU branch, both Virgl and blob resources are support

[PULL v2 00/23] Final test, gdbstub, plugin and gitdm updates for 8.2

2023-11-08 Thread Alex Bennée
The following changes since commit a3c3aaa846ad61b801e7196482dcf4afb8ba34e4: Merge tag 'pull-ppc-20231107' of https://gitlab.com/danielhb/qemu into staging (2023-11-08 20:35:00 +0800) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-halloween-omnibus-081

[PATCH v6 3/4] python: add binary

2023-11-08 Thread Maksim Davydov
Add a supportive property to access the path to the qemu binary Signed-off-by: Maksim Davydov --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 31cb9d617d..78436403b2 100644 --- a/pyth

[PATCH v6 1/4] qom: add default value

2023-11-08 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-by: Maksim Davydo

[PATCH v6 0/4] compare machine type compat_props

2023-11-08 Thread Maksim Davydov
This script can be used to choose the best machine type in the appropriate cases. Also we have to check compat_props of the old MT after changes to be sure that they haven't broken old the MT. For example, pc_compat_3_1 of pc-q35-3.1 has Icelake-Client which was removed. v6 -> v5: * add ability to

[PATCH v6 2/4] qmp: add dump machine type compatible properties

2023-11-08 Thread Maksim Davydov
To control that creating new machine type doesn't affect the previous types (their compat_props) and to check complex compat_props inheritance we need qmp command to print machine type compatible properties. This patch adds the ability to get list of all the compat_props of the corresponding suppor

[PATCH v6 4/4] scripts: add script to compare compatible properties

2023-11-08 Thread Maksim Davydov
This script runs QEMU to obtain compat_props of machines and default values of different types of drivers to produce comparison table. This table can be used to compare machine types to choose the most suitable machine or compare binaries to be sure that migration to the newer version will save all

[PATCH RFC v1 1/1] ui/sdl2: clipboard sharing implementation for SDL

2023-11-08 Thread Kamay Xutax
Signed-off-by: Kamay Xutax --- include/ui/sdl2.h | 5 ++ meson.build | 1 + ui/meson.build | 1 + ui/sdl2-clipboard.c | 147 ui/sdl2.c | 8 +++ 5 files changed, 162 insertions(+) create mode 100644 ui/sdl2-clipboard.c

Re: [PULL 00/23] Final test, gdbstub, plugin and gitdm updates for 8.2

2023-11-08 Thread Alex Bennée
Stefan Hajnoczi writes: > On Tue, 7 Nov 2023 at 22:25, Alex Bennée wrote: >> >> The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683: >> >> Merge tag 'pixman-pull-request' of >> https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-07 19:00:03 >> +0800) >> >>

[PATCH RFC v1 0/1] clipboard sharing implementation for SDL

2023-11-08 Thread Kamay Xutax
Hello, This is my first try contributing to QEMU, and I would like some advices before merging my patch into master branch. Current implementation works with qemu-vdagent character device. I decided to ignore QemuClipboardPeer's request function pointer for my current implementation because I cou

[PATCH] .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)

2023-11-08 Thread Philippe Mathieu-Daudé
macOS 14 "Sonoma" was released on September 2023 [1]. According to QEMU's support policy, we stop supporting the previous major release two years after the the new major release has been published. Replace the macOS 12 (Monterey) testing by macOS 13 (Ventura, released on October 2022, [2]). Refre

[PATCH] risu: Add test summary

2023-11-08 Thread Sebastian Mitterle
Currently, a successful test run finishes silently with exit code 0. The last message on the console is "starting image" which can leave the user wondering if they executed the commands correctly. Now add a summary of the number of executed instructions in case of success. Don't add that message w

Re: [PATCH] .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)

2023-11-08 Thread Daniel P . Berrangé
On Wed, Nov 08, 2023 at 05:20:22PM +0100, Philippe Mathieu-Daudé wrote: > macOS 14 "Sonoma" was released on September 2023 [1]. > > According to QEMU's support policy, we stop supporting the > previous major release two years after the the new major > release has been published. Replace the macOS

[RFC PATCH] tests/docker: merge debian-native with debian-amd64

2023-11-08 Thread Alex Bennée
debian-native isn't really needed and suffers from the problem of tracking a distros dependencies rather than the projects. With a little surgery we can make the debian-amd64 container architecture neutral and allow people to use it to build a native QEMU. Rename it so it follows the same non-arch

[PULL v2 00/25] Block layer patches

2023-11-08 Thread Kevin Wolf
The following changes since commit 462ad017ed76889d46696a3581e1b52343f9b683: Merge tag 'pixman-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-11-07 19:00:03 +0800) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for

Re: [PATCH] .gitlab-ci.d/cirrus: Upgrade macOS to 13 (Ventura)

2023-11-08 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > macOS 14 "Sonoma" was released on September 2023 [1]. > > According to QEMU's support policy, we stop supporting the > previous major release two years after the the new major > release has been published. Replace the macOS 12 (Monterey) > testing by macOS 13 (Ven

Re: [PATCH] MAINTAINERS: Fix a couple s390 paths

2023-11-08 Thread Halil Pasic
On Fri, 20 Oct 2023 16:15:09 +0200 Eric Farman wrote: > : Fri, 20 Oct 2023 16:15:09 +0200 > X-Mailer: git-send-email 2.39.2 > > These are simple typos, since the directories don't exist but the > files themselves do in hw/s390x/ > > Fixes: 56e3483402 ("MAINTAINERS: split out s390x sections") >

Re: [RFC PATCH] tests/docker: merge debian-native with debian-amd64

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 17:56, Alex Bennée wrote: debian-native isn't really needed and suffers from the problem of tracking a distros dependencies rather than the projects. With a little surgery we can make the debian-amd64 container architecture neutral and allow people to use it to build a native QEMU. Re

Re: [PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

2023-11-08 Thread Richard Henderson
On 11/8/23 00:59, Thomas Huth wrote: When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qe

Re: [PATCH v6 3/4] python: add binary

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Maksim, On 8/11/23 16:38, Maksim Davydov wrote: Add a supportive property to access the path to the qemu binary Signed-off-by: Maksim Davydov --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/m

Re: [PATCH v6 1/4] qom: add default value

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 16:38, Maksim Davydov wrote: qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memo

Re: [PATCH v2 11/35 2/2] tcg/arm: Support TCG_COND_TST{EQ,NE}

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 15:52, Philippe Mathieu-Daudé wrote: From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20231028194522.245170-12-richard.hender...@linaro.org> [PMD: Split from bigger patch, part 2/2] Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 29 +

Re: [PATCH v2 14/35] tcg/i386: Support TCG_COND_TST{EQ,NE}

2023-11-08 Thread Philippe Mathieu-Daudé
On 28/10/23 21:45, Richard Henderson wrote: Merge tcg_out_testi into tcg_out_cmp and adjust the two uses. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 83 ++- 1 file changed, 47 insertions(+), 36 deletions(-) #if TCG_TARGET_REG_BI

[RFC PATCH 0/2] buildsys: Use host meson on macOS Sonoma (14)

2023-11-08 Thread Philippe Mathieu-Daudé
macOS 14 "Sonoma" was released end of September 2023, developers who upgraded they host can not build QEMU anymore due to some issue with meson, described in https://gitlab.com/qemu-project/qemu/-/issues/1939 (mkvenv ignore the host meson and forces to use the old meson 0.63.3, which doesn't work o

[NOTFORMERGE PATCH 1/2] configure: Use distrib meson

2023-11-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- configure | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure b/configure index f1456f6123..93735b7661 100755 --- a/configure +++ b/configure @@ -955,15 +955,8 @@ if $python -c 'import sys; sys.exit(sys.version_info >= (

[PATCH 2/2] .gitlab-ci.d/cirrus: Add manual testing of macOS 14 (Sonoma)

2023-11-08 Thread Philippe Mathieu-Daudé
Upgrade libvirt-ci so it covers macOS 14. Add a manual entry (QEMU_JOB_OPTIONAL: 1) to test on Sonoma release. Refresh the lci-tool generated files. Signed-off-by: Philippe Mathieu-Daudé --- Docs are disabled due to: Collecting sphinx Downloading sphinx-7.2.6-py3-none-any.whl.metadata (5.9

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-08 Thread Kevin O'Connor
On Tue, Nov 07, 2023 at 02:03:09PM +0100, Gerd Hoffmann wrote: > For better compatibility with old linux kernels, > see source code comment. > > Related (same problem in ovmf): > https://github.com/tianocore/edk2/commit/c1e853769046 Thanks. I'll defer to your judgement on this. It does seem a l

Re: [RFC PATCH] tests/docker: merge debian-native with debian-amd64

2023-11-08 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 8/11/23 17:56, Alex Bennée wrote: >> debian-native isn't really needed and suffers from the problem of >> tracking a distros dependencies rather than the projects. With a >> little surgery we can make the debian-amd64 container architecture >> neutral and allow

Re: [PATCH v1 9/9] target/loongarch: Add loongarch kvm into meson build

2023-11-08 Thread Richard Henderson
On 11/7/23 17:41, xianglai li wrote: From: Tianrui Zhao Add kvm.c and kvm-stub.c into meson.build to compile it when kvm is configed. Meanwhile in meson.build, we set the kvm_targets to loongarch64-softmmu when the cpu is loongarch. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li ---

Re: [NOTFORMERGE PATCH 1/2] configure: Use distrib meson

2023-11-08 Thread Peter Maydell
On Wed, 8 Nov 2023 at 18:33, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > configure | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/configure b/configure > index f1456f6123..93735b7661 100755 > --- a/configure > +++ b/configure

Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

2023-11-08 Thread Paul Knight
OASIS members and other interested parties, OASIS and the OASIS Virtual I/O Device (VIRTIO) TC are pleased to announce that Virtual I/O Device (VIRTIO) Version 1.3 is now available for public review and comment. Specification Overview: This document describes the specifications of the 'virtio' f

Re: [PATCH v9 5/5] amd_iommu: report x2APIC support to the operating system

2023-11-08 Thread Michael S. Tsirkin
On Wed, Nov 08, 2023 at 09:22:18PM +0700, Bui Quang Minh wrote: > On 11/7/23 07:39, Michael S. Tsirkin wrote: > > On Tue, Oct 24, 2023 at 10:21:05PM +0700, Bui Quang Minh wrote: > > > This commit adds XTSup configuration to let user choose to whether enable > > > this feature or not. When XTSup is

Re: [NOTFORMERGE PATCH 1/2] configure: Use distrib meson

2023-11-08 Thread BALATON Zoltan
On Wed, 8 Nov 2023, Peter Maydell wrote: On Wed, 8 Nov 2023 at 18:33, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- configure | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/configure b/configure index f1456f6123..93735b7661 100755 --- a/

Re: [PATCH v2 27/35] tcg/ppc: Support TCG_COND_TST{EQ,NE}

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Richard, On 28/10/23 21:45, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 105 --- 1 file changed, 98 insertions(+), 7 deletions(-) -static inline void tcg_out_rld(TCGContext *s, int op, TCGReg ra, TCGReg r

[PATCH for-8.2] target/sparc: Fix RETURN

2023-11-08 Thread Richard Henderson
Perform window restore before pc update. Required in order to recognize any window underflow trap with the current pc. Fixes: 86b82fe021f4 ("target/sparc: Move JMPL, RETT, RETURN to decodetree") Reported-by: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/translate.c | 2 +-

  1   2   >