On Wed, Nov 8, 2023 at 9:38 AM Markus Armbruster <arm...@redhat.com> wrote:
>
> -z without -R has no effect: the dump format remains @elf. Fix the
> logic error so it becomes @kdump-zlib.
>
> Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats)
> Fixes: CID 1523841
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> dump/dump-hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c
> index b428ec33df..d9340427c3 100644
> --- a/dump/dump-hmp-cmds.c
> +++ b/dump/dump-hmp-cmds.c
> @@ -41,7 +41,7 @@ void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict)
> dump_format = DUMP_GUEST_MEMORY_FORMAT_WIN_DMP;
> }
>
> - if (zlib && raw) {
> + if (zlib) {
> if (raw) {
> dump_format = DUMP_GUEST_MEMORY_FORMAT_KDUMP_RAW_ZLIB;
> } else {
> --
> 2.41.0
>
>
--
Marc-André Lureau
