Re: [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-07 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote: >> Lets keep a cleaner split between the base class and the derived >> vhost-user-device which we can use for generic vhost-user stubs. This >> includes an update to introduce the vq_size property so the n

Re: [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-07 Thread Michael S. Tsirkin
On Tue, Nov 07, 2023 at 08:03:16AM +, Alex Bennée wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote: > >> Lets keep a cleaner split between the base class and the derived > >> vhost-user-device which we can use for generic vhost-user stubs

qemu-devel@nongnu.org

2023-11-07 Thread Mark Cave-Ayland
On 06/11/2023 19:15, Alex Bennée wrote: A lot of our vhost-user stubs are large chunks of boilerplate that do (mostly) the same thing. This series continues the cleanups by splitting the vhost-user-base and vhost-user-generic implementations. After adding a new vq_size property the rng, gpio and

qemu-devel@nongnu.org

2023-11-07 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:09PM +, Alex Bennée wrote: > A lot of our vhost-user stubs are large chunks of boilerplate that do > (mostly) the same thing. This series continues the cleanups by > splitting the vhost-user-base and vhost-user-generic implementations. > After adding a new vq_size

Re: [PATCH 17/29] gdbstub: Simplify XML lookup

2023-11-07 Thread Frédéric Pétrot
Hello Alex and Akihiko, this patch introduces a regression for riscv. When connecting to gdb, gdb issues the infamous "Architecture rejected target-supplied description" warning. As this patch touches "common" QEMU files (not riscv ones that I am a bit more familiar with and am able to test), I w

Re: [PATCH v8 23/24] hw/display/ati: allow compiling without PIXMAN

2023-11-07 Thread BALATON Zoltan
On Tue, 7 Nov 2023, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Change the "x-pixman" property default value and use the fallback path when PIXMAN support is disabled. Signed-off-by: Marc-André Lureau --- hw/display/ati.c | 16 +++- hw/display/ati_2d.c| 11

qemu-devel@nongnu.org

2023-11-07 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:09PM +, Alex Bennée wrote: > A lot of our vhost-user stubs are large chunks of boilerplate that do > (mostly) the same thing. This series continues the cleanups by > splitting the vhost-user-base and vhost-user-generic implementations. > After adding a new vq_size

Re: [PATCH v7 0/3] Add emulation of AmigaOne XE board

2023-11-07 Thread BALATON Zoltan
On Mon, 6 Nov 2023, BALATON Zoltan wrote: On Fri, 27 Oct 2023, BALATON Zoltan wrote: Changes in v7: - Increase default memory size to 512m to match pegasos2 and sam460ex and it's a better default for AmigaOS Changes in v6: - Dropped patch 1, now it's Based-on: <20231024224056.842607-1-mark.cav

Re: [PULL 00/60] Misc HW/UI patches for 2023-11-06

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 02:39, Stefan Hajnoczi wrote: On Mon, 6 Nov 2023 at 19:03, Philippe Mathieu-Daudé wrote: The following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-11-03

Re: [PATCH v6 3/6] hw/virtio: derive vhost-user-gpio from vhost-user-base

2023-11-07 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:12PM +, Alex Bennée wrote: > -case CHR_EVENT_CLOSED: > -/* defer close until later to avoid circular close */ > -vhost_user_async_close(dev, &gpio->chardev, &gpio->vhost_dev, > - vu_gpio_disconnect, vu_gpio_event);

Re: [PATCH v8 23/24] hw/display/ati: allow compiling without PIXMAN

2023-11-07 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 12:46 PM BALATON Zoltan wrote: > > On Tue, 7 Nov 2023, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Change the "x-pixman" property default value and use the fallback path > > when PIXMAN support is disabled. > > > > Signed-off-by: Marc-André Lu

Re: [PATCH RFC 2/3] tests/qtest/pvanic: use centralized definition of supported events

2023-11-07 Thread Thomas Huth
On 04/11/2023 12.25, Thomas Weißschuh wrote: Avoid the necessity to update all tests when new events are added to the device. Signed-off-by: Thomas Weißschuh --- tests/qtest/pvpanic-pci-test.c | 5 +++-- tests/qtest/pvpanic-test.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions

Re: [PATCH] dump:Add close fd on error return to avoid resource leak

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 03:44, Zongmin Zhou wrote: Signed-off-by: Zongmin Zhou Reported-by: Coverity CID 1523842 (RESOURCE_LEAK) Fixes: e6549197f7 ("dump: Add command interface for kdump-raw formats") Reviewed-by: Philippe Mathieu-Daudé --- dump/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2023-11-07 Thread Vladimir Sementsov-Ogievskiy
From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. We still want per-device throttling, so let's use device id as a key. Signed-off-by: Leonid Kaplan Signed-off-by: Vladimir Sementsov-Ogievskiy --- monitor/monitor.c | 10 ++ 1 file changed, 10 insert

Re: [PATCH] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()

2023-11-07 Thread Vladimir Sementsov-Ogievskiy
On 07.11.23 10:32, Michael S. Tsirkin wrote: On Fri, Nov 03, 2023 at 01:56:02PM +0300, Dmitrii Gavrilov wrote: Original goal of addition of drain_call_rcu to qmp_device_add was to cover the failure case of qdev_device_add. It seems call of drain_call_rcu was misplaced in 7bed89958bfbf40df what l

Re: [PATCH v2 16/29] migration/ram: Add support for 'fixed-ram' migration restore

2023-11-07 Thread Daniel P . Berrangé
On Mon, Nov 06, 2023 at 04:00:33PM -0500, Peter Xu wrote: > On Mon, Nov 06, 2023 at 10:18:03AM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Wed, Nov 01, 2023 at 02:28:24PM +, Daniel P. Berrangé wrote: > > >> On Wed, Nov 01, 2023 at 10:21:07AM -0400, Peter Xu wrote: > > >> > O

[PATCH] hw/arm: XLNX_VERSAL depends on XLNX_CSU_DMA

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 8ce288a40c..fef992a402 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -484,6 +484,7 @@ config XLNX_VERSAL select XLNX_E

Re: [PATCH v8 03/24] ui: compile out some qemu-pixman functions when !PIXMAN

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 08:18, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions

Re: [PATCH v8 02/24] build-sys: drop needless warning pragmas for old pixman

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 08:18, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit 236f282c1c7 ("configure: check for pixman-1 version"), QEMU requires >= 0.21.8. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 4 --

Re: [PATCH v8 20/24] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-11-07 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 7/11/23 08:19, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meso

[PULL 09/15] hw/xen: update Xen console to XenDevice model

2023-11-07 Thread David Woodhouse
From: David Woodhouse This allows (non-primary) console devices to be created on the command line and hotplugged. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/char/trace-events| 8 + hw/char/xen_console.c | 532 +++- hw/xen/xe

[PULL 02/15] hw/xen: Clean up event channel 'type_val' handling to use union

2023-11-07 Thread David Woodhouse
From: David Woodhouse A previous implementation of this stuff used a 64-bit field for all of the port information (vcpu/type/type_val) and did atomic exchanges on them. When I implemented that in Qemu I regretted my life choices and just kept it simple with locking instead. So there's no need fo

[PULL 06/15] hw/xen: automatically assign device index to block devices

2023-11-07 Thread David Woodhouse
From: David Woodhouse There's no need to force the user to assign a vdev. We can automatically assign one, starting at xvda and searching until we find the first disk name that's unused. This means we can now allow '-drive if=xen,file=xxx' to work without an explicit separate -driver argument, j

[PULL 03/15] include: update Xen public headers to Xen 4.17.2 release

2023-11-07 Thread David Woodhouse
From: David Woodhouse ... in order to advertise the XEN_HVM_CPUID_UPCALL_VECTOR feature, which will come in a subsequent commit. Signed-off-by: David Woodhouse Acked-by: Paul Durrant --- hw/i386/kvm/xen_xenstore.c| 2 +- include/hw/xen/interface/arch-arm.h | 37

[PULL 00/15] xenfv.for-upstream queue

2023-11-07 Thread David Woodhouse
The following changes since commit 8aba939e77daca10eac99d9d467f65ba7df5ab3e: Merge tag 'pull-riscv-to-apply-20231107' of https://github.com/alistair23/qemu into staging (2023-11-07 11:08:16 +0800) are available in the Git repository at: git://git.infradead.org/users/dwmw2/qemu

[PULL 11/15] hw/xen: only remove peers of PCI NICs on unplug

2023-11-07 Thread David Woodhouse
From: David Woodhouse When the Xen guest asks to unplug *emulated* NICs, it's kind of unhelpful also to unplug the peer of the *Xen* PV NIC. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/xen/xen_platform.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[PULL 07/15] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-11-07 Thread David Woodhouse
From: David Woodhouse The primary Xen console is special. The guest's side is set up for it by the toolstack automatically and not by the standard PV init sequence. Accordingly, its *frontend* doesn't appear in …/device/console/0 either; instead it appears under …/console in the guest's XenStore

[PULL 15/15] docs: update Xen-on-KVM documentation

2023-11-07 Thread David Woodhouse
From: David Woodhouse Add notes about console and network support, and how to launch PV guests. Clean up the disk configuration examples now that that's simpler, and remove the comment about IDE unplug on q35/AHCI now that it's fixed. Update the -initrd option documentation to explain how to quo

[PULL 04/15] i386/xen: advertise XEN_HVM_CPUID_UPCALL_VECTOR in CPUID

2023-11-07 Thread David Woodhouse
From: David Woodhouse This will allow Linux guests (since v6.0) to use the per-vCPU upcall vector delivered as MSI through the local APIC. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- target/i386/kvm/kvm.c | 4 1 file changed, 4 insertions(+) diff --git a/target/i386/kvm

[PULL 01/15] i386/xen: Ignore VCPU_SSHOTTMR_future flag in set_singleshot_timer()

2023-11-07 Thread David Woodhouse
From: David Woodhouse Upstream Xen now ignores this flag¹, since the only guest kernel ever to use it was buggy. ¹ https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=19c6cbd909 Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- target/i386/kvm/xen-emu.c | 20 ++---

[PULL 14/15] xen-platform: unplug AHCI disks

2023-11-07 Thread David Woodhouse
From: David Woodhouse To support Xen guests using the Q35 chipset, the unplug protocol needs to also remove AHCI disks. Make pci_xen_ide_unplug() more generic, iterating over the children of the PCI device and destroying the "ide-hd" devices. That works the same for both AHCI and IDE, as does th

[PULL 08/15] hw/xen: do not repeatedly try to create a failing backend device

2023-11-07 Thread David Woodhouse
From: David Woodhouse If xen_backend_device_create() fails to instantiate a device, the XenBus code will just keep trying over and over again each time the bus is re-enumerated, as long as the backend appears online and in XenbusStateInitialising. The only thing which prevents the XenBus code fr

[PULL 05/15] hw/xen: populate store frontend nodes with XenStore PFN/port

2023-11-07 Thread David Woodhouse
From: David Woodhouse This is kind of redundant since without being able to get these through some other method (HVMOP_get_param) the guest wouldn't be able to access XenStore in order to find them. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/kvm/xen_xenstore.c | 11 +

[PULL 13/15] hw/i386/pc: support '-nic' for xen-net-device

2023-11-07 Thread David Woodhouse
From: David Woodhouse The default NIC creation seems a bit hackish to me. I don't understand why each platform has to call pci_nic_init_nofail() from a point in the code where it actually has a pointer to the PCI bus, and then we have the special cases for things like ne2k_isa. If qmp_device_add

[PULL 10/15] hw/xen: add support for Xen primary console in emulated mode

2023-11-07 Thread David Woodhouse
From: David Woodhouse The primary console is special because the toolstack maps a page into the guest for its ring, and also allocates the guest-side event channel. The guest's grant table is even primed to export that page using a known grant ref#. Add support for all that in emulated mode, so t

[PULL 12/15] hw/xen: update Xen PV NIC to XenDevice model

2023-11-07 Thread David Woodhouse
From: David Woodhouse This allows us to use Xen PV networking with emulated Xen guests, and to add them on the command line or hotplug. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/net/meson.build| 2 +- hw/net/trace-events | 11 + hw/net/xen_nic.c

Re: [PATCH v4 16/17] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2023-11-07 Thread David Woodhouse
On Mon, 2023-11-06 at 14:35 +, David Woodhouse wrote: > From: David Woodhouse > > We can't just embed labels directly into files like qemu-options.hx which > are included from multiple top-level RST files, because Sphinx sees the > labels as duplicate: https://github.com/sphinx-doc/sphinx/iss

Re: [PATCH v4 14/17] net: do not delete nics in net_cleanup()

2023-11-07 Thread David Woodhouse
On Mon, 2023-11-06 at 14:35 +, David Woodhouse wrote: > From: David Woodhouse > > In net_cleanup() we only need to delete the netdevs, as those may have > state which outlives Qemu when it exits, and thus may actually need to > be cleaned up on exit. > > The nics, on the other hand, are owne

[PULL 1/5] ui/gtk: force realization of drawing area

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau Fixes the GL context creation from a widget that isn't yet realized (in a hidden tab for example). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1727 Signed-off-by: Marc-André Lureau Reviewed-by: Antonio Caggiano Message-Id: <20231017111642.1155545-1-marcandr

[PULL 0/5] Ui patches

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 8aba939e77daca10eac99d9d467f65ba7df5ab3e: Merge tag 'pull-riscv-to-apply-20231107' of https://github.com/alistair23/qemu into staging (2023-11-07 11:08:16 +0800) are available in the Git repository at: https://

[PULL 3/5] ui/gtk-egl: apply scale factor when calculating window's dimension

2023-11-07 Thread marcandre . lureau
From: Dongwon Kim Scale factor needs to be applied when calculating width/height of the GTK windows. Cc: Marc-André Lureau Signed-off-by: Dongwon Kim Reviewed-by: Marc-André Lureau Message-Id: <2023101643.13996-1-dongwon@intel.com> --- ui/gtk-egl.c | 14 -- 1 file changed

[PULL 2/5] ui/gtk-egl: Check EGLSurface before doing scanout

2023-11-07 Thread marcandre . lureau
From: Antonio Caggiano The first time gd_egl_scanout_texture() is called, there's a possibility that the GTK drawing area might not be realized yet, in which case its associated GdkWindow is NULL. This means gd_egl_init() was also skipped and the EGLContext and EGLSurface stored in the VirtualGfx

[PULL 4/5] ui/cocoa: add zoom-to-fit display option

2023-11-07 Thread marcandre . lureau
From: Carwyn Ellis Provides a display option, zoom-to-fit, that enables scaling of the display when full-screen mode is enabled. Also ensures that the corresponding menu item is marked as enabled when the option is set to on. Signed-off-by: Carwyn Ellis Reviewed-by: Akihiko Odaki Message-Id:

[PULL 5/5] ui: Replacing pointer in function

2023-11-07 Thread marcandre . lureau
From: Sergey Mironov At the end of the first if we see 'vc->gfx.surface = NULL;', further checking of it is pointless. In the second if, ectx is taken. Found by Linux Verification Center (linuxtesting.org) with SVACE. Co-developed-by: Linux Verification Center Signed-off-by: Sergey Mironov Me

Re: [PATCH 12/22] configure: tell meson and contrib_plugins about DLLTOOL

2023-11-07 Thread Paolo Bonzini
On 11/6/23 19:51, Alex Bennée wrote: To cleanly handle cross-building we need to export the details of dlltool into meson's list of cross binaries and into the contrib/plugins/ make configuration. Signed-off-by: Alex Bennée Cc: Paolo Bonzini Cc: Greg Manning Reviewed-by: Paolo Bonzini --

Re: [PATCH 13/22] plugins: add dllexport and dllimport to api funcs

2023-11-07 Thread Paolo Bonzini
On 11/6/23 19:51, Alex Bennée wrote: From: Greg Manning In qemu-plugin.h, mark all API functions as __declspec(dllexport) when compiling the executables, and as __declspec(dllimport) when being used to compile plugins against. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id:

Re: [PULL 00/85] target/hppa patch queue

2023-11-07 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH 1/3] hw/virtio: check owner for removing objects

2023-11-07 Thread Albert Esteve
Shared objects lack spoofing protection. For VHOST_USER_BACKEND_SHARED_OBJECT_REMOVE messages received by the vhost-user interface, any backend was allowed to remove entries from the shared table just by knowing the UUID. Only the owner of the entry shall be allowed to removed their resources from

[PATCH 0/3] Virtio dmabuf improvements

2023-11-07 Thread Albert Esteve
Various improvements for the virtio-dmabuf module. This patch includes: - Check for ownership before allowing a vhost device to remove an object from the table. - Properly cleanup shared resources if a vhost device object gets cleaned up. - Rename virtio dmabuf functions to `virtio_dmabuf_*`

[PATCH 3/3] hw/virtio: rename virtio dmabuf API

2023-11-07 Thread Albert Esteve
Functions in the virtio-dmabuf module start with 'virtio_*', which is too generic and may not correctly identify them as part of the virtio dmabuf API. Rename all functions to 'virtio_dmabuf_*' instead to avoid confusion. Signed-off-by: Albert Esteve --- hw/display/virtio-dmabuf.c| 14 +

[PATCH 2/3] hw/virtio: cleanup shared resources

2023-11-07 Thread Albert Esteve
Ensure that we cleanup all virtio shared resources when the vhost devices is cleaned up (after a hot unplug, or a crash). To track all owned uuids of a device, add a GSList to the vhost_dev struct. This way we can avoid traversing the full table for every cleanup, whether they actually own any sha

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Paolo Bonzini
One important remark below that Greg can answer; the others are nits. On 11/6/23 19:51, Alex Bennée wrote: diff --git a/contrib/plugins/win32_linker.c b/contrib/plugins/win32_linker.c new file mode 100644 index 00..50797d616e --- /dev/null +++ b/contrib/plugins/win32_linker.c @@ -0,0 +1,

Re: [PATCH] s390/sclp: fix SCLP facility map

2023-11-07 Thread Thomas Huth
On 02/11/2023 19.50, Eric Farman wrote: (+cc qemu-devel) On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote: Qemu's SCLP implementation incorrectly reports that it supports CPU reconfiguration. If a guest issues a CPU reconfiguration request it is rejected as invalid command. Fix the SCLP

[PATCH RFC 0/2] dynamic timeout for tests

2023-11-07 Thread Michael S. Tsirkin
so we keep making timeouts longer for CI but one has to stop somewhere. netdev socket test recently failed for me again even though it's at 2 minutes already. here's an experiment for netdev-socket. if this works well for a while we can generalize to other tests. Michael S. Tsirkin (2): osdep: a

[PATCH RFC 2/2] netdev: set timeout depending on loadavg

2023-11-07 Thread Michael S. Tsirkin
netdev test keeps failing sometimes. I don't think we should increase the timeout some more: let's try something else instead, testing how busy the system is. Seems to work for me. Signed-off-by: Michael S. Tsirkin --- tests/qtest/netdev-socket.c | 28 +++- 1 file change

[PATCH RFC 1/2] osdep: add getloadavg

2023-11-07 Thread Michael S. Tsirkin
getloadavg is supported on Linux, BSDs, Solaris. Following man page: RETURN VALUE If the load average was unobtainable, -1 is returned; otherwise, the number of samples actually retrieved is returned. accordingly, make stub for systems which don't support this function return -1 for

Re: [PATCH] MAINTAINERS: Add a general architecture section for x86

2023-11-07 Thread Thomas Huth
On 16/10/2023 11.05, Thomas Huth wrote: On 29/09/2023 15.45, Thomas Huth wrote: It's a little bit weird that the files in target/i386/ which are not in a subfolder there do not have any associated maintainer (and thus nobody might be CC:-ed on changes to these files). We should have a general x8

Re: [PATCH] target/riscv: don't enable Zfa by default

2023-11-07 Thread Daniel Henrique Barboza
On 11/6/23 23:53, Jerry ZJ wrote: Use use mode QEMU can reproduce this Reproduce steps Compile: riscv64-unknown-elf-clang -march=rv32imac_zicsr_zifencei_zba_zbb ./test.c -o hello_rv32imac Run: qemu-riscv32 -cpu rv32,g=false,f=false,v=false,d=false,e=false,h=false,c=true,m=true,i=true,a=tru

Re: [PATCH] hw/arm: XLNX_VERSAL depends on XLNX_CSU_DMA

2023-11-07 Thread Philippe Mathieu-Daudé
On 7/11/23 10:03, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau Fixes: 868d968004 ("hw/arm/xlnx-versal: Connect OSPI flash controller") Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --gi

qemu-devel@nongnu.org

2023-11-07 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:09PM +, Alex Bennée wrote: > A lot of our vhost-user stubs are large chunks of boilerplate that do > (mostly) the same thing. This series continues the cleanups by > splitting the vhost-user-base and vhost-user-generic implementations. > After adding a new vq_size

Re: [PATCH 14/22] plugins: make test/example plugins work on windows

2023-11-07 Thread Greg Manning
From: Paolo Bonzini One important remark below that Greg can answer; the others are nits. > ... > I think this could also use the notification hook and dliNotePreLoadLibrary. That's a little more tidy but it's okay either way. I don't really mind. I had in mind that there might someday be a sin

Re: [PATCH RFC 0/2] dynamic timeout for tests

2023-11-07 Thread Philippe Mathieu-Daudé
Hi Michael, On 7/11/23 10:49, Michael S. Tsirkin wrote: so we keep making timeouts longer for CI but one has to stop somewhere. netdev socket test recently failed for me again even though it's at 2 minutes already. here's an experiment for netdev-socket. if this works well for a while we can gen

Re: [PATCH] MAINTAINERS: Add tests/decode/ to the "Overall TCG CPUs" section

2023-11-07 Thread Thomas Huth
On 13/10/2023 08.57, Thomas Huth wrote: The tests/decode/ folder belongs to scripts/decodetree.py, so it should be listed in the same section as the script. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45eb2304

Re: [PATCH RFC 0/2] dynamic timeout for tests

2023-11-07 Thread Michael S. Tsirkin
On Tue, Nov 07, 2023 at 10:57:23AM +0100, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 7/11/23 10:49, Michael S. Tsirkin wrote: > > so we keep making timeouts longer for CI but one has to stop > > somewhere. netdev socket test recently failed for me again > > even though it's at 2 minutes al

Re: [PATCH 02/22] gdb-xml: fix duplicate register in arm-neon.xml

2023-11-07 Thread Philippe Mathieu-Daudé
On 6/11/23 19:50, Alex Bennée wrote: Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20231103195956.1998255-3-alex.ben...@linaro.org> --- gdb-xml/arm-neon.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Cc: qemu-sta...@nongnu.org Fixes: 56aebc8916 ("Add GDB

Re: [PATCH 08/22] gdbstub: Add num_regs member to GDBFeature

2023-11-07 Thread Philippe Mathieu-Daudé
Hi Alex, On 6/11/23 19:50, Alex Bennée wrote: From: Akihiko Odaki Currently the number of registers exposed to GDB is written as magic numbers in code. Derive the number of registers GDB actually see from XML files to replace the magic numbers in code later. Signed-off-by: Akihiko Odaki Revi

Re: [PATCH v2 00/17] QEMU: CXL mailbox rework and features (Part 1)

2023-11-07 Thread Michael S. Tsirkin
> This series is focused on enabling the Fabric Management aspects of > CXL to enable orchestration and tooling development and also > to enable testing of related kernel features. This would be a better subject than "CXL mailbox" then ;)

Re: [PATCH 13/22] plugins: add dllexport and dllimport to api funcs

2023-11-07 Thread Philippe Mathieu-Daudé
On 6/11/23 19:51, Alex Bennée wrote: From: Greg Manning In qemu-plugin.h, mark all API functions as __declspec(dllexport) when compiling the executables, and as __declspec(dllimport) when being used to compile plugins against. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id:

Re: [PATCH 12/22] configure: tell meson and contrib_plugins about DLLTOOL

2023-11-07 Thread Philippe Mathieu-Daudé
On 6/11/23 19:51, Alex Bennée wrote: To cleanly handle cross-building we need to export the details of dlltool into meson's list of cross binaries and into the contrib/plugins/ make configuration. Signed-off-by: Alex Bennée Cc: Paolo Bonzini Cc: Greg Manning --- configure | 6 ++ 1 fil

[PULL 00/63] virtio,pc,pci: features, fixes

2023-11-07 Thread Michael S. Tsirkin
The following changes since commit 3e01f1147a16ca566694b97eafc941d62fa1e8d8: Merge tag 'pull-sp-20231105' of https://gitlab.com/rth7680/qemu into staging (2023-11-06 09:34:22 +0800) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea

[PULL 01/63] vhost-user.rst: Improve [GS]ET_VRING_BASE doc

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek GET_VRING_BASE does not mention that it stops the respective ring. Fix that. Furthermore, it is not fully clear what the "base offset" these commands' documentation refers to is; an offset could be many things. Be more precise and verbose about it, especially given that the

[PULL 02/63] vhost-user.rst: Clarify enabling/disabling vrings

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek Currently, the vhost-user documentation says that rings are to be initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is negotiated. However, by the time of feature negotiation, all rings have already been initialized, so it is not entirely clear what this me

[PULL 08/63] Add virtio-sound device stub

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Add a new VIRTIO device for the virtio sound device id. Functionality will be added in the following commits. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signe

[PULL 11/63] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Respond to the VIRTIO_SND_R_PCM_INFO control request with the parameters of each requested PCM stream. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed-off-b

[PULL 06/63] vhost: Add high-level state save/load functions

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek vhost_save_backend_state() and vhost_load_backend_state() can be used by vhost front-ends to easily save and load the back-end's state to/from the migration stream. Because we do not know the full state size ahead of time, vhost_save_backend_state() simply reads the data in

[PULL 12/63] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Handle the start and stop control messages for a stream_id. This request does nothing at the moment except for replying to it. Audio playback or capture will be started/stopped here in follow-up commits. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d

Re: [PATCH 15/22] plugins: disable lockstep plugin on windows

2023-11-07 Thread Philippe Mathieu-Daudé
On 6/11/23 19:51, Alex Bennée wrote: From: Greg Manning The lockstep plugin uses unix sockets and would require a different communication mechanism to work on Windows. Signed-off-by: Greg Manning Reviewed-by: Alex Bennée Message-Id: <20231102172053.17692-4-gmann...@rapitasystems.com> Signed-

[PULL 15/63] virtio-sound: handle VIRTIO_SND_R_PCM_RELEASE

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Handle the PCM release control request, which is necessary for flushing pending sound IO. No IO is handled yet so currently it only replies to the request. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor

[PULL 07/63] vhost-user-fs: Implement internal migration

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek A virtio-fs device's VM state consists of: - the virtio device (vring) state (VMSTATE_VIRTIO_DEVICE) - the back-end's (virtiofsd's) internal state We get/set the latter via the new vhost operations to transfer migratory state. It is its own dedicated subsection, so that for

[PULL 14/63] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Handles the PCM prepare control request. It initializes a PCM stream when the guests asks for it. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-off-by: Anton Yakovlev Signed-off-by: Ma

[PULL 05/63] vhost-user: Interface for migration state transfer

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek Add the interface for transferring the back-end's state during migration as defined previously in vhost-user.rst. Reviewed-by: Stefan Hajnoczi Signed-off-by: Hanna Czenczek Message-Id: <20231016134243.68248-6-hre...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-b

[PULL 24/63] tests: test-smp-parse: Add the test for cores/threads per socket helpers

2023-11-07 Thread Michael S. Tsirkin
From: Zhao Liu Use the different ways to calculate cores/threads per socket, so that the new CPU topology levels won't be missed in these 2 helpes: * machine_topo_get_cores_per_socket() * machine_topo_get_threads_per_socket() Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/ th

[PULL 10/63] virtio-sound: handle control messages and streams

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Receive guest requests in the control (CTRL) queue of the virtio sound device and reply with a NOT SUPPORTED error to all control commands. The receiving handler is virtio_snd_handle_ctrl(). It stores all control messages in the queue in the device's command queue. Then

[PULL 22/63] vdpa: Restore receive-side scaling state

2023-11-07 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch reuses vhost_vdpa_net_load_rss() with some refactorings to restore the receive-side scaling state at device's startup. Signed-off-by: Hawkins Jiawei Message-Id: Acked-by: Eugenio Pérez Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- ne

[PULL 21/63] vdpa: Add SetSteeringEBPF method for NetClientState

2023-11-07 Thread Michael S. Tsirkin
From: Hawkins Jiawei At present, to enable the VIRTIO_NET_F_RSS feature, eBPF must be loaded for the vhost backend. Given that vhost-vdpa is one of the vhost backend, we need to implement the SetSteeringEBPF method to support RSS for vhost-vdpa, even if vhost-vdpa calculates the rss hash in the

[PULL 09/63] Add virtio-sound-pci device

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis This patch adds a PCI wrapper device for the virtio-sound device. It is necessary to instantiate a virtio-snd device in a guest. All sound logic will be added to the virtio-snd device in the following commits. To add this device with a guest, you'll need a >=5.13 kernel

[PULL 29/63] tests: bios-tables-test: Add test for smbios type4 core count

2023-11-07 Thread Michael S. Tsirkin
From: Zhao Liu This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of cores in the socket is not more than 255, then smbios type4 table encodes cores per socket into the core count field. So for the topol

[PULL 39/63] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test

2023-11-07 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PULL 57/63] hw/cxl: Add support for device sanitation

2023-11-07 Thread Michael S. Tsirkin
From: Davidlohr Bueso Make use of the background operations through the sanitize command, per CXL 3.0 specs. Traditionally run times can be rather long, depending on the size of the media. Estimate times based on: https://pmem.io/documents/NVDIMM_DSM_Interface-V1.8.pdf Signed-off-by: D

[PULL 20/63] vdpa: Allow VIRTIO_NET_F_HASH_REPORT in SVQ

2023-11-07 Thread Michael S. Tsirkin
From: Hawkins Jiawei Enable SVQ with VIRTIO_NET_F_HASH_REPORT feature. Signed-off-by: Hawkins Jiawei Message-Id: Acked-by: Eugenio Pérez Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdp

[PULL 56/63] hw/cxl/mbox: Wire up interrupts for background completion

2023-11-07 Thread Michael S. Tsirkin
From: Davidlohr Bueso Notify when the background operation is done. Note that for now background commands are only supported on the main Type 3 mailbox. Signed-off-by: Davidlohr Bueso Signed-off-by: Jonathan Cameron Message-Id: <20231023160806.13206-13-jonathan.came...@huawei.com> Reviewed-by:

[PULL 17/63] virtio-sound: implement audio capture (RX)

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis To perform audio capture we duplicate the TX logic of the previous commit with the following difference: we receive data from the QEMU audio backend and write it in the virt queue IO buffers the guest sends to QEMU. When they are full (i.e. they have `period_bytes` amoun

[PULL 27/63] tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test

2023-11-07 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + * Disassembly

[PULL 25/63] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 count test

2023-11-07 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the type 4 count. Signed-off-by: Zhao Liu Reviewed-by: Michael S. Tsirkin Message-Id: <20231023094635.1588282-3-zhao1@linux.intel.com> Reviewed-by

[PULL 13/63] virtio-sound: handle VIRTIO_SND_R_PCM_SET_PARAMS

2023-11-07 Thread Michael S. Tsirkin
From: Manos Pitsidianakis Handle the set parameters control request. It reconfigures a stream based on a guest's preference if the values are valid and supported. Based-on: https://github.com/OpenSynergy/qemu/commit/5a2f350eec5d157b90d9c7b40a8e603f4da92471 Signed-off-by: Igor Skalkin Signed-of

[PULL v3 12/25] virtio-gpu: replace PIXMAN for region/rect test

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- include/ui/rect.h | 59 + hw/display/virt

[PULL v3 10/25] ui/vc: console-vc requires PIXMAN

2023-11-07 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console-vc-stubs.c | 33 + ui/console.c | 3 +++ ui/meson.build| 2 +-

[PULL 42/63] hw/cxl: CXLDVSECPortExtensions renamed to CXLDVSECPortExt

2023-11-07 Thread Michael S. Tsirkin
From: Jonathan Cameron Done to reduce line lengths where this is used. Ext seems sufficiently obvious that it need not be spelt out fully. Signed-off-by: Jonathan Cameron Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fan Ni Message-Id: <20231023140210.3089-4-jonathan.came...@huawei.com> Re

[PULL 40/63] hw/cxl: Use a switch to explicitly check size in caps_reg_read()

2023-11-07 Thread Michael S. Tsirkin
From: Jonathan Cameron Bring this read function inline with the others that do check for unexpected size values. Also reduces line lengths to sub 80 chars. Signed-off-by: Jonathan Cameron Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fan Ni Message-Id: <20231023140210.3089-2-jonathan.came

[PULL 03/63] vhost-user.rst: Introduce suspended state

2023-11-07 Thread Michael S. Tsirkin
From: Hanna Czenczek In vDPA, GET_VRING_BASE does not stop the queried vring, which is why SUSPEND was introduced so that the returned index would be stable. In vhost-user, it does stop the vring, so under the same reasoning, it can get away without SUSPEND. Still, we do want to clarify that if

  1   2   3   4   5   6   >