From: Sergey Mironov <miro...@fintech.ru> At the end of the first if we see 'vc->gfx.surface = NULL;', further checking of it is pointless. In the second if, ectx is taken.
Found by Linux Verification Center (linuxtesting.org) with SVACE. Co-developed-by: Linux Verification Center <sdl.q...@linuxtesting.org> Signed-off-by: Sergey Mironov <miro...@fintech.ru> Message-ID: <20231012104448.1251039-1-miro...@fintech.ru> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 2a4c9b84ba..be047a41ad 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1400,7 +1400,7 @@ static void gd_menu_untabify(GtkMenuItem *item, void *opaque) eglDestroySurface(qemu_egl_display, vc->gfx.esurface); vc->gfx.esurface = NULL; } - if (vc->gfx.esurface) { + if (vc->gfx.ectx) { eglDestroyContext(qemu_egl_display, vc->gfx.ectx); vc->gfx.ectx = NULL; } -- 2.41.0