Re: [PATCH v7 00/23] Make Pixman an optional dependency

2023-10-31 Thread Marc-André Lureau
Hi On Mon, Oct 30, 2023 at 9:29 PM Michael Tokarev wrote: > > (Trim Cc: list) > > 30.10.2023 13:47, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > QEMU system emulators can be made to compile and work without Pixman. > > Out of curiocity (not opposing to this

Re: [PULL 00/41] target-arm queue

2023-10-31 Thread Stefan Hajnoczi
On Fri, 27 Oct 2023 at 23:41, Peter Maydell wrote: > > Hi; here's the latest target-arm queue. Mostly this is refactoring > and cleanup type patches. Applied, thanks! Stefan > > thanks > -- PMM > > The following changes since commit c60be6e3e38cb36dc66129e757ec4b34152232be: > > Merge tag 'pul

Re: [PULL 00/21] linux-user patch queue

2023-10-31 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/1] ufs queue

2023-10-31 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and targetted interface

2023-10-31 Thread Cédric Le Goater
On 10/30/23 03:40, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Friday, October 27, 2023 10:03 PM Subject: Re: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and targetted interface On 10/26/23 12:30, Zhenzhong Duan wrote: Introduce a dumb V

[PATCH 0/1] hw/sd: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-31 Thread Philippe Mathieu-Daudé
Hi, This is an intent to automatically convert to DEFINE_TYPES(). I used a Comby script, see https://comby.dev/. Example in Comby playground: https://comby.live/#%7B%22source%22%3A%22static%20const%20TypeInfo%20pl181_info%20%3D%20%7B%5Cn%20%20%20%20.name%20%20%20%20%20%20%20%20%20%20%3D%20TYPE_P

[PATCH 1/1] hw/sd: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-31 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Mechanical transformation using the following comby script: [pattern-x1] match=''' static const TypeInf

Re: 来自Leo Hou的邮件

2023-10-31 Thread Philippe Mathieu-Daudé
Hi Leo, On 31/10/23 04:10, Leo Hou wrote: hi , all   Does qemu plan to support CPU heterogeneity? Short answer is yes. When will this be available is yet to be determined, as a lot of work is required. I'm going to talk about the challenges and possible roadmap later today, feel free to

Re: [PATCH v2 5/6] hw/input/stellaris_input: Convert to qdev

2023-10-31 Thread Philippe Mathieu-Daudé
On 30/10/23 15:25, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Peter, Cc'ing Markus for QObject. On 30/10/23 12:48, Peter Maydell wrote: Convert the hw/input/stellaris_input device to qdev. The interface uses an array property for the board to specify the keycodes to use, so

Re: [PATCH v3 07/37] vfio/container: Introduce a empty VFIOIOMMUOps

2023-10-31 Thread Cédric Le Goater
On 10/30/23 03:43, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Friday, October 27, 2023 10:21 PM Subject: Re: [PATCH v3 07/37] vfio/container: Introduce a empty VFIOIOMMUOps On 10/26/23 12:30, Zhenzhong Duan wrote: This empty VFIOIOMMUOps named vfio_legacy

Re: [PATCH v3 10/37] vfio/container: Move space field to base container

2023-10-31 Thread Cédric Le Goater
On 10/30/23 03:51, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Friday, October 27, 2023 10:46 PM Subject: Re: [PATCH v3 10/37] vfio/container: Move space field to base container On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger Move the space fie

Re: [PATCH v3 14/37] vfio/container: Move vrdl_list, pgsizes and dma_max_mappings to base container

2023-10-31 Thread Cédric Le Goater
On 10/30/23 04:14, Duan, Zhenzhong wrote: Hi Cédric, -Original Message- From: Cédric Le Goater Sent: Friday, October 27, 2023 11:52 PM Subject: Re: [PATCH v3 14/37] vfio/container: Move vrdl_list, pgsizes and dma_max_mappings to base container On 10/26/23 12:30, Zhenzhong Duan wrote:

RE: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and targetted interface

2023-10-31 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Tuesday, October 31, 2023 3:58 PM >Subject: Re: [PATCH v3 06/37] vfio: Introduce base object for VFIOContainer and >targetted interface > >On 10/30/23 03:40, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Cédric Le

Re: [PATCH 1/1] hw/sd: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-31 Thread Cédric Le Goater
On 10/31/23 09:06, Philippe Mathieu-Daudé wrote: When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Mechanical transformation using the following comby script:

Re: [PATCH 0/4] target/s390x: CC fixes

2023-10-31 Thread David Hildenbrand
On 31.10.23 06:32, Ilya Leoshkevich wrote: Hi, This series fixes two issues with updating CC. David was suggesting a bigger rewrite [1], but I did not dare do this (yet). Instead, these I started coding that up but was distracted by other things; last time I looked at that, I concluded that t

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-31 Thread Ethan Chen via
On Mon, Oct 30, 2023 at 11:02:30AM -0400, Peter Xu wrote: > On Mon, Oct 30, 2023 at 02:00:54PM +0800, Ethan Chen wrote: > > On Fri, Oct 27, 2023 at 12:13:50PM -0400, Peter Xu wrote: > > > Add cc list. > > > > > > On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > > > > On Fri, Oct 27, 202

Re: [PATCH v3 23/37] Add iommufd configure option

2023-10-31 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: This adds "--enable-iommufd/--disable-iommufd" to enable or disable iommufd support, enabled by default. It should be disabled by default for PPC. Thanks, C. Signed-off-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater --- meson.build

[PULL 01/38] migration/doc: Add contents

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-2-quint...@redhat.com> --- docs/devel/migration.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index c3e1400c0c..4d6a98ae58 100644 --- a/docs/de

[PULL 03/38] migration/doc: How to migrate when hosts have different features

2023-10-31 Thread Juan Quintela
Sometimes devices have different features depending of things outside of qemu. For instance the kernel. Document how to handle that cases. Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-4-quint...@redhat.com> --- docs/devel/migrati

[PULL 12/38] migration: Move busy++ to migrate_with_multithread

2023-10-31 Thread Juan Quintela
And now we can simplify save_compress_page(). Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-7-quint...@redhat.com> --- migration/ram-compress.c | 1 + migration/ram.c | 8 ++-- 2 files changed, 3 insertions(+),

[PULL 06/38] migration: Rename ram_handle_compressed() to ram_handle_zero()

2023-10-31 Thread Juan Quintela
Now that we know it only handles zero, we can remove the ch parameter. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20231019085259.13307-3-quint...@redhat.com> --- migration/ram.h | 2 +- migration/ram.c | 10 +- migration/rdma.c | 2 +-

[PULL 18/38] migration/ram: Fix compilation with -Wshadow=local

2023-10-31 Thread Juan Quintela
From: Thomas Huth Rename the variable here to avoid that it shadows a variable from the beginning of the function scope. With this change the code now successfully compiles with -Wshadow=local. Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <202

[PULL 07/38] migration: Give one error if trying to set MULTIFD and XBZRLE

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-2-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index 42fb818956..b8c3c3218d 100644 --- a/migration/option

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: >> >> When dump_init()'s check for non-zero @length fails, dump_cleanup() >> passes null s->string_table_buf to g_array_unref(), which spews "GLib: >> g_array_unref: assertion 'array' failed" to stderr. >

[PULL 16/38] migration: Merge flush_compressed_data() and compress_flush_data()

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-11-quint...@redhat.com> --- migration/ram-compress.h | 1 - migration/ram-compress.c | 17 ++--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/migration/ram-compress.h b/migra

[PULL 13/38] migration: Create compress_update_rates()

2023-10-31 Thread Juan Quintela
So we can move more compression_counters stuff to ram-compress.c. Create compression_counters struct to add the stuff that was on MigrationState. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-8-quint...@redhat.com> --- migra

[PULL 10/38] migration: Make compress_data_with_multithreads return bool

2023-10-31 Thread Juan Quintela
Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-5-quint...@redhat.com> --- migration/ram-compress.h | 4 ++-- migration/ram-compress.c | 17 ++--- migration/ram.c | 3 +-- 3 files changed, 13 insertions(+

[PULL 19/38] migration: rename vmstate_save_needed->vmstate_section_needed

2023-10-31 Thread Juan Quintela
From: Marc-André Lureau The function is used on save at this point. The following commits will use it on load. Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231024084043.2926316-5-marcandre.lur...@redhat.com> --- include/migration/vms

[PULL 15/38] migration: Move ram_flush_compressed_data() to ram-compress.c

2023-10-31 Thread Juan Quintela
As we export it, rename it compress_flush_data(). Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-10-quint...@redhat.com> --- migration/ram-compress.h | 1 + migration/ram-compress.c | 9 + migration/ram.c | 17 - 3 fi

[PULL 20/38] migration: set file error on subsection loading

2023-10-31 Thread Juan Quintela
From: Marc-André Lureau commit 13cde50889237 ("vmstate: Return error in case of error") sets QemuFile error to stop reading from it and report to the caller (checked by unit tests). We should do the same on subsection loading error. Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela S

[PULL 05/38] migration: Receiving a zero page non zero is an error

2023-10-31 Thread Juan Quintela
We don't allow non zero compressed pages since: commit 3edcd7e6ebae3ef0ac178eed5f4225803159562d Author: Peter Lieven Date: Tue Mar 26 10:58:35 2013 +0100 migration: search for zero instead of dup pages RDMA case is a bit more complicated, but they don't handle it since: commit a1febc4950

[PULL 26/38] migration: Stop migration immediately in RDMA error paths

2023-10-31 Thread Juan Quintela
From: Peter Xu In multiple places, RDMA errors are handled in a strange way, where it only sets qemu_file_set_error() but not stop the migration immediately. It's not obvious what will happen later if there is already an error. Make all such failures stop migration immediately. Cc: Zhijian Li

Re: [PATCH v3 29/37] vfio/iommufd: Bypass EEH if iommufd backend

2023-10-31 Thread Cédric Le Goater
On 10/31/23 03:26, Duan, Zhenzhong wrote: -Original Message- From: Cédric Le Goater Sent: Monday, October 30, 2023 9:57 PM Subject: Re: [PATCH v3 29/37] vfio/iommufd: Bypass EEH if iommufd backend On 10/26/23 12:30, Zhenzhong Duan wrote: IBM EEH is only supported by legacy backend c

[PULL 04/38] migration/doc: We broke backwards compatibility

2023-10-31 Thread Juan Quintela
When we detect that we have broken backwards compatibility in a released version, we can't do anything for that version. But once we fix that bug on the next released version, we can "mitigate" that problem when migrating to new versions to give a way out of that machine until it does a hard reboo

[PULL 00/38] Migration 20231031 patches

2023-10-31 Thread Juan Quintela
The following changes since commit fd9a38fd437c4c31705071c240f4be11394ca1f8: Merge tag 'pull-hex-20231018' of https://github.com/quic/qemu into staging (2023-10-30 13:42:29 +0900) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-202

[PULL 31/38] qemu_file: Remove unused qemu_file_transferred()

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-6-quint...@redhat.com> --- migration/qemu-file.h | 18 -- migration/qemu-file.c | 7 --- 2 files changed, 25 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h inde

[PULL 17/38] migration: Rename ram_compressed_pages() to compress_ram_pages()

2023-10-31 Thread Juan Quintela
We are moving to have all functions exported from ram-compress.c to start with compress_. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-12-quint...@redhat.com> --- migration/ram-compress.h | 2 +- migration/ram-compress.c | 2 +- migration/ram.c

[PULL 02/38] migration/doc: Add documentation for backwards compatiblity

2023-10-31 Thread Juan Quintela
State what are the requeriments to get migration working between qemu versions. And once there explain how one is supposed to implement a new feature/default value and not break migration. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20

[PULL 38/38] qemu-file: Make qemu_fflush() return errors

2023-10-31 Thread Juan Quintela
This let us simplify code of this shape. qemu_fflush(f); int ret = qemu_file_get_error(f); if (ret) { return ret; } into: int ret = qemu_fflush(f); if (ret) { return ret; } I updated all callers where there is any error check. qemu_fclose() don't need to check f

[PULL 35/38] qemu-file: Simplify qemu_file_get_error()

2023-10-31 Thread Juan Quintela
If we pass a NULL error is the same that returning directly the value. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-10-quint...@redhat.com> --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-fi

[PULL 08/38] migration: Give one error if trying to set COMPRESSION and XBZRLE

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-3-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index b8c3c3218d..37fa1cfe74 100644 --- a/migration/option

[PULL 33/38] migration: migration_transferred_bytes() don't need the QEMUFile

2023-10-31 Thread Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-8-quint...@redhat.com> --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) dif

[PULL 29/38] qemu_file: total_transferred is not used anymore

2023-10-31 Thread Juan Quintela
Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-4-quint...@redhat.com> --- migration/qemu-file.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 384985f534..641ab703cc 100644 --- a/migration/qemu-

[PULL 32/38] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

2023-10-31 Thread Juan Quintela
qemu_file_transferred() don't exist anymore, so we can reuse the name. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-7-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 9 - migration/block.c | 4 ++-- migratio

[PULL 22/38] migration: migrate 'inc' command option is deprecated.

2023-10-31 Thread Juan Quintela
Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-3-quint...@redhat.com> --- docs/about/deprecated.rst | 8 qapi/migration.json| 8

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: >>> >>> When dump_init()'s check for non-zero @length fails, dump_cleanup() >>> passes null s->string_table_buf to g_array_unref(), which spews "GLib: >>> g_array_unref:

[PULL 14/38] migration: Export send_queued_data()

2023-10-31 Thread Juan Quintela
This function is only used for compression. So we rename it as compress_send_queued_data(). We put it on ram-compress.h because we are moving it later to ram-compress.c. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-9-quint...@redhat.com> --- migrat

[PULL 21/38] qemu-iotests: Filter warnings about block migration being deprecated

2023-10-31 Thread Juan Quintela
Create a new filter that removes the two warnings for test 183. Reviewed-by: Hanna Czenczek Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-2-quint...@redhat.com> --- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 +++ 2 files changed, 8 insertio

[PULL 11/38] migration: Simplify compress_page_with_multithread()

2023-10-31 Thread Juan Quintela
Move the goto to a while true. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-6-quint...@redhat.com> --- migration/ram-compress.c | 48 1 file changed, 24 insertions(+), 24 deletions(-

[PULL 30/38] migration: Use the number of transferred bytes directly

2023-10-31 Thread Juan Quintela
We only use migration_transferred_bytes() to calculate the rate_limit, for that we don't need to flush whatever is on the qemu_file buffer. Remember that the buffer is really small (normal case is 32K if we use iov's can be 64 * TARGET_PAGE_SIZE), so this is not relevant to calculations. Reviewed-

[PULL 27/38] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer

2023-10-31 Thread Juan Quintela
We only call qemu_file_transferred_* on the sending side. Remove the increment at qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-2-quint...@redhat.com> --- migration/qemu-file.

[PULL 23/38] migration: migrate 'blk' command option is deprecated.

2023-10-31 Thread Juan Quintela
Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-4-quint...@redhat.com> --- docs/about/deprecated.rst | 9 + qapi/migration.json| 7

RE: [PATCH v3 29/37] vfio/iommufd: Bypass EEH if iommufd backend

2023-10-31 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Tuesday, October 31, 2023 5:01 PM >Subject: Re: [PATCH v3 29/37] vfio/iommufd: Bypass EEH if iommufd backend > >On 10/31/23 03:26, Duan, Zhenzhong wrote: >> >> >>> -Original Message- >>> From: Cédric Le Goater >>> Sent: Monday,

[PULL 28/38] qemu_file: Use a stat64 for qemu_file_transferred

2023-10-31 Thread Juan Quintela
This way we can read it from any thread. I checked that it gives the same value as the current one. We never use two qemu_files at the same time. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-3-quint...@redhat.com> --- migration/migration-stats.h | 4

[PULL 24/38] migration: Deprecate block migration

2023-10-31 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-5-quint...@redhat.com> --- docs/

[PULL 36/38] migration: Use migration_transferred_bytes()

2023-10-31 Thread Juan Quintela
There are only two differnces with the old value: - the amount of QEMUFile that hasn't yet been flushed. It can be discussed what is more exact, the new or the old one. - the amount of transferred bytes that we forgot to account for (the newer is better, i.e. exact). Notice that this two val

[PULL 37/38] migration: Remove transferred atomic counter

2023-10-31 Thread Juan Quintela
After last commit, it is a write only variable. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-12-quint...@redhat.com> --- migration/migration-stats.h | 4 migration/multifd.c | 3 --- migration/ram.c | 1 - 3 files changed, 8 d

[PULL 09/38] migration: Remove save_page_use_compression()

2023-10-31 Thread Juan Quintela
After previous patch, we disable the posiblity that we use compression together with xbzrle. So we can use directly migrate_compress(). Once there, now we don't need the rs parameter, so remove it. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-4-quin

[PULL 25/38] migration: Deprecate old compression method

2023-10-31 Thread Juan Quintela
Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-6-quint...@redhat.com> --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- migration/options.c

Re: [PATCH v2 28/29] migration: Add direct-io parameter

2023-10-31 Thread Daniel P . Berrangé
On Mon, Oct 30, 2023 at 07:51:34PM -0300, Fabiano Rosas wrote: > I could use some advice on how to solve this situation. The fdset code > at monitor/fds.c and the add-fd command don't seem to be usable outside > the original use-case of passing fds with different open flags. > > There are several

[PULL 34/38] migration: migration_rate_limit_reset() don't need the QEMUFile

2023-10-31 Thread Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-9-quint...@redhat.com> --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-31 Thread gaosong
在 2023/10/30 下午7:54, Jiajie Chen 写道: On 2023/10/30 16:23, gaosong wrote: 在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Chen 写道: On 2023/10/26 03:04, Richard Henderson wrote: On 10/25/23 10:13, Jiajie Chen wrote: On 2023/10/24 07:26,

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-31 Thread Jiajie Chen
On 2023/10/31 17:11, gaosong wrote: 在 2023/10/30 下午7:54, Jiajie Chen 写道: On 2023/10/30 16:23, gaosong wrote: 在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Chen 写道: On 2023/10/26 03:04, Richard Henderson wrote: On 10/25/23 10:13, Ji

Re: [PATCH] linux-user/elfload: Add missing arm64 hwcap values

2023-10-31 Thread Marielle Novastrider
> On 31 Oct 2023, at 00:56, Marielle Novastrider > wrote: > >> On 30 Oct 2023, at 09:52, Peter Maydell wrote: >> >> ...but we don't implement FEAT_MTE3 yet. We would add this feature test >> function, and the GET_FEATURE_ID() line, when we do, but we don't >> need it until then. > > Unders

Re: [PATCH v2] block/file-posix: fix update_zones_wp() caller

2023-10-31 Thread Hanna Czenczek
On 25.08.23 06:05, Sam Li wrote: When the zoned request fail, it needs to update only the wp of the target zones for not disrupting the in-flight writes on these other zones. The wp is updated successfully after the request completes. Fixed the callers with right offset and nr_zones. Signed-off

Re: [PATCH v2] block/file-posix: fix update_zones_wp() caller

2023-10-31 Thread Sam Li
Looks good, thanks! Hanna Czenczek 于2023年10月31日 周二17:24写道: > On 25.08.23 06:05, Sam Li wrote: > > When the zoned request fail, it needs to update only the wp of > the target zones for not disrupting the in-flight writes on > these other zones. The wp is updated successfully after the > request co

Re: [PATCH 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Marc-André Lureau
Hi On Tue, Oct 31, 2023 at 1:06 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Hi > >> > >> On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster > >> wrote: > >>> > >>> When dump_init()'s check for non-zero @length fails, dump_cleanup() > >>> p

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-31 Thread Juan Quintela
David Gibson wrote: > On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: >> On 10/30/23 17:38, Juan Quintela wrote: >> > Having two functions with the same name is a bad idea. As spapr only >> > uses the function locally, made it static. >> > >> > When you compile with clang, you

Re: [PATCH] ui/sdl2: use correct key names in win title on mac

2023-10-31 Thread Marc-André Lureau
On Mon, Oct 30, 2023 at 6:11 PM Adrian Wowk wrote: > > Previously, when using the SDL2 UI on MacOS, the title bar uses incorrect > key names (such as Ctrl and Alt instead of the standard MacOS key symbols > like ⌃ and ⌥). This commit changes sdl_update_caption in ui/sdl2.c to > use the correct sym

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

2023-10-31 Thread Cédric Le Goater
On 10/31/23 11:15, Juan Quintela wrote: David Gibson wrote: On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: On 10/30/23 17:38, Juan Quintela wrote: Having two functions with the same name is a bad idea. As spapr only uses the function locally, made it static. When you comp

Re: [PATCH 5/5] dump: Drop redundant check for empty dump

2023-10-31 Thread Marc-André Lureau
On Mon, Oct 30, 2023 at 5:37 PM Markus Armbruster wrote: > > dump_init() first computes the size of the dump, taking the filter > area into account, and fails if its zero. It then looks for memory in > the filter area, and fails if there is none. > > This is redundant: if the size of the dump is

Re: [PATCH 00/52] migration/rdma: Error handling fixes

2023-10-31 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Oct 04, 2023 at 08:00:34PM +0200, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >> > On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote: >> >> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote: >> >> > Oh dear, where to start. There's

[PATCH v2 4/5] dump: Improve some dump-guest-memory error messages

2023-10-31 Thread Markus Armbruster
Zero @length is rejected with "Invalid parameter 'length'". Improve to "parameter 'length' expects a non-zero length". qemu_open_old() is a wrapper around qemu_open_internal() that throws away error information. Switch to the wrapper that doesn't: qemu_create(). Example improvement: (qemu)

[PATCH v2 0/5] dump: Minor fixes & improvements

2023-10-31 Thread Markus Armbruster
v2: * PATCH 2: Use g_clear_pointer() [Marc-André] * PATCH 4: Avoid QERR_INVALID_PARAMETER_VALUE [Philippe]. Replace qemu_open_old() by qemu_create(). Markus Armbruster (5): dump: Rename qmp_dump_guest_memory() parameter to match QAPI schema dump: Fix g_array_unref(NULL) in dump-guest-memory

[PATCH v2 2/5] dump: Fix g_array_unref(NULL) in dump-guest-memory

2023-10-31 Thread Markus Armbruster
When dump_init()'s check for non-zero @length fails, dump_cleanup() passes null s->string_table_buf to g_array_unref(), which spews "GLib: g_array_unref: assertion 'array' failed" to stderr. Guard the g_array_unref(). Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- dump/dum

[PATCH v2 3/5] dump: Recognize "fd:" protocols on Windows hosts

2023-10-31 Thread Markus Armbruster
A few QMP command can work with named file descriptors. The only way to create a named file descriptor used to be QMP command getfd, which only works on POSIX hosts. Thus, named file descriptors were actually usable only there. They became usable on Windows hosts when we added QMP command get-wi

[PATCH v2 5/5] dump: Drop redundant check for empty dump

2023-10-31 Thread Markus Armbruster
dump_init() first computes the size of the dump, taking the filter area into account, and fails if its zero. It then looks for memory in the filter area, and fails if there is none. This is redundant: if the size of the dump is zero, there is no memory, and vice versa. Delete this check. Signed

[PATCH v2 1/5] dump: Rename qmp_dump_guest_memory() parameter to match QAPI schema

2023-10-31 Thread Markus Armbruster
The name of the second parameter differs between QAPI schema and C implementation: it's @protocol in the former and @file in the latter. Potentially confusing. Change the C implementation to match the QAPI schema. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau --- dump/dump.c

prefix gets lost on config regen for cross Windows build

2023-10-31 Thread Matheus Tavares Bernardino
[resending as it looks like there was some delivery issue with the first msg] Hi, It seems that we lose the install prefix option when regenerating config for a Windows cross-build. Looks like this behavior appeared with c36dd41ba2 (configure: move target-specific defaults to an external machine

Re: [PATCH] target/arm: Fix SVE STR increment

2023-10-31 Thread Peter Maydell
On Mon, 30 Oct 2023 at 19:04, Richard Henderson wrote: > > The previous change missed updating one of the increments. > > Cc: qemu-sta...@nongnu.org > Fixes: e6dd5e782be ("target/arm: Use tcg_gen_qemu_{ld, st}_i128 in > gen_sve_{ld, st}r") > Signed-off-by: Richard Henderson > --- > target/arm/t

RE: [PATCH v3 23/37] Add iommufd configure option

2023-10-31 Thread Duan, Zhenzhong
Hi All, >-Original Message- >From: Cédric Le Goater >Sent: Tuesday, October 31, 2023 4:59 PM >Subject: Re: [PATCH v3 23/37] Add iommufd configure option > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> This adds "--enable-iommufd/--disable-iommufd" to enable or disable >> iommufd support, e

Re: [PATCH] linux-user/elfload: Add missing arm64 hwcap values

2023-10-31 Thread Peter Maydell
On Tue, 31 Oct 2023 at 09:23, Marielle Novastrider wrote: > > > > > On 31 Oct 2023, at 00:56, Marielle Novastrider > > wrote: > > > >> On 30 Oct 2023, at 09:52, Peter Maydell wrote: > >> > >> ...but we don't implement FEAT_MTE3 yet. We would add this feature test > >> function, and the GET_FEAT

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-31 Thread gaosong
在 2023/10/31 下午5:13, Jiajie Chen 写道: On 2023/10/31 17:11, gaosong wrote: 在 2023/10/30 下午7:54, Jiajie Chen 写道: On 2023/10/30 16:23, gaosong wrote: 在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Chen 写道: On 2023/10/26 03:04, Richard He

Re: [PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-10-31 Thread Juan Quintela
Markus Armbruster wrote: > Peter Xu writes: > >> On Wed, Oct 11, 2023 at 04:21:02PM +0200, Markus Armbruster wrote: >> IIRC both of them used to be the goals: either allow compat properties for >> old machine types, or specify migration parameters in cmdline for easier >> debugging and tests. I

Re: [PATCH v2 12/12] qdev: Rework array properties based on list visitor

2023-10-31 Thread Kevin Wolf
Am 30.10.2023 um 21:48 hat Mark Cave-Ayland geschrieben: > On 30/10/2023 14:26, Kevin Wolf wrote: > > > Until now, array properties are actually implemented with a hack that > > uses multiple properties on the QOM level: a static "foo-len" property > > and after it is set, dynamically created "foo

Re: [PATCH 0/5] Add LoongArch v1.1 instructions

2023-10-31 Thread Jiajie Chen
On 2023/10/31 19:06, gaosong wrote: 在 2023/10/31 下午5:13, Jiajie Chen 写道: On 2023/10/31 17:11, gaosong wrote: 在 2023/10/30 下午7:54, Jiajie Chen 写道: On 2023/10/30 16:23, gaosong wrote: 在 2023/10/28 下午9:09, Jiajie Chen 写道: On 2023/10/26 14:54, gaosong wrote: 在 2023/10/26 上午9:38, Jiajie Che

[PATCH 1/7] spapr/pci: Correct "does not support hotplugging error messages

2023-10-31 Thread Markus Armbruster
When dynamic-reconfiguration is off, hot plug / unplug can fail with "Bus 'spapr-pci-host-bridge' does not support hotplugging". spapr-pci-host-bridge is a device, not a bus. Report the name of the bus it provides instead: 'pci.0'. Signed-off-by: Markus Armbruster --- hw/ppc/spapr_pci.c | 4 ++-

[PATCH 5/7] net: Fix a misleading error message

2023-10-31 Thread Markus Armbruster
The error message $ qemu-system-x86_64 -netdev user,id=net0,ipv6-net=fec0::0/ qemu-system-x86_64: -netdev user,id=net0,ipv6-net=fec0::0/: Parameter 'ipv6-prefixlen' expects a number points to ipv6-prefixlen instead of ipv6-net. Fix: qemu-system-x86_64: -netdev user,id=net0,ipv6-net

[PATCH 6/7] balloon: Fix a misleading error message

2023-10-31 Thread Markus Armbruster
The error message {"execute": "balloon", "arguments":{"value": -1}} {"error": {"class": "GenericError", "desc": "Parameter 'target' expects a size"}} points to 'target' instead of 'value'. Fix: {"error": {"class": "GenericError", "desc": "Parameter 'value' expects a size"}} Root

[PATCH 2/7] hmp: Improve sync-profile error message

2023-10-31 Thread Markus Armbruster
Improve (qemu) sync-profile of Error: Invalid parameter 'of' to Error: invalid parameter 'of', expecting 'on', 'off', or 'reset' Signed-off-by: Markus Armbruster --- monitor/hmp-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor/hmp-cmds.c b/mon

[PATCH 0/7] Miscellaneous error message improvements

2023-10-31 Thread Markus Armbruster
Markus Armbruster (7): spapr/pci: Correct "does not support hotplugging error messages hmp: Improve sync-profile error message qga: Improve guest-exec-status error message ui/qmp-cmds: Improve two error messages net: Fix a misleading error message balloon: Fix a misleading error message

[PATCH 7/7] target/i386/cpu: Improve error message for property "vendor"

2023-10-31 Thread Markus Armbruster
Improve $ qemu-system-x86_64 -device max-x86_64-cpu,vendor=me qemu-system-x86_64: -device max-x86_64-cpu,vendor=me: Property '.vendor' doesn't take value 'me' to qemu-system-x86_64: -device max-x86_64-cpu,vendor=0123456789abc: value of property 'vendor' must consist of excactly 12

[PATCH 3/7] qga: Improve guest-exec-status error message

2023-10-31 Thread Markus Armbruster
When the PID passed to guest-exec-status does not exist, we report "Invalid parameter 'pid'" Improve this to "PID 1234 does not exist" Signed-off-by: Markus Armbruster --- qga/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands.c b/qga/commands.

[PATCH 4/7] ui/qmp-cmds: Improve two error messages

2023-10-31 Thread Markus Armbruster
set_password with "protocol": "vnc" supports only "connected": "keep". Any other value is rejected with Invalid parameter 'connected' Improve this to parameter 'connected' must be 'keep' when 'protocol' is 'vnc' client_migrate_info requires "port" or "tls-port". When both are missing,

Re: [PATCH 3/7] qga: Improve guest-exec-status error message

2023-10-31 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Oct 31, 2023 at 1:11 PM Markus Armbruster wrote: > When the PID passed to guest-exec-status does not exist, we report > > "Invalid parameter 'pid'" > > Improve this to > > "PID 1234 does not exist" > > Signed-off-by: Markus Armbruster > --- > qg

Re: [PATCH v3 23/37] Add iommufd configure option

2023-10-31 Thread Cédric Le Goater
On 10/31/23 11:52, Duan, Zhenzhong wrote: Hi All, -Original Message- From: Cédric Le Goater Sent: Tuesday, October 31, 2023 4:59 PM Subject: Re: [PATCH v3 23/37] Add iommufd configure option On 10/26/23 12:30, Zhenzhong Duan wrote: This adds "--enable-iommufd/--disable-iommufd" to en

Re: [PATCH v2 1/5] migration: Set downtime_start even for postcopy

2023-10-31 Thread Juan Quintela
Peter Xu wrote: > Postcopy calculates its downtime separately. It always sets > MigrationState.downtime properly, but not MigrationState.downtime_start. > > Make postcopy do the same as other modes on properly recording the > timestamp when the VM is going to be stopped. Drop the temporary varia

Re: [PATCH v2 2/5] migration: Add migration_downtime_start|end() helpers

2023-10-31 Thread Juan Quintela
Peter Xu wrote: > Unify the three users on recording downtimes with the same pair of helpers. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela queued.

Re: PATCH: #1938: [ARM/PL011] Wrong UART register spacing reported in DBG2/SPCR

2023-10-31 Thread Peter Maydell
On Sat, 21 Oct 2023 at 13:33, Udo Steinberg wrote: > > > From: Udo Steinberg > Date: Sat, 21 Oct 2023 14:10:30 +0200 > Subject: [PATCH] hw/arm/virt: Report correct register sizes in ACPI DBG2/SPCR > tables. > > Documentation for using the GAS in ACPI tables to report debug UART addresses > at >

Re: [PATCH 1/2] block: Fix locking in media change monitor commands

2023-10-31 Thread Hanna Czenczek
On 13.10.23 17:33, Kevin Wolf wrote: blk_insert_bs() requires that the caller holds the AioContext lock for the node to be inserted. Since commit c066e808e11, neglecting to do so causes a crash when the child has to be moved to a different AioContext to attach it to the BlockBackend. This fixes

  1   2   3   4   >