Re: [PATCH 0/2] audio/jackaudio: avoid dynamic stack allocations

On Tue, Sep 12, 2023 at 03:19:08PM +0100, Peter Maydell wrote: > Hi Gerd; this series has been reviewed. Did you want to take it > via the audio tree? Or I can put it in via target-arm.next > if you prefer. arm tree is fine with me. take care, Gerd

Re: [RFC PATCH v2 1/2] hw/riscv: hart: replace array access with qemu_get_cpu()

Hello Alistair! On Mon, 2023-09-18 at 11:50 +1000, Alistair Francis wrote: > On Thu, Sep 14, 2023 at 6:09 PM Nikita Shubin > wrote: > > > > From: Nikita Shubin > > > > Replace all RISCVHartArrayState->harts[idx] with > > qemu_get_cpu()/cpu_by_arch_id(). > > Thanks for the patch > > Why do we

[PATCH] hw/misc/mips_itu: Make MIPSITUState target agnostic

When prototyping a heterogenous machine including the ITU, we get: include/hw/misc/mips_itu.h:76:5: error: unknown type name 'MIPSCPU' MIPSCPU *cpu0; ^ MIPSCPU is declared in the target specific "cpu.h" header, but we don't want to include it, because "cpu.h" is target specific and

Re: [PATCH 01/21] parallels: fix formatting in bdrv_parallels initialization

On 9/15/23 20:41, Denis V. Lunev wrote: Old code is ugly and contains tabulations. There are no functional changes in this patch. Signed-off-by: Denis V. Lunev --- block/parallels.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/blo

Re: [PATCH 01/21] parallels: fix formatting in bdrv_parallels initialization

On 9/15/23 20:41, Denis V. Lunev wrote: Old code is ugly and contains tabulations. There are no functional changes in this patch. Signed-off-by: Denis V. Lunev --- block/parallels.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/blo

Re: [PATCH 02/21] parallels: mark driver as supporting CBT

On 9/15/23 20:41, Denis V. Lunev wrote: Parallels driver indeed support Parallels Dirty Bitmap Feature in read-only mode. The patch adds bdrv_supports_persistent_dirty_bitmap() callback which always return 1 to indicate that. This will allow to copy CBT from Parallels image with qemu-img. Note:

Re: [PULL 01/39] accel/tcg: mttcg remove false-negative halted assertion

"Nicholas Piggin" writes: > On Sat Sep 16, 2023 at 1:29 PM AEST, Richard Henderson wrote: >> From: Nicholas Piggin >> >> mttcg asserts that an execution ending with EXCP_HALTED must have >> cpu->halted. However between the event or instruction that sets >> cpu->halted and requests exit and the

Re: [PATCH v3 36/39] accel: Introduce accel_cpu_unrealize() stub

On 16/9/23 23:41, Richard Henderson wrote: From: Philippe Mathieu-Daudé Prepare the stub for parity with accel_cpu_realize(). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230915190009.68404-3-phi...@linaro.org> Signed-off-by: Richard Henderson --- include/qemu/accel.h | 6 ++

Re: [PATCH 04/21] parallels: return earler in fail_format branch in parallels_open()

This is not the case with this patch, but it seems that the 5 first "goto fail;" could be replaced by returns. The first allocation, freeing at the "fail" label, is at 1127 line. The next error handling and all the previous ones can make return instead goto fail. On 9/15/23 20:41, Denis V. Lun

Re: [PATCH 04/21] parallels: return earler in fail_format branch in parallels_open()

On 9/15/23 20:41, Denis V. Lunev wrote: We do not need to perform any deallocation/cleanup if wrong format is detected. Signed-off-by: Denis V. Lunev --- block/parallels.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index 1d5409

Re: [PATCH 04/21] parallels: return earler in fail_format branch in parallels_open()

Oh, sorry, I see it in the next patch. =) On 9/18/23 10:14, Alexander Ivanov wrote: This is not the case with this patch, but it seems that the 5 first "goto fail;" could be replaced by returns. The first allocation, freeing at the "fail" label, is at 1127 line. The next error handling and all

Re: [PATCH 05/21] parallels: return earlier from parallels_open() function on error

On 9/15/23 20:41, Denis V. Lunev wrote: At the beginning of the function we can return immediately until we really allocate s->header. Signed-off-by: Denis V. Lunev --- block/parallels.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/block/parallels.c b/bl

Re: [PATCH 04/21] parallels: return earler in fail_format branch in parallels_open()

On 9/18/23 10:14, Alexander Ivanov wrote: This is not the case with this patch, but it seems that the 5 first "goto fail;" could be replaced by returns. The first allocation, freeing at the "fail" label, is at 1127 line. The next error handling and all the previous ones can make return instead

Re: [PATCH v3 2/4] qcow2: add configurations for zoned format extension

Markus Armbruster 于2023年9月1日周五 19:08写道： > > Sam Li writes: > > > To configure the zoned format feature on the qcow2 driver, it > > requires following arguments: the device size, zoned profile, > > "Zoned profile" is gone in v3. > > > zone model, zone size, zone capacity, number of conventional >

[PULL V2 03/17] virtio-net: Add USO flags to vhost support.

From: Andrew Melnychenko New features are subject to check with vhost-user and vdpa. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- hw/net/vhost_net.c | 3 +++ net/vhost-vdpa.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/hw/net/v

Re: [PATCH 06/21] parallels: refactor path when we need to re-check image in parallels_open

On 9/15/23 20:41, Denis V. Lunev wrote: More conditions follows thus the check should be more scalable. Signed-off-by: Denis V. Lunev --- block/parallels.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 8f2

[PULL V2 00/17] Net patches

The following changes since commit 005ad32358f12fe9313a4a01918a55e60d4f39e5: Merge tag 'pull-tpm-2023-09-12-3' of https://github.com/stefanberger/qemu-tpm into staging (2023-09-13 13:41:57 -0400) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-requ

[PULL V2 02/17] tap: Add check for USO features

From: Yuri Benditovich Tap indicates support for USO features according to capabilities of current kernel module. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychecnko Signed-off-by: Jason Wang --- include/net/net.h | 3 +++ net/net.c | 9 + net/tap-bsd.c |

[PULL V2 09/17] igb: add IPv6 extended headers traffic detection

From: Tomasz Dzieciol Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/igb_core.c | 4 +++- hw/net/igb_regs.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c inde

[PULL V2 05/17] igb: remove TCP ACK detection

From: Tomasz Dzieciol TCP ACK detection is no longer present in igb. Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/igb_core.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core

[PULL V2 13/17] net: add initial support for AF_XDP network backend

From: Ilya Maximets AF_XDP is a network socket family that allows communication directly with the network device driver in the kernel, bypassing most or all of the kernel networking stack. In the essence, the technology is pretty similar to netmap. But, unlike netmap, AF_XDP is Linux-native and

[PULL V2 16/17] net/dump: Avoid variable length array

From: Peter Maydell Use a g_autofree heap allocation instead of a variable length array in dump_receive_iov(). The codebase has very few VLAs, and if we can get rid of them all we can make the compiler error on new additions. This is a defensive measure against security bugs where an on-stack d

[PULL V2 08/17] igb: RX payload guest writting refactoring

From: Tomasz Dzieciol Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 18 ++--

[PULL V2 04/17] virtio-net: Add support for USO features

From: Yuri Benditovich USO features of virtio-net device depend on kernel ability to support them, for backward compatibility by default the features are disabled on 8.0 and earlier. Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychecnko Signed-off-by: Jason Wang --- hw/core/mach

[PULL V2 14/17] hw/net/fsl_etsec/rings.c: Avoid variable length array

From: Peter Maydell In fill_rx_bd() we create a variable length array of size etsec->rx_padding. In fact we know that this will never be larger than 64 bytes, because rx_padding is set in rx_init_frame() in a way that ensures it is only that large. Use a fixed sized array and assert that it is bi

[PULL V2 17/17] net/tap: Avoid variable-length array

From: Peter Maydell Use a heap allocation instead of a variable length array in tap_receive_iov(). The codebase has very few VLAs, and if we can get rid of them all we can make the compiler error on new additions. This is a defensive measure against security bugs where an on-stack dynamic alloc

[PULL V2 10/17] igb: packet-split descriptors support

From: Tomasz Dzieciol Packet-split descriptors are used by Linux VF driver for MTU values from 2048 Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/igb_core.c | 348 +---

[PULL V2 11/17] e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers

From: Tomasz Dzieciol Rename e1000e_ba_state according and e1000e_write_hdr_to_rx_buffers for consistency with IGB. Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 28 +++- 1 file

[PULL V2 01/17] tap: Add USO support to tap device.

From: Andrew Melnychenko Passing additional parameters (USOv4 and USOv6 offloads) when setting TAP offloads Signed-off-by: Yuri Benditovich Signed-off-by: Andrew Melnychenko Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c| 2 +- hw/net/virtio-net.c | 4 ++

[PULL V2 06/17] igb: rename E1000E_RingInfo_st

From: Tomasz Dzieciol Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide. Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 34 +- hw/net/igb_core

[PULL V2 12/17] tests: bump libvirt-ci for libasan and libxdp

From: Ilya Maximets This pulls in the fixes for libasan version as well as support for libxdp that will be used for af-xdp netdev in the next commits. Signed-off-by: Ilya Maximets Reviewed-by: Daniel P. Berrangé Signed-off-by: Jason Wang --- tests/docker/dockerfiles/debian-amd64-cross.docker

[PULL V2 15/17] hw/net/rocker: Avoid variable length array

From: Peter Maydell Replace an on-stack variable length array in of_dpa_ig() with a g_autofree heap allocation. The codebase has very few VLAs, and if we can get rid of them all we can make the compiler error on new additions. This is a defensive measure against security bugs where an on-stack

[PULL V2 07/17] igb: RX descriptors guest writting refactoring

From: Tomasz Dzieciol Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki Signed-off-by: Jason Wang --- hw/net/igb_core.c | 170 +

Re: [QEMU PATCH v5 09/13] virtio-gpu: Handle resource blob commands

On Sat, Sep 16, 2023 at 12:04:17AM +0800, Akihiko Odaki wrote: > On 2023/09/15 20:11, Huang Rui wrote: > > From: Antonio Caggiano > > > > Support BLOB resources creation, mapping and unmapping by calling the > > new stable virglrenderer 0.10 interface. Only enabled when available and > > via the

Re: [QEMU PATCH v5 09/13] virtio-gpu: Handle resource blob commands

On 2023/09/18 17:36, Huang Rui wrote: On Sat, Sep 16, 2023 at 12:04:17AM +0800, Akihiko Odaki wrote: On 2023/09/15 20:11, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when av

Re: [PATCH 07/21] parallels: create mark_used() helper which sets bit in used bitmap

On 9/15/23 20:41, Denis V. Lunev wrote: This functionality is used twice already and next patch will add more code with it. Signed-off-by: Denis V. Lunev --- block/parallels.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/block/parall

Re: [PATCH 1/3] vdpa net: fix error message setting virtio status

On Sat, Sep 16, 2023 at 1:03 AM Eugenio Pérez wrote: > > It incorrectly prints "error setting features", probably because a copy > paste miss. > > Reported-by: Peter Maydell > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > net/vhost-vdpa.c | 2 +- > 1 file changed, 1 inser

Re: [PATCH 2/3] vdpa net: stop probing if cannot set features

On Sat, Sep 16, 2023 at 1:03 AM Eugenio Pérez wrote: > > Otherwise it continues the CVQ isolation probing. > > Reported-by: Peter Maydell > Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Thanks > --- > net/vhost-vdpa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/vhost-vd

Re: [PATCH v3 2/4] qcow2: add configurations for zoned format extension

Stefan Hajnoczi 于2023年9月14日周四 04:12写道： > > On Mon, Aug 28, 2023 at 11:09:53PM +0800, Sam Li wrote: > > To configure the zoned format feature on the qcow2 driver, it > > requires following arguments: the device size, zoned profile, > > zone model, zone size, zone capacity, number of conventional >

Re: [PATCH] MAINTAINERS: Nick Piggin PPC maintainer, other PPC changes

On 18/09/2023 16:45, Nicholas Piggin wrote: On Fri Sep 15, 2023 at 9:05 PM AEST, Daniel Henrique Barboza wrote: Update all relevant PowerPC entries as follows: - Nick Piggin is promoted to Maintainer in all qemu-ppc subsystems. Nick has been a solid contributor for the last couple of year

Re: [PATCH 3/3] vdpa net: follow VirtIO initialization properly at cvq isolation probing

On Sat, Sep 16, 2023 at 1:03 AM Eugenio Pérez wrote: > > This patch solves a few issues. The most obvious is that the feature > set was done previous to ACKNOWLEDGE | DRIVER status bit set. Current > vdpa devices are permissive with this, but it is better to follow the > standard. > > Signed-off

Re: [PATCH 08/21] tests: ensure that image validation will not cure the corruption

On 9/15/23 20:41, Denis V. Lunev wrote: Since commit cfce1091d55322789582480798a891cbaf66924e Author: Alexander Ivanov Date: Tue Jul 18 12:44:29 2023 +0200 parallels: Image repairing in parallels_open() there is a potential pit fall with calling qemu-io -c "read" The i

Re: Call for agenda for 2023-09-19 QEMU developers call

Seems like we’ve had a bit of a ’slower’ time in recent weeks - presumably “summer time” - If I understand correctly, Linaro are not going toe preset this week? Maybe we should re-group in the next meeting, So I’m happy to have the meeting tomorrow if Linaro can make it, otherwise for 3rd Oct,

Re: [PATCH 09/21] parallels: fix broken parallels_check_data_off()

On 9/15/23 20:41, Denis V. Lunev wrote: Once we have repaired data_off field in the header we should update s->data_start which is calculated on the base of it. Signed-off-by: Denis V. Lunev --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/p

[PATCH v3] spapr: Remove support for NVIDIA V100 GPU with NVLink2

From: Cédric Le Goater NVLink2 support was removed from the PPC PowerNV platform and VFIO in Linux 5.13 with commits : 562d1e207d32 ("powerpc/powernv: remove the nvlink support") b392a1989170 ("vfio/pci: remove vfio_pci_nvlink2") This was 2.5 years ago. Do the same in QEMU with a revert of

Re: [PATCH 10/21] parallels: add test which will validate data_off fixes through repair

On 9/15/23 20:41, Denis V. Lunev wrote: We have only check through self-repair and that proven to be not enough. Signed-off-by: Denis V. Lunev --- tests/qemu-iotests/tests/parallels-checks | 17 + tests/qemu-iotests/tests/parallels-checks.out | 18 ++ 2 f

Re: [Stable-8.1.1 11/34] softmmu: Assert data in bounds in iotlb_to_section

09.09.2023 13:27, Michael Tokarev wrote: From: Richard Henderson Acked-by: Alex Bennée Suggested-by: Alex Bennée Signed-off-by: Richard Henderson (cherry picked from commit 86e4f93d827d3c1efd00cd8a906e38a2c0f2b5bc) Signed-off-by: Michael Tokarev diff --git a/softmmu/physmem.c b/softmmu/phy

Re: [PATCH] mem/x86: add processor address space check for VM memory

/* * The 64bit pci hole starts after "above 4G RAM" and * potentially the space reserved for memory hotplug. */ There is the ROUND_UP(hole64_start, 1 * GiB); in there that is not really required for the !hole64 case. It shouldn't matter much in practice I think (besides an aligned value

[PATCH v2 4/4] vfio/pci: enable MSI-X in interrupt restoring on dynamic allocation

During migration restoring, vfio_enable_vectors() is called to restore enabling MSI-X interrupts for assigned devices. It sets the range from 0 to nr_vectors to kernel to enable MSI-X and the vectors unmasked in guest. During the MSI-X enabling, all the vectors within the range are allocated accord

[PATCH v2 3/4] vfio/pci: use an invalid fd to enable MSI-X

Guests typically enable MSI-X with all of the vectors masked in the MSI-X vector table. To match the guest state of device, QEMU enables MSI-X by enabling vector 0 with userspace triggering and immediately release. However the release function actually does not release it due to already using users

[PATCH v2 2/4] vfio/pci: enable vector on dynamic MSI-X allocation

The vector_use callback is used to enable vector that is unmasked in guest. The kernel used to only support static MSI-X allocation. When allocating a new interrupt using "static MSI-X allocation" kernels, QEMU first disables all previously allocated vectors and then re-allocates all including the

[PATCH v2 1/4] vfio/pci: detect the support of dynamic MSI-X allocation

Kernel provides the guidance of dynamic MSI-X allocation support of passthrough device, by clearing the VFIO_IRQ_INFO_NORESIZE flag to guide user space. Fetch the flags from host to determine if dynamic MSI-X allocation is supported. Originally-by: Reinette Chatre Signed-off-by: Jing Liu Review

[PATCH v2 0/4] Support dynamic MSI-X allocation

Changes since v1: - v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg982842.html - Revise Qemu to QEMU. (Cédric) - Add g_free when failure of getting MSI-X irq info. (Cédric) - Apply Cédric's Reviewed-by. (Cédric) - Use g_autofree to automatically release. (Cédric) - Remove the failure mes

Re: [PULL 2/3] seabios: turn off CONFIG_APMBIOS for 128k build

On Tue, Sep 12, 2023 at 03:55:03PM +0200, Paolo Bonzini wrote: > On 9/12/23 12:53, Gerd Hoffmann wrote: > > Needed to make the build fit into 128k. > > > > Signed-off-by: Gerd Hoffmann > > --- > > roms/config.seabios-128k | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/roms/con

[PATCH v4 0/4] Add full zoned storage emulation to qcow2 driver

This patch series add a new extension - zoned format - to the qcow2 driver thereby allowing full zoned storage emulation on the qcow2 img file. Users can attach such a qcow2 file to the guest as a zoned device. Write pointer are preserved in the zoned metadata. It will be recovered after power cyc

[PATCH v4 1/4] docs/qcow2: add the zoned format feature

Add the specs for the zoned format feature of the qcow2 driver. The qcow2 file can be taken as zoned device and passed through by virtio-blk device or NVMe ZNS device to the guest given zoned information. Signed-off-by: Sam Li --- docs/system/qemu-block-drivers.rst.inc | 33 +

[PATCH v4 2/4] qcow2: add configurations for zoned format extension

To configure the zoned format feature on the qcow2 driver, it requires settings as: the device size, zone model, zone size, zone capacity, number of conventional zones, limits on zone resources (max append sectors, max open zones, and max_active_zones). To create a qcow2 file with zoned format, us

[PATCH v4 4/4] iotests: test the zoned format feature for qcow2 file

The zoned format feature can be tested by: $ tests/qemu-iotests/check -qcow2 zoned-qcow2 Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/tests/zoned-qcow2 | 129 ++ tests/qemu-iotests/tests/zoned-qcow2.out | 133 +++ 2 files

[PATCH v4 3/4] qcow2: add zoned emulation capability

By adding zone operations and zoned metadata, the zoned emulation capability enables full emulation support of zoned device using a qcow2 file. The zoned device metadata includes zone type, zoned device state and write pointer of each zone, which is stored to an array of unsigned integers. Each zo

Re: [PULL 0/3] Firmware/seabios 20230912 patches

> Hi Gerd, > I think either this pull request or your edk2 pull request causes the > following CI failure: > > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh > >>> QTEST_QEMU_BINARY=./qemu-system-aarch64 MALLOC_PERTURB_=199 > >>> /builds/qemu-project/qemu/build/tes

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, 18 Sept, 2023, 3:03 pm David Hildenbrand, wrote: > >> > /* > * The 64bit pci hole starts after "above 4G RAM" and > * potentially the space reserved for memory hotplug. > */ > > There is the > ROUND_UP(hole64_start, 1 * GiB); > in there that is n

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 12:07, Ani Sinha wrote: On Mon, 18 Sept, 2023, 3:03 pm David Hildenbrand, > wrote: >> /* * The 64bit pci hole starts after "above 4G RAM" and * potentially the space reserved for memory hotplug. */

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

The following changes since commit 005ad32358f12fe9313a4a01918a55e60d4f39e5: Merge tag 'pull-tpm-2023-09-12-3' of https://github.com/stefanberger/qemu-tpm into staging (2023-09-13 13:41:57 -0400) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slo

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, 18 Sept, 2023, 3:39 pm David Hildenbrand, wrote: > On 18.09.23 12:07, Ani Sinha wrote: > > > > > > On Mon, 18 Sept, 2023, 3:03 pm David Hildenbrand, > > wrote: > > > > >> > > /* > > * The 64bit pci hole starts after "above 4G RAM" and > >

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, 18 Sept, 2023, 3:41 pm Ani Sinha, wrote: > > > On Mon, 18 Sept, 2023, 3:39 pm David Hildenbrand, > wrote: > >> On 18.09.23 12:07, Ani Sinha wrote: >> > >> > >> > On Mon, 18 Sept, 2023, 3:03 pm David Hildenbrand, > > > wrote: >> > >> > >> >> > /* >>

[PATCH 0/2] qdev: Ensure devices are fully realized when calling DeviceReset handler

In the process of clarifying QOM/QDev design, we want to enforce the QDev state machine, in particular RESET can only happens *after* REALIZE. Besides CPUs (which are still particular), the only case I noticed is in a non-QDev type (OMAP MMC) accessing a QDev one (SD/MMC card). The first patch fi

[PATCH 1/2] hw/sd/omap_mmc: Do not reset SDCard until being fully realized

We shouldn't call QDev DeviceReset() before DeviceRealize(). Since the OMAP MMC model is not QDev'ified, it has to manually call the SDCard reset() handler. This breaks QDev assumptions that DeviceReset() is never called before a device is fully realized. In order to avoid that, pass a 'realized'

[PATCH 2/2] qdev: Ensure devices are fully realized when calling DeviceReset handler

We shouldn't call a DeviceReset() handler on unrealized device. In order to enforce that, add an assertion. CPU devices are a bit particular because we manually reset them in various places, so corner case them out for now. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 3 +++ 1 fil

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 12:11, Ani Sinha wrote: Ok hopefully my last question. I am still confused on something. Does the above mean that the hole64 will actually start from an address that is beyond maxram? Like basically if you added all of ram_below_4G, ram_above_4G, hot plug_mem and pci

Re: [PATCH 2/3] backends: Initial support for SPDM socket support

On Mon, 18 Sep 2023 13:16:01 +1000 Alistair Francis wrote: > On Sat, Sep 16, 2023 at 1:19 AM Jonathan Cameron > wrote: > > > > On Fri, 15 Sep 2023 21:27:22 +1000 > > Alistair Francis wrote: > > > > > From: Huai-Cheng Kuo > > > > Great to see you taking this forwards! > > > > > > > > > >

Re: [PATCH] MAINTAINERS: Nick Piggin PPC maintainer, other PPC changes

On 9/18/23 02:01, Nicholas Piggin wrote: Hi Daniel, Thank you for your stwardship of ppc, I might hope to do half as good a job with it as you have. And to Greg and David for all the work over the years. I'm pretty sure you'll be great :D and both Cedric and I will be around if you need ass

Re: [PATCH] MAINTAINERS: Nick Piggin PPC maintainer, other PPC changes

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 9/15/23 08:05, Daniel Henrique Barboza wrote: Update all relevant PowerPC entries as follows: - Nick Piggin is promoted to Maintainer in all qemu-ppc subsystems. Nick has been a solid contributor for the last couple of ye

Re: [PATCH v3] spapr: Remove support for NVIDIA V100 GPU with NVLink2

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 9/18/23 06:17, Cédric Le Goater wrote: From: Cédric Le Goater NVLink2 support was removed from the PPC PowerNV platform and VFIO in Linux 5.13 with commits : 562d1e207d32 ("powerpc/powernv: remove the nvlink support")

Re: [PATCH v2] ppc/xive: Fix uint32_t overflow

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 9/14/23 12:46, Cédric Le Goater wrote: As reported by Coverity, "idx << xive->pc_shift" is evaluated using 32-bit arithmetic, and then used in a context expecting a "uint64_t". Add a uint64_t cast. Fixes: Coverity CID 1519049

[PATCH 0/3] accel: Factor tcg_cpu_reset_hold() out of cpu-common.c

Hi, We want to have exec/ code agnostic to accelerators. still we use various call to TCG and KVM. This series factor the TCG code from cpu_common_reset_hold() to an accel-specific handler within AccelOpsClass. Based-on: <20230915190009.68404-1-phi...@linaro.org> Philippe Mathieu-Daudé (3): ac

[PATCH 1/3] accel/tcg: Declare tcg_flush_jmp_cache() in 'exec/tb-flush.h'

"exec/cpu-common.h" is meant to contain the declarations related to CPU usable with any accelerator / target combination. tcg_flush_jmp_cache() is specific to TCG, so restrict its declaration by moving it to "exec/tb-flush.h". Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu-common.h

[PATCH 2/3] accel: Introduce cpu_exec_reset_hold()

Introduce cpu_exec_reset_hold() which call an accelerator specific AccelOpsClass::cpu_reset_hold() handler. Define a stub on TCG user emulation, because CPU reset is irrelevant there. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 1 + include/sysemu/accel-ops.h | 1 + a

[PATCH 3/3] accel/tcg: Factor tcg_cpu_reset_hold() out

Factor the TCG specific code from cpu_common_reset_hold() to tcg_cpu_reset_hold() within tcg-accel-ops.c. Since this file is sysemu specific, we can inline tcg_flush_softmmu_tlb(), removing its declaration in "exec/cpu-common.h". Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu-common.

Re: [PATCH v3 0/6] hw/virtio: Build vhost-vdpa.o once for all targets

Hi Michael, On 6/9/23 08:31, Philippe Mathieu-Daudé wrote: On 30/8/23 15:35, Philippe Mathieu-Daudé wrote: This series is now fully reviewed. On 10/7/23 11:49, Philippe Mathieu-Daudé wrote: Missing review: patch #4 Since v2: - Added R-b tags - Addressed Richard's review comment: page_mask =

Re: [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin

On 18/9/23 08:35, Thomas Huth wrote: On 18/09/2023 08.25, Philippe Mathieu-Daudé wrote: Do not run this test on Darwin, otherwise we get:    qemu-system-arm: -netdev dgram,id=st0,remote.type=inet,remote.host=230.0.0.1,remote.port=1234: can't add socket to multicast group 230.0.0.1: Can't assi

Re: [PATCH v1 1/3] {include/}hw/arm: refactor virt PPI logic

On Fri, 15 Sept 2023 at 12:56, Leif Lindholm wrote: > > GIC Private Peripheral Interrupts (PPI) are defined as GIC INTID 16-31. > As in, PPI0 is INTID16 .. PPI15 is INTID31. > Arm's Base System Architecture specification (BSA) lists the mandated and > recommended private interrupt IDs by INTID, no

Re: [PATCH v1 3/3] hw/arm/sbsa-ref: use bsa.h for PPI definitions

On Fri, 15 Sept 2023 at 12:55, Leif Lindholm wrote: > > Use the private peripheral interrupt definitions from bsa.h instead of > defining them locally. Refactor to use PPI() to convert from INTID macro > where necessary. > > Signed-off-by: Leif Lindholm > --- > hw/arm/sbsa-ref.c | 23 +++

Re: [PATCH v1 2/3] include/hw/arm: move BSA definitions to bsa.h

On Fri, 15 Sept 2023 at 12:55, Leif Lindholm wrote: > > virt.h defines a number of IRQs that are ultimately described by Arm's > Base System Architecture specification. Move these to a dedicated header > so that they can be reused by other platforms that do the same. > Include that header from vir

Re: [PATCH 1/1] sbsa-ref: add non-secure EL2 virtual timer

On Wed, 13 Sept 2023 at 15:06, Marcin Juszkiewicz wrote: > > Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure > EL2 virtual timer. > > This change adds it to fullfil Arm BSA (Base System Architecture) > requirements. > > Signed-off-by: Marcin Juszkiewicz > > --- > hw/arm/sb

Re: [PULL 01/39] accel/tcg: mttcg remove false-negative halted assertion

On Mon Sep 18, 2023 at 5:59 PM AEST, Alex Bennée wrote: > > "Nicholas Piggin" writes: > > > On Sat Sep 16, 2023 at 1:29 PM AEST, Richard Henderson wrote: > >> From: Nicholas Piggin > >> > >> mttcg asserts that an execution ending with EXCP_HALTED must have > >> cpu->halted. However between the ev

[PATCH 3/3] qga: test: Add test for guest-exec stream-output

Add a test that simulates a long running process (by using a named pipe to synchronize). This test ensures that full output is returned with each call to guest-exec-status. Signed-off-by: Daniel Xu --- tests/unit/test-qga.c | 77 +++ 1 file changed, 77 ins

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: > > On 18.09.23 12:11, Ani Sinha wrote: > > > > > Ok hopefully my last question. I am still confused on something. > > Does the above mean that the hole64 will actually start from an > > address that is beyond maxram? Like basica

[PATCH 0/3] qga: Add optional stream-output argument to guest-exec

Currently, commands run through guest-exec are "silent" until they finish running. This is fine for short lived commands. But for commands that take a while, this is a bad user experience. Usually long running programs know that they will run for a while. To improve user experience, they will typi

[PATCH 2/3] qga: Add optional stream-output argument to guest-exec

Currently, commands run through guest-exec are "silent" until they finish running. This is fine for short lived commands. But for commands that take a while, this is a bad user experience. Usually long running programs know that they will run for a while. To improve user experience, they will typi

[PATCH 1/3] qga: Fix memory leak when output stream is unused

If capture-output is requested but one of the channels goes unused (eg. we attempt to capture stderr but the command never writes to stderr), we can leak memory. guest_exec_output_watch() is (from what I understand) unconditionally called for both streams if output capture is requested. The first

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 12:54, Ani Sinha wrote: On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: On 18.09.23 12:11, Ani Sinha wrote: Ok hopefully my last question. I am still confused on something. Does the above mean that the hole64 will actually start from an address that is be

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > > On 18.09.23 12:54, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: > >> > >> On 18.09.23 12:11, Ani Sinha wrote: > >> > >>> > >>> Ok hopefully my last question. I am still confused on something. > >>>

Re: [PATCH 1/2] hw/sd/omap_mmc: Do not reset SDCard until being fully realized

On Mon, 18 Sept 2023 at 11:17, Philippe Mathieu-Daudé wrote: > > We shouldn't call QDev DeviceReset() before DeviceRealize(). > > Since the OMAP MMC model is not QDev'ified, it has to manually > call the SDCard reset() handler. This breaks QDev assumptions > that DeviceReset() is never called befo

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:30 PM Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > > > > On 18.09.23 12:54, Ani Sinha wrote: > > > On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand > > > wrote: > > >> > > >> On 18.09.23 12:11, Ani Sinha wrote: > > >> > > >>> > > >>>

Re: [PATCH] mem/x86: add processor address space check for VM memory

On 18.09.23 13:00, Ani Sinha wrote: On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: On 18.09.23 12:54, Ani Sinha wrote: On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand wrote: On 18.09.23 12:11, Ani Sinha wrote: Ok hopefully my last question. I am still confused on somet

Re: [PATCH] mem/x86: add processor address space check for VM memory

On Mon, Sep 18, 2023 at 4:32 PM David Hildenbrand wrote: > > On 18.09.23 13:00, Ani Sinha wrote: > > On Mon, Sep 18, 2023 at 4:28 PM David Hildenbrand wrote: > >> > >> On 18.09.23 12:54, Ani Sinha wrote: > >>> On Mon, Sep 18, 2023 at 3:49 PM David Hildenbrand > >>> wrote: > > On 18.09

Re: [PATCH] ui/gtk: fix UI info precondition

Hi On Fri, Sep 15, 2023 at 4:46 PM Michael Tokarev wrote: > > 15.09.2023 14:36, marcandre.lur...@redhat.com: > > From: Marc-André Lureau > > > > dpy_get_ui_info() shouldn't be called if the underlying GPU doesn't > > support it. > > > > Before the assert() was added and the regression introduced

Re: [PATCH v2 qemu 2/3] dump: Allow directly outputting reassembled kdumps

Hi On Thu, Sep 14, 2023 at 5:04 AM Stephen Brennan wrote: > > The flattened format (currently output by qemu) is used by makedumpfile > only when it is outputting a vmcore to a file which is not seekable. The > flattened format functions essentially as a set of instructions of the > form "seek to

Re: [PATCH v2 qemu 3/3] dump: Add qmp argument "reassembled"

Hi On Thu, Sep 14, 2023 at 5:03 AM Stephen Brennan wrote: > > This can be used from QMP command line as "-R" to mirror the > corresponding flag for makedumpfile. This enables the kdump_reassembled > flag introduced in the previous patch. > > Signed-off-by: Stephen Brennan > --- > dump/dump-hmp-

Re: [PATCH 0/8] hw/audio/es1370: bug fix

Hi On Sun, Sep 17, 2023 at 10:55 AM Volker Rümelin wrote: > > Cc: qemu-stable. Patch 1/8 is a bug fix. > Cc: more people. The maintainer of hw/audio is busy with other projects. > > Earlier this year I was asked if I could help to debug an audio playback > speed issue with the es1370 device. Whil

  1   2   3   4   >