Re: [PATCH 04/21] parallels: return earler in fail_format branch in parallels_open()

[Alexander Ivanov]

On 9/15/23 20:41, Denis V. Lunev wrote:

We do not need to perform any deallocation/cleanup if wrong format is
detected.

Signed-off-by: Denis V. Lunev <d...@openvz.org>
---
  block/parallels.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/parallels.c b/block/parallels.c
index 1d5409f2ba..0f127427bf 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1226,7 +1226,8 @@ static int parallels_open(BlockDriverState *bs, QDict 
*options, int flags,

fail_format:

      error_setg(errp, "Image not in Parallels format");
-    ret = -EINVAL;
+    return -EINVAL;
+
  fail:
      /*
       * "s" object was allocated by g_malloc0 so we can safely

Reviewed-by: Alexander Ivanov <alexander.iva...@virtuozzo.com>