Re: [PATCH 3/6] qemu-img: rebase: use backing files' BlockBackend for buffer alignment

2023-08-29 Thread Andrey Drobyshev
On 8/25/23 17:29, Hanna Czenczek wrote: > On 01.06.23 21:28, Andrey Drobyshev via wrote: >> Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for >> the data read from the old and new backing files are aligned using >> BlockDriverState (or BlockBackend later on) referring to the t

Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL

2023-08-29 Thread Chenyi Qiang
On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: > On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: >> Xiaoyao Li writes: >> >>> From: Isaku Yamahata >>> >>> For GetQuote, delegate a request to Quote Generation Service. Add property >>> of address of quote generation server a

Re: [PATCH v2 3/4] qcow2: add zoned emulation capability

2023-08-29 Thread Damien Le Moal
On 8/29/23 15:27, Sam Li wrote: > Damien Le Moal 于2023年8月29日周二 14:06写道: >> >> On 8/28/23 20:55, Sam Li wrote: > +/* close one implicitly open zones to make it available */ > +for (int i = s->zoned_header.zone_nr_conv; > +i < bs->bl.nr_zones; ++i) { >

Re: [PATCH v2 3/4] qcow2: add zoned emulation capability

2023-08-29 Thread Sam Li
Damien Le Moal 于2023年8月29日周二 15:14写道: > > On 8/29/23 15:27, Sam Li wrote: > > Damien Le Moal 于2023年8月29日周二 14:06写道: > >> > >> On 8/28/23 20:55, Sam Li wrote: > > +/* close one implicitly open zones to make it available */ > > +for (int i = s->zoned_header.zone_nr_c

[PATCH 00/10] configure cleanups for QEMU 8.2

2023-08-29 Thread Paolo Bonzini
This includes a few more patches cleaning up the configure/meson separation. The highlights are fixing --host-cc, removing the last traces of compiler detection from config-host.mak, and dropping the useless pc-bios/Makefile. Paolo Bonzini (10): meson: do not unnecessarily use cmake for depende

[PATCH 05/10] meson: compile bundled device trees

2023-08-29 Thread Paolo Bonzini
If dtc is available, compile the .dts files in the pc-bios directory instead of using the precompiled binaries. Signed-off-by: Paolo Bonzini --- pc-bios/Makefile| 19 --- pc-bios/meson.build | 25 + 2 files changed, 21 insertions(+), 23 deletions(-) d

[PATCH 01/10] meson: do not unnecessarily use cmake for dependencies

2023-08-29 Thread Paolo Bonzini
Both gvnc and sysprof-capture come with pkg-config files, so specify the method to find them. Signed-off-by: Paolo Bonzini --- tests/migration/meson.build | 2 +- tests/qtest/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/migration/meson.build b/test

[PATCH 06/10] contrib/plugins: use an independent makefile

2023-08-29 Thread Paolo Bonzini
The initial reason to write this patch was to remove the last use of CONFIG_DEBUG_TCG from the makefiles; the flags to use to build TCG plugins are unrelated to --enable-debug-tcg, and instead they should be the same as those used to build emulators (the plugins are not build via meson for demonstr

[PATCH 03/10] configure: remove HOST_CC

2023-08-29 Thread Paolo Bonzini
$(HOST_CC) is only used to invoke the preprocessor, and $(CC) can be used instead now that there is a Tricore C compiler. Remove the variable from config-host.mak. Signed-off-by: Paolo Bonzini --- configure | 1 - tests/tcg/tricore/Makefile.softmmu-target | 2 +-

[PATCH 02/10] meson: update unsupported host/CPU messages

2023-08-29 Thread Paolo Bonzini
Unsupported CPU and OSes are not really going away, but the project simply does not guarantee that they work. Rephrase the messages accordingly. While at it, move the warning for TCI performance at the end where it is more visible. Signed-off-by: Paolo Bonzini --- meson.build | 38

[PATCH 07/10] meson: do not use config_host to pick tap implementations

2023-08-29 Thread Paolo Bonzini
The target OS is invariant and does not depend on the configuration, so move away from config_host and just use unconditional rules in softmmu_ss. Signed-off-by: Paolo Bonzini --- net/meson.build | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/net/meson.bu

[PATCH 08/10] configure, meson: move simple OS definitions to meson

2023-08-29 Thread Paolo Bonzini
CONFIG_DARWIN and CONFIG_SOLARIS are only used in C sources. Move them to config_host_data. Signed-off-by: Paolo Bonzini --- configure | 12 hw/9pfs/meson.build | 4 +++- meson.build | 2 ++ 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/configur

[PATCH 09/10] configure: remove $linux and $mingw32 variables

2023-08-29 Thread Paolo Bonzini
Just use $targetos always. Signed-off-by: Paolo Bonzini --- configure | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/configure b/configure index eba5befa2cf..aed48db68fd 100755 --- a/configure +++ b/configure @@ -374,12 +374,9 @@ fi # OS specific -mi

[PATCH 10/10] configure: move --enable-debug-tcg to meson

2023-08-29 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 11 +-- meson.build | 3 ++- meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/configure b/configure index aed48

[PATCH 04/10] configure: create native file with contents of $host_cc

2023-08-29 Thread Paolo Bonzini
The argument of --host-cc is not obeyed when cross compiling. To avoid this issue, place it in a configuration file and pass it to meson with --native-file. While at it, clarify that --host-cc is not obeyed anyway when _not_ cross compiling. Signed-off-by: Paolo Bonzini --- configure | 11

Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id

2023-08-29 Thread Mario Casquero
This series has been successfully tested by QE. Start a vm using pc.ram id but specifying a different memory-backend from the default one. Check the error message has been improved. Tested-by: Mario Casquero On Wed, Aug 23, 2023 at 5:38 PM David Hildenbrand wrote: > > For migration purposes, u

[PATCH] linux-user, bsd-user: disable on unsupported host architectures

2023-08-29 Thread Paolo Bonzini
Safe signal handling around system calls is mandatory for user-mode emulation, and requires a small piece of handwritten assembly code. So refuse to compile unless the common-user/host subdirectory exists for the host architecture that was detected or selected with --cpu. Signed-off-by: Paolo Bonz

Re: [PATCH] hw/net/rocker: avoid NULL pointer dereference in of_dpa_cmd_add_l2_flood

2023-08-29 Thread Mauro Matteo Cascella
On Mon, Aug 28, 2023 at 6:11 PM Philippe Mathieu-Daudé wrote: > > On 27/8/23 13:07, Mauro Matteo Cascella wrote: > > On Sat, Aug 26, 2023 at 4:31 PM Mauro Matteo Cascella > > wrote: > >> > >> On Fri, Jun 24, 2022 at 4:40 PM Mauro Matteo Cascella > >> wrote: > >>> > >>> rocker_tlv_parse_nested co

Re: [PATCH 3/6] qemu-img: rebase: use backing files' BlockBackend for buffer alignment

2023-08-29 Thread Hanna Czenczek
On 29.08.23 09:06, Andrey Drobyshev wrote: On 8/25/23 17:29, Hanna Czenczek wrote: On 01.06.23 21:28, Andrey Drobyshev via wrote: Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for the data read from the old and new backing files are aligned using BlockDriverState (or Block

Re: [PATCH v2 2/3] qemu-img: map: report compressed data blocks

2023-08-29 Thread Hanna Czenczek
On 29.08.23 08:44, Andrey Drobyshev wrote: On 8/25/23 17:14, Hanna Czenczek wrote: On 06.07.23 18:30, Andrey Drobyshev wrote: Right now "qemu-img map" reports compressed blocks as containing data but having no host offset.  This is not very informative.  Instead, let's add another boolean field

[PATCH v2 0/2] Vhost-vdpa Shadow Virtqueue Hash calculation Support

2023-08-29 Thread Hawkins Jiawei
This series enables shadowed CVQ to intercept VIRTIO_NET_CTRL_MQ_HASH_CONFIG command through shadowed CVQ, update the virtio NIC device model so qemu send it in a migration, and the restore of that Hash calculation state in the destination. Note that this patch should be based on patch "vdpa: Send

[PATCH v2 1/2] vdpa: Restore hash calculation state

2023-08-29 Thread Hawkins Jiawei
This patch introduces vhost_vdpa_net_load_rss() to restore the hash calculation state at device's startup. Note that vhost_vdpa_net_load_rss() has `do_rss` argument, which allows future code to reuse this function to restore the receive-side scaling state when the VIRTIO_NET_F_RSS feature is enabl

[PATCH v2 2/2] vdpa: Allow VIRTIO_NET_F_HASH_REPORT in SVQ

2023-08-29 Thread Hawkins Jiawei
Enable SVQ with VIRTIO_NET_F_HASH_REPORT feature. Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 139bb79468..b29f84f54c 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -118,6 +118,7 @@ stati

Re: [PATCH v2 3/8] machine: Print supported CPU models instead of typenames

2023-08-29 Thread Igor Mammedov
On Tue, 29 Aug 2023 16:28:45 +1000 Gavin Shan wrote: > Hi Igor, > > On 8/29/23 00:46, Igor Mammedov wrote: > > On Mon, 31 Jul 2023 15:07:30 +1000 > > Gavin Shan wrote: > >> On 7/27/23 19:00, Igor Mammedov wrote: > >>> On Thu, 27 Jul 2023 15:16:18 +1000 > >>> Gavin Shan wrote: > >>> >

[PATCH 2/2] igb: Add Function Level Reset to PF and VF

2023-08-29 Thread Cédric Le Goater
From: Cédric Le Goater The Intel 82576EB GbE Controller say that the Physical and Virtual Functions support Function Level Reset. Add the capability to each device model. Cc: Sriram Yagnaraman Fixes: 3a977deebe6b ("Intrdocue igb device emulation") Reviewed-by: Akihiko Odaki Tested-by: Akihiko

[PATCH 0/2] igb: Add FLR support

2023-08-29 Thread Cédric Le Goater
From: Cédric Le Goater Hello, Here is a little series adding FLR to the new IGB models. Thanks, C. Cédric Le Goater (2): igb: Add a VF reset handler igb: Add Function Level Reset to PF and VF hw/net/igb_common.h | 1 + hw/net/igb_core.h | 3 +++ hw/net/igb.c| 9 + h

[PATCH 1/2] igb: Add a VF reset handler

2023-08-29 Thread Cédric Le Goater
From: Cédric Le Goater Export the igb_vf_reset() helper routine from the PF model to let the IGBVF model implement its own device reset. Cc: Akihiko Odaki Suggested-by: Sriram Yagnaraman Signed-off-by: Cédric Le Goater --- hw/net/igb_common.h | 1 + hw/net/igb_core.h | 3 +++ hw/net/igb.

[PATCH v3 0/3] Vhost-vdpa Shadow Virtqueue RSS Support

2023-08-29 Thread Hawkins Jiawei
This series enables shadowed CVQ to intercept RSS command through shadowed CVQ, update the virtio NIC device model so qemu send it in a migration, and the restore of that RSS state in the destination. Note that this patch should be based on patch "Vhost-vdpa Shadow Virtqueue Hash calculation Suppo

[PATCH v3 1/3] vdpa: Add SetSteeringEBPF method for NetClientState

2023-08-29 Thread Hawkins Jiawei
At present, to enable the VIRTIO_NET_F_RSS feature, eBPF must be loaded for the vhost backend. Given that vhost-vdpa is one of the vhost backend, we need to implement the SetSteeringEBPF method to support RSS for vhost-vdpa, even if vhost-vdpa calculates the rss hash in the hardware device instead

[PATCH v3 3/3] vdpa: Allow VIRTIO_NET_F_RSS in SVQ

2023-08-29 Thread Hawkins Jiawei
Enable SVQ with VIRTIO_NET_F_RSS feature. Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 85547b7bbb..13da60aeda 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -119,6 +119,7 @@ static const

[PATCH v3 2/3] vdpa: Restore receive-side scaling state

2023-08-29 Thread Hawkins Jiawei
This patch reuses vhost_vdpa_net_load_rss() with some refactorings to restore the receive-side scaling state at device's startup. Signed-off-by: Hawkins Jiawei --- v3: - resolve conflict with updated patch "Vhost-vdpa Shadow Virtqueue Hash calculation Support" v2: https://lore.kernel.org/all/

Re: [PATCH v4 0/8] vdpa: Send all CVQ state load commands in parallel

2023-08-29 Thread Hawkins Jiawei
On 2023/8/29 13:54, Hawkins Jiawei wrote: > This patchset allows QEMU to delay polling and checking the device > used buffer until either the SVQ is full or control commands shadow > buffers are full, instead of polling and checking immediately after > sending each SVQ control command, so that QEMU

Re: [PATCH] hw/block/dataplane/virtio-block: Avoid dynamic stack allocation

2023-08-29 Thread Peter Maydell
On Thu, 24 Aug 2023 at 18:15, Stefan Hajnoczi wrote: > > On Thu, Aug 24, 2023 at 05:57:40PM +0100, Peter Maydell wrote: > > Instead of using a variable length array in notify_guest_bh(), always > > use a fixed sized bitmap (this will be 128 bytes). This means we > > need to avoid assuming that bi

Re: [PATCH 1/3] hw/mips/jazz: Remove the big_endian variable

2023-08-29 Thread Peter Maydell
On Mon, 28 Aug 2023 at 18:00, Thomas Huth wrote: > > On 28/08/2023 17.48, Philippe Mathieu-Daudé wrote: > > On 28/8/23 14:41, Thomas Huth wrote: > >> On 28/08/2023 14.19, Philippe Mathieu-Daudé wrote: > >>> Hi Thomas, > >>> > >>> On 25/8/23 19:51, Thomas Huth wrote: > There is an easier way t

Re: [PATCH v1 01/23] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2023-08-29 Thread David Woodhouse
On Tue, 2023-06-20 at 13:24 -0400, Joel Upham wrote: > The primary difference in PCI device IRQ management between Xen HVM and > QEMU is that Xen PCI IRQs are "device-centric" while QEMU PCI IRQs are > "chipset-centric". Namely, Xen uses PCI device BDF and INTx as coordinates > to assert IRQ while

Re: [PATCH] tests/qtest/bios-tables-test: Check for virtio-iommu device before using it

2023-08-29 Thread Igor Mammedov
On Tue, 22 Aug 2023 18:49:48 +0200 Thomas Huth wrote: > The virtio-iommu device might be missing in the QEMU binary (e.g. in > downstream RHEL builds), so let's better check for its availability first > before using it. > > Signed-off-by: Thomas Huth Acked-by: Igor Mammedov > --- > tests/qt

Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL

2023-08-29 Thread Daniel P . Berrangé
On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: > > > On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: > > On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: > >> Xiaoyao Li writes: > >> > >>> From: Isaku Yamahata > >>> > >>> For GetQuote, delegate a request to Quot

Re: [PATCH v2 47/58] i386/tdx: Wire REPORT_FATAL_ERROR with GuestPanic facility

2023-08-29 Thread Daniel P . Berrangé
On Mon, Aug 28, 2023 at 09:14:41PM +0800, Xiaoyao Li wrote: > On 8/21/2023 5:58 PM, Daniel P. Berrangé wrote: > > On Fri, Aug 18, 2023 at 05:50:30AM -0400, Xiaoyao Li wrote: > > > Originated-from: Isaku Yamahata > > > Signed-off-by: Xiaoyao Li > > > --- > > > qapi/run-state.json | 17

Re: [PATCH 02/10] meson: update unsupported host/CPU messages

2023-08-29 Thread Daniel P . Berrangé
On Tue, Aug 29, 2023 at 10:29:23AM +0200, Paolo Bonzini wrote: > Unsupported CPU and OSes are not really going away, but the > project simply does not guarantee that they work. Rephrase > the messages accordingly. While at it, move the warning for > TCI performance at the end where it is more vis

Re: [PATCH v3] Fix SEGFAULT on getting physical address of MMIO region.

2023-08-29 Thread Jonathan Cameron via
On Thu, 10 Aug 2023 14:18:50 +0100 Jonathan Cameron via wrote: > On Fri, 4 Aug 2023 09:15:13 -0700 > Richard Henderson wrote: > > > On 8/4/23 04:09, Mikhail Tyutin wrote: > > > Apply save_iotlb_data() to io_readx() as well as to io_writex(). This > > > fixes > > > SEGFAULT on qemu_plugin_hwa

Re: [PATCH 2/3] softmmu: Use async_run_on_cpu in tcg_commit

2023-08-29 Thread Jonathan Cameron via
On Sat, 26 Aug 2023 16:24:14 -0700 Richard Henderson wrote: > After system startup, run the update to memory_dispatch > and the tlb_flush on the cpu. This eliminates a race, > wherein a running cpu sees the memory_dispatch change > but has not yet seen the tlb_flush. > > Since the update now ha

Re: [PATCH 1/2] igb: Add a VF reset handler

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 11:05, Cédric Le Goater wrote: From: Cédric Le Goater Export the igb_vf_reset() helper routine from the PF model to let the Preferably splitting in 2 patches to KISS, Reviewed-by: Philippe Mathieu-Daudé IGBVF model implement its own device reset. Cc: Akihiko Odaki Suggested-b

Re: [PATCH v3 04/11] softmmu/physmem: Remap with proper protection in qemu_ram_remap()

2023-08-29 Thread Philippe Mathieu-Daudé
On 23/8/23 17:34, David Hildenbrand wrote: Let's remap with the proper protection that we can derive from RAM_READONLY. Signed-off-by: David Hildenbrand --- softmmu/physmem.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 09/11] docs: Start documenting VM templating

2023-08-29 Thread Philippe Mathieu-Daudé
On 23/8/23 17:34, David Hildenbrand wrote: Let's add some details about VM templating, focusing on the VM memory configuration only. There is much more to VM templating (VM state? block devices?), but I leave that as future work. Signed-off-by: David Hildenbrand --- MAINTAINERS

Re: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id

2023-08-29 Thread Philippe Mathieu-Daudé
On 25/8/23 12:10, David Hildenbrand wrote: On 25.08.23 11:59, David Hildenbrand wrote: On 25.08.23 11:56, Markus Armbruster wrote: David Hildenbrand writes: On 25.08.23 11:10, Markus Armbruster wrote: David Hildenbrand writes: On 25.08.23 08:57, ThinerLogoer wrote: Hello, At 2023-08-23

PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Marcin Juszkiewicz
I am working on aarch64/sbsa-ref machine so people can have virtual machine to test their OS against something reminding standards compliant system. One of tools I use is BSA ACS (Base System Architecture - Architecture Compliance Suite) [1] written by Arm. It runs set of tests to check does syst

Re: [PATCH v2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-08-29 Thread Daniel P . Berrangé
On Fri, Aug 25, 2023 at 01:15:16PM -0400, Peter Xu wrote: > Quotting from Markus in his replies: > > migrate-set-parameters sets migration parameters, and > query-migrate-parameters gets them. Unsurprisingly, the former's > argument type MigrateSetParameters is quite close to the latter's >

Re: [PATCH v2 4/4] migration/qapi: Drop @MigrationParameter enum

2023-08-29 Thread Daniel P . Berrangé
On Fri, Aug 25, 2023 at 01:15:17PM -0400, Peter Xu wrote: > Drop the enum in qapi because it is never used in QMP APIs. Instead making > it an internal definition for QEMU so that we can decouple it from QAPI, > and also we can deduplicate the QAPI documentations. > > Signed-off-by: Peter Xu > -

[PATCH v5 3/3] vhost-user: move VhostUserProtocolFeature definition to header file

2023-08-29 Thread Jonah Palmer
Move the definition of VhostUserProtocolFeature to include/hw/virtio/vhost-user.h. Remove previous definitions in hw/scsi/vhost-user-scsi.c, hw/virtio/vhost-user.c, and hw/virtio/virtio-qmp.c. Previously there were 3 separate definitions of this over 3 different files. Now only 1 definition of th

[PATCH v5 1/3] qmp: remove virtio_list, search QOM tree instead

2023-08-29 Thread Jonah Palmer
The virtio_list duplicates information about virtio devices that already exist in the QOM composition tree. Instead of creating this list of realized virtio devices, search the QOM composition tree instead. This patch modifies the QMP command qmp_x_query_virtio to instead recursively search the QO

[PATCH v5 0/3] qmp, vhost-user: Remove virtio_list & update virtio introspection

2023-08-29 Thread Jonah Palmer
These patches update a few things related to virtio introspection via. QMP/HMP commands. 1. Remove 'virtio_list' and instead query the QOM composition tree to find any active & realized virtio devices. The 'virtio_list' was duplicating information about virtio devices that was already available i

[PATCH v5 2/3] qmp: update virtio feature maps, vhost-user-gpio introspection

2023-08-29 Thread Jonah Palmer
Add new vhost-user protocol feature to vhost-user protocol feature map and enumeration: - VHOST_USER_PROTOCOL_F_STATUS Add new virtio device features for several virtio devices to their respective feature mappings: virtio-blk: - VIRTIO_BLK_F_SECURE_ERASE virtio-net: - VIRTIO_NET_F_NOTF_COAL

[PATCH 1/2] hw/intc/riscv_aplic.c fix non-KVM --enable-debug build

2023-08-29 Thread Daniel Henrique Barboza
Commit 6df0b37e2ab breaks a --enable-debug build in a non-KVM environment with the following error: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_intc_riscv_aplic.c.o: in function `riscv_kvm_aplic_request': ./qemu/build/../hw/intc/riscv_aplic.c:486: undefined reference to `kvm_set_irq' collect2: e

[PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-29 Thread Daniel Henrique Barboza
A build with --enable-debug and without KVM will fail as follows: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function `virt_machine_init': ./qemu/build/../hw/riscv/virt.c:1465: undefined reference to `kvm_riscv_aia_create' This happens because the code block with "if virt_u

[PATCH 0/2] riscv: fix --enable-debug in riscv-to-apply.next

2023-08-29 Thread Daniel Henrique Barboza
Hi, There is a couple of build problems that sneaked in riscv-to-apply.next in the KVM AIA patches. Here's a potential solution for them. Alistair, feel free to squash the fixes in the original commits since they're not yet on master. Cc: Yong-Xuan Wang Daniel Henrique Barboza (2): hw/intc/r

Re: [PATCH v2 11/11] target/arm: Implement cortex-a710

2023-08-29 Thread Peter Maydell
On Fri, 11 Aug 2023 at 22:42, Richard Henderson wrote: > > The cortex-a710 is a first generation ARMv9.0-A processor. > diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c > index b12e10d3ab..81c27c70e8 100644 > --- a/target/arm/tcg/cpu64.c > +++ b/target/arm/tcg/cpu64.c > @@ -758,6 +758

Re: [PATCH v2 00/11] target/arm: Implement cortex-a710

2023-08-29 Thread Peter Maydell
On Fri, 11 Aug 2023 at 22:42, Richard Henderson wrote: > > This is one of the first generation Armv9 cores, and gives us something > concrete to test in that area. Notably, it supports MTE. > > Changes for v2: > * Check GMBS during realize. > * Fix access checks for neoverse implementation re

Re: [PATCH v4 1/9] tests/tcg/aarch64: Adjust pauth tests for FEAT_FPAC

2023-08-29 Thread Peter Maydell
On Tue, 22 Aug 2023 at 05:27, Richard Henderson wrote: > > With FEAT_FPAC, AUT* instructions that fail authentication > do not produce an error value but instead fault. > > For pauth-2, install a signal handler and verify it gets called. > > For pauth-4 and pauth-5, we are explicitly testing the e

Re: [PATCH v4 3/9] target/arm: Add feature detection for FEAT_Pauth2 and extensions

2023-08-29 Thread Peter Maydell
On Tue, 22 Aug 2023 at 05:27, Richard Henderson wrote: > > From: Aaron Lindsay > > Rename isar_feature_aa64_pauth_arch to isar_feature_aa64_pauth_qarma5 > to distinguish the other architectural algorithm qarma3. > > Add ARMPauthFeature and isar_feature_pauth_feature to cover the > other pauth con

Re: [PATCH v4 4/9] target/arm: Don't change pauth features when changing algorithm

2023-08-29 Thread Peter Maydell
On Tue, 22 Aug 2023 at 05:27, Richard Henderson wrote: > > We have cpu properties to adjust the pauth algorithm for the > purpose of speed of emulation. Retain the set of pauth features > supported by the cpu even as the algorithm changes. > > This already affects the neoverse-v1 cpu, which has F

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Peter Maydell
On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz wrote: > > I am working on aarch64/sbsa-ref machine so people can have virtual > machine to test their OS against something reminding standards compliant > system. > > One of tools I use is BSA ACS (Base System Architecture - Architecture > Complian

Re: [PATCH 11/20] target/riscv: introduce KVM AccelCPUClass

2023-08-29 Thread Daniel Henrique Barboza
On 8/28/23 13:38, Philippe Mathieu-Daudé wrote: On 25/8/23 15:08, Daniel Henrique Barboza wrote: Add a KVM accelerator class like we did with TCG. The difference is that, at least for now, we won't be using a realize() implementation for this accelerator. We'll start by assiging kvm_riscv_cp

Re: [PATCH] target/arm: Use deposit_z() in BCF opcode

2023-08-29 Thread Peter Maydell
On Tue, 22 Aug 2023 at 10:51, Philippe Mathieu-Daudé wrote: > > When clearing a bitfield we don't need to lead the "load" ? > source register. Use deposit_z_i32() with the BFC > opcode to save a load_reg() call. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/tcg/translate.c | 9 +

Re: [PATCH v1 2/7] hw/fsi: Introduce IBM's scratchpad

2023-08-29 Thread Ninad Palsule
Hello Thomas, On 8/28/23 20:52, Thomas Huth wrote: On 25/08/2023 22.30, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad provides a non-functional registers. There is a 1-1 rel

Re: [PATCH 1/6] migration: Add migration prefix to functions in target.c

2023-08-29 Thread Cédric Le Goater
On 8/28/23 17:18, Avihai Horon wrote: The functions in target.c are not static, yet they don't have a proper migration prefix. Add such prefix. Reviewed-by: Cédric Le Goater Thanks, C. Signed-off-by: Avihai Horon --- migration/migration.h | 4 ++-- migration/migration.c | 6 +++---

Re: [PATCH 2/6] vfio/migration: Fail adding device with enable-migration=on and existing blocker

2023-08-29 Thread Cédric Le Goater
On 8/28/23 17:18, Avihai Horon wrote: If a device with enable-migration=on is added and it causes a migration blocker, adding the device should fail with a proper error. This is not the case with multiple device migration blocker when the blocker already exists. If the blocker already exists and

Re: [PATCH v2] target/arm: properly document FEAT_CRC32

2023-08-29 Thread Peter Maydell
On Thu, 24 Aug 2023 at 08:54, Alex Bennée wrote: > > This is a mandatory feature for Armv8.1 architectures but we don't > state the feature clearly in our emulation list. Also include > FEAT_CRC32 comment in aarch64_max_tcg_initfn for ease of grepping. > > Reviewed-by: Philippe Mathieu-Daudé > Si

Re: [PATCH 3/6] vfio/migration: Add vfio_migratable_devices_num()

2023-08-29 Thread Cédric Le Goater
On 8/28/23 17:18, Avihai Horon wrote: Add vfio_migratable_devices_num() function, which returns the number of VFIO devices that are using VFIO migration, and use it in vfio_multiple_devices_migration_is_supported(). This is done in preparation for next patches which will block VFIO migration wit

Re: [PATCH v2 10/12] gdbstub: refactor get_feature_xml

2023-08-29 Thread Alex Bennée
Richard Henderson writes: > On 8/24/23 09:39, Alex Bennée wrote: >> Try to bring up the code to more modern standards by: >>- use dynamic GString built xml over a fixed buffer >>- use autofree to save on explicit g_free() calls >>- don't hand hack strstr to find the delimiter >> Sig

Re: [PATCH 4/6] qemu-img: rebase: avoid unnecessary COW operations

2023-08-29 Thread Andrey Drobyshev
On 8/25/23 18:00, Hanna Czenczek wrote: > On 01.06.23 21:28, Andrey Drobyshev via wrote: >> When rebasing an image from one backing file to another, we need to >> compare data from old and new backings.  If the diff between that data >> happens to be unaligned to the target cluster size, we might e

Re: [PATCH v4 1/6] Remove i.MX7 IOMUX GPR device from i.MX6UL

2023-08-29 Thread Peter Maydell
On Fri, 25 Aug 2023 at 13:22, Jean-Christophe Dubois wrote: > > i.MX7 IOMUX GPR device is not equivalent to i.MX6UL IOMUXC GPR device. > In particular, register 22 is not present on i.MX6UL and this is actualy > The only register that is really emulated in the i.MX7 IOMUX GPR device. > > Note: The

Re: [PATCH 5/6] vfio/migration: Block VFIO migration with postcopy migration

2023-08-29 Thread Cédric Le Goater
On 8/28/23 17:18, Avihai Horon wrote: VFIO migration is not compatible with postcopy migration. A VFIO device in the destination can't handle page faults for pages that have not been sent yet. Doing such migration will cause the VM to crash in the destination: qemu-system-x86_64: VFIO_MAP_DMA f

Re: [PATCH v4 2/6] Refactor i.MX6UL processor code

2023-08-29 Thread Peter Maydell
On Fri, 25 Aug 2023 at 13:22, Jean-Christophe Dubois wrote: > > * Add Addr and size definition for most i.MX6UL devices in i.MX6UL header > file. > * Use those newly defined named constants whenever possible. > * Standardize the way we init a familly of unimplemented devices > - SAI > - PWM >

Re: [PATCH v4 4/6] Refactor i.MX7 processor code

2023-08-29 Thread Peter Maydell
On Fri, 25 Aug 2023 at 13:22, Jean-Christophe Dubois wrote: > > * Add Addr and size definition for all i.MX7 devices in i.MX7 header file. > * Use those newly defined named constants whenever possible. > * Standardize the way we init a familly of unimplemented devices > - SAI > - PWM > - CAN

[PATCH] qemu-options.hx: Rephrase the descriptions of the -hd* and -cdrom options

2023-08-29 Thread Thomas Huth
The current description says that these options will create a device on the IDE bus, which is only true on x86. So rephrase these sentences a little bit to speak of "default bus" instead. Signed-off-by: Thomas Huth --- qemu-options.hx | 20 1 file changed, 12 insertions(+),

Re: [PATCH v1 1/4] vfio/pci: detect the support of dynamic MSI-X allocation

2023-08-29 Thread Cédric Le Goater
Hello Jing, On 8/22/23 09:29, Jing Liu wrote: Kernel provides the guidance of dynamic MSI-X allocation support of passthrough device, by clearing the VFIO_IRQ_INFO_NORESIZE flag to guide user space. Fetch the flags from host to determine if dynamic MSI-X allocation is supported. Originally-by:

Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator

2023-08-29 Thread Thomas Huth
On 24/06/2023 01.12, Philippe Mathieu-Daudé wrote: On 24/6/23 01:08, Philippe Mathieu-Daudé wrote: HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark HAXM in QEMU as deprecated"), released in v8.0.0. Per the QEMU depre

Re: [PATCH v1 3/7] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-08-29 Thread Ninad Palsule
Hello Thomas, On 8/28/23 21:03, Thomas Huth wrote: On 25/08/2023 22.30, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal

Re: [PATCH v1 3/7] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-08-29 Thread Cédric Le Goater
On 8/29/23 15:39, Ninad Palsule wrote: Hello Thomas, On 8/28/23 21:03, Thomas Huth wrote: On 25/08/2023 22.30, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines

Re: [PULL 00/14] Python, i386 changes for 2023-08-28

2023-08-29 Thread Stefan Hajnoczi
Hi Paolo, I see a new test error that may have been introduced by this pull request: https://gitlab.com/qemu-project/qemu/-/jobs/4968468877#L131 AVOCADO Downloading avocado tests VM image for s390x Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not in

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 02:14:51PM +0100, Peter Maydell wrote: > On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz > wrote: > > > > I am working on aarch64/sbsa-ref machine so people can have virtual > > machine to test their OS against something reminding standards compliant > > system. > > > > On

Re: [PULL 00/36] 2023q3 bsd user patches

2023-08-29 Thread Stefan Hajnoczi
Applied, thanks. In the future, please invoke git-request-pull(1) with the public HTTPS repo URL to make it easier for anyone to fetch the changes: > are available in the Git repository at: > > g...@gitlab.com:bsdimp/qemu.git tags/2023q3-bsd-user-pull-request ^^ Please update the

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 13:39, Marcin Juszkiewicz wrote: I am working on aarch64/sbsa-ref machine so people can have virtual machine to test their OS against something reminding standards compliant system. One of tools I use is BSA ACS (Base System Architecture - Architecture Compliance Suite) [1] written by

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 15:48, Michael S. Tsirkin wrote: On Tue, Aug 29, 2023 at 02:14:51PM +0100, Peter Maydell wrote: On Tue, 29 Aug 2023 at 12:40, Marcin Juszkiewicz wrote: I am working on aarch64/sbsa-ref machine so people can have virtual machine to test their OS against something reminding standards

Re: [PATCH v1 3/4] vfio/pci: use an invalid fd to enable MSI-X

2023-08-29 Thread Cédric Le Goater
On 8/22/23 09:29, Jing Liu wrote: Guests typically enable MSI-X with all of the vectors masked in the MSI-X vector table. To match the guest state of device, Qemu enables MSI-X by QEMU is preferred to Qemu. enabling vector 0 with userspace triggering and immediately release. However the relea

Re: [PATCH 1/6] migration: Add migration prefix to functions in target.c

2023-08-29 Thread Peter Xu
On Mon, Aug 28, 2023 at 06:18:37PM +0300, Avihai Horon wrote: > The functions in target.c are not static, yet they don't have a proper > migration prefix. Add such prefix. > > Signed-off-by: Avihai Horon No issue on the patch itself, but just noticed that we have hard-coded vfio calls in migrati

Re: [PATCH v4 0/6] Complete i.MX6UL and i.MX7 processor for bare metal application.

2023-08-29 Thread Peter Maydell
On Fri, 25 Aug 2023 at 13:21, Jean-Christophe Dubois wrote: > > This patch adds a few unimplemented TZ devices (TZASC and CSU) to > i.MX6UL and i.MX7 processors to avoid bare metal application to > experiment "bus error" when acccessing these devices. > > It also adds some internal memory segments

Re: [PATCH v2 2/4] tests/migration-test: Add a test for null parameter setups

2023-08-29 Thread Philippe Mathieu-Daudé
On 25/8/23 19:15, Peter Xu wrote: Add a test for StrOrNull parameters (tls-*). Reviewed-by: Fabiano Rosas Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-

Re: [PATCH v2 1/4] migration/qmp: Fix crash on setting tls-authz with null

2023-08-29 Thread Philippe Mathieu-Daudé
On 25/8/23 19:15, Peter Xu wrote: QEMU will crash if anyone tries to set tls-authz (which is a type StrOrNull) with 'null' value. Fix it in the easy way by converting it to qstring just like the other two tls parameters. Cc: qemu-sta...@nongnu.org # v4.0+ Fixes: d2f1d29b95 ("migration: add supp

Re: [PATCH 1/2] hw/intc/riscv_aplic.c fix non-KVM --enable-debug build

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 14:21, Daniel Henrique Barboza wrote: Commit 6df0b37e2ab breaks a --enable-debug build in a non-KVM environment with the following error: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_intc_riscv_aplic.c.o: in function `riscv_kvm_aplic_request': ./qemu/build/../hw/intc/riscv_aplic.c:48

Re: [PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 14:21, Daniel Henrique Barboza wrote: A build with --enable-debug and without KVM will fail as follows: /usr/bin/ld: libqemu-riscv64-softmmu.fa.p/hw_riscv_virt.c.o: in function `virt_machine_init': ./qemu/build/../hw/riscv/virt.c:1465: undefined reference to `kvm_riscv_aia_create'

Re: [PATCH v1 01/23] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2023-08-29 Thread David Woodhouse
On Tue, 2023-06-20 at 13:24 -0400, Joel Upham wrote: > The primary difference in PCI device IRQ management between Xen HVM and > QEMU is that Xen PCI IRQs are "device-centric" while QEMU PCI IRQs are > "chipset-centric". Namely, Xen uses PCI device BDF and INTx as coordinates > to assert IRQ while

Re: [PATCH 05/10] meson: compile bundled device trees

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 10:29, Paolo Bonzini wrote: If dtc is available, compile the .dts files in the pc-bios directory instead of using the precompiled binaries. Signed-off-by: Paolo Bonzini --- pc-bios/Makefile| 19 --- pc-bios/meson.build | 25 + 2 files c

Re: [PATCH 07/10] meson: do not use config_host to pick tap implementations

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 10:29, Paolo Bonzini wrote: The target OS is invariant and does not depend on the configuration, so move away from config_host and just use unconditional rules in softmmu_ss. Signed-off-by: Paolo Bonzini --- net/meson.build | 18 ++ 1 file changed, 10 insertions(+)

Re: [PATCH 08/10] configure, meson: move simple OS definitions to meson

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 10:29, Paolo Bonzini wrote: CONFIG_DARWIN and CONFIG_SOLARIS are only used in C sources. Move them to config_host_data. Signed-off-by: Paolo Bonzini --- configure | 12 hw/9pfs/meson.build | 4 +++- meson.build | 2 ++ 3 files changed, 5 insertio

Re: [PATCH 09/10] configure: remove $linux and $mingw32 variables

2023-08-29 Thread Philippe Mathieu-Daudé
On 29/8/23 10:29, Paolo Bonzini wrote: Just use $targetos always. Signed-off-by: Paolo Bonzini --- configure | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 1/4] ppc/xive: Use address_space routines to access the machine RAM

2023-08-29 Thread Cédric Le Goater
to log an error in case of bad configuration of the XIVE tables by the FW. Signed-off-by: Cédric Le Goater --- hw/intc/pnv_xive.c | 27 +++ hw/intc/pnv_xive2.c | 27 +++ 2 files changed, 46 insertions(+), 8 deletions(-) diff --git a/hw/intc/pnv_x

[PATCH 0/4] ppc/xive: Rework Inter chip communication

2023-08-29 Thread Cédric Le Goater
Hello, Today, the inter chip communication for interrupts uses the pnv_xive_get_remote() routine to grab the remote XIVE interrupt controller object. This is a modeling shortcut which can be improved by implementing : * remote END triggers * memory operations on remote NVT structures. Both are

[PATCH 3/4] ppc/xive: Handle END triggers between chips with MMIOs

2023-08-29 Thread Cédric Le Goater
The notify page of the interrupt controller can either be used to receive trigger events from the HW controllers (PHB, PSI) or to reroute interrupts between Interrupt Controllers. In which case, the VSD table is used to determine the address of the notify page of the remote IC and the store data is

[PATCH 4/4] ppc/xive: Add support for the PC MMIOs

2023-08-29 Thread Cédric Le Goater
The XIVE interrupt contoller maintains various fields on interrupt targets in a structure called NVT. Each unit has a NVT cache, backed by RAM. When the NVT structure is not local (in RAM) to the chip, the XIVE interrupt controller forwards the memory operation to the owning chip using the PC MMIO

  1   2   3   4   >