Re: [Question - ARM CCA] vCPU Hotplug Support in ARM Realm world might require ARM spec change?

2023-07-24 Thread bibo mao
在 2023/7/25 08:56, Salil Mehta 写道: > Hi Bibo, > >> From: bibo mao >> Sent: Tuesday, July 25, 2023 1:29 AM >> To: Salil Mehta >> Cc: Catalin Marinas ; Jonathan Cameron >> ; Marc Zyngier ; Will Deacon >> ; christoffer.d...@arm.com; oliver.up...@linux.dev; >> mark.rutl...@arm.com; pbonz...@redha

[PATCH QEMU v10 5/9] migration: Refactor auto-converge capability logic

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v10 4/9] migration: Introduce dirty-limit capability

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor vcpu_d

[PATCH QEMU v10 9/9] tests: Add migration dirty-limit capability test

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The te

[PATCH QEMU v10 8/9] migration: Extend query-migrate to provide dirty-limit info

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewed-by: Juan Q

[PATCH QEMU v10 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Markus Armbruster Reviewe

[PATCH QEMU v10 7/9] migration: Implement dirty-limit convergence algorithm

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algorithm for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability ena

[PATCH QEMU v10 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during live migration by qmp migrate-set-pa

[PATCH QEMU v10 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirty page rate calculation period configurable. Currently, as the "x-vcpu-dirty-limit-period" varies, the total time of live migration changes. Tes

[PATCH QEMU v10 0/9] migration: introduce dirtylimit capability

2023-07-24 Thread ~hyman
Hi, Juan, Markus and i has crafted docs for the series, please use the latest version to make a pull request if it is convenient to you. No functional changes since v6. Thanks. Yong v7~v10: Rebase on master, update "Since" tags to 8.2, fix conflicts and craft the docs suggested by Markus v6: 1.

[PATCH QEMU v10 6/9] migration: Put the detection logic before auto-converge checking

2023-07-24 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-off-by: Hyman

Re: [PATCH 0/6] Add nRF51 DETECT signal with test

2023-07-24 Thread Chris Laplante
Hi Peter, > Thanks for this patchset and especially for the work > improving the qtest infrastructure. I've given my > comments on the different patches, and in some cases > reviewed-by tags. (Where I've given one of those, you should > add it to your commit message for the relevant patch under >

Re: [RFC PATCH 11/12] vdpa: use SVQ to stall dataplane while NIC state is being restored

2023-07-24 Thread Jason Wang
On Tue, Jul 25, 2023 at 3:59 AM Eugenio Perez Martin wrote: > > On Sat, Jul 22, 2023 at 12:59 AM Si-Wei Liu wrote: > > > > > > > > On 7/20/2023 11:14 AM, Eugenio Pérez wrote: > > > Some dynamic state of a virtio-net vDPA devices is restored from CVQ in > > > the event of a live migration. Howeve

Re: [PATCH 5/6] qtest: irq_intercept_[out/in]: return FAIL if no intercepts are installed

2023-07-24 Thread Chris Laplante
> Makes sense. Did you do a 'make check' on an > all-targets-enabled build just to confirm we haven't > accidentally let any bogus uses of the command in while > it was returning OK for these cases? > > Reviewed-by: Peter Maydell peter.mayd...@linaro.org Yes, I just did a 'make check' and got:

[PATCH] target/riscv: don't read write-only CSR

2023-07-24 Thread Nikita Shubin
From: Nikita Shubin In case of write-only CSR don't return illegal inst error when CSR is written and lacks read op. Signed-off-by: Nikita Shubin --- Anyway it not might be a good idea to read CSR when we are not asked for, during CSRRW or CSRRWI: "For CSRRWI, if rd=x0, then the instruction sh

RE: [Question - ARM CCA] vCPU Hotplug Support in ARM Realm world might require ARM spec change?

2023-07-24 Thread Salil Mehta via
Hello, > From: bibo mao > Sent: Tuesday, July 25, 2023 2:14 AM > To: Salil Mehta [...] > 在 2023/7/25 08:56, Salil Mehta 写道: > > Hi Bibo, > > > >> From: bibo mao > >> Sent: Tuesday, July 25, 2023 1:29 AM > >> To: Salil Mehta > >> Cc: Catalin Marinas ; Jonathan Cameron > >> ; Marc Zyngier ;

Re: [Question - ARM CCA] vCPU Hotplug Support in ARM Realm world might require ARM spec change?

2023-07-24 Thread bibo mao
在 2023/7/25 13:45, Salil Mehta 写道: > Hello, > >> From: bibo mao >> Sent: Tuesday, July 25, 2023 2:14 AM >> To: Salil Mehta > > > [...] > > >> 在 2023/7/25 08:56, Salil Mehta 写道: >>> Hi Bibo, >>> From: bibo mao Sent: Tuesday, July 25, 2023 1:29 AM To: Salil Mehta Cc: C

Re: [PATCH v2 1/4] virtio-net: do not reset vlan filtering at set_features

2023-07-24 Thread Jason Wang
On Sun, Jul 23, 2023 at 5:27 PM Hawkins Jiawei wrote: > > From: Eugenio Pérez > > This function is called after virtio_load, so all vlan configuration is > lost in migration case. > > Just allow all the vlan-tagged packets if vlan is not configured, and > trust device reset to clear all filtered

Re: [PATCH 0/3] hw/arm/virt: Use generic CPU invalidation

2023-07-24 Thread Igor Mammedov
On Mon, 24 Jul 2023 16:14:22 +0100 Peter Maydell wrote: > On Mon, 24 Jul 2023 at 16:06, Igor Mammedov wrote: > > I've seen others asking why you print type name instead of shorter cpu-model > > used on CLI. To do that would make you write a patch to implement reverse > > mapping. > > In some ca

Re: [PATCH v2 3/4] vdpa: Restore vlan filtering state

2023-07-24 Thread Jason Wang
On Sun, Jul 23, 2023 at 5:28 PM Hawkins Jiawei wrote: > > This patch introduces vhost_vdpa_net_load_single_vlan() > and vhost_vdpa_net_load_vlan() to restore the vlan > filtering state at device's startup. > > Co-developed-by: Eugenio Pérez > Signed-off-by: Eugenio Pérez > Signed-off-by: Hawkins

Re: [PATCH v2 2/4] virtio-net: Expose MAX_VLAN

2023-07-24 Thread Jason Wang
On Sun, Jul 23, 2023 at 5:27 PM Hawkins Jiawei wrote: > > vhost-vdpa shadowed CVQ needs to know the maximum number of > vlans supported by the virtio-net device, so QEMU can restore > the VLAN state in a migration. > > Co-developed-by: Eugenio Pérez > Signed-off-by: Eugenio Pérez > Signed-off-by

Re: [PATCH v2 4/4] vdpa: Allow VIRTIO_NET_F_CTRL_VLAN in SVQ

2023-07-24 Thread Jason Wang
On Sun, Jul 23, 2023 at 5:27 PM Hawkins Jiawei wrote: > > Enable SVQ with VIRTIO_NET_F_CTRL_VLAN feature. > > Co-developed-by: Eugenio Pérez > Signed-off-by: Eugenio Pérez > Signed-off-by: Hawkins Jiawei Acked-by: Jason Wang Thanks > --- > net/vhost-vdpa.c | 1 + > 1 file changed, 1 insert

Re: [PATCH v2] net: add initial support for AF_XDP network backend

2023-07-24 Thread Jason Wang
On Thu, Jul 20, 2023 at 9:26 PM Ilya Maximets wrote: > > On 7/20/23 09:37, Jason Wang wrote: > > On Thu, Jul 6, 2023 at 4:58 AM Ilya Maximets wrote: > >> > >> AF_XDP is a network socket family that allows communication directly > >> with the network device driver in the kernel, bypassing most or

<    1   2   3