On Sun, Jul 23, 2023 at 5:27 PM Hawkins Jiawei <yin31...@gmail.com> wrote:
>
> From: Eugenio Pérez <epere...@redhat.com>
>
> This function is called after virtio_load, so all vlan configuration is
> lost in migration case.
>
> Just allow all the vlan-tagged packets if vlan is not configured, and
> trust device reset to clear all filtered vlans.
>
> Fixes: 0b1eaa8803 ("virtio-net: Do not filter VLANs without F_CTRL_VLAN")
> Signed-off-by: Eugenio Pérez <epere...@redhat.com>
> Reviewed-by: Hawkins Jiawei <yin31...@gmail.com>
> Signed-off-by: Hawkins Jiawei <yin31...@gmail.com>
Acked-by: Jason Wang <jasow...@redhat.com>
Thanks
> ---
> hw/net/virtio-net.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 7102ec4817..d20d5a63cd 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -1006,9 +1006,7 @@ static void virtio_net_set_features(VirtIODevice *vdev,
> uint64_t features)
> vhost_net_save_acked_features(nc->peer);
> }
>
> - if (virtio_has_feature(features, VIRTIO_NET_F_CTRL_VLAN)) {
> - memset(n->vlans, 0, MAX_VLAN >> 3);
> - } else {
> + if (!virtio_has_feature(features, VIRTIO_NET_F_CTRL_VLAN)) {
> memset(n->vlans, 0xff, MAX_VLAN >> 3);
> }
>
> --
> 2.25.1
>
