Am 16. Juli 2023 19:53:37 UTC schrieb Bernhard Beschow :
>
>
>Am 10. Juli 2023 16:01:46 UTC schrieb Bernhard Beschow :
>>
>>
>>Am 10. Juli 2023 10:16:35 UTC schrieb "Philippe Mathieu-Daudé"
>>:
>>>On 9/7/23 10:09, Bernhard Beschow wrote:
Since commit c0a55a0c9da2 "hw/sd/sdhci: Support big
Hi If you have topics for this week call, please let's us now. Later, Juan.
QEMU developers fortnightly conference call
Tuesday 2023-07-25 ⋅ 15:00 – 16:00
Central European Time - Madrid
Location
https://meet.jit.si/kvmcallmeeting
https://www.google.com/url?q=https%3A%2F%2Fmeet.jit.si%2Fkvm
On 16/07/2023 14.05, Michael Tokarev wrote:
16.07.2023 14:57, Michael Tokarev пишет:
The following changes since commit 7d07a21ec003724475566073404c5893e36de5e5:
tree-wide spelling fixes in comments and some messages: hw/9pfs
(2023-07-16 13:59:17 +0300)
are available in the Git repository
When the vhost-user reconnect to the backend, the notifer should be
cleanup. Otherwise, the fd resource will be exhausted.
Fixes: f9a09ca3ea ("vhost: add support for configure interrupt")
Signed-off-by: Li Feng
---
hw/virtio/vhost.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virti
Hi
Daniel, in commit 275e0d616b ("ui: refactor code for populating
SocketAddress from vnc_display_open"), you said "This refactoring also
removes the restriction that prevents enabling websockets when the plain
VNC server is listening on a UNIX socket.". But you didn't remove the
condition. I supp
Type 13 is reserved, so using it should result in specification
exception. Due to an off-by-1 error the code triggers an assertion at a
later point in time instead.
Cc: qemu-sta...@nongnu.org
Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)")
Reviewed-by: David Hildenbrand
R
i386 and s390x implementations of op_add2 require an earlyclobber,
which is currently missing. This breaks VCKSM in s390x guests. E.g., on
x86_64 the following op:
add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2 dead: 0 2 3 4 5 pref=none,0x
is translated to:
addl %ebx, %r12d
adcl
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 1 +
tests/tcg/s390x/vcksm.c | 31 +++
tests/tcg/s390x/vx.h| 2 ++
3 files changed, 34 insertions(+)
create mo
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 5 +
tests/tcg/s390x/cgebra.c| 32
tests/tcg/s390x/clgebr.c| 32
3 files c
.. adding Alex, maybe something related to multithreaded TCG?
On 7/21/23 11:08, Claudio Fontana wrote:
>
> Hello Cornelia, Richard,
>
> I had some strange behavior in an s390x TCG VM that I am debugging,
>
> and configured latest upstream QEMU with --enable-debug --enable-debug-tcg
>
> and I a
R2 designates an even-odd register pair; the instruction should raise
a specification exception when R2 is not even.
Cc: qemu-sta...@nongnu.org
Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU")
Signed-off-by: Ilya Leoshkevich
---
target/s390x/tcg/insn-data.h.inc | 2 +-
target/s390x/
MC requires bit positions 8-11 (upper 4 bits of class) to be zeros,
otherwise it must raise a specification exception.
Cc: qemu-sta...@nongnu.org
Fixes: 20d143e2cab8 ("s390x/tcg: Implement MONITOR CALL")
Reviewed-by: David Hildenbrand
Reviewed-by: Richard Henderson
Signed-off-by: Ilya Leoshkevic
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/stpq.S | 20
2 files changed, 21 insertions(+)
create mode 100644 tests/tcg/s390x/stpq.S
di
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/clm.S | 29 +
2 files changed, 30 insertions(+)
create mode 100644 tests/tcg/s390x/clm.S
When the mask is zero, access exceptions should still be recognized for
1 byte at the second-operand address. CC should be set to 0.
Cc: qemu-sta...@nongnu.org
Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU")
Reviewed-by: David Hildenbrand
Reviewed-by: Richard Henderson
Signed-off-b
v3: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03902.html
v3 -> v4: Introduce in2_ra2_E (Richard).
Use probe_read (Richard).
Add R-bs.
Patches needing review: [01/14], [08/14]-[14/14].
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03762.ht
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/mc.S| 56 +
2 files changed, 57 insertions(+)
create mode 100644 tests/tcg/s390x/mc.S
CONVERT TO LOGICAL/FIXED deviate from IEEE 754 in that they raise an
inexact exception on out-of-range inputs. float_flag_invalid_cvti
aligns nicely with that behavior, so convert it to
S390_IEEE_MASK_INEXACT.
Cc: qemu-sta...@nongnu.org
Fixes: defb0e3157af ("s390x: Implement opcode helpers")
Revie
Add a small test to prevent regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/cksm.S | 29 +
2 files changed, 30 insertions(+)
create mode 100644 tests/tcg/s390x/cksm.S
diff --git a/tests/tc
Add a small test to prevent regressions.
Tested-by: Thomas Huth
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.softmmu-target | 1 +
tests/tcg/s390x/icm.S | 32 +
2 files changed, 33 insertions(+)
create mode 100644 tests/tcg/s390x/icm.S
When the mask is zero, access exceptions should still be recognized for
1 byte at the second-operand address. CC should be set to 0.
Cc: qemu-sta...@nongnu.org
Fixes: defb0e3157af ("s390x: Implement opcode helpers")
Reviewed-by: David Hildenbrand
Reviewed-by: Richard Henderson
Signed-off-by: Ily
On Mon, Jul 24 2023, Gavin Shan wrote:
> Hi Connie,
>
> On 7/18/23 21:14, Cornelia Huck wrote:
>> We can neaten the code by switching to the kvm_set_one_reg function.
>>
>> Signed-off-by: Cornelia Huck
>> ---
>> target/arm/kvm.c | 13 +++--
>> target/arm/kvm64.c | 66 +-
On Mon, Jul 24 2023, Gavin Shan wrote:
> Hi Connie,
>
> On 7/18/23 21:14, Cornelia Huck wrote:
>> We can neaten the code by switching the callers that work on a
>> CPUstate to the kvm_get_one_reg function.
>>
>> Signed-off-by: Cornelia Huck
>> ---
>> target/arm/kvm.c | 15 +++-
>>
On Mon, Jul 24, 2023 at 12:08:26PM +0400, Marc-André Lureau wrote:
> Hi
>
> Daniel, in commit 275e0d616b ("ui: refactor code for populating
> SocketAddress from vnc_display_open"), you said "This refactoring also
> removes the restriction that prevents enabling websockets when the plain
> VNC serv
On Mon, Jul 24, 2023 at 12:03:56AM +0300, Sergii Zasenko wrote:
> Signed-off-by: Sergii Zasenko
> ---
> ui/vnc.c | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 92964dc..dea1414 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3715,11 +3715,6 @@ static int
The virtio-gpu test is known to be flaky - that's why we also did
not enable the test_s390x_fedora in the gitlab CI. However, a flaky
test can also be annoying when testing locally, so let's rather skip
this subtest by default and start running the test_s390x_fedora test
in the gitlab CI again (sin
From: Anton Johansson
In replacing target_ulong with vaddr and TARGET_FMT_lx with VADDR_PRIx,
the zero-padding of TARGET_FMT_lx got lost. Readd 16-wide zero-padding
for logging consistency.
Suggested-by: Peter Maydell
Signed-off-by: Anton Johansson
Message-Id: <20230713120746.26897-1-a...@rev
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 10 ++
bsd-user/mmap.c | 1 +
linux-user/mmap.c | 1 +
3 files changed, 12 insertions(+)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 5fa0687cd2..d02517e95f
In the initial commit, cdfac37be0d, the sense of the test is incorrect,
as the -1/0 return was confusing. In bef6f008b981, we mechanically
invert all callers while changing to false/true return, preserving the
incorrectness of the test.
Now that the return sense is sane, it's easy to see that if
From: Jordan Niethe
Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified
goto_tb to ensure only a single instruction was patched to prevent
incorrect behavior if a thread was in the middle of multiple
instructions when they were replaced. However this introduced a race
between loa
From: Luca Bonissi
These should match 'start' as target_ulong, not target_long.
On 32bit targets, the parameter was sign-extended to uint64_t,
so only the first mmap within the upper 2GB memory can succeed.
Signed-off-by: Luca Bonissi
Message-Id: <327460e2-0ebd-9edb-426b-1df80d16c...@bonslack.
The following changes since commit d1181d29370a4318a9f11ea92065bea6bb159f83:
Merge tag 'pull-nbd-2023-07-19' of https://repo.or.cz/qemu/ericb into staging
(2023-07-20 09:54:07 +0100)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.git tags/pull-tcg-2023072
From: Ilya Leoshkevich
i386 and s390x implementations of op_add2 require an earlyclobber,
which is currently missing. This breaks VCKSM in s390x guests. E.g., on
x86_64 the following op:
add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2 dead: 0 2 3 4 5 pref=none,0x
is translated to:
addl
For user-only, the probe for page writability may race with another
thread's mprotect. Take the mmap_lock around the operation. This
is still faster than the start/end_exclusive fallback.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
accel/tcg/ldst_atomicity.c.inc | 32 +
On 7/24/23 09:15, Ilya Leoshkevich wrote:
R2 designates an even-odd register pair; the instruction should raise
a specification exception when R2 is not even.
Cc:qemu-sta...@nongnu.org
Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU")
Signed-off-by: Ilya Leoshkevich
---
target/s390
On Sat, 22 Jul 2023 21:52:06 -0700
Ira Weiny wrote:
> nifan@ wrote:
> > From: Fan Ni
> >
> > The patch series provides dynamic capacity device (DCD) emulation in Qemu.
>
> I don't the patches on the list.
>
> https://lore.kernel.org/all/sg2pr06mb33976bb3f9c47cbe08f02d09b2...@sg2pr06mb3397.a
Thomas Huth wrote:
> The tests from tests/avocado/migration.py do not work at all
> on s390x - the bios shuts down immediately when it cannot find
> a boot disk, so there is nothing left to migrate here. For doing
> a proper migration test, we would need a proper payload, but we
> already do such
On Mon, 17 Jul 2023 at 10:50, Michael Tokarev wrote:
>
> 16.07.2023 18:58, Philippe Mathieu-Daudé wrote:
> ...
> >> Michael Tokarev (5):
> >>tree-wide spelling fixes in comments and some messages: migration/
> >>tree-wide spelling fixes in comments and some messages: s390x
> >>tree-wid
~hyman writes:
> From: Hyman Huang(黄勇)
>
> Introduce migration dirty-limit capability, which can
> be turned on before live migration and limit dirty
> page rate durty live migration.
>
> Introduce migrate_dirty_limit function to help check
> if dirty-limit capability enabled during live migrati
~hyman writes:
> From: Hyman Huang(黄勇)
>
> Introduce "x-vcpu-dirty-limit-period" migration experimental
> parameter, which is in the range of 1 to 1000ms and used to
> make dirty page rate calculation period configurable.
>
> Currently with the "x-vcpu-dirty-limit-period" varies, the
Currently,
On 7/21/23 17:14, Michael Tokarev wrote:
19.07.2023 18:52, Helge Deller wrote:
qemu-user crashes immediately when running static binaries on the armhf
architecture. The problem is the memory layout where the executable is
loaded before the interpreter library, in which case the reserved brk
regi
On 22/07/2023 08.21, Andrew Jones wrote:
Since Linux commit 00f918f61c56 ("RISC-V: KVM: Skeletal in-kernel AIA
irqchip support") checking KVM_CAP_IRQCHIP returns non-zero when the
RISC-V platform has AIA. The cap indicates KVM supports at least one
of the following ioctls:
KVM_CREATE_IRQCHIP
Gurchetan Singh writes:
> In terms of API stability/versioning/packaging, once this series is
> reviewed, the plan is to cut a "gfxstream upstream release branch". We
> will have the same API guarantees as any other QEMU project then, i.e no
> breaking API changes for 5 years.
What about Rutaba
On 7/18/23 16:22, Cornelia Huck wrote:
Add 8.2 machine types for arm/i440fx/m68k/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
---
hw/arm/virt.c | 9 -
hw/core/machine.c | 3 +++
hw/i386/pc.c | 3 +++
hw/i386/pc_piix.c | 16 ++
- Remove unix socket option limitation for VNC websocket
- Reflect websocket option changes in documentation
Signed-off-by: Sergii Zasenko
---
qemu-options.hx | 4
ui/vnc.c| 5 -
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
ind
On Mon, Jul 24, 2023 at 2:04 PM Sergii Zasenko wrote:
> - Remove unix socket option limitation for VNC websocket
> - Reflect websocket option changes in documentation
>
> Signed-off-by: Sergii Zasenko
>
Reviewed-by: Marc-André Lureau
> ---
> qemu-options.hx | 4
> ui/vnc.c| 5 -
v3 -> v4:
- Hanna pointed out that 'throttle type' is not clear enough,
'throttle direction' would be better in the v3.
Use 'ThrottleDirection' instead, also rename 'ThrottleType throttle' to
'ThrottleDirection direction'.
- For patch 'throttle: support read-only and write-only', reduce codes
Operations on a cryptodev are considered as *write* only, the callback
of read direction is never invoked. Use NULL instead of an unreachable
path(cryptodev_backend_throttle_timer_cb on read direction).
The dummy read timer(never invoked) is already removed here, it means
that the 'FIXME' tag is n
Use enum ThrottleDirection instead of number index.
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
---
include/qemu/throttle.h | 11 ---
util/throttle.c | 16 +---
2 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/in
Use enum ThrottleDirection instead in the throttle test codes.
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
---
tests/unit/test-throttle.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/unit/test-throttle.c b/tests/unit/test
enum ThrottleDirection is already there, use ThrottleDirection instead
of 'bool is_write' for throttle API, also modify related codes from
block, fsdev, cryptodev and tests.
Signed-off-by: zhenwei pi
---
backends/cryptodev.c| 9 +
block/throttle-groups.c | 6 --
fsdev/q
The first dimension of both to_check and
bucket_types_size/bucket_types_units is used as throttle direction,
use THROTTLE_MAX instead of hard coded number. Also use ARRAY_SIZE()
to avoid hard coded number for the second dimension.
Hanna noticed that the two array should be static. Yes, turn them
i
'bool is_write' style is obsolete from throttle framework, adapt
block throttle groups to the new style.
Use a simple python script to test the new style:
#!/usr/bin/python3
import subprocess
import random
import time
commands = ['virsh blkdeviotune jammy vda --write-bytes-sec ', \
'
Only one direction is necessary in several scenarios:
- a read-only disk
- operations on a device are considered as *write* only. For example,
encrypt/decrypt/sign/verify operations on a cryptodev use a single
*write* timer(read timer callback is defined, but never invoked).
Allow a single dir
'bool is_write' style is obsolete from throttle framework, adapt
fsdev to the new style.
Cc: Greg Kurz
Signed-off-by: zhenwei pi
---
fsdev/qemu-fsdev-throttle.c | 14 +++---
fsdev/qemu-fsdev-throttle.h | 4 ++--
hw/9pfs/cofile.c| 4 ++--
3 files changed, 11 insertions(+),
Reviewed-by: Alberto Garcia
Reviewed-by: Hanna Czenczek
Signed-off-by: zhenwei pi
---
tests/unit/test-throttle.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
index a60b5fe22e..5547837a58 10064
On Fri, 2023-07-21 at 13:24 +0200, Pierre Morel wrote:
>
> On 7/18/23 18:31, Nina Schoetterl-Glausch wrote:
> > Reviewed-by: Nina Schoetterl-Glausch
> >
> > Some notes below.
> >
> > The s390x/ prefix in the title might suggest that this patch
> > is s390 specific, but it touches common files.
On 18/07/2023 16.22, Cornelia Huck wrote:
Add 8.2 machine types for arm/i440fx/m68k/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
---
hw/arm/virt.c | 9 -
hw/core/machine.c | 3 +++
hw/i386/pc.c | 3 +++
hw/i386/pc_piix.c | 16 +++
On Sat, 22 Jul 2023 at 02:10, Stefano Stabellini wrote:
>
> The following changes since commit d1181d29370a4318a9f11ea92065bea6bb159f83:
>
> Merge tag 'pull-nbd-2023-07-19' of https://repo.or.cz/qemu/ericb into
> staging (2023-07-20 09:54:07 +0100)
>
> are available in the Git repository at:
>
I missed something...
~hyman writes:
> From: Hyman Huang(黄勇)
>
> Introduce "x-vcpu-dirty-limit-period" migration experimental
> parameter, which is in the range of 1 to 1000ms and used to
> make dirty page rate calculation period configurable.
>
> Currently with the "x-vcpu-dirty-limit-period"
On 22/7/23 08:22, Akihiko Odaki wrote:
kvm_arch_get_default_type() returns the default KVM type. This hook is
particularly useful to derive a KVM type that is valid for "none"
machine model, which is used by libvirt to probe the availability of
KVM.
For MIPS, the existing mips_kvm_type() is reus
Markus Armbruster writes:
> Did this fall through the cracks?
Hmm, looks like Peter is taking care of merging right now.
Doesn't apply to master. Care to rebase?
On 24/7/23 10:48, Thomas Huth wrote:
The virtio-gpu test is known to be flaky - that's why we also did
not enable the test_s390x_fedora in the gitlab CI. However, a flaky
test can also be annoying when testing locally, so let's rather skip
this subtest by default and start running the test_s390x_
On 24.07.2023 12:56, Markus Armbruster wrote:
Doesn't apply to master. Care to rebase?
The series is now based on David's virtio-mem-memslots patches
(specifically, commit 6769107d1a4f from [1]) since it depends
on support for exposing device memory via multiple memslots
provided by that seri
On 24.07.23 10:15, Ilya Leoshkevich wrote:
R2 designates an even-odd register pair; the instruction should raise
a specification exception when R2 is not even.
Cc: qemu-sta...@nongnu.org
Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU")
Signed-off-by: Ilya Leoshkevich
---
Reviewed
"Maciej S. Szmigiero" writes:
> From: "Maciej S. Szmigiero"
>
> Used by the hv-balloon driver to report its provided memory state
> information.
>
> Co-developed-by: David Hildenbrand
> Signed-off-by: Maciej S. Szmigiero
> ---
> hw/core/machine-hmp-cmds.c | 15 +++
> qapi/machine.
"Maciej S. Szmigiero" writes:
> On 24.07.2023 12:56, Markus Armbruster wrote:
>> Doesn't apply to master. Care to rebase?
>>
>
> The series is now based on David's virtio-mem-memslots patches
> (specifically, commit 6769107d1a4f from [1]) since it depends
> on support for exposing device memory
On 24.07.2023 13:37, Markus Armbruster wrote:
"Maciej S. Szmigiero" writes:
From: "Maciej S. Szmigiero"
Used by the hv-balloon driver to report its provided memory state
information.
Co-developed-by: David Hildenbrand
Signed-off-by: Maciej S. Szmigiero
---
hw/core/machine-hmp-cmds.c | 1
On 24.07.2023 13:39, Markus Armbruster wrote:
"Maciej S. Szmigiero" writes:
On 24.07.2023 12:56, Markus Armbruster wrote:
Doesn't apply to master. Care to rebase?
The series is now based on David's virtio-mem-memslots patches
(specifically, commit 6769107d1a4f from [1]) since it depends
o
On Sat, 22 Jul 2023 at 22:44, Richard Henderson
wrote:
>
> Fixes a race condition (generally without optimization) in which
> the subtree is re-read after the protecting if condition.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Richard Henderson
> ---
Reviewed-by: Peter Maydell
thanks
-- P
On Sat, 22 Jul 2023 at 22:44, Richard Henderson
wrote:
>
> Ensure that the stores to rb_left and rb_right are complete before
> inserting the new node into the tree. Otherwise a concurrent reader
> could see garbage in the new leaf.
>
> Cc: qemu-sta...@nongnu.org
> Signed-off-by: Richard Henderso
On Sat, 22 Jul 2023 at 22:44, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> util/interval-tree.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sat, 22 Jul 2023 at 22:44, Richard Henderson
wrote:
>
> While less susceptible to optimization problems than left and right,
> interval_tree_iter_next also reads rb_parent(), so make sure that
> stores and loads are atomic.
>
> This goes further than technically required, changing all loads to
On 7/23/23 23:51, Alistair Francis wrote:
On Thu, Jul 20, 2023 at 11:25 PM Daniel Henrique Barboza
wrote:
Hi,
Found these 2 instances while working in more 8.2 material.
I believe both are safe for freeze but I won't lose my sleep if we
decide to postpone it.
I wasn't going to squeeze t
Sat, 22 Jul 2023 13:49:40 +0100 Richard Henderson
:
> If this is with optimization enabled, the bug should be reported to gcc
> bugzilla.
> The compiler should easily prove the default case is unreachable.
This happens also with -O0 or without any -On, or without -Wall.
https://bugzilla.suse.c
On Sat, 15 Jul 2023 at 14:31, Sean Estabrooks wrote:
>
> The curses display handles most control-X keys, and translates
> them into their corresponding keycode. Here we recognize
> a few that are missing, Ctrl-@ (null), Ctrl-\ (backslash),
> Ctrl-] (right bracket), Ctrl-^ (caret), Ctrl-_ (undersc
From: Fabiano Rosas
We're about to add more functions to this file so make it use the same
coding style as the rest of the code.
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Message-Id: <20230607161306.31425-2-faro...@suse.
From: Hyman Huang(黄勇)
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇)
Reviewed-by: Markus Armbruster
Reviewe
From: Hyman Huang(黄勇)
Implement dirty-limit convergence algo for live migration,
which is kind of like auto-converge algo but using dirty-limit
instead of cpu throttle to make migration convergent.
Enable dirty page limit if dirty_rate_high_cnt greater than 2
when dirty-limit capability enabled,
From: Hyman Huang(黄勇)
Introduce migration dirty-limit capability, which can
be turned on before live migration and limit dirty
page rate durty live migration.
Introduce migrate_dirty_limit function to help check
if dirty-limit capability enabled during live migration.
Meanwhile, refactor vcpu_d
From: Hyman Huang(黄勇)
This commit is prepared for the implementation of dirty-limit
convergence algo.
The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.
Signed-off-by: Hyman
Has return zero for more than 10 years.
Specifically we introduced the field in 1.5.0
commit f1c72795af573b24a7da5eb52375c9aba8a37972
Author: Peter Lieven
Date: Tue Mar 26 10:58:37 2013 +0100
migration: do not sent zero pages in bulk stage
during bulk stage of ram migration if a page
This is how everything else in QEMUFile is structured.
As a bonus they are three less lines of code.
Reviewed-by: Peter Xu
Message-ID: <20230530183941.7223-17-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 1 -
migration/qemu-file.c | 12
migration/r
From: Fabiano Rosas
This doubly linked list is common for all the multifd and migration
threads so we need to avoid concurrent access.
Add a mutex to protect the data from concurrent access. This fixes a
crash when removing two MigrationThread objects from the list at the
same time during cleanu
Fast don't say much. Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230530183941.7223-2-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 11 +--
migration/qemu-f
From: Hyman Huang(黄勇)
Introduce "x-vcpu-dirty-limit-period" migration experimental
parameter, which is in the range of 1 to 1000ms and used to
make dirtyrate calculation period configurable.
Currently with the "x-vcpu-dirty-limit-period" varies, the
total time of live migration changes, test res
This will contain the options needed for both source and target.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-6-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
di
From: Hyman Huang(黄勇)
Introduce "vcpu-dirty-limit" migration parameter used
to limit dirty page rate during live migration.
"vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
two dirty-limit-related migration parameters, which can
be set before and during live migration by qmp
migrate-set-pa
From: Peter Xu
We have postcopy recovery but not reflected in the document, do an update
for that.
Add a very small section on postcopy preempt.
Touch up the pagemap section, dropping the unsent map because it's already
been dropped in the source code in commit 1e7cf8c323 ("migration/postcopy:
We do a qemu_fclose() just after that, that also does a qemu_fflush(),
so remove one qemu_fflush().
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230530183941.7223-3-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
From: Hyman Huang(黄勇)
Check if block migration is running before throttling
guest down in auto-converge way.
Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.
Signed-off-by: Hyman
It makes no sense that we don't have the same configuration on both sides.
Reviewed-by: Laurent Vivier
Message-ID: <20230608224943.3877-2-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/
So all the file is consistent.
Reviewed-by: Markus Armbruster
Message-ID: <20230612191604.2219-1-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
qapi/migration.json | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/qapi/migration.json b/qapi/migrat
Hi
This is the migration PULL request. It has:
- Fabiano rosas trheadinfo cleanups
- Hyman Huang dirtylimit changes
- Part of my changes
- Peter Xu documentation
- Tejus updato to migration descriptions
- Wei want improvements for postocpy and multifd setup
Please apply.
Now a not on CI, thas h
On 7/6/23 19:30, Andrey Drobyshev wrote:
> v1 --> v2:
> * Add vmdk format to the 1st commit. Tweak commit message accordingly;
> * Make "compressed" field in MapEntry optional.
>
> v1: https://lists.nongnu.org/archive/html/qemu-block/2023-06/msg00184.html
>
> Andrey Drobyshev (3):
> block:
From: Wei Wang
The Postcopy preempt capability is expected to be set before incoming
starts, so change the postcopy tests to start with deferred incoming and
call migrate-incoming after the cap has been set.
Why the existing tests (without this patch) didn't fail?
There could be two reasons:
1)
On 6/30/23 13:54, Denis V. Lunev wrote:
> On 6/1/23 21:28, Andrey Drobyshev wrote:
>> This series is adding [-c | --compress] option to "qemu-img rebase"
>> command, which might prove useful for saving some disk space when, for
>> instance, manipulating chains of backup images. Along the way I had
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20230608224943.3877-5-quint...@redhat.com>
---
tests/qtest/migration-test.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2296ed4bf5.
It is not used outside of qemu_file, and it shouldn't.
Signed-off-by: Juan Quintela
Message-ID: <20230530183941.7223-19-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 1 -
migration/qemu-file.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/
1 - 100 of 223 matches
Mail list logo
