Peter Xu writes:
> On Thu, Jul 06, 2023 at 02:33:42PM -0300, Fabiano Rosas wrote:
>> Peter Xu writes:
>>
>> > On Thu, Jul 06, 2023 at 10:50:34AM -0300, Fabiano Rosas wrote:
>> >> Peter Xu writes:
>> >>
>> >> > On Wed, Jul 05, 2023 at 07:05:13PM -0300, Fabiano Rosas wrote:
>> >> >> Peter Xu w
On Fri, Jun 30, 2023 at 06:29:02PM -0300, Fabiano Rosas wrote:
> Add basic tests for file-based migration.
>
> Signed-off-by: Fabiano Rosas
Reviewed-by: Peter Xu
One trivial comment below:
> +static void test_precopy_file_offset_bad(void)
> +{
> +/* using a value not supported by qemu_str
On Fri, Jun 30, 2023 at 06:29:01PM -0300, Fabiano Rosas wrote:
> There is currently no way to write a test for errors that happened in
> qmp_migrate before the migration has started.
>
> Add a version of qmp_migrate that ensures an error happens. To make
> use of it a test needs to set MigrateComm
On Thu, Jul 06, 2023 at 02:14:37PM -0400, Peter Xu wrote:
> On Thu, Jul 06, 2023 at 03:07:40PM -0300, Leonardo Bras Soares Passos wrote:
> > > I asked the same question, and I still keep confused: whether there's a
> > > first bad commit? Starting from when it fails?
> > >
> > > For example, is th
On Wed, Jul 05, 2023 at 03:16:31PM +0200, Eric Auger wrote:
> Hi Zhenghong,
>
> On 7/5/23 10:17, Duan, Zhenzhong wrote:
> >
> >> -Original Message-
> >> From: Duan, Zhenzhong
> >> Sent: Wednesday, July 5, 2023 12:56 PM
> >> Subject: RE: [PATCH 2/2] virtio-iommu: Rework the trace in
> >> vi
Setting scanout mode is better to be done very last minute
right because the mode can be reset anytime after it is set in
dpy_gl_scanout_texture by any asynchronouse dpy_refresh call,
which eventually cancels drawing of the guest scanout texture.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek
Skip refresh if a new dmabuf (guest scanout frame) has already been
submitted and ready to be drawn because the scanout will be updated
with new frame anyway.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 4
ui/gtk-gl-area.c
On Thu, Jul 06, 2023 at 02:50:20PM -0400, Michael S. Tsirkin wrote:
> On Thu, Jul 06, 2023 at 02:14:37PM -0400, Peter Xu wrote:
> > On Thu, Jul 06, 2023 at 03:07:40PM -0300, Leonardo Bras Soares Passos wrote:
> > > > I asked the same question, and I still keep confused: whether there's a
> > > > fi
On Wed, 5 Jul 2023 at 02:02, Jason Wang wrote:
>
> On Mon, Jul 3, 2023 at 5:03 PM Stefan Hajnoczi wrote:
> >
> > On Fri, 30 Jun 2023 at 09:41, Jason Wang wrote:
> > >
> > > On Thu, Jun 29, 2023 at 8:36 PM Stefan Hajnoczi
> > > wrote:
> > > >
> > > > On Thu, 29 Jun 2023 at 07:26, Jason Wang wr
This allow to skip some rings that qemu does not want to enable.
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-vdpa.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 5978d970ee..f51f5d9969 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b
To restore the device at the destination of a live migration we send the
commands through control virtqueue. For a device to read CVQ it must
have received the DRIVER_OK status bit.
However this opens a window where the device could start receiving
packets in rx queue 0 before it receives the RSS
At this moment the migration of net features that depends on CVQ is not
possible, as there is no reliable way to restore the device state like mac
address, number of enabled queues, etc to the destination. This is mainly
caused because the device must only read CVQ, and process all the commands
be
To restore the device at the destination of a live migration we send the
commands through control virtqueue. For a device to read CVQ it must
have received the DRIVER_OK status bit.
However this opens a window where the device could start receiving
packets in rx queue 0 before it receives the RSS
Now that we have add migration blockers if the device does not support
all the needed features, remove the general blocker applied to all net
devices with CVQ.
Signed-off-by: Eugenio Pérez
---
net/vhost-vdpa.c | 12
1 file changed, 12 deletions(-)
diff --git a/net/vhost-vdpa.c b/ne
To restore the device at the destination of a live migration we send
the commands through control virtqueue. For a device to read CVQ it
must have received the DRIVER_OK status bit.
However this opens a window where the device could start receiving
packets in rx queue 0 before it receives the RSS
The vhost-vdpa net backend needs to enable vrings in a different order
than default, so export it.
No functional change intended except for tracing, that now includes the
(virtio) index being enabled and the return value of the ioctl.
Still ignoring return value of this function if called from
vh
Commit e6df58a5578fee7a50bbf36f4a50a2781cff855d
Author: Hanna Reitz
Date: Wed May 8 23:18:18 2019 +0200
qemu-nbd: Do not close stderr
has introduced an interesting regression. Original behavior of
ssh somehost qemu-nbd /home/den/tmp/file -f raw --fork
was the following:
* qemu-n
On Thu, Jun 29, 2023 at 11:59:03AM +0300, Andrei Gudkov wrote:
> Introduces alternative argument calc-time-ms, which is the
> the same as calc-time but accepts millisecond value.
> Millisecond precision allows to make predictions whether
> migration will succeed or not. To do this, calculate dirty
On Thu, Jul 06, 2023 at 06:05:37PM +0100, Richard Henderson wrote:
> We had done this for user-mode by invoking page_protect
> within the translator loop. Extend this to handle system
> mode as well. Move page locking out of tb_link_page.
>
> Reported-by: Liren Wei
> Reported-by: Richard W.M. J
For the most part, AMD hosts can use the same MCE injection code as Intel but,
there are instances where the qemu implementation is Intel specific. First, MCE
deliviery works differently on AMD and does not support broadcast. Second,
kvm_mce_inject generates MCEs that include a number of Intel spec
In the event that a guest process attempts to access memory that has
been poisoned in response to a deferred uncorrected MCE, an AMD system
will currently generate a SIGBUS error which will result in the entire
guest being shutdown. Ideally, we only want to kill the guest process
that accessed pois
Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required to
be exposed to guests to allow them to handle machine check exceptions on AMD
hosts.
Reported-by: William Roche
Signed-off-by: John Allen
---
target/i386/cpu.c | 2 +-
target/i386/cpu.h | 4
2 files changed, 5 in
qemu_file_set_error() sets f->last_error, which is later used by
functions in qemu-file.c to return the error to callers.
The following functions expect f->last_error to be -errno:
qemu_file_get_error_obj()
qemu_file_get_error()
qemu_fclose()
Make sure qemu_file_set_error() always receives a neg
All migration hooks, except this one, return -1 on error and 0 on
success.
Signed-off-by: Fabiano Rosas
---
target/arm/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/machine.c b/target/arm/machine.c
index fc4a4a4064..db3fcd5ae4 100644
--- a/target/arm/ma
The convention in qemu-file.c is to return a negative value on
error.
The only place that could use qemu_file_set_error() to store a
positive value to f->last_error was vmstate_save() which has been
fixed in the previous patch.
bdrv_inactivate_all() already returns a negative value on error.
Doc
The Apple Sound Chip was primarily used by the Macintosh II to generate sound
in hardware which was previously handled by the toolbox ROM with software
interrupts.
Implement both the standard ASC and also the enhanced ASC (EASC) functionality
which is used in the Quadra 800.
Note that whilst rea
On Thu, Jul 06, 2023 at 09:12:21PM +0200, Eugenio Pérez wrote:
> At this moment the migration of net features that depends on CVQ is not
> possible, as there is no reliable way to restore the device state like mac
> address, number of enabled queues, etc to the destination. This is mainly
> caused
On Thu, Jul 06, 2023 at 03:02:07PM -0400, Peter Xu wrote:
> On Thu, Jul 06, 2023 at 02:50:20PM -0400, Michael S. Tsirkin wrote:
> > On Thu, Jul 06, 2023 at 02:14:37PM -0400, Peter Xu wrote:
> > > On Thu, Jul 06, 2023 at 03:07:40PM -0300, Leonardo Bras Soares Passos
> > > wrote:
> > > > > I asked t
On Thu, Jul 06, 2023 at 04:00:49PM -0400, Michael S. Tsirkin wrote:
> I mean his patch is exactly right. cmask was designed with this
> kind of use case in mind.
> Will queue.
That's great news.
> If you want to suggest more text to the commit log, for the benefit
> of backporters, that is fine b
file-based migration requires the target to initiate its migration after
the source has finished writing out the data in the file. Currently
there's no easy way to initiate 'migrate-incoming', allow this by
introducing migrate_incoming_qmp helper, similarly to migrate_qmp.
Also make sure migration
The following patch will make use of this function from within
migrate-helpers.c, so move it there.
Reviewed-by: Juan Quintela
Reviewed-by: Thomas Huth
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 11 +++
tests/qtest/migration-helpers.h | 3
Add basic tests for file-based migration.
Signed-off-by: Fabiano Rosas
Reviewed-by: Peter Xu
---
tests/qtest/migration-test.c | 99
1 file changed, 99 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2fdf6a115e..c
There is currently no way to write a test for errors that happened in
qmp_migrate before the migration has started.
Add a version of qmp_migrate that ensures an error happens. To make
use of it a test needs to set MigrateCommon.result as
MIG_TEST_QMP_ERROR.
Reviewed-by: Peter Xu
Signed-off-by: F
We are sending a migration event of MIGRATION_STATUS_SETUP at
qemu_start_incoming_migration but never actually setting the state.
This creates a window between qmp_migrate_incoming and
process_incoming_migration_co where the migration status is still
MIGRATION_STATUS_NONE. Calling query-migrate du
Use the new migrate_incoming_qmp helper in the places that currently
open-code calling migrate-incoming.
Reviewed-by: Juan Quintela
Reviewed-by: Peter Xu
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 1 +
tests/qtest/migration-test.c | 12 ++---
tests/qtest/virtio-
Based-on:
[PATCH V4 0/2] migration file URI
https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sist...@oracle.com
Since v3:
- used FILE_TEST_FILENAME for the three tests
v3:
https://lore.kernel.org/r/20230630212902.19925-1-faro...@suse.de
v2:
https://lore.kernel.org/r/202306281
Hi John,
Thanks for the patches. Few comments below.
On 7/6/23 14:40, John Allen wrote:
> Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required to
> be exposed to guests to allow them to handle machine check exceptions on AMD
> hosts.
>
> Reported-by: William Roche
> Signed
On Tue, 4 Jul 2023 16:39:27 +0300
Avihai Horon wrote:
> vfio_realize() has the following flow:
> 1. vfio_bars_prepare() -- sets VFIOBAR->size.
> 2. msix_early_setup().
> 3. vfio_bars_register() -- allocates VFIOBAR->mr.
>
> After vfio_bars_prepare() is called msix_early_setup() can fail. If it
>
On 7/6/23 08:16, BALATON Zoltan wrote:
Add a QOM type name define for ppc4xx-host-bridge in the common header
and replace direct use of the string name with the constant.
Signed-off-by: BALATON Zoltan
---
Reviewed-by: Daniel Henrique Barboza
hw/ppc/ppc440_pcix.c| 3 ++-
hw/ppc/pp
On 7/6/23 08:16, BALATON Zoltan wrote:
Rename TYPE_PPC440_PCIX_HOST_BRIDGE to better match its string value,
move it to common header and use it also in sam460ex to replace hard
coded type name.
Signed-off-by: BALATON Zoltan
---
Reviewed-by: Daniel Henrique Barboza
hw/ppc/ppc440_pcix.
On 7/6/23 08:16, BALATON Zoltan wrote:
Rename the TYPE_PPC4xx_PCI_HOST_BRIDGE define and its string value to
match each other and other similar types and to avoid confusion with
"ppc4xx-host-bridge" type defined in same file.
Signed-off-by: BALATON Zoltan
---
I struggled a bit to understan
On 7/6/23 04:32, Nicholas Piggin wrote:
On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote:
ppc currently silently accepts invalid real address access. Catch
these and turn them into machine checks on POWER9/10 machines.
Would there be any objections to merging this and the checksto
On 7/6/23 22:50, Daniel Henrique Barboza wrote:
On 7/6/23 04:32, Nicholas Piggin wrote:
On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote:
ppc currently silently accepts invalid real address access. Catch
these and turn them into machine checks on POWER9/10 machines.
Would there be
+x86 qemu folks
On 06/07/2023 20:40, John Allen wrote:
> For the most part, AMD hosts can use the same MCE injection code as Intel but,
> there are instances where the qemu implementation is Intel specific. First,
> MCE
> deliviery works differently on AMD and does not support broadcast. Second,
+x86 qemu folks
On 06/07/2023 21:22, Moger, Babu wrote:
> Hi John,
> Thanks for the patches. Few comments below.
>
> On 7/6/23 14:40, John Allen wrote:
>> Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required
>> to
>> be exposed to guests to allow them to handle machine che
On Thu, Jul 6, 2023 at 3:24 PM Peter Xu wrote:
>
> On Thu, Jul 06, 2023 at 03:07:40PM -0300, Leonardo Bras Soares Passos wrote:
> > > I asked the same question, and I still keep confused: whether there's a
> > > first bad commit? Starting from when it fails?
> > >
> > > For example, is this broke
Hello all,
I have a test case that needs to intercept a named GPIO out interrupt.
qtest_irq_intercept_out doesn't support this currently. I would like to send a
patch to add this functionality. Does anyone have a preference if I implement
it is a new function (qtest_irq_intercept_out_named), vs
Hi Peter,
> >
> > Working on adding this now. One question - if the CPU is off (via
> > arm_set_cpu_off), will the 'DETECT' IRQ I add to nrf51_gpio.c still fire?
>
>
> Yes. The only thing that turning the CPU off affects is
> the CPU -- all the rest of the devices in the system
> continue to b
On Thu, 6 Jul 2023, Daniel Henrique Barboza wrote:
On 7/6/23 08:16, BALATON Zoltan wrote:
Rename the TYPE_PPC4xx_PCI_HOST_BRIDGE define and its string value to
match each other and other similar types and to avoid confusion with
"ppc4xx-host-bridge" type defined in same file.
Signed-off-by: BAL
Alex Bennée writes:
> Can gdb switch which packet sequence it uses to halt and restart
> threads?
Yes, but the way it does it does not trigger the behavior I was concerned
about. GDB falls back to the old sequence when either (1) the target does not
support the vCont command it's trying to send
zhangjianguo (A) 将撤回邮件“Qemu asan test reported heap-use-after-free error when
using qxl and spice”。
On Fri, Jul 7, 2023 at 3:08 AM Stefan Hajnoczi wrote:
>
> On Wed, 5 Jul 2023 at 02:02, Jason Wang wrote:
> >
> > On Mon, Jul 3, 2023 at 5:03 PM Stefan Hajnoczi wrote:
> > >
> > > On Fri, 30 Jun 2023 at 09:41, Jason Wang wrote:
> > > >
> > > > On Thu, Jun 29, 2023 at 8:36 PM Stefan Hajnoczi
>
>-Original Message-
>From: Jean-Philippe Brucker
>Sent: Thursday, July 6, 2023 10:36 PM
>Subject: Re: [PATCH 2/2] virtio-iommu: Rework the trace in
>virtio_iommu_set_page_size_mask()
>
>On Wed, Jul 05, 2023 at 03:16:31PM +0200, Eric Auger wrote:
>> >>> diff --git a/hw/virtio/virtio-iommu.c
On Thu, Jul 6, 2023 at 10:59 PM Markus Armbruster wrote:
> ~hyman writes:
>
> > From: Hyman Huang(黄勇)
> >
> > Introduce migration dirty-limit capability, which can
> > be turned on before live migration and limit dirty
> > page rate durty live migration.
> >
> > Introduce migrate_dirty_limit fu
The Quad Management Engine (QME) manages power related settings for its
quad. The xscom region is separate from the quad xscoms, therefore a new
region is added. The xscoms in a QME select a given core by selecting
the forth nibble.
Implement dummy reads for the stop state history (SSH) and specia
From: Hyman Huang(黄勇)
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇)
Reviewed-by: Markus Armbruster
Reviewe
From: Hyman Huang(黄勇)
Introduce "x-vcpu-dirty-limit-period" migration experimental
parameter, which is in the range of 1 to 1000ms and used to
make dirtyrate calculation period configurable.
Currently with the "x-vcpu-dirty-limit-period" varies, the
total time of live migration changes, test res
From: Hyman Huang(黄勇)
Introduce migration dirty-limit capability, which can
be turned on before live migration and limit dirty
page rate durty live migration.
Introduce migrate_dirty_limit function to help check
if dirty-limit capability enabled during live migration.
Meanwhile, refactor vcpu_d
From: Hyman Huang(黄勇)
Check if block migration is running before throttling
guest down in auto-converge way.
Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.
Signed-off-by: Hyman
From: Hyman Huang(黄勇)
This commit is prepared for the implementation of dirty-limit
convergence algo.
The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.
Signed-off-by: Hyman
Hi, Juan and Markus, thanks for reviewing the previous
versions and please review the latest version if you have time :)
Yong
v8:
1. Rebase on master and refactor the docs suggested by Markus
v7:
1. Rebase on master and fix conflicts
v6:
1. Rebase on master
2. Split the commit "Implement dirty-
From: Hyman Huang(黄勇)
Introduce "vcpu-dirty-limit" migration parameter used
to limit dirty page rate during live migration.
"vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
two dirty-limit-related migration parameters, which can
be set before and during live migration by qmp
migrate-set-pa
From: Hyman Huang(黄勇)
Add migration dirty-limit capability test if kernel support
dirty ring.
Migration dirty-limit capability introduce dirty limit
capability, two parameters: x-vcpu-dirty-limit-period and
vcpu-dirty-limit are introduced to implement the live
migration with dirty limit.
The te
From: Hyman Huang(黄勇)
Extend query-migrate to provide throttle time and estimated
ring full time with dirty-limit capability enabled, through which
we can observe if dirty limit take effect during live migration.
Signed-off-by: Hyman Huang(黄勇)
Reviewed-by: Markus Armbruster
Reviewed-by: Juan Q
From: Hyman Huang(黄勇)
Implement dirty-limit convergence algo for live migration,
which is kind of like auto-converge algo but using dirty-limit
instead of cpu throttle to make migration convergent.
Enable dirty page limit if dirty_rate_high_cnt greater than 2
when dirty-limit capability enabled,
On 7/7/23 06:06, Joel Stanley wrote:
The Quad Management Engine (QME) manages power related settings for its
quad. The xscom region is separate from the quad xscoms, therefore a new
region is added. The xscoms in a QME select a given core by selecting
the forth nibble.
Implement dummy reads for
https://github.com/cschoenebeck/qemu.git tags/pull-9p-20230706
for you to fetch changes up to 3548fa01511b4d8d19d4b187d3989b7033b733d8:
MAINTAINERS: raise status of 9p to 'Maintained' (2023-07-06 11:42:08 +0200)
Adminis
On Thu, Jul 6, 2023 at 10:02 PM Michael S. Tsirkin wrote:
>
> On Thu, Jul 06, 2023 at 09:12:21PM +0200, Eugenio Pérez wrote:
> > At this moment the migration of net features that depends on CVQ is not
> > possible, as there is no reliable way to restore the device state like mac
> > address, numbe
MacOS (un)helpfully leaves the FIFO engine running even when all the samples
have
been written to the hardware, and expects the FIFO status flags and IRQ to be
updated continuously.
Since not all audio backends guarantee an all-zero output when no data is
provided, explicitly generate at least o
201 - 269 of 269 matches
Mail list logo
