On Fri, Jun 30, 2023 at 06:29:02PM -0300, Fabiano Rosas wrote: > Add basic tests for file-based migration. > > Signed-off-by: Fabiano Rosas <faro...@suse.de>
Reviewed-by: Peter Xu <pet...@redhat.com> One trivial comment below: > +static void test_precopy_file_offset_bad(void) > +{ > + /* using a value not supported by qemu_strtosz() */ > + g_autofree char *uri = g_strdup_printf("file:%s/migfile,offset=0x20M", Better reuse FILE_TEST_FILENAME. > + tmpfs); > + MigrateCommon args = { > + .connect_uri = uri, > + .listen_uri = "defer", > + .result = MIG_TEST_QMP_ERROR, > + }; > + > + test_precopy_common(&args); > +} -- Peter Xu