Re: [PATCH v2 3/6] util/async-teardown: Fall back to close fds one by one

2023-06-19 Thread Richard Henderson
On 6/16/23 17:27, Bin Meng wrote: When opening /proc/self/fd fails, current codes just return directly, but we can fall back to close fds one by one. Signed-off-by: Bin Meng --- (no changes since v1) util/async-teardown.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v2 4/6] utils/osdep: Introduce qemu_close_range()

2023-06-19 Thread Richard Henderson
On 6/16/23 17:27, Bin Meng wrote: This introduces a new QEMU API qemu_close_range() that closes all open file descriptors from first to last (included). This API will try a more efficient call to close_range(), or walk through of /proc/self/fd whenever these are possible, otherwise it falls back

Re: [PATCH v2 5/6] util/async-teardown: Use qemu_close_range() to close fds

2023-06-19 Thread Richard Henderson
On 6/16/23 17:27, Bin Meng wrote: +qemu_close_range(0, ~0U); This is clearly assuming that close_range exists. Should qemu_close_range attempt to lower last if >= _SC_OPEN_MAX? Or better to use that here. r~

Re: [PATCH v2 4/6] utils/osdep: Introduce qemu_close_range()

2023-06-19 Thread Richard Henderson
On 6/16/23 17:27, Bin Meng wrote: +int qemu_close_range(unsigned int first, unsigned int last) +{ +DIR *dir = NULL; + +#ifdef CONFIG_CLOSE_RANGE +int r = close_range(first, last, 0); +if (!r) { +/* Success, no need to try other ways. */ +return 0; +} +#endif What

Re: [PATCH v2 6/6] net: tap: Use qemu_close_range() to close fds

2023-06-19 Thread Richard Henderson
On 6/16/23 17:27, Bin Meng wrote: From: Zhangjin Wu Current codes using a brute-force traversal of all file descriptors do not scale on a system where the maximum number of file descriptors is set to a very large value (e.g.: in a Docker container of Manjaro distribution it is set to 1073741816)

Re: [PATCH v3 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large

2023-06-19 Thread Richard Henderson
On 6/17/23 07:36, Bin Meng wrote: Current codes using a brute-force traversal of all file descriptors do not scale on a system where the maximum number of file descriptors is set to a very large value (e.g.: in a Docker container of Manjaro distribution it is set to 1073741816). QEMU just looks f

Re: [PATCH v2 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-19 Thread Stefan Hajnoczi
On Fri, Jun 16, 2023 at 03:58:25PM +0900, Jeuk Kim wrote: > This commit makes the UFS device support query > and nop out transfer requests. > > The next patch would be support for UFS logical > unit and scsi command transfer request. > > Signed-off-by: Jeuk Kim > --- > hw/ufs/ufs.c | 968 ++

Re: [PATCH 1/7] target/i386: fix INVD vmexit

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: Due to a typo or perhaps a brain fart, the INVD vmexit was never generated. Fix it (but not that fixing just the typo would break both INVD and WBINVD, due to a case of two wrongs making a right). Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate

Re: [PATCH 2/7] target/i386: TCG supports 3DNow! prefetch(w)

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: The AMD prefetch(w) instructions have not been deprecated together with the rest of 3DNow!, and in fact are even supported by newer Intel processor. Mark them as supported by TCG, as it supports all of 3DNow!. Signed-off-by: Paolo Bonzini --- target/i386

Re: [PATCH 3/7] target/i386: TCG supports RDSEED

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: TCG implements RDSEED, and in fact uses qcrypto_random_bytes which is secure enough to match hardware behavior. Expose it to guests. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) TCG pro

Re: [PATCH 4/7] target/i386: TCG supports 32-bit SYSCALL

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: TCG supports both 32-bit and 64-bit SYSCALL, so expose it with "-cpu max" even for 32-bit emulators. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 6/7] target/i386: implement RDPID in TCG

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: RDPID corresponds to a RDMSR(TSC_AUX); however, it is unprivileged so for user-mode emulation we must provide the value that the kernel places in the MSR. For Linux, it is a combination of the current CPU and the current NUMA node, both of which can be retr

[PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' header

2023-06-19 Thread Philippe Mathieu-Daudé
hw/net/i82596.c access the global 'address_space_memory' calling the ld/st_phys() API. address_space_memory is declared in "exec/address-spaces.h". Currently this header is indirectly pulled in via another header. Explicitly include it to avoid when refactoring unrelated headers: hw/net/i82596.c

[PATCH 3/4] exec/address-spaces.h: Remove unuseful 'exec/memory.h' include

2023-06-19 Thread Philippe Mathieu-Daudé
"exec/address-spaces.h" declares get_system_io() and get_system_memory(), both returning a MemoryRegion pointer. MemoryRegion is forward declared in "qemu/typedefs.h", so we don't need any declaration from "exec/memory.h" here. Remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ad

[PATCH 2/4] hw/dma/etraxfs: Include missing 'exec/memory.h' header

2023-06-19 Thread Philippe Mathieu-Daudé
The 'fs_dma_ctrl' structure has a MemoryRegion 'mmio' field which is initialized in etraxfs_dmac_init() calling memory_region_init_io() and memory_region_add_subregion(). These functions are declared in "exec/memory.h", along with the MemoryRegion structure. Include the missing header. Signed-off

[PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header

2023-06-19 Thread Philippe Mathieu-Daudé
Commit 1e05888ab5 ("sysemu/kvm: Remove unused headers") was a bit overzealous while cleaning "sysemu/kvm.h" headers: kvm_arch_post_run() returns a MemTxAttrs type, so depends on "exec/memattrs.h" for its definition. Fixes: 1e05888ab5 ("sysemu/kvm: Remove unused headers") Signed-off-by: Philippe Ma

[PATCH 0/4] exec: Header cleanups around memory.h/address-spaces.h

2023-06-19 Thread Philippe Mathieu-Daudé
Trivial header cleanups extracted from bigger series. Sending separately since somehow unrelated to its goal. Philippe Mathieu-Daudé (4): hw/net/i82596: Include missing 'exec/address-spaces.h' header hw/dma/etraxfs: Include missing 'exec/memory.h' header exec/address-spaces.h: Remove unusefu

Re: [PATCH 5/7] target/i386: TCG supports XSAVEERPTR

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: XSAVEERPTR is actually a fix for an errata; TCG does not have the issue. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 7/7] target/i386: implement WBNOINVD in TCG

2023-06-19 Thread Richard Henderson
On 6/18/23 23:51, Paolo Bonzini wrote: WBNOINVD is the same as INVD or WBINVD as far as TCG is concerned, but it does not generate a vmexit if the processor supports it. If it does not, it is treated as WBINVD and generates a vmexit. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c

Re: [PATCH] vhost_net: add an assertion for TAP client backends

2023-06-19 Thread Laurent Vivier
On 6/19/23 06:15, Ani Sinha wrote: An assertion was missing for tap vhost backends that enforces a non-null reference from get_vhost_net(). Both vhost-net-user and vhost-net-vdpa enforces this. Enforce the same for tap. Unit tests pass with this change. Signed-off-by: Ani Sinha --- hw/net/vho

Re: [PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' header

2023-06-19 Thread Richard Henderson
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote: hw/net/i82596.c access the global 'address_space_memory' calling the ld/st_phys() API. address_space_memory is declared in "exec/address-spaces.h". Currently this header is indirectly pulled in via another header. Explicitly include it to avoid when

Re: [PATCH 2/4] hw/dma/etraxfs: Include missing 'exec/memory.h' header

2023-06-19 Thread Richard Henderson
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote: The 'fs_dma_ctrl' structure has a MemoryRegion 'mmio' field which is initialized in etraxfs_dmac_init() calling memory_region_init_io() and memory_region_add_subregion(). These functions are declared in "exec/memory.h", along with the MemoryRegion

Re: [PATCH 4/4] sysemu/kvm: Re-include "exec/memattrs.h" header

2023-06-19 Thread Richard Henderson
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote: Commit 1e05888ab5 ("sysemu/kvm: Remove unused headers") was a bit overzealous while cleaning "sysemu/kvm.h" headers: kvm_arch_post_run() returns a MemTxAttrs type, so depends on "exec/memattrs.h" for its definition. Fixes: 1e05888ab5 ("sysemu/kvm:

Re: [PATCH 3/4] exec/address-spaces.h: Remove unuseful 'exec/memory.h' include

2023-06-19 Thread Richard Henderson
On 6/19/23 09:41, Philippe Mathieu-Daudé wrote: "exec/address-spaces.h" declares get_system_io() and get_system_memory(), both returning a MemoryRegion pointer. MemoryRegion is forward declared in "qemu/typedefs.h", so we don't need any declaration from "exec/memory.h" here. Remove it. Signed-of

[PATCH] linux-user/riscv: Add syscall riscv_hwprobe

2023-06-19 Thread Robbin Ehn
This patch adds the new syscall for the "RISC-V Hardware Probing Interface" (https://docs.kernel.org/riscv/hwprobe.html). Reviewed-by: Palmer Dabbelt Signed-off-by: Robbin Ehn --- v1->v2: Moved to syscall.c v2->v3: Separate function, get/put user v3->patch --- linux-user/riscv/syscall32_nr.h |

[no subject]

2023-06-19 Thread Bilal Elmoussaoui
Expose the recently added multi touch support on the UI DBus backend Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

[PATCH v3 2/2] ui/dbus: Expose a touch device interface

2023-06-19 Thread Bilal Elmoussaoui
So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- ui/dbus-console.c| 59 +++- ui/dbus-display1.xml | 45

[no subject]

2023-06-19 Thread Bilal Elmoussaoui
Expose the recently added multi touch support on the UI DBus backend Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

[PATCH v3 1/2] ui/touch: Move event handling to a common helper

2023-06-19 Thread Bilal Elmoussaoui
To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- include/ui/console.h | 15 ++ ui/console.c | 65 ui/gtk.c | 61

Re: [PATCH v2 0/2] target/i386/kvm: fix two svm pmu virtualization bugs

2023-06-19 Thread Like Xu
I think we've been stuck here too long. Sorry Dongli. +zhenyu, could you get someone to follow up on this, or I will start working on that. On 9/1/2023 9:19 am, Dongli Zhang wrote: Ping? About [PATCH v2 2/2], the bad thing is that the customer will not be able to notice the issue, that is, t

[PATCH v2] vfio/migration: Refactor and fix print of "Migration disabled"

2023-06-19 Thread Zhenzhong Duan
This patch refactors vfio_migration_realize() and its dependend code as follows: 1. Change vfio_block_*_migration() to be only a checker. 2. It's redundant in vfio_migration_realize() to registers multiple blockers, refactor it to register one migration blocker per device. 3. Remove useless vfi

Re: [PATCH v2 11/18] target/riscv/cpu: add misa_ext_infos[]

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:50PM -0300, Daniel Henrique Barboza wrote: > Next patch will add KVM specific user properties for both MISA and > multi-letter extensions. For MISA extensions we want to make use of what > is already available in misa_ext_cfgs[] to avoid code repetition. > > The new m

Re: [PATCH v2 12/18] target/riscv: add KVM specific MISA properties

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:51PM -0300, Daniel Henrique Barboza wrote: > Using all TCG user properties in KVM is tricky. First because KVM > supports only a small subset of what TCG provides, so most of the > cpu->cfg flags do nothing for KVM. > > Second, and more important, we don't have a way

[PATCH v2 2/2] accel/tcg: Make probe_access() a generic TCG helper

2023-06-19 Thread Philippe Mathieu-Daudé
probe_access() is not ARM specific and can be reused by other targets. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/tcg-runtime.h| 2 ++ target/arm/helper.h| 2 -- accel/tcg/tcg-runtime.c| 16 target/arm/tcg/op_helper.c |

[PATCH v2 0/2] accel/tcg: Make probe_access() a generic TCG helper

2023-06-19 Thread Philippe Mathieu-Daudé
probe_access() is not ARM specific and can be reused by other targets, so make it a generic helper (after widening its address argument to 64-bits). Philippe Mathieu-Daudé (2): target/arm: Widen probe_access()'s address argument to 64-bits accel/tcg: Make probe_access() a generic TCG helper

[PATCH v2 1/2] target/arm: Widen probe_access()'s address argument to 64-bits

2023-06-19 Thread Philippe Mathieu-Daudé
Make probe_access() agnostic to the address size of the guest, using a uint64_t type since usage varies between guests. Since we don't access any CPUARMState particular env field, use the generic CPUArchState type insted. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.h| 2

Re: [PATCH v3 4/6] util/osdep: Introduce qemu_close_range()

2023-06-19 Thread Markus Armbruster
Bin Meng writes: > This introduces a new QEMU API qemu_close_range() that closes all > open file descriptors from first to last (included). > > This API will try a more efficient call to close_range(), or walk > through of /proc/self/fd whenever these are possible, otherwise it > falls back to a

Re: [PATCH v3 5/6] util/async-teardown: Use qemu_close_range() to close fds

2023-06-19 Thread Claudio Imbrenda
On Sat, 17 Jun 2023 13:36:20 +0800 Bin Meng wrote: > From: Zhangjin Wu > > Based on the old close_all_open_fd() of util/async-teardown.c, a new > generic qemu_close_range() has been added in osdep.c. > > Now, let's switch over to use the generic qemu_close_range(). > > Signed-off-by: Zhangjin

Re: [PATCH v3 6/6] net: tap: Use qemu_close_range() to close fds

2023-06-19 Thread Claudio Imbrenda
On Sat, 17 Jun 2023 13:36:21 +0800 Bin Meng wrote: > From: Zhangjin Wu > > Current codes using a brute-force traversal of all file descriptors > do not scale on a system where the maximum number of file descriptors > is set to a very large value (e.g.: in a Docker container of Manjaro > distrib

Re: [PATCH] hw/intc: If mmsiaddrcfgh.L == 1, smsiaddrcfg and smsiaddrcfgh are read-only.

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 05:12, Alistair Francis wrote: > > On Fri, Jun 9, 2023 at 4:01 PM Tommy Wu wrote: > > > > According to the `The RISC-V Advanced Interrupt Architecture` > > document, if register `mmsiaddrcfgh` of the domain has bit L set > > to one, then `smsiaddrcfg` and `smsiaddrcfgh` are

Re: [PATCH v3 3/6] util/async-teardown: Fall back to close fds one by one

2023-06-19 Thread Claudio Imbrenda
On Sat, 17 Jun 2023 13:36:18 +0800 Bin Meng wrote: > When opening /proc/self/fd fails, current codes just return directly, > but we can fall back to close fds one by one. > > Signed-off-by: Bin Meng > > --- > > (no changes since v2) > > Changes in v2: > - new patch: "util/async-teardown: Fal

Re: [PATCH v3 4/6] util/osdep: Introduce qemu_close_range()

2023-06-19 Thread Claudio Imbrenda
On Sat, 17 Jun 2023 13:36:19 +0800 Bin Meng wrote: > This introduces a new QEMU API qemu_close_range() that closes all > open file descriptors from first to last (included). > > This API will try a more efficient call to close_range(), or walk > through of /proc/self/fd whenever these are possib

Re: [PATCH v2 13/18] target/riscv/kvm.c: update KVM MISA bits

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:52PM -0300, Daniel Henrique Barboza wrote: > Our design philosophy with KVM properties can be resumed in two main > decisions based on KVM interface availability and what the user wants to > do: > > - if the user disables an extension that the host KVM module doesn't

Re: The real function of calling cpu_io_recompile in non-icount mode

2023-06-19 Thread Peter Maydell
On Sat, 17 Jun 2023 at 15:53, GanDalf LeBron wrote: > As said in the comment, instructions doing device I/Os must be at the end of > the TB in deterministic execution mode, icount mode or replay mode in other > words. > > But cpu_io_recompile is still got called when I disable icount opt. The >

Re: [PATCH v5 1/9] migration: Add switchover ack capability

2023-06-19 Thread Avihai Horon
On 15/06/2023 16:49, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 6/15/23 14:38, YangHang Liu wrote: Test in the following two scenarios: [1]  Test scenario:  Both source VM and target VM (in listening mode) have enabled return-path and switchover-ack

Re: [PATCH v2 14/18] target/riscv/kvm.c: add multi-letter extension KVM properties

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:53PM -0300, Daniel Henrique Barboza wrote: > Let's add KVM user properties for the multi-letter extensions that KVM > currently supports: zicbom, zicboz, zihintpause, zbb, ssaia, sstc, > svinval and svpbmt. > > As with MISA extensions, we're using the KVMCPUConfig typ

[PATCH v4 1/2] ui/touch: Move event handling to a common helper

2023-06-19 Thread Bilal Elmoussaoui
To share code between the GTK and DBus UI bakcends see the next commit for details Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau --- include/ui/console.h | 15 ++ ui/console.c | 65 ui/gtk.c | 61

Re: [PATCH v2 2/2] accel/tcg: Make probe_access() a generic TCG helper

2023-06-19 Thread Richard Henderson
On 6/19/23 11:19, Philippe Mathieu-Daudé wrote: + +void HELPER(probe_access)(CPUArchState *env, uint64_t ptr, + uint32_t access_type, uint32_t mmu_idx, + uint32_t size) +{ +uint32_t in_page = -((uint32_t)ptr | TARGET_PAGE_SIZE); +uintptr_t

[PATCH v4 2/2] ui/dbus: Expose a touch device interface

2023-06-19 Thread Bilal Elmoussaoui
So that clients making use of the DBus backend could send touch events through the new org.qemu.Display1.Touch interface Signed-off-by: Bilal Elmoussaoui Reviewed-by: Marc-André Lureau Signed-off-by: Bilal Elmoussaoui --- ui/dbus-console.c| 59 +++-

[PATCH v4 0/2] dbus/ui: Expose a multi touch interface

2023-06-19 Thread Bilal Elmoussaoui
*** Expose a multi touch device interface for the UI DBus backend *** Bilal Elmoussaoui (2): ui/touch: Move event handling to a common helper ui/dbus: Expose a touch device interface include/ui/console.h | 15 ++ ui/console.c | 65

Re: [PATCH v2 15/18] target/riscv: make riscv_isa_string_ext() KVM compatible

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:54PM -0300, Daniel Henrique Barboza wrote: > The isa_edata_arr[] is used by riscv_isa_string_ext() to create the > riscv,isa DT attribute. isa_edata_arr[] is kept in sync with the TCG > property vector riscv_cpu_extensions[], i.e. all TCG properties from > this vector

Re: [PATCH v2 17/18] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:56PM -0300, Daniel Henrique Barboza wrote: > There are 2 places in which we need to get a pointer to a certain > property of the cpu->cfg struct based on property offset. Next patch > will add a couple more. > > Create a helper to avoid repeating this code over and ov

Re: A confusion about CXL in arm virt machine

2023-06-19 Thread Jonathan Cameron via
On Fri, 16 Jun 2023 14:10:24 -0400 Gregory Price wrote: > On Fri, Jun 16, 2023 at 03:43:31PM +0800, Yuquan Wang wrote: > > Hi, Gregory > > > > There is one confusion about CXL in QEMU I hope to consult. > > If you have some time to look at this email, I would have better > > understanding of C

Re: [PATCH v2 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-06-19 Thread Jeuk Kim
On Fri, Jun 16, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:21PM +0900, Jeuk Kim wrote: >> Universal Flash Storage (UFS) is a high-performance mass storage device >> with a serial interface. It is primarily used as a high-performance >> data storage device for embedded applications.

Re: [PATCH v2 3/3] hw/ufs: Support for UFS logical unit

2023-06-19 Thread Stefan Hajnoczi
On Fri, Jun 16, 2023 at 03:58:27PM +0900, Jeuk Kim wrote: > This commit adds support for ufs logical unit. > The LU handles processing for the SCSI command, > unit descriptor query request. > > This commit enables the UFS device to process > IO requests. Is UFS a SCSI Host Bus Adapter capable of

Re: [RFC 2/4] qcow2: add configurations for zoned format extension

2023-06-19 Thread Stefan Hajnoczi
On Mon, Jun 05, 2023 at 06:41:06PM +0800, Sam Li wrote: > To configure the zoned format feature on the qcow2 driver, it > requires following arguments: the device size, zoned profile, > zoned model, zone size, zone capacity, number of conventional > zones, limits on zone resources (max append secto

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-19 Thread Peter Maydell
On Wed, 7 Jun 2023 at 08:25, Chen Baozi wrote: > > > > On Jun 7, 2023, at 10:33, Yuquan Wang wrote: > > > > The current sbsa-ref cannot use EHCI controller which is only > > able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. > > Hence, this uses system bus XHCI to provide a usb con

Re: [PATCH 1/1] hw/arm/Kconfig: sbsa-ref uses Bochs display

2023-06-19 Thread Peter Maydell
On Wed, 7 Jun 2023 at 10:21, Marcin Juszkiewicz wrote: > > Signed-off-by: Marcin Juszkiewicz > Reviewed-by: Thomas Huth > > --- > hw/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied to target-arm.next, thanks. -- PMM

Re: [RFC 2/4] qcow2: add configurations for zoned format extension

2023-06-19 Thread Sam Li
Stefan Hajnoczi 于2023年6月19日周一 18:10写道: > > On Mon, Jun 05, 2023 at 06:41:06PM +0800, Sam Li wrote: > > To configure the zoned format feature on the qcow2 driver, it > > requires following arguments: the device size, zoned profile, > > zoned model, zone size, zone capacity, number of conventional >

Re: [PATCH v3] imx_serial: set wake bit when we receive a data byte

2023-06-19 Thread Peter Maydell
On Thu, 15 Jun 2023 at 15:24, Martin Kaiser wrote: > > The Linux kernel added a flood check for RX data recently in commit > 496a4471b7c3 ("serial: imx: work-around for hardware RX flood"). This > check uses the wake bit in the UART status register 2. The wake bit > indicates that the receiver det

Re: [PATCH v2 02/38] util: Add cpuinfo-ppc.c

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: Move the code from tcg/. Fix a bug in that PPC_FEATURE2_ARCH_3_10 is actually spelled PPC_FEATURE2_ARCH_3_1. This is rather confusing. Signed-off-by: Richard Henderson --- host/include/ppc/host/cpuinfo.h | 29 host/include/ppc6

Re: [PATCH v2 07/38] target/i386: Use aesenc_SB_SR_AK

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This implements the AESENCLAST instruction. Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) void glue(helper_aesenclast, SUFFIX)(CPUX86State *env, Reg *d, Reg *v, Reg

Re: [PATCH v2 07/38] target/i386: Use aesenc_SB_SR_AK

2023-06-19 Thread Philippe Mathieu-Daudé
On 19/6/23 12:43, Philippe Mathieu-Daudé wrote: On 9/6/23 04:23, Richard Henderson wrote: This implements the AESENCLAST instruction. Signed-off-by: Richard Henderson ---   target/i386/ops_sse.h | 11 ++-   1 file changed, 6 insertions(+), 5 deletions(-)   void glue(helper_aesenclast

Re: [PATCH v2 10/38] target/ppc: Use aesenc_SB_SR_AK

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This implements the VCIPHERLAST instruction. Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 13/38] target/i386: Use aesdec_ISB_ISR_AK

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This implements the AESDECLAST instruction. Signed-off-by: Richard Henderson --- target/i386/ops_sse.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 15/38] target/ppc: Use aesdec_ISB_ISR_AK

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This implements the VNCIPHERLAST instruction. Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 1/8] target/arm: Add ID_AA64ISAR2_EL1

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 14:18, Aaron Lindsay wrote: > > On Jun 09 13:49, Richard Henderson wrote: > > On 6/9/23 10:23, Aaron Lindsay wrote: > > > --- a/target/arm/hvf/hvf.c > > > +++ b/target/arm/hvf/hvf.c > > > @@ -847,6 +847,7 @@ static bool > > > hvf_arm_get_host_cpu_features(ARMHostCPUFeatures

Re: Emulation of 'System OFF' mode in ARM nRF51 SoCs

2023-06-19 Thread Philippe Mathieu-Daudé
Hi Chris, On 14/6/23 04:27, Chris Laplante wrote: Hi all, I am working on improving nRF51 emulation. Specifically I want to implement the special "System OFF" mode. System OFF is a power saving mode. In this mode, the system can only be woken up by a reset or a handful of peripherals (most no

Re: [PATCH v2 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-19 Thread Jeuk Kim
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:25PM +0900, Jeuk Kim wrote: >> This commit makes the UFS device support query >> and nop out transfer requests. >> >> The next patch would be support for UFS logical >> unit and scsi command transfer request. >> >> Signed

Re: [PATCH v2] vfio/migration: Refactor and fix print of "Migration disabled"

2023-06-19 Thread Avihai Horon
Hi Zhenzhong, On 19/06/2023 11:44, Zhenzhong Duan wrote: External email: Use caution opening links or attachments This patch refactors vfio_migration_realize() and its dependend code as follows: 1. Change vfio_block_*_migration() to be only a checker. 2. It's redundant in vfio_migration_reali

Re: [PATCH v2 3/3] hw/ufs: Support for UFS logical unit

2023-06-19 Thread Jeuk Kim
On Fri, Jun 19, 2023, Stefan Hajnoczi wrote: >On Fri, Jun 16, 2023 at 03:58:27PM +0900, Jeuk Kim wrote: >> This commit adds support for ufs logical unit. >> The LU handles processing for the SCSI command, >> unit descriptor query request. >> >> This commit enables the UFS device to process >> IO r

Re: [PATCH v2] hw/pci: prevent hotplug of devices on pcie-root-ports on the wrong slot

2023-06-19 Thread Ani Sinha
> On 15-Jun-2023, at 4:56 PM, Igor Mammedov wrote: > > On Thu, 15 Jun 2023 10:46:45 +0530 > Ani Sinha wrote: > >> PCIE root ports and other upstream ports only allow one device on slot 0. >> When hotplugging a device on a pcie root port, make sure that the device >> address passed always rep

Re: Emulation of 'System OFF' mode in ARM nRF51 SoCs

2023-06-19 Thread Peter Maydell
On Wed, 14 Jun 2023 at 14:02, Chris Laplante wrote: > > Hi all, > > I am working on improving nRF51 emulation. Specifically I want to implement > the special "System OFF" mode. System OFF is a power saving mode. In this > mode, the system can only be woken up by a reset or a handful of periphera

Re: [PATCH] accel/kvm/kvm-all: Handle register access errors

2023-06-19 Thread Peter Maydell
On Sat, 10 Jun 2023 at 04:51, Akihiko Odaki wrote: > > On 2022/12/01 20:00, Akihiko Odaki wrote: > > On 2022/12/01 19:40, Peter Maydell wrote: > >> On Thu, 1 Dec 2022 at 10:27, Akihiko Odaki > >> wrote: > >>> > >>> A register access error typically means something seriously wrong > >>> happened s

Re: [PATCH v3 07/23] q800: move GLUE device into separate q800-glue.c file

2023-06-19 Thread Mark Cave-Ayland
On 05/06/2023 13:41, Philippe Mathieu-Daudé wrote: On 4/6/23 15:14, Mark Cave-Ayland wrote: This will allow the q800-glue.h header to be included separately so that the GLUE device can be referenced externally. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier ---   MAINTAINERS

Re: [PATCH v2 05/23] q800: move CPU object into Q800MachineState

2023-06-19 Thread Mark Cave-Ayland
On 13/06/2023 12:50, Markus Armbruster wrote: Mark Cave-Ayland writes: On 01/06/2023 10:00, Markus Armbruster wrote: Mark Cave-Ayland writes: On 31/05/2023 16:00, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 31/5/23 14:53, Mark Cave-Ayland wrote: Also change the insta

[PATCH v2] hw: Fix format for comments

2023-06-19 Thread Shaoqin Huang
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie at it, reorder the parameters in comments to match the sequence of parameters which defined in the CPUArchId. Reviewed-by: Igor Mammedov Signed-off-by: Shaoqin Huang --- include/hw/boards.h | 4 ++-- 1 file changed, 2 inse

Re: [PATCH v2 18/18] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM

2023-06-19 Thread Andrew Jones
On Tue, Jun 13, 2023 at 05:58:57PM -0300, Daniel Henrique Barboza wrote: > If we don't set a proper cbom_blocksize|cboz_blocksize in the FDT the > Linux Kernel will fail to detect the availability of the CBOM/CBOZ > extensions, regardless of the contents of the 'riscv,isa' DT prop. > > The FDT is

Re: [PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

2023-06-19 Thread Gerd Hoffmann
On Thu, Jun 08, 2023 at 01:49:27PM -0700, Mike Kravetz wrote: > This effectively reverts commit 16c243e99d33 ("udmabuf: Add support > for mapping hugepages (v4)"). Recently, Junxiao Chang found a BUG > with page map counting as described here [1]. This issue pointed out > that the udmabuf driver

Re: [PATCH 1/1] docs: sbsa: document board to firmware interface

2023-06-19 Thread Peter Maydell
On Wed, 31 May 2023 at 18:18, Marcin Juszkiewicz wrote: > > We plan to add more hardware information into DeviceTree to limit amount > of hardcoded values in firmware. > > Signed-off-by: Marcin Juszkiewicz I'm going to apply this to target-arm.next with this squashed in to fix a few grammar/form

Re: [PATCH v2 12/12] target/arm: Allow users to set the number of VFP registers

2023-06-19 Thread Mads Ynddal
Sorry, if this has already been acknowledged, but I couldn't find it on the mailinglist. This commit seems to break compatibility with macOS accelerator hvf when virtualizing ARM CPUs. It breaks the VM on boot-up with the message "ARM CPUs must have both VFP-D32 and Neon or neither". I haven't lo

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-19 Thread Peter Maydell
On Wed, 7 Jun 2023 at 03:34, Yuquan Wang wrote: > > The current sbsa-ref cannot use EHCI controller which is only > able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. > Hence, this uses system bus XHCI to provide a usb controller with > 64-bit DMA capablity instead of EHCI. "capabi

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-19 Thread Gerd Hoffmann
Hi, > Adding a new command requires new feature flag (and maybe it should be in > the <0x1000 range instead) > > But I am not sure we need a new message at the virtio-gpu level. Gerd, wdyt? > > Maybe it's not a good place to reset all GPU resources during QEMU reset() > after all, if it's call

Re: [PATCH 1/1] docs: sbsa: document board to firmware interface

2023-06-19 Thread Marcin Juszkiewicz
W dniu 19.06.2023 o 14:41, Peter Maydell pisze: I'm going to apply this to target-arm.next with this squashed in to fix a few grammar/format nits and add some text from the comment in the source file about the platform version part. Thanks. My English grammar sucks so I am glad that you looked

Re: [PATCH 1/2] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2023-06-19 Thread Peter Maydell
On Tue, 6 Jun 2023 at 19:24, Marcin Juszkiewicz wrote: > > From: Shashi Mallela > > Included creation of ITS as part of SBSA platform GIC > initialization. > > Signed-off-by: Shashi Mallela Marcin, this should have your signed-off-by too because the patch came to us via you. > +static void cre

Re: [PATCH 2/2] hw/arm/sbsa-ref: add GIC ITS to DeviceTree

2023-06-19 Thread Peter Maydell
On Tue, 6 Jun 2023 at 19:24, Marcin Juszkiewicz wrote: > > We need GIC ITS information in DeviceTree so TF-A can pass it to EDK2. > > Bumping platform version to 0.2 as this is important hardware change. > > Signed-off-by: Marcin Juszkiewicz > > --- > hw/arm/sbsa-ref.c | 9 - > 1 file ch

[PATCH qemu] gdbstub: Fixed gdb_open() does not work issue while an extra 'x' is being added when converting '%s' to a pointer

2023-06-19 Thread ~foxes
From: Foxes Hung Signed-off-by: Foxes Hung --- gdbstub/syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c index 02e3a8f74c..4c6b5f728b 100644 --- a/gdbstub/syscalls.c +++ b/gdbstub/syscalls.c @@ -126,7 +126,7 @@ void gdb_do_sys

Re: [PATCH v3] imx_serial: set wake bit when we receive a data byte

2023-06-19 Thread Philippe Mathieu-Daudé
On 19/6/23 12:36, Peter Maydell wrote: On Thu, 15 Jun 2023 at 15:24, Martin Kaiser wrote: The Linux kernel added a flood check for RX data recently in commit 496a4471b7c3 ("serial: imx: work-around for hardware RX flood"). This check uses the wake bit in the UART status register 2. The wake bi

Re: [PATCH v2 12/12] target/arm: Allow users to set the number of VFP registers

2023-06-19 Thread Cédric Le Goater
On 6/19/23 14:47, Mads Ynddal wrote: Sorry, if this has already been acknowledged, but I couldn't find it on the mailinglist. This commit seems to break compatibility with macOS accelerator hvf when virtualizing ARM CPUs. It breaks the VM on boot-up with the message "ARM CPUs must have both VFP

Re: [PATCH v2 35/38] crypto: Unexport AES_*_rot, AES_TeN, AES_TdN

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: These arrays are no longer used outside of aes.c. Signed-off-by: Richard Henderson --- include/crypto/aes.h | 25 - crypto/aes.c | 33 + 2 files changed, 21 insertions(+), 37 deletions(

Re: [PATCH v2 34/38] crypto: Remove AES_imc

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This array is no longer used. Signed-off-by: Richard Henderson --- include/crypto/aes.h | 7 -- crypto/aes.c | 264 --- 2 files changed, 271 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH] accel/tcg: Handle MO_ATOM_WITHIN16 in do_st16_leN

2023-06-19 Thread Richard Henderson
Otherwise we hit the default assert not reached. Handle it as MO_ATOM_NONE, because of size and misalignment. We already handle this correctly in do_ld16_beN. Signed-off-by: Richard Henderson --- Fixes an abort booting debian11 with -cpu max. r~ --- accel/tcg/cputlb.c | 1 + 1 file changed, 1

Re: [PATCH qemu v2 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 10:40, ~jhogberg wrote: > > From: John Högberg > > https://gitlab.com/qemu-project/qemu/-/issues/1034 > > Signed-off-by: John Högberg > diff --git a/tests/tcg/aarch64/icivau.c b/tests/tcg/aarch64/icivau.c > new file mode 100644 > index 00..ff80d3d868 > --- /dev/nu

Re: [PATCH 2/2] hw/arm/sbsa-ref: add GIC ITS to DeviceTree

2023-06-19 Thread Marcin Juszkiewicz
W dniu 19.06.2023 o 14:55, Peter Maydell pisze: On Tue, 6 Jun 2023 at 19:24, Marcin Juszkiewicz wrote: We need GIC ITS information in DeviceTree so TF-A can pass it to EDK2. Bumping platform version to 0.2 as this is important hardware change. We should fold this patch into the previous o

Re: [RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 23:35, Philippe Mathieu-Daudé wrote: > > From: Sergey Kambalin > > Signed-off-by: Sergey Kambalin > Message-Id: <20230531155258.8361-1-sergey.kamba...@auriga.com> > [PMD: Split from bigger patch: 3/4] > Signed-off-by: Philippe Mathieu-Daudé > --- > TOCHECK: seems raspi3-s

Re: [PATCH v3 0/4] hw/arm/raspi: Use named constants in BCM props

2023-06-19 Thread Peter Maydell
On Mon, 12 Jun 2023 at 23:34, Philippe Mathieu-Daudé wrote: > > v2: > https://lore.kernel.org/qemu-devel/20230612115950.5002-1-sergey.kamba...@auriga.com/ > > This is a respin of Sergey's patch but > - split in multiple patches > - removing redundant comments Applied to target-arm.next (with the

Re: [PATCH v2 12/12] target/arm: Allow users to set the number of VFP registers

2023-06-19 Thread Peter Maydell
On Mon, 19 Jun 2023 at 13:47, Mads Ynddal wrote: > > Sorry, if this has already been acknowledged, but I couldn't find it on the > mailinglist. > > This commit seems to break compatibility with macOS accelerator hvf when > virtualizing ARM CPUs. > > It breaks the VM on boot-up with the message "AR

Re: [PATCH] accel/tcg: Handle MO_ATOM_WITHIN16 in do_st16_leN

2023-06-19 Thread Peter Maydell
On Mon, 19 Jun 2023 at 14:26, Richard Henderson wrote: > > Otherwise we hit the default assert not reached. > Handle it as MO_ATOM_NONE, because of size and misalignment. > We already handle this correctly in do_ld16_beN. > > Signed-off-by: Richard Henderson > --- > > Fixes an abort booting debia

Re: [PATCH v2 32/38] crypto: Remove AES_shifts, AES_ishifts

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: These arrays are no longer used, replaced by AES_SH_*, AES_ISH_*. Signed-off-by: Richard Henderson --- include/crypto/aes.h | 4 crypto/aes.c | 14 -- 2 files changed, 18 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 31/38] target/ppc: Use aesdec_ISB_ISR_AK_IMC

2023-06-19 Thread Philippe Mathieu-Daudé
On 9/6/23 04:23, Richard Henderson wrote: This implements the VNCIPHER instruction. Signed-off-by: Richard Henderson --- target/ppc/int_helper.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

  1   2   3   >