[PATCH v4 15/16] accel/tcg: Add aarch64 lse2 load_atom_extract_al16_or_al8

2023-05-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- .../aarch64/host/load-extract-al16-al8.h | 40 +++ 1 file changed, 40 insertions(+) create mode 100644 host/include/aarch64/host/load-extract-al16-al8.h diff --git a/host/include/aarch64/host/load-extract-al16-al8.h b/host/include/aarch

[PATCH v4 07/16] tcg/aarch64: Reserve TCG_REG_TMP1, TCG_REG_TMP2

2023-05-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index 8996e29ca9..5e7ac6fb76 100644 --- a/tcg/aarch64/tcg-target.c.inc +++ b/tcg/aarch64/tcg-t

[PATCH v4 09/16] tcg/aarch64: Support 128-bit load/store

2023-05-25 Thread Richard Henderson
With FEAT_LSE2, LDP/STP suffices. Without FEAT_LSE2, use LDXP+STXP 16-byte atomicity is required and LDP/STP otherwise. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target-con-set.h | 2 + tcg/aarch64/tcg-target.h | 11 ++- tcg/aarch64/tcg-target.c

[PATCH v4 10/16] tcg/ppc: Support 128-bit load/store

2023-05-25 Thread Richard Henderson
Use LQ/STQ with ISA v2.07, and 16-byte atomicity is required. Note that these instructions do not require 16-byte alignment. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target-con-set.h | 2 + tcg/ppc/tcg-target-con-str.h | 1 + tcg/ppc/tcg-target.h

Re: [PATCH v5 1/3] target/riscv: smstateen check for fcsr

2023-05-25 Thread Alistair Francis
On Fri, May 19, 2023 at 3:51 AM Mayuresh Chitale wrote: > > Implement the s/h/mstateen.fcsr bit as defined in the smstateen spec > and check for it when accessing the fcsr register and its fields. > > Signed-off-by: Mayuresh Chitale > Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis Alist

Re: [PATCH v5 2/3] target/riscv: Reuse tb->flags.FS

2023-05-25 Thread Alistair Francis
On Fri, May 19, 2023 at 3:51 AM Mayuresh Chitale wrote: > > When misa.F is 0 tb->flags.FS field is unused and can be used to save > the current state of smstateen0.FCSR check which is needed by the > floating point translation routines. > > Signed-off-by: Mayuresh Chitale > Reviewed-by: Richard H

Re: [PATCH v5 0/3] Smstateen FCSR

2023-05-25 Thread Alistair Francis
On Fri, May 19, 2023 at 3:51 AM Mayuresh Chitale wrote: > > Patch 4 and 5 of the smstateen series need to be re-submitted with > changes described in the email below. > https://lists.nongnu.org/archive/html/qemu-riscv/2022-11/msg00155.html > Hence splitting the patch 4 of the original series into

Re: [PATCH v2 2/8] target/riscv: Split RISCVCPUConfig declarations from cpu.h into cpu_cfg.h

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Split RISCVCPUConfig declarations to prepare for passing it to disas. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 114 +---

Re: [PATCH v2 1/8] disas: Change type of disassemble_info.target_info to pointer

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Use pointer to pass more information of target to disasembler, > such as pass cpu.cfg related information in following commits. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Reviewed-by: A

Re: [PATCH v2 3/8] target/riscv: Pass RISCVCPUConfig as target_info to disassemble_info

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Pass RISCVCPUConfig as disassemble_info.target_info to support disas > of conflict instructions related to specific extensions. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Reviewed-by: A

Re: [PATCH v2 4/8] disas/riscv.c: Support disas for Zcm* extensions

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:37 PM Weiwei Li wrote: > > Support disas for Zcmt* instructions only when related extensions > are supported. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Alistair > --- > disas/ri

Re: [PATCH v2 5/8] disas/riscv.c: Support disas for Z*inx extensions

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:37 PM Weiwei Li wrote: > > Support disas for Z*inx instructions only when Zfinx extension is supported. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Alistair > --- > disas/riscv.c

Re: [PATCH v2 7/8] disas/riscv.c: Fix lines with over 80 characters

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:37 PM Weiwei Li wrote: > > Fix lines with over 80 characters. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Alistair > --- > disas/riscv.c | 201 +++

Re: [PATCH v2 6/8] disas/riscv.c: Remove unused decomp_rv32/64 value for vector instructions

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Currently decomp_rv32 and decomp_rv64 value in opcode_data for vector > instructions are the same op index as their own. And they have no > functional decomp_data. So they have no functional difference from just > leaving them as zero. > > Signe

Re: [PATCH v2 8/8] disas/riscv.c: Remove redundant parentheses

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Remove redundant parenthese and fix multi-line comments. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Alistair > --- > disas/riscv.c | 219 +

Re: [PATCH v3 2/3] vhost: register and change IOMMU flag depending on Device-TLB state

2023-05-25 Thread Jason Wang
On Thu, May 25, 2023 at 8:55 PM Viktor Prutyanov wrote: > > On Wed, May 24, 2023 at 11:25 AM Jason Wang wrote: > > > > On Sat, May 20, 2023 at 1:50 AM Viktor Prutyanov wrote: > > > > > > On Thu, May 18, 2023 at 9:14 AM Jason Wang wrote: > > > > > > > > On Fri, May 12, 2023 at 9:51 PM Viktor Pru

Re: [PATCH v2 0/8] Add support for extension specific disas

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 7:38 PM Weiwei Li wrote: > > Some extensions have conflict encodings, such as > * Z*inx reuse the same encodings as normal float point extensions. > * Zcm* reuse the some encodings of Zcd. > * Custom extensions from different vendors may share the same encodings. > To re

Re: [PATCH v2 2/7] target/riscv: Introduce cur_insn_len into DisasContext

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:16 AM Weiwei Li wrote: > > Use cur_insn_len to store the length of the current instruction to > prepare for PC-relative translation. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c

Re: [PATCH v2 3/7] target/riscv: Change gen_goto_tb to work on displacements

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:14 AM Weiwei Li wrote: > > Reduce reliance on absolute value to prepare for PC-relative translation. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn_trans/trans_rvi.c.inc | 4 ++-- > targ

[PATCH v2 2/4] decodetree: Fix recursion in prop_format and build_tree

2023-05-25 Thread Richard Henderson
Two copy-paste errors walking the parse tree. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 3f9f6876f7..e2640cc79b 100644 --- a/scripts/decodetree.py +++ b/scr

[PATCH v2 3/4] decodetree: Diagnose empty pattern group

2023-05-25 Thread Richard Henderson
Test err_pattern_group_empty.decode failed with exception: Traceback (most recent call last): File "./scripts/decodetree.py", line 1424, in main() File "./scripts/decodetree.py", line 1342, in main toppat.build_tree() File "./scripts/decodetree.py", line 627, in build_tree self.tree = s

[PATCH v2 4/4] tests/decode: Convert tests to meson

2023-05-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/decode/check.sh| 24 tests/decode/meson.build | 59 tests/meson.build| 5 +--- 3 files changed, 60 insertions(+), 28 deletions(-) delete mode 100755 tests/decode/check.sh create mod

[PATCH v2 0/4] tests/decode: Convert tests to meson

2023-05-25 Thread Richard Henderson
Add --test-for-error to decodetree.py and convert the tests to meson. This exposes an exception error that had been hidden by the fact that the script as a whole did exit with error. Which proves that this is a better way to run the tests. r~ Richard Henderson (4): decodetree: Add --test-for

[PATCH v2 1/4] decodetree: Add --test-for-error

2023-05-25 Thread Richard Henderson
Invert the exit code, for use with the testsuite. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index a03dc6b5e3..3f9f6876f7 100644 --- a/scripts/decodetree.py

Re: [PATCH v2 4/7] target/riscv: Change gen_set_pc_imm to gen_update_pc

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:08 AM Weiwei Li wrote: > > Reduce reliance on absolute values(by passing pc difference) to > prepare for PC-relative translation. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn_trans/tra

Re: [PATCH v2 5/7] target/riscv: Use true diff for gen_pc_plus_diff

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:14 AM Weiwei Li wrote: > > Reduce reliance on absolute values by using true pc difference for > gen_pc_plus_diff() to prepare for PC-relative translation. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > ta

Re: [PATCH v2 6/7] target/riscv: Enable PC-relative translation

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:12 AM Weiwei Li wrote: > > Add a base pc_save for PC-relative translation(CF_PCREL). > Diable the directly sync pc from tb by riscv_cpu_synchronize_from_tb. > Use gen_pc_plus_diff to get the pc-relative address. > Enable CF_PCREL in System mode. > > Signed-off-by: Weiwei

Re: [PATCH v2 7/7] target/riscv: Remove pc_succ_insn from DisasContext

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:07 AM Weiwei Li wrote: > > pc_succ_insn is no longer useful after the introduce of cur_insn_len > and all pc related value use diff value instead of absolute value. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair >

Re: [PATCH 2/2] docs/clx: Change to lowercase as others

2023-05-25 Thread Zhijian Li (Fujitsu)
On 25/05/2023 19:49, Jonathan Cameron via wrote: > On Fri, 19 May 2023 16:58:02 +0800 > Li Zhijian wrote: > >> Using the same style except the 'Topo' abbreviation. >> >> Signed-off-by: Li Zhijian >> --- >> I'm not a native speaker, feel free to correct me. > > I've edited slightly and applied

Re: Re: [PATCH] linux-user/i386: Properly align signal frame

2023-05-25 Thread fanwj--- via
"The beginning of the structure, with pretaddr, should be just below 16-byte alignment." It is incorrect! The beginning of the structure, with pretaddr not aligned as 16-byte! On x86-64, It aligned as (16n - sizeof(void*)) because of instruction "call" ! > -原始邮件- > 发件人: "Richard He

Re: [PATCH v3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none"

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 8:29 PM Sunil V L wrote: > > Currently, virt machine supports two pflash instances each with > 32MB size. However, the first pflash is always assumed to > contain M-mode firmware and reset vector is set to this if > enabled. Hence, for S-mode payloads like EDK2, only one pf

Re: [PATCH] cryptodev: Handle unexpected request to avoid crash

2023-05-25 Thread Lei He
> On Apr 27, 2023, at 16:05, zhenwei pi wrote: > > Generally guest side should discover which services the device is > able to offer, then do requests on device. > > However it's also possible to break this rule in a guest. Handle > unexpected request here to avoid NULL pointer dereference. >

Re: [PATCH v2 0/7] target/riscv: Add support for PC-relative translation

2023-05-25 Thread Alistair Francis
On Wed, May 24, 2023 at 12:15 AM Weiwei Li wrote: > > This patchset tries to add support for PC-relative translation. > > The existence of CF_PCREL can improve performance with the guest > kernel's address space randomization. Each guest process maps libc.so > (et al) at a different virtual addre

Re: [PATCH v4 1/2] vhost: register and change IOMMU flag depending on Device-TLB state

2023-05-25 Thread Jason Wang
On Thu, May 25, 2023 at 8:58 PM Viktor Prutyanov wrote: > > The guest can disable or never enable Device-TLB. In these cases, > it can't be used even if enabled in QEMU. So, check Device-TLB state > before registering IOMMU notifier and select unmap flag depending on > that. Also, implement a way

Re: [PATCH v4 2/2] virtio-net: pass Device-TLB enable/disable events to vhost

2023-05-25 Thread Jason Wang
On Thu, May 25, 2023 at 8:58 PM Viktor Prutyanov wrote: > > If vhost is enabled for virtio-net, Device-TLB enable/disable events > must be passed to vhost for proper IOMMU unmap flag selection. > > Signed-off-by: Viktor Prutyanov Acked-by: Jason Wang Thanks > --- > hw/net/virtio-net.c | 1 +

Re: [PATCH v3 2/5] vdpa: add vhost_vdpa_reset_status_fd

2023-05-25 Thread Jason Wang
On Thu, May 25, 2023 at 1:37 AM Eugenio Perez Martin wrote: > > On Wed, May 17, 2023 at 7:49 AM Jason Wang wrote: > > > > On Wed, May 17, 2023 at 1:46 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, May 17, 2023 at 5:14 AM Jason Wang wrote: > > > > > > > > On Tue, May 9, 2023 at 11:44 PM

[PATCH 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-05-25 Thread Jeuk Kim
This patch series adds support for a new PCI-based UFS device. The UFS pci device id (PCI_DEVICE_ID_REDHAT_UFS) is not registered in the Linux kernel yet, so it does not work right away, but I confirmed that it works with Linux when the UFS pci device id is registered. I have also verified that i

[PATCH 2/3] hw/ufs: Support for Query Transfer Requests

2023-05-25 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 967 ++- hw/ufs/ufs.h | 45 +++ 2 fil

[PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-25 Thread Jeuk Kim
Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches to handle UFS logical un

[PATCH 3/3] hw/ufs: Support for UFS logical unit

2023-05-25 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441 ++ hw/ufs/mes

Re: [PATCH v2 3/3] cpu, qdict, vl: Enable printing options for CPU type

2023-05-25 Thread Markus Armbruster
This is really, really, *really* for maintainers of the code parsing -cpu to review. Code parsing -cpu: * parse_cpu_option() in cpu.c Eduardo Habkost (supporter:Machine core) Marcel Apfelbaum (supporter:Machine core) "Philippe Mathieu-Daudé" (reviewer:Machine core) Yanan Wang (review

Re: [PATCH v3 1/1] hw/arm/aspeed:Add vpd data for Rainier machine

2023-05-25 Thread Cédric Le Goater
On 5/25/23 21:57, Ninad Palsule wrote: Hello Cedric, On 5/25/23 1:37 AM, Cédric Le Goater wrote: [ ... ] However, regarding Cédric's log above, a reboot is expected on the first boot of a fresh image when there's valid VPD available. For the first boot of a fresh image we configure the kerne

[PATCH v2 0/6] TriCore PCXI/ICR register fixes

2023-05-25 Thread Bastian Koppelmann
Hi, the main motivator for this series was https://gitlab.com/qemu-project/qemu/-/issues/1453. To test that I'm not screwing up this refactor I also extended the tests by C programs so we can test the PCXI/ICR registers by recursive function call. Through these tests I also found a problem, where

[PATCH v2 1/6] tests/tcg/tricore: Move asm tests into 'asm' directory

2023-05-25 Thread Bastian Koppelmann
this seperates these tests from the upcoming tests written in C. Also rename the compiled test to 'test_.asm.tst'. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile.softmmu-target | 35 --- tests/tcg/tricore/{ => asm}/macros.h | 0 tests/tcg/tricore/{ =>

[PATCH v2 2/6] tests/tcg/tricore: Uses label for memory addresses

2023-05-25 Thread Bastian Koppelmann
the linker might rearrange sections, so lets reference memory by label name instead of addr + off. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 1 - tests/tcg/tricore/asm/test_ld_bu.S | 4 ++-- tests/tcg/tricore/asm/test_ld_h.S | 8 3 files changed, 6 inse

[PATCH v2 3/6] tests/tcg/tricore: Add first C program

2023-05-25 Thread Bastian Koppelmann
this allows us to exercise the startup code used by GCC to call main(). Signed-off-by: Bastian Koppelmann --- configure | 1 + tests/tcg/tricore/Makefile.softmmu-target | 13 + tests/tcg/tricore/c/crt0-tc2x.S | 335 ++ tests/tcg/tr

[PATCH v2 6/6] tests/tcg/tricore: Add recursion test for CSAs

2023-05-25 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile.softmmu-target | 3 ++- tests/tcg/tricore/c/test_context_save_areas.c | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/tricore/c/test_context_save_areas.c diff --git a/tests/

[PATCH v2 4/6] target/tricore: Refactor PCXI/ICR register fields

2023-05-25 Thread Bastian Koppelmann
starting from ISA version 1.6.1 (previously known as 1.6P/E), some bitfields in PCXI and ICR have changed. We also refactor these registers using the register fields API. Signed-off-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1453 --- v1 -> v2: - Created ice

[PATCH v2 5/6] target/tricore: Fix wrong PSW for call insns

2023-05-25 Thread Bastian Koppelmann
we were copying PSW into a local variable, updated PSW.CDE in the local and never wrote it back. So when we called save_context_upper() we were using the non-local version of PSW which did not contain the updated PSW.CDE. Signed-off-by: Bastian Koppelmann --- target/tricore/op_helper.c | 2 ++ 1

RE: [PATCH] intel_iommu: Optimize out some unnecessary UNMAP calls

2023-05-25 Thread Duan, Zhenzhong
>-Original Message- >From: Peter Xu >Sent: Thursday, May 25, 2023 9:54 PM >Subject: Re: [PATCH] intel_iommu: Optimize out some unnecessary UNMAP >calls > >On Thu, May 25, 2023 at 11:29:34AM +, Duan, Zhenzhong wrote: >> Hi Peter, >> >> See inline. >> >-Original Message- >> >Fro

[PATCH v3 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support placeholder

2023-05-25 Thread Yong-Xuan Wang
Sync-up Linux header to get latest KVM RISC-V headers having AIA support. Note: This is a placeholder commit and could be replaced when all referenced Linux patchsets are mainlined. The linux-headers changes are from 2 different patchsets. [1] https://lore.kernel.org/lkml/20230404153452.2405681

[PATCH v3 5/6] target/riscv: update APLIC and IMSIC to support KVM AIA

2023-05-25 Thread Yong-Xuan Wang
- Do not set the mmio operations of APLIC and IMSIC when using KVM AIA - Send interrupt signal to KVM AIA via KVM_IRQ_LINE API Signed-off-by: Yong-Xuan Wang Reviewed-by: Jim Shu --- hw/intc/riscv_aplic.c | 19 +++ hw/intc/riscv_imsic.c | 16 +++- 2 files changed, 26

[PATCH v3 0/6] Add RISC-V KVM AIA Support

2023-05-25 Thread Yong-Xuan Wang
This series adds support for KVM AIA in RISC-V architecture. In order to test these patches, we require Linux with KVM AIA support which can be found in the qemu_kvm_aia branch at https://github.com/yong-xuan/linux.git This kernel branch is based on the riscv_aia_v1 branch available at https://git

[PATCH v3 6/6] target/riscv: select KVM AIA in riscv virt machine

2023-05-25 Thread Yong-Xuan Wang
Select KVM AIA when the host kernel has in-kernel AIA chip support. Signed-off-by: Yong-Xuan Wang Reviewed-by: Jim Shu --- hw/riscv/virt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 18b94888ab..57a07fa6c5 100644 --- a/hw/riscv/virt.c

[PATCH v3 2/6] target/riscv: support the AIA device emulation with KVM enabled

2023-05-25 Thread Yong-Xuan Wang
Remove M mode AIA devices when using KVM acceleration Signed-off-by: Yong-Xuan Wang Reviewed-by: Jim Shu --- hw/riscv/virt.c | 199 +--- 1 file changed, 105 insertions(+), 94 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4e3efbee1

[PATCH v3 3/6] target/riscv: check the in-kernel irqchip support

2023-05-25 Thread Yong-Xuan Wang
We check the in-kernel irqchip support when using KVM acceleration. Signed-off-by: Yong-Xuan Wang Reviewed-by: Jim Shu --- target/riscv/kvm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 0f932a5b96..eb469e8ca5 10

[PATCH v3 4/6] target/riscv: Create an KVM AIA irqchip

2023-05-25 Thread Yong-Xuan Wang
implement a function to create an KVM AIA chip Signed-off-by: Yong-Xuan Wang Reviewed-by: Jim Shu --- target/riscv/kvm.c | 83 target/riscv/kvm_riscv.h | 3 ++ 2 files changed, 86 insertions(+) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c

Re: [PATCH] intel_iommu: Optimize out some unnecessary UNMAP calls

2023-05-25 Thread Jason Wang
On Fri, May 26, 2023 at 2:22 PM Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Peter Xu > >Sent: Thursday, May 25, 2023 9:54 PM > >Subject: Re: [PATCH] intel_iommu: Optimize out some unnecessary UNMAP > >calls > > > >On Thu, May 25, 2023 at 11:29:34AM +, Duan, Zhenzhong wro

Re: [PATCH 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-05-25 Thread Thomas Huth
On 26/05/2023 07.05, Jeuk Kim wrote: Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI d

Re: [PATCH v4 0/3] hw/riscv/virt: pflash improvements

2023-05-25 Thread Andrew Jones
On Thu, May 25, 2023 at 11:03:52AM -0700, Andrea Bolognani wrote: > On Thu, May 25, 2023 at 10:18:00PM +0530, Sunil V L wrote: > > This series improves the pflash usage in RISC-V virt machine with solutions > > to > > below issues. > > > > 1) Currently the first pflash is reserved for ROM/M-mode f

Re: [PATCH v3] hw/riscv: virt: Assume M-mode FW in pflash0 only when "-bios none"

2023-05-25 Thread Alistair Francis
On Tue, May 23, 2023 at 8:29 PM Sunil V L wrote: > > Currently, virt machine supports two pflash instances each with > 32MB size. However, the first pflash is always assumed to > contain M-mode firmware and reset vector is set to this if > enabled. Hence, for S-mode payloads like EDK2, only one pf

Re: [PATCH] vhost: release memory objects in error path

2023-05-25 Thread Prasad Pandit
Hello Peter, all On Thu, 25 May 2023 at 18:33, Peter Xu wrote: > IIRC this bug used to only reproduce on rt kernels, is it still the case? > * Yes, it's a same crash. > Here besides doing correct unregister, does it also mean that even if > event_notifier_init() failed there's totally no erro

<    1   2   3   4