Re: [PATCH 03/11] hw/scsi: Rearrange meson.build

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: We will modify this file shortly. Re-arrange it slightly first, declaring source sets first. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/meson.build | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

Re: [PATCH 05/11] hw/virtio: Introduce VHOST_VSOCK_COMMON symbol in Kconfig

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: Instead of adding 'vhost-vsock-common.c' twice (for VHOST_VSOCK and VHOST_USER_VSOCK), have it depend on VHOST_VSOCK_COMMON, selected by both symbols. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/Kconfig | 6 ++ hw/virtio/meso

Re: [PATCH 07/11] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: Instead of having "virtio/virtio-bus.h" implicitly included, explicit it, to avoid when rearranging headers: s/explicit it/explicitly include it/ ? With that change: Reviewed-by: Thomas Huth

Re: [PATCH 08/11] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: In order to have virtio-iommu.c become target-agnostic, we need to avoid using TARGET_PAGE_MASK. Get it with the qemu_target_page_mask() helper. Signed-off-by: Philippe Mathieu-Daudé --- hw/virtio/virtio-iommu.c | 3 ++- 1 file changed, 2 in

Re: [PATCH 09/11] hw/virtio: Remove unnecessary 'virtio-access.h' header

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: None of these files use the VirtIO Load/Store API declared by "hw/virtio/virtio-access.h". This header probably crept in via copy/pasting, remove it. Note, "virtio-access.h" is target-specific, so any file including it also become tainted as tar

Re: [PATCH 10/11] hw/virtio: Build various target-agnostic objects just once

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: The previous commit remove the unnecessary "virtio-access.h" header. These files no longer have target-specific dependency. Move them to the generic 'softmmu_ss' source set. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/dataplane/meson.b

Re: [RFC PATCH 11/11] hw/virtio: Make vhost-vdpa.c target-agnostic to build it once

2023-05-24 Thread Thomas Huth
On 23/05/2023 18.36, Philippe Mathieu-Daudé wrote: Replace TARGET_PAGE_MASK -> qemu_target_page_mask() and TARGET_PAGE_ALIGN() -> qemu_target_page_align() so we don't need the target-specific "cpu.h" header. These macros are used in the MemoryListener add/del handlers (vhost_vdpa_listener_skippe

Re: [PATCH 08/11] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

2023-05-24 Thread Eric Auger
Hi Philippe, On 5/23/23 18:35, Philippe Mathieu-Daudé wrote: > In order to have virtio-iommu.c become target-agnostic, > we need to avoid using TARGET_PAGE_MASK. Get it with the > qemu_target_page_mask() helper. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Eric > --- > hw/

Re: [PATCH 09/11] hw/virtio: Remove unnecessary 'virtio-access.h' header

2023-05-24 Thread Philippe Mathieu-Daudé
On 24/5/23 09:29, Thomas Huth wrote: On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: None of these files use the VirtIO Load/Store API declared by "hw/virtio/virtio-access.h". This header probably crept in via copy/pasting, remove it. Note, "virtio-access.h" is target-specific, so any file i

Re: [PATCH v3 1/1] hw/arm/aspeed:Add vpd data for Rainier machine

2023-05-24 Thread Joel Stanley
On Wed, 24 May 2023 at 06:38, Cédric Le Goater wrote: > > On 5/23/23 23:45, Ninad Palsule wrote: > > The current modeling of Rainier machine creates zero filled VPDs(EEPROMs). > > This makes some services and applications unhappy and causing them to fail. > > Hence this drop adds some fabricated d

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-24 Thread Thomas Huth
On 19/05/2023 13.48, Paolo Bonzini wrote: On 5/19/23 11:32, Daniel P. Berrangé wrote: Feels like we should be able to figure out some way to get rid of all the submodules though, except for the roms, which are special and ok to leave IMHO Hmm, almost.  roms/SLOF is used to build pc-bios/s390-c

RE: [EXT] Re: [PATCH v2] cryptodev-vhost-user: add asymmetric crypto support

2023-05-24 Thread Gowrishankar Muthukrishnan
> Pls do not v2 as reply to v1. > Start a new thread if you really want to reply to v1 with link to lore copy > of v2. > Apologies that I am new to this forum and 'll follow this in future patches as well. Please let me know any changes needed in v2. Regards, Gowrishankar

[PATCH v1] migration: fix migrate_params_test_apply to set the dest param correctly

2023-05-24 Thread Wei Wang
qmp_migrate_set_parameters expects to use tmp for parameters check, so migrate_params_test_apply is expected to copy the related fields from params to tmp. So fix migrate_params_test_apply to use the function parameter, *dest, rather than the global one. The dest->has_xxx (xxx is the feature name)

[PATCH] tests/qtest: Run arm-specific tests only if the required machine is available

2023-05-24 Thread Thomas Huth
pflash-cfi02-test.c always uses the "musicpal" machine for testing, test-arm-mptimer.c always uses the "vexpress-a9" machine, and microbit-test.c requires the "microbit" machine, so we should only run these tests if the machines have been enabled in the configuration. Signed-off-by: Thomas Huth -

Re: [PATCH 1/6] block: add blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 11:47:08AM -0400, Stefan Hajnoczi wrote: On Fri, May 19, 2023 at 10:45:57AM +0200, Stefano Garzarella wrote: On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote: > Introduce a new API for thread-local blk_io_plug() that does not > traverse the block graph. The

Re: [PATCH v2 1/6] block: add blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:55PM -0400, Stefan Hajnoczi wrote: Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section, pro

[PATCH v1] migration/multifd: always post the sync semaphores when sendesr exit

2023-05-24 Thread Wei Wang
The sem_sync and channels_ready semaphores are used by the multifd sender threads to synchronize with the migration thread. It is possible that one of the sender threads exits due to an error (e.g. occured when writing to the socket). The error thread sets multifd_send_state->exiting to force other

[PATCH] tests/qtest: Run ipmi-bt-test only if CONFIG_IPMI_EXTERN is set

2023-05-24 Thread Thomas Huth
The ipmi-bt-test uses "-device ipmi-bmc-extern", thus it should only be run if this device has been enabled in the configuration. Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/mes

Re: [PATCH v2 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:56PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- v2 - Remove

Re: [PATCH v2 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:57PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- v2 - Add mis

Re: [PATCH 1/1] hw/ide/core.c: fix handling of unsupported commands

2023-05-24 Thread Niklas Cassel
On Tue, May 23, 2023 at 10:35:56AM -0400, John Snow wrote: > On Mon, May 22, 2023 at 5:16???PM Mateusz Albecki > > wrote: > > > > Certainly seems like my patch is wrong as it will make the abort path > execute ide_cmd_done twice. During debug I came to the conclusion that > ide_cmd_done is not ca

[PATCH] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine

2023-05-24 Thread Thomas Huth
Mark the default NIC via the new MachineClass->default_nic setting so that the machine-defaults code in vl.c can decide whether the default NIC is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Thomas Huth --- hw/arm/sbsa-ref.c |

Re: [PATCH v3 2/3] vhost: register and change IOMMU flag depending on Device-TLB state

2023-05-24 Thread Jason Wang
On Sat, May 20, 2023 at 1:50 AM Viktor Prutyanov wrote: > > On Thu, May 18, 2023 at 9:14 AM Jason Wang wrote: > > > > On Fri, May 12, 2023 at 9:51 PM Viktor Prutyanov wrote: > > > > > > The guest can disable or never enable Device-TLB. In these cases, > > > it can't be used even if enabled in QE

Re: [PATCH 1/2] qemu-img: rebase: stop when reaching EOF of old backing file

2023-05-24 Thread Denis V. Lunev
On 5/23/23 18:24, Andrey Drobyshev wrote: In case when we're rebasing within one backing chain, and when target image is larger than old backing file, bdrv_is_allocated_above() ends up setting *pnum = 0. As a result, target offset isn't getting incremented, and we get stuck in an infinite for lo

Re: [RFC PATCH 1/6] block: Remove bdrv_query_block_node_info

2023-05-24 Thread Claudio Fontana
On 5/23/23 23:38, Fabiano Rosas wrote: > The last call site of this function has been removed by commit > c04d0ab026 ("qemu-img: Let info print block graph"). > > Signed-off-by: Fabiano Rosas > --- > block/qapi.c | 27 --- > include/block/qapi.h | 3 --- > 2 file

Re: [PATCH v3 1/1] hw/arm/aspeed:Add vpd data for Rainier machine

2023-05-24 Thread Cédric Le Goater
On 5/24/23 09:44, Joel Stanley wrote: On Wed, 24 May 2023 at 06:38, Cédric Le Goater wrote: On 5/23/23 23:45, Ninad Palsule wrote: The current modeling of Rainier machine creates zero filled VPDs(EEPROMs). This makes some services and applications unhappy and causing them to fail. Hence this

[PATCH 3/3] hw/arm/sbsa-ref: use MachineClass->default_display

2023-05-24 Thread Marcin Juszkiewicz
Mark the default graphica via the new MachineClass->default_display setting so that the machine-defaults code in vl.c can decide whether the default graphics is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Marcin Juszkiewicz ---

[PATCH 2/3] hw/arm/sbsa-ref: add gfx card only if we have pci

2023-05-24 Thread Marcin Juszkiewicz
Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c540b2f1ba..9a3d77d6b6

[PATCH 1/3] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Marcin Juszkiewicz
In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-r

[PULL 0/2] vfio queue

2023-05-24 Thread Cédric Le Goater
The following changes since commit aa33508196f4e2da04625bee36e1f7be5b9267e7: Merge tag 'mem-2023-05-23' of https://github.com/davidhildenbrand/qemu into staging (2023-05-23 10:57:25 -0700) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfi

[PULL 1/2] vfio/pci: Fix a use-after-free issue

2023-05-24 Thread Cédric Le Goater
From: Zhenzhong Duan vbasedev->name is freed wrongly which leads to garbage VFIO trace log. Fix it by allocating a dup of vbasedev->name and then free the dup. Fixes: 2dca1b37a760 ("vfio/pci: add support for VF token") Suggested-by: Alex Williamson Signed-off-by: Zhenzhong Duan Reviewed-by: Cé

Re: [PATCH v2 4/6] block/io_uring: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:58PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- v2 - Removed

[PULL 2/2] util/vfio-helpers: Use g_file_read_link()

2023-05-24 Thread Cédric Le Goater
From: Akihiko Odaki When _FORTIFY_SOURCE=2, glibc version is 2.35, and GCC version is 12.1.0, the compiler complains as follows: In file included from /usr/include/features.h:490, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdint.h:26,

Re: [RFC PATCH 3/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Claudio Fontana
On 5/23/23 23:39, Fabiano Rosas wrote: > From: Lin Ma > > Sometimes the query-block performs time-consuming I/O(say waiting for > the fstat of NFS complete), So let's make this QMP handler runs in a > coroutine. > > The following patch moves the fstat() into a thread pool. Hi, this message tal

Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Claudio Fontana
On 5/23/23 23:39, Fabiano Rosas wrote: > From: Lin Ma > > Sometimes the query-block performs time-consuming I/O(say waiting for > the fstat of NFS complete), So let's make this QMP handler runs in a > coroutine. > > The following patch moves the fstat() into a thread pool. > > Signed-off-by: Li

Re: [PATCH 1/3] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba

Re: [PATCH v2 6/6] block: remove bdrv_co_io_plug() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:13:00PM -0400, Stefan Hajnoczi wrote: No block driver implements .bdrv_co_io_plug() anymore. Get rid of the function pointers. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/block/block-io.h | 3 --- include/block/block_int-common.h | 11 -

Re: [PATCH v2 5/6] block/linux-aio: convert to blk_io_plug_call() API

2023-05-24 Thread Stefano Garzarella
On Tue, May 23, 2023 at 01:12:59PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake --- include/bloc

Re: [PATCH] target/ppc: Merge COMPUTE_CLASS and COMPUTE_FPRF

2023-05-24 Thread BALATON Zoltan
On Tue, 23 May 2023, Richard Henderson wrote: On 5/23/23 16:02, BALATON Zoltan wrote: On Tue, 23 May 2023, Richard Henderson wrote: Instead of computing an artifical "class" bitmask then converting that to the fprf value, compute the final value from the start. Reorder the tests to check the m

Re: [PATCH 2/3] hw/arm/sbsa-ref: add gfx card only if we have pci

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.

Re: [PATCH v3 1/1] block/blkio: use qemu_open() to support fd passing for virtio-blk

2023-05-24 Thread Stefano Garzarella
Gentle ping :-) On Wed, May 17, 2023 at 4:30 PM Stefan Hajnoczi wrote: > > On Wed, May 17, 2023 at 09:19:26AM +0200, Stefano Garzarella wrote: > > CCing Markus for some advice. > > > > On Tue, May 16, 2023 at 11:04:21AM -0500, Jonathon Jongsma wrote: > > > On 5/15/23 5:10 AM, Stefano Garzarella w

PING: [PATCH RESEND 0/6] gdbstub: Add support for info proc mappings

2023-05-24 Thread Ilya Leoshkevich
On Wed, 2023-05-10 at 22:26 +0200, Ilya Leoshkevich wrote: > [Apologies to people in To: and Cc:, who will get this the second > time - > I forgot to Cc: the mailing list initially.] > > Hi, > > this series partially implements the Host I/O feature of the GDB > Remote > Serial Protocol in order t

[PATCH 2/2] docs/clx: Change to lowercase as others

2023-05-24 Thread Li Zhijian
Using the same style except the 'Topo' abbreviation. Signed-off-by: Li Zhijian --- I'm not a native speaker, feel free to correct me. --- docs/system/devices/cxl.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.

[PATCH 1/2] docs/cxl: Correct CFMW number

2023-05-24 Thread Li Zhijian
The 'Notes:' in this document mentioned CFMW{0-2}, but the figure missed CFMW2. Signed-off-by: Li Zhijian --- I'm totally new to CXL, so i have little confidence to this change :) --- docs/system/devices/cxl.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/system/

Re: [PATCH v5 5/7] hw/cxl/events: Add injection of General Media Events

2023-05-24 Thread Jonathan Cameron via
On Tue, 23 May 2023 14:46:37 +0200 Markus Armbruster wrote: > Jonathan Cameron writes: > > >> > > >> >> > +# > >> >> > +# Inject an event record for a General Media Event (CXL r3.0 > >> >> > 8.2.9.2.1.1) > >> >> > >> >> What's "CXL r3.0", and where could a reader find it? > >> >

[PATCH v3 0/4] Virtio shared dma-buf

2023-05-24 Thread Albert Esteve
v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html v2 -> v3: - Change UUID hash function strategy to djb - Add qemu_uuid_is_equal wrapper This patch covers the required steps to add s

[PATCH v3 2/4] virtio-dmabuf: introduce virtio-dmabuf

2023-05-24 Thread Albert Esteve
This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functions that reside in the virtio-dmabuf file. Suggested-by: Gerd Hoffmann S

[PATCH v3 3/4] vhost-user: add shared_object msg

2023-05-24 Thread Albert Esteve
Add new vhost-user protocol message `VHOST_USER_BACKEND_SHARED_OBJECT`. This new message is sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add, remove, or lookup for virtio dma-buf shared objects. The action taken in the front-end depends on the type stored in

[PATCH v3 4/4] vhost-user: refactor send_resp code

2023-05-24 Thread Albert Esteve
Refactor code to send response message so that all common parts both for the common REPLY_ACK case, and other data responses, can call it and avoid code repetition. Signed-off-by: Albert Esteve --- hw/virtio/vhost-user.c | 52 +++--- 1 file changed, 24 inserti

[PATCH v3 1/4] uuid: add hash_func and equal_func

2023-05-24 Thread Albert Esteve
Add hash and an equal function to uuid module. Add a couple simple unit tests for new functions, checking collisions for similar UUIDs in the case of the hash function, and comparing generated UUIDs for the equal function. Signed-off-by: Albert Esteve --- include/qemu/uuid.h| 2 ++ tests/u

Re: [PATCH v4 05/10] qapi: make the vcpu parameters deprecated for 8.1

2023-05-24 Thread Philippe Mathieu-Daudé
On 23/5/23 14:49, Alex Bennée wrote: I don't think I can remove the parameters directly but certainly mark them as deprecated. Message-Id: <20230420150009.1675181-6-alex.ben...@linaro.org> Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Message-Id: <20230503091756.1453057-6-alex.be

Re: [PATCH v5 5/7] hw/cxl/events: Add injection of General Media Events

2023-05-24 Thread Jonathan Cameron via
On Wed, 24 May 2023 10:11:58 +0100 Jonathan Cameron wrote: > On Tue, 23 May 2023 14:46:37 +0200 > Markus Armbruster wrote: > > > Jonathan Cameron writes: > > > > >> > > > >> >> > +# > > >> >> > +# Inject an event record for a General Media Event (CXL r3.0 > > >> >> > 8.2.9.2.1.1) >

Re: [PATCH 3/3] hw/arm/sbsa-ref: use MachineClass->default_display

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: Mark the default graphica via the new MachineClass->default_display setting so that the machine-defaults code in vl.c can decide whether the default graphics is usable or not (for example when compiling with the "--without-default-devices" configure

Re: [PATCH v4 01/10] *-user: remove the guest_user_syscall tracepoints

2023-05-24 Thread Philippe Mathieu-Daudé
On 23/5/23 14:49, Alex Bennée wrote: This is pure duplication now. Both bsd-user and linux-user have builtin strace support and we can also track syscalls via the plugins system. Message-Id: <20230420150009.1675181-2-alex.ben...@linaro.org> Reviewed-by: Warner Losh Reviewed-by: Stefan Hajnoczi

Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Lin Ma
The query-named-block-nodes is only availabe for qmp, not support hmp yet. Lin From: Claudio Fontana Sent: Wednesday, May 24, 2023 4:49 PM To: Fabiano Rosas; qemu-devel@nongnu.org Cc: qemu-bl...@nongnu.org; Kevin Wolf; Hanna Reitz; Markus Armbruster; João

Re: [PATCH v4 02/10] trace-events: remove the remaining vcpu trace events

2023-05-24 Thread Philippe Mathieu-Daudé
On 23/5/23 14:49, Alex Bennée wrote: While these are all in helper functions being designated vcpu events complicates the removal of the dynamic vcpu state code. TCG plugins allow you to instrument vcpu_[init|exit|idle]. We rename cpu_reset and make it a normal trace point. Reviewed-by: Stefan

Re: [PATCH 3/3] hw/arm/sbsa-ref: use MachineClass->default_display

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: Mark the default graphica via the new MachineClass->default_display setting so that the machine-defaults code in vl.c can decide whether the default graphics is usable or not (for example when compiling with the "--without-default-devices" configure

Re: [PATCH 1/3] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba

Re: [PATCH 08/11] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

2023-05-24 Thread Philippe Mathieu-Daudé
On 24/5/23 01:28, Richard Henderson wrote: On 5/23/23 09:35, Philippe Mathieu-Daudé wrote: In order to have virtio-iommu.c become target-agnostic, we need to avoid using TARGET_PAGE_MASK. Get it with the qemu_target_page_mask() helper. Signed-off-by: Philippe Mathieu-Daudé ---   hw/virtio/virt

Re: [PATCH 2/3] hw/arm/sbsa-ref: add gfx card only if we have pci

2023-05-24 Thread Thomas Huth
On 24/05/2023 10.39, Marcin Juszkiewicz wrote: Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.

Re: [PATCH 03/11] hw/scsi: Rearrange meson.build

2023-05-24 Thread Philippe Mathieu-Daudé
On 24/5/23 09:14, Thomas Huth wrote: On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote: We will modify this file shortly. Re-arrange it slightly first, declaring source sets first. No logical change. Signed-off-by: Philippe Mathieu-Daudé ---   hw/scsi/meson.build | 12 +---   1 file ch

Re: [PATCH RESEND 1/6] linux-user: Expose do_guest_openat() and do_guest_readlink()

2023-05-24 Thread Alex Bennée
Ilya Leoshkevich writes: > These functions will be required by the GDB stub in order to provide > the guest view of /proc to GDB. > > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH RESEND 2/6] gdbstub: Expose gdb_get_process() and gdb_get_first_cpu_in_process()

2023-05-24 Thread Alex Bennée
Ilya Leoshkevich writes: > These functions will be needed by user-target.c in order to retrieve > the name of the executable. > > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH v2 00/10] hw/virtio: Build various target-agnostic objects just once

2023-05-24 Thread Philippe Mathieu-Daudé
All patches reviewed. Since v1: - Addressed Richard & Thomas review comments . qemu_target_page_align() dropped . qemu_target_page_mask() returns signed . meson shuffle - Collected R-b/T-b/A-b tags - Dropped vhost-vdpa patch (to be posted as another series) Less controvertial than my first

[PATCH v2 01/10] softmmu: Introduce qemu_target_page_mask() helper

2023-05-24 Thread Philippe Mathieu-Daudé
Since TARGET_PAGE_MASK is poisoned in target-agnostic code, introduce the qemu_target_page_mask() helper to get this value from target-agnostic code at runtime. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/exec/target_page.h | 1 + softmmu/physmem.c | 5 ++

[PATCH v2 03/10] hw/scsi: Rearrange meson.build

2023-05-24 Thread Philippe Mathieu-Daudé
We will modify this file shortly. Re-arrange it slightly first, declaring source sets first. No logical change. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/meson.build | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/scsi/me

[PATCH v2 04/10] hw/scsi: Rename target-specific source set as 'specific_virtio_scsi_ss'

2023-05-24 Thread Philippe Mathieu-Daudé
Following the SCSI variable named '[specific_]scsi_ss', rename the target-specific VirtIO/SCSI set prefixed with 'specific_'. This will help when adding target-agnostic VirtIO/SCSI set in few commits. No logical change. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- h

[PATCH v2 05/10] hw/virtio: Introduce VHOST_VSOCK_COMMON symbol in Kconfig

2023-05-24 Thread Philippe Mathieu-Daudé
Instead of adding 'vhost-vsock-common.c' twice (for VHOST_VSOCK and VHOST_USER_VSOCK), have it depend on VHOST_VSOCK_COMMON, selected by both symbols. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/virtio/Kconfig | 6 ++ hw/virtio/m

[PATCH v2 07/10] hw/virtio/vhost-vsock: Include missing 'virtio/virtio-bus.h' header

2023-05-24 Thread Philippe Mathieu-Daudé
Instead of having "virtio/virtio-bus.h" implicitly included, explicitly include it, to avoid when rearranging headers: hw/virtio/vhost-vsock-common.c: In function ‘vhost_vsock_common_start’: hw/virtio/vhost-vsock-common.c:51:5: error: unknown type name ‘VirtioBusClass’; did you mean ‘VirtioDe

[PATCH v2 02/10] hw/scsi: Introduce VHOST_SCSI_COMMON symbol in Kconfig

2023-05-24 Thread Philippe Mathieu-Daudé
Instead of adding 'vhost-scsi-common.c' twice (for VHOST_SCSI and VHOST_USER_SCSI), have it depend on VHOST_SCSI_COMMON, selected by both symbols. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- hw/scsi/Kconfig | 6 ++ hw/scsi/meson.bui

[PATCH v2 10/10] hw/virtio: Build various target-agnostic objects just once

2023-05-24 Thread Philippe Mathieu-Daudé
The previous commit remove the unnecessary "virtio-access.h" header. These files no longer have target-specific dependency. Move them to the generic 'softmmu_ss' source set. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- hw/block/dataplane/mes

[PATCH v2 08/10] hw/virtio/virtio-iommu: Use target-agnostic qemu_target_page_mask()

2023-05-24 Thread Philippe Mathieu-Daudé
In order to have virtio-iommu.c become target-agnostic, we need to avoid using TARGET_PAGE_MASK. Get it with the qemu_target_page_mask() helper. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- hw/virtio/virtio-iommu.c | 3 ++- 1 file changed, 2

[PATCH v2 09/10] hw/virtio: Remove unnecessary 'virtio-access.h' header

2023-05-24 Thread Philippe Mathieu-Daudé
None of these files use the VirtIO Load/Store API declared by "hw/virtio/virtio-access.h". This header probably crept in via copy/pasting, remove it. Note, "virtio-access.h" is target-specific, so any file including it also become tainted as target-specific. Signed-off-by: Philippe Mathieu-Daudé

[PATCH v2 06/10] hw/virtio/virtio-mem: Use qemu_ram_get_fd() helper

2023-05-24 Thread Philippe Mathieu-Daudé
Avoid accessing RAMBlock internals, use the provided qemu_ram_get_fd() getter to get the file descriptor. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson --- hw/virtio/virtio-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH v2 03/10] hw/scsi: Rearrange meson.build

2023-05-24 Thread Thomas Huth
On 24/05/2023 11.37, Philippe Mathieu-Daudé wrote: We will modify this file shortly. Re-arrange it slightly first, declaring source sets first. No logical change. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/scsi/meson.build | 10 +- 1 file changed, 5

Re: [PATCH RESEND 3/6] gdbstub: Report the actual qemu-user pid

2023-05-24 Thread Alex Bennée
Ilya Leoshkevich writes: > Currently qemu-user reports pid 1 to GDB. Resolve the TODO and report > the actual PID. Using getpid() relies on the assumption that there is > only one GDBProcess. Add an assertion to make sure that future changes > don't break it. > > Signed-off-by: Ilya Leoshkevich

Re: [PATCH v2 04/10] hw/scsi: Rename target-specific source set as 'specific_virtio_scsi_ss'

2023-05-24 Thread Thomas Huth
On 24/05/2023 11.37, Philippe Mathieu-Daudé wrote: Following the SCSI variable named '[specific_]scsi_ss', rename the target-specific VirtIO/SCSI set prefixed with 'specific_'. This will help when adding target-agnostic VirtIO/SCSI set in few commits. No logical change. Signed-off-by: Philippe

[PATCH 1/4] Add Bochs to list of vga_interfaces

2023-05-24 Thread Marcin Juszkiewicz
arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz --- include/sysemu/sysemu.h | 2 +- softmmu/vl.c| 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) d

[PATCH v2 4/5] hw/arm/sbsa-ref: add gfx card only if we have pci

2023-05-24 Thread Marcin Juszkiewicz
Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c540b2f1ba..9a3d77d6b6

[PATCH v2 3/5] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Marcin Juszkiewicz
In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-r

[PATCH v2 2/5] Add Bochs to list of vga_interfaces

2023-05-24 Thread Marcin Juszkiewicz
arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz --- include/sysemu/sysemu.h | 2 +- softmmu/vl.c| 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) d

[PATCH v2 5/5] hw/arm/sbsa-ref: use MachineClass->default_display

2023-05-24 Thread Marcin Juszkiewicz
Mark the default graphica via the new MachineClass->default_display setting so that the machine-defaults code in vl.c can decide whether the default graphics is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Marcin Juszkiewicz ---

[PATCH v2 1/5] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine

2023-05-24 Thread Marcin Juszkiewicz
From: Thomas Huth Mark the default NIC via the new MachineClass->default_nic setting so that the machine-defaults code in vl.c can decide whether the default NIC is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Thomas Huth ---

Re: [PATCH RESEND 5/6] docs: Document security implications of debugging

2023-05-24 Thread Alex Bennée
Ilya Leoshkevich writes: > Now that the GDB stub implements reading host files, concerns may arise > that it undermines security. Document the status quo, which is that the > users are already responsible for securing the GDB connection > themselves. > > Signed-off-by: Ilya Leoshkevich Review

Re: [PATCH 6/6] tests/decode: Add tests for various named-field cases

2023-05-24 Thread Peter Maydell
On Tue, 23 May 2023 at 13:04, Peter Maydell wrote: > > Add some tests for various cases of named-field use, both ones that > should work and ones that should be diagnosed as errors. > > Signed-off-by: Peter Maydell > --- > tests/decode/err_field1.decode | 2 +- > tests/decode/err_field10.

[PATCH v3 3/5] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Marcin Juszkiewicz
In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-r

[PATCH v3 4/5] hw/arm/sbsa-ref: add gfx card only if we have pci

2023-05-24 Thread Marcin Juszkiewicz
Creation of network card is guarded with check do we have pci bus. Do the same with graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index c540b2f1ba..9a3d77d6b6

[PATCH v3 2/5] Add Bochs to list of vga_interfaces

2023-05-24 Thread Marcin Juszkiewicz
arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz --- include/sysemu/sysemu.h | 2 +- softmmu/vl.c| 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) d

[PATCH v3 1/5] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine

2023-05-24 Thread Marcin Juszkiewicz
From: Thomas Huth Mark the default NIC via the new MachineClass->default_nic setting so that the machine-defaults code in vl.c can decide whether the default NIC is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Thomas Huth ---

[PATCH v3 0/5] hw/arm/sbsa-ref: sort out graphics a bit

2023-05-24 Thread Marcin Juszkiewicz
Thomas Huth gave me some hints on how to improve sbsa-ref configuration when it comes to graphics. With this patchset we are able to start sbsa-ref if qemu is build with "--without-default-devices" argument given to configure script. Marcin Juszkiewicz (4): Add Bochs to list of vga_interfaces

[PATCH v3 5/5] hw/arm/sbsa-ref: use MachineClass->default_display

2023-05-24 Thread Marcin Juszkiewicz
Mark the default graphica via the new MachineClass->default_display setting so that the machine-defaults code in vl.c can decide whether the default graphics is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Marcin Juszkiewicz ---

Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Peter Maydell
On Tue, 23 May 2023 at 23:39, Richard Henderson wrote: > > Remove the signed * signed check, leaving the signed * unsigned check. > This link test runs foul of -fsanitize=undefined, where clang-11 has > an undefined reference to __muloti4 to check for signed overflow. If you can't do a signed * s

Re: [PATCH v3 2/5] Add Bochs to list of vga_interfaces

2023-05-24 Thread Thomas Huth
On 24/05/2023 12.27, Marcin Juszkiewicz wrote: arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz --- include/sysemu/sysemu.h | 2 +- softmmu/vl.c| 6 ++

Re: [PATCH v3 3/5] hw/arm/sbsa-ref: honor "-vga none" argument

2023-05-24 Thread Thomas Huth
On 24/05/2023 12.27, Marcin Juszkiewicz wrote: In case someone wants to run without graphics card. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e670ec6..c540b2f1ba

Re: [PATCH] virtio-gpu: add a FIXME for virtio_gpu_load()

2023-05-24 Thread Marc-André Lureau
Hi Michael On Fri, May 19, 2023 at 1:35 AM Michael S. Tsirkin wrote: > On Mon, May 15, 2023 at 05:25:18PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > It looks like the virtio_gpu_load() does not compute and set the offset, > > the same way virtio_gpu_set_scan

Re: [PATCH] win32: wrap socket close() with an exception handler

2023-05-24 Thread Marc-André Lureau
On Mon, May 15, 2023 at 5:25 PM wrote: > From: Marc-André Lureau > > Since commit abe34282 ("win32: avoid mixing SOCKET and file descriptor > space"), we set HANDLE_FLAG_PROTECT_FROM_CLOSE on the socket FD, to > prevent closing the HANDLE with CloseHandle. This raises an exception > which under

[PATCH v4 3/3] hw/arm/sbsa-ref: set default display to Bochs

2023-05-24 Thread Marcin Juszkiewicz
This way we can use pci_vga_init() and have Bochs by default while still have an option to run with other VGA cards. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 9c3e67

[PATCH 1/3] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine

2023-05-24 Thread Marcin Juszkiewicz
From: Thomas Huth Mark the default NIC via the new MachineClass->default_nic setting so that the machine-defaults code in vl.c can decide whether the default NIC is usable or not (for example when compiling with the "--without-default-devices" configure switch). Signed-off-by: Thomas Huth Teste

[PATCH v4 0/3] hw/arm/sbsa-ref: sort out graphics a bit

2023-05-24 Thread Marcin Juszkiewicz
Thomas Huth gave me some hints on how to improve sbsa-ref configuration when it comes to graphics. With this patchset we are able to start sbsa-ref if qemu is build with "--without-default-devices" argument given to configure script. Changes since v3: - add Bochs display to pci_vga_init() list -

[PATCH v4 2/3] Add Bochs to list of vga_interfaces

2023-05-24 Thread Marcin Juszkiewicz
arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz --- hw/pci/pci.c| 2 ++ include/sysemu/sysemu.h | 2 +- softmmu/vl.c| 6 ++ 3 files changed, 9

  1   2   3   >