On 24/5/23 09:29, Thomas Huth wrote:
On 23/05/2023 18.35, Philippe Mathieu-Daudé wrote:
None of these files use the VirtIO Load/Store API declared
by "hw/virtio/virtio-access.h". This header probably crept
in via copy/pasting, remove it.
Note, "virtio-access.h" is target-specific, so any file
including it also become tainted as target-specific.
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
hw/block/dataplane/virtio-blk.c | 1 -
hw/s390x/virtio-ccw.c | 1 -
hw/scsi/vhost-scsi.c | 1 -
hw/scsi/vhost-user-scsi.c | 1 -
hw/scsi/virtio-scsi-dataplane.c | 1 -
hw/virtio/vdpa-dev.c | 1 -
hw/virtio/vhost-vdpa.c | 1 -
hw/virtio/vhost-vsock-common.c | 1 -
hw/virtio/vhost.c | 1 -
hw/virtio/virtio-crypto.c | 1 -
hw/virtio/virtio-iommu.c | 1 -
hw/virtio/virtio-mem.c | 1 -
12 files changed, 12 deletions(-)
Very good catch! I checked that it compiles and links fine with this
change, so:
Tested-by: Thomas Huth <th...@redhat.com>
Thanks, FYI this list was built doing:
$ git grep -l virtio-access.h \
| xargs git grep -LE 'virtio_(st|ld)' \
| xargs git grep virtio-access.h
(I don't think the command is relevant enough to include in the
commit description, but can amend it)
