Am 27.04.23 um 16:36 schrieb Juan Quintela:
> Fiona Ebner wrote:
>> Am 27.04.23 um 13:03 schrieb Kevin Wolf:
>>> Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben:
Am 20.04.23 um 08:55 schrieb Paolo Bonzini:
>
> Hi
>
>> Our function is a custom variant of saving a snapshot and uses
>> qemu
Vladimir Sementsov-Ogievskiy wrote:
> We don't allow to use x-colo capability when replication is not
> configured. So, no reason to build COLO when replication is disabled,
> it's unusable in this case.
>
> Note also that the check in migrate_caps_check() is not the only
> restriction: some funct
Vladimir Sementsov-Ogievskiy wrote:
> Add option to not build filter-mirror, filter-rewriter and
> colo-compare when they are not needed.
>
> There could be more agile configuration, for example add separate
> options for each filter, but that may be done in future on demand. The
> aim of this pat
On 4/27/23 16:44, Alex Bennée wrote:
The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:
Merge tag 'migration-20230426-pull-request'
ofhttps://gitlab.com/juan.quintela/qemu into staging (2023-04-27 10:47:14
+0100)
are available in the Git repository at:
https:
On 4/27/23 14:16, Fabiano Rosas wrote:
Richard Henderson writes:
On 4/26/23 19:00, Fabiano Rosas wrote:
We're about to move the 32-bit CPUs under CONFIG_TCG, so adjust the
query-cpu-model-expansion test to check against the cortex-a7, which
is already under CONFIG_TCG. That allows the next pa
Fiona Ebner wrote:
> Am 27.04.23 um 16:36 schrieb Juan Quintela:
>> Fiona Ebner wrote:
>>> Am 27.04.23 um 13:03 schrieb Kevin Wolf:
Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben:
> Am 20.04.23 um 08:55 schrieb Paolo Bonzini:
>>
>> Hi
>>
>>> Our function is a custom variant of savi
Am 27.04.23 um 16:56 schrieb Peter Xu:
> On Thu, Apr 27, 2023 at 04:36:14PM +0200, Juan Quintela wrote:
>> Fiona Ebner wrote:
>>> Am 27.04.23 um 13:03 schrieb Kevin Wolf:
Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben:
> Am 20.04.23 um 08:55 schrieb Paolo Bonzini:
>>
>> Hi
>>
>>> Our
On 4/27/23 23:59, Taylor Simpson wrote:
Enable conditional compilation depending on whether idef-parser
is configured
Signed-off-by: Taylor Simpson
---
meson.build | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson
r~
On 4/27/23 23:59, Taylor Simpson wrote:
These instructions have implicit reads from p0, so we don't want
them in helpers when idef-parser is off.
Signed-off-by: Taylor Simpson
---
target/hexagon/gen_tcg.h | 16
target/hexagon/macros.h | 4
2 files changed, 16 inserti
On 4/28/23 00:00, Taylor Simpson wrote:
The generated helpers for HVX use pass-by-reference, so they can't
short-circuit when the reads/writes overlap. The instructions with
overrides are OK because they use tcg_gen_gvec_*.
We add a flag has_hvx_helper to DisasContext and extend gen_analyze_fun
On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote:
> Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
> This flag is set/checked prior to calling a device's MemoryRegion
> handlers, and set when device code initiates DMA. The purpose of this
> flag is to pre
On 28/04/2023 10.12, Daniel P. Berrangé wrote:
On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote:
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
This flag is set/checked prior to calling a device's MemoryRegion
handlers, and set when device code initiate
"Michael S. Tsirkin" wrote:
> On Tue, Apr 25, 2023 at 07:14:34PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> On incoming migration we have the following sequence to load option
>> ROM:
>>
>> 1. On device realize we do normal load ROM from the file
>>
>> 2. Than, on incoming migration we rewrit
On 28.04.23 10:33, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy wrote:
Add option to not build filter-mirror, filter-rewriter and
colo-compare when they are not needed.
There could be more agile configuration, for example add separate
options for each filter, but that may be done in futur
Am 28.04.2023 um 09:47 hat Juan Quintela geschrieben:
> Fiona Ebner wrote:
> > Am 27.04.23 um 16:36 schrieb Juan Quintela:
> >> Fiona Ebner wrote:
> >>> Am 27.04.23 um 13:03 schrieb Kevin Wolf:
> Am 26.04.2023 um 16:31 hat Fiona Ebner geschrieben:
> > Am 20.04.23 um 08:55 schrieb Paolo B
On 28.04.23 10:30, Juan Quintela wrote:
Vladimir Sementsov-Ogievskiy wrote:
We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.
Note also that the check in migrate_caps_check() is not
Hi
After reorganization of the capabilities, this two functions don't use
the MigrationState parameter anymore, just drop it.
Vladimir suggested it while he was doing the review.
Later, Juan.
Juan Quintela (2):
migration: Drop unused parameter for migration_tls_get_creds()
migration: Drop u
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Juan Quintela
---
migration/multifd.c | 2 +-
migration/postcopy-ram.c | 2 +-
migration/tls.c | 5 ++---
migration/tls.h | 3 +--
4 fil
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Juan Quintela
---
migration/tls.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/migration/tls.c b/migration/tls.c
index cd2917
On 28.04.23 11:34, Juan Quintela wrote:
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Kevin Wolf wrote:
>>
>> I am perhaps a bit ingenuous here, but it is there a way to convince
>> qemu that snapshot_save_job_bh *HAS* to run on the main thread?
>
> I believe we're talking about a technicality here. I asked another more
> fundamental question that nobody has answered yet:
>
> Why
On 28.04.23 11:34, Juan Quintela wrote:
It is not needed since we moved the accessor for tls properties to
options.c.
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
> -Original Message-
> From: Vladimir Sementsov-Ogievskiy
> Sent: Friday, April 28, 2023 5:30 AM
> To: Lukas Straub
> Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org;
> michael.r...@amd.com; arm...@redhat.com; ebl...@redhat.com;
> jasow...@redhat.com; quint...@redhat.com; Zhang, Hailia
Vladimir Sementsov-Ogievskiy wrote:
> On 28.04.23 10:33, Juan Quintela wrote:
>> Vladimir Sementsov-Ogievskiy wrote:
>>> Add option to not build filter-mirror, filter-rewriter and
>>> colo-compare when they are not needed.
>>>
>>> There could be more agile configuration, for example add separate
Vladimir Sementsov-Ogievskiy wrote:
> On 28.04.23 10:33, Juan Quintela wrote:
>> Vladimir Sementsov-Ogievskiy wrote:
>>> Add option to not build filter-mirror, filter-rewriter and
>>> colo-compare when they are not needed.
>>>
>>> There could be more agile configuration, for example add separate
Juan Quintela wrote:
> Once there:
> - Remove unused data parameter
> - unfold it in its callers.
> - change all callers to call qemu_rdma_registration_start()
>
> Signed-off-by: Juan Quintela
self-Nack from here.
I just break the case when there is CONFIG_RDMA but it is not being
used.
Later,
On 230428 1015, Thomas Huth wrote:
> On 28/04/2023 10.12, Daniel P. Berrangé wrote:
> > On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote:
> > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
> > > This flag is set/checked prior to calling a device's Memory
On 28/04/2023 11.11, Alexander Bulekov wrote:
On 230428 1015, Thomas Huth wrote:
On 28/04/2023 10.12, Daniel P. Berrangé wrote:
On Thu, Apr 27, 2023 at 05:10:06PM -0400, Alexander Bulekov wrote:
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
This flag is set/checked p
On 4/27/23 22:22, Weiwei Li wrote:
On 2023/4/28 04:57, Daniel Henrique Barboza wrote:
Commit 3479a814 ("target/riscv: rvv-1.0: add VMA and VTA") added vma and
vta fields in the vtype register, while also defining that QEMU doesn't
need to have a tail agnostic policy to be compliant with the
On Thu, Apr 27, 2023 at 17:57:06 -0300, Daniel Henrique Barboza wrote:
: Second patch makes the function debug only. The logic is explained in
: the commit message, but long story short: we don't have to implement any
: tail-agnostic policy at all to be spec compliant, but this function has
: its
Fix a few minor typos for PMU events.
Signed-off-by: Yu Chien Peter Lin
---
target/riscv/cpu.h| 2 +-
target/riscv/cpu_helper.c | 2 +-
target/riscv/pmu.c| 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 638
Vladimir Sementsov-Ogievskiy writes:
> On 27.04.23 12:53, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> docs/devel/qapi-code-gen.rst | 53
>> 1 file changed, 53 insertions(+)
>> diff --git a/docs/devel/qapi-code-gen.rst b/docs/deve
The pmu encodes the event to counter mappings and is only used
by the SBI firmware. Currently, pmu is a subnode of soc but has
no reg properties included, causing the following failure when
checked with dt-validate.
/tmp/virt.dtb: soc: pmu: {'riscv,event-to-mhpmcounters': [[1, 1, 524281], [2,
2,
Vladimir Sementsov-Ogievskiy writes:
> On 04.04.23 14:58, Markus Armbruster wrote:
>> It's always nice to get doc fixes into the release, but if it's too
>> late, it's too late.
>> Generated code does not change, except for the last patch, which moves
>> a bit of code without changing it.
>
>
> I
From: Ilya Leoshkevich
Both TCG and KVM emulate ckc, cputm, last_break and prefix, and it's
quite useful to have them during debugging. Right now they are grouped
together with KVM-only pp, pfault_token, pfault_select and
pfault_compare in s390-virt.xml, and are not available when debugging
TCG-e
From: Alexander Bulekov
Devices can pass their MemoryReentrancyGuard (from their DeviceState),
when creating new BHes. Then, the async API will toggle the guard
before/after calling the BH call-back. This prevents bh->mmio reentrancy
issues.
Signed-off-by: Alexander Bulekov
Reviewed-by: Darren
From: Paolo Bonzini
chr_read() is printing an error message and returning with s->data_mutex taken.
This can potentially cause a hang. Reported by Coverity.
Signed-off-by: Paolo Bonzini
Message-Id: <20230427125423.103536-1-pbonz...@redhat.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Hu
From: Alexander Bulekov
Advise authors to use the _guarded versions of the APIs, instead.
Signed-off-by: Alexander Bulekov
Reviewed-by: Darren Kenny
Message-Id: <20230427211013.2994127-4-alx...@bu.edu>
Signed-off-by: Thomas Huth
---
scripts/checkpatch.pl | 8
1 file changed, 8 inser
They have apparently never been used.
Message-Id: <20230419103018.627115-1-th...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
hw/rdma/rdma_rm.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
index cfd85de3e6..038d56
The "pvrdma" device is only usable in conjunction with the "vmxnet3"
NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().
By adding this dependency, the amount of total files that have to
be compiled for a configuration with all targets decreases by 64
files (!), since the rdma code is marked
From: Alexander Bulekov
As the code is designed for re-entrant calls to apic-msi, mark apic-msi
as reentrancy-safe.
Signed-off-by: Alexander Bulekov
Reviewed-by: Darren Kenny
Message-Id: <20230427211013.2994127-9-alx...@bu.edu>
Signed-off-by: Thomas Huth
---
hw/intc/apic.c | 7 +++
1 fil
From: Alexander Bulekov
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA.
This flag is set/checked prior to calling a device's MemoryRegion
handlers, and set when device code initiates DMA. The purpose of this
flag is to prevent two types of DMA-based reentrancy issues:
1
From: Alexander Bulekov
This protects devices from bh->mmio reentrancy issues.
Thanks: Thomas Huth for diagnosing OS X test failure.
Signed-off-by: Alexander Bulekov
Reviewed-by: Darren Kenny
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Paul Durrant
Reviewed-by
From: Alexander Bulekov
As the code is designed for re-entrant calls from bcm2835_property to
bcm2835_mbox and back into bcm2835_property, mark iomem as
reentrancy-safe.
Signed-off-by: Alexander Bulekov
Reviewed-by: Thomas Huth
Message-Id: <20230427211013.2994127-7-alx...@bu.edu>
Signed-off-by
Hi Richard!
The following changes since commit cc5ee50fff9dbac0aac32cd892a7163c7babcca1:
Merge tag 'pull-testing-docs-270423-1' of https://gitlab.com/stsquad/qemu
into staging (2023-04-27 16:46:17 +0100)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-r
Some files of the rdma code do not depend on any target specific
macros. Compile these only once to save some time during the build.
Message-Id: <20230419114937.667221-1-th...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
hw/rdma/meson.build | 8 +---
1 file
From: Alexander Bulekov
As the code is designed to use the memory APIs to access the script ram,
disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion.
In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion.
Reported-by: Fiona Ebner
Signed-off-by: Alexander B
On 28.04.23 12:34, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
On 27.04.23 12:53, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 53
1 file changed, 53 insertions(+)
diff --git a/docs/de
From: Alexander Bulekov
As the code is designed for re-entrant calls from raven_io_ops to
pci-conf, mark raven_io_ops as reentrancy-safe.
Signed-off-by: Alexander Bulekov
Message-Id: <20230427211013.2994127-8-alx...@bu.edu>
Signed-off-by: Thomas Huth
---
hw/pci-host/raven.c | 7 +++
1 fil
v7 takes a different approach to wiring up MTE, so I still include a cover
letter where I can explain things better, even though it is now only a
single patch :)
Previous versions used a cpu property to control MTE enablement, while
keeping the same semantics for the virt machine "mte" property as
Extend the 'mte' property for the virt machine to cover KVM as
well. For KVM, we don't allocate tag memory, but instead enable the
capability.
If MTE has been enabled, we need to disable migration, as we do not
yet have a way to migrate the tags as well. Therefore, MTE will stay
off with KVM unles
On 4/27/23 16:22, Juan Quintela wrote:
The following changes since commit 1eb95e1baef852d0971a1dd62a3293cd68f1ec35:
Merge tag 'migration-20230426-pull-request'
ofhttps://gitlab.com/juan.quintela/qemu into staging (2023-04-27 10:47:14
+0100)
are available in the Git repository at:
http
Use a store-release at the end of the work item, and a load-acquire when
waiting for the item to be completed. This is the standard message passing
pattern and is both enough and clearer than mb_read/mb_set.
Signed-off-by: Paolo Bonzini
---
cpus-common.c | 4 ++--
1 file changed, 2 insertions(+
Vladimir Sementsov-Ogievskiy writes:
> On 28.04.23 12:34, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> On 27.04.23 12:53, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 53 +++
The following changes since commit cc5ee50fff9dbac0aac32cd892a7163c7babcca1:
Merge tag 'pull-testing-docs-270423-1' of https://gitlab.com/stsquad/qemu
into staging (2023-04-27 16:46:17 +0100)
are available in the Git repository at:
https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2023-04-2
rST parses something like
first line
second line
as a definition list item, where "first line" is the term being
defined by "second line".
This bites us in a couple of places. Here's one:
# @bps_max: total throughput limit during bursts,
# in bytes (Sinc
Signed-off-by: Markus Armbruster
Message-Id: <20230427095346.1238913-1-arm...@redhat.com>
Reviewed-by: Juan Quintela
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
docs/devel/qapi-code-gen.rst | 53
1 file changed, 53 insertions(+)
diff --git a/docs/devel/qa
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Marc-André Lureau
Message-Id: <20230425064223.820979-16-arm...@redhat.com>
---
qapi/block-core.json | 6 +++---
qapi/stats.json | 2 +-
qapi/tpm.json| 3 +--
qapi/ui.json | 6 +++---
4 f
query-cpu-definitions returns a list of CpuDefinitionInfo, but
documentation claims CpuDefInfo, which doesn't exist.
query-migrate-capabilities returns a list of
MigrationCapabilityStatus, but documentation claims
MigrationCapabilitiesStatus, which doesn't exist.
balloon and query-balloon can fai
Documentation section "Stability Considerations" dates back to the
early days of QMP (commit 82a56f0d83d (Monitor: Introduce the
qmp-commands.hx file)). It became largely misleading years ago.
Delete it.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Mar
Commit 81cbfd50886 (block: remove dirty bitmaps 'status' field)
removed deprecated BlockDirtyInfo member @status. It neglected to
remove references to its enumeration values from the documentation of
its replacements. Do that now.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov
GuestDiskStatsInfo's member documentation is parsed as ordinary text
due to missing colons. The generated documentation shows these
members as "Not documented".
The fix is obvious: add the missing colons.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: M
Member / argument documentation of BlockdevAmendOptionsQcow2,
job-resume, and RDMA_GID_STATUS_CHANGED is parsed as ordinary text due
to missing colon or space before the colon. The generated
documentation shows these members / arguments as "Not documented".
The fix is obvious: add missing colons,
Commit de253f14912e88f4 (qmp: switch to the new error format on the
wire) removed most error classes. Several later commits mistakenly
mentioned them in documentation. Replace them by the actual error
class there.
Fixes: 44e3e053af56 (qmp: add interface blockdev-snapshot-delete-internal-sync)
Fi
Section tags are case sensitive and end with a colon. Screwing up
either gets them interpreted as ordinary paragraph. Fix a few.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Marc-André Lureau
Message-Id: <20230425064223.820979-15-arm...@redhat.com>
-
Delete "error state indicates", because it doesn't make sense.
I suspect it was an accident.
Signed-off-by: Markus Armbruster
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Marc-André Lureau
Message-Id: <20230425064223.820979-2-arm...@redhat.com>
---
qg
Documentation suggests @foo is merely shorthand for ``foo``. It's
not, it carries additional meaning: it's a reference to a QAPI schema
name.
Reword the documentation to spell that out.
Fix up the few ``foo`` that should be @foo.
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov
A few examples neglect to prefix QMP input with '->'. Fix that.
Two examples have extra space after '<-'. Delete it.
A few examples neglect to show output. Provide some. The example
output for query-vcpu-dirty-limit could use further improvement. Add
a TODO comment.
Use "Examples:" instead
In the QEMU QMP Reference Manual, subsection "Block core (VM
unrelated)" is empty. Its contents is at the end of subsection
"Background jobs" instead. That's because qapi/job.json is included
first from qapi/block-core.json, which makes qapi/job.json's
documentation go between qapi/block-core.jso
On 2023/04/27 19:47, Tomasz Dzieciol wrote:
Format of Intel 82576 was changed in comparison to Intel 82574 extended
descriptors. This change updates filling of advanced descriptors fields
accordingly:
* remove TCP ACK detection
* add IPv6 with extensions traffic detection
* fragment checksum and
Peter Maydell's commit 100cc4fe0f08 explains:
rST insists on a blank line before and after a bulleted list [...]
Add some extra blank lines in the doc comments so they're
acceptable rST input.
It missed one in qapi/trace.json.
Paolo Bonzini later added another instance in qapi/stats.
Code returns a list of GuestNetworkInterface, documentation claims
GuestNetworkInfo, which doesn't exist. Fix the documentation.
Fixes: 3424fc9f16a1 (qemu-ga: add guest-network-get-interfaces command)
Signed-off-by: Markus Armbruster
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Marc-A
MemoryDeviceInfoKind, NetClientDriver, and GuestPanicAction mention
some members only in ad hoc since documentation. The generated
documentation shows these members as "Not documented".
Replace by formal member documentation.
Add actual documentation text for the GuestPanicAction members, to
mat
On 27/04/2023 17.44, Alex Bennée wrote:
From: Philippe Mathieu-Daudé
This change adds set of boot tests on SBSA-ref machine:
1. boot firmware up to the EDK2 banner
2. boot Alpine Linux
Prebuilt flash volumes are included, built using upstream documentation.
To unify tests for AArch64/virt an
Drop inline marker: let compiler decide.
Change return type to uint64_t: this matches the computation in the
return statement and the local variable assignment in the caller.
Rename local to dirty_ring_size_MB to fix typo.
Simplify conversion to MiB via qemu_target_page_bits and right shift.
Sig
On 2023/04/28 11:52, Gurchetan Singh wrote:
From: Gurchetan Singh
The virtio-gpu GL device has a heavy dependence on virgl.
Acknowledge this by naming functions accurately.
Signed-off-by: Gurchetan Singh
Reviewed-by: Philippe Mathieu-Daudé
---
v1:
- (Philippe) virtio_gpu_virglrenderer_rese
Signed-off-by: Paolo Bonzini
---
include/qemu/rcu.h | 5 -
util/rcu.c | 24 +++-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index 313fc414bc2a..661c1a146872 100644
--- a/include/qemu/rcu.h
+++ b/include
We have two FIXME notes. These FIXMEs are for QAPI developers. They
are not useful for QAPI schema developers. They are marked up as
admonitions, which makes them look important in generated HTML.
Turn them into comments. QAPI developers will still see them (they
read and write the .rst). QAP
MigrateSetParameters has a TODO comment sitting right behind its doc
comment. I wrote it this way to keep it out of the manual, but that
reason is not obvious.
The previous commit (sphinx/qapidoc: Do not emit TODO sections into
user manuals) lets me move it into the doc comment as a TODO section.
@qapi_gen_depends is missing scripts/qapi/main.py. Fix that, and drop
a duplicate scripts/qapi/common.py.
Signed-off-by: Markus Armbruster
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index c44d05a13f..ed24df2ade 100644
--- a/meso
The commit before previous relaxed the indentation rules to let us
improve the doc comment conventions. This commit changes the written
conventions. The next commits will update QAPI schemas to conform to
them.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 46
Change
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
#do eiusmod tempor incididunt ut labore et dolore magna aliqua.
to
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
# do eiusmod tempor incididunt ut labore et dolore mag
Section "Definition documentation" uses both single and double quotes
around doc text snippets. Stick to double quotes.
Signed-off-by: Markus Armbruster
---
docs/devel/qapi-code-gen.rst | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/devel/qapi-code-gen.rst
Documentation of dump-guest-memory contains two bulleted lists. The
first one is indented, the second one isn't. Delete the first one's
indentation for a more consistent look.
Signed-off-by: Markus Armbruster
---
qapi/dump.json | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
The QAPI generator doesn't reject undocumented members and
features (yet). doc-good.json covers this, with clear "is
undocumented" notes to signal intent.
Except for @Variant1 member @var1, where it's "(but no @var: line)".
Less clear. Replace by "@var1 is undocumented".
Signed-off-by: Markus A
When an argument's description starts on the line after the "#arg: "
line, indentation is stripped only from the description's first line,
as demonstrated by the previous commit. Moreover, subsequent lines
with less indentation are not rejected.
Make the first line's indentation the expected inde
Queued, thanks.
Paolo
When the lexer chokes on a stray character, its shows the characters
until the next structural character in the error message. It uses a
regular expression to match a non-empty string of non-structural
characters. Bug: the regular expression treats '"' as structural.
When the lexer chokes on '"',
This reverts commit 97cd74f77231f3897838f8db32b659d94803e01f.
The next commit will hide TODO: sections. See there for rationale.
Signed-off-by: Markus Armbruster
---
qapi/block-export.json | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qapi/block-export.json b/q
This series improves the doc comment formatting rules, then reformats
doc comments to conform to them.
I don't like reformatting code. But I'm tired of looking at ugly doc
comments. People imitate them in new work (not blaming them for
that), which leads to tiresome arguments about style. I've
QAPI doc comments are for QMP users: they go into the "QEMU QMP
Reference Manual" and the "QEMU Storage Daemon QMP Reference Manual".
The doc comment TODO sections are for somebody else, namely for the
people who can do: developers. Do not emit them into the user
manuals.
This elides the followi
The QAPI schema doc comment language provides special syntax for
command and event arguments, struct and union members, alternate
branches, enumeration values, and features: descriptions starting with
"@name:".
By convention, we format them like this:
# @name: Lorem ipsum dolor sit amet, cons
On 28/04/2023 12.34, Richard Henderson wrote:
Drop inline marker: let compiler decide.
Change return type to uint64_t: this matches the computation in the
return statement and the local variable assignment in the caller.
Rename local to dirty_ring_size_MB to fix typo.
Simplify conversion to MiB
Improve the comments to better describe what they test.
Cover argument description starting on a new line indented. This
style isn't documented in docs/devel/qapi-code-gen.rst. qapi-gen.py
accepts it, but messes up indentation: it's stripped from the first
line, not subsequent ones. The next co
Signed-off-by: Markus Armbruster
---
scripts/qapi/parser.py | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 3e29b7bf48..22ee631198 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/par
To recognize a line starting with a section symbol and or tag, we
first split it at the first space, then examine the part left of the
space. We can just as well examine the unsplit line, so do that.
Signed-off-by: Markus Armbruster
---
scripts/qapi/parser.py | 51 +++---
Forgot to mention: it's based on my "[PULL 00/17] QAPI patches patches
for 2023-04-28". Apologies!
The remaining use of mb_read/mb_set is just to force a thread to exit
eventually. It does not order two memory accesses and therefore can be
just read/set.
Signed-off-by: Paolo Bonzini
---
tests/unit/test-aio-multithread.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
Add new -run-with option with an async-teardown=on|off parameter. It
is visible in the output of query-command-line-options QMP command, so
it can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
v5->v6
* deprecate the old -async-teardown option instea
Add new -run-with option with an async-teardown=on|off parameter. It is
visible in the output of query-command-line-options QMP command, so it
can be discovered and used by libvirt.
The option -async-teardown is now redundant, deprecate it.
Reported-by: Boris Fiuczynski
Fixes: c891c24b1a ("os-po
1 - 100 of 310 matches
Mail list logo
