On 5/4/23 21:39, Taylor Simpson wrote:
This will facilitate adding additional tests in separate .c files
Signed-off-by: Taylor Simpson
---
tests/tcg/hexagon/hvx_misc.h | 178 ++
tests/tcg/hexagon/hvx_misc.c | 160 +--
tests/tcg/h
This patchset tries to fix some problems in current implementation for
mstatus.MPP
The port is available here:
https://github.com/plctlab/plct-qemu/tree/plct-mpp-fix-v2
v2:
* Modify commit message and add comment to specify MPP field becomes a WARL
field since priv version 1.11 in patch 2
* reb
mstatus.MPP field is a WARL field since priv version 1.11, so we
remain it unchanged if an invalid value is written into it. And
after this, RVH shouldn't be passed to riscv_cpu_set_mode().
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
---
target/riscv/cpu_helper.c | 5 +
target/ri
The MPP will be set to the least-privileged supported mode (U if
U-mode is implemented, else M).
Signed-off-by: Weiwei Li
Signed-off-by: Junqiang Wang
Reviewed-by: Alistair Francis
---
target/riscv/op_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/riscv/o
On 05/04/2023 18.04, Philippe Mathieu-Daudé wrote:
Protected Virtualization is specific to KVM.
Rename the file as 'pv-kvm.c' to make this clearer.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/{pv.c => pv-kvm.c} | 0
hw/s390x/meson.build| 2 +-
2 files changed, 1 insertion(+),
Fei Wu writes:
> The translation ratio of host to guest instruction count is one of the
> key performance factor of binary translation. TCG doesn't collect host
> instruction count at present, it does collect host instruction size
> instead, although they are not the same thing as instruction s
Fei Wu writes:
> It's only valid when inline=false, otherwise it's default to 0.
>
> Signed-off-by: Fei Wu
> ---
> contrib/plugins/hotblocks.c | 24 +++-
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotbl
On 4/6/23 09:50, Thomas Huth wrote:
On 05/04/2023 18.04, Philippe Mathieu-Daudé wrote:
Protected Virtualization is specific to KVM.
Rename the file as 'pv-kvm.c' to make this clearer.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/{pv.c => pv-kvm.c} | 0
hw/s390x/meson.build|
"Antonio Apostoliu" writes:
> Hello
>
>
>
> You are so kind to tell me how can I use qmp to send colon character . I
> speak about this character :
>
>
>
> I tried:
>
> {"execute":"send-key","arguments":{"keys":[{"type":"qcode","data":"shift-sem
> icolon"}]}}
Reply:
{"error": {"class":
On Wed, 29 Mar 2023 10:27:26 +0530
Ani Sinha wrote:
> i440fx machine versions 2.3 and newer supports dynamic ram
> resizing. See commit a1666142db6233 ("acpi-build: make ROMs RAM blocks
> resizeable") .
> Currently supported all q35 machine types (versions 2.4 and newer) supports
> resizable RAM
On 6/4/23 10:04, Janosch Frank wrote:
On 4/6/23 09:50, Thomas Huth wrote:
On 05/04/2023 18.04, Philippe Mathieu-Daudé wrote:
Protected Virtualization is specific to KVM.
Rename the file as 'pv-kvm.c' to make this clearer.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/{pv.c => pv-kvm.c
On 06/04/2023 10.22, Philippe Mathieu-Daudé wrote:
On 6/4/23 10:04, Janosch Frank wrote:
On 4/6/23 09:50, Thomas Huth wrote:
On 05/04/2023 18.04, Philippe Mathieu-Daudé wrote:
Protected Virtualization is specific to KVM.
Rename the file as 'pv-kvm.c' to make this clearer.
Signed-off-by: Phili
Yohei Kojima writes:
> On 2023/03/31 4:06, Markus Armbruster wrote:
>> Yohei Kojima writes:
>>
>>> Add qemu_strerror() which follows the POSIX specification for
>>> strerror(). While strerror() is not guaranteed to be thread-safe, this
>>> function is thread-safe.
>>
>> Why not g_strerror()?
Philippe Mathieu-Daudé writes:
> All types used are forward-declared in "qemu/typedefs.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Philippe Mathieu-Daudé writes:
> Avoid when calling kvm_direct_msi_enabled() from
> arm_gicv3_its_common.c the next commit:
>
> Undefined symbols for architecture arm64:
> "_kvm_direct_msi_allowed", referenced from:
> _its_class_name in hw_intc_arm_gicv3_its_common.c.o
> ld: sym
On Thu, 6 Apr 2023 at 07:57, Thomas Huth wrote:
>
> On 05/04/2023 17.15, Peter Maydell wrote:
> > The s390 private runner CI job ubuntu-20.04-s390x-all seems to have
> > started timing out a lot recently. Here's an example where it passed,
> > but with only 53 seconds left on the clock before it w
Add PCI based MEN Chameleon Bus carrier emulation.
Signed-off-by: Johannes Thumshirn
---
hw/mcb/Kconfig | 6 +
hw/mcb/mcb-pci.c| 297
hw/mcb/meson.build | 1 +
hw/mcb/trace-events | 3 +
hw/mcb/trace.h | 1 +
meson.build
The MEN Chameleon Bus (MCB) is an on-chip bus system exposing IP Cores of an
FPGA to a outside bus system like PCIe.
Acked-by: Alistair Francis
Signed-off-by: Johannes Thumshirn
---
MAINTAINERS | 6 ++
hw/Kconfig | 1 +
hw/mcb/Kconfig | 2 +
hw/mcb/mcb.c |
Add emulation of MEN Chameleon Hardware to Qemu.
This emulation is specifically designed to test the upstream Linux kernel
drivers when one has no access to the hardware.
The emulation consists of the bus itself, a PCI hardware target creating the
bus, MEN Micro Electronic's 8250 based UART via MC
Add MEN z125 UART over MEN Chameleon Bus emulation.
Acked-by: Alistair Francis
Signed-off-by: Johannes Thumshirn
---
hw/char/Kconfig | 6 +++
hw/char/meson.build | 1 +
hw/char/serial-mcb.c | 115 +++
3 files changed, 122 insertions(+)
create m
Add 16z069 Watchdog over MEN Chameleon BUS emulation.
Signed-off-by: Johannes Thumshirn
---
hw/watchdog/Kconfig | 5 +
hw/watchdog/meson.build | 1 +
hw/watchdog/wdt_z069.c | 218
3 files changed, 224 insertions(+)
create mode 100644 hw/watchdog
We are a bit premature in recommending -blockdev/-device as the best
way to configure block devices. It seems there are times the more
human friendly -drive still makes sense especially when -snapshot is
involved.
Improve the language to hopefully make things clearer.
Suggested-by: Michael Tokare
Add separate macro EXTIOI_CPUS for extioi interrupt controller, extioi
only supports 4 cpu. And set macro LOONGARCH_MAX_CPUS as 256 so that
loongarch virt machine supports more cpus.
Interrupts from external devices can only be routed cpu 0-3 because
of extioi limits, cpu internal interrupt such a
ipi is used to communicate between cpus, this patch modified
loongarch ipi device as percpu deivce, so that there are
2 MemoryRegions with ipi device, rather than 2*cpus
MemoryRegions, which may be large than QDEV_MAX_MMIO if
more cpus are added on loongarch virt machine.
Signed-off-by: Song Gao
When ipi mailbox is used, cpu index is decoded from iocsr register.
cpu maybe does not exist. This patch adss NULL pointer check on
ipi device.
Signed-off-by: Song Gao
---
hw/intc/loongarch_ipi.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git
On Thu, 6 Apr 2023 at 10:34, Johannes Thumshirn wrote:
>
> The MEN Chameleon Bus (MCB) is an on-chip bus system exposing IP Cores of an
> FPGA to a outside bus system like PCIe.
>
> Acked-by: Alistair Francis
> Signed-off-by: Johannes Thumshirn
> @@ -0,0 +1,182 @@
> +/*
> + * QEMU MEN Chameleon
There is already a barrier in AIO_WAIT_WHILE_INTERNAL(), thus the
qatomic_mb_read() is not adding anything.
Signed-off-by: Paolo Bonzini
---
block/block-backend.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 2ee39229e
Replace with an explicit barrier and a comment.
Signed-off-by: Paolo Bonzini
---
util/qemu-coroutine.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c
index 849452369201..17a88f65053e 100644
--- a/util/qemu-coroutine.c
Signed-off-by: Paolo Bonzini
---
block/nfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
index 351dc6ec8d14..0ee63f44deb0 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -727,8 +727,8 @@ nfs_get_allocated_file_size_cb(int ret, struct nfs_context
It does not even pair with a qatomic_mb_set(), so it is clearer to use
load-acquire in this case; they are synonyms.
Signed-off-by: Paolo Bonzini
---
migration/postcopy-ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
i
- Trap satp/hgatp accesses from HS-mode when MSTATUS.TVM is enabled.
- Trap satp accesses from VS-mode when HSTATUS.VTVM is enabled.
- Raise RISCV_EXCP_ILLEGAL_INST when U-mode executes SFENCE.VMA/SINVAL.VMA.
- Raise RISCV_EXCP_VIRT_INSTRUCTION_FAULT when VU-mode executes
SFENCE.VMA/SINVAL.VMA or
After the recent introduction of many new coroutine callbacks,
a couple calls from non-coroutine_fn to coroutine_fn have sneaked
in; fix them.
Signed-off-by: Paolo Bonzini
---
block/mirror.c | 4 ++--
include/block/graph-lock.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(
> -Original Messages-
> From: "Alistair Francis"
> Sent Time: 2023-04-06 09:56:58 (Thursday)
> To: "Yi Chen"
> Cc: qemu-devel@nongnu.org, "Weiwei Li" , "Palmer
> Dabbelt" , "Alistair Francis" ,
> "Bin Meng" , "Daniel Henrique Barboza"
> , "Liu Zhiwei" ,
> "open list:RISC-V TCG CPUs
On Fri, 17 Mar 2023 16:54:36 +
Jonathan Cameron via wrote:
> Michael Tsirkin raised that we have recently had churn in the bios-tables-test
> and perhaps it was worth factoring some parts of DSDT out as SSDT files.
> This is an attempt to do that for the entries from pxb-pcie and pxb-cxl
> PC
There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path. By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn ma
There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path. By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn ma
There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path. By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn ma
On Thu, 6 Apr 2023 at 06:08, Paolo Bonzini wrote:
>
> There is already a barrier in AIO_WAIT_WHILE_INTERNAL(), thus the
> qatomic_mb_read() is not adding anything.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/block-backend.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed
On Wed, 5 Apr 2023 15:57:38 +0530
Raghu H wrote:
Hi Raghu,
Thanks for tidying this up! (and reporting it in the first place)
A few minor comments for v2.
A better title might be
docs/cxl: Remove incorrect CXL type 3 size parameter.
> cxl device typ3 size is read from the memory backend device
Am 06.04.23 um 11:21 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 07:57, Thomas Huth wrote:
On 05/04/2023 17.15, Peter Maydell wrote:
The s390 private runner CI job ubuntu-20.04-s390x-all seems to have
started timing out a lot recently. Here's an example where it passed,
but with only 53 s
On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
wrote:
> Am 06.04.23 um 11:21 schrieb Peter Maydell:
> > Christian, does our S390X machine get a guaranteed amount of CPU,
> > or does it depend on what else is running on the hardware?
>
> I think its a shared system with shared CPUs. Can you che
On Thu, 6 Apr 2023 at 06:09, Paolo Bonzini wrote:
>
> Signed-off-by: Paolo Bonzini
> ---
> block/nfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
On Thu, 6 Apr 2023 at 06:09, Paolo Bonzini wrote:
>
> Replace with an explicit barrier and a comment.
>
> Signed-off-by: Paolo Bonzini
> ---
> util/qemu-coroutine.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c
>
Am 06.04.23 um 12:44 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
wrote:
Am 06.04.23 um 11:21 schrieb Peter Maydell:
Christian, does our S390X machine get a guaranteed amount of CPU,
or does it depend on what else is running on the hardware?
I think its a shared
Lukáš Doktor wrote:
> Fio job (executed via pbench, let me know if you need simplified steps with
> fio only):
That would be useful, thanks.
I suspect revert is useless because upcoming TCP_NODELAY change will increase
small packet rate too.
Current codes using a brute-force traversal of all file descriptors
do not scale on a system where the maximum number of file descriptors
are set to a very large value (e.g.: in a Docker container of Manjaro
distribution it is set to 1073741816). QEMU just looks freezed during
start-up.
The close-
On Thu, 2023-04-06 at 02:40 -0400, Yang Zhong wrote:
> The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with
> FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):{ECX,EDX}, which made
> SGX enclave only supported SSE and x87 feature(xfrm=0x3).
I don't particularly like the sentence's second
On Tue, 4 Apr 2023 12:46:45 +0200
Gerd Hoffmann wrote:
> On Tue, Apr 04, 2023 at 10:30:55AM +0200, Igor Mammedov wrote:
> > On Tue, 4 Apr 2023 09:03:59 +0200
> > Gerd Hoffmann wrote:
> >
> > > Hi,
> > >
> > > > > Allowing pending delete expire brings ACPI PCI hotplug on par
> > > > > wit
On Thu, Apr 06, 2023 at 01:46:48PM +0200, Igor Mammedov wrote:
> On Tue, 4 Apr 2023 12:46:45 +0200
> Gerd Hoffmann wrote:
>
> > On Tue, Apr 04, 2023 at 10:30:55AM +0200, Igor Mammedov wrote:
> > > On Tue, 4 Apr 2023 09:03:59 +0200
> > > Gerd Hoffmann wrote:
> > >
> > > > Hi,
> > > >
> >
Queued, thanks.
Paolo
On Thu, 6 Apr 2023 at 12:17, Christian Borntraeger
wrote:
>
> Am 06.04.23 um 12:44 schrieb Peter Maydell:
> > On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
> > wrote:
> >> Am 06.04.23 um 11:21 schrieb Peter Maydell:
> >>> Christian, does our S390X machine get a guaranteed amount of CPU,
> >>
HI, Richard
在 2023/3/29 上午4:46, Richard Henderson 写道:
+static void do_vmuh_s(unsigned vece, uint32_t vd_ofs, uint32_t vj_ofs,
+ uint32_t vk_ofs, uint32_t oprsz, uint32_t maxsz)
+{
+ static const GVecGen3 op[4] = {
+ {
+ .fno = gen_helper_vmuh_b,
+
Am 06.04.23 um 14:05 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 12:17, Christian Borntraeger
wrote:
Am 06.04.23 um 12:44 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
wrote:
Am 06.04.23 um 11:21 schrieb Peter Maydell:
Christian, does our S390X machine get a
On Thu, 20 Oct 2022 at 13:21, Peter Maydell wrote:
>
> From: Richard Henderson
>
> Add a field to TARGET_PAGE_ENTRY_EXTRA to hold the guarded bit.
> In is_guarded_page, use probe_access_full instead of just guessing
> that the tlb entry is still present. Also handles the FIXME about
> executing
On Thu, 6 Apr 2023 at 13:13, Christian Borntraeger
wrote:
>
>
>
> Am 06.04.23 um 14:05 schrieb Peter Maydell:
> > On Thu, 6 Apr 2023 at 12:17, Christian Borntraeger
> > wrote:
> >>
> >> Am 06.04.23 um 12:44 schrieb Peter Maydell:
> >>> On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
> >>> wro
On 06/04/2023 14.13, Christian Borntraeger wrote:
Am 06.04.23 um 14:05 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 12:17, Christian Borntraeger
wrote:
Am 06.04.23 um 12:44 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 11:40, Christian Borntraeger
wrote:
Am 06.04.23 um 11:21 schrieb Peter
On 6/4/23 13:20, Bin Meng wrote:
Current codes using a brute-force traversal of all file descriptors
do not scale on a system where the maximum number of file descriptors
are set to a very large value (e.g.: in a Docker container of Manjaro
distribution it is set to 1073741816). QEMU just looks f
On Thu, 6 Apr 2023 at 13:30, Thomas Huth wrote:
> The thing is: it shouldn't take that long to build QEMU and run the tests
> here, theoretically. Some days ago, the job was finishing in 39 minutes:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/3973481571
>
> The recent run took 74 minutes:
>
Am 06.04.23 um 14:30 schrieb Thomas Huth:
On 06/04/2023 14.13, Christian Borntraeger wrote:
Am 06.04.23 um 14:05 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 12:17, Christian Borntraeger
wrote:
Am 06.04.23 um 12:44 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 11:40, Christian Borntraeg
Am 06.04.23 um 14:39 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 13:30, Thomas Huth wrote:
The thing is: it shouldn't take that long to build QEMU and run the tests
here, theoretically. Some days ago, the job was finishing in 39 minutes:
https://gitlab.com/qemu-project/qemu/-/jobs/39734
On 2023/04/06 17:57, Alex Bennée wrote:
>
> Yohei Kojima writes:
>
>> On 2023/03/31 4:06, Markus Armbruster wrote:
>>> Yohei Kojima writes:
>>>
Add qemu_strerror() which follows the POSIX specification for
strerror(). While strerror() is not guaranteed to be thread-safe, this
f
On Thu, Apr 6, 2023 at 8:34 PM Philippe Mathieu-Daudé wrote:
>
> On 6/4/23 13:20, Bin Meng wrote:
> > Current codes using a brute-force traversal of all file descriptors
> > do not scale on a system where the maximum number of file descriptors
> > are set to a very large value (e.g.: in a Docker c
Allow the Linux guest agent to attempt each of the suspend methods
(systemctl, pm-* and writing to /sys) in turn.
Prior to this guests without systemd failed to suspend due to
`guest_suspend` returning early regardless of the return value of
`systemd_supports_mode`.
Signed-off-by: Mark Somerville
cxl-type3 memory size is read directly from the provided memory backed end
device. Remove non existent size option
Signed-off-by: Raghu H
---
docs/system/devices/cxl.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/
Thanks Jonathan for quick review/comments on earlier patch, as suggested
splitting into two separate patches
https://www.mail-archive.com/qemu-devel@nongnu.org/msg952999.html
Removed the unsupported size option for cxl-type3 device, Qemu reads
the device size directly from the backend memory devic
Currently Qemu CXL emulation support is not availabe on AARCH64 but its
available with qemu x86_64 architecture, updating the document to reflect
the supported platform.
Signed-off-by: Raghu H
---
docs/system/devices/cxl.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --
On Mon, 13 Mar 2023 at 11:47, wrote:
>
> From: Marc-André Lureau
>
> This can help debugging issues or develop, when error handling is
> introduced.
>
> Signed-off-by: Marc-André Lureau
> Reviewed-by: Stefan Berger
> Message-Id: <20230221124802.4103554-6-marcandre.lur...@redhat.com>
Hi; Coveri
On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote:
>
> On Mon, 13 Mar 2023 at 11:47, wrote:
> >
> > From: Marc-André Lureau
> >
> > This can help debugging issues or develop, when error handling is
> > introduced.
> >
> > Signed-off-by: Marc-André Lureau
> > Reviewed-by: Stefan Berger
> > Messa
The event filename is an absolute path. Convert it to a relative path when
writing '#line' directives, to preserve reproducibility of the generated
output when different base paths are used.
Signed-off-by: Thomas De Schampheleire
---
scripts/tracetool/backend/ftrace.py | 4 +++-
scripts/tracetoo
Hello,
I am trying to use qemu to run ROCm in a virtual machine via GPU
passthrough with vfio-pci. While this mostly works out of the box, ROCm
requires PCIe atomics to function properly, and it seems like that this
is a feature that is missing in qemu. The setup is using a simple PCie
topolo
Currently Qemu CXL emulation support is not availabe on AARCH64 but its
available with qemu x86_64 architecture, updating the document to reflect
the supported platform.
Signed-off-by: Raghu H
---
docs/system/devices/cxl.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
cxl-type3 memory size is read directly from the provided memory backed end
device. Remove non existent size option
Signed-off-by: Raghu H
---
docs/system/devices/cxl.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/
Thanks Jonathan for quick review/comments on earlier patch, as suggested
splitting into two separate patches
https://www.mail-archive.com/qemu-devel@nongnu.org/msg952999.html
Removed the unsupported size option for cxl-type3 device, Qemu reads
the device size directly from the backend memory devic
On 4/6/23 09:17, Peter Maydell wrote:
On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote:
On Mon, 13 Mar 2023 at 11:47, wrote:
From: Marc-André Lureau
This can help debugging issues or develop, when error handling is
introduced.
Signed-off-by: Marc-André Lureau
Reviewed-by: Stefan Berg
Am 06.04.23 um 14:39 schrieb Peter Maydell:
On Thu, 6 Apr 2023 at 13:30, Thomas Huth wrote:
The thing is: it shouldn't take that long to build QEMU and run the tests
here, theoretically. Some days ago, the job was finishing in 39 minutes:
https://gitlab.com/qemu-project/qemu/-/jobs/39734
On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote:
> I'll be out starting tomorrow. I don't see Marc-André online.
>
> Would this be acceptable?
> It ensures that if error_handle() returns, err has been freed.
> In the other two cases a copy is being made of the Error that can then be
> used after
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Thursday, April 6, 2023 2:24 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: richard.hender...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain
> ; Matheus Bernardino (QUIC)
>
> Subject: Re: [PATCH] Hexagon (tests/tcg/hex
Alex Bennée writes:
> We are a bit premature in recommending -blockdev/-device as the best
> way to configure block devices. It seems there are times the more
> human friendly -drive still makes sense especially when -snapshot is
> involved.
>
> Improve the language to hopefully make things clear
On 4/6/23 10:36, Peter Maydell wrote:
On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote:
I'll be out starting tomorrow. I don't see Marc-André online.
Would this be acceptable?
It ensures that if error_handle() returns, err has been freed.
In the other two cases a copy is being made of the E
On Thu, Apr 06, 2023 at 09:54:55AM +0300, Michael Tokarev wrote:
> 06.04.2023 09:48, Thomas Huth пишет:
> ..>> There's one minor caveat still, though: it is missing in the
> > > "Full list of releases" for whatever reason. Dunno how that
> > > happened, maybe that page hasn't been (re)generated ye
On Thu, 6 Apr 2023 at 16:00, Stefan Berger wrote:
>
>
>
> On 4/6/23 10:36, Peter Maydell wrote:
> > On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote:
> >> I'll be out starting tomorrow. I don't see Marc-André online.
> >>
> >> Would this be acceptable?
> >> It ensures that if error_handle() retur
On Thu, Apr 06, 2023 at 12:55:38PM +0200, Lukáš Doktor wrote:
> Hello Florian, folks,
>
> my CI caught ~5% regression (in 60s runs, when using 240s it was about 10%)
> in qemu-nbd performance bisected multiple-times up to
> bd2cd4a441ded163b62371790876f28a9b834317 in fio when using 4k blocks rea
On Thu, Apr 06, 2023 at 08:48:34AM +0200, Thomas Huth wrote:
> On 06/04/2023 08.33, Michael Tokarev wrote:
> > 06.04.2023 00:06, Michael Roth пишет:
> > ..
> > > Re-packaged tarball based on your 7.2.1 tag is now uploaded:
> > >
> > > https://www.qemu.org/download/
> >
> > Thank you Michael!
So that we can avoid the "older gdb crashes" problem described in
commit 5787d17a42f7af4 and which caused us to disable reporting pauth
information via the gdbstub, newer gdb is going to implement support
for recognizing the pauth information via a new feature name:
org.gnu.gdb.aarch64.pauth_v2
O
Stefan Berger writes:
> On 4/6/23 09:17, Peter Maydell wrote:
>> On Thu, 6 Apr 2023 at 14:16, Peter Maydell wrote:
>>>
>>> On Mon, 13 Mar 2023 at 11:47, wrote:
From: Marc-André Lureau
This can help debugging issues or develop, when error handling is
introduced.
>>
On Tue, 7 Mar 2023 at 18:28, David Woodhouse wrote:
>
> From: David Woodhouse
>
> There's no need for this to be in the Xen accel code, and as we want to
> use the Xen console support with KVM-emulated Xen we'll want to have a
> platform-agnostic version of it. Make it use GString to build up the
Ping? This should go in rc4, there is not much time left to prepare a
PULL...
Best Regards,
Lukas Straub
On Tue, 4 Apr 2023 14:36:03 +
Lukas Straub wrote:
> Since ec6f3ab9, migration with compress enabled was broken, because
> the compress threads use a dummy QEMUFile which just acts as a
>
Hi
On Thu, Apr 6, 2023 at 7:00 PM Stefan Berger wrote:
>
>
>
> On 4/6/23 10:36, Peter Maydell wrote:
> > On Thu, 6 Apr 2023 at 15:13, Stefan Berger wrote:
> >> I'll be out starting tomorrow. I don't see Marc-André online.
> >>
> >> Would this be acceptable?
> >> It ensures that if error_handle()
Coverity points out (in CID 1508390) that write_bootloader has
some dead code, where we assign to 'p' and then in the following
line assign to it again. This happened as a result of the
refactoring in commit cd5066f8618b.
Fix the dead code by removing the 'void *v' variable entirely and
instead ad
Fix use-after-free errors in the code path that called error_handle(). A
call to error_handle() will now either free the passed Error 'err' or
assign it to '*errp' if '*errp' is currently NULL. This ensures that 'err'
either has been freed or is assigned to '*errp' if this function returns.
Adjust
On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote:
>
> From: David Woodhouse
>
> The way that Xen handles MSI PIRQs is kind of awful.
> Now that this is working we can finally enable XENFEAT_hvm_pirqs and
> let the guest use it all.
>
Hi; Coverity points out a logic error in this code (CID 15076
On Thu, 6 Apr 2023 at 16:43, Stefan Berger wrote:
>
> Fix use-after-free errors in the code path that called error_handle(). A
> call to error_handle() will now either free the passed Error 'err' or
> assign it to '*errp' if '*errp' is currently NULL. This ensures that 'err'
> either has been free
On 6/4/23 17:37, Peter Maydell wrote:
Coverity points out (in CID 1508390) that write_bootloader has
some dead code, where we assign to 'p' and then in the following
line assign to it again. This happened as a result of the
refactoring in commit cd5066f8618b.
Fix the dead code by removing the 'v
On 6/4/23 17:43, Stefan Berger wrote:
Fix use-after-free errors in the code path that called error_handle(). A
call to error_handle() will now either free the passed Error 'err' or
assign it to '*errp' if '*errp' is currently NULL. This ensures that 'err'
either has been freed or is assigned to '
Coverity complains (CID 1507880) that the declaration "int error_code;"
in mmu_translate() is unreachable code. Since this is only a declaration,
this isn't actually a bug, but:
* it's a bear-trap for future changes, because if it was changed to
include an initialization 'int error_code = foo;'
Hi
On Thu, Apr 6, 2023 at 7:43 PM Stefan Berger wrote:
>
> Fix use-after-free errors in the code path that called error_handle(). A
> call to error_handle() will now either free the passed Error 'err' or
> assign it to '*errp' if '*errp' is currently NULL. This ensures that 'err'
> either has bee
On Mon, 7 Nov 2022 at 22:53, Michael S. Tsirkin wrote:
>
> From: Jason Wang
>
> This patch introduce ECAP_PASID via "x-pasid-mode".
Hi; Coverity points out an issue with this code (CID 1508100):
> -static guint vtd_uint64_hash(gconstpointer v)
> +static guint vtd_iotlb_hash(gconstpointer v)
>
On Thu, 2023-04-06 at 16:48 +0100, Peter Maydell wrote:
> On Thu, 2 Mar 2023 at 12:37, Paolo Bonzini wrote:
> >
> > From: David Woodhouse
> >
> > The way that Xen handles MSI PIRQs is kind of awful.
>
> > Now that this is working we can finally enable XENFEAT_hvm_pirqs and
> > let the guest us
Peter Xu writes:
> On Tue, Apr 04, 2023 at 05:10:52PM +0200, Claudio Fontana wrote:
>> On 4/4/23 16:53, Peter Xu wrote:
>> > On Tue, Apr 04, 2023 at 10:00:16AM +0200, Claudio Fontana wrote:
>> >> Hi Peter,
>> >
>> > Hi, Claudio,
>> >
>> >>
>> >> On 4/3/23 21:26, Peter Xu wrote:
>> >>> Hi, Claud
On 05.04.23 11:59, Vladimir Sementsov-Ogievskiy wrote:
On 04.04.23 20:32, Hanna Czenczek wrote:
On 04.04.23 10:10, Vladimir Sementsov-Ogievskiy wrote:
On 03.04.23 16:33, Hanna Czenczek wrote:
(Sorry for the rather late reply... Thanks for the review!)
On 20.03.23 11:31, Vladimir Sementsov-Ogi
1 - 100 of 166 matches
Mail list logo
