Re: [PATCH v4] hostmem-file: add offset option

On 01.04.23 19:47, Stefan Hajnoczi wrote: On Sat, Apr 01, 2023 at 12:42:57PM +, Alexander Graf wrote: Add an option for hostmem-file to start the memory object at an offset into the target file. This is useful if multiple memory objects reside inside the same target file, such as a device no

Re: [PATCH 01/14] ram.c: Let the compress threads return a CompressResult enum

On 2/4/23 19:56, Lukas Straub wrote: This will be used in the next commits to move save_page_header() out of compress code. Signed-off-by: Lukas Straub --- migration/ram.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/migration/ram.c

Re: [PATCH 10/14] ram.c: Move core decompression code into its own file

On 2/4/23 19:56, Lukas Straub wrote: No functional changes intended. Signed-off-by: Lukas Straub --- migration/ram-compress.c | 203 ++ migration/ram-compress.h | 5 + migration/ram.c | 204 --- 3 files chan

Re: [PATCH 13/14] ram-compress.c: Make target independent

On 2/4/23 19:56, Lukas Straub wrote: Make ram-compress.c target independent. Signed-off-by: Lukas Straub --- migration/meson.build| 2 +- migration/ram-compress.c | 16 +--- 2 files changed, 10 insertions(+), 8 deletions(-) \o/ Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 12/14] ram.c: Remove unused include after moving out code

On 2/4/23 19:56, Lukas Straub wrote: Signed-off-by: Lukas Straub --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 7a8f540737..9072d70f7c 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -32,7 +32,6 @@ #include "qemu/bitmap.h

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

On 30.03.23 20:03, Fabiano Rosas wrote: Hi folks, I'm continuing the work done last year to add a new format of migration stream that can be used to migrate large guests to a single file in a performant way. This is an early RFC with the previous code + my additions to support multifd and direc

[PATCH v4 1/7] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq()

xen_piix3_set_irq() isn't PIIX specific: PIIX is a single PCI device while xen_piix3_set_irq() maps multiple PCI devices to their respective IRQs, which is board-specific. Rename xen_piix3_set_irq() to communicate this. Also rename XEN_PIIX_NUM_PIRQS to XEN_IOAPIC_NUM_PIRQS since the Xen's IOAPIC

[PATCH v4 7/7] hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE

During the last patches, TYPE_PIIX3_XEN_DEVICE turned into a clone of TYPE_PIIX3_DEVICE. Remove this redundancy. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20230312120221.99183-7-shen...@gmail.com> --- i

[PATCH v4 5/7] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config()

Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for having a common piix3_write_config() for the PIIX3 device models. While at it, move the subscription into machine code to facilitate resolving TYPE_PIIX3_XEN_DEVICE. In a possible future followup, pci_bus_fire_intx_routing

[PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

There is currently a dedicated PIIX3 device model for use under Xen. By reusing existing PCI API during initialization this device model can be eliminated and the plain PIIX3 device model can be used instead. Resolving TYPE_PIIX3_XEN_DEVICE results in less code while also making Xen agnostic towar

[PATCH v4 2/7] hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs()

When calling pci_bus_irqs() multiple times on the same object without calling pci_bus_irqs_cleanup() in between PCIBus::irq_count[] is currently leaked. Let's fix this because Xen will do just that in a few commits, and because calling pci_bus_irqs_cleanup() in between seems fragile and cumbersome.

[PATCH v4 4/7] hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3

xen_intx_set_irq() doesn't depend on PIIX3State. In order to resolve TYPE_PIIX3_XEN_DEVICE and in order to make Xen agnostic about the precise south bridge being used, set up Xen's PCI IRQ handling of PIIX3 in the board. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by

[PATCH v4 6/7] hw/isa/piix3: Resolve redundant k->config_write assignments

The previous patch unified handling of piix3_write_config() accross the PIIX3 device models which allows for assigning k->config_write once in the base class. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Anthony PERARD Tested-by: Chuck Zmudzinski Message-Id: <20

[PATCH v4 3/7] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()

This is a preparational patch for the next one to make the following more obvious: First, pci_bus_irqs() is now called twice in case of Xen where the second call overrides the pci_set_irq_fn with the Xen variant. Second, pci_bus_set_route_irq_fn() is now also called in Xen mode. Signed-off-by: B

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

On 3/31/23 23:52, Peter Xu wrote: > On Fri, Mar 31, 2023 at 03:18:37PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >>> On Fri, Mar 31, 2023 at 05:10:16PM +0100, Daniel P. Berrangé wrote: On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: > On Fri, Mar 31, 2023 at 12:30:45PM

Re: [PATCH 1/3] target/arm: Pass ARMMMUFaultInfo to merge_syn_data_abort()

On 31/3/23 16:50, Peter Maydell wrote: We already pass merge_syn_data_abort() two fields from the ARMMMUFaultInfo struct, and we're about to want to use a third field. Refactor to just pass a pointer to the fault info. Signed-off-by: Peter Maydell --- target/arm/tcg/tlb_helper.c | 15 +++-

Re: [PATCH] MAINTAINERS: Add Eugenio Pérez as vhost-shadow-virtqueue reviewer

On 31/3/23 17:04, Eugenio Pérez wrote: I'd like to be notified on SVQ patches and review them. Signed-off-by: Eugenio Pérez --- MAINTAINERS | 4 1 file changed, 4 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

On 30/3/23 12:11, Alex Bennée wrote: We don't update these often but if you are the sort of person who enjoys debating and tuning project policies you could now add yourself as a reviewer here so you don't miss the next debate over tabs vs spaces ;-) Who's with me? Signed-off-by: Alex Bennée C

Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()

Am 1. April 2023 22:36:45 UTC schrieb Bernhard Beschow : > > >Am 30. März 2023 13:00:25 UTC schrieb Anthony PERARD >: >>On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: >>> This is a preparational patch for the next one to make the following >>> more obvious: >>> >>> First, pc

Re: [PATCH 2/3] accel/tcg: Fix overwrite problems of tcg_cflags

On 1/4/23 06:51, Richard Henderson wrote: From: Weiwei Li CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which tcg_cflags will be overwrited by tcg_cpu_init_cflags(). The description makes sense, but I couldn't reproduce using: -- >8 -- diff --git a/accel/tcg/tcg-accel-ops

Re: [RFC PATCH v3 1/2] mm: restrictedmem: Allow userspace to specify mount for memfd_restricted

On 01.04.23 01:50, Ackerley Tng wrote: By default, the backing shmem file for a restrictedmem fd is created on shmem's kernel space mount. With this patch, an optional tmpfs mount can be specified via an fd, which will be used as the mountpoint for backing the shmem file associated with a restri

Re: [RFC PATCH v3 2/2] selftests: restrictedmem: Check hugepage-ness of shmem file backing restrictedmem fd

On 01.04.23 01:50, Ackerley Tng wrote: For memfd_restricted() calls without a userspace mount, the backing file should be the shmem mount in the kernel, and the size of backing pages should be as defined by system-wide shmem configuration. If a userspace mount is provided, the size of backing pa

Re: [PATCH 09/16] hw/i3c/aspeed_i3c: Add data TX and RX

Hi Joe, > +static uint8_t aspeed_i3c_device_target_addr(AspeedI3CDevice *s, > + uint16_t offset) > +{ > +    if (offset > ASPEED_I3C_NR_DEVICES) { > +    qemu_log_mask(LOG_GUEST_ERROR, "%s: Device addr table offset %d out > of " > + 

Re: xen bits broke x32 build

On Mon, 2023-04-03 at 08:46 +0200, Philippe Mathieu-Daudé wrote: > > > Well. Maybe xen support should be disabled entirely on x32. > > > Or maybe x32 should be declared as unsupported entirely. > > > I dunno. > > > > We rely heavily on the struct layouts being precisely the same, > > since these a

Re: On integrating LoongArch EDK2 firmware into QEMU build process

Cc to Chao Li who is maintainer of edk2 about LoongArch support. Hi Chao, Fedora38 is used to build edk2 binary in qemu CI, cross gcc-12 is integrated on Fedora38. There is one issue when gcc-12 is used to build edk2 loongarch like this: > ... but when trying to use them to compile the loongarch

property 'cxl-type3.size' not found

Hello, I am trying qemu-system-aarch64 & cxl configuration listed in https://www.qemu.org/docs/master/system/devices/cxl.html qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ ... -object memory-backend-file,id=cxl-mem0,share=on,mem-path=/tmp/cxltest.raw,size=25

Re: [PATCH 2/3] accel/tcg: Fix overwrite problems of tcg_cflags

On 2023/4/3 16:09, Philippe Mathieu-Daudé wrote: On 1/4/23 06:51, Richard Henderson wrote: From: Weiwei Li CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which tcg_cflags will be overwrited by tcg_cpu_init_cflags(). The description makes sense, but I couldn't reproduce u

Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()

On Sat, Apr 01, 2023 at 10:36:45PM +, Bernhard Beschow wrote: > > > Am 30. März 2023 13:00:25 UTC schrieb Anthony PERARD > : > >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: > >> This is a preparational patch for the next one to make the following > >> more obvious: > >>

Re: property 'cxl-type3.size' not found

Cc'ing CXL maintainers. On 3/4/23 11:04, Maverickk 78 wrote: Hello, I am trying qemu-system-aarch64 & cxl configuration listed in https://www.qemu.org/docs/master/system/devices/cxl.html qemu-system-aarch64 -M virt,gic-version=3,cxl

Re: property 'cxl-type3.size' not found

On Mon, 3 Apr 2023 14:34:33 +0530 Maverickk 78 wrote: > Hello, > > I am trying qemu-system-aarch64 & cxl configuration listed in > > https://www.qemu.org/docs/master/system/devices/cxl.html > > qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 > -cpu max \ > ... > -objec

Re: [PATCH v2 2/5] apic: add support for x2APIC mode

On Wed, 2023-03-29 at 22:30 +0700, Bui Quang Minh wrote: > > > > > I do some more testing on my hardware, your point is correct when dest > > == 0x, the interrupt is delivered to all APICs regardless of > > their mode. > > To be precisely, it only broadcasts to CPUs in xAPIC mode if th

Re: [edk2-devel] On integrating LoongArch EDK2 firmware into QEMU build process

On 03/04/2023 11:13, Chao Li wrote: This problem is because the gcc-12 does not yet to support the option 'mno-explicit-reloc', this option is used to open the new reloaction type for LoongArch, this new feature is very important for LoongArch, because it can reduce the binary size and improve

Re: property 'cxl-type3.size' not found

Hi Jonathan Do you want me to modify the doc(remove size)? I can do that. Regards Raghu On Mon, 3 Apr 2023, 15:12 Jonathan Cameron, wrote: > On Mon, 3 Apr 2023 14:34:33 +0530 > Maverickk 78 wrote: > > > Hello, > > > > I am trying qemu-system-aarch64 & cxl configuration listed in > > > > https

Re: [PATCH 2/3] accel/tcg: Fix overwrite problems of tcg_cflags

On 4/3/23 11:09, liweiwei wrote: On 2023/4/3 16:09, Philippe Mathieu-Daudé wrote: cflags |= parallel ? CF_PARALLEL : 0; cflags |= icount_enabled() ? CF_USE_ICOUNT : 0; +    tcg_debug_assert(!cpu->tcg_cflags); cpu->tcg_cflags = cflags;  } --- Li and Junqiang, what is your use c

Re: [PATCH v9] audio/pwaudio.c: Add Pipewire audio backend for QEMU

Hi Marc-André, ...but queue 0. Look like you don't need the memset() after all. I thought so too, however Volker wanted it there. I understand it may be desirable to have a trace for stream state > change. But the implementation could be simpler, no switch involved, > and easier to read, simply

[RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

This patchset implements the entropy leak reporting feature proposal [1] for virtio-rng devices. Entropy leaking (as defined in the specification proposal) typically happens when we take a snapshot of a VM or while we resume a VM from a snapshot. In these cases, we want to let the guest know so th

[RFC PATCH 1/1] virtio-rng: implement entropy leak feature

Entropy leak reporting is a virtio-rng proposed feature [1], which allows a virtio-rng device to report events during which entropy has decreased, for example when a VM gets snapshotted or resumed from a snapshot. Guests can request from the virtio-rng device to perform two types of events upon su

Re: [edk2-devel] On integrating LoongArch EDK2 firmware into QEMU build process

On Mon, Apr 03, 2023 at 06:13:41PM +0800, Chao Li wrote: > Hi Bibo, > > gcc-13 will support this new feature, so we expect this issue to be resolved > when using gcc-13, which may be released at this month. > > If Fedora38 does not plan to use gcc-13 now, I suggest that CI can download > a LoongA

Re: [PATCH 01/14] ram.c: Let the compress threads return a CompressResult enum

On Mon, 3 Apr 2023 09:25:41 +0200 Philippe Mathieu-Daudé wrote: > On 2/4/23 19:56, Lukas Straub wrote: > > This will be used in the next commits to move save_page_header() > > out of compress code. > > > > Signed-off-by: Lukas Straub > > --- > > migration/ram.c | 34 ++

Re: [PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

Hi Volker, Filling a buffer with zeros to produce silence still wrong for unsigned > samples. For example, a 0 in SPA_AUDIO_FORMAT_U8 format maps to -1.0 in > SPA_AUDIO_FORMAT_F32. > This is a bug. On a buffer underrun, the buffer filled with silence is > dropped. > What are your suggestions to im

Re: [edk2-devel] On integrating LoongArch EDK2 firmware into QEMU build process

On Mon, Apr 03, 2023 at 10:29:52AM +, Michael Brown wrote: > On 03/04/2023 11:13, Chao Li wrote: > > This problem is because the gcc-12 does not yet to support the option > > 'mno-explicit-reloc', this option is used to open the new reloaction > > type for LoongArch, this new feature is very im

[RFC PATCH] gdbstub: don't report auxv feature unless on Linux

The later handler if conditionally compiled only for Linux but we forgot to ensure we don't advertise it lest we confuse our BSD brethren. Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c in

Wine CE 8.5 Released, Cross Architecture Windows Emulator, Support Wow64, Base on wine and qemu

Wine CE is a compatibility layer capable of running Windows applications on Cross-architecture paltform of Linux, It base on wine and qemu, and support aarch64 and riscv64 Linux. It can emulate x86(32bit) x64, aarch64 windows app. Project Address: https://gitlab.com/wine-ce/wine-ce Binary Downnl

Re: [PATCH v9 0/5] Add zoned storage emulation to virtio-blk driver

On Wed, 29 Mar 2023 at 01:01, Michael S. Tsirkin wrote: > > On Mon, Mar 27, 2023 at 10:45:48PM +0800, Sam Li wrote: > > This patch adds zoned storage emulation to the virtio-blk driver. It > > implements the virtio-blk ZBD support standardization that is > > recently accepted by virtio-spec. The l

Re: [EXTERNAL][RFC PATCH] tests/avocado: Test Xen guest support under KVM

On Wed, 2023-03-29 at 21:56 +0100, Alex Bennée wrote: > Alex Bennée writes: > > > From: David Woodhouse > > > > Exercise guests with a few different modes for interrupt delivery. In > > particular we want to cover: > > > >  • Xen event channel delivery via GSI to the I/O APIC > >  • Xen event

Re: [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()

On Mon, Apr 3, 2023 at 5:33 AM Anthony PERARD wrote: > > On Sat, Apr 01, 2023 at 10:36:45PM +, Bernhard Beschow wrote: > > > > > > Am 30. März 2023 13:00:25 UTC schrieb Anthony PERARD > > : > > >On Sun, Mar 12, 2023 at 01:02:17PM +0100, Bernhard Beschow wrote: > > >> This is a preparational p

Re: [RFC PATCH] gdbstub: don't report auxv feature unless on Linux

On 3/4/23 14:02, Alex Bennée wrote: The later handler if conditionally compiled only for Linux but we forgot to ensure we don't advertise it lest we confuse our BSD brethren. Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [RFC PATCH 0/5] Deprecate/rename singlestep command line option

On Tue, 7 Feb 2023 at 15:56, Markus Armbruster wrote: > > (3) what should we do about the HMP StatusInfo object? > > I'm not sure how we handle compatibility for HMP. > > Uh, you mean *QMP*, don't you? Yes. > As you wrote above, StatusInfo is returned by query-status, which is a > stable int

[PATCH qemu] sev/i386: Fix error reporting

c9f5aaa6bce8 ("sev: Add Error ** to sev_kvm_init()") converted error_report() to error_setg(), however it missed one error_report() and other 2 changes added error_report() after conversion. The result is the caller - kvm_init() - crashes in error_report_err as local_err is NULL. Follow the patter

Re: [PATCH] Make bootable RPi4B model

Hi Phil! I've put unit tests to a separate patch in order to not overwhelm you with code. It is already a huge piece, and I agree that 3000+ lines are a sort of a challenge to a reviewer. OK, I'll try to split it into a several patches - core functionality + a single patch for each device (g

[PATCH] Subject:[PATCH] cxl-cdat:Fix open file not closed in ct3_load_cdat

opened file processor not closed,May cause file processor leaks Fixes:aba578bdace5303a441f8a37aad781b5cb06f38c Signed-off-by: Zeng Hao Suggested-by: Xie Ming --- hw/cxl/cxl-cdat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c index 137abd0992..ba7ed1

Re: [RFC PATCH] gdbstub: don't report auxv feature unless on Linux

On Mon, Apr 3, 2023, 6:37 AM Philippe Mathieu-Daudé wrote: > On 3/4/23 14:02, Alex Bennée wrote: > > The later handler if conditionally compiled only for Linux but we > > forgot to ensure we don't advertise it lest we confuse our BSD > > brethren. > > > > Signed-off-by: Alex Bennée > > --- > >

[PATCH] stm32vldiscovery: allow overriding of RAM size

stm32vldiscovery comes with 8KB of SRAM, which may be too low when running some workloads on QEMU. The command line argument "-m mem_size" is not recognized by the current implementation, though, so one cannot easily override the default memory size. This patch fixes that by adding a memory subreg

Re: [edk2-devel] On integrating LoongArch EDK2 firmware into QEMU build process

Hi Bibo, Thanks for Cc to me. Hi Gerd, This problem is because the gcc-12 does not yet to support the option 'mno-explicit-reloc', this option is used to open the new reloaction type for LoongArch, this new feature is very important for LoongArch, because it can reduce the binary size and i

[PATCH v2] lasi: fix RTC migration

Migrate rtc_ref (which only needs to be 32-bit because it is summed to a 32-bit register), which requires bumping the migration version. The HPPA machine does not have versioned machine types so it is okay to block migration to old versions of QEMU. While at it, drop the write-only field rtc from

Re: [RFC PATCH v2 18/44] target/loongarch: Implement vsat

Hi, Richard 在 2023/4/1 下午1:03, Richard Henderson 写道: On 3/27/23 20:06, Song Gao wrote: +static void gen_vsat_s(unsigned vece, TCGv_vec t, TCGv_vec a, int64_t imm) +{ +    TCGv_vec t1; +    int64_t max  = (1l << imm) - 1; This needed 1ull, but better to just use     max = MAKE_64BIT_MASK(0,

[PATCH] vfio/migration: Skip log_sync during migration SETUP state

Currently, VFIO log_sync can be issued while migration is in SETUP state. However, doing this log_sync is at best redundant and at worst can fail. Redundant -- all RAM is marked dirty in migration SETUP state and is transferred only after migration is set to ACTIVE state, so doing log_sync during

Re: [PATCH v2] target/loongarch: Enables plugins to get instruction codes

tanhongze writes: > Signed-off-by: tanhongze It looks like you've missed the review tags from the last posting. Acked-by: Alex Bennée > --- > target/loongarch/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/loongarch/translate.c b/target/loongar

an issue for device hot-unplug

Dear Laurent, recently we run into an issue with the following error: command '{ "execute": "device_del", "arguments": { "id": "virtio-diskX" } }' for VM "id" failed ({ "return": {"class": "GenericError", "desc": "Device virtio-diskX is already in the process of unplug"} }). The issue is reprodu

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

Markus Armbruster writes: > Alex Bennée writes: > >> We are a bit premature in recommending -blockdev/-device as the best >> way to configure block devices, especially in the common case. >> Improve the language to hopefully make things clearer. >> >> Suggested-by: Michael Tokarev >> Signed-o

Re: [PATCH 2/4] block: Split padded I/O vectors exceeding IOV_MAX

(Sorry for the rather late reply... Thanks for the review!) On 20.03.23 11:31, Vladimir Sementsov-Ogievskiy wrote: On 17.03.23 20:50, Hanna Czenczek wrote: [...] diff --git a/block/io.c b/block/io.c index 8974d46941..1e9cdba17a 100644 --- a/block/io.c +++ b/block/io.c [..] +    pad->writ

Re: [PATCH] MAINTAINERS: Remove and change David Gilbert maintainer entries

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > I'm leaving Red Hat next week, so clean up the maintainer entries. > > 'virtiofs' is just the device code now, so is pretty small, and > Stefan is still a maintainer there. > > 'migration' still has Juan. > > For 'HMP' I'l

riscv: g_assert for NULL predicate?

Recent commit 0ee342256af92 switches to g_assert() for the predicate() NULL check from returning RISCV_EXCP_ILLEGAL_INST. Qemu doesn't have predicate() for un-allocated CSRs, then a buggy userspace application reads CSR such as 0x4 causes qemu to exit, I don't think it's expected. .global _start

[PATCH v2 03/11] gdbstub: don't report auxv feature unless on Linux

The later handler if conditionally compiled only for Linux but we forgot to ensure we don't advertise it lest we confuse our BSD brethren. Signed-off-by: Alex Bennée Fixes: 51c623b0de ("gdbstub: add support to Xfer:auxv:read: packet") Reported-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 05/11] qemu-options: finesse the recommendations around -blockdev

We are a bit premature in recommending -blockdev/-device as the best way to configure block devices, especially in the common case. Improve the language to hopefully make things clearer. Suggested-by: Michael Tokarev Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <2023033010114

[PATCH v2 02/11] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary

From: Philippe Mathieu-Daudé It is pointless to build libgdb_user.fa in a system-only build (or libgdb_softmmu.fa in a user-only build). Besides, in some restricted build configurations, some APIs might be restricted / not available. Example in a KVM-only builds where TCG is disabled: $ ninja

[PATCH v2 08/11] tests/qemu-iotests: explicitly invoke 'check' via 'python'

From: Daniel P. Berrangé The 'check' script will use "#!/usr/bin/env python3" by default to locate python, but this doesn't work in distros which lack a bare 'python3' binary like NetBSD. We need to explicitly invoke 'check' by referring to the 'python' variable in meson, which resolves to the d

[PATCH v2 04/11] MAINTAINERS: add a section for policy documents

We don't update these often but now at least we have a few like minded individuals keeping reviewers eye out for changes. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Warner Losh Reviewed-by: Markus Armbruster Reviewed-by: Kashyap Chamarthy Reviewed-by: Philippe Mathieu-Da

[PATCH v2 09/11] tests/vm: use the default system python for NetBSD

From: Daniel P. Berrangé Currently our NetBSD VM recipe requests instal of the python37 package and explicitly tells QEMU to use that version of python. Since the NetBSD base ISO was updated to version 9.3 though, the default system python version is 3.9 which is sufficiently new for QEMU to rely

[PATCH v2 00/11] more misc fixes for 8.0 (tests, gdbstub, meta, docs)

Testing of kaniko as an alternative builder ran into the weeds so that patch has been dropped. It looks like the gitlab registry doesn't support layer caching. However the build also seems to be very unstable leading to a bunch of container build failures, e.g.: https://gitlab.com/stsquad/qemu/-

[PATCH v2 06/11] metadata: add .git-blame-ignore-revs

Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée Message-Id: <20230318115657.1345921-1-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <2023033010

[PATCH v2 10/11] gitlab: fix typo

Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230330101141.30199-11-alex.ben...@linaro.org> --- .gitlab-ci.d/base.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index

[PATCH v2 07/11] Use hexagon toolchain version 16.0.0

From: Marco Liebel Signed-off-by: Marco Liebel Reviewed-by: Brian Cain Message-Id: <20230329142108.1199509-1-quic_mlie...@quicinc.com> Signed-off-by: Alex Bennée Message-Id: <20230330101141.30199-7-alex.ben...@linaro.org> --- tests/docker/dockerfiles/debian-hexagon-cross.docker | 2 +- 1 file

[PATCH v2 11/11] tests/avocado: Test Xen guest support under KVM

From: David Woodhouse Exercise guests with a few different modes for interrupt delivery. In particular we want to cover: • Xen event channel delivery via GSI to the I/O APIC • Xen event channel delivery via GSI to the i8259 PIC • MSIs routed to PIRQ event channels • GSIs routed to PIRQ event

[PATCH v2 01/11] scripts/coverage: initial coverage comparison script

This is a very rough and ready first pass at comparing gcovr's json output between two different runs. At the moment it will give you a file level diff between two runs but hopefully it wont be too hard to extend to give better insight. After generating the coverage results you run with something

Re: [PATCH] stm32vldiscovery: allow overriding of RAM size

On Mon, 3 Apr 2023 at 13:51, Lucas Villa Real wrote: > > stm32vldiscovery comes with 8KB of SRAM, which may be too low when > running some workloads on QEMU. The command line argument "-m mem_size" > is not recognized by the current implementation, though, so one cannot > easily override the defau

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

Hi Babis, Why are you resending this? As I mentioned before, I'm going to move forward in implementing this feature in a way that actually works with the RNG. I'll use your RFC patch as a base, but I think beyond that, I can take it from here. Thanks, Jason

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

On Mon, Apr 3, 2023 at 4:15 PM Jason A. Donenfeld wrote: > > Hi Babis, > > Why are you resending this? As I mentioned before, I'm going to move > forward in implementing this feature in a way that actually works with > the RNG. I'll use your RFC patch as a base, but I think beyond that, I > can ta

Re: [PATCH 4/4] iotests/iov-padding: New test

On 18.03.23 13:39, Eric Blake wrote: On Fri, Mar 17, 2023 at 06:50:19PM +0100, Hanna Czenczek wrote: Test that even vectored IO requests with 1024 vector elements that are not aligned to the device's request alignment will succeed. Signed-off-by: Hanna Czenczek --- + +# Four combinations: +# -

Re: property 'cxl-type3.size' not found

On Mon, 3 Apr 2023 16:03:20 +0530 Maverickk 78 wrote: > Hi Jonathan > > Do you want me to modify the doc(remove size)? I can do that. That would be great. Also whilst there, a second patch to modify the architecture to be x86_64 would be good. Thanks, Jonathan > > Regards > Raghu > > On M

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

On 4/3/23 4:16 PM, "Jason A. Donenfeld" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Apr 3, 2023 at 4:15 PM Jason A. Donenfeld wrote: > > Hi Babis, >

Re: [RFC PATCH 0/5] Deprecate/rename singlestep command line option

Peter Maydell writes: > On Tue, 7 Feb 2023 at 15:56, Markus Armbruster wrote: >> > (3) what should we do about the HMP StatusInfo object? >> > I'm not sure how we handle compatibility for HMP. >> >> Uh, you mean *QMP*, don't you? > > Yes. > >> As you wrote above, StatusInfo is returned by qu

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

David Hildenbrand writes: > On 30.03.23 20:03, Fabiano Rosas wrote: >> Hi folks, >> >> I'm continuing the work done last year to add a new format of >> migration stream that can be used to migrate large guests to a single >> file in a performant way. >> >> This is an early RFC with the previous

RE: [PATCH 0/2] Migration time prediction using calc-dirty-rate

ping3 https://patchew.org/QEMU/cover.1677589218.git.gudkov.and...@huawei.com/ -Original Message- From: Gudkov Andrei Sent: Monday, March 27, 2023 17:09 To: 'qemu-devel@nongnu.org' Cc: 'quint...@redhat.com' ; 'dgilb...@redhat.com' Subject: RE: [PATCH 0/2] Migration time prediction usin

[PATCH v2 01/10] make one-insn-per-tb an accel option

This commit adds 'one-insn-per-tb' as a property on the TCG accelerator object, so you can enable it with -accel tcg,one-insn-per-tb=on It has the same behaviour as the existing '-singlestep' command line option. We use a different name because 'singlestep' has always been a confusing choice,

[PATCH v2 02/10] softmmu: Don't use 'singlestep' global in QMP and HMP commands

The HMP 'singlestep' command, the QMP 'query-status' command and the HMP 'info status' command (which is just wrapping the QMP command implementation) look at the 'singlestep' global variable. Make them access the new TCG accelerator 'one-insn-per-tb' property instead. This leaves the HMP and QMP

[PATCH v2 00/10] Deprecate/rename singlestep command line option, monitor interfaces

The command line option '-singlestep' and its HMP equivalent the 'singlestep' command are very confusingly named, because they have nothing to do with single-stepping the guest (either via the gdb stub or by emulation of guest CPU architectural debug facilities). What they actually do is put TCG in

[PATCH v2 03/10] tcg: Use one-insn-per-tb accelerator property in curr_cflags()

Change curr_cflags() to look at the one-insn-per-tb accelerator property instead of the old singlestep global variable. Since this is the final remaining use of the global, we can delete it entirely. Signed-off-by: Peter Maydell --- This is the "clean" way of doing it. I dunno how much of a hot

[PATCH v2 07/10] hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep'

The 'singlestep' HMP command is confusing, because it doesn't actually have anything to do with single-stepping the CPU. What it does do is force TCG emulation to put one guest instruction in each TB, which can be useful in some situations. Create a new HMP command 'one-insn-per-tb', so we can d

[PATCH v2 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'

The '-singlestep' option is confusing, because it doesn't actually have anything to do with single-stepping the CPU. What it does do is force TCG emulation to put one guest instruction in each TB, which can be useful in some situations. Create a new command line argument -one-insn-per-tb, so we ca

[PATCH v2 06/10] Document that -singlestep command line option is deprecated

Document that the -singlestep command line option is now deprecated, as it is replaced by either the TCG accelerator property 'one-insn-per-tb' for system emulation or the new '-one-insn-per-tb' option for usermode emulation, and remove the only use of the deprecated syntax from a README. Signed-o

[PATCH v2 09/10] qapi/run-state.json: Fix missing newline at end of file

The run-state.json file is missing a trailing newline; add it. Signed-off-by: Peter Maydell --- Noticed this because my editor wanted to add the newline when I touched the file for the following patch... --- qapi/run-state.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

The 'singlestep' member of StatusInfo has never done what the QMP documentation claims it does. What it actually reports is whether TCG is working in "one guest instruction per translation block" mode. Create a new 'one-insn-per-tb' member whose name matches what the field actually does and the ne

[PATCH v2 08/10] hmp: Report 'one-insn-per-tb', not 'single step mode', in 'info status' output

The HMP 'info status' output includes "(single step mode)" when we are running with TCG one-insn-per-tb enabled. Change this text to "(one insn per TB)" to match the new command line option names. We don't need to have a deprecation/transition plan for this, because we make no guarantees about sta

[PATCH v2 05/10] bsd-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'

The '-singlestep' option is confusing, because it doesn't actually have anything to do with single-stepping the CPU. What it does do is force TCG emulation to put one guest instruction in each TB, which can be useful in some situations. Create a new command line argument -one-insn-per-tb, so we ca

Re: [PATCH 04/11] qemu-options: finesse the recommendations around -blockdev

Alex Bennée writes: > Markus Armbruster writes: > >> Alex Bennée writes: >> >>> We are a bit premature in recommending -blockdev/-device as the best >>> way to configure block devices, especially in the common case. >>> Improve the language to hopefully make things clearer. >>> >>> Suggested-by

Re: [PATCH v6 2/3] qga: Add `merged` variant to GuestExecCaptureOutputMode

Hi Daniel, I will merge this series after the 8.0 release. Best Regards, Konstantin Kostiuk. On Fri, Mar 31, 2023 at 11:24 PM Daniel Xu wrote: > Hi Daniel, > > On Thu, Mar 23, 2023, at 3:26 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 22, 2023 at 06:19:27PM -0600, Daniel Xu wrote: > >> Curre

Re: [PATCH qemu] sev/i386: Fix error reporting

Alexey Kardashevskiy writes: > c9f5aaa6bce8 ("sev: Add Error ** to sev_kvm_init()") converted > error_report() to error_setg(), however it missed one error_report() > and other 2 changes added error_report() after conversion. The result > is the caller - kvm_init() - crashes in error_report_err a

Re: [PATCH] stm32vldiscovery: allow overriding of RAM size

On Mon, Apr 3, 2023 at 10:54 AM Peter Maydell wrote: > On Mon, 3 Apr 2023 at 13:51, Lucas Villa Real wrote: > > > > stm32vldiscovery comes with 8KB of SRAM, which may be too low when > > running some workloads on QEMU. The command line argument "-m mem_size" > > is not recognized by the current

RE: [PATCH] MAINTAINERS: Remove and change David Gilbert maintainer entries

> -Original Message- > From: qemu-devel-bounces+chen.zhang=intel@nongnu.org devel-bounces+chen.zhang=intel@nongnu.org> On Behalf Of Dr. David > Alan Gilbert (git) > Sent: Thursday, March 30, 2023 5:55 PM > To: qemu-devel@nongnu.org; stefa...@redhat.com; quint...@redhat.com; > d.

  1   2   3   >