Re: [RFC PATCH 3/5] ebpf: Added declaration/initialization routines.

2023-03-31 Thread Jason Wang
On Thu, Mar 30, 2023 at 4:34 PM Daniel P. Berrangé wrote: > > On Thu, Mar 30, 2023 at 02:54:32PM +0800, Jason Wang wrote: > > On Thu, Mar 30, 2023 at 8:33 AM Andrew Melnychenko > > wrote: > > > > > > Now, the binary objects may be retrieved by id/name. > > > It would require for future qmp comma

Re: [PATCH 09/11] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-31 Thread Thomas Huth
On 30/03/2023 14.21, Thomas Huth wrote: On 30/03/2023 14.12, Alex Bennée wrote: Thomas Huth writes: On 30/03/2023 12.11, Alex Bennée wrote: From: Kautuk Consul Avocado version 101.0 has a fix to re-compute the checksum of an asset file if the algorithm used in the *-CHECKSUM file isn't the

Re: [RFC PATCH v1 10/26] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-31 Thread Daniel P . Berrangé
On Thu, Mar 30, 2023 at 06:01:51PM -0400, Peter Xu wrote: > On Thu, Mar 30, 2023 at 03:03:20PM -0300, Fabiano Rosas wrote: > > From: Nikolay Borisov > > > > Implement 'fixed-ram' feature. The core of the feature is to ensure that > > each ram page of the migration stream has a specific offset in

Re: [RFC PATCH 3/5] ebpf: Added declaration/initialization routines.

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 03:48:18PM +0800, Jason Wang wrote: > On Thu, Mar 30, 2023 at 4:34 PM Daniel P. Berrangé > wrote: > > > > On Thu, Mar 30, 2023 at 02:54:32PM +0800, Jason Wang wrote: > > > On Thu, Mar 30, 2023 at 8:33 AM Andrew Melnychenko > > > wrote: > > > > > > Who or how the ABI comp

Re: [PATCH v3 5/6] target/riscv: Enable PC-relative translation in system mode

2023-03-31 Thread LIU Zhiwei
On 2023/3/31 9:45, Weiwei Li wrote: The existence of CF_PCREL can improve performance with the guest kernel's address space randomization. Each guest process maps libc.so (et al) at a different virtual address, and this allows those translations to be shared. Signed-off-by: Weiwei Li Signed-

Re: [PATCH for 8.1 v2 5/6] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-03-31 Thread Jason Wang
在 2023/3/30 18:42, Eugenio Perez Martin 写道: On Thu, Mar 30, 2023 at 8:23 AM Jason Wang wrote: On Thu, Mar 30, 2023 at 2:20 PM Jason Wang wrote: On Fri, Mar 24, 2023 at 3:54 AM Eugenio Pérez wrote: Evaluating it at start time instead of initialization time may make the guest capable of dyn

Re: [RFC PATCH 3/5] ebpf: Added declaration/initialization routines.

2023-03-31 Thread Jason Wang
On Fri, Mar 31, 2023 at 3:59 PM Daniel P. Berrangé wrote: > > On Fri, Mar 31, 2023 at 03:48:18PM +0800, Jason Wang wrote: > > On Thu, Mar 30, 2023 at 4:34 PM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Mar 30, 2023 at 02:54:32PM +0800, Jason Wang wrote: > > > > On Thu, Mar 30, 2023 at 8:33

Re: [RFC PATCH 3/5] ebpf: Added declaration/initialization routines.

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 04:03:39PM +0800, Jason Wang wrote: > On Fri, Mar 31, 2023 at 3:59 PM Daniel P. Berrangé > wrote: > > > > On Fri, Mar 31, 2023 at 03:48:18PM +0800, Jason Wang wrote: > > > On Thu, Mar 30, 2023 at 4:34 PM Daniel P. Berrangé > > > wrote: > > > > > > > > On Thu, Mar 30, 202

Re: [RFC PATCH 3/5] ebpf: Added declaration/initialization routines.

2023-03-31 Thread Jason Wang
On Fri, Mar 31, 2023 at 4:13 PM Daniel P. Berrangé wrote: > > On Fri, Mar 31, 2023 at 04:03:39PM +0800, Jason Wang wrote: > > On Fri, Mar 31, 2023 at 3:59 PM Daniel P. Berrangé > > wrote: > > > > > > On Fri, Mar 31, 2023 at 03:48:18PM +0800, Jason Wang wrote: > > > > On Thu, Mar 30, 2023 at 4:34

Re: [RFC PATCH 0/3] configure: create a python venv and install meson

2023-03-31 Thread Paolo Bonzini
On 3/30/23 16:11, John Snow wrote: * undo the meson parts from PATCH 3; make patch 3 create the venv + subsume the MKVENV parts of the Makefiles + always set explicit_python=yes (so that at this point the in-tree meson is always used). * add a patch that starts rejecting --me

Re: [RFC PATCH 1/3] python: add mkvenv.py

2023-03-31 Thread Paolo Bonzini
On 3/30/23 16:00, John Snow wrote: > +                yield { > +                    'name': entry_point.name , > +                    'module': module, > +                    'import_name': attr, > +                    'func': attr, What

virtio-net-failover intermittent test hangs eating CPU on s390 host

2023-03-31 Thread Peter Maydell
Found a couple of virtio-net-failover test processes sat on the s390 CI runner with the virtio-net-failover process eating CPU. Backtrace (I captured from both, but the backtraces are the same in both cases): Process tree: virtio-net-fail(3435488)---qemu-system-i38(3435776) ==

Re: [RFC PATCH 1/3] python: add mkvenv.py

2023-03-31 Thread Paolo Bonzini
On 3/31/23 10:44, Paolo Bonzini wrote:     What about using a dataclass or namedtuple instead of a dictionary? Sure. Once 3.8 is our minimum there's no point, though. Well, that's why I also mentioned namedtuples.  But no big deal. Sorry, I misunderstood this (I read "until 3.8 is our mini

Re: [PATCH] hw/ssi: Fix Linux driver init issue with xilinx_spi

2023-03-31 Thread Edgar E. Iglesias
On Thu, Mar 23, 2023 at 7:29 PM Chris Rauer wrote: > The problem is that the Linux driver expects the master transaction inhibit > bit(R_SPICR_MTI) to be set during driver initialization so that it can > detect the fifo size but QEMU defaults it to zero out of reset. The > datasheet indicates th

Re: [PATCH] hw/ssi: Fix Linux driver init issue with xilinx_spi

2023-03-31 Thread Peter Maydell
On Fri, 31 Mar 2023 at 11:09, Edgar E. Iglesias wrote: > > > On Thu, Mar 23, 2023 at 7:29 PM Chris Rauer wrote: >> >> The problem is that the Linux driver expects the master transaction inhibit >> bit(R_SPICR_MTI) to be set during driver initialization so that it can >> detect the fifo size but Q

Re: [PATCH for 8.1 v2 5/6] vdpa: move CVQ isolation check to net_init_vhost_vdpa

2023-03-31 Thread Eugenio Perez Martin
On Fri, Mar 31, 2023 at 10:00 AM Jason Wang wrote: > > > 在 2023/3/30 18:42, Eugenio Perez Martin 写道: > > On Thu, Mar 30, 2023 at 8:23 AM Jason Wang wrote: > >> On Thu, Mar 30, 2023 at 2:20 PM Jason Wang wrote: > >>> On Fri, Mar 24, 2023 at 3:54 AM Eugenio Pérez wrote: > Evaluating it at st

Re: [PATCH 1/2] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-31 Thread Alex Bennée
Kautuk Consul writes: > Hi, > On 2023-03-27 07:50:29, Kautuk Consul wrote: >> Avocado version 101.0 has a fix to re-compute the checksum >> of an asset file if the algorithm used in the *-CHECKSUM >> file isn't the same as the one being passed to it by the >> avocado user (i.e. the avocado_qemu

Re: [PATCH v4 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-31 Thread Thomas Huth
On 28/03/2023 19.19, Stefan Berger wrote: Add read and write functions for accessing registers of I2C devices connected to the Aspeed I2C controller. Signed-off-by: Stefan Berger Reviewed-by: Cédric Le Goater Reviewed-by: Ninad Palsule --- include/hw/i2c/aspeed_i2c.h | 7 +++ tests/qtest

Re: [PATCH v4 2/3] qtest: Move tpm_util_tis_transmit() into tpm-tis-utils.c and rename it

2023-03-31 Thread Thomas Huth
On 28/03/2023 19.19, Stefan Berger wrote: To be able to remove tpm_tis_base_addr from test cases that do not really need it move the tpm_util_tis_transmit() function into tpm-tis-utils.c and rename it to tpm_tis_transmit(). Fix a locality parameter in a test case on the way. Signed-off-by: Stef

Re: [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines

2023-03-31 Thread Cédric Le Goater
On 3/31/23 08:53, Harsh Prateek Bora wrote: This patchset introduces helper routines to enable (and does) cleaning up of h_enter_nested() and spapr_exit_nested() routines in existing api for nested virtualization on Power/SPAPR for better code readability / maintenance. No functional changes inte

Re: [PATCH 1/2] tests/requirements.txt: bump up avocado-framework version to 101.0

2023-03-31 Thread Kautuk Consul
On 2023-03-31 11:19:18, Alex Bennée wrote: > > Kautuk Consul writes: > > > Hi, > > On 2023-03-27 07:50:29, Kautuk Consul wrote: > >> Avocado version 101.0 has a fix to re-compute the checksum > >> of an asset file if the algorithm used in the *-CHECKSUM > >> file isn't the same as the one being

Re: [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines

2023-03-31 Thread Daniel Henrique Barboza
On 3/31/23 07:39, Cédric Le Goater wrote: On 3/31/23 08:53, Harsh Prateek Bora wrote: This patchset introduces helper routines to enable (and does) cleaning up of h_enter_nested() and spapr_exit_nested() routines in existing api for nested virtualization on Power/SPAPR for better code readabi

Re: [PATCH 2/2] tests/avocado/boot_linux.py: re-enable test-case for ppc64

2023-03-31 Thread Cédric Le Goater
Hello, [ Copying qemu-ppc@ and Daniel ] On 3/28/23 13:24, Kautuk Consul wrote: On 2023-03-27 17:07:30, Alex Bennée wrote: Kautuk Consul writes: Fixes c0c8687ef0("tests/avocado: disable BootLinuxPPC64 test in CI"). Commit c0c8687ef0fd990db8db1655a8a6c5a5e35dd4bb disabled the test-case for

Re: [PATCH v2 0/3] qapi: allow unions to contain further unions

2023-03-31 Thread Het Gala
Hi all, On 17/03/23 9:25 pm, Markus Armbruster wrote: Daniel P. Berrangé writes: Currently it is not possible for a union type to contain a further union as one (or more) of its branches. This relaxes that restriction and adds the calls needed to validate field name uniqueness as unions are f

Re: [PULL 0/6] Misc fixes for 2023-03-30

2023-03-31 Thread Peter Maydell
On Thu, 30 Mar 2023 at 14:19, Philippe Mathieu-Daudé wrote: > > The following changes since commit f00506aeca2f6d92318967693f8da8c713c163f3: > > Merge tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu into > staging (2023-03-29 11:19:19 +0100) > > are available in the Git repository at

Re: On integrating LoongArch EDK2 firmware into QEMU build process

2023-03-31 Thread Gerd Hoffmann
On Fri, Mar 31, 2023 at 08:54:16AM +0800, maobibo wrote: > Xuerui, > > Thanks for your mail, it is a good suggestion. Now we are planing to > move LoongArch uefi bios from edk2-platform to edk2 repo, so that uefi > bios supporting LoongArch can be auto compiled and uploaded to qemu > repo. Only th

[PATCH] tests: lcitool: Switch to OpenSUSE Leap 15.4

2023-03-31 Thread Peter Krempa
The 15.3 version is EOL now: https://get.opensuse.org/leap/15.3 Switch the dockerfile to 15.4. Signed-off-by: Peter Krempa --- tests/docker/dockerfiles/opensuse-leap.docker | 25 +-- tests/lcitool/refresh | 2 +- 2 files changed, 13 insertions(+), 14 de

Re: [PATCH] tests: lcitool: Switch to OpenSUSE Leap 15.4

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 03:11:41PM +0200, Peter Krempa wrote: > The 15.3 version is EOL now: > > https://get.opensuse.org/leap/15.3 > > Switch the dockerfile to 15.4. > > Signed-off-by: Peter Krempa > --- > tests/docker/dockerfiles/opensuse-leap.docker | 25 +-- > tests/lcitool

Re: [PATCH 1/7] hw/i2c: pmbus add support for block receive

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:50AM +, Titus Rwantare wrote: > PMBus devices can send and receive variable length data using the > block read and write format, with the first byte in the payload > denoting the length. > > This is mostly used for strings and on-device logs. Devices can > respond

Re: [PATCH 2/7] hw/i2c: pmbus: add vout mode bitfields

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:51AM +, Titus Rwantare wrote: > The VOUT_MODE command is described in the PMBus Specification, > Part II, Ver 1.3 Section 8.3 > > VOUT_MODE has a three bit mode and 4 bit parameter, the three bit > mode determines whether voltages are formatted as uint16, uint16,

Re: [PATCH 3/7] hw/i2c: pmbus: add fan support

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:52AM +, Titus Rwantare wrote: > PMBus devices may integrate fans whose operation is configurable > over PMBus. This commit allows the driver to read and write the > fan control registers but does not model the operation of fans. > > Reviewed-by: Stephen Longfield

Re: [PATCH 4/7] hw/i2c: pmbus: block uninitialised string reads

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:53AM +, Titus Rwantare wrote: > Devices models calling pmbus_send_string can't be relied upon to > send a non-zero pointer. This logs an error and doesn't segfault. > > Reviewed-by: Patrick Venture > Signed-off-by: Titus Rwantare Acked-by: Corey Minyard > ---

Re: [PATCH 5/7] hw/i2c: pmbus: add VCAP register

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:54AM +, Titus Rwantare wrote: > VCAP is a register for devices with energy storage capacitors. > > Reviewed-by: Benjamin Streb > Signed-off-by: Titus Rwantare Acked-by: Corey Minyard > --- > hw/i2c/pmbus_device.c | 8 > include/hw/i2c/pmbus_

Re: [PATCH 6/7] hw/sensor: add ADM1266 device model

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:55AM +, Titus Rwantare wrote: > The ADM1266 is a cascadable super sequencer with margin control and > fault recording. This sounds like serious marketing-speak :). I looked up the chip and yes, that's what they say about it. > This commit adds basic suppor

Re: [PATCH 7/7] tests/qtest: add tests for ADM1266

2023-03-31 Thread Corey Minyard
On Fri, Mar 31, 2023 at 12:07:56AM +, Titus Rwantare wrote: > The ADM1266 can have string fields written by the driver, so > it's worth specifically testing. > > Reviewed-by: Hao Wu > Signed-off-by: Titus Rwantare Acked-by: Corey Minyard > --- > tests/qtest/adm1266-test.c | 123 +

Re: [PATCH 0/7] bsd-user: remove bitrotted NetBSD and OpenBSD bsd-user support

2023-03-31 Thread Warner Losh
Please note: This did come from me, from a new machine that's slightly misconfigured, so it didn't go through Google's email server and so you may get a spoofing warning. I'll fix that in v2, if there is one, or in the pull request if there's no changes. Warner On Fri, Mar 31, 2023 at 8:19 AM War

[PATCH 0/7] bsd-user: remove bitrotted NetBSD and OpenBSD bsd-user support

2023-03-31 Thread Warner Losh
The NetBSD and OpenBSD support in bsd-user hasn't built since before the meson conversion. It's also out of sync with many of the recent changes in the bsd-user fork and has just been removed there. Remove it from master for the same reasons: it generates a number of false positives with grep and h

[PATCH 3/7] bsd-user: Remove netbsd system call tracing

2023-03-31 Thread Warner Losh
Remove NetBSD system call tracing. We've not supported building all the BSDs into one module for some time, and the NetBSD support hasn't even built since the meson conversion. Signed-off-by: Warner Losh --- bsd-user/qemu.h | 5 - bsd-user/strace.c | 17 - 2 files changed,

[PATCH 1/7] bsd-user: Remove obsolete prototypes

2023-03-31 Thread Warner Losh
These prototypes have been obsolete since 304f944e5104. Signed-off-by: Warner Losh --- bsd-user/qemu.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index 41d84e0b81..4062ee720f 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -169,12 +169,6 @@ a

[PATCH 2/7] bsd-user: Remove netbsd system call inclusion and defines

2023-03-31 Thread Warner Losh
Remove NetBSD system call inclusion and defines. We've not supported building all the BSDs into one module for some time, and the NetBSD support hasn't even built since the meson conversion. Signed-off-by: Warner Losh --- bsd-user/syscall_defs.h | 16 1 file changed, 16 deletion

[PATCH 5/7] bsd-user: Remove openbsd system call tracing

2023-03-31 Thread Warner Losh
Remove OpenBSD system call tracing. We've not supported building all the BSDs into one module for some time, and the OpenBSD support hasn't even built since the meson conversion. Signed-off-by: Warner Losh --- bsd-user/qemu.h | 5 - bsd-user/strace.c | 17 - 2 files change

[PATCH 7/7] bsd-user: Remove openbsd directory

2023-03-31 Thread Warner Losh
The OpenBSD support in the bsd-user fork can't even compile. It is being removed there. Remove it here as well. If someone wants to revive it, then I'm happy to help them do so. This hasn't built since the conversion to meson. Signed-off-by: Warner Losh --- bsd-user/openbsd/host-os.h |

[PATCH 4/7] bsd-user: Remove openbsd system call inclusion and defines

2023-03-31 Thread Warner Losh
Remove OpenBSD system call inclusion and defines. We've not supported building all the BSDs into one module for some time, and the OpenBSD support hasn't even built since the meson conversion. --- bsd-user/syscall_defs.h | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --g

[PATCH 6/7] bsd-user: Remove netbsd directory

2023-03-31 Thread Warner Losh
The NetBSD support in the bsd-user fork can't even compile. It is being removed there. Remove it here as well. If someone wants to revive it, then I'm happy to help them do so. This hasn't built since the conversion to meson. Signed-off-by: Warner Losh --- bsd-user/netbsd/host-os.h |

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Mar 30, 2023 at 03:03:10PM -0300, Fabiano Rosas wrote: >> Hi folks, > > Hi, > >> >> I'm continuing the work done last year to add a new format of >> migration stream that can be used to migrate large guests to a single >> file in a performant way. >> >> This is an ear

Re: [RFC PATCH v1 10/26] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 08:56:01AM +0100, Daniel P. Berrangé wrote: > On Thu, Mar 30, 2023 at 06:01:51PM -0400, Peter Xu wrote: > > On Thu, Mar 30, 2023 at 03:03:20PM -0300, Fabiano Rosas wrote: > > > From: Nikolay Borisov > > > > > > Implement 'fixed-ram' feature. The core of the feature is to e

[PATCH 3/3] target/arm: Implement FEAT_PAN3

2023-03-31 Thread Peter Maydell
FEAT_PAN3 adds an EPAN bit to SCTLR_EL1 and SCTLR_EL2, which allows the PAN bit to make memory non-privileged-read/write if it is user-executable as well as if it is user-read/write. Implement this feature and enable it in the AArch64 'max' CPU. Signed-off-by: Peter Maydell --- docs/system/arm/

[PATCH 1/3] target/arm: Pass ARMMMUFaultInfo to merge_syn_data_abort()

2023-03-31 Thread Peter Maydell
We already pass merge_syn_data_abort() two fields from the ARMMMUFaultInfo struct, and we're about to want to use a third field. Refactor to just pass a pointer to the fault info. Signed-off-by: Peter Maydell --- target/arm/tcg/tlb_helper.c | 15 +++ 1 file changed, 7 insertions(+),

[PATCH 0/3] target/arm: Fix ESR_EL2 buglet, implement FEAT_PAN3

2023-03-31 Thread Peter Maydell
The main purpose of this patchset is to implement FEAT_PAN3, which allows the guest to force privileged code to not be able to access memory that can be executed by user code. (This is an extension of the existing FEAT_PAN which denies access if user code could read or write the memory.) That is al

[PATCH 2/3] target/arm: Don't set ISV when reporting stage 1 faults in ESR_EL2

2023-03-31 Thread Peter Maydell
The syndrome value reported to ESR_EL2 should only contain the detailed instruction syndrome information when the fault has been caused by a stage 2 abort, not when the fault was a stage 1 abort (i.e. caused by execution at EL2). We were getting this wrong and reporting the detailed ISV informati

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: > >> Outgoing migration to file. NVMe disk. XFS filesystem. > >> > >> - Single migration runs of stopped 32G guest with ~90% RAM usage. Guest > >> running `stress-ng --vm 4 --vm-bytes 90% --vm-method all --verify -t > >> 10m -v`: >

Re: [PATCH] meson: add more version numbers to the summary

2023-03-31 Thread Richard Henderson
On 3/30/23 03:46, Paolo Bonzini wrote: -cc.find_library('gpg-error', required: true)]) +cc.find_library('gpg-error', required: true)], +version: gcrypt.version()) Indentation. Reviewed-by: Richard Henderson r~

Re: [PATCH] meson: add more version numbers to the summary

2023-03-31 Thread Richard Henderson
On 3/31/23 07:54, Richard Henderson wrote: On 3/30/23 03:46, Paolo Bonzini wrote: -    cc.find_library('gpg-error', required: true)]) +    cc.find_library('gpg-error', required: true)], +    version: gcrypt.version()) Indentation. Bah, mis-read the patch. Reviewed-by: Richard

[PATCH] MAINTAINERS: Add Eugenio Pérez as vhost-shadow-virtqueue reviewer

2023-03-31 Thread Eugenio Pérez
I'd like to be notified on SVQ patches and review them. Signed-off-by: Eugenio Pérez --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ef45b5e71e..986119e8ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2061,6 +2061,10 @@ F: backends/vhost-

Re: [RFC PATCH v1 10/26] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-31 Thread Fabiano Rosas
Peter Xu writes: >> >> * pc - refers to the page_size/mr->addr members, so newly added members >> begin from "bitmap_size". > > Could you elaborate more on what's the pc? > > I also didn't see this *pc in below migration.rst update. > Yeah, you need to be looking at the code to figure that one

[PATCH v4 7/8] target/riscv: Enable PC-relative translation in system mode

2023-03-31 Thread Weiwei Li
The existence of CF_PCREL can improve performance with the guest kernel's address space randomization. Each guest process maps libc.so (et al) at a different virtual address, and this allows those translations to be shared. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Reviewed-by: LIU

[PATCH v4 5/8] accel/tcg: Fix overwrite problems of tcg_cflags

2023-03-31 Thread Weiwei Li
CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which tcg_cflags will be overwrited by tcg_cpu_init_cflags(). Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-a

[PATCH v4 2/8] target/riscv: Update cur_pmmask/base when xl changes

2023-03-31 Thread Weiwei Li
write_mstatus() can only change current xl when in debug mode. And we need update cur_pmmask/base in this case. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Reviewed-by: LIU Zhiwei --- target/riscv/csr.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/targe

[PATCH v4 1/8] target/riscv: Fix pointer mask transformation for vector address

2023-03-31 Thread Weiwei Li
actual_address = (requested_address & ~mpmmask) | mpmbase. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang Reviewed-by: Daniel Henrique Barboza Reviewed-by: LIU Zhiwei --- target/riscv/vector_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/vecto

[PATCH v4 6/8] accel/tcg: Fix tb mis-matched problem when CF_PCREL is enabled

2023-03-31 Thread Weiwei Li
A corner case is triggered when tb block with first_pc = 0x8008 and first_pc = 0x80200 has the same jump cache hash, and share the same tb entry with the same tb information except PC. The executed sequence is as follows: tb(0x8008) -> tb(0x8008)-> tb(0x80200) -> tb(0x8008)

[PATCH v4 8/8] target/riscv: Add pointer mask support for instruction fetch

2023-03-31 Thread Weiwei Li
Transform the fetch address in cpu_get_tb_cpu_state() when pointer mask for instruction is enabled. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 20 +++- target/riscv/csr.c| 2 -- 3 files changed

[PATCH v4 0/8] target/riscv: Fix pointer mask related support

2023-03-31 Thread Weiwei Li
This patchset tries to fix some problem in current implementation for pointer mask, and add support for pointer mask of instruction fetch. The port is available here: https://github.com/plctlab/plct-qemu/tree/plct-pm-fix-v4 v2: * drop some error patchs * Add patch 2 and 3 to fix the new problems

[PATCH v4 3/8] target/riscv: Fix target address to update badaddr

2023-03-31 Thread Weiwei Li
Compute the target address before storing it into badaddr when mis-aligned exception is triggered. Use a target_pc temp to store the target address to avoid the confusing operation that udpate target address into cpu_pc before misalign check, then update it into badaddr and restore cpu_pc to curre

[PATCH v4 4/8] target/riscv: Add support for PC-relative translation

2023-03-31 Thread Weiwei Li
Add a base save_pc For PC-relative translation(CF_PCREL). Diable the directly sync pc from tb by riscv_cpu_synchronize_from_tb. Sync pc before it's used or updated from tb related pc: real_pc = (old)env->pc + target_pc(from tb) - ctx->save_pc Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wa

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: >> >> Outgoing migration to file. NVMe disk. XFS filesystem. >> >> >> >> - Single migration runs of stopped 32G guest with ~90% RAM usage. Guest >> >> running `stress-ng --vm 4 --vm-bytes 90% --vm-method all --ve

Re: [RFC PATCH v1 10/26] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 10:39:23AM -0400, Peter Xu wrote: > On Fri, Mar 31, 2023 at 08:56:01AM +0100, Daniel P. Berrangé wrote: > > On Thu, Mar 30, 2023 at 06:01:51PM -0400, Peter Xu wrote: > > > On Thu, Mar 30, 2023 at 03:03:20PM -0300, Fabiano Rosas wrote: > > > > From: Nikolay Borisov > > > >

Re: [PATCH 1/3] target/arm: Pass ARMMMUFaultInfo to merge_syn_data_abort()

2023-03-31 Thread Richard Henderson
On 3/31/23 07:50, Peter Maydell wrote: We already pass merge_syn_data_abort() two fields from the ARMMMUFaultInfo struct, and we're about to want to use a third field. Refactor to just pass a pointer to the fault info. Signed-off-by: Peter Maydell --- target/arm/tcg/tlb_helper.c | 15 +++--

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 10:52:09AM -0400, Peter Xu wrote: > On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: > > >> Outgoing migration to file. NVMe disk. XFS filesystem. > > >> > > >> - Single migration runs of stopped 32G guest with ~90% RAM usage. Guest > > >> running `stress-ng

Re: [PATCH 2/3] target/arm: Don't set ISV when reporting stage 1 faults in ESR_EL2

2023-03-31 Thread Richard Henderson
On 3/31/23 07:50, Peter Maydell wrote: The syndrome value reported to ESR_EL2 should only contain the detailed instruction syndrome information when the fault has been caused by a stage 2 abort, not when the fault was a stage 1 abort (i.e. caused by execution at EL2). We were getting this wrong

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 12:30:45PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: > >> >> Outgoing migration to file. NVMe disk. XFS filesystem. > >> >> > >> >> - Single migration runs of stopped 32G guest with ~90% RAM usage.

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Daniel P . Berrangé
On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: > On Fri, Mar 31, 2023 at 12:30:45PM -0300, Fabiano Rosas wrote: > > Peter Xu writes: > > > > > On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: > > >> >> Outgoing migration to file. NVMe disk. XFS filesystem. > > >> >> > >

[PATCH v12 0/3] Add support for TPM devices over I2C bus

2023-03-31 Thread Ninad Palsule
Hello, Incorporated review comments from Stefan. Please review. This drop adds support for the TPM devices attached to the I2C bus. It only supports the TPM2 protocol. You need to run it with the external TPM emulator like swtpm. I have tested it with swtpm. I have refered to the work done by z

Re: [RFC PATCH v1 10/26] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 04:34:57PM +0100, Daniel P. Berrangé wrote: > On Fri, Mar 31, 2023 at 10:39:23AM -0400, Peter Xu wrote: > > On Fri, Mar 31, 2023 at 08:56:01AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Mar 30, 2023 at 06:01:51PM -0400, Peter Xu wrote: > > > > On Thu, Mar 30, 2023 at 03:

[PATCH v12 2/3] tpm: Extend common APIs to support TPM TIS I2C

2023-03-31 Thread Ninad Palsule
From: Ninad Palsule Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. This commit includes changes for the common code. - Added support for the new checksum registers which are required for the I2C support. The checksum calcu

[PATCH v12 1/3] docs: Add support for TPM devices over I2C bus

2023-03-31 Thread Ninad Palsule
From: Ninad Palsule This is a documentation change for I2C TPM device support. Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. Signed-off-by: Ninad Palsule Reviewed-by: Stefan Berger Reviewed-by: Cédric Le Goater Reviewed

[PATCH v12 3/3] tpm: Add support for TPM device over I2C bus

2023-03-31 Thread Ninad Palsule
From: Ninad Palsule Qemu already supports devices attached to ISA and sysbus. This drop adds support for the I2C bus attached TPM devices. I2C model only supports TPM2 protocol. This commit includes changes for the common code. - Added I2C emulation model. Logic was added in the model to tempora

[PATCH v2] block-backend: Add new bds_io_in_flight counter

2023-03-31 Thread Hanna Czenczek
IDE TRIM is a BB user that wants to elevate its BB's in-flight counter for a "macro" operation that consists of several actual I/O operations. Each of those operations is individually started and awaited. It does this so that blk_drain() will drain the whole TRIM, and not just a single one of the

Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5

2023-03-31 Thread Igor Mammedov
On Wed, 29 Mar 2023 12:47:05 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > > Hmm I don't think we can reasonably make such a change for 8.0. > > > Seems too risky. > > > Also, I fe

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 05:10:16PM +0100, Daniel P. Berrangé wrote: > On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: > > On Fri, Mar 31, 2023 at 12:30:45PM -0300, Fabiano Rosas wrote: > > > Peter Xu writes: > > > > > > > On Fri, Mar 31, 2023 at 11:37:50AM -0300, Fabiano Rosas wrote: >

Re: [PATCH 2/2] hw/acpi: i386: bump MADT to revision 5

2023-03-31 Thread Igor Mammedov
On Wed, 29 Mar 2023 08:16:26 -0500 Eric DeVolder wrote: > On 3/29/23 00:03, Michael S. Tsirkin wrote: > > On Tue, Mar 28, 2023 at 11:59:26AM -0400, Eric DeVolder wrote: > >> Currently i386 QEMU generates MADT revision 3, and reports > >> MADT revision 1. ACPI 6.3 introduces MADT revision 5. > >

Re: [PATCH 3/3] target/arm: Implement FEAT_PAN3

2023-03-31 Thread Richard Henderson
On 3/31/23 07:50, Peter Maydell wrote: FEAT_PAN3 adds an EPAN bit to SCTLR_EL1 and SCTLR_EL2, which allows the PAN bit to make memory non-privileged-read/write if it is user-executable as well as if it is user-read/write. Implement this feature and enable it in the AArch64 'max' CPU. Signed-off

Re: [PULL 00/15] tcg patch queue

2023-03-31 Thread Richard Henderson
On 3/30/23 03:37, Joel Stanley wrote: On Tue, 28 Mar 2023 at 22:59, Richard Henderson wrote: The following changes since commit d37158bb2425e7ebffb167d611be01f1e9e6c86f: Update version for v8.0.0-rc2 release (2023-03-28 20:43:21 +0100) are available in the Git repository at: https://g

[PATCH v5 3/3] qtest: Add a test case for TPM TIS I2C connected to Aspeed I2C controller

2023-03-31 Thread Stefan Berger
Add a test case for the TPM TIS I2C device exercising most of its functionality, including localities. Signed-off-by: Stefan Berger Tested-by: Cédric Le Goater --- tests/qtest/meson.build| 3 + tests/qtest/tpm-tis-i2c-test.c | 663 + 2 files changed, 66

[PATCH v5 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

2023-03-31 Thread Stefan Berger
Add read and write functions for accessing registers of I2C devices connected to the Aspeed I2C controller. Signed-off-by: Stefan Berger Reviewed-by: Cédric Le Goater Reviewed-by: Ninad Palsule Acked-by: Thomas Huth --- include/hw/i2c/aspeed_i2c.h | 7 +++ tests/qtest/qtest_aspeed.c | 117

[PATCH v5 0/3] qtests: tpm: Add test cases for TPM TIS I2C device emulation

2023-03-31 Thread Stefan Berger
This series adds test cases exercising much of the TPM TIS I2C device model assuming that the device is connected to the Aspeed I2C controller. Tests are passing on little and big endian hosts. This series of patches builds on the following series of patches providing the TPM TIS I2C device emulat

[PATCH v5 2/3] qtest: Move tpm_util_tis_transmit() into tpm-tis-utils.c and rename it

2023-03-31 Thread Stefan Berger
To be able to remove tpm_tis_base_addr from test cases that do not really need it move the tpm_util_tis_transmit() function into tpm-tis-utils.c and rename it to tpm_tis_transmit(). Fix a locality parameter in a test case on the way. Signed-off-by: Stefan Berger Reviewed-by: Ninad Palsule Revie

[PATCH] coverity: unify Fedora dockerfiles

2023-03-31 Thread Paolo Bonzini
The Fedora CI and coverity runs are using a slightly different set of packages. Copy most of the content over from tests/docker while keeping the commands at the end that unpack the tools. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/coverity-scan.docker | 250 - 1

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Mar 31, 2023 at 05:10:16PM +0100, Daniel P. Berrangé wrote: >> On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: >> > On Fri, Mar 31, 2023 at 12:30:45PM -0300, Fabiano Rosas wrote: >> > > Peter Xu writes: >> > > >> > > > On Fri, Mar 31, 2023 at 11:37:50AM -030

Re: [PATCH] riscv: Add support for the Zfa extension

2023-03-31 Thread Christoph Müllner
On Mon, Mar 27, 2023 at 7:18 PM Richard Henderson wrote: > > On 3/27/23 01:00, Christoph Muellner wrote: > > +uint64_t helper_fminm_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2) > > +{ > > +float32 frs1 = check_nanbox_s(env, rs1); > > +float32 frs2 = check_nanbox_s(env, rs2); > > + > >

Re: [PATCH] riscv: Add support for the Zfa extension

2023-03-31 Thread Christoph Müllner
On Mon, Mar 27, 2023 at 10:42 AM liweiwei wrote: > > > On 2023/3/27 16:00, Christoph Muellner wrote: > > From: Christoph Müllner > > > > This patch introduces the RISC-V Zfa extension, which introduces > > additional floating-point extensions: > > * fli (load-immediate) with pre-defined immediate

[RFC PATCH v2] riscv: Add support for the Zfa extension

2023-03-31 Thread Christoph Muellner
From: Christoph Müllner This patch introduces the RISC-V Zfa extension, which introduces additional floating-point extensions: * fli (load-immediate) with pre-defined immediates * fminm/fmaxm (like fmin/fmax but with different NaN behaviour) * fround/froundmx (round to integer) * fcvtmod.w.d (Mod

Re: [PATCH v5 3/3] qtest: Add a test case for TPM TIS I2C connected to Aspeed I2C controller

2023-03-31 Thread Ninad Palsule
On 3/31/23 12:30 PM, Stefan Berger wrote: Add a test case for the TPM TIS I2C device exercising most of its functionality, including localities. Signed-off-by: Stefan Berger Tested-by: Cédric Le Goater --- Tested-by: Ninad Palsule

Re: Cxl devel!

2023-03-31 Thread Maverickk 78
Hi Jonathan, Thanks for the response, effort and time you spent to list down the TODOs in CXL space. I just started understanding CXL2.0, am part of a startup developing a CXL2.0 switch to build compostable architecture, it's been 6 weeks. As part of it I have built QEMU and configured with CXL

Re: [PATCH v6 2/3] qga: Add `merged` variant to GuestExecCaptureOutputMode

2023-03-31 Thread Daniel Xu
Hi Daniel, On Thu, Mar 23, 2023, at 3:26 AM, Daniel P. Berrangé wrote: > On Wed, Mar 22, 2023 at 06:19:27PM -0600, Daniel Xu wrote: >> Currently, any captured output (via `capture-output`) is segregated into >> separate GuestExecStatus fields (`out-data` and `err-data`). This means >> that downstr

Re: [PATCH v2 4/6] target/ppc: Alignment faults do not set DSISR in ISA v3.0 onward

2023-03-31 Thread Fabiano Rosas
Nicholas Piggin writes: > This optional behavior was removed from the ISA in v3.0, see > Summary of Changes preface: > > Data Storage Interrupt Status Register for Alignment Interrupt: > Simplifies the Alignment interrupt by remov- ing the Data Storage > Interrupt Status Register (DSISR) fr

Re: [PATCH v2 5/6] target/ppc: Add SRR1 prefix indication to interrupt handlers

2023-03-31 Thread Fabiano Rosas
Nicholas Piggin writes: > ISA v3.1 introduced prefix instructions. Among the changes, various > synchronous interrupts report whether they were caused by a prefix > instruction in (H)SRR1. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas

Re: [PATCH v2 3/6] target/ppc: Fix instruction loading endianness in alignment interrupt

2023-03-31 Thread Fabiano Rosas
Nicholas Piggin writes: > powerpc ifetch endianness depends on MSR[LE] so it has to byteswap > after cpu_ldl_code(). This corrects DSISR bits in alignment > interrupts when running in little endian mode. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas

Re: [PATCH] riscv: Add support for the Zfa extension

2023-03-31 Thread Richard Henderson
On 3/31/23 11:22, Christoph Müllner wrote: On Mon, Mar 27, 2023 at 7:18 PM Richard Henderson wrote: On 3/27/23 01:00, Christoph Muellner wrote: +uint64_t helper_fminm_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2) +{ +float32 frs1 = check_nanbox_s(env, rs1); +float32 frs2 = check_n

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-03-31 Thread Peter Xu
On Fri, Mar 31, 2023 at 03:18:37PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Mar 31, 2023 at 05:10:16PM +0100, Daniel P. Berrangé wrote: > >> On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: > >> > On Fri, Mar 31, 2023 at 12:30:45PM -0300, Fabiano Rosas wrote: > >> > >

Re: [PATCH 0/7] bsd-user: remove bitrotted NetBSD and OpenBSD bsd-user support

2023-03-31 Thread Richard Henderson
On 3/31/23 07:18, Warner Losh wrote: The NetBSD and OpenBSD support in bsd-user hasn't built since before the meson conversion. It's also out of sync with many of the recent changes in the bsd-user fork and has just been removed there. Remove it from master for the same reasons: it generates a nu

  1   2   >