Re: [PATCH v2 0/4] hw/arm/virt: Support dirty ring

2023-03-13 Thread Gavin Shan
On 2/27/23 12:26 PM, Gavin Shan wrote: This series intends to support dirty ring for live migration for arm64. The dirty ring use discrete buffer to track dirty pages. For arm64, the speciality is to use backup bitmap to track dirty pages when there is no-running-vcpu context. It's known that the

Re: [PATCH v3 0/3] NUMA: Apply cluster-NUMA-node boundary for aarch64 and riscv machines

2023-03-13 Thread Gavin Shan
On 2/25/23 2:35 PM, Gavin Shan wrote: For arm64 and riscv architecture, the driver (/base/arch_topology.c) is used to populate the CPU topology in the Linux guest. It's required that the CPUs in one cluster can't span mutiple NUMA nodes. Otherwise, the Linux scheduling domain can't be sorted out,

Re: [PATCH v2] include/block: fixup typos

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 01:37, Wilfred Mallawa wrote: From: Wilfred Mallawa Fixup a few minor typos Signed-off-by: Wilfred Mallawa --- v2: - Fixup typo in commit msg. include/block/aio-wait.h | 2 +- include/block/block_int-common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

Re: [PATCH 1/2] cpu, qapi, target/arm, i386, s390x: Refactor query-cpu-model-expansion

2023-03-13 Thread Thomas Huth
On 12/03/2023 22.06, Dinah Baum wrote: This patch enables 'query-cpu-model-expansion' on all architectures. Only architectures that implement the command will return results, others will return an error message as before. This patch lays the groundwork for parsing a -cpu cpu,help option as speci

Re: [PATCH 3/4] hw/arm: Add WDT to Allwinner-H3 and Orangepi-PC

2023-03-13 Thread Philippe Mathieu-Daudé
Hi, On 11/3/23 15:41, Strahinja Jankovic wrote: This patch adds WDT to Allwinner-H3 and Orangepi-PC. WDT is added as an overlay to the Timer module memory area. Signed-off-by: Strahinja Jankovic --- docs/system/arm/orangepi.rst | 1 + hw/arm/Kconfig| 1 + hw/arm/allwinner-

Re: [PULL 00/73] virtio,pc,pci: features, fixes

2023-03-13 Thread Philippe Mathieu-Daudé
On 11/3/23 20:22, Michael S. Tsirkin wrote: On Fri, Mar 10, 2023 at 11:20:36PM +0100, Philippe Mathieu-Daudé wrote: Hi, On 10/3/23 18:32, Peter Maydell wrote: On Thu, 9 Mar 2023 at 14:47, Michael S. Tsirkin wrote: I moved it one commit back, now at (96cb085897) Cornelia posted some concern

[PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Alexander Bulekov
v6 -> v7: - Fix bad qemu_bh_new_guarded calls found by Thomas (Patch 4) - Add an MR-specific flag to disable reentrancy (Patch 5) - Disable reentrancy checks for lsi53c895a's RAM-like MR (Patch 6) Patches 5 and 6 need review. I left the review-tags for Patch 4, however a fe

[PATCH v7 2/6] async: Add an optional reentrancy guard to the BH API

2023-03-13 Thread Alexander Bulekov
Devices can pass their MemoryReentrancyGuard (from their DeviceState), when creating new BHes. Then, the async API will toggle the guard before/after calling the BH call-back. This prevents bh->mmio reentrancy issues. Reviewed-by: Darren Kenny Signed-off-by: Alexander Bulekov --- docs/devel/mul

[PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Alexander Bulekov
This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-off-by: Alexander Bulekov --- hw/9pfs/xen-9p-backend.c

[PATCH v7 6/6] lsi53c895a: disable reentrancy detection for script RAM

2023-03-13 Thread Alexander Bulekov
As the code is designed to use the memory APIs to access the script ram, disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion. In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion. Reported-by: Fiona Ebner Signed-off-by: Alexander Bulekov --- hw/scsi/lsi53

[PATCH v7 5/6] memory: Allow disabling re-entrancy checking per-MR

2023-03-13 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov --- include/exec/memory.h | 3 +++ softmmu/memory.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 6fa0b071f0..5154b123d8 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h

[PATCH v7 3/6] checkpatch: add qemu_bh_new/aio_bh_new checks

2023-03-13 Thread Alexander Bulekov
Advise authors to use the _guarded versions of the APIs, instead. Reviewed-by: Darren Kenny Signed-off-by: Alexander Bulekov --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d768171dcf..eeaec436eb 100755 --

[PATCH v7 1/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Alexander Bulekov
Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiates DMA. The purpose of this flag is to prevent two types of DMA-based reentrancy issues: 1.) mmio -> dma -> mmio cas

Re: [PATCH v7 5/6] memory: Allow disabling re-entrancy checking per-MR

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: Signed-off-by: Alexander Bulekov --- include/exec/memory.h | 3 +++ softmmu/memory.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 6fa0b071f0..5154b123d8 100644 ---

Re: [PATCH v7 4/6] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: This protects devices from bh->mmio reentrancy issues. Thanks: Thomas Huth for diagnosing OS X test failure. Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Paul Durrant Signed-off-by: Alexande

Re: [PATCH v7 6/6] lsi53c895a: disable reentrancy detection for script RAM

2023-03-13 Thread Thomas Huth
On 13/03/2023 09.24, Alexander Bulekov wrote: As the code is designed to use the memory APIs to access the script ram, disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion. In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion. Reported-by: Fiona Ebner Sign

Re: [PATCH v7 6/6] memory: Introduce address_space_to_flatview_rcu()

2023-03-13 Thread Chuang Xu
Hi, Peter, On 2023/3/10 下午11:08, Peter Xu wrote: On Fri, Mar 10, 2023 at 10:24:25AM +0800, Chuang Xu wrote: In last patch, we wrap vm_load with begin/commit, here we introduce address_space_to_flatview_rcu() to avoid unnecessary enforce commit during vm_load. Signed-off-by: Chuang Xu --- in

Re: [PATCH v7 1/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Philippe Mathieu-Daudé
Hi Alex, Sorry for the late review, *sigh*. On 13/3/23 09:24, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiates DMA. The purpose of thi

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-13 Thread David Woodhouse
On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote: > > This breaks dm_restrict=1 since the xs_open is not allowed by the > time > this is called.  There are other evtchn errors before this as well: > # cat /var/log/xen/qemu-dm-debian.log > char device redirected to /dev/pts/8 (label serial0)

Re: [PATCH-for-8.0] gitlab-ci: Remove job building EDK2 firmware binaries

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 03:09, Bin Meng wrote: On Fri, Mar 10, 2023 at 9:50 PM Philippe Mathieu-Daudé wrote: On 10/3/23 14:38, Peter Maydell wrote: On Fri, 10 Mar 2023 at 13:33, Philippe Mathieu-Daudé wrote: When we introduced this Gitlab-CI job in commit 71920809ce ("gitlab-ci.yml: Add jobs to build E

Re: [PATCH] xen: fix dm_restrict startup

2023-03-13 Thread David Woodhouse
On Sun, 2023-03-12 at 19:41 -0400, Jason Andryuk wrote: > QEMU is failing to signal it start when launched by libxl with > dm_restrict=1.  When xenstore_record_dm_state() is called, the > restrictions prevent xs_open() from succeeding.  QEMU can't write > running to the xenstore, and libxl fails th

[PATCH v7 6/8] igb: respect E1000_VMOLR_RSSE

2023-03-13 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index cb6993dd3b..f91cea20e5 100644 --- a/hw/net/igb_core.c +++ b/hw/net/i

Re: [PATCH v8 09/11] tests/avocado: Pass parameters to migration test

2023-03-13 Thread Philippe Mathieu-Daudé
On 9/3/23 21:14, Fabiano Rosas wrote: The migration tests are currently broken for an aarch64 host because the tests pass no 'machine' and 'cpu' options on the QEMU command line. Add a separate class to each architecture so that we can specify 'machine' and 'cpu' options instead of relying on de

Re: [PATCH v8 10/11] target/arm: gdbstub: Guard M-profile code with CONFIG_TCG

2023-03-13 Thread Philippe Mathieu-Daudé
On 9/3/23 21:14, Fabiano Rosas wrote: This code is only relevant when TCG is present in the build. If we try to build with --disable-tcg we currently get: libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub.c.o: in function `m_sysreg_ptr': ../target/arm/gdbstub.c:356: undefined reference to `arm_v7m

Re: [RFC QEMU PATCH 01/18] virtio: Add shared memory capability

2023-03-13 Thread Philippe Mathieu-Daudé
On 12/3/23 10:22, Huang Rui wrote: From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-speci

Re: [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature

2023-03-13 Thread Philippe Mathieu-Daudé
On 12/3/23 10:22, Huang Rui wrote: From: Antonio Caggiano Create virgl renderer context with flags using context_id when valid. The feature can be enabled via the context_init config option. A warning message will be emitted and the feature will not be used when linking with virglrenderer versi

RE: [PATCH v2 03/10] contrib/gitdm: Add ASPEED Technology to the domain map

2023-03-13 Thread Troy Lee
Hi Alex, > -Original Message- > From: Alex Bennée > Sent: Saturday, March 11, 2023 2:03 AM > To: qemu-devel@nongnu.org > Cc: Alex Bennée ; Steven Lee > ; Troy Lee ; > Howard Chiu ; Jamin Lin > > Subject: [PATCH v2 03/10] contrib/gitdm: Add ASPEED Technology to the > domain map > > We ha

Re: [PATCH v7 1/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Alexander Bulekov
On 230313 0945, Philippe Mathieu-Daudé wrote: > Hi Alex, > > Sorry for the late review, *sigh*. > > On 13/3/23 09:24, Alexander Bulekov wrote: > > Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. > > This flag is set/checked prior to calling a device's MemoryRegion > > han

Re: [PATCH v7 1/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Alexander Bulekov
On 230313 0515, Alexander Bulekov wrote: > > > > At this point I'm not sure anymore this is a device or MR property. > > It's designed to be an MR property. If it were MR specific, it wouldn't Should be "It's designed to be a Device property."

Re: [PATCH-for-8.0] gitlab-ci: Remove job building EDK2 firmware binaries

2023-03-13 Thread Bin Meng
Hi Philippe, On Mon, Mar 13, 2023 at 4:51 PM Philippe Mathieu-Daudé wrote: > > On 13/3/23 03:09, Bin Meng wrote: > > On Fri, Mar 10, 2023 at 9:50 PM Philippe Mathieu-Daudé > > wrote: > >> > >> On 10/3/23 14:38, Peter Maydell wrote: > >>> On Fri, 10 Mar 2023 at 13:33, Philippe Mathieu-Daudé > >

Re: [PATCH v2 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-13 Thread Marc-André Lureau
Hi On Fri, Mar 10, 2023 at 2:03 PM Daniel P. Berrangé wrote: > > On Tue, Mar 07, 2023 at 03:56:34PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > User can still bypass the QEMU choice with SDL_RENDER_DRIVER environment > > variable. (for some reason, specifying a

Re: [PATCH v2 16/18] ui: introduce egl_init()

2023-03-13 Thread Marc-André Lureau
Hi On Fri, Mar 10, 2023 at 2:07 PM Daniel P. Berrangé wrote: > > On Tue, Mar 07, 2023 at 03:56:35PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Future patches will introduce EGL support on win32 (too late for 8.0 > > though). Having a common place for EGL initia

Re: [PATCH] include/blcok: fixup typos

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 00:26, Wilfred Mallawa wrote: > > From: Wilfred Mallawa > > Fixup a few minor typos Typo in patch subject line: should be 'block' :-) > Signed-off-by: Wilfred Mallawa > --- Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH-for-8.0] gitlab-ci: Remove job building EDK2 firmware binaries

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 10:35, Bin Meng wrote: Hi Philippe, On Mon, Mar 13, 2023 at 4:51 PM Philippe Mathieu-Daudé wrote: On 13/3/23 03:09, Bin Meng wrote: On Fri, Mar 10, 2023 at 9:50 PM Philippe Mathieu-Daudé wrote: On 10/3/23 14:38, Peter Maydell wrote: On Fri, 10 Mar 2023 at 13:33, Philippe Mathi

Re: [PATCH v7 1/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 09:24, Alexander Bulekov wrote: Add a flag to the DeviceState, when a device is engaged in PIO/MMIO/DMA. This flag is set/checked prior to calling a device's MemoryRegion handlers, and set when device code initiates DMA. The purpose of this flag is to prevent two types of DMA-based re

Re: [PATCH-for-8.0] gitlab-ci: Remove job building EDK2 firmware binaries

2023-03-13 Thread Bin Meng
On Mon, Mar 13, 2023 at 6:01 PM Philippe Mathieu-Daudé wrote: > > On 13/3/23 10:35, Bin Meng wrote: > > Hi Philippe, > > > > On Mon, Mar 13, 2023 at 4:51 PM Philippe Mathieu-Daudé > > wrote: > >> > >> On 13/3/23 03:09, Bin Meng wrote: > >>> On Fri, Mar 10, 2023 at 9:50 PM Philippe Mathieu-Daudé >

[PATCH v3 00/18] ui: dbus & misc fixes

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Hi, This is a respin of a series I sent end of January that didn't get reviews, here is your chance! :) A collection of fixes for UI related-stuff, and paving the way for accelerated/egl dbus display support on win32 (for 8.1 hopefully). I think they are worth to include

[PATCH v3 01/18] ui/dbus: initialize cursor_fb

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Or else, we may randomly destroy some textures.. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- include/ui/egl-helpers.h | 2 ++ ui/dbus-listener.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/ui/egl-help

[PATCH v3 03/18] audio/dbus: there are no sender for p2p mode

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- audio/audio_int.h | 2 +- audio/dbusaudio.c | 7 +-- ui/dbus.c | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index d51d63f08d.

[PATCH v3 05/18] meson: ensure dbus-display generated code is built before other units

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau It's simply by luck that dbus-display header is built first before the other units using it. With sourceset, I can't find an easier way out than declaring an extra dependency for dbus-display1 generate code. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berran

[PATCH v3 10/18] ui: set cursor position upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/console.c b/ui/console.c index 7b808f080e..8fc18c44bf 100644 --- a/ui/console.c +++ b/ui/console.c @@ -95,6 +95,7 @@ struct Qe

[PATCH v3 07/18] ui: rename cursor_{get->ref}, return it

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU code, and allows to simplify some code by changing the API design, so it returns the input parameter, instead of void. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 2 +- ui/cursor.c

[PATCH v3 11/18] ui/sdl: get the GL context from the window

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau There is no guarantee to have a current GL context here. The current code seems to rely on the renderer using a GL backend, and to set a current GL context. But this is not always the case, for example if the renderer backend is DirectX. This change is enough to fix using

[PATCH v3 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau We can enable EGL later for non-GBM hosts. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 10 +- ui/dbus.c | 12 +++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 85692f

[PATCH v3 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Enable SDL logging when QEMU_ENABLE_SDL_LOGGING variable is set, as suggested by Sam Lantinga, upstream SDL maintainer. Signed-off-by: Marc-André Lureau --- ui/sdl2.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 137f7ab57f..221cdce

[PATCH v3 09/18] ui: set cursor upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index 0dccbdd4be..7b808f080e 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1662,6 +1662,9 @@ void regi

[PATCH v3 06/18] ui: rename cursor_{put->unref}

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h| 2 +- hw/display/qxl-render.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 4 ++-- ui/cursor.c | 2

[PATCH v3 08/18] ui: keep current cursor with QemuConsole

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Keeping the current cursor around is useful, not only for VNC, but for other displays. Let's move it down, see the following patches for other usages. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 1 + ui/vnc.h

[PATCH v3 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau -display sdl,gl=es didn't actually use OpenGL ES. Using OpenGL ES allows to use ANGLE, which works generally better than Windows/OEM OpenGL driver. (note: users can still bypass the QEMU choice with SDL_RENDER_DRIVER environment variable) (note: for some reason, specify

[PATCH v3 12/18] ui/shader: fix #version directive must occur on first line

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau ANGLE fails to compile shaders otherwise. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/shader/texture-blit-flip.vert | 1 - ui/shader/texture-blit.frag | 1 - ui/shader/texture-blit.vert | 1 - 3 files changed, 3 deletions(-) diff

[PATCH v3 04/18] ui/dbus: set mouse is-absolute during console creation

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/dbus-console.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 0bfaa2298d..f77bc49d2e 100644 --- a/ui/dbus-console.

[PATCH v3 17/18] ui/dbus: do not require opengl & gbm

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Allow to build & use the DBus display without 3d/GPU acceleration support. Signed-off-by: Marc-André Lureau --- meson.build | 4 ++-- ui/dbus-listener.c | 15 +-- ui/dbus.c | 8 tests/qtest/meson.build | 2 +- ui/me

[PATCH v3 13/18] ui/egl: print EGL error, helping debugging

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/egl-helpers.c | 54 ++-- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 3a88245b67..b1183741

[PATCH v3 02/18] ui/dbus: unregister clipboard on connection close

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Fixes unregistration with p2p connections, since they don't have an associated name owner. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/dbus-clipboard.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/u

[PATCH v3 16/18] ui: introduce egl_init()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Future patches will introduce EGL support on win32 (too late for 8.0 though). Having a common place for EGL initialization and error handling will make it simpler. Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 2 ++ ui/dbus.c| 7 +

Re: [PATCH v3 11/18] ui/sdl: get the GL context from the window

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:00PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > There is no guarantee to have a current GL context here. The current > code seems to rely on the renderer using a GL backend, and to set a > current GL context. But this is not always the ca

Re: [PATCH] virtio: refresh vring region cache after updating a virtqueue size

2023-03-13 Thread Carlos López
On 9/3/23 11:43, Cornelia Huck wrote: On Thu, Mar 02 2023, Carlos López wrote: Fix this by calling virtio_queue_update_rings() after virtio_queue_set_num() if we are not already calling virtio_queue_set_rings(). Don't we instead need to call virtio_init_region_cache() to update the caches? vi

Re: [PATCH v3 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:03PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Enable SDL logging when QEMU_ENABLE_SDL_LOGGING variable is set, as > suggested by Sam Lantinga, upstream SDL maintainer. > > Signed-off-by: Marc-André Lureau > --- > ui/sdl2.c | 4 >

Re: [PATCH v3 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:04PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > -display sdl,gl=es didn't actually use OpenGL ES. > > Using OpenGL ES allows to use ANGLE, which works generally better than > Windows/OEM OpenGL driver. > > (note: users can still bypass

Re: [PATCH v3 16/18] ui: introduce egl_init()

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:05PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Future patches will introduce EGL support on win32 (too late for 8.0 > though). Having a common place for EGL initialization and error handling > will make it simpler. > > Signed-off-by: Ma

Re: [PATCH v3 17/18] ui/dbus: do not require opengl & gbm

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:06PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allow to build & use the DBus display without 3d/GPU acceleration support. > > Signed-off-by: Marc-André Lureau > --- > meson.build | 4 ++-- > ui/dbus-listener.c | 15 +

Re: [PATCH v3 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-13 Thread Daniel P . Berrangé
On Mon, Mar 13, 2023 at 02:12:07PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > We can enable EGL later for non-GBM hosts. > > Signed-off-by: Marc-André Lureau > --- > ui/dbus-listener.c | 10 +- > ui/dbus.c | 12 +++- > 2 files changed, 16 i

Re: [PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

2023-03-13 Thread Alex Bennée
Richard Henderson writes: > Changes for v2: > * Use plugin_gen_disable_mem_helpers, > * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb. > * Break include loop with hw/core/cpu.h and qemu/plugins.h. > * Inline plugin_gen_disable_mem_helpers. Queued to for-8.0/tweaks-and-fixe

Re: [PULL 30/73] tests: acpi: update expected blobs

2023-03-13 Thread Philippe Mathieu-Daudé
On 8/3/23 02:12, Michael S. Tsirkin wrote: From: Igor Mammedov expected changes: Basically adds devices present on root bus in form: Device (SXX) { Name (_ADR, 0x) // _ADR: Address } On top of that For q35.noacpihp, all ACPI PCI hotplug AML is removed and _OSC get nativ

[PULL 02/18] ui/dbus: unregister clipboard on connection close

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Fixes unregistration with p2p connections, since they don't have an associated name owner. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/dbus-clipboard.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/u

[PULL 03/18] audio/dbus: there are no sender for p2p mode

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- audio/audio_int.h | 2 +- audio/dbusaudio.c | 7 +-- ui/dbus.c | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index d51d63f08d.

[PULL 06/18] ui: rename cursor_{put->unref}

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h| 2 +- hw/display/qxl-render.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 4 ++-- ui/cursor.c | 2

[PULL 05/18] meson: ensure dbus-display generated code is built before other units

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau It's simply by luck that dbus-display header is built first before the other units using it. With sourceset, I can't find an easier way out than declaring an extra dependency for dbus-display1 generate code. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berran

[PULL 00/18] UI patches

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: Merge tag 'linux-user-for-8.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2023-03-12 10:57:00 +) are available in the Git repository at: https://gitlab.com/ma

[PULL 10/18] ui: set cursor position upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/console.c b/ui/console.c index 7b808f080e..8fc18c44bf 100644 --- a/ui/console.c +++ b/ui/console.c @@ -95,6 +95,7 @@ struct Qe

[PULL 04/18] ui/dbus: set mouse is-absolute during console creation

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/dbus-console.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 0bfaa2298d..f77bc49d2e 100644 --- a/ui/dbus-console.

[PULL 01/18] ui/dbus: initialize cursor_fb

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Or else, we may randomly destroy some textures.. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- include/ui/egl-helpers.h | 2 ++ ui/dbus-listener.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/ui/egl-help

[PULL 09/18] ui: set cursor upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index 0dccbdd4be..7b808f080e 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1662,6 +1662,9 @@ void regi

[PULL 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Enable SDL logging when QEMU_ENABLE_SDL_LOGGING variable is set, as suggested by Sam Lantinga, upstream SDL maintainer. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/sdl2.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/sdl2.c b/ui

[PULL 16/18] ui: introduce egl_init()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Future patches will introduce EGL support on win32 (too late for 8.0 though). Having a common place for EGL initialization and error handling will make it simpler. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/egl-helpers.h | 2 ++ ui

[PULL 07/18] ui: rename cursor_{get->ref}, return it

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU code, and allows to simplify some code by changing the API design, so it returns the input parameter, instead of void. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 2 +- ui/cursor.c

[PULL 08/18] ui: keep current cursor with QemuConsole

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Keeping the current cursor around is useful, not only for VNC, but for other displays. Let's move it down, see the following patches for other usages. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 1 + ui/vnc.h

[PULL 13/18] ui/egl: print EGL error, helping debugging

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/egl-helpers.c | 54 ++-- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 3a88245b67..b1183741

[PULL 12/18] ui/shader: fix #version directive must occur on first line

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau ANGLE fails to compile shaders otherwise. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/shader/texture-blit-flip.vert | 1 - ui/shader/texture-blit.frag | 1 - ui/shader/texture-blit.vert | 1 - 3 files changed, 3 deletions(-) diff

[PULL 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau -display sdl,gl=es didn't actually use OpenGL ES. Using OpenGL ES allows to use ANGLE, which works generally better than Windows/OEM OpenGL driver. (note: users can still bypass the QEMU choice with SDL_RENDER_DRIVER environment variable) (note: for some reason, specify

[PULL 11/18] ui/sdl: get the GL context from the window

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau There is no guarantee to have a current GL context here. The current code seems to rely on the renderer using a GL backend, and to set a current GL context. But this is not always the case, for example if the renderer backend is DirectX. This change is enough to fix using

[PULL 17/18] ui/dbus: do not require opengl & gbm

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Allow to build & use the DBus display without 3d/GPU acceleration support. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- meson.build | 4 ++-- ui/dbus-listener.c | 15 +-- ui/dbus.c | 8 tests

[PULL 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau We can enable EGL later for non-GBM hosts. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/dbus-listener.c | 10 +- ui/dbus.c | 12 +++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ui/dbus-listener.c

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-13 Thread Luis Machado
On 3/10/23 18:07, Peter Maydell wrote: On Fri, 10 Mar 2023 at 18:00, Fabiano Rosas wrote: Peter Maydell writes: On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: You need a very new gdb to be able to run with pauth support otherwise your likely to hit asserts and aborts. Disable pauth for

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-13 Thread Peter Maydell
On Fri, 10 Mar 2023 at 18:20, Alex Bennée wrote: > > > (adding some more gdb types to CC) > > Fabiano Rosas writes: > > > Peter Maydell writes: > > > >> On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: > >>> > >>> You need a very new gdb to be able to run with pauth support otherwise > >>> your

Re: [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug

2023-03-13 Thread Denis V. Lunev
On 3/7/23 13:20, Hanna Czenczek wrote: On 03.02.23 10:18, Alexander Ivanov wrote: Fix image inflation when offset in BAT is out of image. Replace whole BAT syncing by flushing only dirty blocks. Move all the checks outside the main check function in separate functions Use WITH_QEMU_LOCK_GUARD

Re: [PATCH v3 1/3] numa: Validate cluster and NUMA node boundary if required

2023-03-13 Thread Philippe Mathieu-Daudé
On 25/2/23 07:35, Gavin Shan wrote: For some architectures like ARM64, multiple CPUs in one cluster can be associated with different NUMA nodes, which is irregular configuration because we shouldn't have this in baremetal environment. The irregular configuration causes Linux guest to misbehave, a

[RFC PATCH] qapi: net: fix -set parameter with modern style

2023-03-13 Thread Laurent Vivier
With netdev modern style, parameters cannot be found using qemu_find_opts_err() and then qemu_set_option() cannot find them to update them with the new option. To fix that, update the code to manage the modern style by searching the parameter in nd_queue, and update the entry using visit_type_Netd

[PULL 01/25] util: drop qemu_fork()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Fortunately, qemu_fork() is no longer used since commit a95570e3e4d6 ("io/command: use glib GSpawn, instead of open-coding fork/exec"). (GSpawn uses posix_spawn() whenever possible instead) Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20

[PULL 03/25] io: use closesocket()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Because they are actually sockets... Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20230221124802.4103554-4-marcandre.lur...@redhat.com> --- io/channel-socket.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/io/channe

[PULL 05/25] error: add global &error_warn destination

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau This can help debugging issues or develop, when error handling is introduced. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20230221124802.4103554-6-marcandre.lur...@redhat.com> --- include/qapi/error.h | 6 ++ tests/unit/test-

[PULL 02/25] tests: use closesocket()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Because they are actually sockets... Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20230221124802.4103554-3-marcandre.lur...@redhat.com> --- tests/unit/socket-helpers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t

[PULL 11/25] slirp: unregister the win32 SOCKET

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Presumably, this is what should happen when the SOCKET is to be removed. (it probably worked until now because closesocket() does it implicitly, but we never now how the slirp library could use the SOCKET later) Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger

[PULL 17/25] char: do not double-close fd when failing to add client

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The caller is already closing the fd on failure. Fixes: c3054a6e6a ("char: Factor out qmp_add_client() parts and move to chardev/") Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20230306122751.2355515-3-marc

[PULL 00/25] Win socket patches

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: Merge tag 'linux-user-for-8.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2023-03-12 10:57:00 +) are available in the Git repository at: https://gitlab.com/ma

[PULL 13/25] win32: avoid mixing SOCKET and file descriptor space

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Until now, a win32 SOCKET handle is often cast to an int file descriptor, as this is what other OS use for sockets. When necessary, QEMU eventually queries whether it's a socket with the help of fd_is_socket(). However, there is no guarantee of conflict between the fd and

[PULL 10/25] main-loop: remove qemu_fd_register(), win32/slirp/socket specific

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Open-code the socket registration where it's needed, to avoid artificially used or unclear generic interface. Furthermore, the following patches are going to make socket handling use FD-only inside QEMU, but we need to handle win32 SOCKET from libslirp. Signed-off-by: Ma

Re: [PULL 00/25] Win socket patches

2023-03-13 Thread Marc-André Lureau
Hi On Mon, Mar 13, 2023 at 3:43 PM wrote: > From: Marc-André Lureau > > The following changes since commit > 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: > > Merge tag 'linux-user-for-8.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2023-03-12 10:57:00 > +) > > are

[PULL 14/25] os-posix: remove useless ioctlsocket() define

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The API is specific to win32. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20230221124802.4103554-16-marcandre.lur...@redhat.com> --- include/sysemu/os-posix.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/sysemu/os-posix.h

[PULL 06/25] win32/socket: introduce qemu_socket_select() helper

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau This is a wrapper for WSAEventSelect, with Error handling. By default, it will produce a warning, so callers don't have to be modified now, and yet we can spot potential mis-use. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20230221124802.410

  1   2   3   4   >