Re: [PATCH v3 00/16] win32: do not mix SOCKET and fd space

2023-03-06 Thread Paolo Bonzini
On 3/2/23 15:09, Marc-André Lureau wrote: v3: - fix closesocket() to prevent CloseHandle() from close() - fix direct closesocket() usage (#undef closesocket before) - add a test for &error_warn - add r-b tags ping  (I am missing reviews, thanks) I'm going to queue this se

Re: [PATCH v3 00/20] tcg: drop tcg_temp_free from translators

2023-03-06 Thread Philippe Mathieu-Daudé
On 4/3/23 19:18, Richard Henderson wrote: Richard Henderson (20): target/i386: Drop tcg_temp_free target/mips: Drop tcg_temp_free from micromips_translate.c.inc target/mips: Drop tcg_temp_free from mips16e_translate.c.inc target/mips: Drop tcg_temp_free from msa_translate.c target

Re: [PATCH v3 00/16] win32: do not mix SOCKET and fd space

2023-03-06 Thread Marc-André Lureau
Hi Paolo On Mon, Mar 6, 2023 at 12:05 PM Paolo Bonzini wrote: > On 3/2/23 15:09, Marc-André Lureau wrote: > > > > > > v3: > > - fix closesocket() to prevent CloseHandle() from close() > > - fix direct closesocket() usage (#undef closesocket before) > > - add a test for &error_war

Re: [PATCH v11 0/5] riscv: Allow user to set the satp mode

2023-03-06 Thread Alexandre Ghiti
Hi Palmer, On Mon, Mar 6, 2023 at 12:34 AM Palmer Dabbelt wrote: > > On Fri, 03 Mar 2023 05:12:47 PST (-0800), alexgh...@rivosinc.com wrote: > > This introduces new properties to allow the user to set the satp mode, > > see patch 3 for full syntax. In addition, it prevents cpus to boot in a > > s

[PATCH v4 5/5] gitlab-ci.d/crossbuilds: Drop the 32-bit arm system emulation jobs

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit arm environments for running QEMU, so let's stop wasting our scarce CI minutes with these jobs. Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wilfred Mallawa Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuilds.yml | 14 --

[PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 binary is a proper superset of the qemu-system-i386 binary. With the 32-bit host support being deprecated, it is now also possible to deprecate the qemu-system-i386 binary. With regards to 32-bit KVM support in the x86 Linux ker

[PATCH v4 3/5] gitlab-ci.d/crossbuilds: Drop the i386 system emulation job

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 environments for running QEMU with full system emulation, so let's stop wasting our scarce CI minutes with this job. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit) Reviewed-by: Daniel P. Berrangé Reviewe

[PATCH v4 1/5] docs/about/deprecated: Deprecate 32-bit x86 hosts for system emulation

2023-03-06 Thread Thomas Huth
Hardly anybody still uses 32-bit x86 hosts today, so we should start deprecating them to stop wasting our time and CI minutes here. For example, there are also still some unresolved problems with these: When emulating 64-bit binaries in user mode, TCG does not honor atomicity for 64-bit accesses, w

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

2023-03-06 Thread Laszlo Ersek
On 3/5/23 09:41, Wouter Verhelst wrote: > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: >> On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy wrote: >>> s-o-b line missed. >> >> I'm not sure if the NBD project has a strict policy on including one, >> but I don't mi

[PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Thomas Huth
For running QEMU in system emulation mode, the user needs a rather strong host system, i.e. not only an embedded low-frequency controller. All recent beefy arm host machines should support 64-bit now, it's unlikely that anybody is still seriously using QEMU on a 32-bit arm CPU, so we deprecate the

[PATCH v4 0/5] Deprecate system emulation support for 32-bit x86 and arm hosts

2023-03-06 Thread Thomas Huth
We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. Hardly anybody uses QEMU system emulation on 32-bit x86 and arm hosts anymore, so it's time to deprecate these environments no

Re: [PATCH 1/2] target/arm: Add Neoverse-N1 registers

2023-03-06 Thread Marcin Juszkiewicz
W dniu 3.03.2023 o 17:15, Chen Baozi pisze: Add implementation defined registers for neoverse-n1 which would be accessed by TF-A. Signed-off-by: Chen Baozi Tested-by: Marcin Juszkiewicz ~ # cat /proc/cpuinfo processor : 0 BogoMIPS: 125.00 Features: fp asimd evtstrm aes

Re: stable releases

2023-03-06 Thread Thomas Huth
On 05/03/2023 11.27, Michael Tokarev wrote: Hi! For a few qemu major releases already, we did not have any stable minor releases. I'd love to change that, in order to consolidate efforts and to make better software in the end.  But I need some (hopefully minor) help here. I collected changes

[PATCH 0/1] hw/riscv: Add ACT related support

2023-03-06 Thread Weiwei Li
ACT tests play an important role in riscv tests. This patch tries to add related support to run ACT tests. The port is available here: https://github.com/plctlab/plct-qemu/tree/plct-act-upstream The ACT tests can be run on qemu-system-riscv32/64 with machine argument "-M spike,signature=,signatur

[PATCH 1/1] hw/riscv: Add signature dump function for spike to run ACT tests

2023-03-06 Thread Weiwei Li
Add signature and signature-granularity properties in spike to specify the target signatrue file and the line size for signature data. Recgonize the signature section between begin_signature and end_signature symbols when loading elf of ACT tests. Then dump signature data in signature section j

Re: KVM developers conference call agenda

2023-03-06 Thread Wei Wang
On 2/21/23 21:46, juan.quint...@gmail.com wrote: KVM developers conference call Hi for today call: Trivial stuff (less that 5mins each) - should we record the sessions - should we have the call every week. We have on the backburner: * TDX migration Hi Juan, Can I get 30 min (or more if no mo

Re: [PATCH v4 3/5] gitlab-ci.d/crossbuilds: Drop the i386 system emulation job

2023-03-06 Thread Philippe Mathieu-Daudé
On 6/3/23 09:46, Thomas Huth wrote: Hardly anybody still uses 32-bit x86 environments for running QEMU with full system emulation, so let's stop wasting our scarce CI minutes with this job. (There are still the 32-bit MinGW and TCI jobs around for having some compile test coverage on 32-bit) Re

Re: [PATCH v4 4/5] docs/about/deprecated: Deprecate 32-bit arm hosts for system emulation

2023-03-06 Thread Philippe Mathieu-Daudé
On 6/3/23 09:46, Thomas Huth wrote: For running QEMU in system emulation mode, the user needs a rather strong host system, i.e. not only an embedded low-frequency controller. All recent beefy arm host machines should support 64-bit now, it's unlikely that anybody is still seriously using QEMU on

Re: [PATCH] hw/intc/ioapic: Update KVM routes before redelivering IRQ, on RTE update

2023-03-06 Thread David Woodhouse
On Mon, 2023-03-06 at 06:51 +, David Woodhouse wrote: > On 5 March 2023 22:36:18 GMT, Peter Xu wrote: > > On Sun, Mar 05, 2023 at 06:43:42PM +, > > > --- > > > Alternative fixes might have been just to remove the part in > > > ioapic_service() which delivers the IRQ via kvm_set_irq() beca

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: > Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 > binary is a proper superset of the qemu-system-i386 binary. With the > 32-bit host support being deprecated, it is now also possible to > deprecate the qemu-system-

Re: [PATCH v5 13/16] fsdev: Disable proxy fs driver on Windows

2023-03-06 Thread Philippe Mathieu-Daudé
On 20/2/23 11:08, Bin Meng wrote: From: Guohuai Shi We don't plan to support 'proxy' file system driver for 9pfs on Windows. Disable it for Windows build. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- fsdev/qemu-fsdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fsdev

Re: [PATCH v5 03/16] hw/9pfs: Replace the direct call to xxxdir() APIs with a wrapper

2023-03-06 Thread Philippe Mathieu-Daudé
On 20/2/23 11:08, Bin Meng wrote: From: Guohuai Shi xxxdir() APIs are not safe on Windows host. For future extension to Windows, let's replace the direct call to xxxdir() APIs with a wrapper. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 14 ++ h

Re: [PATCH v5 03/16] hw/9pfs: Replace the direct call to xxxdir() APIs with a wrapper

2023-03-06 Thread Bin Meng
On Mon, Mar 6, 2023 at 5:32 PM Philippe Mathieu-Daudé wrote: > > On 20/2/23 11:08, Bin Meng wrote: > > From: Guohuai Shi > > > > xxxdir() APIs are not safe on Windows host. For future extension to > > Windows, let's replace the direct call to xxxdir() APIs with a wrapper. > > > > Signed-off-by: G

Re: [PATCH v3 00/13] vfio/migration: Device dirty page tracking

2023-03-06 Thread Joao Martins
On 06/03/2023 02:19, Alex Williamson wrote: > On Sun, 5 Mar 2023 23:33:35 + > Joao Martins wrote: > >> On 05/03/2023 20:57, Alex Williamson wrote: >>> On Sat, 4 Mar 2023 01:43:30 + >>> Joao Martins wrote: >>> Hey, Presented herewith a series based on the basic VFIO mig

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Thomas Huth
On 06/03/2023 10.27, Daniel P. Berrangé wrote: On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 binary is a proper superset of the qemu-system-i386 binary. With the 32-bit host support being deprecated, it is now a

Re: [PATCH 5/8] util/async: add smp_mb__after_rmw() around BH enqueue/dequeue

2023-03-06 Thread Paolo Bonzini
On 3/5/23 20:32, Richard Henderson wrote: On 3/3/23 09:19, Paolo Bonzini wrote:   unsigned old_flags;   /* * The memory barrier makes sure that: * 1. any writes needed by the callback are visible from the callback *    after aio_bh_dequeue() returns bh.   * 2. c

Re: [PATCH v4 2/5] docs/about/deprecated: Deprecate the qemu-system-i386 binary

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 10:54:15AM +0100, Thomas Huth wrote: > On 06/03/2023 10.27, Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 09:46:55AM +0100, Thomas Huth wrote: > > > Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64 > > > binary is a proper superset of the qemu-sy

[PATCH] linux-user: fill out task state in /proc/self/stat

2023-03-06 Thread Andreas Schwab
Some programs want to match an actual task state character. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 36fffd36ca..eb4c2c3162 100644 --- a/linux-user/syscall.c +++ b/linux-user/sy

Re: [PATCH v3 00/16] win32: do not mix SOCKET and fd space

2023-03-06 Thread Paolo Bonzini
On 3/6/23 09:08, Marc-André Lureau wrote: Great, thanks! (I suppose you'll drop "RFC: build-sys: add slirp.wrap", and perhaps queue the other meson/wrap series instead) I don't have time to test the dtc fallback in CI, so I'll queue only the first three patches and note it as experimental in t

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-06 Thread Jonathan Cameron via
On Fri, 3 Mar 2023 22:47:20 -0800 Ira Weiny wrote: > Jonathan Cameron wrote: > > Current implementation is very simple so many of the corner > > cases do not exist (e.g. fragmenting larger poison list entries) > > One coding style change at the bottom and I'm still hung up on that loop > logic

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Daniel P . Berrangé
On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > Meson "wrap" is a mechanism to build dependencies that doesn't rely on git > submodules and integrate external dependencies as subproject()s. > > This offers developpers a simpler

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Peter Maydell
On Mon, 6 Mar 2023 at 10:06, Daniel P. Berrangé wrote: > > On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > Meson "wrap" is a mechanism to build dependencies that doesn't rely on git > > submodules and integrate external

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Marc-André Lureau
Hi On Mon, Mar 6, 2023 at 2:06 PM Daniel P. Berrangé wrote: > On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > Hi, > > > > Meson "wrap" is a mechanism to build dependencies that doesn't rely on > git > > submodules and integrate

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Marc-André Lureau
Hi On Mon, Mar 6, 2023 at 2:18 PM Peter Maydell wrote: > On Mon, 6 Mar 2023 at 10:06, Daniel P. Berrangé > wrote: > > > > On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com > wrote: > > > From: Marc-André Lureau > > > > > > Hi, > > > > > > Meson "wrap" is a mechanism to buil

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Daniel P . Berrangé
On Mon, Mar 06, 2023 at 02:19:25PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Mar 6, 2023 at 2:06 PM Daniel P. Berrangé > wrote: > > > On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com > > wrote: > > > From: Marc-André Lureau > > > > > > Hi, > > > > > > Meson "wrap" is

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Marc-André Lureau
Hi On Mon, Mar 6, 2023 at 2:33 PM Daniel P. Berrangé wrote: > > On Mon, Mar 06, 2023 at 02:19:25PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Mon, Mar 6, 2023 at 2:06 PM Daniel P. Berrangé > > wrote: > > > > > On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lur...@redhat.com > > > wro

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-03-06 Thread Igor Mammedov
On Sat, 4 Mar 2023 21:10:54 +0700 Bui Quang Minh wrote: > On 2/28/23 23:39, Igor Mammedov wrote: > > On Tue, 28 Feb 2023 21:34:33 +0700 > > Bui Quang Minh wrote: > > > >> On 2/27/23 23:07, Igor Mammedov wrote: > >>> On Sat, 25 Feb 2023 17:15:17 +0700 > >>> Bui Quang Minh wrote: > >>>

Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots

2023-03-06 Thread Igor Mammedov
On Thu, 2 Mar 2023 18:21:28 -0500 "Michael S. Tsirkin" wrote: > On Thu, Mar 02, 2023 at 01:07:16PM +0100, Igor Mammedov wrote: > > On Thu, 2 Mar 2023 05:59:16 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote: > > > > Series extend

Re: [PATCH v3 13/20] target/s390x: Drop free_compare

2023-03-06 Thread Ilya Leoshkevich
On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > Translators are no longer required to free tcg temporaries. > Remove the g1 and g2 members of DisasCompare, as they were > used to track which temps needed to be freed. > > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand

Re: [PATCH v3 14/20] target/s390x: Drop tcg_temp_free from translate_vx.c.inc

2023-03-06 Thread Ilya Leoshkevich
On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand > Cc: Ilya Leoshkevich > Cc: Thomas Huth > Cc: qemu-s3...@nongnu.org > --- >  target/s390x/tcg/translate_

Re: [PATCH v3 15/20] target/s390x: Drop tcg_temp_free from translate.c

2023-03-06 Thread Ilya Leoshkevich
On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > Translators are no longer required to free tcg temporaries. > > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand > Cc: Ilya Leoshkevich > Cc: Thomas Huth > Cc: qemu-s3...@nongnu.org > --- >  target/s390x/tcg/translate.

Re: [PATCH v3 16/20] target/s390x: Remove assert vs g_in2

2023-03-06 Thread Ilya Leoshkevich
On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > These were trying to determine if o->in2 was available for > use as a temporary.  It's better to just allocate a new one. > > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand > Cc: Ilya Leoshkevich > Cc: Thomas Huth >

Re: [PATCH v2] hw: arm: Support direct boot for Linux/arm64 EFI zboot images

2023-03-06 Thread Peter Maydell
On Fri, 3 Mar 2023 at 16:01, Ard Biesheuvel wrote: > > Fedora 39 will ship its arm64 kernels in the new generic EFI zboot > format, using gzip compression for the payload. > > For doing EFI boot in QEMU, this is completely transparent, as the > firmware or bootloader will take care of this. Howeve

Re: [PATCH] linux-user: fill out task state in /proc/self/stat

2023-03-06 Thread Laurent Vivier
Le 06/03/2023 à 10:59, Andreas Schwab a écrit : Some programs want to match an actual task state character. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 36fffd36ca..eb4c2c3162 1

Re: [PATCH v3 15/20] target/s390x: Drop tcg_temp_free from translate.c

2023-03-06 Thread David Hildenbrand
On 04.03.23 19:18, Richard Henderson wrote: Translators are no longer required to free tcg temporaries. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc: Thomas Huth Cc: qemu-s3...@nongnu.org --- target/s390x/tcg/translate.c | 105 -

Re: [PATCH v3 14/20] target/s390x: Drop tcg_temp_free from translate_vx.c.inc

2023-03-06 Thread David Hildenbrand
On 04.03.23 19:18, Richard Henderson wrote: Translators are no longer required to free tcg temporaries. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc: Thomas Huth Cc: qemu-s3...@nongnu.org --- target/s390x/tcg/translate_vx.c.inc | 143 --

Re: [PATCH 1/1] hw/riscv: Add signature dump function for spike to run ACT tests

2023-03-06 Thread LIU Zhiwei
On 2023/3/6 17:03, Weiwei Li wrote: Add signature and signature-granularity properties in spike to specify the target signatrue file and the line size for signature data. Recgonize the signature section between begin_signature and end_signature symbols when loading elf of ACT tests. Then dum

Re: [PATCH v3 16/20] target/s390x: Remove assert vs g_in2

2023-03-06 Thread David Hildenbrand
On 04.03.23 19:18, Richard Henderson wrote: These were trying to determine if o->in2 was available for use as a temporary. It's better to just allocate a new one. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc: Thomas Huth Cc: qemu-s3...@nongnu.org ---

Re: [PATCH v3 17/20] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext

2023-03-06 Thread David Hildenbrand
On 04.03.23 19:18, Richard Henderson wrote: These fields are no longer read, so remove them and the writes. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc: Thomas Huth Cc: qemu-s3...@nongnu.org --- target/s390x/tcg/translate.c | 17 - 1

Re: [PATCH v3 13/20] target/s390x: Drop free_compare

2023-03-06 Thread David Hildenbrand
On 04.03.23 19:18, Richard Henderson wrote: Translators are no longer required to free tcg temporaries. Remove the g1 and g2 members of DisasCompare, as they were used to track which temps needed to be freed. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich Cc:

Re: [PATCH v3 00/13] vfio/migration: Device dirty page tracking

2023-03-06 Thread Cédric Le Goater
On 3/6/23 10:45, Joao Martins wrote: On 06/03/2023 02:19, Alex Williamson wrote: On Sun, 5 Mar 2023 23:33:35 + Joao Martins wrote: On 05/03/2023 20:57, Alex Williamson wrote: On Sat, 4 Mar 2023 01:43:30 + Joao Martins wrote: Hey, Presented herewith a series based on the basic

Re: [PATCH v3 17/20] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext

2023-03-06 Thread Ilya Leoshkevich
On Sat, 2023-03-04 at 10:18 -0800, Richard Henderson wrote: > These fields are no longer read, so remove them and the writes. > > Signed-off-by: Richard Henderson > --- > Cc: David Hildenbrand > Cc: Ilya Leoshkevich > Cc: Thomas Huth > Cc: qemu-s3...@nongnu.org > --- >  target/s390x/tcg/transl

Re: [PATCH 3/3] target/arm: Support reading ZA[] from gdbstub

2023-03-06 Thread Peter Maydell
On Tue, 28 Feb 2023 at 00:37, Richard Henderson wrote: > > Mirror the existing support for SVE. > > Signed-off-by: Richard Henderson > --- > +g_string_printf(s, ""); > +g_string_append_printf(s, ""); > +g_string_append_printf(s, ""); Isn't there an upstream-gdb-defined way to acces

[PATCH V2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-06 Thread Viresh Kumar
The current model of memory mapping at the back-end works fine where a standard call to mmap() (for the respective file descriptor) is enough before the front-end can start accessing the guest memory. There are other complex cases though where the back-end needs more information and simple mmap()

Re: test-blockjob: intermittent CI failures in msys2-64bit job

2023-03-06 Thread Peter Maydell
On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote: > > I've noticed that test-blockjob seems to fail intermittently > on the msys2-64bit job: > > https://gitlab.com/qemu-project/qemu/-/jobs/3872508803 > https://gitlab.com/qemu-project/qemu/-/jobs/3871061024 > https://gitlab.com/qemu-project/qemu/-/

Re: [PATCH 1/2] target/riscv: Expose "virt" register for GDB for reads

2023-03-06 Thread LIU Zhiwei
On 2023/3/5 17:42, Jim Shu wrote: This patch enables a debugger to read current virtualization mode via virtual "virt" register. After it, we could get full current privilege mode via both "priv" and "virt" register. Extend previous commit ab9056ff9bdb3f95db6e7a666d10522d289f14ec to support H-

Re: [PATCH 2/2] target/riscv: Make the "virt" register writable by GDB

2023-03-06 Thread LIU Zhiwei
On 2023/3/5 17:42, Jim Shu wrote: This patch also enables debugger to set current privilege mode to VU/VS-mode. Extend previous commit 81d2929c41d32af138f3562f5a7b309f6eac7ca7 to support H-extension. Signed-off-by: Jim Shu Reviewed-by: Frank Chang --- target/riscv/gdbstub.c | 18 +

Re: [PATCH v2 1/3] migration: Merge ram_counters and ram_atomic_counters

2023-03-06 Thread David Edmondson
Juan Quintela writes: > Using MgrationStats as type for ram_counters mean that we didn't have Minor typo - MigrationStatus. > to re-declare each value in another struct. The need of atomic > counters have make us to create MigrationAtomicStats for this atomic > counters. > > Create RAMStats typ

Re: [PATCH v4 12/15] vdpa: block migration if device has unsupported features

2023-03-06 Thread Eugenio Perez Martin
On Mon, Mar 6, 2023 at 4:42 AM Jason Wang wrote: > > On Fri, Mar 3, 2023 at 4:58 PM Eugenio Perez Martin > wrote: > > > > On Fri, Mar 3, 2023 at 4:48 AM Jason Wang wrote: > > > > > > > > > 在 2023/3/2 03:32, Eugenio Perez Martin 写道: > > > > On Mon, Feb 27, 2023 at 9:20 AM Jason Wang wrote: > >

Re: [PATCH 1/2] target/arm: Add Neoverse-N1 registers

2023-03-06 Thread Peter Maydell
On Fri, 3 Mar 2023 at 16:15, Chen Baozi wrote: > > Add implementation defined registers for neoverse-n1 which > would be accessed by TF-A. > > Signed-off-by: Chen Baozi > --- > target/arm/cpu64.c | 2 ++ > target/arm/cpu_tcg.c | 62 ++ > target/arm/

Re: [PATCH 0/4] Add meson wrap fallback for slirp & dtc

2023-03-06 Thread Paolo Bonzini
On 3/6/23 11:06, Daniel P. Berrangé wrote: This offers developpers a simpler way to build QEMU with missing system dependencies (ex, libslirp in my case), but also simplify the fallback build definition of dtc/libfdt. Do we actually need this facility though ? We've already determined that every

Re: [PATCH] virtio: refresh vring region cache after updating a virtqueue size

2023-03-06 Thread Thomas Huth
On 02/03/2023 11.14, Carlos López wrote: When a virtqueue size is changed by the guest via virtio_queue_set_num(), its region cache is not automatically updated. If the size was increased, this could lead to accessing the cache out of bounds. For example, in vring_get_used_event(): static i

Re: [PATCH] migration: move migration_global_dump() to migration-hmp-cmds.c

2023-03-06 Thread David Edmondson
Juan Quintela writes: > It is only used there, so we can make it static. > Once there, remove spice.h that it is not used. The removal of ui/qemu-spice.h seems like an unrelated change - should be a different changeset? > > Signed-off-by: Juan Quintela > --- > include/migration/misc.h |

Re: hexagon: check-tcg rebuilding up to date image

2023-03-06 Thread Matheus Tavares Bernardino
Alex Bennée writes: > > Fabiano Rosas writes: > > > > > I think we might need to add DOCKER_BUILDKIT=1 $(RUNC) ... to properly > > make use of caching with docker. As for podman, I'm seeing conflicting > > information on the web as to whether it even supports caching. > > As opposed to --build

[PATCH v4 01/11] tests: fix path separator, use g_build_filename()

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- tests/unit/test-io-channel-command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel

[PATCH v4 02/11] char: do not double-close fd when failing to add client

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau The caller is already closing the fd on failure. Fixes: c3054a6e6a ("char: Factor out qmp_add_client() parts and move to chardev/") Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- chardev/char.c | 2 -- 1 file changed

[PATCH v4 06/11] monitor: release the lock before calling close()

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau As per comment, presumably to avoid syscall in critical section. Fixes: 0210c3b39bef08 ("monitor: Use LOCK_GUARD macros") Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- monitor/fds.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

[PATCH v4 00/11] QMP command to import win32 sockets

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, The series focuses on 'add_client' win32 support, by limiting its scope to sockets and adding a new command to import sockets. This enables vnc-display test on win32, exercising the new code paths. (a follow up series will add dbus display support on win32, with test

[PATCH v4 03/11] tests/docker: fix a win32 error due to portability

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau docker.py is run during configure, and produces an error: No module named 'pwd'. Use a more portable and recommended alternative to lookup the user "login name". Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 6 +++---

[PATCH v4 07/11] qapi/gen: run C code through clang-format, if possible

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Make the resulting code even prettier, if possible. Signed-off-by: Marc-André Lureau --- scripts/qapi/gen.py| 15 ++- scripts/qapi/introspect.py | 2 ++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/gen.py b/scripts/qap

[PATCH v4 09/11] libqtest: make qtest_qmp_add_client work on win32

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Use the "get-win32-socket" function to pass an opened socket to QEMU, instead of using "getfd", which relies on socket ancillary FD message passing. Signed-off-by: Marc-André Lureau --- tests/qtest/libqtest.h | 5 ++--- tests/qtest/libqtest.c | 18 -- 2

[PATCH v4 05/11] qmp: 'add_client' actually expects sockets

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Whether it is SPICE, VNC, D-Bus, or the socket chardev, they all actually expect a socket kind or will fail in different ways at runtime. Throw an error early if the given 'add_client' fd is not a socket, and close it to avoid leaks. This allows to replace the close() ca

[PATCH v4 10/11] qtest: enable vnc-display test on win32

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Now that qtest_qmp_add_client() works on win32, we can enable the VNC test. Signed-off-by: Marc-André Lureau Acked-by: Thomas Huth --- tests/qtest/vnc-display-test.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/qtest/vnc-displa

[PATCH v4 11/11] QMP/HMP: only actually implement getfd on CONFIG_POSIX

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Currently, the function will simply fail if ancillary fds are not provided, for ex on unsupported platforms. Signed-off-by: Marc-André Lureau --- qapi/misc.json | 2 +- monitor/fds.c | 2 ++ monitor/hmp-cmds.c | 2 ++ hmp-commands.hx| 2 ++ 4 files changed,

[PATCH v4 04/11] osdep: implement qemu_socketpair() for win32

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau Manually implement a socketpair() function, using UNIX sockets and simple peer credential checking. QEMU doesn't make much use of socketpair, beside vhost-user which is not available for win32 at this point. However, I intend to use it for writing some new portable tests.

Re: [PATCH 2/2] target/arm: Add DynamIQ Shared Unit control registers

2023-03-06 Thread Peter Maydell
On Fri, 3 Mar 2023 at 16:16, Chen Baozi wrote: > > DynamIQ Shared Unit (DSU) contains system control registers in the SCU > and L3 logic which are implemented as the system registers for the cores > in the cluster. Add DSU control registers and enable it to the supported > cores. > > Signed-off-by

Re: [PATCH] Add qemu qcode support for keys F13 to F24

2023-03-06 Thread Alex Bennée
Willem van de Velde writes: > To be able to use the function keys F13 to F24 these should be defined in de > keycodemapdb and added to the qapi. > The keycodemapdb is updated in its own repository, this patch enables the use > of those keys within qemu. > > Signed-off-by: Willem van de Velde

[PATCH v4 08/11] qmp: add 'get-win32-socket'

2023-03-06 Thread marcandre . lureau
From: Marc-André Lureau A process with enough capabilities can duplicate a socket to QEMU. Add a QMP command to import it and add it to the monitor fd list, so it can be later used by other commands. Signed-off-by: Marc-André Lureau --- qapi/misc.json | 30 monitor/fds.c

[PATCH v8 0/6] Pegasos2 fixes and audio output support

2023-03-06 Thread BALATON Zoltan
Changes in this version: v8: - Last change to logging in patch 3 as asked by Bernhard v7: - Added a comment and log to patch 3 as asked by Bernhard - Added missed R-b tag to patch 5 - Patch 4 in this version is Based-on: <20230304114043.121024-1-shen...@gmail.com> (hw/isa/vt82c686: Fix wiring of

[PATCH v8 4/6] hw/ppc/pegasos2: Fix PCI interrupt routing

2023-03-06 Thread BALATON Zoltan
According to the PegasosII schematics the PCI interrupt lines are connected to both the gpp pins of the Mv64361 north bridge and the PINT pins of the VT8231 south bridge so guests can get interrupts from either of these. So far we only had the MV64361 connections which worked for on board devices b

[PATCH v8 2/6] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select

2023-03-06 Thread BALATON Zoltan
From: David Woodhouse Back in the mists of time, before EISA came along and required per-pin level control in the ELCR register, the i8259 had a single chip-wide level-mode control in bit 3 of ICW1. Even in the PIIX3 datasheet from 1996 this is documented as 'This bit is disabled', but apparentl

[PATCH v8 3/6] hw/isa/vt82c686: Implement PCI IRQ routing

2023-03-06 Thread BALATON Zoltan
The real VIA south bridges implement a PCI IRQ router which is configured by the BIOS or the OS. In order to respect these configurations, QEMU needs to implement it as well. The real chip may allow routing IRQs from internal functions independently of PCI interrupts but since guests usually config

[PATCH v8 5/6] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing

2023-03-06 Thread BALATON Zoltan
From: Bernhard Beschow According to the PCI specification, PCI_INTERRUPT_LINE shall have no effect on hardware operations. Now that the VIA south bridges implement the internal PCI interrupt router let's be more conformant to the PCI specification. Signed-off-by: Bernhard Beschow Reviewed-by: M

[PATCH v8 1/6] hw/display/sm501: Add debug property to control pixman usage

2023-03-06 Thread BALATON Zoltan
Add a property to allow disabling pixman and always use the fallbacks for different operations which is useful for testing different drawing methods or debugging pixman related issues. Signed-off-by: BALATON Zoltan Tested-by: Rene Engel --- hw/display/sm501.c | 18 +++--- 1 file cha

[PATCH v8 6/6] hw/audio/via-ac97: Basic implementation of audio playback

2023-03-06 Thread BALATON Zoltan
Add basic implementation of the AC'97 sound part used in VIA south bridge chips. Not all features of the device is emulated, only one playback channel is supported for now but this is enough to get sound output from some guests using this device on pegasos2. Signed-off-by: BALATON Zoltan Reviewed

Re: [PATCH 1/3] target/arm: Avoid splitting Zregs across lines in dump

2023-03-06 Thread Peter Maydell
On Tue, 28 Feb 2023 at 00:37, Richard Henderson wrote: > > Allow the line length to extend to 548 columns. While annoyingly wide, > it's still less confusing than the continuations we print. Also, the > default VL used by Linux (and max for A64FX) uses only 140 columns. > > Signed-off-by: Richar

Re: [PATCH 2/3] target/arm: Dump ZA[] when active

2023-03-06 Thread Peter Maydell
On Tue, 28 Feb 2023 at 00:37, Richard Henderson wrote: > > Always print each matrix row whole, one per line, so that we > get the entire matrix in the proper shape. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: hexagon: check-tcg rebuilding up to date image

2023-03-06 Thread Fabiano Rosas
Alex Bennée writes: > Fabiano Rosas writes: > >> Matheus Tavares Bernardino writes: >> >>> Hi, >>> >>> We noticed that local `make check-tcg` is rebuilding the docker image >>> for qemu-hexagon at every run, whereas previously it would say "Image is >>> up to date" and move on. >>> >>> This was

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-06 Thread Chuang Xu
Hi, Peter, On 2023/3/6 上午6:05, Peter Xu wrote: Hi, Chuang, On Fri, Mar 03, 2023 at 06:56:50PM +0800, Chuang Xu wrote: Sorry to forget to update the test results in the last patch of v6. In this version: - add peter's patch. - split mr_do_commit() from mr_commit(). - adjust the sanity check i

Re: [PATCH v3 0/6] Support for new CPU model SapphireRapids

2023-03-06 Thread Igor Mammedov
On Tue, 7 Feb 2023 10:50:56 +0800 "Wang, Lei" wrote: > On 2/2/2023 7:05 PM, Igor Mammedov wrote: > > On Fri, 6 Jan 2023 00:38:20 -0800 > > Lei Wang wrote: > > > >> This series aims to add a new CPU model SapphireRapids, and tries to > >> address the problem stated in > >> https://lore.kernel

Re: [PATCH v9 08/14] hw/nvram: NPCM7xx OTP device model

2023-03-06 Thread Philippe Mathieu-Daudé
On 5/3/23 08:41, avi.fish...@nuvoton.com wrote: Hi, Inside -Original Message- From: Philippe Mathieu-Daudé Sent: Thursday, December 22, 2022 5:03 PM To: Havard Skinnemoen ; peter.mayd...@linaro.org Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; IS20 Avi Fishman ; CS20 KFTing ; Alexa

Re: [PATCH 1/9] linux-user: Diagnose incorrect -R size

2023-03-06 Thread Peter Maydell
On Mon, 6 Mar 2023 at 02:14, Richard Henderson wrote: > > Zero is the value for 'off', and should not be used with -R. > We have been enforcing host page alignment for the non-R > fallback of MAX_RESERVED_VA, but failing to enforce for -R. I'm pretty sure we have users who specifically use "-R 0"

Re: [RESEND PATCH 1/1] pc-bios: Add support for List-Directed IPL from ECKD DASD

2023-03-06 Thread Thomas Huth
On 21/02/2023 18.45, jro...@linux.ibm.com wrote: From: Jared Rossi Check for a List Directed IPL Boot Record, which would supersede the CCW type entries. If the record is valid, proceed to use the new style pointers and perform LD-IPL. Each block pointer is interpreted as either an LD-IPL poin

Re: [PATCH 1/1] hw/riscv: Add signature dump function for spike to run ACT tests

2023-03-06 Thread liweiwei
On 2023/3/6 19:00, LIU Zhiwei wrote: On 2023/3/6 17:03, Weiwei Li wrote: Add signature and signature-granularity properties in spike to specify the target signatrue file and the line size for signature data. Recgonize the signature section between begin_signature and end_signature symbols

Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel

2023-03-06 Thread Thomas Huth
On 03/03/2023 13.05, Peter Maydell wrote: On Fri, 3 Mar 2023 at 11:29, Thomas Huth wrote: On 03/03/2023 12.18, Peter Maydell wrote: On Fri, 3 Mar 2023 at 09:10, Juan Quintela wrote: Daniel P. Berrangé wrote: On Thu, Mar 02, 2023 at 05:22:11PM +, Peter Maydell wrote: migration-test h

Re: [PULL 14/53] virtio-rng-pci: fix transitional migration compat for vectors

2023-03-06 Thread Dr. David Alan Gilbert
* Michael Tokarev (m...@tls.msk.ru) wrote: > 02.03.2023 11:25, Michael S. Tsirkin wrote: > > From: "Dr. David Alan Gilbert" > > > > In bad9c5a516 ("virtio-rng-pci: fix migration compat for vectors") I > > fixed the virtio-rng-pci migration compatibility, but it was discovered > > that we also nee

Re: [RFC PATCH v1 00/12] *** Add allwinner R40 device support ***

2023-03-06 Thread Peter Maydell
On Thu, 2 Mar 2023 at 11:41, wrote: > > From: qianfan Zhao > > v1: 2023-03-02 > > The first three patches try fix allwinner i2c driver and I already send them > as a standalone PR and can read it from: > > https://patchwork.kernel.org/project/qemu-devel/patch/20230220081252.25348-3-qianfangui...@

Re: [PATCH RESEND v7 5/9] tests/avocado: Pass parameters to migration test

2023-03-06 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Tue, 28 Feb 2023 at 19:28, Fabiano Rosas wrote: > > > > The migration tests are currently broken for an aarch64 host because > > the tests pass no 'machine' and 'cpu' options on the QEMU command > > line. > > > > Add a separate class to each a

Re: [PATCH v3 04/13] vfio/common: Add VFIOBitmap and alloc function

2023-03-06 Thread Cédric Le Goater
On 3/4/23 02:43, Joao Martins wrote: From: Avihai Horon There are already two places where dirty page bitmap allocation and calculations are done in open code. With device dirty page tracking being added in next patches, there are going to be even more places. To avoid code duplication, introd

Re: [PATCH 1/8] qatomic: add smp_mb__before/after_rmw()

2023-03-06 Thread David Hildenbrand
On 03.03.23 18:19, Paolo Bonzini wrote: On ARM, seqcst loads and stores (which QEMU does not use) are compiled respectively as LDAR and STLR instructions. Even though STLR is also used for store-release operations, STLR followed by LDAR provides store-against-load ordering, which is stronger tha

  1   2   3   4   5   6   >