Alex Bennée <alex.ben...@linaro.org> writes: > Fabiano Rosas <faro...@suse.de> writes: > >> Matheus Tavares Bernardino <quic_mathb...@quicinc.com> writes: >> >>> Hi, >>> >>> We noticed that local `make check-tcg` is rebuilding the docker image >>> for qemu-hexagon at every run, whereas previously it would say "Image is >>> up to date" and move on. >>> >>> This was changed at 0b1a649047 (tests/docker: use direct RUNC call to >>> build containers, 2023-02-28), where we started to no longer use >>> docker.py and its image_matches_dockerfile() to skip image builds. >>> >>> Is this new behavior by design? Or perhaps do we have some local >>> docker misconfiguration that is not correctly using caches? >> >> Hi, >> >> We started relying on docker for the cache. Are you using docker or >> podman? There should be a RUNC variable in config-host.mak that you can >> check. >> >> And for the record, which version of either podman or docker? >> >> >> Alex, >> >> I think we might need to add DOCKER_BUILDKIT=1 $(RUNC) ... to properly >> make use of caching with docker. As for podman, I'm seeing conflicting >> information on the web as to whether it even supports caching. > > As opposed to --build-arg BUILDKIT_INLINE_CACHE=1 or both?
Both. As I understand it, DOCKER_BUILDKIT=1 enables buildkit and BUILDKIT_INLINE_CACHE=1 embeds metadata in the image so that when you push/pull the metadata goes along (as opposed to having the cache as a separate artifact from the image).