Re: [PATCH] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Thomas Huth
On 24/02/2023 08.56, Sunil V L wrote: On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote: Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays. Signed-off-by: Thomas Huth --- docs/about/deprec

Re: [PATCH] .gitlab-ci.d/base: Mark jobs as interruptible by default

2023-02-24 Thread Philippe Mathieu-Daudé
On 24/2/23 07:22, Thomas Huth wrote: On 23/02/2023 21.23, Philippe Mathieu-Daudé wrote: On 23/2/23 20:13, Thomas Huth wrote: When handling pull requests in the staging branch, it often happens that one of the job fails due to a problem, so that the pull request can't be merged. Peter/Richard/St

Re: [PATCH] .gitlab-ci.d/base: Mark jobs as interruptible by default

2023-02-24 Thread Thomas Huth
On 24/02/2023 09.01, Philippe Mathieu-Daudé wrote: On 24/2/23 07:22, Thomas Huth wrote: On 23/02/2023 21.23, Philippe Mathieu-Daudé wrote: On 23/2/23 20:13, Thomas Huth wrote: When handling pull requests in the staging branch, it often happens that one of the job fails due to a problem, so tha

Re: [PATCH v2 28/28] tcg: Use noinline for major tcg_gen_code_subroutines

2023-02-24 Thread Philippe Mathieu-Daudé
On 23/2/23 00:27, Richard Henderson wrote: This makes it easier to assign blame with perf. Signed-off-by: Richard Henderson --- tcg/tcg.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 03/28] accel/tcg: Use more accurate max_insns for tb_overflow

2023-02-24 Thread Philippe Mathieu-Daudé
On 23/2/23 00:26, Richard Henderson wrote: Write back the number of insns that we attempt to translate, so that if we longjmp out we have a more accurate limit for the next attempt. This results in fewer restarts when some limit is consumed by few instructions. Signed-off-by: Richard Henderson

Re: [PATCH] accel/tcg: Add 'size' param to probe_access_full

2023-02-24 Thread Richard Henderson
On 2/23/23 20:57, Philippe Mathieu-Daudé wrote: On 24/2/23 01:45, Richard Henderson wrote: Change to match the recent change to probe_access_flags. All existing callers updated to supply 0, so no change in behaviour. Signed-off-by: Richard Henderson ---   include/exec/exec-all.h  |

Re: [PATCH v2 04/28] tcg: Remove branch-to-next regardless of reference count

2023-02-24 Thread Philippe Mathieu-Daudé
On 23/2/23 00:26, Richard Henderson wrote: Just because the label reference count is more than 1 does not mean we cannot remove a branch-to-next. By doing this first, the label reference count may drop to 0, and then the label itself gets removed as before. Signed-off-by: Richard Henderson ---

Re: [PATCH] .gitlab-ci.d/base: Mark jobs as interruptible by default

2023-02-24 Thread Philippe Mathieu-Daudé
On 24/2/23 09:03, Thomas Huth wrote: On 24/02/2023 09.01, Philippe Mathieu-Daudé wrote: On 24/2/23 07:22, Thomas Huth wrote: On 23/02/2023 21.23, Philippe Mathieu-Daudé wrote: On 23/2/23 20:13, Thomas Huth wrote: When handling pull requests in the staging branch, it often happens that one of

Re: [PULL v2 00/36] Testing, docs, semihosting and plugin updates

2023-02-24 Thread Philippe Mathieu-Daudé
On 24/2/23 05:51, Akihiko Odaki wrote: On 2023/02/23 21:59, Philippe Mathieu-Daudé wrote: On 3/2/23 18:38, Philippe Mathieu-Daudé wrote: On 2/2/23 17:01, Alex Bennée wrote: Testing, docs, semihosting and plugin updates -

Re: [PATCH] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Sunil V L
On Fri, Feb 24, 2023 at 08:59:41AM +0100, Thomas Huth wrote: > On 24/02/2023 08.56, Sunil V L wrote: > > On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote: > > > Similar to "-no-hpet", the "-no-acpi" switch is a legacy command > > > line option that should be replaced with the "acpi" mach

Re: [PATCH v3 1/5] hw/nvme: move adjustment of data_units{read,written}

2023-02-24 Thread Joel Granados
On Mon, Feb 20, 2023 at 12:59:22PM +0100, Jesper Devantier wrote: > From: Joel Granados > > In order to return the units_{read/written} required by the SMART log we > need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply > by 1000. This is a prep patch that moves this adjustme

[PATCH] virtio-balloon: optimize the virtio-balloon on the ARM platform.

2023-02-24 Thread Yangming via
Optimize the virtio-balloon feature on the ARM platform by adding a variable to keep track of the current hot-plugged pc-dimm size, instead of traversing the virtual machine's memory modules to count the current RAM size during the balloon inflation or deflation process. This variable can be u

Re: [PATCH] virtio-balloon: optimize the virtio-balloon on the ARM platform.

2023-02-24 Thread Michael S. Tsirkin
On Fri, Feb 24, 2023 at 08:23:40AM +, Yangming wrote: > > Optimize the virtio-balloon feature on the ARM platform by adding a variable > to keep track of the current hot-plugged pc-dimm size, instead of traversing > the virtual machine's memory modules to count the current RAM size during th

Re: [PATCH] cpu/i386: update xsave components after CPUID filtering

2023-02-24 Thread Paolo Bonzini
On 11/23/22 19:17, Huanyu ZHAI wrote: Subject: [PATCH] cpu/i386: update xsave components after CPUID filtering On i386 platform, CPUID data are setup through three consecutive steps: CPU model definition, expansion and filtering. XSAVE components are enabled during the expansion stage, by che

[PATCH V4 0/8] Add basic ACPI support for risc-v virt

2023-02-24 Thread Sunil V L
This series adds the basic ACPI support for the RISC-V virt machine. Currently only RINTC interrupt controller specification is approved by the UEFI forum. External interrupt controller support in ACPI is in progress. The basic infrastructure changes are mostly leveraged from ARM. This adds supp

[PATCH V4 2/8] hw/riscv/virt: Add a switch to disable ACPI

2023-02-24 Thread Sunil V L
ACPI will be enabled by default. Add a switch to turn off for testing and debug purposes. Signed-off-by: Sunil V L Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 29 + include/hw/riscv/virt.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/hw/riscv/

[PATCH V4 7/8] hw/riscv/virt.c: Initialize the ACPI tables

2023-02-24 Thread Sunil V L
Initialize the ACPI tables if the acpi option is not disabled. Signed-off-by: Sunil V L Reviewed-by: Bin Meng Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index bcbacf4e63..126352d480 100644 --- a/hw/ris

[PATCH V4 1/8] hw/riscv/virt: Add OEM_ID and OEM_TABLE_ID fields

2023-02-24 Thread Sunil V L
ACPI needs OEM_ID and OEM_TABLE_ID for the machine. Add these fields in the RISCVVirtState structure and initialize with default values. Signed-off-by: Sunil V L Reviewed-by: Bin Meng Acked-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/riscv/virt.c | 5 + include/hw/riscv/

[PATCH V4 4/8] hw/riscv/virt: Enable basic ACPI infrastructure

2023-02-24 Thread Sunil V L
Add basic ACPI infrastructure for RISC-V with below tables. 1) DSDT with below basic objects - CPUs - fw_cfg 2) FADT revision 6 with HW_REDUCED flag 3) XSDT 4) RSDP Add this functionality in a new file virt-acpi-build.c and enable bui

[PATCH V4 5/8] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT

2023-02-24 Thread Sunil V L
Add Multiple APIC Description Table (MADT) with the RINTC structure for each cpu. Signed-off-by: Sunil V L Acked-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/riscv/virt-acpi-build.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/hw/riscv/vi

[PATCH V4 6/8] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table

2023-02-24 Thread Sunil V L
RISC-V ACPI platforms need to provide RISC-V Hart Capabilities Table (RHCT). Add this to the ACPI tables. Signed-off-by: Sunil V L Reviewed-by: Andrew Jones --- hw/riscv/virt-acpi-build.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/hw/riscv/virt-a

[PATCH V4 8/8] MAINTAINERS: Add entry for RISC-V ACPI

2023-02-24 Thread Sunil V L
RISC-V ACPI related functionality for virt machine is added in virt-acpi-build.c. Add the maintainer entry after moving the ARM ACPI entry under the main ACPI entry. Signed-off-by: Sunil V L Reviewed-by: Bin Meng Acked-by: Alistair Francis Reviewed-by: Andrew Jones --- MAINTAINERS | 18 ++

Re: [PATCH] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Thomas Huth
On 24/02/2023 09.20, Sunil V L wrote: On Fri, Feb 24, 2023 at 08:59:41AM +0100, Thomas Huth wrote: On 24/02/2023 08.56, Sunil V L wrote: On Fri, Feb 24, 2023 at 08:34:41AM +0100, Thomas Huth wrote: Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be repl

[PATCH V4 3/8] hw/riscv/virt: Add memmap pointer to RiscVVirtState

2023-02-24 Thread Sunil V L
memmap needs to be exported outside of virt.c so that modules like acpi can use it. Hence, add a pointer field in RiscVVirtState structure and initialize it with the memorymap. Signed-off-by: Sunil V L Reviewed-by: Bin Meng Acked-by: Alistair Francis Reviewed-by: Andrew Jones --- hw/riscv/vir

Re: [PATCH v2 01/18] hw/isa: Rename isa_get_dma() -> isa_bus_get_dma()

2023-02-24 Thread Thomas Huth
On 15/02/2023 17.16, Philippe Mathieu-Daudé wrote: isa_get_dma() returns a DMA channel handler from an ISABus. To emphasize this, rename it as isa_bus_get_dma(). Mechanical change using: $ sed -i -e 's/isa_get_dma/isa_bus_get_dma/g' \ $(git grep -l isa_get_dma) Signed-off-by: Phili

Re: [PATCH v2 02/18] hw/isa: Factor isa_bus_get_irq() out of isa_get_irq()

2023-02-24 Thread Thomas Huth
On 15/02/2023 17.16, Philippe Mathieu-Daudé wrote: isa_get_irq() was added in commit 3a38d437ca ("Add isa_reserve_irq()" Fri Aug 14 11:36:15 2009) as: a temporary interface to be used to allocate ISA IRQs for devices which have not yet been converted to qdev, and for special cases

Re: [PATCH v3 1/1] vhost-user-fs: add migration type property

2023-02-24 Thread Michael S. Tsirkin
On Thu, Feb 23, 2023 at 04:24:43PM -0500, Stefan Hajnoczi wrote: > On Thu, Feb 23, 2023 at 02:36:33AM -0500, Michael S. Tsirkin wrote: > > On Wed, Feb 22, 2023 at 03:21:42PM -0500, Michael S. Tsirkin wrote: > > > On Wed, Feb 22, 2023 at 08:25:19PM +0200, Anton Kuchin wrote: > > > > On 22/02/2023 19

Re: [PATCH v2 03/18] hw: Replace isa_get_irq() by isa_bus_get_irq() when ISABus is available

2023-02-24 Thread Thomas Huth
On 15/02/2023 17.16, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/cs4231a.c | 5 +++-- hw/audio/gus.c | 5 +++-- hw/audio/sb16.c | 7 --- hw/block/fdc-isa.c | 5 +++-- include/hw/timer/i8254.h | 3 ++- 5 files changed,

Re: [PATCH v3 3/5] hw/nvme: add basic endurance group support

2023-02-24 Thread Joel Granados
On Mon, Feb 20, 2023 at 12:59:24PM +0100, Jesper Devantier wrote: > From: Klaus Jensen > > Add the mandatory Endurance Group identify data structures and log > pages. > > For now, all namespaces in a subsystem belongs to a single Endurance > Group. > > Signed-off-by: Klaus Jensen > --- > hw/n

Re: [RFC PATCH 0/1] ci: Speed up container stage

2023-02-24 Thread Daniel P . Berrangé
On Thu, Feb 23, 2023 at 05:30:58PM -0300, Fabiano Rosas wrote: > > Hi Alex, > > > Daniel P. Berrangé writes: > > > >> On Thu, Feb 23, 2023 at 11:21:53AM -0300, Fabiano Rosas wrote: > >>> I'm not sure if this was discussed previously, but I noticed we're not > >>> pulling the images we push to th

[PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Thomas Huth
Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays. Signed-off-by: Thomas Huth --- v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!) docs/about/deprecated.rst | 6 ++ softmmu/vl.

Re: [PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Sunil V L
On Fri, Feb 24, 2023 at 10:05:43AM +0100, Thomas Huth wrote: > Similar to "-no-hpet", the "-no-acpi" switch is a legacy command > line option that should be replaced with the "acpi" machine parameter > nowadays. > > Signed-off-by: Thomas Huth > --- > v2: Fixed stypid copy-n-paste bug (Thanks to

Re: out of CI pipeline minutes again

2023-02-24 Thread Gerd Hoffmann
On Thu, Feb 23, 2023 at 10:11:11PM +, Eldon Stegall wrote: > On Thu, Feb 23, 2023 at 03:33:00PM +, Daniel P. Berrangé wrote: > > IIUC, we already have available compute resources from a couple of > > sources we could put into service. The main issue is someone to > > actually configure them

Re: [PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Peter Krempa
On Fri, Feb 24, 2023 at 10:05:43 +0100, Thomas Huth wrote: > Similar to "-no-hpet", the "-no-acpi" switch is a legacy command > line option that should be replaced with the "acpi" machine parameter > nowadays. > > Signed-off-by: Thomas Huth > --- > v2: Fixed stypid copy-n-paste bug (Thanks to Su

Re: [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags()

2023-02-24 Thread Daniel Henrique Barboza
On 2/23/23 21:23, Richard Henderson wrote: On 2/23/23 14:19, Richard Henderson wrote: On 2/23/23 13:44, Daniel Henrique Barboza wrote: +    if (unlikely(flags & TLB_NOTDIRTY)) { +    notdirty_write(env_cpu(env), addr, 1, full, retaddr); That '1' should be 'size'.  Fixed locally. Hmph

Re: [PATCH v2 0/4] NUMA: Apply socket-NUMA-node boundary for aarch64 and RiscV machines

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 04:09, Gavin Shan wrote: On 2/24/23 12:18 AM, Daniel Henrique Barboza wrote: On 2/23/23 05:13, Gavin Shan wrote: For arm64 and RiscV architecture, the driver (/base/arch_topology.c) is used to populate the CPU topology in the Linux guest. It's required that the CPUs in one socket

Re: [PATCH] accel/tcg: Add 'size' param to probe_access_full

2023-02-24 Thread Daniel Henrique Barboza
On 2/23/23 21:45, Richard Henderson wrote: Change to match the recent change to probe_access_flags. All existing callers updated to supply 0, so no change in behaviour. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza include/exec/exec-all.h | 2 +

Re: [PATCH] MAINTAINERS: Cover RCU documentation

2023-02-24 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v3 3/5] hw/nvme: add basic endurance group support

2023-02-24 Thread Klaus Jensen
On Feb 24 09:51, Joel Granados wrote: > On Mon, Feb 20, 2023 at 12:59:24PM +0100, Jesper Devantier wrote: > > From: Klaus Jensen > > > > Add the mandatory Endurance Group identify data structures and log > > pages. > > > > For now, all namespaces in a subsystem belongs to a single Endurance > >

Re: [PATCH v3 1/5] hw/nvme: move adjustment of data_units{read,written}

2023-02-24 Thread Klaus Jensen
On Feb 24 09:20, Joel Granados wrote: > On Mon, Feb 20, 2023 at 12:59:22PM +0100, Jesper Devantier wrote: > > From: Joel Granados > > > > In order to return the units_{read/written} required by the SMART log we > > need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply > > by 1

Re: [RFC PATCH 1/2] mm: restrictedmem: Allow userspace to specify mount_path for memfd_restricted

2023-02-24 Thread kirill . shutemov
On Thu, Feb 23, 2023 at 12:55:16AM +, Ackerley Tng wrote: > > "Kirill A. Shutemov" writes: > > > On Thu, Feb 16, 2023 at 12:41:16AM +, Ackerley Tng wrote: > > > By default, the backing shmem file for a restrictedmem fd is created > > > on shmem's kernel space mount. > > > > With this pa

Re: [PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Philippe Mathieu-Daudé
On 24/2/23 10:05, Thomas Huth wrote: Similar to "-no-hpet", the "-no-acpi" switch is a legacy command line option that should be replaced with the "acpi" machine parameter nowadays. Signed-off-by: Thomas Huth --- v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!) docs/abo

Re: out of CI pipeline minutes again

2023-02-24 Thread Paolo Bonzini
On 2/23/23 16:33, Daniel P. Berrangé wrote: On Thu, Feb 23, 2023 at 03:28:37PM +, Ben Dooks wrote: On Thu, Feb 23, 2023 at 12:56:56PM +, Peter Maydell wrote: Hi; the project is out of gitlab CI pipeline minutes again. In the absence of any other proposals, no more pull request merges wi

Re: [PATCH 5/5] hw/audio/via-ac97: Basic implementation of audio playback

2023-02-24 Thread Bernhard Beschow
Am 23. Februar 2023 19:40:03 UTC schrieb "Volker Rümelin" : >Am 21.02.23 um 19:44 schrieb BALATON Zoltan: >> This adds basic implementation of the AC'97 sound part used in VIA >> south bridge chips. Not all features of the device is emulated, only >> one playback channel is supported but this is

Re: [RFC PATCH] target/arm: properly document FEAT_CRC32

2023-02-24 Thread Peter Maydell
On Thu, 23 Feb 2023 at 23:01, Richard Henderson wrote: > > On 2/22/23 01:01, Alex Bennée wrote: > > This is a mandatory feature for Armv8.1 architectures but we don't > > state the feature clearly in our emulation list. While checking verify > > our cortex-a76 model matches up with the current TRM

Re: [PATCH] hw/display/sm501: Add alternatives to pixman routines

2023-02-24 Thread Peter Maydell
On Fri, 24 Feb 2023 at 00:18, BALATON Zoltan wrote: > > Pixman can sometimes return false so add fallbacks for such cases and > also add a property to disable pixman and always use the fallbacks > which can be useful on platforms where pixman is broken or for testing > different drawing methods. >

Re: [PATCH v2 0/4] NUMA: Apply socket-NUMA-node boundary for aarch64 and RiscV machines

2023-02-24 Thread Gavin Shan
On 2/24/23 8:26 PM, Daniel Henrique Barboza wrote: On 2/24/23 04:09, Gavin Shan wrote: On 2/24/23 12:18 AM, Daniel Henrique Barboza wrote: On 2/23/23 05:13, Gavin Shan wrote: For arm64 and RiscV architecture, the driver (/base/arch_topology.c) is used to populate the CPU topology in the Linux

Re: [PATCH v1 5/6] hw/arm/virt: Enable backup bitmap for dirty ring

2023-02-24 Thread Gavin Shan
On 2/23/23 10:51 PM, Peter Maydell wrote: On Thu, 23 Feb 2023 at 00:52, Gavin Shan wrote: On 2/23/23 2:54 AM, Peter Maydell wrote: But we might have to for other boards we add later. We shouldn't put code in per-board if it's not really board specific. Moreover, I think "we need the backup b

Re: [RFC PATCH] target/arm: properly document FEAT_CRC32

2023-02-24 Thread Philippe Mathieu-Daudé
On 24/2/23 00:27, Richard Henderson wrote: On 2/23/23 13:22, Philippe Mathieu-Daudé wrote: On 24/2/23 00:01, Richard Henderson wrote: On 2/22/23 01:01, Alex Bennée wrote: This is a mandatory feature for Armv8.1 architectures but we don't state the feature clearly in our emulation list. While c

Re: [PATCH V4 8/8] MAINTAINERS: Add entry for RISC-V ACPI

2023-02-24 Thread Andrew Jones
On Fri, Feb 24, 2023 at 02:07:01PM +0530, Sunil V L wrote: > RISC-V ACPI related functionality for virt machine is added in > virt-acpi-build.c. Add the maintainer entry after moving the > ARM ACPI entry under the main ACPI entry. > > Signed-off-by: Sunil V L > Reviewed-by: Bin Meng > Acked-by:

Re: [PATCH v2 0/4] NUMA: Apply socket-NUMA-node boundary for aarch64 and RiscV machines

2023-02-24 Thread Andrew Jones
On Fri, Feb 24, 2023 at 09:16:39PM +1100, Gavin Shan wrote: > On 2/24/23 8:26 PM, Daniel Henrique Barboza wrote: > > On 2/24/23 04:09, Gavin Shan wrote: > > > On 2/24/23 12:18 AM, Daniel Henrique Barboza wrote: > > > > On 2/23/23 05:13, Gavin Shan wrote: > > > > > For arm64 and RiscV architecture,

[PATCH 0/2] ui/kbd-state: QAPI'fy QKbdModifier

2023-02-24 Thread Philippe Mathieu-Daudé
QAPI seems designed to maintain such enums, so convert QKbdModifier to be QAPI generated. Besides, this is how QKeyCode is maintained. Philippe Mathieu-Daudé (2): ui/kbd-state: Rename QKbdModifier enum definitions ui/kbd-state: QAPI'fy QKbdModifier include/ui/kbd-state.h | 16 ---

[PATCH 2/2] ui/kbd-state: QAPI'fy QKbdModifier

2023-02-24 Thread Philippe Mathieu-Daudé
Let QAPI maintain the QKbdModifier enum values. Signed-off-by: Philippe Mathieu-Daudé --- include/ui/kbd-state.h | 16 qapi/ui.json | 10 ++ 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/include/ui/kbd-state.h b/include/ui/kbd-state.h index 1

[PATCH 1/2] ui/kbd-state: Rename QKbdModifier enum definitions

2023-02-24 Thread Philippe Mathieu-Daudé
In order to QAPI'fy QKbdModifier in the next commit, rename its definitions to a QAPI-ready format. Mechanical change doing: $ sed -i -e s/QKBD_MOD_/Q_KBD_MODIFIER_/g $(git grep -l QKBD_MOD_) Signed-off-by: Philippe Mathieu-Daudé --- include/ui/kbd-state.h | 16 ui/cocoa.m

Re: [PATCH v2 7/7] target/arm: Add CPU properties for most v8.3 PAC features

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 22:14, Richard Henderson wrote: > > On 2/22/23 09:35, Aaron Lindsay wrote: > > Signed-off-by: Aaron Lindsay > > --- > > +static Property arm_cpu_pauth2_property = > > +DEFINE_PROP_BOOL("pauth2", ARMCPU, prop_pauth2, false); > > +static Property arm_cpu_pauth_fpac_prope

Re: [PATCH v2 17/20] vfio/common: Support device dirty page tracking with vIOMMU

2023-02-24 Thread Joao Martins
On 23/02/2023 23:26, Jason Gunthorpe wrote: > On Thu, Feb 23, 2023 at 03:33:09PM -0700, Alex Williamson wrote: >> On Thu, 23 Feb 2023 16:55:54 -0400 >> Jason Gunthorpe wrote: >>> On Thu, Feb 23, 2023 at 01:06:33PM -0700, Alex Williamson wrote: >>> Or even better figure out how to get interrupt rem

Re: [PATCH 1/6] target/riscv: Fix the relationship between menvcfg.PBMTE/STCE and Svpbmt/Sstc extensions

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: menvcfg.PBMTE/STCE are read-only zero if Svpbmt/Sstc are not implemented. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/csr.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-

Re: [PATCH 2/6] target/riscv: Fix the relationship of PBMTE/STCE fields between menvcfg and henvcfg

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: henvcfg.PBMTE/STCE are read-only zero if menvcfg.PBMTE/STCE are zero. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/csr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions

Re: [PATCH 3/6] target/riscv: Add csr support for svadu

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: Add ext_svadu property Add HADE field in *envcfg: * menvcfg.HADE is read-only zero if Svadu is not implemented. * henvcfg.HADE is read-only zero if menvcfg.HADE is zero. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henriq

Re: [PATCH 4/6] target/riscv: Add *envcfg.PBMTE related check in address translation

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: menvcfg.PBMTE bit controls whether the Svpbmt extension is available for use in S-mode and G-stage address translation. henvcfg.PBMTE bit controls whether the Svpbmt extension is available for use in VS-stage address translation. Set *envcfg.PBMTE default t

Re: [PATCH 5/6] target/riscv: Add *envcfg.HADE related check in address translation

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: When menvcfg.HADE is 1, hardware updating of PTE A/D bits is enabled during single-stage address translation. When the hypervisor extension is implemented, if menvcfg.HADE is 1, hardware updating of PTE A/D bits is enabled during G-stage address translation.

Re: [PATCH 6/6] target/riscv: Export Svadu property

2023-02-24 Thread Daniel Henrique Barboza
On 2/24/23 01:08, Weiwei Li wrote: Set it default true for backward compatibility Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: Daniel Henrique Barboza target/riscv/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/riscv/cpu.c b/target/risc

Re: [PATCH 2/2] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2023-02-24 Thread Jonathan Cameron via
On Fri, 24 Feb 2023 00:29:47 + Fan Ni wrote: > On Mon, Feb 20, 2023 at 11:46:46AM +, Jonathan Cameron wrote: > > > On Fri, 17 Feb 2023 06:08:57 -0500 > > Gregory Price wrote: > > > > > On Fri, Feb 17, 2023 at 04:16:17PM +, Jonathan Cameron via wrote: > > > > On Tue, 31 Jan 2023

Re: [PATCH 2/6] target/riscv: Fix the relationship of PBMTE/STCE fields between menvcfg and henvcfg

2023-02-24 Thread Andrew Jones
On Fri, Feb 24, 2023 at 12:08:48PM +0800, Weiwei Li wrote: > henvcfg.PBMTE/STCE are read-only zero if menvcfg.PBMTE/STCE are zero. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > target/riscv/csr.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > di

Re: [PATCH 5/5] hw/audio/via-ac97: Basic implementation of audio playback

2023-02-24 Thread BALATON Zoltan
On Fri, 24 Feb 2023, Bernhard Beschow wrote: Am 23. Februar 2023 19:40:03 UTC schrieb "Volker Rümelin" : Am 21.02.23 um 19:44 schrieb BALATON Zoltan: This adds basic implementation of the AC'97 sound part used in VIA south bridge chips. Not all features of the device is emulated, only one playb

Re: [PATCH] hw/display/sm501: Add alternatives to pixman routines

2023-02-24 Thread BALATON Zoltan
On Fri, 24 Feb 2023, Peter Maydell wrote: On Fri, 24 Feb 2023 at 00:18, BALATON Zoltan wrote: Pixman can sometimes return false so add fallbacks for such cases and also add a property to disable pixman and always use the fallbacks which can be useful on platforms where pixman is broken or for

Re: [PATCH 2/6] target/riscv: Fix the relationship of PBMTE/STCE fields between menvcfg and henvcfg

2023-02-24 Thread liweiwei
On 2023/2/24 20:19, Andrew Jones wrote: On Fri, Feb 24, 2023 at 12:08:48PM +0800, Weiwei Li wrote: henvcfg.PBMTE/STCE are read-only zero if menvcfg.PBMTE/STCE are zero. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/csr.c | 13 + 1 file changed, 9 inse

Re: [PULL v2 0/8] tcg patch queue

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:00, Richard Henderson wrote: > > The following changes since commit 79b677d658d3d35e1e776826ac4abb28cdce69b8: > > Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into > staging (2023-02-21 11:28:31 +) > > are available in the Git repository at: > >

Re: [PATCH V4 5/8] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT

2023-02-24 Thread Igor Mammedov
On Fri, 24 Feb 2023 14:06:58 +0530 Sunil V L wrote: > Add Multiple APIC Description Table (MADT) with the > RINTC structure for each cpu. > > Signed-off-by: Sunil V L > Acked-by: Alistair Francis > Reviewed-by: Andrew Jones > --- > hw/riscv/virt-acpi-build.c | 44

[RFC PATCH v2 2/3] gitlab: Cache container images

2023-02-24 Thread Fabiano Rosas
Make use of the --cache-from option from 'docker build' by including build layers when building and then pulling a previously built image before the next build. This was previously done by the docker.py script, but got disabled due to bad interactions with certain runners. See commit 6ddc3dc7a8 ("

Re: [PATCH v2 17/20] vfio/common: Support device dirty page tracking with vIOMMU

2023-02-24 Thread Joao Martins
On 24/02/2023 11:25, Joao Martins wrote: > On 23/02/2023 23:26, Jason Gunthorpe wrote: >> On Thu, Feb 23, 2023 at 03:33:09PM -0700, Alex Williamson wrote: >>> On Thu, 23 Feb 2023 16:55:54 -0400 >>> Jason Gunthorpe wrote: On Thu, Feb 23, 2023 at 01:06:33PM -0700, Alex Williamson wrote: Or

[RFC PATCH v2 1/3] gitlab: Use plain docker in container-template.yml

2023-02-24 Thread Fabiano Rosas
Our dockerfiles no longer reference layers from other qemu images so we can now use 'docker build' on them. Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/container-template.yml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.gitlab-ci.d/container-template.yml b/.gitlab-

[RFC PATCH v2 0/3] ci: Speed up container stage

2023-02-24 Thread Fabiano Rosas
Turns out we were already pulling the image, but for forks we were pulling from a different registry and for the main project we had caching disabled due to a bug with docker/gitlab. I've now replaced the usage of docker.py with a plain docker command and reintroduced the caching. I also removed

[RFC PATCH v2 3/3] gitlab: Remove COMMON_TAG from container-template.yml

2023-02-24 Thread Fabiano Rosas
We're not using the COMMON_TAG and we cannot have a push to a different registry than we pull from because that would get in the way of forks testing their changes to a dockerfile. Signed-off-by: Fabiano Rosas --- .gitlab-ci.d/container-template.yml | 2 -- 1 file changed, 2 deletions(-) diff -

Re: [PATCH V4 6/8] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table

2023-02-24 Thread Igor Mammedov
On Fri, 24 Feb 2023 14:06:59 +0530 Sunil V L wrote: > RISC-V ACPI platforms need to provide RISC-V Hart Capabilities > Table (RHCT). Add this to the ACPI tables. > > Signed-off-by: Sunil V L > Reviewed-by: Andrew Jones > --- > hw/riscv/virt-acpi-build.c | 76 ++

Re: [PATCH v2] Deprecate the "-no-acpi" command line switch

2023-02-24 Thread Igor Mammedov
On Fri, 24 Feb 2023 10:05:43 +0100 Thomas Huth wrote: > Similar to "-no-hpet", the "-no-acpi" switch is a legacy command > line option that should be replaced with the "acpi" machine parameter > nowadays. > > Signed-off-by: Thomas Huth Reviewed-by: Igor Mammedov > --- > v2: Fixed stypid cop

Re: [PULL v2 0/8] tcg patch queue

2023-02-24 Thread Peter Maydell
On Fri, 24 Feb 2023 at 12:46, Peter Maydell wrote: > > On Wed, 22 Feb 2023 at 02:00, Richard Henderson > wrote: > > > > The following changes since commit 79b677d658d3d35e1e776826ac4abb28cdce69b8: > > > > Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into > > staging (2023-0

Re: [PATCH 5/5] hw/audio/via-ac97: Basic implementation of audio playback

2023-02-24 Thread BALATON Zoltan
Just for some motivation, this is what we want to make possible for more people with QEMU 8.0: https://youtu.be/YY9RExl4VDI This would need at least my SM502 patches and fixing the IRQ routing in the VT8231 (this test was with my series for that, I'll ask testing Bernhard's version the same wa

Re: [PATCH v5 12/14] Hexagon (target/hexagon) Remove gen_log_predicated_reg_write[_pair]

2023-02-24 Thread Anton Johansson via
On 1/31/23 23:56, Taylor Simpson wrote: static void gen_log_reg_write_pair(int rnum, TCGv_i64 val) { const target_ulong reg_mask_low = reg_immut_masks[rnum]; @@ -167,6 +120,7 @@ static void gen_log_reg_write_pair(int rnum, TCGv_i64 val) } tcg_temp_free(val32); +tcg

Re: [PATCH v3 01/25] target/arm: Handle m-profile in arm_is_secure

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:34, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 02/25] target/arm: Stub arm_hcr_el2_eff for m-profile

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:34, Richard Henderson wrote: > > M-profile doesn't have HCR_EL2. While we could test features > before each call, zero is a generally safe return value to > disable the code in the caller. This test is required to > avoid an assert in arm_is_secure_below_el3. > > Signed

Re: [PATCH v3 03/25] target/arm: Diagnose incorrect usage of arm_is_secure subroutines

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:34, Richard Henderson wrote: > > In several places we use arm_is_secure_below_el3 and > arm_is_el3_or_mon separately from arm_is_secure. > These functions make no sense for m-profile, and > would indicate prior incorrect feature testing. > > Signed-off-by: Richard Henders

Re: [RFC PATCH] target/arm: properly document FEAT_CRC32

2023-02-24 Thread Alex Bennée
Richard Henderson writes: > On 2/22/23 01:01, Alex Bennée wrote: >> This is a mandatory feature for Armv8.1 architectures but we don't >> state the feature clearly in our emulation list. While checking verify >> our cortex-a76 model matches up with the current TRM by breaking out >> the long fo

Re: [PATCH v3 13/25] target/arm: Remove __attribute__((nonnull)) from ptw.c

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:36, Richard Henderson wrote: > > This was added in 7e98e21c098 as part of a reorg in which > one of the argument had been legally NULL, and this caught > actual instances. Now that the reorg is complete, this > serves little purpose. > > Signed-off-by: Richard Henderson

Re: [PATCH] tests/avocado: Enable TuxRun/mips64 (big-endian) test

2023-02-24 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Now that the previous commit ("hw/mips/gt64xxx_pci: Don't > endian-swap GT_PCI0_CFGADDR") fixed the issue accessing > the GT64120 PCI config-address register on big-endian > targets, we can enable this TuxRun test. > > Signed-off-by: Philippe Mathieu-Daudé Ack

[PATCH v8 4/4] target/riscv: add Zicbop cbo.prefetch{i, r, m} placeholder

2023-02-24 Thread Daniel Henrique Barboza
From: Christoph Muellner The cmo.prefetch instructions are nops for QEMU (no emulation of the memory hierarchy, no illegal instructions, no permission faults, no traps). Add a comment noting where they would be decoded in case cbo.prefetch instructions become relevant in the future. Co-develope

[PATCH v8 1/4] tcg: add 'size' param to probe_access_flags()

2023-02-24 Thread Daniel Henrique Barboza
probe_access_flags() as it is today uses probe_access_full(), which in turn uses probe_access_internal() with size = 0. probe_access_internal() then uses the size to call the tlb_fill() callback for the given CPU. This size param ('fault_size' as probe_access_internal() calls it) is ignored by most

[PATCH v8 2/4] target/riscv: implement Zicboz extension

2023-02-24 Thread Daniel Henrique Barboza
From: Christoph Muellner The RISC-V base cache management operation (CBO) ISA extension has been ratified. It defines three extensions: Cache-Block Management, Cache-Block Prefetch and Cache-Block Zero. More information about the spec can be found at [1]. Let's start by implementing the Cache-Bl

[PATCH v8 0/4] riscv: Add support for Zicbo[m,z,p] instructions

2023-02-24 Thread Daniel Henrique Barboza
Hi, This version has a change in patch 2, proposed by Weiwei Li, where we're now triggering virt_instruction_fault before triggering illegal_insn fault from S mode. Richard already queued patch 1 is queued in tcg-next already. I'm still including it here to allow for easier testing of the remain

[PATCH v8 3/4] target/riscv: implement Zicbom extension

2023-02-24 Thread Daniel Henrique Barboza
From: Christoph Muellner Zicbom is the Cache-Block Management extension defined in the already ratified RISC-V Base Cache Management Operation (CBO) ISA extension [1]. The extension contains three instructions: cbo.clean, cbo.flush and cbo.inval. All of them must be implemented in the same group

Re: [PATCH] hw/display/sm501: Add alternatives to pixman routines

2023-02-24 Thread BALATON Zoltan
On Fri, 24 Feb 2023, Peter Maydell wrote: On Fri, 24 Feb 2023 at 00:18, BALATON Zoltan wrote: Pixman can sometimes return false so add fallbacks for such cases and also add a property to disable pixman and always use the fallbacks which can be useful on platforms where pixman is broken or for t

Re: [PATCH v3 04/25] target/arm: Rewrite check_s2_mmu_setup

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:34, Richard Henderson wrote: > > Integrate neighboring code from get_phys_addr_lpae which computed > starting level, as it is easier to validate when doing both at the > same time. Mirror the checks at the start of AArch{64,32}.S2Walk, > especially S2InvalidSL and S2Inco

Re: out of CI pipeline minutes again

2023-02-24 Thread Alex Bennée
Eldon Stegall writes: > On Thu, Feb 23, 2023 at 03:33:00PM +, Daniel P. Berrangé wrote: >> IIUC, we already have available compute resources from a couple of >> sources we could put into service. The main issue is someone to >> actually configure them to act as runners *and* maintain their

Re: [PATCH v2 0/4] NUMA: Apply socket-NUMA-node boundary for aarch64 and RiscV machines

2023-02-24 Thread Igor Mammedov
On Fri, 24 Feb 2023 21:16:39 +1100 Gavin Shan wrote: > On 2/24/23 8:26 PM, Daniel Henrique Barboza wrote: > > On 2/24/23 04:09, Gavin Shan wrote: > >> On 2/24/23 12:18 AM, Daniel Henrique Barboza wrote: > >>> On 2/23/23 05:13, Gavin Shan wrote: > For arm64 and RiscV architecture, the d

Re: [PATCH v5 13/14] Hexagon (target/hexagon) Reduce manipulation of slot_cancelled

2023-02-24 Thread Anton Johansson via
On 1/31/23 23:56, Taylor Simpson wrote: /* Called during packet commit when there are two scalar stores */ -void HELPER(probe_pkt_scalar_store_s0)(CPUHexagonState *env, int mmu_idx) +void HELPER(probe_pkt_scalar_store_s0)(CPUHexagonState *env, int args) { -probe_store(env, 0, mmu_idx);

Re: [PATCH v3 07/25] target/arm: SCR_EL3.NS may be RES1

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:35, Richard Henderson wrote: > > With RME, SEL2 must also be present to support secure state. > The NS bit is RES1 if SEL2 is not present. > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Peter May

Re: [PATCH V4 5/8] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT

2023-02-24 Thread Sunil V L
Hi Igor, On Fri, Feb 24, 2023 at 01:53:43PM +0100, Igor Mammedov wrote: > On Fri, 24 Feb 2023 14:06:58 +0530 > Sunil V L wrote: > > > Add Multiple APIC Description Table (MADT) with the > > RINTC structure for each cpu. > > > > Signed-off-by: Sunil V L > > Acked-by: Alistair Francis > > Revie

Re: [PATCH v3 15/25] target/arm: NSTable is RES0 for the RME EL3 regime

2023-02-24 Thread Peter Maydell
On Wed, 22 Feb 2023 at 02:36, Richard Henderson wrote: > > Test in_space instead of in_secure so that we don't switch > out of Root space. Handle the output space change immediately, > rather than try and combine the NSTable and NS bits later. > > Signed-off-by: Richard Henderson > --- > target

Re: [PATCH 1/4] apic: add support for x2APIC mode

2023-02-24 Thread Igor Mammedov
On Tue, 21 Feb 2023 23:04:57 +0700 Bui Quang Minh wrote: > This commit refactors APIC registers read/write function to support both > MMIO read/write in xAPIC mode and MSR read/write in x2APIC mode. Also, > support larger APIC ID, self IPI, new IPI destination determination in > x2APIC mode. > >

Re: [PATCH v5 14/14] Hexagon (target/hexagon) Improve code gen for predicated HVX instructions

2023-02-24 Thread Anton Johansson via
On 1/31/23 23:56, Taylor Simpson wrote: The following improvements are made for predicated HVX instructions During gen_commit_hvx, unconditionally move the "new" value into the dest Don't set slot_cancelled Remove runtime bookkeeping of which registers were updated

  1   2   3   >