On 2/16/23 20:16, Philippe Mathieu-Daudé wrote:
On 16/2/23 19:12, Cédric Le Goater wrote:
On 2/16/23 13:25, Philippe Mathieu-Daudé wrote:
ForeachArgs::name is only used once as TYPE_IPMI_BMC.
Since the penultimate commit, object_child_foreach_recursive()'s
handler takes an Error* argument and r
Hi, Peter!
In my last email to Juan, I mentioned two errors.
Now I want to discuss them with you.
On 2023/2/16 下午11:41, Chuang Xu wrote:
I ran qtest with reference to your environment, and finally reported
two errors.
Error 1(the same as yours):
QTEST_QEMU_BINARY=./qemu-system-x86_64 MALLOC
The next step would be to get rid of the drive_get(IF_MTD) internal
API, which means finding a way to attach block backend devices from
the command line to the default flash devices. This should be done
at machine init time and the blockdev should have some 'bus@addr'
identifier. I lack the kno
On 2/15/23 13:26, Philippe Mathieu-Daudé wrote:
On 15/2/23 12:09, Cédric Le Goater wrote:
On 2/15/23 11:55, Philippe Mathieu-Daudé wrote:
On 14/2/23 18:18, Cédric Le Goater wrote:
From: Klaus Jensen
Add an example I2C device to demonstrate how a slave may master the bus
and send data asynchr
On 2/15/23 11:45, Philippe Mathieu-Daudé wrote:
On 14/2/23 18:18, Cédric Le Goater wrote:
Hello,
This series starts with a first set of patches fixing I2C slave mode
in the Aspeed I2C controller, a test device and its associated test in
avocado.
Follow some cleanups which allow the use of bloc
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> The generated code doesn't quite handle the conditional arguments.
> For example, 'bar' in 'test-if-cmd' is not correctly surrounded by #if
> conditions. See generated code in qmp_marshal_test_if_cmd().
>
> Note that if there are m
On 2/16/23 23:55, LIU Zhiwei wrote:
On 2023/2/17 5:55, Daniel Henrique Barboza wrote:
We're going to do changes that requires accessing the RISCVCPUConfig
struct from the RISCVCPU, having access only to a CPURISCVState 'env'
pointer. Add a helper to make the code easier to read.
Signed-off-
Queued, thanks.
Paolo
On Fri, Feb 17, 2023 at 03:41:30PM +0800, wangyanan (Y) wrote:
> Date: Fri, 17 Feb 2023 15:41:30 +0800
> From: "wangyanan (Y)"
> Subject: Re: [RFC 08/52] machine: Add helpers to get cpu topology info from
> MachineState.topo
>
> 在 2023/2/17 11:07, Zhao Liu 写道:
> > On Thu, Feb 16, 2023 at 04:38:3
Thomas Huth writes:
> On 15/02/2023 20.05, Markus Armbruster wrote:
>> The discussion under PATCH 6 makes me think there's a bit of confusion
>> about the actual impact of dropping support for Python 3.6. Possibly
>> because it's spelled out in the commit message of PATCH 7. Let me
>> summarize
在 2023/2/17 15:26, Zhao Liu 写道:
On Fri, Feb 17, 2023 at 12:07:01PM +0800, wangyanan (Y) wrote:
Date: Fri, 17 Feb 2023 12:07:01 +0800
From: "wangyanan (Y)"
Subject: Re: [PATCH RESEND 18/18] i386: Add new property to control L2
cache topo in CPUID.04H
在 2023/2/17 11:35, Zhao Liu 写道:
On Thu, F
I am a bit late, but nonetheless, some comments inline.
On 2/15/23 11:53, Fiona Ebner wrote:
Am 14.02.23 um 19:21 schrieb John Snow:
On Thu, Feb 2, 2023 at 7:08 AM Fiona Ebner wrote:
Hi,
over the years we've got 1-2 dozen reports[0] about suddenly
missing/corrupted MBR/partition tables. The
marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau
>
> A process with enough capabilities can duplicate a socket to QEMU.
> Modify 'getfd' to import it and add it to the monitor fd list, so it can
> be later used by other commands.
>
> Note that we actually store the SOCKET in the FD l
On 17/02/2023 10.06, Markus Armbruster wrote:
Thomas Huth writes:
...
My view on all this is a bit more pragmatic.
For a human developer, the difference between "dnf install
python-sphinx" and "pip install sphinx" is, in my opinion, close to
negligible. Really no comparison to "git-clone GCC
On Fri, Feb 17, 2023 at 10:06:49AM +0100, Markus Armbruster wrote:
> Thomas Huth writes:
>
> > On 15/02/2023 20.05, Markus Armbruster wrote:
> >> The discussion under PATCH 6 makes me think there's a bit of confusion
> >> about the actual impact of dropping support for Python 3.6. Possibly
> >>
Noted.
Thanks,
Cédric
On Fri, Feb 17, 2023 at 1:19 PM Cédric Le Goater wrote:
> Hello Karthikeyan,
>
> On 2/16/23 19:43, Karthikeyan Pasupathi wrote:
> > This patch support Tiogapass in QEMU environment.
> > and introduced EEPROM BMC FRU data support "add tiogapass_bmc_fruid data"
> > along wi
Am 03/02/2023 um 16:21 schrieb Kevin Wolf:
> After introducing the graph lock in a previous series, this series
> actually starts making widespread use of it.
>
> Most of the BlockDriver callbacks access the children list in some way,
> so you need to hold the graph lock to call them. The patch
Am 10.02.2023 um 15:32 hat Stefan Hajnoczi geschrieben:
> When an IOThread is configured, the ctrl virtqueue is processed in the
> IOThread. TMFs that reset SCSI devices are currently called directly
> from the IOThread and trigger an assertion failure in blk_drain():
>
> ../block/block-backend.
On 2/16/23 09:25, Philippe Mathieu-Daudé wrote:
The '1' returned value isn't used because
spapr_phb_get_free_liobn_cb() isn't called recursively
(it is only called once in spapr_phb_get_free_liobn()).
The next commit will convert object_child_foreach()
handlers to return a boolean indicating
Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
Signed-off-by: Fiona Ebner
---
Or should it be sorted alphabetically below execute_ncq_command_unsup?
I felt read and write belong close together and this reflects the
positions in the code.
hw/ide/ahci.c | 4 ++--
hw/ide/trace
I feel the discussion petered out without a conclusion.
I don't think letting the status quo win by inertia is a good outcome
here.
Which 32-bit hosts are still useful, and why?
Please note my question is not about the cost of keeping them (or
savings from not keeping them), it's about the value
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote:
> I feel the discussion petered out without a conclusion.
>
> I don't think letting the status quo win by inertia is a good outcome
> here.
>
> Which 32-bit hosts are still useful, and why?
>
> Please note my question is not abou
The problem has been reported by gcc with CFLAGS=-O3:
.../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’:
.../hw/virtio/vhost-shadow-virtqueue.c:538:12:
error: ‘len’ may be used uninitialized [-Werror=maybe-uninitialized]
538 | return len;
|^~~
vhost_svq_
On 2/17/23 11:36, Markus Armbruster wrote:
> I feel the discussion petered out without a conclusion.
>
> I don't think letting the status quo win by inertia is a good outcome
> here.
>
> Which 32-bit hosts are still useful, and why?
Hi Markus,
if the question is very very general, my opinion i
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote:
> I feel the discussion petered out without a conclusion.
>
> I don't think letting the status quo win by inertia is a good outcome
> here.
>
> Which 32-bit hosts are still useful, and why?
Which 32-bit hosts does Linux still pro
I know this is a pull request, but if you prefer to have all the patches
with and R-b, you can add mine here too, but I'll leave it up to you.
Reviewed-by: Darren Kenny
Thanks,
Darren.
On Thursday, 2023-02-16 at 23:08:47 -05, Alexander Bulekov wrote:
> As we are converting most fuzzers to rely
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote:
Which 32-bit hosts are still useful, and why?
Citing my previous mail:
I now checked all downloads of the latests installers since 2022-12-30.
qemu-w32-setup-20221230.exe – 509 different IP addresses
qemu-w64-setup-
On 1/30/23 12:44, Thomas Huth wrote:
> Testing 32-bit host OS support takes a lot of precious time during the QEMU
> contiguous integration tests, and considering that many OS vendors stopped
> shipping 32-bit variants of their OS distributions and most hardware from
> the past >10 years is capable
On Thu, 16 Feb 2023 15:52:31 -0500
Gregory Price wrote:
> On Thu, Feb 16, 2023 at 06:00:57PM +, Jonathan Cameron wrote:
> > On Wed, 15 Feb 2023 04:10:20 -0500
> > Gregory Price wrote:
> >
> > > On Wed, Feb 15, 2023 at 03:18:54PM +, Jonathan Cameron via wrote:
> > > > On Wed, 8 Feb 2
On 14/02/23 3:46 pm, Markus Armbruster wrote:
Het Gala writes:
On 10/02/23 12:54 pm, Markus Armbruster wrote:
Daniel P. Berrangé writes:
[...]
+##
+# @MigrateAddress:
+#
+# The options available for communication transport mechanisms for migration
+#
+# Since 8.0
+##
+{ 'union' : 'Migra
On Fri, Feb 17, 2023 at 11:42 AM Laurent Vivier wrote:
>
> The problem has been reported by gcc with CFLAGS=-O3:
>
> .../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’:
> .../hw/virtio/vhost-shadow-virtqueue.c:538:12:
> error: ‘len’ may be used uninitialized [-Werror=maybe-uninit
On Thu, Feb 09, 2023 at 07:31:40PM -0500, John Snow wrote:
> Howdy, this series increases our minimum python version to 3.7.
..snip...
So based on the discussion in this thread I see the following as the
key take aways:
* Use of newer Meson feature
We need newer meson in order to continue/f
Stefan Weil writes:
> On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote:
>
>> Which 32-bit hosts are still useful, and why?
>
>
> Citing my previous mail:
>
>I now checked all downloads of the latests installers since 2022-12-30.
>
>qemu-w32-setup-20221230.exe – 509 differ
On 2/17/23 12:24, Eugenio Perez Martin wrote:
On Fri, Feb 17, 2023 at 11:42 AM Laurent Vivier wrote:
The problem has been reported by gcc with CFLAGS=-O3:
.../hw/virtio/vhost-shadow-virtqueue.c: In function ‘vhost_svq_poll’:
.../hw/virtio/vhost-shadow-virtqueue.c:538:12:
error: ‘len’ may be u
On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote:
> On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote:
>
> > Which 32-bit hosts are still useful, and why?
>
>
> Citing my previous mail:
>
>I now checked all downloads of the latests installers since 2022-12-30.
>
On Fri, Feb 17, 2023 at 04:48:59PM +0530, Het Gala wrote:
>
> On 14/02/23 3:46 pm, Markus Armbruster wrote:
> > Het Gala writes:
> >
> > > On 10/02/23 12:54 pm, Markus Armbruster wrote:
> > > > Daniel P. Berrangé writes:
> > > >
> > > > [...]
> > > >
> > > > > > +##
> > > > > > +# @MigrateAdd
From: Jesper Wendel Devantier
Flexible Data Placement (FDP) is a newly introduced enhancement
of the NVM command set introduced by the NVM Express, Inc.
organization as TP 4146. FDP aims to extend the NVM command set
to enable host-guided data placement. FDP-enabled namespaces
can be used as befo
From: Gollu Appalanaidu
Add support for the Directive Send and Recv commands and the Identify
directive.
Signed-off-by: Klaus Jensen
Signed-off-by: Gollu Appalanaidu
---
hw/nvme/ctrl.c | 40 +++-
hw/nvme/nvme.h | 2 ++
include/block/nvme.h | 35
From: Jesper Devantier
Add emulation of TP4146 ("Flexible Data Placement").
Signed-off-by: Jesper Devantier
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 703 ++-
hw/nvme/ns.c | 142 +
hw/nvme/nvme.h | 85 +-
hw/nvme/
From: Klaus Jensen
Add the mandatory Endurance Group identify data structures and log
pages.
For now, all namespaces in a subsystem belongs to a single Endurance
Group.
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 48 +++-
hw/nvme/ns.c
From: Joel Granados
In order to return the units_{read/written} required by the SMART log we
need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply
by 1000. This is a prep patch that moves this adjustment to where the SMART
log is calculated in order to use the stats struct for
From: Niklas Cassel
Each NvmeNamespace can be used by serveral controllers,
but a NvmeNamespace can at most belong to a single NvmeSubsystem.
Store a pointer to the NvmeSubsystem, if the namespace was realized
with a NvmeSubsystem.
Signed-off-by: Niklas Cassel
Signed-off-by: Klaus Jensen
---
Am 16.02.23 um 17:15 schrieb Mike Maslenkin:
> Makes sense for disks without partition table.
> But wouldn't Linux or any other OS write at least 4K bytes in that case?
Yes, it does here.
> Who may want to write 512 bytes for any purposes except for boot
> sector nowadays..
>From a quick test, f
On 17/2/23 11:31, Fiona Ebner wrote:
Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
Oops
Signed-off-by: Fiona Ebner
---
Or should it be sorted alphabetically below execute_ncq_command_unsup?
No, there is no convention...
I felt read and write belong close together and thi
Historically, the critical dependency for both building and running
QEMU has been the distro packages. Because QEMU is written in C and C's
package management has been tied to distros (at least if you do not want
to bundle libraries with the binary, otherwise I suppose you could use
something like
Historically, the critical dependency for both building and running
QEMU has been the distro packages. Because QEMU is written in C and C's
package management has been tied to distros (at least if you do not want
to bundle libraries with the binary, otherwise I suppose you could use
something like
Ping.
This fixes a bug (admittedly with a big hammer) that affects
users with heavily multi-threaded user-mode workloads.
Thanks,
Emilio
On Sun, Feb 05, 2023 at 11:37:56 -0500, Emilio Cota wrote:
> Changes since v1:
>
> - Add configure check to only use QTree if Glib still imple
Fiona Ebner writes:
> Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
> Signed-off-by: Fiona Ebner
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Our distro support policy has been written with a best-effort
estimation of what users and developers need. However, as we now
know, the support for older long-term distributions can get really
troublesome for upstream development, since it is for example close
to impossible to keep the code for al
Am 16.02.23 um 15:17 schrieb Mike Maslenkin:
> Does additional comparison make a sense here: check for LBA == 0 and
> then check MBR signature bytes.
> Additionally it’s easy to check buffer_is_zero() result or even print
> FIS contents under these conditions.
> Data looks like a part of guest memo
On 17/02/2023 12.37, Daniel P. Berrangé wrote:
...
The long life enterprise distros are the pain point in unlocking the
new of python features. So the proposal is that, at a minimum, we
augment the current policy with words to the effect that:
* For long life cycle distributions, QEMU will fo
On 16.02.23 17:04, Stefan Hajnoczi wrote:
Acked-by: Stefan Hajnoczi
Thanks!
--
Thanks,
David / dhildenb
On Fri, Feb 17, 2023 at 02:46:53PM +0100, Thomas Huth wrote:
> On 17/02/2023 12.37, Daniel P. Berrangé wrote:
> ...
> > The long life enterprise distros are the pain point in unlocking the
> > new of python features. So the proposal is that, at a minimum, we
> > augment the current policy with word
On Fri, Feb 17, 2023 at 8:39 AM Si-Wei Liu wrote:
>
>
>
> On 2/15/2023 11:35 PM, Eugenio Perez Martin wrote:
> > On Thu, Feb 16, 2023 at 3:15 AM Si-Wei Liu wrote:
> >>
> >>
> >> On 2/14/2023 11:07 AM, Eugenio Perez Martin wrote:
> >>> On Tue, Feb 14, 2023 at 2:45 AM Si-Wei Liu wrote:
>
> >>
Following the recommendation added in commit a98c370c46
("typedefs: (Re-)sort entries alphabetically"), and similarly
to commit 64baadc272 ("Sort include/qemu/typedefs.h"), sort
again the type definitions (in case-insensitive alphabetical
order, using 'sort --ignore-case').
Signed-off-by: Philippe
From: qianfan Zhao
TWI_CNTR_INT_FLAG is W1C(write 1 to clear and write 0 has non-effect)
register, we should lower interrupt when the guest write this bit.
The linux kernel will hang in irq handler(mv64xxx_i2c_intr) if no
device connected on the i2c bus, next is the trace log:
[7.004130] ax
From: qianfan Zhao
Next is an example when allwinner_i2c_rw enabled:
allwinner_i2c_rw write CNTR[0x0c]: 50 { M_STP BUS_EN }
allwinner_i2c_rw write CNTR[0x0c]: e4 { A_ACK M_STA BUS_EN INT_EN }
allwinner_i2c_rw read CNTR[0x0c]: cc { A_ACK INT_FLAG BUS_EN INT_EN }
allwinner_i2c_rw read
Yet another "try to reduce build-time" series.
Philippe Mathieu-Daudé (2):
qemu/typedefs: Sort in case-insensitive alphabetical order (again)
hw/timer: Reduce 'hw/ptimer.h' inclusion
hw/display/xlnx_dp.c | 1 +
hw/net/can/xlnx-zynqmp-can.c | 1 +
hw/net/fsl_
"hw/ptimer.h" API is mostly used by timer / watchdog device
models. Since the SoC / machines only access the ptimer via
reference, they don't need its definition: the declartion is
enough.
On order to reduce the inclusion on the source files,
forward-declare 'ptimer_state' in "qemu/typedefs.h".
Us
On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote:
> Following up on my previous work to make virtio-mem consume multiple
> memslots dynamically [1] that requires precise accounting between used vs.
> reserved memslots, I realized that vhost makes this extra hard by
> filtering out
On 17.02.23 15:20, Michael S. Tsirkin wrote:
On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote:
Following up on my previous work to make virtio-mem consume multiple
memslots dynamically [1] that requires precise accounting between used vs.
reserved memslots, I realized that vhost
On Friday, February 17, 2023 8:11:43 AM CET Dorinda Bassey wrote:
> This commit adds a new audiodev backend to allow QEMU to use Pipewire as
> both an audio sink and source. This backend is available on most systems
>
> Add Pipewire entry points for QEMU Pipewire audio backend
> Add wrappers for Q
On 2/17/23 12:37, Daniel P. Berrangé wrote:
So basically I'm suggesting we take a combination of John's series
here, and Paolo's series. John's last patch would change so that our
dockerfiles grab docutils with pip instead of disabling docs build
on centos8. Then look at introducing the use of v
On 2/17/23 14:26, Thomas Huth wrote:
Note: These changes mean that openSUSE is not considered as supported
anymore (since version 15.0 has been released in May 2018), and
RHEL/CentOS 8 will not be supported anymore in 3 months (since version
8.0 has been released in May 2019).
Signed-off-by: Tho
On 230217 1048, Darren Kenny wrote:
> I know this is a pull request, but if you prefer to have all the patches
> with and R-b, you can add mine here too, but I'll leave it up to you.
>
> Reviewed-by: Darren Kenny
>
Thank you Darren - I missed that this one wasn't reviewed..
On Fri, Feb 17, 2023 at 03:44:23PM +0100, Paolo Bonzini wrote:
> On 2/17/23 14:26, Thomas Huth wrote:
> > Note: These changes mean that openSUSE is not considered as supported
> > anymore (since version 15.0 has been released in May 2018), and
> > RHEL/CentOS 8 will not be supported anymore in 3 mo
On Fri, Feb 17, 2023 at 02:26:31PM +0100, Thomas Huth wrote:
> Our distro support policy has been written with a best-effort
> estimation of what users and developers need. However, as we now
> know, the support for older long-term distributions can get really
> troublesome for upstream development
The following changes since commit 6dffbe36af79e26a4d23f94a9a1c1201de99c261:
Merge tag 'migration-20230215-pull-request' of
https://gitlab.com/juan.quintela/qemu into staging (2023-02-16 13:09:51 +)
are available in the Git repository at:
https://repo.or.cz/qemu/kevin.git tags/for-upstr
Some functions must not be called from coroutine context. The common
pattern to use them anyway from a coroutine is running them in a BH and
letting the calling coroutine yield to be woken up when the BH is
completed.
Instead of manually writing such wrappers, add support for generating
them to bl
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-6-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Revi
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-5-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Revi
From: Emanuele Giuseppe Esposito
FreeBSD implements pthread headers using TSA (thread safety analysis)
annotations, therefore when an application is compiled with
-Wthread-safety there are some locking/annotation requirements that the
user of the pthread API has to follow.
This will also be the
From: Hanna Czenczek
g_hash_table_destroy() and g_hash_table_foreach_remove() (called by
curl_drop_all_sockets()) both require the table to be non-NULL, or will
print assertion failures (just print, no abort).
There are several paths in curl_open() that can lead to the out_noclean
label without
From: Emanuele Giuseppe Esposito
When calling bdrv_getlength() in handle_aiocb_write_zeroes(), the
function creates a new coroutine and then waits that it finishes using
AIO_WAIT_WHILE.
The problem is that this function could also run in a worker thread,
that has a different AioContext from main
From: Anton Johansson
* 7.55.0 deprecates CURLINFO_CONTENT_LENGTH_DOWNLOAD in favour of a *_T
version, which returns curl_off_t instead of a double.
* 7.85.0 deprecates CURLOPT_PROTOCOLS and CURLOPT_REDIR_PROTOCOLS in
favour of *_STR variants, specifying the desired protocols via a
string.
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-12-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Rev
Images can't be opened in coroutine context because opening needs to
change the block graph. Add no_co_wrappers so that coroutines have a
simple way of opening images in a BH instead.
At the same time, mark the wrapped functions as no_coroutine_fn.
Signed-off-by: Kevin Wolf
Message-Id: <20230126
From: Emanuele Giuseppe Esposito
FreeBSD implements pthread headers using TSA (thread safety analysis)
annotations, therefore when an application is compiled with
-Wthread-safety there are some locking/annotation requirements that the
user of the pthread API has to follow.
This will also be the
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-10-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Rev
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-11-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Rev
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-9-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Revi
This enables clang's thread safety analysis (TSA), which we'll use to
statically check the block graph locking.
Signed-off-by: Kevin Wolf
Message-Id: <20221207131838.239125-9-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
Message-Id: <20230117135203.3049709-
.bdrv_co_create implementations run in a coroutine, as does
qcow2_do_open(). Therefore they are not allowed to open images directly.
Fix the calls to use the corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-7-kw...@redhat.com>
Reviewed-by: Emanuel
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-4-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Revi
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-14-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Reviewed-by: Hanna Czenczek
Signed-off-by: Kevin Wolf
---
block.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/block.c b/block.c
index
From: Andrey Zhadchenko
The last return statement should return true, as we already evaluated that
start == next_dirty
Also, fix hbitmap_status() description in header
Cc: qemu-sta...@nongnu.org
Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()")
Signed-off-by: Andre
From: Stefano Garzarella
bdrv_append() is called with bs_top AioContext held, but
bdrv_attach_child_noperm() could change the AioContext of bs_top.
bdrv_replace_node_noperm() calls bdrv_drained_begin() starting from
commit 2398747128 ("block: Don't poll in bdrv_replace_child_noperm()").
bdrv_dra
bdrv_co_create_opts_simple() runs in a coroutine. Therefore it is not
allowed to open images directly. Fix the call to use the corresponding
no_co_wrapper instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-13-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Reviewed-b
.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.
Signed-off-by: Kevin Wolf
Message-Id: <20230126172432.436111-8-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Revi
From: Vladimir Sementsov-Ogievskiy
I have to admit this is out of my scope now. Still feel free to Cc me
directly if my help is needed :)
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20230214182848.1564714-1-vsement...@yandex-team.ru>
Signed-off-by: Kevin Wolf
---
MAINTAINERS | 2
Due to typo in opcode list, ctzw is disassembled as clzw instruction.
Signed-off-by: Ivan Klokov
---
disas/riscv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/riscv.c b/disas/riscv.c
index ddda687c13..d0639cd047 100644
--- a/disas/riscv.c
+++ b/disas/riscv.c
@@ -164
> I have been testing TCG plugin patch on latest Qemu build but noticed that it
> fails with assert on some of the applications.
>
>ERROR:../accel/tcg/cpu-exec.c:983:cpu_exec_loop:
>assertion failed: (cpu->plugin_mem_cbs == ((void *)0))
>
It seems that the problem is around tcg_ctx->
On Fri, Feb 17, 2023 at 01:41:50PM +0100, Paolo Bonzini wrote:
> Historically, the critical dependency for both building and running
> QEMU has been the distro packages. Because QEMU is written in C and C's
> package management has been tied to distros (at least if you do not want
> to bundle libr
On Thu, 16 Feb 2023 at 19:39, David Woodhouse wrote:
>
> On Thu, 2023-02-16 at 09:29 -1000, Richard Henderson wrote:
> > On 2/16/23 09:02, David Woodhouse wrote:
> > > It wouldn't be beyond the wit of man to extend qemu-user to support the
> > > similar personality variations for SCO/Solaris/etc.
On Thu, 16 Feb 2023 at 13:49, Pierrick Bouvier
wrote:
>
> ctr_el0 access is privileged on this platform and fails as an illegal
> instruction.
>
> Windows does not offer a way to flush data cache from userspace, and
> only FlushInstructionCache is available in Windows API.
>
> The generic implemen
On Fri, 17 Feb 2023 at 09:56, Thomas Huth wrote:
>
> On 17/02/2023 10.06, Markus Armbruster wrote:
> > Thomas Huth writes:
> ...
> > My view on all this is a bit more pragmatic.
> >
> > For a human developer, the difference between "dnf install
> > python-sphinx" and "pip install sphinx" is, in m
On Fri, Feb 17, 2023 at 03:37:16PM +, Peter Maydell wrote:
> On Fri, 17 Feb 2023 at 09:56, Thomas Huth wrote:
> >
> > On 17/02/2023 10.06, Markus Armbruster wrote:
> > > Thomas Huth writes:
> > ...
> > > My view on all this is a bit more pragmatic.
> > >
> > > For a human developer, the diffe
On 2/17/23 12:14, Ivan Klokov wrote:
Due to typo in opcode list, ctzw is disassembled as clzw instruction.
The code was added by 02c1b569a15b4b06a so I believe a "Fixes:" tag is in
order:
Fixes: 02c1b569a15b ("disas/riscv: Add Zb[abcs] instructions")
Signed-off-by: Ivan Klokov
---
dis
Hello, Chuang,
On Fri, Feb 17, 2023 at 04:11:19PM +0800, Chuang Xu wrote:
> Error 1 was triggered by our sanity check. I try to add RCU_READ_LOCK_GUARD()
> in address_space_init() and it works. But I'm not sure if this code change is
> appropriate. If this change is not appropriate, we may need to
Paolo Bonzini writes:
> Historically, the critical dependency for both building and running
> QEMU has been the distro packages. Because QEMU is written in C and C's
> package management has been tied to distros (at least if you do not want
> to bundle libraries with the binary, otherwise I supp
1 - 100 of 236 matches
Mail list logo
