Re: [PATCH 14/20] hw/ide: Rename ide_init2() -> ide_bus_init_output_irq()

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: ide_init2() initializes a IDEBus, and set its output IRQ. To emphasize this, rename it as ide_bus_init_output_irq(). Mechanical change using: $ sed -i -e 's/ide_init2/ide_bus_init_output_irq/g' \ $(git grep -l ide_init2) Signed-off-by

Re: [PATCH 15/20] hw/ide: Rename idebus_active_if() -> ide_bus_active_if()

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: idebus_active_if() operates on a IDEBus; rename it as ide_bus_active_if() to emphasize its first argument is a IDEBus. Mechanical change using: $ sed -i -e 's/idebus_active_if/ide_bus_active_if/g' \ $(git grep -l idebus_active_if) Sig

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.02.2023 um 08:40 hat Markus Armbruster geschrieben: >> I read this on Friday, and decided to let it sit until after the >> weekend. Well, it's now Tuesday, and to be frank, it's still as >> offensively flippant as it was on Friday. It shows either ignorance of >> or c

Re: [PATCH 16/20] hw/ide/ioport: Remove unnecessary includes

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ioport.c | 10 -- 1 file changed, 10 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 17/20] hw/ide/pci: Unexport bmdma_active_if()

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: From: Bernhard Beschow The function is only used inside ide/pci.c, so doesn't need to be exported. Signed-off-by: Bernhard Beschow Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/pci.c | 6 ++ include/hw/ide/pci.h | 6 -- 2 fi

Re: [PATCH 18/20] hw/ide/piix: Remove unused includes

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/piix.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 3/3] target/mips: implement CP0.Config7.WII bit support

2023-02-15 Thread Marcin Nowakowski
On Wed, Feb 15, 2023 at 7:33 PM Philippe Mathieu-Daudé wrote: > > Hi Marcin, > > On 15/2/23 09:47, Marcin Nowakowski wrote: > > Some older cores use CP0.Config7.WII bit to indicate that a disabled > > interrupt should wake up a sleeping CPU. > > Enable this bit by default for M14Kc, which supports

Re: [PATCH 19/20] hw/ide/piix: Pass Error* to pci_piix_init_ports() for better error msg

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: -rc = pci_piix_init_ports(d); -if (rc) { -error_setg_errno(errp, -rc, "Failed to realize %s", - object_get_typename(OBJECT(dev))); +if (!pci_piix_init_ports(d, errp)) { +return; } The if is

Re: [PATCH 20/20] hw/ide/piix: Refactor pci_piix_init_ports as pci_piix_init_bus per bus

2023-02-15 Thread Richard Henderson
On 2/15/23 01:27, Philippe Mathieu-Daudé wrote: @@ -165,8 +162,10 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d); -if (!pci_piix_init_ports(d, errp)) { -return; +for (unsigned i = 0; i < 2;

[PATCH 03/12] tests: add socat dependency for tests

2023-02-15 Thread Alex Bennée
We only use it for test-io-channel-command at the moment. Unfortunately bringing socat into CI exposes an existing bug in the test-io-channel-command unit test. For now disable the test with the preprocessor until someone can diagnose it on Mac hardware. Signed-off-by: Alex Bennée Cc: Philippe Ma

[PATCH 08/12] tests: skip the nios2 replay_kernel test

2023-02-15 Thread Alex Bennée
It is buggy and keeps failing. Suggested-by: Peter Maydell Signed-off-by: Alex Bennée --- tests/avocado/replay_kernel.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index 00a26e4a0c..f13456e1ec 100644 --- a/tests/avocado/re

[PATCH 06/12] gitlab: extend custom runners with base_job_template

2023-02-15 Thread Alex Bennée
The base job template is responsible for controlling how we kick off testing on our various branches. Rename and extend the custom_runner_template so we can take advantage of all that control. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 3 ++- .gitlab-c

[PATCH 05/12] gitlab: reduce default verbosity of cirrus run

2023-02-15 Thread Alex Bennée
We also truncate the echoing of the test log if we fail. Ideally we would want the build aretefact to be available to gitlab but so far how to do this eludes me. Signed-off-by: Alex Bennée Cc: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 11/12] cirrus.yml: Improve the windows_msys2_task

2023-02-15 Thread Alex Bennée
From: Thomas Huth There's no need to run a full-blown bash just to create a directory. And we can skip the "cd build" each time by doing it once at the beginning. Additionally, let's exclude some targets (that we already compile-test with MinGW in the gitlab jobs) from the build, since the build

[PATCH 09/12] tests: add tuxrun baseline test to avocado

2023-02-15 Thread Alex Bennée
The TuxRun project (www.tuxrun.org) uses QEMU to run tests on a wide variety of kernel configurations on wide range of our emulated platforms. They publish a known good set of images at: https://storage.tuxboot.com/ to help with bisecting regressions in either the kernel, firmware or QEMU itsel

[PATCH 00/12] testing/next: docker, avocado, unit,

2023-02-15 Thread Alex Bennée
Here is the current status of my testing next. I've had to jump a few hoops on MacOS as adding socat discovered a unit test failure. This also includes tuxrun_baselines which is a collection of quick test images that exercise a wide range of platforms. The following patches need review: tests: en

[PATCH 02/12] tests/avocado: retire the Aarch64 TCG tests from boot_linux.py

2023-02-15 Thread Alex Bennée
The two TCG tests for GICv2 and GICv3 are very heavy weight distros that take a long time to boot up, especially for an --enable-debug build. The total code coverage they give is: Overall coverage rate: lines..: 11.2% (59584 of 530123 lines) functions..: 15.0% (7436 of 49443 function

[PATCH 12/12] tests: ensure we export job results for some cross builds

2023-02-15 Thread Alex Bennée
We do run tests on some cross builds. Provide a template to ensure we export the testlog to the build artefacts and report the test results via the junit. Signed-off-by: Alex Bennée Reported-by: Peter Maydell --- v2 - properly format extends --- .gitlab-ci.d/crossbuild-template.yml | 11

[PATCH 04/12] tests: be a bit more strict cleaning up fifos

2023-02-15 Thread Alex Bennée
When we re-factored we dropped the unlink() step which turns out to be required for rmdir to do its thing. If we had been checking the return value we would have noticed so lets do that with this fix. Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) Signed-off-by: Alex Bennée

[PATCH 10/12] tests/docker: Use binaries for debian-tricore-cross

2023-02-15 Thread Alex Bennée
From: Bastian Koppelmann since binutils is pretty old, it fails our CI repeatedly during the compilation of tricore-binutils. We created a precompiled version using the debian docker image and download it instead of building it ourself. We also updated the package to include a newer version of b

[PATCH 01/12] gitlab: tweak and filter ninja output to reduce build noise

2023-02-15 Thread Alex Bennée
A significant portion of our CI logs are just enumerating each successfully built object file. The current widespread versions of ninja don't have a quiet option so we use NINJA_STATUS to add a fixed string to the ninja output which we then filter with grep. If there are any errors in the output we

[PATCH 07/12] testing: update ubuntu2004 to ubuntu2204

2023-02-15 Thread Alex Bennée
The 22.04 LTS release has been out for almost a year now so its time to update all the remaining images to the current LTS. We can also drop some hacks we need for older clang TSAN support. Signed-off-by: Alex Bennée --- docs/devel/testing.rst| 4 ++-- .gitlab-ci.d/build

Re: [PATCH 3/3] target/mips: implement CP0.Config7.WII bit support

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 20:19, Marcin Nowakowski wrote: On Wed, Feb 15, 2023 at 7:33 PM Philippe Mathieu-Daudé wrote: Hi Marcin, On 15/2/23 09:47, Marcin Nowakowski wrote: Some older cores use CP0.Config7.WII bit to indicate that a disabled interrupt should wake up a sleeping CPU. Enable this bit by defa

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-15 Thread Jean-Philippe Brucker
Hi Mostafa, On Sun, Feb 05, 2023 at 09:44:07AM +, Mostafa Saleh wrote: > Allow TLB to be tagged with VMID. > > If stage-1 is only supported, VMID is set to -1 and ignored from STE > and CMD_TLBI_NH* cmds. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 24 ++

Re: [PATCH 1/8] m25p80: Improve error when the backend file size does not match the device

2023-02-15 Thread Peter Delevoryas
On Tue, Feb 14, 2023 at 06:18:23PM +0100, Cédric Le Goater wrote: > Currently, when a block backend is attached to a m25p80 device and the > associated file size does not match the flash model, QEMU complains > with the error message "failed to read the initial flash content". > This is confusing f

Re: [PATCH 03/12] tests: add socat dependency for tests

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 20:25, Alex Bennée wrote: We only use it for test-io-channel-command at the moment. Unfortunately bringing socat into CI exposes an existing bug in the test-io-channel-command unit test. For now disable the test with the preprocessor until someone can diagnose it on Mac hardware. Sign

Re: [PATCH v6 1/3] multifd: Create property multifd-flush-after-each-section

2023-02-15 Thread Peter Xu
On Wed, Feb 15, 2023 at 07:02:29PM +0100, Juan Quintela wrote: > We used to flush all channels at the end of each RAM section > sent. That is not needed, so preparing to only flush after a full > iteration through all the RAM. > > Default value of the property is false. But we return "true" in >

Re: [PATCH v2 0/4] Remove C virtiofsd

2023-02-15 Thread Stefan Hajnoczi
On Wed, Feb 15, 2023 at 06:43:06PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a > in v7.0 in favour of the Rust implementation at > > https://gitlab.com/virtio-fs/virtiofsd > > since then, the Ru

Re: [PULL v2 0/10] xenpvh

2023-02-15 Thread Fabiano Rosas
Peter Maydell writes: > On Tue, 14 Feb 2023 at 23:43, Stefano Stabellini > wrote: >> >> The following changes since commit 6a50f64ca01d0a7b97f14f069762bfd88160f31e: >> >> Merge tag 'pull-request-2023-02-14' of https://gitlab.com/thuth/qemu into >> staging (2023-02-14 14:46:10 +) >> >> ar

[PULL 0/5] Migration 20230215 patches

2023-02-15 Thread Juan Quintela
/migration-20230215-pull-request for you to fetch changes up to 24beea4efe6e6b65fd6248ede936cd3278b2bf8a: migration: Rename res_{postcopy,precopy}_only (2023-02-15 20:04:30 +0100) Migration Pull request This pull request contai

[PULL 2/5] migration/block: Convert remaining DPRINTF() debug macro to trace events

2023-02-15 Thread Juan Quintela
From: Philippe Mathieu-Daudé Finish the conversion from commit fe80c0241d ("migration: using trace_ to replace DPRINTF"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/block.c | 12 +--- migration/trace-events | 1 +

Re: [PATCH v6 3/3] multifd: Only flush once each full round of memory

2023-02-15 Thread Peter Xu
On Wed, Feb 15, 2023 at 07:02:31PM +0100, Juan Quintela wrote: > We need to add a new flag to mean to flush at that point. > Notice that we still flush at the end of setup and at the end of > complete stages. > > Signed-off-by: Juan Quintela Acked-by: Peter Xu One nitpick below. > > --- > >

[PULL 3/5] migration: In case of postcopy, the memory ends in res_postcopy_only

2023-02-15 Thread Juan Quintela
So remove last assignation of res_compatible. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Juan Quintela --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 521912385d..ecf697a58d 100644 --- a/migration/ram.

[PULL 5/5] migration: Rename res_{postcopy,precopy}_only

2023-02-15 Thread Juan Quintela
Once that res_compatible is removed, they don't make sense anymore. We remove the _only preffix. And to make things clearer we rename them to must_precopy and can_postcopy. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Juan Quintela --- include/migration/register.h | 27 ++

[PULL 1/5] migration/qemu-file: Add qemu_file_get_to_fd()

2023-02-15 Thread Juan Quintela
From: Avihai Horon Add new function qemu_file_get_to_fd() that allows reading data from QEMUFile and writing it straight into a given fd. This will be used later in VFIO migration code. Signed-off-by: Avihai Horon Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cédric Le Goater Review

Re: [PATCH v6 2/3] multifd: Protect multifd_send_sync_main() calls

2023-02-15 Thread Peter Xu
On Wed, Feb 15, 2023 at 07:02:30PM +0100, Juan Quintela wrote: > We only need to do that on the ram_save_iterate() call on sending and > on destination when we get a RAM_SAVE_FLAG_EOS. > > In setup() and complete() we need to synch in both new and old cases, > so don't add a check there. > > Sign

[PULL 4/5] migration: Remove unused res_compatible

2023-02-15 Thread Juan Quintela
Nothing assigns to it after previous commit. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Juan Quintela --- include/migration/register.h | 7 ++- migration/savevm.h | 2 -- hw/s390x/s390-stattrib.c | 1 - hw/vfio/migration.c| 3 +-- migration/

Re: [PATCH 3/7] configure: Look for auxiliary Python installations

2023-02-15 Thread John Snow
On Fri, Feb 10, 2023 at 2:45 PM Eric Blake wrote: > > On Thu, Feb 09, 2023 at 10:40:30AM -0500, John Snow wrote: > > At the moment, we look for just "python3" and "python", which is good > > enough almost all of the time. But ... if you are on a platform that > > uses an older Python by default an

Re: [PATCH v6 1/3] multifd: Create property multifd-flush-after-each-section

2023-02-15 Thread Juan Quintela
Peter Xu wrote: > On Wed, Feb 15, 2023 at 07:02:29PM +0100, Juan Quintela wrote: >> We used to flush all channels at the end of each RAM section >> sent. That is not needed, so preparing to only flush after a full >> iteration through all the RAM. >> >> Default value of the property is false. B

Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-02-15 Thread Alex Williamson
On Wed, 15 Feb 2023 19:04:33 +0100 Juan Quintela wrote: > Avihai Horon wrote: > > On 15/02/2023 14:43, Juan Quintela wrote: > >> External email: Use caution opening links or attachments > >> > >> > >> Avihai Horon wrote: > >>> Currently, if IOMMU of a VFIO container doesn't support dirty pa

Re: [PATCH 1/3] target/mips: fix JALS32/J32 instruction handling for microMIPS

2023-02-15 Thread Richard Henderson
On 2/14/23 22:47, Marcin Nowakowski wrote: @@ -4860,6 +4860,7 @@ static void gen_compute_branch(DisasContext *ctx, uint32_t opc, target_ulong btgt = -1; int blink = 0; int bcond_compute = 0; +int jal_mask = 0; Better to limit the scope of the variable to the block below.

Re: [PATCH] coverity: physmem: use simple assertions instead of modelling

2023-02-15 Thread Vladimir Sementsov-Ogievskiy
ping [add Stefan] -- Best regards, Vladimir

Re: [PATCH 5/7] testing: Add Python >= 3.7 to Centos, OpenSuSE

2023-02-15 Thread John Snow
On Fri, Feb 10, 2023 at 5:38 AM Daniel P. Berrangé wrote: > > On Thu, Feb 09, 2023 at 10:40:32AM -0500, John Snow wrote: > > This is just a proof-of-concept patch, as these files are lcitool > > generated. The real fix will involve updating the lcitool configuration > > and updating these files th

Re: [PATCH 6/7] CI: Stop building docs on centos8

2023-02-15 Thread John Snow
On Fri, Feb 10, 2023 at 5:30 AM Paolo Bonzini wrote: > > On 2/10/23 00:32, John Snow wrote: > >> It's possible to teach lcitool to use pip instead to install > >> docutils, sphinx and sphinx-rtd-theme > > > > I will say that once upon a time, Peter Maydell expressed a > > preference to use the ver

Re: [PATCH qemu 2/2] aspeed/fuji : correct the eeprom size

2023-02-15 Thread Peter Delevoryas
On Tue, Feb 14, 2023 at 03:28:58PM +0100, Cédric Le Goater wrote: > Hello, > > Adding Peter since he contributed the fuji machine, > > On 2/14/23 10:06, ~ssinprem wrote: > > From: Sittisak Sinprem > > > > Device 24C64 the size is 64 kilobits > > Device 24C02 the size is 2 kilobits > > Could yo

Re: [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode

2023-02-15 Thread Peter Delevoryas
On Tue, Feb 14, 2023 at 03:29:33PM +0100, Cédric Le Goater wrote: > On 2/10/23 07:20, ~ssinprem wrote: > > From: Sittisak Sinprem > > > > You will need to add a Signed-off-by tag > > Thanks, > > C. Oh, yeah this is a pretty good change: I mean, at first I had no idea what's going on here, so

Re: [PATCH v1 RFC Zisslpcfi 2/9] target/riscv: zisslpcfi CSR, bit positions and other definitions

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 7:31 PM LIU Zhiwei wrote: > > > On 2023/2/9 14:23, Deepak Gupta wrote: > > `zisslpcfi` extension adds two new CSRs. CSR_SSP and CSR_LPLR. > > - CSR_SSP: This CSR holds shadow stack pointer for current privilege mode > > CSR_SSP is accessible in all modes. Each m

Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-02-15 Thread Jason Gunthorpe
On Wed, Feb 15, 2023 at 01:14:35PM -0700, Alex Williamson wrote: > We'll need to consider whether we want to keep "dumb" dirty tracking, > or even any form of dirty tracking in the type1 uAPI, under an > experimental opt-in. Thanks, I was expecting we'd delete the kernel code for type 1 dirty tr

Re: [PATCH 04/12] tests: be a bit more strict cleaning up fifos

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 20:25, Alex Bennée wrote: When we re-factored we dropped the unlink() step which turns out to be required for rmdir to do its thing. If we had been checking the return value we would have noticed so lets do that with this fix. Fixes: 68406d1085 (tests/unit: cleanups for test-io-channe

Re: [PATCH v1 RFC Zisslpcfi 1/9] target/riscv: adding zimops and zisslpcfi extension to RISCV cpu config

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 6:52 PM LIU Zhiwei wrote: > > > On 2023/2/9 14:23, Deepak Gupta wrote: > > Introducing riscv `zisslpcfi` extension to riscv target. `zisslpcfi` > > extension provides hardware assistance to riscv hart to enable control > > flow integrity (CFI) for software. > > > > `zisslpc

Re: [PATCH 08/12] tests: skip the nios2 replay_kernel test

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 20:25, Alex Bennée wrote: It is buggy and keeps failing. Suggested-by: Peter Maydell Signed-off-by: Alex Bennée --- tests/avocado/replay_kernel.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py index 00a26e4a0c.

Re: [PATCH 10/12] tests/docker: Use binaries for debian-tricore-cross

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 20:25, Alex Bennée wrote: From: Bastian Koppelmann since binutils is pretty old, it fails our CI repeatedly during the compilation of tricore-binutils. We created a precompiled version using the debian docker image and download it instead of building it ourself. We also updated the

Re: [PATCH 1/3] target/mips: fix JALS32/J32 instruction handling for microMIPS

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 21:21, Richard Henderson wrote: On 2/14/23 22:47, Marcin Nowakowski wrote: @@ -4860,6 +4860,7 @@ static void gen_compute_branch(DisasContext *ctx, uint32_t opc,   target_ulong btgt = -1;   int blink = 0;   int bcond_compute = 0; +    int jal_mask = 0; Better to limit th

Re: [PATCH 0/4] qemu-img: Fix exit code for errors closing the image

2023-02-15 Thread Vladimir Sementsov-Ogievskiy
On 15.02.23 16:07, Markus Armbruster wrote: Kevin Wolf writes: Am 13.01.2023 um 08:30 hat Markus Armbruster geschrieben: Drive-by comment... Kevin Wolf writes: This series addresses the problem described in these bug reports: https://gitlab.com/qemu-project/qemu/-/issues/1330 https://bugz

Re: [PATCH 01/20] MAINTAINERS: Mark IDE and Floppy as "Odd Fixes"

2023-02-15 Thread Philippe Mathieu-Daudé
On 15/2/23 12:26, Philippe Mathieu-Daudé wrote: From: John Snow I have not been able to give these devices the love they need for a while now. Update the maintainers file to reflect the truth of the matter. Signed-off-by: John Snow Message-Id: <20230206182544.77-1-js...@redhat.com> Signed

Re: [PATCH 04/12] tests: be a bit more strict cleaning up fifos

2023-02-15 Thread Richard Henderson
On 2/15/23 09:25, Alex Bennée wrote: When we re-factored we dropped the unlink() step which turns out to be required for rmdir to do its thing. If we had been checking the return value we would have noticed so lets do that with this fix. Fixes: 68406d1085 (tests/unit: cleanups for test-io-channe

Re: [PATCH v10 09/12] vfio/migration: Implement VFIO migration protocol v2

2023-02-15 Thread Alex Williamson
On Wed, 15 Feb 2023 20:23:12 +0200 Avihai Horon wrote: > On 15/02/2023 15:01, Juan Quintela wrote: > > External email: Use caution opening links or attachments > > > > > > Avihai Horon wrote: > >> Implement the basic mandatory part of VFIO migration protocol v2. > >> This includes all function

Re: [PATCH 08/12] tests: skip the nios2 replay_kernel test

2023-02-15 Thread Richard Henderson
On 2/15/23 09:25, Alex Bennée wrote: It is buggy and keeps failing. Suggested-by: Peter Maydell Signed-off-by: Alex Bennée --- tests/avocado/replay_kernel.py | 1 + 1 file changed, 1 insertion(+) Acked-by: Richard Henderson r~

Re: [PATCH 07/12] testing: update ubuntu2004 to ubuntu2204

2023-02-15 Thread Richard Henderson
On 2/15/23 09:25, Alex Bennée wrote: The 22.04 LTS release has been out for almost a year now so its time to update all the remaining images to the current LTS. We can also drop some hacks we need for older clang TSAN support. Signed-off-by: Alex Bennée --- docs/devel/testing.rst

Re: [PATCH 5/7] hw/ide/piix: Use generic ide_init_ioport()

2023-02-15 Thread Philippe Mathieu-Daudé
On 10/2/23 17:34, Bernhard Beschow wrote: Am 9. Februar 2023 09:04:49 UTC schrieb Bernhard Beschow : On Wed, Feb 8, 2023 at 1:08 AM Philippe Mathieu-Daudé wrote: TYPE_PIIX3_IDE is a PCI function inheriting from QOM TYPE_PCI_DEVICE. To be able to call the ISA specific ide_init_ioport_isa(), we

[PATCH v5 0/4] riscv: Add support for Zicbo[m,z,p] instructions

2023-02-15 Thread Daniel Henrique Barboza
Hi, This is the v5 of the patch series sent by Christoph Muellner one year ago [1]. Aside from a code rebase on top of Alistair's riscv-to-apply.next I also tried to implement the suggestions given in the reviews. Patch 1 is unchanged, aside from trivial changes due to code rebasing. Patch 2 from

[PATCH v5 3/4] target/riscv: implement Zicbom extension

2023-02-15 Thread Daniel Henrique Barboza
From: Christoph Muellner Zicbom is the Cache-Block Management extension defined in the already ratified RISC-V Base Cache Management Operation (CBO) ISA extension [1]. The extension contains three instructions: cbo.clean, cbo.flush and cbo.inval. All of them must be implemented in the same group

[PATCH v5 2/4] target/riscv: implement Zicboz extension

2023-02-15 Thread Daniel Henrique Barboza
From: Christoph Muellner The RISC-V base cache management operation (CBO) ISA extension has been ratified. It defines three extensions: Cache-Block Management, Cache-Block Prefetch and Cache-Block Zero. More information about the spec can be found at [1]. Let's start by implementing the Cache-Bl

[PATCH v5 1/4] accel/tcg: Add probe_access_range_flags interface

2023-02-15 Thread Daniel Henrique Barboza
From: Christoph Muellner The existing probe_access* functions do not allow to specify the access size and a non-faulting behavior at the same time. This is resolved by adding a generalization of probe_access_flags() that takes an additional size parameter. The semantics is basically the same as

Re: [PATCH 08/12] tests: skip the nios2 replay_kernel test

2023-02-15 Thread Richard Henderson
On 2/15/23 10:47, Philippe Mathieu-Daudé wrote: +    @skip("nios2 emulation is buggy under record/replay") It will be hard to notice the flakyness got improved. What about:    @skipUnless(os.getenv('AVOCADO_RUN_FLAKY_TESTS'), 'Flaky test')   def test_nios2_10m50(self):   """

[PATCH v5 4/4] target/riscv: add Zicbop cbo.prefetch{i, r, m} placeholder

2023-02-15 Thread Daniel Henrique Barboza
From: Christoph Muellner The cmo.prefetch instructions are nops for QEMU (no emulation of the memory hierarchy, no illegal instructions, no permission faults, no traps). Add a comment noting where they would be decoded in case cbo.prefetch instructions become relevant in the future. Co-develope

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-15 Thread Vladimir Sementsov-Ogievskiy
On 14.02.23 19:28, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 12:57:28PM +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Feb 14, 2023 at 09:54:22AM +0100, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Feb 13, 2023 at 05:

Re: [PATCH v10 03/12] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-02-15 Thread Alex Williamson
On Wed, 15 Feb 2023 16:38:10 -0400 Jason Gunthorpe wrote: > On Wed, Feb 15, 2023 at 01:14:35PM -0700, Alex Williamson wrote: > > > We'll need to consider whether we want to keep "dumb" dirty tracking, > > or even any form of dirty tracking in the type1 uAPI, under an > > experimental opt-in. Th

Re: [PATCH 17/20] hw/ide/pci: Unexport bmdma_active_if()

2023-02-15 Thread BALATON Zoltan
On Wed, 15 Feb 2023, Bernhard Beschow wrote: Am 15. Februar 2023 11:27:09 UTC schrieb "Philippe Mathieu-Daudé" : From: Bernhard Beschow The function is only used inside ide/pci.c, so doesn't need to be exported. Signed-off-by: Bernhard Beschow Signed-off-by: Philippe Mathieu-Daudé --- hw/i

Re: [PULL v2 0/10] xenpvh

2023-02-15 Thread Stefano Stabellini
On Wed, 15 Feb 2023, Fabiano Rosas wrote: > Peter Maydell writes: > > > On Tue, 14 Feb 2023 at 23:43, Stefano Stabellini > > wrote: > >> > >> The following changes since commit > >> 6a50f64ca01d0a7b97f14f069762bfd88160f31e: > >> > >> Merge tag 'pull-request-2023-02-14' of https://gitlab.com/

Re: [PATCH] qemu: make version available in coredump

2023-02-15 Thread Vladimir Sementsov-Ogievskiy
ping) -- Best regards, Vladimir

Re: [PATCH v5 2/4] target/riscv: implement Zicboz extension

2023-02-15 Thread Richard Henderson
On 2/15/23 10:59, Daniel Henrique Barboza wrote: +mem = probe_access(env, address, cbozlen, MMU_DATA_STORE, + cpu_mmu_index(env, false), ra); + +/* Zero the block */ +memset(mem, 0, cbozlen); Will crash if address does not resolve to ram. According to page 16,

Re: Lost partition tables on ide-hd + ahci drive

2023-02-15 Thread John Snow
On Wed, Feb 15, 2023, 5:53 AM Fiona Ebner wrote: > Am 14.02.23 um 19:21 schrieb John Snow: > > On Thu, Feb 2, 2023 at 7:08 AM Fiona Ebner wrote: > >> > >> Hi, > >> over the years we've got 1-2 dozen reports[0] about suddenly > >> missing/corrupted MBR/partition tables. The issue seems to be very

Re: [PATCH] qemu: make version available in coredump

2023-02-15 Thread Stefan Hajnoczi
On Tue, 7 Jun 2022 at 16:33, Vladimir Sementsov-Ogievskiy wrote: > > Add a variable with QEMU_FULL_VERSION definition. Then the content of > the variable is easily searchable: > >strings /path/to/core | grep QEMU_FULL_VERSION > > 'volatile' keyword is used to avoid removing the variable by com

Re: [Qemu-devel] [PATCH 19/38] char: make some qemu_chr_fe skip if no driver

2023-02-15 Thread Philippe Mathieu-Daudé
Hi Marc-André, [very old patch...] On 22/10/16 11:52, Marc-André Lureau wrote: In most cases, front ends do not care about the side effect of CharBackend, so we can simply skip the checks and call the qemu_chr_fe functions even without associated CharDriver. Signed-off-by: Marc-André Lureau -

Re: [PATCH v5 3/4] target/riscv: implement Zicbom extension

2023-02-15 Thread Richard Henderson
On 2/15/23 10:59, Daniel Henrique Barboza wrote: From: Christoph Muellner Zicbom is the Cache-Block Management extension defined in the already ratified RISC-V Base Cache Management Operation (CBO) ISA extension [1]. The extension contains three instructions: cbo.clean, cbo.flush and cbo.inval

Re: [PATCH v5 4/4] target/riscv: add Zicbop cbo.prefetch{i, r, m} placeholder

2023-02-15 Thread Richard Henderson
On 2/15/23 10:59, Daniel Henrique Barboza wrote: From: Christoph Muellner The cmo.prefetch instructions are nops for QEMU (no emulation of the memory hierarchy, no illegal instructions, no permission faults, no traps). Add a comment noting where they would be decoded in case cbo.prefetch instru

Re: [PATCH v5 3/4] target/riscv: implement Zicbom extension

2023-02-15 Thread Richard Henderson
On 2/15/23 12:13, Richard Henderson wrote:     ret = probe_access_flags(env, address, MMU_DATA_LOAD, mmu_idx, true, &phost, ra);     if (ret != TLB_INVALID_MASK) {     /* Success: readable */     return;     } ... At which point the new probe_acccess_range_flags is not needed. O

[PATCH] virtio: fix reachable assertion due to stale value of cached region size

2023-02-15 Thread Carlos López
In virtqueue_{split,packed}_get_avail_bytes() descriptors are read in a loop via MemoryRegionCache regions and calls to vring_{split,packed}_desc_read() - these take a region cache and the index of the descriptor to be read. For direct descriptors we use a cache provided by the caller, whose size

Re: [PATCH v1 RFC Zisslpcfi 5/9] target/riscv: state save and restore of zisslppcfi state

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 10:11 PM LIU Zhiwei wrote: > > > On 2023/2/9 14:24, Deepak Gupta wrote: > > zisslpcfi's forward cfi if enabled on a hart, enables tracking of > > indirect branches. CPU/hart internally keeps a state `elp` short > > for expecting landing pad instruction. This state goes into

Re: [PATCH v1 RFC Zisslpcfi 3/9] target/riscv: implements CSRs and new bits in existing CSRs in zisslpcfi

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 9:47 PM LIU Zhiwei wrote: > > > On 2023/2/9 14:23, Deepak Gupta wrote: > > CSR_SSP and CSR_LPLR are new CSR additions to cpu/hart. This patch allows > > access to these CSRs. A predicate routine handles access to these CSR as > > per specification. > > > > This patch also i

Re: [PATCH v1 RFC Zisslpcfi 4/9] target/riscv: helper functions for forward and backward cfi

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 10:26 PM LIU Zhiwei wrote: > > > On 2023/2/9 14:23, Deepak Gupta wrote: > > Implementation for forward cfi and backward cfi needs helper function > > to determine if currently fcfi and bcfi are enabled. Enable depends on > > privilege mode and settings in sstatus/menvcfg/he

Re: [PATCH v1 RFC Zisslpcfi 3/9] target/riscv: implements CSRs and new bits in existing CSRs in zisslpcfi

2023-02-15 Thread Deepak Gupta
On Tue, Feb 14, 2023 at 10:24 PM LIU Zhiwei wrote: > > I don't find the modification for read_mstatus. Doesn't need any modification in read_mstatus. It just returns whatever is in the mstatus. > > Zhiwei > > On 2023/2/15 13:47, LIU Zhiwei wrote: > > > > On 2023/2/9 14:23, Deepak Gupta wrote: >

Re: [RFC v3 14/18] backends/iommufd: Introduce the iommufd object

2023-02-15 Thread Nicolin Chen
Hi Eric, On Tue, Jan 31, 2023 at 09:53:01PM +0100, Eric Auger wrote: > diff --git a/include/sysemu/iommufd.h b/include/sysemu/iommufd.h > new file mode 100644 > index 00..06a866d1bd > --- /dev/null > +++ b/include/sysemu/iommufd.h > @@ -0,0 +1,47 @@ > +#ifndef SYSEMU_IOMMUFD_H > +#define

Re: [PATCH v1 RFC Zisslpcfi 6/9] target/riscv: MMU changes for back cfi's shadow stack

2023-02-15 Thread Deepak Gupta
`On Wed, Feb 15, 2023 at 12:43 AM LIU Zhiwei wrote: > > > On 2023/2/9 14:24, Deepak Gupta wrote: > > zisslpcfi protects returns(back cfi) using shadow stack. If compiled with > > enabled compiler, function prologs will have `sspush ra` instruction to > > push return address on shadow stack and fun

Re: [PATCH v1 RFC Zisslpcfi 7/9] target/riscv: Tracking indirect branches (fcfi) using TCG

2023-02-15 Thread Deepak Gupta
On Wed, Feb 15, 2023 at 12:55 AM LIU Zhiwei wrote: > > > On 2023/2/9 14:24, Deepak Gupta wrote: > > zisslpcfi protects forward control flow (if enabled) by enforcing all > > indirect call and jmp must land on a landing pad instruction `lpcll` > > short for landing pad and check lower label value.

Re: [PATCH v1 RFC Zisslpcfi 3/9] target/riscv: implements CSRs and new bits in existing CSRs in zisslpcfi

2023-02-15 Thread Richard Henderson
On 2/15/23 13:33, Deepak Gupta wrote: On Tue, Feb 14, 2023 at 9:47 PM LIU Zhiwei wrote: And MSTATUS_UBCFIEN field change don't need flush tlb. TCG code-gen would be different depending on whether ubcfi is enabled or not. As an example a TB might have code generated when bcfi was enabled. But

Re: [PATCH 14/20] hw/ide: Rename ide_init2() -> ide_bus_init_output_irq()

2023-02-15 Thread Bernhard Beschow
Am 15. Februar 2023 11:27:06 UTC schrieb "Philippe Mathieu-Daudé" : >ide_init2() initializes a IDEBus, and set its output IRQ. s/a IDEBus/an IDEBus/, see e.g. https://owl.purdue.edu/owl/general_writing/grammar/articles_a_versus_an.html . >To emphasize this, rename it as ide_bus_init_output_i

Re: [PATCH 17/20] hw/ide/pci: Unexport bmdma_active_if()

2023-02-15 Thread Bernhard Beschow
Am 15. Februar 2023 21:09:10 UTC schrieb BALATON Zoltan : >On Wed, 15 Feb 2023, Bernhard Beschow wrote: >> Am 15. Februar 2023 11:27:09 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> From: Bernhard Beschow >>> >>> The function is only used inside ide/pci.c, so doesn't need to be exported. >>>

Re: [PATCH v3 02/10] target/riscv: always allow write_misa() to write MISA

2023-02-15 Thread Bin Meng
On Thu, Feb 16, 2023 at 2:58 AM Daniel Henrique Barboza wrote: > > At this moment, and apparently since ever, we have no way of enabling > RISCV_FEATURE_MISA. This means that all the code from write_misa(), all > the nuts and bolts that handles how to properly write this CSR, has > always been a n

Re: [PATCH 17/20] hw/ide/pci: Unexport bmdma_active_if()

2023-02-15 Thread Bernhard Beschow
Am 16. Februar 2023 00:18:47 UTC schrieb Bernhard Beschow : > > >Am 15. Februar 2023 21:09:10 UTC schrieb BALATON Zoltan : >>On Wed, 15 Feb 2023, Bernhard Beschow wrote: >>> Am 15. Februar 2023 11:27:09 UTC schrieb "Philippe Mathieu-Daudé" >>> : From: Bernhard Beschow The funct

Re: [PATCH v4 14/16] qapi: deprecate "device" field of DEVICE_* events

2023-02-15 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: [...] > So, if no objections, I plan to resend with old "optional id & qom_path" > designation for devices. We still can do a deprecation in future. Yes, please.

[RFC PATCH 1/2] mm: restrictedmem: Allow userspace to specify mount_path for memfd_restricted

2023-02-15 Thread Ackerley Tng
By default, the backing shmem file for a restrictedmem fd is created on shmem's kernel space mount. With this patch, an optional tmpfs mount can be specified, which will be used as the mountpoint for backing the shmem file associated with a restrictedmem fd. This change is modeled after how sys_o

[RFC PATCH 0/2] Providing mount for memfd_restricted() syscall

2023-02-15 Thread Ackerley Tng
Hello, This patchset builds upon the memfd_restricted() system call that has been discussed in the ‘KVM: mm: fd-based approach for supporting KVM’ patch series, at https://lore.kernel.org/lkml/20221202061347.1070246-1-chao.p.p...@linux.intel.com/T/#m7e944d7892afdd1d62a03a287bd488c56e377b0c The tr

[RFC PATCH 2/2] selftests: restrictedmem: Check hugepage-ness of shmem file backing restrictedmem fd

2023-02-15 Thread Ackerley Tng
For memfd_restricted() calls without a userspace mount, the backing file should be the shmem mount in the kernel, and the size of backing pages should be as defined by system-wide shmem configuration. If a userspace mount is provided, the size of backing pages should be as defined in the mount. S

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 09:35:44AM +0100, Thomas Huth wrote: >> On 14/02/2023 08.40, Markus Armbruster wrote: >> > Daniel P. Berrangé writes: >> > >> > [...] >> > >> > > We don't have to drop python 3.6. It is a choice because >> > > of a desire to be able to use s

Re: [PATCH 1/3] target/mips: fix JALS32/J32 instruction handling for microMIPS

2023-02-15 Thread Jiaxun Yang
在2023年2月15日二月 下午8:50,Philippe Mathieu-Daudé写道: > On 15/2/23 21:21, Richard Henderson wrote: >> On 2/14/23 22:47, Marcin Nowakowski wrote: >>> @@ -4860,6 +4860,7 @@ static void gen_compute_branch(DisasContext >>> *ctx, uint32_t opc, >>>   target_ulong btgt = -1; >>>   int blink = 0; >>>

Re: [PATCH v3 02/10] target/riscv: always allow write_misa() to write MISA

2023-02-15 Thread weiwei
On 2023/2/16 02:57, Daniel Henrique Barboza wrote: At this moment, and apparently since ever, we have no way of enabling RISCV_FEATURE_MISA. This means that all the code from write_misa(), all the nuts and bolts that handles how to properly write this CSR, has always been a no-op as well becaus

Re: [PATCH v1 RFC Zisslpcfi 3/9] target/riscv: implements CSRs and new bits in existing CSRs in zisslpcfi

2023-02-15 Thread Deepak Gupta
On Wed, Feb 15, 2023 at 4:02 PM Richard Henderson wrote: > > On 2/15/23 13:33, Deepak Gupta wrote: > > On Tue, Feb 14, 2023 at 9:47 PM LIU Zhiwei > > wrote: > >> And MSTATUS_UBCFIEN field change don't need flush tlb. > >> > > > > TCG code-gen would be different depending on whether ubcfi is enab

Re: [PATCH v1 RFC Zisslpcfi 1/9] target/riscv: adding zimops and zisslpcfi extension to RISCV cpu config

2023-02-15 Thread LIU Zhiwei
On 2023/2/16 4:47, Deepak Gupta wrote: On Tue, Feb 14, 2023 at 6:52 PM LIU Zhiwei wrote: On 2023/2/9 14:23, Deepak Gupta wrote: Introducing riscv `zisslpcfi` extension to riscv target. `zisslpcfi` extension provides hardware assistance to riscv hart to enable control flow integrity (CFI) fo

<    1   2   3   4   5   6   >