Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

> > Can you ensure the commit message text is line wrapped at approx > 72 characters. > Noted, Thanks. Just to confirm, you are claiming both copyright ownership for Red Hat > *and* personal copyright ownership ? > I just made some enquiry and given that this was developed inside of work context

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

Hi On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both > an audio sink and source. This backend is available on most systems. > Hmm, I would rather have less audio (and ui) backends in QEMU. (for audio, if I co

Re: [PATCH V2 06/10] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table

On Mon, Feb 13, 2023 at 08:10:34PM +0530, Sunil V L wrote: > RISC-V ACPI platforms need to provide RISC-V Hart Capabilities > Table (RHCT). Add this to the ACPI tables. > > Signed-off-by: Sunil V L > --- > hw/riscv/virt-acpi-build.c | 62 ++ > 1 file changed,

Re: [PATCH V2 07/10] hw/riscv: meson.build: Build virt-acpi-build.c

On Mon, Feb 13, 2023 at 08:10:35PM +0530, Sunil V L wrote: > ACPI functions are defined in new file virt-acpi-build.c. Enable > it to be built as part of virt machine if CONFIG_ACPI is set. > > Signed-off-by: Sunil V L > Reviewed-by: Bin Meng > --- > hw/riscv/meson.build | 1 + > 1 file changed

Re: [PATCH V2 09/10] hw/riscv/virt.c: Initialize the ACPI tables

On Mon, Feb 13, 2023 at 08:10:37PM +0530, Sunil V L wrote: > When the "acpi=on", ACPI tables need to be added. Detect the option > and initialize the ACPI tables. > > Signed-off-by: Sunil V L > Reviewed-by: Bin Meng > --- > hw/riscv/virt.c | 4 > 1 file changed, 4 insertions(+) > > diff -

Re: [PATCH V2 08/10] hw/riscv/Kconfig: virt: Enable ACPI config option

On Mon, Feb 13, 2023 at 08:10:36PM +0530, Sunil V L wrote: > Enable ACPI related config option to build ACPI subsystem > for virt machine. > > Signed-off-by: Sunil V L > --- > hw/riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig > index 4

[PATCH v5 10/16] iotests: add some missed checks of qmp result

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041| 1 + tests/qemu-iotests/151| 1 + tests/qemu-iotests/152| 2 ++ tests/qemu-iotests/tests/migrate-bitmaps-test | 2 ++ 4 files changed, 6 insertions(+) d

[PATCH v5 06/16] python: rename QEMUMonitorProtocol.cmd() to cmd_raw()

Having cmd() and command() methods in one class doesn't look good. Rename cmd() to cmd_raw(), to show its meaning better. We also want to rename command() to cmd() in future, so this commit is a necessary step. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/machine/machine.py | 2 +

[PATCH v5 08/16] python/machine.py: upgrade vm.cmd() method

The method is not popular in iotests, we prefer use vm.qmp() and then check success by hand.. But that's not optimal. To simplify movement to vm.cmd() let's support same interface improvements like in vm.qmp(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/machine/machine.py | 12 +

[PATCH v5 01/16] python: fix superfluous-parens pylint error

Now make check-dev called in python/ directory fails due to this error. Let's fix it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/protocol.py| 2 +- python/qemu/qmp/qmp_client.py | 2 +- tests/qemu-iotests/tests/migrate-bit

[PATCH v5 07/16] python/qemu: rename command() to cmd()

Use a shorter name. We are going to move in iotests from qmp() to command() where possible. But command() is longer than qmp() and don't look better. Let's rename. You can simply grep for '\.command(' and for 'def command(' to check that everything is updated (command() in tests/docker/docker.py i

[PATCH v5 14/16] iotests.py: pause_job(): drop return value

The returned value is unused. It's simple to check by command git grep -B 3 '\.pause_job(' Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iote

[PATCH v5 02/16] python: fix broad-exception-raised pylint error

Now 'make check-dev' called in python/ directory raises several W0719: Raising too general exception: Exception (broad-exception-raised) Let's fix. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/utils/qemu_ga_client.py | 6 +++--- tests/qemu-iotests/iotests.py | 4 ++-- 2 fi

[PATCH v5 15/16] tests/vm/basevm.py: use cmd() instead of qmp()

We don't expect failure here and need 'result' object. cmd() is better in this case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/vm/basevm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 23229e23d1..e61f9f0fd1 100

[PATCH v5 11/16] iotests: refactor some common qmp result checks into generic pattern

To simplify further conversion. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/040 | 3 ++- tests/qemu-iotests/147 | 3 ++- tests/qemu-iotests/155 | 4 ++-- tests/qemu-iotests/218 | 4 ++-- tests/qemu-iotests/296 | 3 ++- 5 files changed, 10 insertions(+), 7 deletions(-) dif

[PATCH v5 00/16] iotests: use vm.cmd()

Hi all! Let's get rid of pattern result = self.vm.qmp(...) self.assert_qmp(result, 'return', {}) And switch to just self.vm.cmd(...) v5: - include fixups by John - fix 'make check-dev' - split first patch into several [Daniel] Vladimir Sementsov-Ogievskiy (16): python: fix supe

[PATCH v5 09/16] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine.

Add similar method for consistency. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 675fbaa1c3..8ef1c8a5d2 100644 --- a/test

[PATCH v5 05/16] scripts/cpu-x86-uarch-abi.py: use .command() instead of .cmd()

Here we don't expect a failure. In case on failure we'll crash on trying to access ['return']. Let's better use .command() that clearly raise on failure. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/cpu-x86-uarch-abi.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

[PATCH v5 12/16] iotests: drop some occasional semicolons

Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 2 +- tests/qemu-iotests/196 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 4d7a829b65..550e4dc391 100755 --- a/tests/qemu-iotests/041 +++ b/tests

[PATCH v5 04/16] qmp_shell.py: _fill_completion() use .command() instead of .cmd()

We just want to ignore failure, so we don't need low level .cmd(). This helps further renaming .command() to .cmd(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/qmp_shell.py | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/python/qemu/

[PATCH v5 03/16] python/qemu/qmp/legacy: cmd(): drop cmd_id unused argument

The argument is unused, let's drop it for now, as we are going to refactor the interface and don't want to refactor unused things. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/legacy.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/python/qemu/qmp/le

[PATCH v5 13/16] iotests: drop some extra ** in qmp() call

qmp() method supports passing dict (if it doesn't need substituting '_' to '-' in keys). So, drop some extra '**' operators. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/040| 4 +- tests/qemu-iotests/041| 14 +++--- tests/qem

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

"Michael S. Tsirkin" writes: > On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: >> >> Bernhard Beschow writes: >> >> >> >> > Am 22. Dezember 2022 10:03:23 UTC schrieb M

Re: [PATCH V2 10/10] MAINTAINERS: Add entry for RISC-V ACPI

On Mon, Feb 13, 2023 at 08:10:38PM +0530, Sunil V L wrote: > RISC-V ACPI related functionality for virt machine is added in > virt-acpi-build.c. Add the maintainer entry. > > Signed-off-by: Sunil V L > Reviewed-by: Bin Meng > Acked-by: Alistair Francis > --- > MAINTAINERS | 6 ++ > 1 file

Re: [PATCH v4 3/6] qapi: Add minor typing workaround for 3.6

Markus Armbruster writes: > John Snow writes: > >> Pylint under 3.6 does not believe that Collection is subscriptable at >> runtime. It is, making this a Pylint >> bug. https://github.com/PyCQA/pylint/issues/2377 >> >> They closed it as fixed, but that doesn't seem to be true as of Pylint >> 2.1

Re: [PATCH] tests/qtest/rtl8139-test: Make the test less verbose by default

Daniel P. Berrangé writes: > On Wed, Feb 15, 2023 at 01:41:22PM +0100, Thomas Huth wrote: >> We are facing the issues that some test logs in the gitlab CI are >> too big (and thus cut off). The rtl8139-test is one of the few qtests >> that prints many lines of output by default when running with

Re: [PATCH v4 0/6] qapi: static typing conversion, pt5c

I had a few suggestions, but none of them requires a respin. Let's discuss them, and then I merge.

Re: [PATCH v10 47/59] i386/xen: handle PV timer hypercalls

On Tue, 2023-02-14 at 10:10 +, Paul Durrant wrote: > There's a nasty little semantic subtlety here which has been missed... > If the guest is not in longmode then the timer value is actually split > across param[0] and param[1] (so that it is still 64-bits). I'll work this in. I should be ab

Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

Hi, > This commit breaks boot-serial-test on ppc64-softmmu. >> >> $ ./configure --enable-tcg-interpreter >> '--target-list=aarch64-softmmu alpha-softmmu arm-softmmu hppa-softmmu >> m68k-softmmu microblaze-softmmu ppc64-softmmu s390x-softmmu >> x86_64-softmmu' >> $ make && cd build && QTEST_QEM

Re: [PATCH v2 00/11] enable write_misa() and RISCV_FEATURE_* cleanups

On Tue, Feb 14, 2023 at 04:23:45PM -0300, Daniel Henrique Barboza wrote: > Hi, > > This new version contains suggestions made by Weiwei Li in v1. Most > notable change is patch 4 from v1, moving up to patch 2 now, to allow > the riscv_cpu_cfg() helper to be used in the MISA CSR patch. > > > Cha

Re: [PULL 00/22] qtest, s390x and misc patches

On Tue, 14 Feb 2023 at 11:21, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b: > > Merge tag 'migration-20230213-pull-request' of > https://gitlab.com/juan.quintela/qemu into staging (2023-02-13 11:54:05 +) > > are available

Re: [PATCH V2 08/10] hw/riscv/Kconfig: virt: Enable ACPI config option

On Wed, Feb 15, 2023 at 02:24:24PM +0100, Andrew Jones wrote: > On Mon, Feb 13, 2023 at 08:10:36PM +0530, Sunil V L wrote: > > Enable ACPI related config option to build ACPI subsystem > > for virt machine. > > > > Signed-off-by: Sunil V L > > --- > > hw/riscv/Kconfig | 1 + > > 1 file changed,

Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables

On Tue, Feb 14, 2023 at 05:44:44AM -0300, Daniel Henrique Barboza wrote: > > > On 2/14/23 00:43, Sunil V L wrote: > > On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote: > > Nah. Doing that now will make this series rely on acks for every other ACPI > arch to > push the RIS

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems. > > >

Re: [PATCH] tests/qtest/rtl8139-test: Make the test less verbose by default

On 15/02/2023 14.38, Fabiano Rosas wrote: Daniel P. Berrangé writes: On Wed, Feb 15, 2023 at 01:41:22PM +0100, Thomas Huth wrote: We are facing the issues that some test logs in the gitlab CI are too big (and thus cut off). The rtl8139-test is one of the few qtests that prints many lines of o

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

Hi On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck wrote: > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > > Hi > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as >

[PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

The meson log files can get very big, especially if running the tests in verbose mode. So dumping those logs to the console was a bad idea, since gitlab truncates the output if it is getting too big. Let's publish the logs as artifacts instead. This has the disadvantage that you have to look up the

Re: [PATCH RESEND 04/18] i386/cpu: Fix number of addressable IDs in CPUID.04H

On Wed, Feb 15, 2023 at 06:11:23PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 18:11:23 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 04/18] i386/cpu: Fix number of addressable IDs > in CPUID.04H > > Hi Zhao, > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu > > > >

Re: [PATCH RESEND 07/18] i386: Support modules_per_die in X86CPUTopoInfo

On Wed, Feb 15, 2023 at 06:38:31PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 18:38:31 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 07/18] i386: Support modules_per_die in > X86CPUTopoInfo > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhuocheng Ding > > > > Support modu

Re: [PATCH RESEND 09/18] i386: Fix comment style in topology.h

On Wed, Feb 15, 2023 at 06:54:15PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 18:54:15 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 09/18] i386: Fix comment style in topology.h > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu > > > > For function comments in this f

Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

On Wed, 15 Feb 2023 at 08:45, Qiang Liu wrote: > > Hi, >>> >>> This commit breaks boot-serial-test on ppc64-softmmu. >>> >>> $ ./configure --enable-tcg-interpreter >>> '--target-list=aarch64-softmmu alpha-softmmu arm-softmmu hppa-softmmu >>> m68k-softmmu microblaze-softmmu ppc64-softmmu s390x-so

Re: [PULL 00/10] Net patches

On 2/14/23 15:30, Peter Maydell wrote: On Tue, 14 Feb 2023 at 14:29, Peter Maydell wrote: On Tue, 14 Feb 2023 at 06:11, Jason Wang wrote: The following changes since commit f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b: Merge tag 'migration-20230213-pull-request' of https://gitlab.com/juan.

Re: [PATCH v4 3/6] qapi: Add minor typing workaround for 3.6

On Wed, Feb 15, 2023, 8:36 AM Markus Armbruster wrote: > Markus Armbruster writes: > > > John Snow writes: > > > >> Pylint under 3.6 does not believe that Collection is subscriptable at > >> runtime. It is, making this a Pylint > >> bug. https://github.com/PyCQA/pylint/issues/2377 > >> > >> The

Re: [PATCH v2] memory: Optimize replay of guest mapping

On Wed, Feb 15, 2023 at 02:52:38PM +0800, Zhenzhong Duan wrote: > On x86, there are two notifiers registered due to vtd-ir memory region > splitting the whole address space. During replay of the address space > for each notifier, the whole address space is scanned which is > unnecessory. > > We on

Re: [PATCH RESEND 10/18] i386: Update APIC ID parsing rule to support module level

On Wed, Feb 15, 2023 at 07:06:32PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 19:06:32 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 10/18] i386: Update APIC ID parsing rule to > support module level > > Hi Zhao, > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhuocheng Din

Re: [PULL 08/10] hw/net/can/xlnx-zynqmp-can: fix assertion failures in transfer_fifo()

Adding CAN bus maintainers. On 14/2/23 07:11, Jason Wang wrote: From: Qiang Liu Check fifos before poping data from and pushing data into it. Fixes: 98e5d7a2b726 ("hw/net/can: Introduce Xilinx ZynqMP CAN controller") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1425 Resolves: https

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

Hi Thomas, On 15/2/23 15:25, Thomas Huth wrote: The meson log files can get very big, especially if running the tests in verbose mode. So dumping those logs to the console was a bad idea, since gitlab truncates the output if it is getting too big. Let's publish the logs as artifacts instead. Thi

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote: > The meson log files can get very big, especially if running the tests in > verbose mode. So dumping those logs to the console was a bad idea, since > gitlab truncates the output if it is getting too big. Let's publish the > logs as arti

Re: [PATCH RESEND 14/18] i386: Add cache topology info in CPUCacheInfo

On Wed, Feb 15, 2023 at 08:17:22PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 20:17:22 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 14/18] i386: Add cache topology info in > CPUCacheInfo > > Hi Zhao, > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu > > > > Curren

Re: [PATCH RESEND 16/18] i386: Fix NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

On Wed, Feb 15, 2023 at 08:32:39PM +0800, wangyanan (Y) wrote: > Date: Wed, 15 Feb 2023 20:32:39 +0800 > From: "wangyanan (Y)" > Subject: Re: [PATCH RESEND 16/18] i386: Fix NumSharingCache for > CPUID[0x801D].EAX[bits 25:14] > > 在 2023/2/13 17:36, Zhao Liu 写道: > > From: Zhao Liu > > > > >F

Re: [PATCH v2 0/7] include/hw/pci include/hw/cxl: Clean up includes

On 15/2/23 14:28, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Fri, Dec 23, 2022 at 06:27:07AM +0100, Markus Armbruster wrote: "Michael S. Tsirkin" writes: On Thu, Dec 22, 2022 at 11:48:25AM +0100, Markus Armbruster wrote: Bernhard Beschow writes: Am 22. Dezember 2022 10:03

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

On Wed, Feb 15, 2023 at 06:11:12PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck > wrote: > > > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey > > > w

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

> > My point is that pipewire has ALSA plugin (and also pulseaudio compat > library etc). So why add another back in QEMU? > Good question. Well the pulseaudio compatibility layer adds to the runtime overhead and dependency, dropping the usage of pw-pulse daemon as a runtime dependency would reduce

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

> > What is the main advantage compared to using the ALSA backend? (I > > assume pipewire depends on ALSA anyway on Linux) > > I think it does make sense to add Pipewire. Apparently it gains popularity. > > The main advantage of Pipewire is its interoperability: It allows you to > connect apps w

Re: [PULL 00/10] xenpvh machine

On Tue, 2023-02-14 at 15:44 -0800, Stefano Stabellini wrote: > > Something weird has happened here -- I'm getting merge conflicts > > in files in migration/ and in tests/unit/test-xbzrle.c, even though > > your pullreq diffstat says it doesn't touch those files. Can you > > try a rebase and resend?

Does the page boundary check still necessary?

Hello, I hope I send this mail to the right place. I'm porting a new guest arch. It jumps of out of physical page constantly. So many TBs cannot be chained with goto_tb. I'm wondering if the following check is still necessary? bool translator_use_goto_tb(DisasContextBase *db, target_ulo

[PATCH 2/3] target/mips: fix SWM32 handling for micromips

SWM32 should store a sequence of 32-bit words from the GPRs, but it was incorrectly coded to store 16-bit words only. As a result, an LWM32 that usually follows would restore invalid register values. Signed-off-by: Marcin Nowakowski --- target/mips/tcg/ldst_helper.c | 4 ++-- 1 file changed, 2 i

[PATCH 0/3] target/mips: misc microMIPS fixes

Marcin Nowakowski (3): target/mips: fix JALS32/J32 instruction handling for microMIPS target/mips: fix SWM32 handling for micromips target/mips: implement CP0.Config7.WII bit support target/mips/cpu-defs.c.inc| 1 + target/mips/cpu.c | 6 -- target/mips/cpu.h

[PATCH 3/3] target/mips: implement CP0.Config7.WII bit support

Some older cores use CP0.Config7.WII bit to indicate that a disabled interrupt should wake up a sleeping CPU. Enable this bit by default for M14Kc, which supports that. There are potentially other cores that support this feature, but I do not have a complete list. Signed-off-by: Marcin Nowakowski

Re: [PATCH qemu 2/2] aspeed/fuji : correct the eeprom size

Hi, Follow the question " Could you please specify the size in bytes ? " Yes, In the source code we need to set the size value as byte. I add "divide by 8" to convert it to bytes unit. 24c64 size is 64kbit = 64k / 8 bytes -aspeed_eeprom_init(i2c[65], 0x53, 64 * KiB); +aspeed_eeprom_

Re: CXL 2.0 memory pooling emulation

On Wed, 8 Feb 2023 16:28:44 -0600 zhiting zhu wrote: > Hi, > > I saw a PoC: > https://lore.kernel.org/qemu-devel/20220525121422.3...@huawei.com/T/ to > implement memory pooling and fabric manager on qemu. Is there any further > development on this? Can qemu emulate a memory pooling on a simp

[PATCH 1/3] target/mips: fix JALS32/J32 instruction handling for microMIPS

microMIPS J & JAL instructions perform a jump in a 128MB region and 5 top bits of the address need to be preserved. This is different behavior compared to standard mips systems, where the jump is executed within a 256MB region. Note that microMIPS32 instruction set documentation appears to have inc

[PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

pci_device.h is not needed at all in allwinner-a10.h, and serial.h is only needed by the corresponding .c file. Signed-off-by: Thomas Huth --- include/hw/arm/allwinner-a10.h | 2 -- hw/arm/allwinner-a10.c | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/arm

[PATCH] accel/xen: Remove dead code

Unused since introduction in commit 04b0de0ee8 ("xen: factor out common functions"). Signed-off-by: Philippe Mathieu-Daudé --- accel/xen/xen-all.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 69aa7d018b..c1b697a8bd 100644 --- a/ac

[PATCH] migration/block: Convert remaining DPRINTF() debug macro to trace events

Finish the conversion from commit fe80c0241d ("migration: using trace_ to replace DPRINTF"). Signed-off-by: Philippe Mathieu-Daudé --- migration/block.c | 12 +--- migration/trace-events | 1 + 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/migration/block.c b/migr

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On 15/02/2023 15.58, Daniel P. Berrangé wrote: On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote: The meson log files can get very big, especially if running the tests in verbose mode. So dumping those logs to the console was a bad idea, since gitlab truncates the output if it is getti

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On Wed, Feb 15, 2023 at 04:33:42PM +0100, Thomas Huth wrote: > On 15/02/2023 15.58, Daniel P. Berrangé wrote: > > On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote: > > > The meson log files can get very big, especially if running the tests in > > > verbose mode. So dumping those logs to

Re: [PATCH 14/20] hw/ide: Rename ide_init2() -> ide_bus_init_output_irq()

On 15/2/23 12:27, Philippe Mathieu-Daudé wrote: ide_init2() initializes a IDEBus, and set its output IRQ. s/set/sets/ To emphasize this, rename it as ide_bus_init_output_irq(). Mechanical change using: $ sed -i -e 's/ide_init2/ide_bus_init_output_irq/g' \ $(git grep -l ide_init2

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On 15/02/2023 15.57, Philippe Mathieu-Daudé wrote: Hi Thomas, On 15/2/23 15:25, Thomas Huth wrote: The meson log files can get very big, especially if running the tests in verbose mode. So dumping those logs to the console was a bad idea, since gitlab truncates the output if it is getting too b

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

> > Are there any additional features available when using the pipewire > protocol instead of pulseaudio or jack? yes, Pipewire supports both use cases, It is more or less a hybrid between pulseaudio and jack. Pipewire uses a much more accurate timing model for timer based scheduling. Pipewire pr

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On 15/2/23 16:45, Thomas Huth wrote: On 15/02/2023 15.57, Philippe Mathieu-Daudé wrote: Hi Thomas, On 15/2/23 15:25, Thomas Huth wrote: The meson log files can get very big, especially if running the tests in verbose mode. So dumping those logs to the console was a bad idea, since gitlab trunc

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > > both an audio sink and source. This backend is available on most systems. > > >

Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

On 2/15/23 14:45, Qiang Liu wrote: Hi, This commit breaks boot-serial-test on ppc64-softmmu.   $ ./configure --enable-tcg-interpreter '--target-list=aarch64-softmmu alpha-softmmu arm-softmmu hppa-softmmu m68k-softmmu microblaze-softmmu ppc64-softmmu s390x-softmm

[PATCH v2 00/18] hw/ide: Untangle ISA/PCI abuses of ide_init_ioport()

Background thread: https://lore.kernel.org/qemu-devel/5095dffc-309b-6c72-d255-8cdaa6fd3...@ilande.co.uk/ This series: - contains few ISA cleanups - exposes PIIX IDE output IRQs and wires them in parent (PC/Malta) - renames the current ide_init_ioport() as ide_init_ioport_isa() - adds a generic ide

[PATCH v2 03/18] hw: Replace isa_get_irq() by isa_bus_get_irq() when ISABus is available

Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/cs4231a.c | 5 +++-- hw/audio/gus.c | 5 +++-- hw/audio/sb16.c | 7 --- hw/block/fdc-isa.c | 5 +++-- include/hw/timer/i8254.h | 3 ++- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/audio/c

[PATCH v2 02/18] hw/isa: Factor isa_bus_get_irq() out of isa_get_irq()

isa_get_irq() was added in commit 3a38d437ca ("Add isa_reserve_irq()" Fri Aug 14 11:36:15 2009) as: a temporary interface to be used to allocate ISA IRQs for devices which have not yet been converted to qdev, and for special cases which are not suited for qdev conversions, such as

[PATCH v2 06/18] hw/isa/piix4: Wire PIIX4 IDE ouput IRQs to ISA bus IRQs 14/15

piix4_realize() initialized an array of 16 ISA IRQs in PIIX4State::isa[], use it to wire the IDE output IRQs. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index de60ceef73..94e5dc7825 100644 --- a/h

[PATCH v2 09/18] hw/isa: Simplify isa_address_space[_io]()

We don't have any caller passing a NULL device argument, so we can simplify, avoiding to access the global 'isabus'. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c

[PATCH v2 05/18] hw/i386/pc_piix: Wire PIIX3 IDE ouput IRQs to ISA bus IRQs 14/15

Since pc_init1() has access to the ISABus*, retrieve the ISA IRQs with isa_bus_get_irq(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7085b4bc58..983baf0211 1006

[PATCH v2 01/18] hw/isa: Rename isa_get_dma() -> isa_bus_get_dma()

isa_get_dma() returns a DMA channel handler from an ISABus. To emphasize this, rename it as isa_bus_get_dma(). Mechanical change using: $ sed -i -e 's/isa_get_dma/isa_bus_get_dma/g' \ $(git grep -l isa_get_dma) Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/cs4231a.c | 2 +- hw

[PATCH v2 12/18] hw/ide: Rename ISA specific ide_init_ioport -> ide_bus_init_ioport_isa

Rename ide_init_ioport() as ide_bus_init_ioport_isa() to make explicit it expects an ISA device. Move the declaration to "hw/ide/isa.h" where it belongs. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ioport.c | 4 +++- hw/ide/isa.c | 2 +-

[PATCH v2 17/18] hw/isa: Un-inline isa_bus_from_device()

No point in inlining isa_bus_from_device() which is only used at device realization time. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 5 + include/hw/isa/isa.h | 6 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i

[PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

Ensure both IDE output IRQ lines are wired. We can remove the last use of isa_get_irq(NULL). Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/piix.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 9d876dd4a7..b75a4ddcca 10064

[PATCH v2 18/18] hw/isa: Remove empty ISADeviceClass structure

ISADeviceClass is an empty class and just increase code complexity. Remove it, directly embedding DeviceClass in classes expanding TYPE_ISA_DEVICE. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 1 - hw/rtc/m48t59-isa.c | 2 +- include/hw/isa/i8259_in

[PATCH v2 15/18] hw/isa: Ensure isa_register_portio_list() do not get NULL ISA device

Previous commit removed the single call to isa_register_portio_list() with dev=NULL. To be sure we won't reintroduce such weird (ab)use, assert dev is non-NULL. We can now calls isa_address_space_io() to get the device I/O region. Note we can then remove the NULL check in isa_init_ioport() becaus

Re: [RFC PATCH 01/16] hw/arm/smmuv3: Add missing fields for IDR0

Hi Mostafa, On 2/5/23 10:43, Mostafa Saleh wrote: > In preparation for adding stage-2 support. > Add IDR0 fields related to stage-2. > > VMID16: 16-bit VMID supported. > S2P: Stage-2 translation supported. > > They are described in 6.3.1 SMMU_IDR0. > > No functional change intended. > > Signed-off

[PATCH v2 14/18] hw/ide/piix: Use generic ide_bus_init_ioport()

TYPE_PIIX3_IDE is a PCI function inheriting from QOM TYPE_PCI_DEVICE. To be able to call the ISA specific ide_init_ioport_isa(), we call this function passing a NULL ISADevice argument. Remove this hack by calling the recently added generic ide_init_ioport(), which doesn't expect any ISADevice. In

[PATCH v2 08/18] hw/isa: Deprecate isa_get_irq() in favor of isa_bus_get_irq()

Last commit removed the last use of isa_get_irq(NULL). Add an assertion to ensure we won't use that hack again. Deprecate in favor of the BUS API: isa_bus_get_irq(). Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 6 +++--- include/hw/isa/isa.h | 4 +++- 2 files changed, 6 inser

[PATCH v2 10/18] hw/isa: Use isa_address_space_io() in isa_register_ioport()

We don't have any caller passing a NULL device argument, so we can simplify, avoiding to access the global 'isabus'. (Since the previous commit, isa_address_space_io() assert the device argument is not NULL). Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/isa-bus.c | 2 +- 1 file changed, 1

[PATCH v2 16/18] hw/isa: Reduce 'isabus' singleton scope to isa_bus_new()

Previous commit ensured when entering isa_register_portio_list(), 'dev' is not NULL. Being a TYPE_ISA_DEVICE, the device must sit on a ISA bus. This means isa_bus_new() as already been called and 'isabus' can not be NULL. Simplify by removing the 'isabus' NULL check in isa_register_portio_list().

[PATCH v2 13/18] hw/ide: Introduce generic ide_init_ioport()

Add ide_init_ioport() which is not restricted to the ISA bus. (Next commit will use it for a PCI device). Inspired-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ioport.c | 12 ++-- include/hw/ide/internal.h | 2 ++ 2 fil

[PATCH v2 04/18] hw/ide/piix: Expose output IRQ as properties for late object population

Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/piix.c | 14 -- include/hw/ide/pci.h | 1 + include/hw/ide/piix.h | 4 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 41d60921e3..9d876dd4a7 100644 --- a/hw/ide/piix.c

[PATCH v2 11/18] hw/ide: Declare ide_get_[geometry/bios_chs_trans] in 'hw/ide/internal.h'

ide_get_geometry() and ide_get_bios_chs_trans() are only used by the TYPE_PC_MACHINE. "hw/ide.h" is a mixed bag of lost IDE declarations. In order to remove this (almost) pointless header soon, move these declarations to "hw/ide/internal.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c

Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs

On Wed, 15 Feb 2023 at 15:33, Thomas Huth wrote: > > On 15/02/2023 15.58, Daniel P. Berrangé wrote: > > On Wed, Feb 15, 2023 at 03:25:03PM +0100, Thomas Huth wrote: > >> The meson log files can get very big, especially if running the tests in > >> verbose mode. So dumping those logs to the console

Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

On 2/15/23 15:34, Stefan Hajnoczi wrote: On Wed, 15 Feb 2023 at 08:45, Qiang Liu wrote: Hi, This commit breaks boot-serial-test on ppc64-softmmu. $ ./configure --enable-tcg-interpreter '--target-list=aarch64-softmmu alpha-softmmu arm-softmmu hppa-softmmu m68k-softmmu microblaze-softmmu p

Re: [RFC PATCH 04/16] hw/arm/smmuv3: Add a system property to choose translation stage

Hi, On 2/5/23 10:43, Mostafa Saleh wrote: > Add a new system property for smmuv3 to choose what translation > stages to advertise. > > The property added arm-smmuv3.stage can have 3 values: > - "1": Stage-1 is only advertised. Stage-1 only is advertised > - "2": Stage-2 is only advertised. > - "al

Re: [PATCH] migration/block: Convert remaining DPRINTF() debug macro to trace events

Philippe Mathieu-Daudé wrote: > Finish the conversion from commit fe80c0241d > ("migration: using trace_ to replace DPRINTF"). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela queued. Thanks.

Re: [RFC PATCH 05/16] hw/arm/smmuv3: Add page table walk for stage-2

Hi Mostafa, On 2/5/23 10:44, Mostafa Saleh wrote: > In preparation for adding stage-2 support. Add Stage-2 PTW code. > Only Aarch64 fromat is supported as stage-1. format > Max 48 bits IPA is supported. > > Nesting stage-1 and stage-2 is not supported right now. > > Signed-off-by: Mostafa Saleh >

Re: [RFC PATCH 03/16] hw/arm/smmuv3: Rename smmu_ptw_64

On 2/5/23 10:43, Mostafa Saleh wrote: > In preparation for adding stage-2 support. Rename smmu_ptw_64 to > smmu_ptw_64_s1. > > No functional change intended. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > dif

Re: [RFC v5 0/3] migration: reduce time of loading non-iterable vmstate

Chuang Xu wrote: > In this version: > > - rename rcu_read_locked() to rcu_read_is_locked(). > - adjust the sanity check in address_space_to_flatview(). > - improve some comments. queued series. > > The duration of loading non-iterable vmstate accounts for a significant > portion of downtime (sta

<    1   2   3   4   5   6   >